[INFO] cloning repository https://github.com/Sherif-Abdou/basic-algebra [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/Sherif-Abdou/basic-algebra" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FSherif-Abdou%2Fbasic-algebra", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FSherif-Abdou%2Fbasic-algebra'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 68f7850565c1d8a03512daa152434c4333c93b4a [INFO] checking Sherif-Abdou/basic-algebra against try#3f7b27fe41ccd116a4c0829bd9a14b65bada4578 for pr-96970 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FSherif-Abdou%2Fbasic-algebra" "/workspace/builds/worker-7/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-7/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/Sherif-Abdou/basic-algebra on toolchain 3f7b27fe41ccd116a4c0829bd9a14b65bada4578 [INFO] running `Command { std: "/workspace/cargo-home/bin/cargo" "+3f7b27fe41ccd116a4c0829bd9a14b65bada4578" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/Sherif-Abdou/basic-algebra [INFO] finished tweaking git repo https://github.com/Sherif-Abdou/basic-algebra [INFO] tweaked toml for git repo https://github.com/Sherif-Abdou/basic-algebra written to /workspace/builds/worker-7/source/Cargo.toml [INFO] crate git repo https://github.com/Sherif-Abdou/basic-algebra already has a lockfile, it will not be regenerated [INFO] running `Command { std: "/workspace/cargo-home/bin/cargo" "+3f7b27fe41ccd116a4c0829bd9a14b65bada4578" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d190cb871061d98bc6d0581d85cb2ecb09a0f8a142ba5463de30be9999fc3251" "/opt/rustwide/cargo-home/bin/cargo" "+3f7b27fe41ccd116a4c0829bd9a14b65bada4578" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 88c860cb9abb9dd5a578e5d97b8463509b389ff4ccae28babc44925d0443a40e [INFO] running `Command { std: "docker" "start" "-a" "88c860cb9abb9dd5a578e5d97b8463509b389ff4ccae28babc44925d0443a40e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "88c860cb9abb9dd5a578e5d97b8463509b389ff4ccae28babc44925d0443a40e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "88c860cb9abb9dd5a578e5d97b8463509b389ff4ccae28babc44925d0443a40e", kill_on_drop: false }` [INFO] [stdout] 88c860cb9abb9dd5a578e5d97b8463509b389ff4ccae28babc44925d0443a40e [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d190cb871061d98bc6d0581d85cb2ecb09a0f8a142ba5463de30be9999fc3251" "/opt/rustwide/cargo-home/bin/cargo" "+3f7b27fe41ccd116a4c0829bd9a14b65bada4578" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 073b25f65c2327f48afa6289bc488f8d04650074c6b09782e4f01e7fa8bb2e54 [INFO] running `Command { std: "docker" "start" "-a" "073b25f65c2327f48afa6289bc488f8d04650074c6b09782e4f01e7fa8bb2e54", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Compiling memchr v2.3.3 [INFO] [stderr] Checking lazy_static v1.4.0 [INFO] [stderr] Checking regex-syntax v0.6.18 [INFO] [stderr] Checking thread_local v1.0.1 [INFO] [stderr] Checking aho-corasick v0.7.10 [INFO] [stderr] Checking regex v1.3.9 [INFO] [stderr] Checking algebra v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `std::borrow::Borrow` [INFO] [stdout] --> src/equation_solver.rs:2:5 [INFO] [stdout] | [INFO] [stdout] 2 | use std::borrow::Borrow; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/equation_solver.rs:77:32 [INFO] [stdout] | [INFO] [stdout] 77 | let new_left_side = if (!flip) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 77 - let new_left_side = if (!flip) { [INFO] [stdout] 77 + let new_left_side = if !flip { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::borrow::Borrow` [INFO] [stdout] --> src/equation_solver.rs:2:5 [INFO] [stdout] | [INFO] [stdout] 2 | use std::borrow::Borrow; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/equation_solver.rs:101:19 [INFO] [stdout] | [INFO] [stdout] 101 | return if (!flip) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 101 - return if (!flip) { [INFO] [stdout] 101 + return if !flip { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `crate::equation::*` [INFO] [stdout] --> src/main.rs:7:5 [INFO] [stdout] | [INFO] [stdout] 7 | use crate::equation::*; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around assigned value [INFO] [stdout] --> src/main.rs:50:26 [INFO] [stdout] | [INFO] [stdout] 50 | let values = (*box_tuple.clone()); [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 50 - let values = (*box_tuple.clone()); [INFO] [stdout] 50 + let values = *box_tuple.clone(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around assigned value [INFO] [stdout] --> src/main.rs:58:26 [INFO] [stdout] | [INFO] [stdout] 58 | let values = (*box_tuple.clone()); [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 58 - let values = (*box_tuple.clone()); [INFO] [stdout] 58 + let values = *box_tuple.clone(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/equation_solver.rs:77:32 [INFO] [stdout] | [INFO] [stdout] 77 | let new_left_side = if (!flip) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 77 - let new_left_side = if (!flip) { [INFO] [stdout] 77 + let new_left_side = if !flip { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around assigned value [INFO] [stdout] --> src/main.rs:66:26 [INFO] [stdout] | [INFO] [stdout] 66 | let values = (*box_tuple.clone()); [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 66 - let values = (*box_tuple.clone()); [INFO] [stdout] 66 + let values = *box_tuple.clone(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/equation_solver.rs:101:19 [INFO] [stdout] | [INFO] [stdout] 101 | return if (!flip) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 101 - return if (!flip) { [INFO] [stdout] 101 + return if !flip { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around assigned value [INFO] [stdout] --> src/main.rs:74:26 [INFO] [stdout] | [INFO] [stdout] 74 | let values = (*box_tuple.clone()); [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 74 - let values = (*box_tuple.clone()); [INFO] [stdout] 74 + let values = *box_tuple.clone(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `crate::equation::*` [INFO] [stdout] --> src/main.rs:7:5 [INFO] [stdout] | [INFO] [stdout] 7 | use crate::equation::*; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around assigned value [INFO] [stdout] --> src/main.rs:50:26 [INFO] [stdout] | [INFO] [stdout] 50 | let values = (*box_tuple.clone()); [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 50 - let values = (*box_tuple.clone()); [INFO] [stdout] 50 + let values = *box_tuple.clone(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around assigned value [INFO] [stdout] --> src/main.rs:58:26 [INFO] [stdout] | [INFO] [stdout] 58 | let values = (*box_tuple.clone()); [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 58 - let values = (*box_tuple.clone()); [INFO] [stdout] 58 + let values = *box_tuple.clone(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around assigned value [INFO] [stdout] --> src/main.rs:66:26 [INFO] [stdout] | [INFO] [stdout] 66 | let values = (*box_tuple.clone()); [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 66 - let values = (*box_tuple.clone()); [INFO] [stdout] 66 + let values = *box_tuple.clone(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around assigned value [INFO] [stdout] --> src/main.rs:74:26 [INFO] [stdout] | [INFO] [stdout] 74 | let values = (*box_tuple.clone()); [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 74 - let values = (*box_tuple.clone()); [INFO] [stdout] 74 + let values = *box_tuple.clone(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/equation_solver.rs:19:13 [INFO] [stdout] | [INFO] [stdout] 19 | let mut variable_path = self.get_variable_path()?; [INFO] [stdout] | ----^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/equation_solver.rs:19:13 [INFO] [stdout] | [INFO] [stdout] 19 | let mut variable_path = self.get_variable_path()?; [INFO] [stdout] | ----^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/main.rs:37:9 [INFO] [stdout] | [INFO] [stdout] 37 | let mut new_eq_result = solver.solve_step(); [INFO] [stdout] | ----^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/main.rs:37:9 [INFO] [stdout] | [INFO] [stdout] 37 | let mut new_eq_result = solver.solve_step(); [INFO] [stdout] | ----^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/main.rs:102:13 [INFO] [stdout] | [INFO] [stdout] 102 | let mut equation = equation::Equation::from_tokens(tokens); [INFO] [stdout] | ----^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/main.rs:108:13 [INFO] [stdout] | [INFO] [stdout] 108 | let mut solver = [INFO] [stdout] | ----^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/main.rs:102:13 [INFO] [stdout] | [INFO] [stdout] 102 | let mut equation = equation::Equation::from_tokens(tokens); [INFO] [stdout] | ----^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/main.rs:108:13 [INFO] [stdout] | [INFO] [stdout] 108 | let mut solver = [INFO] [stdout] | ----^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 12 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 12 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 7.13s [INFO] running `Command { std: "docker" "inspect" "073b25f65c2327f48afa6289bc488f8d04650074c6b09782e4f01e7fa8bb2e54", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "073b25f65c2327f48afa6289bc488f8d04650074c6b09782e4f01e7fa8bb2e54", kill_on_drop: false }` [INFO] [stdout] 073b25f65c2327f48afa6289bc488f8d04650074c6b09782e4f01e7fa8bb2e54