[INFO] cloning repository https://github.com/rcurtis/hexagonal [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/rcurtis/hexagonal" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Frcurtis%2Fhexagonal", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Frcurtis%2Fhexagonal'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 31f71ed4be9904aa0b8eb969dbdd69b6facc6917 [INFO] checking rcurtis/hexagonal against master#936f2600b6c903b04387f74ed5cbce88bb06d243 for pr-91141 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Frcurtis%2Fhexagonal" "/workspace/builds/worker-35/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-35/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/rcurtis/hexagonal on toolchain 936f2600b6c903b04387f74ed5cbce88bb06d243 [INFO] running `Command { std: "/workspace/cargo-home/bin/cargo" "+936f2600b6c903b04387f74ed5cbce88bb06d243" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/rcurtis/hexagonal [INFO] finished tweaking git repo https://github.com/rcurtis/hexagonal [INFO] tweaked toml for git repo https://github.com/rcurtis/hexagonal written to /workspace/builds/worker-35/source/Cargo.toml [INFO] crate git repo https://github.com/rcurtis/hexagonal already has a lockfile, it will not be regenerated [INFO] running `Command { std: "/workspace/cargo-home/bin/cargo" "+936f2600b6c903b04387f74ed5cbce88bb06d243" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-35/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-35/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:5736fa189c1c60b01babf4b8b698fe57b6ecc41933a7ff2e0b8d7a221459412b" "/opt/rustwide/cargo-home/bin/cargo" "+936f2600b6c903b04387f74ed5cbce88bb06d243" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] c7a6dba75bcce4485cec60c9818799b3a8535544404a2d76dc700cac10f4098f [INFO] running `Command { std: "docker" "start" "-a" "c7a6dba75bcce4485cec60c9818799b3a8535544404a2d76dc700cac10f4098f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "c7a6dba75bcce4485cec60c9818799b3a8535544404a2d76dc700cac10f4098f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "c7a6dba75bcce4485cec60c9818799b3a8535544404a2d76dc700cac10f4098f", kill_on_drop: false }` [INFO] [stdout] c7a6dba75bcce4485cec60c9818799b3a8535544404a2d76dc700cac10f4098f [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-35/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-35/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:5736fa189c1c60b01babf4b8b698fe57b6ecc41933a7ff2e0b8d7a221459412b" "/opt/rustwide/cargo-home/bin/cargo" "+936f2600b6c903b04387f74ed5cbce88bb06d243" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 0225036a0f5617e43d44e680511168f47e90ec972e9e9ef08fa2136e9a340355 [INFO] running `Command { std: "docker" "start" "-a" "0225036a0f5617e43d44e680511168f47e90ec972e9e9ef08fa2136e9a340355", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Compiling libc v0.2.101 [INFO] [stderr] Checking cfg-if v1.0.0 [INFO] [stderr] Compiling version_check v0.9.3 [INFO] [stderr] Compiling autocfg v1.0.1 [INFO] [stderr] Compiling unicode-xid v0.2.2 [INFO] [stderr] Compiling syn v1.0.76 [INFO] [stderr] Checking tinyvec_macros v0.1.0 [INFO] [stderr] Compiling memchr v2.4.1 [INFO] [stderr] Compiling serde_derive v1.0.130 [INFO] [stderr] Compiling log v0.4.14 [INFO] [stderr] Checking matches v0.1.9 [INFO] [stderr] Compiling cc v1.0.70 [INFO] [stderr] Compiling crc32fast v1.2.1 [INFO] [stderr] Checking percent-encoding v2.1.0 [INFO] [stderr] Compiling ryu v1.0.5 [INFO] [stderr] Compiling httparse v1.5.1 [INFO] [stderr] Compiling serde v1.0.130 [INFO] [stderr] Checking unicode-bidi v0.3.6 [INFO] [stderr] Checking mime v0.3.16 [INFO] [stderr] Compiling serde_json v1.0.67 [INFO] [stderr] Checking remove_dir_all v0.5.3 [INFO] [stderr] Checking chunked_transfer v1.4.0 [INFO] [stderr] Checking adler32 v1.2.0 [INFO] [stderr] Checking itoa v0.4.8 [INFO] [stderr] Checking base64 v0.13.0 [INFO] [stderr] Checking time v0.3.2 [INFO] [stderr] Compiling proc-macro2 v1.0.29 [INFO] [stderr] Compiling num-traits v0.2.14 [INFO] [stderr] Compiling num-integer v0.1.44 [INFO] [stderr] Checking form_urlencoded v1.0.1 [INFO] [stderr] Compiling unicase v2.6.0 [INFO] [stderr] Checking tinyvec v1.3.1 [INFO] [stderr] Compiling brotli-sys v0.3.2 [INFO] [stderr] Compiling quote v1.0.9 [INFO] [stderr] Checking gzip-header v0.3.0 [INFO] [stderr] Checking getrandom v0.2.3 [INFO] [stderr] Checking time v0.1.43 [INFO] [stderr] Checking num_cpus v1.13.0 [INFO] [stderr] Checking filetime v0.2.15 [INFO] [stderr] Checking buf_redux v0.8.4 [INFO] [stderr] Checking twoway v0.1.8 [INFO] [stderr] Checking rand_core v0.6.3 [INFO] [stderr] Checking unicode-normalization v0.1.19 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Compiling mime_guess v2.0.3 [INFO] [stderr] Checking threadpool v1.8.1 [INFO] [stderr] Checking deflate v0.9.1 [INFO] [stderr] Checking chrono v0.4.19 [INFO] [stderr] Checking rand v0.8.4 [INFO] [stderr] Checking idna v0.2.3 [INFO] [stderr] Checking tempfile v3.2.0 [INFO] [stderr] Checking url v2.2.2 [INFO] [stderr] Checking brotli2 v0.3.2 [INFO] [stderr] Checking multipart v0.18.0 [INFO] [stderr] Checking tiny_http v0.8.2 [INFO] [stderr] Checking rouille v3.3.0 [INFO] [stderr] Checking hexagonal v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `InMemoryRepository` [INFO] [stdout] --> src/domain/create_pokemon.rs:2:36 [INFO] [stdout] | [INFO] [stdout] 2 | use crate::repositories::pokemon::{InMemoryRepository, Repository, InsertError}; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::fmt::Error` [INFO] [stdout] --> src/domain/entities.rs:2:5 [INFO] [stdout] | [INFO] [stdout] 2 | use std::fmt::Error; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `InMemoryRepository` [INFO] [stdout] --> src/domain/fetch_all_pokemon.rs:1:36 [INFO] [stdout] | [INFO] [stdout] 1 | use crate::repositories::pokemon::{InMemoryRepository, Repository, FetchAllError}; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `crate::domain::entities::Pokemon` [INFO] [stdout] --> src/domain/fetch_all_pokemon.rs:3:5 [INFO] [stdout] | [INFO] [stdout] 3 | use crate::domain::entities::Pokemon; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Pokemon` [INFO] [stdout] --> src/domain/fetch_pokemon.rs:1:46 [INFO] [stdout] | [INFO] [stdout] 1 | use crate::domain::entities::{PokemonNumber, Pokemon}; [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Pokemon` [INFO] [stdout] --> src/domain/delete_pokemon.rs:1:46 [INFO] [stdout] | [INFO] [stdout] 1 | use crate::domain::entities::{PokemonNumber, Pokemon}; [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `FetchOneError` [INFO] [stdout] --> src/domain/delete_pokemon.rs:3:48 [INFO] [stdout] | [INFO] [stdout] 3 | use crate::repositories::pokemon::{Repository, FetchOneError, DeleteError}; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `InMemoryRepository` [INFO] [stdout] --> src/api/mod.rs:1:36 [INFO] [stdout] | [INFO] [stdout] 1 | use crate::repositories::pokemon::{InMemoryRepository, Repository}; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `crate::domain::entities::PokemonNumber` [INFO] [stdout] --> src/api/fetch_pokemon.rs:5:5 [INFO] [stdout] | [INFO] [stdout] 5 | use crate::domain::entities::PokemonNumber; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `crate::domain::fetch_pokemon::Error` [INFO] [stdout] --> src/api/fetch_pokemon.rs:7:5 [INFO] [stdout] | [INFO] [stdout] 7 | use crate::domain::fetch_pokemon::Error; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `serde::Serialize` [INFO] [stdout] --> src/api/delete_pokemon.rs:2:5 [INFO] [stdout] | [INFO] [stdout] 2 | use serde::Serialize; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `crate::domain::entities::PokemonNumber` [INFO] [stdout] --> src/api/delete_pokemon.rs:5:5 [INFO] [stdout] | [INFO] [stdout] 5 | use crate::domain::entities::PokemonNumber; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::fmt::Error` [INFO] [stdout] --> src/domain/entities.rs:2:5 [INFO] [stdout] | [INFO] [stdout] 2 | use std::fmt::Error; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `crate::domain::entities::Pokemon` [INFO] [stdout] --> src/domain/fetch_all_pokemon.rs:3:5 [INFO] [stdout] | [INFO] [stdout] 3 | use crate::domain::entities::Pokemon; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Pokemon` [INFO] [stdout] --> src/domain/fetch_pokemon.rs:1:46 [INFO] [stdout] | [INFO] [stdout] 1 | use crate::domain::entities::{PokemonNumber, Pokemon}; [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Pokemon` [INFO] [stdout] --> src/domain/fetch_pokemon.rs:41:35 [INFO] [stdout] | [INFO] [stdout] 41 | use crate::domain::entities::{Pokemon, PokemonTypes, PokemonName}; [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Pokemon` [INFO] [stdout] --> src/domain/delete_pokemon.rs:1:46 [INFO] [stdout] | [INFO] [stdout] 1 | use crate::domain::entities::{PokemonNumber, Pokemon}; [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `FetchOneError` [INFO] [stdout] --> src/domain/delete_pokemon.rs:3:48 [INFO] [stdout] | [INFO] [stdout] 3 | use crate::repositories::pokemon::{Repository, FetchOneError, DeleteError}; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `InMemoryRepository` [INFO] [stdout] --> src/api/mod.rs:1:36 [INFO] [stdout] | [INFO] [stdout] 1 | use crate::repositories::pokemon::{InMemoryRepository, Repository}; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `crate::domain::entities::PokemonNumber` [INFO] [stdout] --> src/api/fetch_pokemon.rs:5:5 [INFO] [stdout] | [INFO] [stdout] 5 | use crate::domain::entities::PokemonNumber; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `crate::domain::fetch_pokemon::Error` [INFO] [stdout] --> src/api/fetch_pokemon.rs:7:5 [INFO] [stdout] | [INFO] [stdout] 7 | use crate::domain::fetch_pokemon::Error; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `serde::Serialize` [INFO] [stdout] --> src/api/delete_pokemon.rs:2:5 [INFO] [stdout] | [INFO] [stdout] 2 | use serde::Serialize; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `crate::domain::entities::PokemonNumber` [INFO] [stdout] --> src/api/delete_pokemon.rs:5:5 [INFO] [stdout] | [INFO] [stdout] 5 | use crate::domain::entities::PokemonNumber; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `e` [INFO] [stdout] --> src/domain/fetch_pokemon.rs:25:66 [INFO] [stdout] | [INFO] [stdout] 25 | let valid_num = PokemonNumber::try_from(req.number).map_err(|e|Error::BadRequest)?; [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_e` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `e` [INFO] [stdout] --> src/domain/fetch_pokemon.rs:25:66 [INFO] [stdout] | [INFO] [stdout] 25 | let valid_num = PokemonNumber::try_from(req.number).map_err(|e|Error::BadRequest)?; [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_e` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 13 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/domain/create_pokemon.rs:99:13 [INFO] [stdout] | [INFO] [stdout] 99 | let mut repo = Arc::new(InMemoryRepository::new().with_error()); [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/domain/create_pokemon.rs:81:9 [INFO] [stdout] | [INFO] [stdout] 81 | repo.insert(number, name, types); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 14 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 3m 23s [INFO] running `Command { std: "docker" "inspect" "0225036a0f5617e43d44e680511168f47e90ec972e9e9ef08fa2136e9a340355", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "0225036a0f5617e43d44e680511168f47e90ec972e9e9ef08fa2136e9a340355", kill_on_drop: false }` [INFO] [stdout] 0225036a0f5617e43d44e680511168f47e90ec972e9e9ef08fa2136e9a340355