[INFO] cloning repository https://github.com/mthomasuk/basic-rust-http-server [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/mthomasuk/basic-rust-http-server" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fmthomasuk%2Fbasic-rust-http-server", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fmthomasuk%2Fbasic-rust-http-server'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] d1a4acb4779d023e4febd2bba0d8666de17742ea [INFO] checking mthomasuk/basic-rust-http-server against master#936f2600b6c903b04387f74ed5cbce88bb06d243 for pr-91141 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fmthomasuk%2Fbasic-rust-http-server" "/workspace/builds/worker-95/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-95/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/mthomasuk/basic-rust-http-server on toolchain 936f2600b6c903b04387f74ed5cbce88bb06d243 [INFO] running `Command { std: "/workspace/cargo-home/bin/cargo" "+936f2600b6c903b04387f74ed5cbce88bb06d243" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/mthomasuk/basic-rust-http-server [INFO] finished tweaking git repo https://github.com/mthomasuk/basic-rust-http-server [INFO] tweaked toml for git repo https://github.com/mthomasuk/basic-rust-http-server written to /workspace/builds/worker-95/source/Cargo.toml [INFO] crate git repo https://github.com/mthomasuk/basic-rust-http-server already has a lockfile, it will not be regenerated [INFO] running `Command { std: "/workspace/cargo-home/bin/cargo" "+936f2600b6c903b04387f74ed5cbce88bb06d243" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-95/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-95/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:5736fa189c1c60b01babf4b8b698fe57b6ecc41933a7ff2e0b8d7a221459412b" "/opt/rustwide/cargo-home/bin/cargo" "+936f2600b6c903b04387f74ed5cbce88bb06d243" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 22870d08199efe0a269ecb501dd83eb84050037f130a0a4b73461e3a9a36d44d [INFO] running `Command { std: "docker" "start" "-a" "22870d08199efe0a269ecb501dd83eb84050037f130a0a4b73461e3a9a36d44d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "22870d08199efe0a269ecb501dd83eb84050037f130a0a4b73461e3a9a36d44d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "22870d08199efe0a269ecb501dd83eb84050037f130a0a4b73461e3a9a36d44d", kill_on_drop: false }` [INFO] [stdout] 22870d08199efe0a269ecb501dd83eb84050037f130a0a4b73461e3a9a36d44d [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-95/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-95/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:5736fa189c1c60b01babf4b8b698fe57b6ecc41933a7ff2e0b8d7a221459412b" "/opt/rustwide/cargo-home/bin/cargo" "+936f2600b6c903b04387f74ed5cbce88bb06d243" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] a32668e5f63fcdb3006c51080cf0b03ca2238fd221ca75524552703b97737dc9 [INFO] running `Command { std: "docker" "start" "-a" "a32668e5f63fcdb3006c51080cf0b03ca2238fd221ca75524552703b97737dc9", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Compiling libc v0.2.48 [INFO] [stderr] Compiling typenum v1.10.0 [INFO] [stderr] Compiling proc-macro2 v0.4.26 [INFO] [stderr] Compiling byteorder v1.3.1 [INFO] [stderr] Checking arrayref v0.3.5 [INFO] [stderr] Checking byte-tools v0.2.0 [INFO] [stderr] Checking constant_time_eq v0.1.3 [INFO] [stderr] Compiling memchr v2.1.3 [INFO] [stderr] Compiling serde v1.0.85 [INFO] [stderr] Checking fallible-iterator v0.1.6 [INFO] [stderr] Compiling ryu v0.2.7 [INFO] [stderr] Checking md5 v0.3.8 [INFO] [stderr] Checking uuid v0.5.1 [INFO] [stderr] Compiling regex v1.1.0 [INFO] [stderr] Checking ucd-util v0.1.3 [INFO] [stderr] Checking hex v0.2.0 [INFO] [stderr] Checking unicode-bidi v0.3.4 [INFO] [stderr] Checking phf_shared v0.7.24 [INFO] [stderr] Checking thread_local v0.3.6 [INFO] [stderr] Checking smallvec v0.6.8 [INFO] [stderr] Checking block-buffer v0.3.3 [INFO] [stderr] Checking phf v0.7.24 [INFO] [stderr] Checking regex-syntax v0.6.5 [INFO] [stderr] Checking unicode-normalization v0.1.8 [INFO] [stderr] Checking rand v0.4.6 [INFO] [stderr] Checking iovec v0.1.2 [INFO] [stderr] Checking memchr v1.0.2 [INFO] [stderr] Checking socket2 v0.3.8 [INFO] [stderr] Compiling quote v0.6.11 [INFO] [stderr] Checking base64 v0.6.0 [INFO] [stderr] Checking stringprep v0.1.2 [INFO] [stderr] Checking generic-array v0.9.0 [INFO] [stderr] Checking aho-corasick v0.6.9 [INFO] [stderr] Compiling syn v0.15.26 [INFO] [stderr] Checking bytes v0.4.11 [INFO] [stderr] Checking digest v0.7.6 [INFO] [stderr] Checking crypto-mac v0.5.2 [INFO] [stderr] Checking sha2 v0.7.1 [INFO] [stderr] Checking hmac v0.5.0 [INFO] [stderr] Checking rand v0.3.23 [INFO] [stderr] Checking postgres-protocol v0.3.2 [INFO] [stderr] Checking postgres-shared v0.4.2 [INFO] [stderr] Checking postgres v0.15.2 [INFO] [stderr] Compiling serde_derive v1.0.85 [INFO] [stderr] Checking serde_json v1.0.37 [INFO] [stderr] Checking toml v0.4.10 [INFO] [stderr] Checking web-serve v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/threading/mod.rs:24:16 [INFO] [stdout] | [INFO] [stdout] 24 | type Job = Box; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: use `dyn`: `dyn FnBox + Send + 'static` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(bare_trait_objects)]` on by default [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around block return value [INFO] [stdout] --> src/threading/mod.rs:39:39 [INFO] [stdout] | [INFO] [stdout] 39 | let safe_size = if size < 1 { (1) } else { (size) }; [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 39 - let safe_size = if size < 1 { (1) } else { (size) }; [INFO] [stdout] 39 + let safe_size = if size < 1 { 1 } else { (size) }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around block return value [INFO] [stdout] --> src/threading/mod.rs:39:52 [INFO] [stdout] | [INFO] [stdout] 39 | let safe_size = if size < 1 { (1) } else { (size) }; [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 39 - let safe_size = if size < 1 { (1) } else { (size) }; [INFO] [stdout] 39 + let safe_size = if size < 1 { (1) } else { size }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/threading/mod.rs:24:16 [INFO] [stdout] | [INFO] [stdout] 24 | type Job = Box; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: use `dyn`: `dyn FnBox + Send + 'static` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(bare_trait_objects)]` on by default [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around block return value [INFO] [stdout] --> src/threading/mod.rs:39:39 [INFO] [stdout] | [INFO] [stdout] 39 | let safe_size = if size < 1 { (1) } else { (size) }; [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 39 - let safe_size = if size < 1 { (1) } else { (size) }; [INFO] [stdout] 39 + let safe_size = if size < 1 { 1 } else { (size) }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around block return value [INFO] [stdout] --> src/threading/mod.rs:39:52 [INFO] [stdout] | [INFO] [stdout] 39 | let safe_size = if size < 1 { (1) } else { (size) }; [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 39 - let safe_size = if size < 1 { (1) } else { (size) }; [INFO] [stdout] 39 + let safe_size = if size < 1 { (1) } else { size }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/request/mod.rs:146:17 [INFO] [stdout] | [INFO] [stdout] 146 | let mut mapped_json = json.join(","); [INFO] [stdout] | ----^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/request/mod.rs:146:17 [INFO] [stdout] | [INFO] [stdout] 146 | let mut mapped_json = json.join(","); [INFO] [stdout] | ----^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field is never read: `host` [INFO] [stdout] --> src/request/mod.rs:19:5 [INFO] [stdout] | [INFO] [stdout] 19 | host: String, [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field is never read: `user_agent` [INFO] [stdout] --> src/request/mod.rs:20:5 [INFO] [stdout] | [INFO] [stdout] 20 | user_agent: String, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field is never read: `headers` [INFO] [stdout] --> src/request/mod.rs:21:5 [INFO] [stdout] | [INFO] [stdout] 21 | headers: Vec, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field is never read: `body` [INFO] [stdout] --> src/request/mod.rs:22:5 [INFO] [stdout] | [INFO] [stdout] 22 | body: String, [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field is never read: `host` [INFO] [stdout] --> src/request/mod.rs:19:5 [INFO] [stdout] | [INFO] [stdout] 19 | host: String, [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field is never read: `user_agent` [INFO] [stdout] --> src/request/mod.rs:20:5 [INFO] [stdout] | [INFO] [stdout] 20 | user_agent: String, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field is never read: `headers` [INFO] [stdout] --> src/request/mod.rs:21:5 [INFO] [stdout] | [INFO] [stdout] 21 | headers: Vec, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field is never read: `body` [INFO] [stdout] --> src/request/mod.rs:22:5 [INFO] [stdout] | [INFO] [stdout] 22 | body: String, [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 8 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 8 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 24.55s [INFO] running `Command { std: "docker" "inspect" "a32668e5f63fcdb3006c51080cf0b03ca2238fd221ca75524552703b97737dc9", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a32668e5f63fcdb3006c51080cf0b03ca2238fd221ca75524552703b97737dc9", kill_on_drop: false }` [INFO] [stdout] a32668e5f63fcdb3006c51080cf0b03ca2238fd221ca75524552703b97737dc9