[INFO] cloning repository https://github.com/ISRAEL-DUFF/tfs [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/ISRAEL-DUFF/tfs" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FISRAEL-DUFF%2Ftfs", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FISRAEL-DUFF%2Ftfs'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] f789f2f3b43776982f61a9245c09b6055a5566ab [INFO] testing ISRAEL-DUFF/tfs against try#722e1797249a965b6335aebd65d777f917e498f1 for pr-91031 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FISRAEL-DUFF%2Ftfs" "/workspace/builds/worker-107/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-107/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/ISRAEL-DUFF/tfs on toolchain 722e1797249a965b6335aebd65d777f917e498f1 [INFO] running `Command { std: "/workspace/cargo-home/bin/cargo" "+722e1797249a965b6335aebd65d777f917e498f1" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/ISRAEL-DUFF/tfs [INFO] finished tweaking git repo https://github.com/ISRAEL-DUFF/tfs [INFO] tweaked toml for git repo https://github.com/ISRAEL-DUFF/tfs written to /workspace/builds/worker-107/source/Cargo.toml [INFO] crate git repo https://github.com/ISRAEL-DUFF/tfs already has a lockfile, it will not be regenerated [INFO] running `Command { std: "/workspace/cargo-home/bin/cargo" "+722e1797249a965b6335aebd65d777f917e498f1" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-107/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-107/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:5736fa189c1c60b01babf4b8b698fe57b6ecc41933a7ff2e0b8d7a221459412b" "/opt/rustwide/cargo-home/bin/cargo" "+722e1797249a965b6335aebd65d777f917e498f1" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 4a2deb9c9d6fbe2b1d71b7ff71a98cd79f50accecaa3a2590bc331ae53632768 [INFO] running `Command { std: "docker" "start" "-a" "4a2deb9c9d6fbe2b1d71b7ff71a98cd79f50accecaa3a2590bc331ae53632768", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "4a2deb9c9d6fbe2b1d71b7ff71a98cd79f50accecaa3a2590bc331ae53632768", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "4a2deb9c9d6fbe2b1d71b7ff71a98cd79f50accecaa3a2590bc331ae53632768", kill_on_drop: false }` [INFO] [stdout] 4a2deb9c9d6fbe2b1d71b7ff71a98cd79f50accecaa3a2590bc331ae53632768 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-107/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-107/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:5736fa189c1c60b01babf4b8b698fe57b6ecc41933a7ff2e0b8d7a221459412b" "/opt/rustwide/cargo-home/bin/cargo" "+722e1797249a965b6335aebd65d777f917e498f1" "build" "--frozen" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 79000b4977500d6bf761aeebe506285f35129242ac1b4fe59aa3eada513095d7 [INFO] running `Command { std: "docker" "start" "-a" "79000b4977500d6bf761aeebe506285f35129242ac1b4fe59aa3eada513095d7", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Compiling disk v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `super::utility` [INFO] [stdout] --> src/tfs/types.rs:3:5 [INFO] [stdout] | [INFO] [stdout] 3 | use super::utility; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unreachable expression [INFO] [stdout] --> src/tfs/mod.rs:407:9 [INFO] [stdout] | [INFO] [stdout] 353 | / loop { [INFO] [stdout] 354 | | if bytes_read == length || j == length { [INFO] [stdout] 355 | | return bytes_read as i64; [INFO] [stdout] 356 | | } [INFO] [stdout] ... | [INFO] [stdout] 404 | | println!("BYTES INDEX: {}, {}", block_index, block_offset); [INFO] [stdout] 405 | | } [INFO] [stdout] | |_________- any code following this expression is unreachable [INFO] [stdout] 406 | [INFO] [stdout] 407 | -1 [INFO] [stdout] | ^^ unreachable expression [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unreachable_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unreachable expression [INFO] [stdout] --> src/tfs/mod.rs:533:9 [INFO] [stdout] | [INFO] [stdout] 507 | / loop { [INFO] [stdout] 508 | | if bytes_writen < length && (offset + bytes_writen) < data.len() { [INFO] [stdout] 509 | | let bytes_wr = self.write_to_block(block_num, block_offset, data, length - bytes_writen, offset + bytes_writen); [INFO] [stdout] 510 | | println!("bytes_writen: {}", bytes_wr); [INFO] [stdout] ... | [INFO] [stdout] 530 | | } [INFO] [stdout] 531 | | } [INFO] [stdout] | |_________- any code following this expression is unreachable [INFO] [stdout] 532 | [INFO] [stdout] 533 | bytes_writen as i64 [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ unreachable expression [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `i` [INFO] [stdout] --> src/tfs/mod.rs:140:13 [INFO] [stdout] | [INFO] [stdout] 140 | for i in 0..nBlocks - inodeBlocks - 1 { [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_i` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `metaData` [INFO] [stdout] --> src/tfs/mod.rs:225:18 [INFO] [stdout] | [INFO] [stdout] 225 | Some(metaData) => { [INFO] [stdout] | ^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_metaData` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `disk` [INFO] [stdout] --> src/tfs/mod.rs:227:26 [INFO] [stdout] | [INFO] [stdout] 227 | Some(disk) => { [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_disk` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/tfs/disk.rs:60:13 [INFO] [stdout] | [INFO] [stdout] 60 | let mut file = OpenOptions::new() [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/tfs/disk.rs:104:18 [INFO] [stdout] | [INFO] [stdout] 104 | Some(mut file) => { [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/tfs/disk.rs:116:18 [INFO] [stdout] | [INFO] [stdout] 116 | Some(mut file) => { [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/tfs/mod.rs:345:13 [INFO] [stdout] | [INFO] [stdout] 345 | let mut block_index = (offset as f64 / Disk::BLOCK_SIZE as f64).floor() as usize; [INFO] [stdout] | ----^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/tfs/mod.rs:450:13 [INFO] [stdout] | [INFO] [stdout] 450 | let mut disc = match &mut self.disk { [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/tfs/mod.rs:684:13 [INFO] [stdout] | [INFO] [stdout] 684 | let mut disk = match &mut self.disk { [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary `unsafe` block [INFO] [stdout] --> src/tfs/types.rs:90:9 [INFO] [stdout] | [INFO] [stdout] 90 | unsafe { [INFO] [stdout] | ^^^^^^ unnecessary `unsafe` block [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_unsafe)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary `unsafe` block [INFO] [stdout] --> src/tfs/types.rs:96:9 [INFO] [stdout] | [INFO] [stdout] 96 | unsafe { [INFO] [stdout] | ^^^^^^ unnecessary `unsafe` block [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary `unsafe` block [INFO] [stdout] --> src/tfs/types.rs:102:9 [INFO] [stdout] | [INFO] [stdout] 102 | unsafe { [INFO] [stdout] | ^^^^^^ unnecessary `unsafe` block [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary `unsafe` block [INFO] [stdout] --> src/tfs/types.rs:108:9 [INFO] [stdout] | [INFO] [stdout] 108 | unsafe { [INFO] [stdout] | ^^^^^^ unnecessary `unsafe` block [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function is never used: `as_u32_be` [INFO] [stdout] --> src/tfs/utility.rs:1:8 [INFO] [stdout] | [INFO] [stdout] 1 | pub fn as_u32_be(array: &[u8; 4]) -> u32 { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function is never used: `as_u32_le` [INFO] [stdout] --> src/tfs/utility.rs:8:8 [INFO] [stdout] | [INFO] [stdout] 8 | pub fn as_u32_le(array: &[u8; 4]) -> u32 { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function is never used: `as_u32` [INFO] [stdout] --> src/tfs/utility.rs:15:8 [INFO] [stdout] | [INFO] [stdout] 15 | pub fn as_u32(array: &[u8]) -> u32 { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `metaData` should have a snake case name [INFO] [stdout] --> src/tfs/mod.rs:9:9 [INFO] [stdout] | [INFO] [stdout] 9 | pub metaData: Option, [INFO] [stdout] | ^^^^^^^^ help: convert the identifier to snake case: `meta_data` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_snake_case)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `inodeBitMap` should have a snake case name [INFO] [stdout] --> src/tfs/mod.rs:10:9 [INFO] [stdout] | [INFO] [stdout] 10 | pub inodeBitMap: Option>, [INFO] [stdout] | ^^^^^^^^^^^ help: convert the identifier to snake case: `inode_bit_map` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `dataBitMap` should have a snake case name [INFO] [stdout] --> src/tfs/mod.rs:11:9 [INFO] [stdout] | [INFO] [stdout] 11 | pub dataBitMap: Option>, [INFO] [stdout] | ^^^^^^^^^^ help: convert the identifier to snake case: `data_bit_map` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `metaData` should have a snake case name [INFO] [stdout] --> src/tfs/mod.rs:54:18 [INFO] [stdout] | [INFO] [stdout] 54 | Some(metaData) => Self::debug_print(metaData), [INFO] [stdout] | ^^^^^^^^ help: convert the identifier to snake case: `meta_data` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `metaData` should have a snake case name [INFO] [stdout] --> src/tfs/mod.rs:60:13 [INFO] [stdout] | [INFO] [stdout] 60 | let metaData = Self::read_meta_data(disk); [INFO] [stdout] | ^^^^^^^^ help: convert the identifier to snake case: `meta_data` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `inodeTable` should have a snake case name [INFO] [stdout] --> src/tfs/mod.rs:66:13 [INFO] [stdout] | [INFO] [stdout] 66 | let inodeTable = &meta_data.inodeTable; [INFO] [stdout] | ^^^^^^^^^^ help: convert the identifier to snake case: `inode_table` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `metaData` should have a snake case name [INFO] [stdout] --> src/tfs/mod.rs:122:13 [INFO] [stdout] | [INFO] [stdout] 122 | let metaData = Self::read_meta_data(disk); [INFO] [stdout] | ^^^^^^^^ help: convert the identifier to snake case: `meta_data` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `metaData2` should have a snake case name [INFO] [stdout] --> src/tfs/mod.rs:123:13 [INFO] [stdout] | [INFO] [stdout] 123 | let metaData2 = Self::read_meta_data(disk); // ...have no idea how to make a copy [INFO] [stdout] | ^^^^^^^^^ help: convert the identifier to snake case: `meta_data2` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `nBlocks` should have a snake case name [INFO] [stdout] --> src/tfs/mod.rs:133:13 [INFO] [stdout] | [INFO] [stdout] 133 | let nBlocks = metaData.superBlock.Blocks; [INFO] [stdout] | ^^^^^^^ help: convert the identifier to snake case: `n_blocks` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `inodeBlocks` should have a snake case name [INFO] [stdout] --> src/tfs/mod.rs:134:13 [INFO] [stdout] | [INFO] [stdout] 134 | let inodeBlocks = metaData.superBlock.InodeBlocks; [INFO] [stdout] | ^^^^^^^^^^^ help: convert the identifier to snake case: `inode_blocks` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `metaData` should have a snake case name [INFO] [stdout] --> src/tfs/mod.rs:200:38 [INFO] [stdout] | [INFO] [stdout] 200 | ... Some(metaData) => { [INFO] [stdout] | ^^^^^^^^ help: convert the identifier to snake case: `meta_data` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `metaData` should have a snake case name [INFO] [stdout] --> src/tfs/mod.rs:225:18 [INFO] [stdout] | [INFO] [stdout] 225 | Some(metaData) => { [INFO] [stdout] | ^^^^^^^^ help: convert the identifier to snake case: `meta_data` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `metaData` should have a snake case name [INFO] [stdout] --> src/tfs/mod.rs:248:22 [INFO] [stdout] | [INFO] [stdout] 248 | Some(metaData) => { [INFO] [stdout] | ^^^^^^^^ help: convert the identifier to snake case: `meta_data` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `ibitMap` should have a snake case name [INFO] [stdout] --> src/tfs/mod.rs:257:22 [INFO] [stdout] | [INFO] [stdout] 257 | Some(ibitMap)=> { [INFO] [stdout] | ^^^^^^^ help: convert the identifier to snake case: `ibit_map` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `superBlock` should have a snake case name [INFO] [stdout] --> src/tfs/mod.rs:544:13 [INFO] [stdout] | [INFO] [stdout] 544 | let superBlock = block.superblock(); [INFO] [stdout] | ^^^^^^^^^^ help: convert the identifier to snake case: `super_block` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `inodeTable` should have a snake case name [INFO] [stdout] --> src/tfs/mod.rs:547:17 [INFO] [stdout] | [INFO] [stdout] 547 | let mut inodeTable = Vec::new(); [INFO] [stdout] | ^^^^^^^^^^ help: convert the identifier to snake case: `inode_table` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `metaData` should have a snake case name [INFO] [stdout] --> src/tfs/mod.rs:563:18 [INFO] [stdout] | [INFO] [stdout] 563 | Some(metaData) => { [INFO] [stdout] | ^^^^^^^^ help: convert the identifier to snake case: `meta_data` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `metaData` should have a snake case name [INFO] [stdout] --> src/tfs/mod.rs:581:18 [INFO] [stdout] | [INFO] [stdout] 581 | Some(metaData) => { [INFO] [stdout] | ^^^^^^^^ help: convert the identifier to snake case: `meta_data` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `metaData` should have a snake case name [INFO] [stdout] --> src/tfs/mod.rs:658:26 [INFO] [stdout] | [INFO] [stdout] 658 | Some(metaData) => { [INFO] [stdout] | ^^^^^^^^ help: convert the identifier to snake case: `meta_data` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `dataBitMap` should have a snake case name [INFO] [stdout] --> src/tfs/mod.rs:693:31 [INFO] [stdout] | [INFO] [stdout] 693 | let get_free_block = |dataBitMap: Option<&Vec>| { [INFO] [stdout] | ^^^^^^^^^^ help: convert the identifier to snake case: `data_bit_map` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `dataBitMap` should have a snake case name [INFO] [stdout] --> src/tfs/mod.rs:695:22 [INFO] [stdout] | [INFO] [stdout] 695 | Some(dataBitMap) => { [INFO] [stdout] | ^^^^^^^^^^ help: convert the identifier to snake case: `data_bit_map` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `dataBitMap` should have a snake case name [INFO] [stdout] --> src/tfs/mod.rs:718:22 [INFO] [stdout] | [INFO] [stdout] 718 | Some(dataBitMap) => { [INFO] [stdout] | ^^^^^^^^^^ help: convert the identifier to snake case: `data_bit_map` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `metaData` should have a snake case name [INFO] [stdout] --> src/tfs/mod.rs:725:22 [INFO] [stdout] | [INFO] [stdout] 725 | Some(metaData) => { [INFO] [stdout] | ^^^^^^^^ help: convert the identifier to snake case: `meta_data` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `FileDescriptor` should have a snake case name [INFO] [stdout] --> src/tfs/disk.rs:10:5 [INFO] [stdout] | [INFO] [stdout] 10 | FileDescriptor: Option, [INFO] [stdout] | ^^^^^^^^^^^^^^ help: convert the identifier to snake case: `file_descriptor` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `Blocks` should have a snake case name [INFO] [stdout] --> src/tfs/disk.rs:11:5 [INFO] [stdout] | [INFO] [stdout] 11 | Blocks: usize, // Number of blocks in disk image [INFO] [stdout] | ^^^^^^ help: convert the identifier to snake case: `blocks` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `Reads` should have a snake case name [INFO] [stdout] --> src/tfs/disk.rs:12:5 [INFO] [stdout] | [INFO] [stdout] 12 | Reads: usize, // Number of reads performed [INFO] [stdout] | ^^^^^ help: convert the identifier to snake case: `reads` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `Writes` should have a snake case name [INFO] [stdout] --> src/tfs/disk.rs:13:5 [INFO] [stdout] | [INFO] [stdout] 13 | Writes: usize, // Number of writes performed [INFO] [stdout] | ^^^^^^ help: convert the identifier to snake case (notice the capitalization): `writes` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `Mounts` should have a snake case name [INFO] [stdout] --> src/tfs/disk.rs:14:5 [INFO] [stdout] | [INFO] [stdout] 14 | Mounts: usize, // Number of mounts [INFO] [stdout] | ^^^^^^ help: convert the identifier to snake case: `mounts` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `Path` should have a snake case name [INFO] [stdout] --> src/tfs/disk.rs:15:5 [INFO] [stdout] | [INFO] [stdout] 15 | Path: &'a str // file path for the disk [INFO] [stdout] | ^^^^ help: convert the identifier to snake case: `path` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison is useless due to type limits [INFO] [stdout] --> src/tfs/disk.rs:21:12 [INFO] [stdout] | [INFO] [stdout] 21 | if blocknum < 0 { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_comparisons)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/tfs/disk.rs:68:17 [INFO] [stdout] | [INFO] [stdout] 68 | f.set_len((nblocks as u64) * (Self::BLOCK_SIZE as u64)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/tfs/disk.rs:105:17 [INFO] [stdout] | [INFO] [stdout] 105 | file.seek(SeekFrom::Start( blocknum as u64 * Self::BLOCK_SIZE as u64)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/tfs/disk.rs:106:17 [INFO] [stdout] | [INFO] [stdout] 106 | file.read(data); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/tfs/disk.rs:117:17 [INFO] [stdout] | [INFO] [stdout] 117 | file.seek(SeekFrom::Start(blocknum as u64 * Self::BLOCK_SIZE as u64)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/tfs/disk.rs:118:17 [INFO] [stdout] | [INFO] [stdout] 118 | file.write(data); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `MagicNumber` should have a snake case name [INFO] [stdout] --> src/tfs/types.rs:13:9 [INFO] [stdout] | [INFO] [stdout] 13 | pub MagicNumber: u32, [INFO] [stdout] | ^^^^^^^^^^^ help: convert the identifier to snake case: `magic_number` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `Blocks` should have a snake case name [INFO] [stdout] --> src/tfs/types.rs:14:9 [INFO] [stdout] | [INFO] [stdout] 14 | pub Blocks: u32, [INFO] [stdout] | ^^^^^^ help: convert the identifier to snake case: `blocks` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `InodeBlocks` should have a snake case name [INFO] [stdout] --> src/tfs/types.rs:15:9 [INFO] [stdout] | [INFO] [stdout] 15 | pub InodeBlocks: u32, [INFO] [stdout] | ^^^^^^^^^^^ help: convert the identifier to snake case: `inode_blocks` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `Inodes` should have a snake case name [INFO] [stdout] --> src/tfs/types.rs:16:9 [INFO] [stdout] | [INFO] [stdout] 16 | pub Inodes: u32 [INFO] [stdout] | ^^^^^^ help: convert the identifier to snake case (notice the capitalization): `inodes` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `Valid` should have a snake case name [INFO] [stdout] --> src/tfs/types.rs:22:9 [INFO] [stdout] | [INFO] [stdout] 22 | pub Valid: u32, // whether or not inode is valid (or allocated) [INFO] [stdout] | ^^^^^ help: convert the identifier to snake case (notice the capitalization): `valid` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `Size` should have a snake case name [INFO] [stdout] --> src/tfs/types.rs:23:9 [INFO] [stdout] | [INFO] [stdout] 23 | pub Size: u32, // size of file [INFO] [stdout] | ^^^^ help: convert the identifier to snake case (notice the capitalization): `size` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `Direct` should have a snake case name [INFO] [stdout] --> src/tfs/types.rs:24:9 [INFO] [stdout] | [INFO] [stdout] 24 | pub Direct: [u32; POINTERS_PER_INODE], [INFO] [stdout] | ^^^^^^ help: convert the identifier to snake case: `direct` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `Indirect` should have a snake case name [INFO] [stdout] --> src/tfs/types.rs:25:9 [INFO] [stdout] | [INFO] [stdout] 25 | pub Indirect: u32 [INFO] [stdout] | ^^^^^^^^ help: convert the identifier to snake case (notice the capitalization): `indirect` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `Super` should have a snake case name [INFO] [stdout] --> src/tfs/types.rs:31:9 [INFO] [stdout] | [INFO] [stdout] 31 | pub Super: Superblock, [INFO] [stdout] | ^^^^^ help: rename the identifier [INFO] [stdout] | [INFO] [stdout] = note: `super` cannot be used as a raw identifier [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `Inodes` should have a snake case name [INFO] [stdout] --> src/tfs/types.rs:32:9 [INFO] [stdout] | [INFO] [stdout] 32 | pub Inodes: [Inode; INODES_PER_BLOCK], [INFO] [stdout] | ^^^^^^ help: convert the identifier to snake case (notice the capitalization): `inodes` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `Pointers` should have a snake case name [INFO] [stdout] --> src/tfs/types.rs:33:9 [INFO] [stdout] | [INFO] [stdout] 33 | pub Pointers: [u32; POINTERS_PER_BLOCK], [INFO] [stdout] | ^^^^^^^^ help: convert the identifier to snake case: `pointers` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `Data` should have a snake case name [INFO] [stdout] --> src/tfs/types.rs:34:9 [INFO] [stdout] | [INFO] [stdout] 34 | pub Data: [u8; Disk::BLOCK_SIZE] [INFO] [stdout] | ^^^^ help: convert the identifier to snake case: `data` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `superBlock` should have a snake case name [INFO] [stdout] --> src/tfs/types.rs:40:9 [INFO] [stdout] | [INFO] [stdout] 40 | pub superBlock: Superblock, [INFO] [stdout] | ^^^^^^^^^^ help: convert the identifier to snake case: `super_block` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `inodeTable` should have a snake case name [INFO] [stdout] --> src/tfs/types.rs:41:9 [INFO] [stdout] | [INFO] [stdout] 41 | pub inodeTable: Vec<[Inode; INODES_PER_BLOCK]> [INFO] [stdout] | ^^^^^^^^^^ help: convert the identifier to snake case: `inode_table` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 68 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::error::Error` [INFO] [stdout] --> src/main.rs:5:5 [INFO] [stdout] | [INFO] [stdout] 5 | use std::error::Error; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `File` [INFO] [stdout] --> src/main.rs:251:19 [INFO] [stdout] | [INFO] [stdout] 251 | use std::fs::{File, OpenOptions}; [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `File` [INFO] [stdout] --> src/main.rs:294:19 [INFO] [stdout] | [INFO] [stdout] 294 | use std::fs::{File, OpenOptions}; [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `bytes_read` [INFO] [stdout] --> src/main.rs:84:9 [INFO] [stdout] | [INFO] [stdout] 84 | let bytes_read = stdin().read_line(&mut line).unwrap(); [INFO] [stdout] | ^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_bytes_read` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/main.rs:150:18 [INFO] [stdout] | [INFO] [stdout] 150 | fn do_create<'a>(mut disk: Disk<'a>, [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/main.rs:167:18 [INFO] [stdout] | [INFO] [stdout] 167 | fn do_remove<'a>(mut disk: Disk<'a>, [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/main.rs:185:16 [INFO] [stdout] | [INFO] [stdout] 185 | fn do_stat<'a>(mut disk: Disk<'a>, [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/main.rs:204:18 [INFO] [stdout] | [INFO] [stdout] 204 | fn do_copyin<'a>(mut disk: Disk<'a>, [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/main.rs:205:5 [INFO] [stdout] | [INFO] [stdout] 205 | mut fs: FileSystem<'a>, args: Vec<&str>) [INFO] [stdout] | ----^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/main.rs:222:19 [INFO] [stdout] | [INFO] [stdout] 222 | fn do_copyout<'a>(mut disk: Disk<'a>, [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/main.rs:223:5 [INFO] [stdout] | [INFO] [stdout] 223 | mut fs: FileSystem<'a>, args: Vec<&str>) [INFO] [stdout] | ----^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/main.rs:262:9 [INFO] [stdout] | [INFO] [stdout] 262 | let mut offset = 0; [INFO] [stdout] | ----^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/main.rs:325:15 [INFO] [stdout] | [INFO] [stdout] 325 | fn do_cat<'a>(mut fs: FileSystem<'a>, args: Vec<&str>) -> FileSystem<'a> { [INFO] [stdout] | ----^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison is useless due to type limits [INFO] [stdout] --> src/main.rs:157:16 [INFO] [stdout] | [INFO] [stdout] 157 | if inumber >= 0 { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_comparisons)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/main.rs:282:9 [INFO] [stdout] | [INFO] [stdout] 282 | file.seek(SeekFrom::Start( n as u64 * Disk::BLOCK_SIZE as u64)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/main.rs:315:13 [INFO] [stdout] | [INFO] [stdout] 315 | file.write(&mut buff); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/main.rs:317:13 [INFO] [stdout] | [INFO] [stdout] 317 | file.write(&mut buffer); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 17 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1m 35s [INFO] running `Command { std: "docker" "inspect" "79000b4977500d6bf761aeebe506285f35129242ac1b4fe59aa3eada513095d7", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "79000b4977500d6bf761aeebe506285f35129242ac1b4fe59aa3eada513095d7", kill_on_drop: false }` [INFO] [stdout] 79000b4977500d6bf761aeebe506285f35129242ac1b4fe59aa3eada513095d7 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-107/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-107/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:5736fa189c1c60b01babf4b8b698fe57b6ecc41933a7ff2e0b8d7a221459412b" "/opt/rustwide/cargo-home/bin/cargo" "+722e1797249a965b6335aebd65d777f917e498f1" "test" "--frozen" "--no-run" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 8768b2f2bd84ef79ef19051c5fce7105509f3be841d4f4f0e8e1e7e39dad610c [INFO] running `Command { std: "docker" "start" "-a" "8768b2f2bd84ef79ef19051c5fce7105509f3be841d4f4f0e8e1e7e39dad610c", kill_on_drop: false }` [INFO] [stdout] warning: unused import: `super::utility` [INFO] [stdout] --> src/tfs/types.rs:3:5 [INFO] [stdout] | [INFO] [stdout] 3 | use super::utility; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unreachable expression [INFO] [stdout] --> src/tfs/mod.rs:407:9 [INFO] [stdout] | [INFO] [stdout] 353 | / loop { [INFO] [stdout] 354 | | if bytes_read == length || j == length { [INFO] [stdout] 355 | | return bytes_read as i64; [INFO] [stdout] 356 | | } [INFO] [stdout] ... | [INFO] [stdout] 404 | | println!("BYTES INDEX: {}, {}", block_index, block_offset); [INFO] [stdout] 405 | | } [INFO] [stdout] | |_________- any code following this expression is unreachable [INFO] [stdout] 406 | [INFO] [stdout] 407 | -1 [INFO] [stdout] | ^^ unreachable expression [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unreachable_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unreachable expression [INFO] [stdout] --> src/tfs/mod.rs:533:9 [INFO] [stdout] | [INFO] [stdout] 507 | / loop { [INFO] [stdout] 508 | | if bytes_writen < length && (offset + bytes_writen) < data.len() { [INFO] [stdout] 509 | | let bytes_wr = self.write_to_block(block_num, block_offset, data, length - bytes_writen, offset + bytes_writen); [INFO] [stdout] 510 | | println!("bytes_writen: {}", bytes_wr); [INFO] [stdout] ... | [INFO] [stdout] 530 | | } [INFO] [stdout] 531 | | } [INFO] [stdout] | |_________- any code following this expression is unreachable [INFO] [stdout] 532 | [INFO] [stdout] 533 | bytes_writen as i64 [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ unreachable expression [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `i` [INFO] [stdout] --> src/tfs/mod.rs:140:13 [INFO] [stdout] | [INFO] [stdout] 140 | for i in 0..nBlocks - inodeBlocks - 1 { [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_i` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `metaData` [INFO] [stdout] --> src/tfs/mod.rs:225:18 [INFO] [stdout] | [INFO] [stdout] 225 | Some(metaData) => { [INFO] [stdout] | ^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_metaData` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `disk` [INFO] [stdout] --> src/tfs/mod.rs:227:26 [INFO] [stdout] | [INFO] [stdout] 227 | Some(disk) => { [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_disk` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/tfs/disk.rs:60:13 [INFO] [stdout] | [INFO] [stdout] 60 | let mut file = OpenOptions::new() [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/tfs/disk.rs:104:18 [INFO] [stdout] | [INFO] [stdout] 104 | Some(mut file) => { [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/tfs/disk.rs:116:18 [INFO] [stdout] | [INFO] [stdout] 116 | Some(mut file) => { [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/tfs/mod.rs:345:13 [INFO] [stdout] | [INFO] [stdout] 345 | let mut block_index = (offset as f64 / Disk::BLOCK_SIZE as f64).floor() as usize; [INFO] [stdout] | ----^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/tfs/mod.rs:450:13 [INFO] [stdout] | [INFO] [stdout] 450 | let mut disc = match &mut self.disk { [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/tfs/mod.rs:684:13 [INFO] [stdout] | [INFO] [stdout] 684 | let mut disk = match &mut self.disk { [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary `unsafe` block [INFO] [stdout] --> src/tfs/types.rs:90:9 [INFO] [stdout] | [INFO] [stdout] 90 | unsafe { [INFO] [stdout] | ^^^^^^ unnecessary `unsafe` block [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_unsafe)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary `unsafe` block [INFO] [stdout] --> src/tfs/types.rs:96:9 [INFO] [stdout] | [INFO] [stdout] 96 | unsafe { [INFO] [stdout] | ^^^^^^ unnecessary `unsafe` block [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary `unsafe` block [INFO] [stdout] --> src/tfs/types.rs:102:9 [INFO] [stdout] | [INFO] [stdout] 102 | unsafe { [INFO] [stdout] | ^^^^^^ unnecessary `unsafe` block [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary `unsafe` block [INFO] [stdout] --> src/tfs/types.rs:108:9 [INFO] [stdout] | [INFO] [stdout] 108 | unsafe { [INFO] [stdout] | ^^^^^^ unnecessary `unsafe` block [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function is never used: `as_u32_be` [INFO] [stdout] --> src/tfs/utility.rs:1:8 [INFO] [stdout] | [INFO] [stdout] 1 | pub fn as_u32_be(array: &[u8; 4]) -> u32 { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function is never used: `as_u32_le` [INFO] [stdout] --> src/tfs/utility.rs:8:8 [INFO] [stdout] | [INFO] [stdout] 8 | pub fn as_u32_le(array: &[u8; 4]) -> u32 { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function is never used: `as_u32` [INFO] [stdout] --> src/tfs/utility.rs:15:8 [INFO] [stdout] | [INFO] [stdout] 15 | pub fn as_u32(array: &[u8]) -> u32 { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `metaData` should have a snake case name [INFO] [stdout] --> src/tfs/mod.rs:9:9 [INFO] [stdout] | [INFO] [stdout] 9 | pub metaData: Option, [INFO] [stdout] | ^^^^^^^^ help: convert the identifier to snake case: `meta_data` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_snake_case)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `inodeBitMap` should have a snake case name [INFO] [stdout] --> src/tfs/mod.rs:10:9 [INFO] [stdout] | [INFO] [stdout] 10 | pub inodeBitMap: Option>, [INFO] [stdout] | ^^^^^^^^^^^ help: convert the identifier to snake case: `inode_bit_map` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `dataBitMap` should have a snake case name [INFO] [stdout] --> src/tfs/mod.rs:11:9 [INFO] [stdout] | [INFO] [stdout] 11 | pub dataBitMap: Option>, [INFO] [stdout] | ^^^^^^^^^^ help: convert the identifier to snake case: `data_bit_map` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `metaData` should have a snake case name [INFO] [stdout] --> src/tfs/mod.rs:54:18 [INFO] [stdout] | [INFO] [stdout] 54 | Some(metaData) => Self::debug_print(metaData), [INFO] [stdout] | ^^^^^^^^ help: convert the identifier to snake case: `meta_data` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `metaData` should have a snake case name [INFO] [stdout] --> src/tfs/mod.rs:60:13 [INFO] [stdout] | [INFO] [stdout] 60 | let metaData = Self::read_meta_data(disk); [INFO] [stdout] | ^^^^^^^^ help: convert the identifier to snake case: `meta_data` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `inodeTable` should have a snake case name [INFO] [stdout] --> src/tfs/mod.rs:66:13 [INFO] [stdout] | [INFO] [stdout] 66 | let inodeTable = &meta_data.inodeTable; [INFO] [stdout] | ^^^^^^^^^^ help: convert the identifier to snake case: `inode_table` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `metaData` should have a snake case name [INFO] [stdout] --> src/tfs/mod.rs:122:13 [INFO] [stdout] | [INFO] [stdout] 122 | let metaData = Self::read_meta_data(disk); [INFO] [stdout] | ^^^^^^^^ help: convert the identifier to snake case: `meta_data` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `metaData2` should have a snake case name [INFO] [stdout] --> src/tfs/mod.rs:123:13 [INFO] [stdout] | [INFO] [stdout] 123 | let metaData2 = Self::read_meta_data(disk); // ...have no idea how to make a copy [INFO] [stdout] | ^^^^^^^^^ help: convert the identifier to snake case: `meta_data2` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `nBlocks` should have a snake case name [INFO] [stdout] --> src/tfs/mod.rs:133:13 [INFO] [stdout] | [INFO] [stdout] 133 | let nBlocks = metaData.superBlock.Blocks; [INFO] [stdout] | ^^^^^^^ help: convert the identifier to snake case: `n_blocks` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `inodeBlocks` should have a snake case name [INFO] [stdout] --> src/tfs/mod.rs:134:13 [INFO] [stdout] | [INFO] [stdout] 134 | let inodeBlocks = metaData.superBlock.InodeBlocks; [INFO] [stdout] | ^^^^^^^^^^^ help: convert the identifier to snake case: `inode_blocks` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `metaData` should have a snake case name [INFO] [stdout] --> src/tfs/mod.rs:200:38 [INFO] [stdout] | [INFO] [stdout] 200 | ... Some(metaData) => { [INFO] [stdout] | ^^^^^^^^ help: convert the identifier to snake case: `meta_data` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `metaData` should have a snake case name [INFO] [stdout] --> src/tfs/mod.rs:225:18 [INFO] [stdout] | [INFO] [stdout] 225 | Some(metaData) => { [INFO] [stdout] | ^^^^^^^^ help: convert the identifier to snake case: `meta_data` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `metaData` should have a snake case name [INFO] [stdout] --> src/tfs/mod.rs:248:22 [INFO] [stdout] | [INFO] [stdout] 248 | Some(metaData) => { [INFO] [stdout] | ^^^^^^^^ help: convert the identifier to snake case: `meta_data` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `ibitMap` should have a snake case name [INFO] [stdout] --> src/tfs/mod.rs:257:22 [INFO] [stdout] | [INFO] [stdout] 257 | Some(ibitMap)=> { [INFO] [stdout] | ^^^^^^^ help: convert the identifier to snake case: `ibit_map` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `superBlock` should have a snake case name [INFO] [stdout] --> src/tfs/mod.rs:544:13 [INFO] [stdout] | [INFO] [stdout] 544 | let superBlock = block.superblock(); [INFO] [stdout] | ^^^^^^^^^^ help: convert the identifier to snake case: `super_block` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `inodeTable` should have a snake case name [INFO] [stdout] --> src/tfs/mod.rs:547:17 [INFO] [stdout] | [INFO] [stdout] 547 | let mut inodeTable = Vec::new(); [INFO] [stdout] | ^^^^^^^^^^ help: convert the identifier to snake case: `inode_table` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `metaData` should have a snake case name [INFO] [stdout] --> src/tfs/mod.rs:563:18 [INFO] [stdout] | [INFO] [stdout] 563 | Some(metaData) => { [INFO] [stdout] | ^^^^^^^^ help: convert the identifier to snake case: `meta_data` [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Compiling disk v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: variable `metaData` should have a snake case name [INFO] [stdout] --> src/tfs/mod.rs:581:18 [INFO] [stdout] | [INFO] [stdout] 581 | Some(metaData) => { [INFO] [stdout] | ^^^^^^^^ help: convert the identifier to snake case: `meta_data` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `metaData` should have a snake case name [INFO] [stdout] --> src/tfs/mod.rs:658:26 [INFO] [stdout] | [INFO] [stdout] 658 | Some(metaData) => { [INFO] [stdout] | ^^^^^^^^ help: convert the identifier to snake case: `meta_data` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `dataBitMap` should have a snake case name [INFO] [stdout] --> src/tfs/mod.rs:693:31 [INFO] [stdout] | [INFO] [stdout] 693 | let get_free_block = |dataBitMap: Option<&Vec>| { [INFO] [stdout] | ^^^^^^^^^^ help: convert the identifier to snake case: `data_bit_map` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `dataBitMap` should have a snake case name [INFO] [stdout] --> src/tfs/mod.rs:695:22 [INFO] [stdout] | [INFO] [stdout] 695 | Some(dataBitMap) => { [INFO] [stdout] | ^^^^^^^^^^ help: convert the identifier to snake case: `data_bit_map` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `dataBitMap` should have a snake case name [INFO] [stdout] --> src/tfs/mod.rs:718:22 [INFO] [stdout] | [INFO] [stdout] 718 | Some(dataBitMap) => { [INFO] [stdout] | ^^^^^^^^^^ help: convert the identifier to snake case: `data_bit_map` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `metaData` should have a snake case name [INFO] [stdout] --> src/tfs/mod.rs:725:22 [INFO] [stdout] | [INFO] [stdout] 725 | Some(metaData) => { [INFO] [stdout] | ^^^^^^^^ help: convert the identifier to snake case: `meta_data` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `FileDescriptor` should have a snake case name [INFO] [stdout] --> src/tfs/disk.rs:10:5 [INFO] [stdout] | [INFO] [stdout] 10 | FileDescriptor: Option, [INFO] [stdout] | ^^^^^^^^^^^^^^ help: convert the identifier to snake case: `file_descriptor` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `Blocks` should have a snake case name [INFO] [stdout] --> src/tfs/disk.rs:11:5 [INFO] [stdout] | [INFO] [stdout] 11 | Blocks: usize, // Number of blocks in disk image [INFO] [stdout] | ^^^^^^ help: convert the identifier to snake case: `blocks` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `Reads` should have a snake case name [INFO] [stdout] --> src/tfs/disk.rs:12:5 [INFO] [stdout] | [INFO] [stdout] 12 | Reads: usize, // Number of reads performed [INFO] [stdout] | ^^^^^ help: convert the identifier to snake case: `reads` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `Writes` should have a snake case name [INFO] [stdout] --> src/tfs/disk.rs:13:5 [INFO] [stdout] | [INFO] [stdout] 13 | Writes: usize, // Number of writes performed [INFO] [stdout] | ^^^^^^ help: convert the identifier to snake case (notice the capitalization): `writes` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `Mounts` should have a snake case name [INFO] [stdout] --> src/tfs/disk.rs:14:5 [INFO] [stdout] | [INFO] [stdout] 14 | Mounts: usize, // Number of mounts [INFO] [stdout] | ^^^^^^ help: convert the identifier to snake case: `mounts` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `Path` should have a snake case name [INFO] [stdout] --> src/tfs/disk.rs:15:5 [INFO] [stdout] | [INFO] [stdout] 15 | Path: &'a str // file path for the disk [INFO] [stdout] | ^^^^ help: convert the identifier to snake case: `path` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison is useless due to type limits [INFO] [stdout] --> src/tfs/disk.rs:21:12 [INFO] [stdout] | [INFO] [stdout] 21 | if blocknum < 0 { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_comparisons)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/tfs/disk.rs:68:17 [INFO] [stdout] | [INFO] [stdout] 68 | f.set_len((nblocks as u64) * (Self::BLOCK_SIZE as u64)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/tfs/disk.rs:105:17 [INFO] [stdout] | [INFO] [stdout] 105 | file.seek(SeekFrom::Start( blocknum as u64 * Self::BLOCK_SIZE as u64)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/tfs/disk.rs:106:17 [INFO] [stdout] | [INFO] [stdout] 106 | file.read(data); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/tfs/disk.rs:117:17 [INFO] [stdout] | [INFO] [stdout] 117 | file.seek(SeekFrom::Start(blocknum as u64 * Self::BLOCK_SIZE as u64)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/tfs/disk.rs:118:17 [INFO] [stdout] | [INFO] [stdout] 118 | file.write(data); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `MagicNumber` should have a snake case name [INFO] [stdout] --> src/tfs/types.rs:13:9 [INFO] [stdout] | [INFO] [stdout] 13 | pub MagicNumber: u32, [INFO] [stdout] | ^^^^^^^^^^^ help: convert the identifier to snake case: `magic_number` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `Blocks` should have a snake case name [INFO] [stdout] --> src/tfs/types.rs:14:9 [INFO] [stdout] | [INFO] [stdout] 14 | pub Blocks: u32, [INFO] [stdout] | ^^^^^^ help: convert the identifier to snake case: `blocks` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `InodeBlocks` should have a snake case name [INFO] [stdout] --> src/tfs/types.rs:15:9 [INFO] [stdout] | [INFO] [stdout] 15 | pub InodeBlocks: u32, [INFO] [stdout] | ^^^^^^^^^^^ help: convert the identifier to snake case: `inode_blocks` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `Inodes` should have a snake case name [INFO] [stdout] --> src/tfs/types.rs:16:9 [INFO] [stdout] | [INFO] [stdout] 16 | pub Inodes: u32 [INFO] [stdout] | ^^^^^^ help: convert the identifier to snake case (notice the capitalization): `inodes` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `Valid` should have a snake case name [INFO] [stdout] --> src/tfs/types.rs:22:9 [INFO] [stdout] | [INFO] [stdout] 22 | pub Valid: u32, // whether or not inode is valid (or allocated) [INFO] [stdout] | ^^^^^ help: convert the identifier to snake case (notice the capitalization): `valid` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `Size` should have a snake case name [INFO] [stdout] --> src/tfs/types.rs:23:9 [INFO] [stdout] | [INFO] [stdout] 23 | pub Size: u32, // size of file [INFO] [stdout] | ^^^^ help: convert the identifier to snake case (notice the capitalization): `size` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `Direct` should have a snake case name [INFO] [stdout] --> src/tfs/types.rs:24:9 [INFO] [stdout] | [INFO] [stdout] 24 | pub Direct: [u32; POINTERS_PER_INODE], [INFO] [stdout] | ^^^^^^ help: convert the identifier to snake case: `direct` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `Indirect` should have a snake case name [INFO] [stdout] --> src/tfs/types.rs:25:9 [INFO] [stdout] | [INFO] [stdout] 25 | pub Indirect: u32 [INFO] [stdout] | ^^^^^^^^ help: convert the identifier to snake case (notice the capitalization): `indirect` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `Super` should have a snake case name [INFO] [stdout] --> src/tfs/types.rs:31:9 [INFO] [stdout] | [INFO] [stdout] 31 | pub Super: Superblock, [INFO] [stdout] | ^^^^^ help: rename the identifier [INFO] [stdout] | [INFO] [stdout] = note: `super` cannot be used as a raw identifier [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `Inodes` should have a snake case name [INFO] [stdout] --> src/tfs/types.rs:32:9 [INFO] [stdout] | [INFO] [stdout] 32 | pub Inodes: [Inode; INODES_PER_BLOCK], [INFO] [stdout] | ^^^^^^ help: convert the identifier to snake case (notice the capitalization): `inodes` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `Pointers` should have a snake case name [INFO] [stdout] --> src/tfs/types.rs:33:9 [INFO] [stdout] | [INFO] [stdout] 33 | pub Pointers: [u32; POINTERS_PER_BLOCK], [INFO] [stdout] | ^^^^^^^^ help: convert the identifier to snake case: `pointers` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `Data` should have a snake case name [INFO] [stdout] --> src/tfs/types.rs:34:9 [INFO] [stdout] | [INFO] [stdout] 34 | pub Data: [u8; Disk::BLOCK_SIZE] [INFO] [stdout] | ^^^^ help: convert the identifier to snake case: `data` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `superBlock` should have a snake case name [INFO] [stdout] --> src/tfs/types.rs:40:9 [INFO] [stdout] | [INFO] [stdout] 40 | pub superBlock: Superblock, [INFO] [stdout] | ^^^^^^^^^^ help: convert the identifier to snake case: `super_block` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `inodeTable` should have a snake case name [INFO] [stdout] --> src/tfs/types.rs:41:9 [INFO] [stdout] | [INFO] [stdout] 41 | pub inodeTable: Vec<[Inode; INODES_PER_BLOCK]> [INFO] [stdout] | ^^^^^^^^^^ help: convert the identifier to snake case: `inode_table` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 68 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::error::Error` [INFO] [stdout] --> src/main.rs:5:5 [INFO] [stdout] | [INFO] [stdout] 5 | use std::error::Error; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `File` [INFO] [stdout] --> src/main.rs:251:19 [INFO] [stdout] | [INFO] [stdout] 251 | use std::fs::{File, OpenOptions}; [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `File` [INFO] [stdout] --> src/main.rs:294:19 [INFO] [stdout] | [INFO] [stdout] 294 | use std::fs::{File, OpenOptions}; [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `super::utility` [INFO] [stdout] --> src/tfs/types.rs:3:5 [INFO] [stdout] | [INFO] [stdout] 3 | use super::utility; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `bytes_read` [INFO] [stdout] --> src/main.rs:84:9 [INFO] [stdout] | [INFO] [stdout] 84 | let bytes_read = stdin().read_line(&mut line).unwrap(); [INFO] [stdout] | ^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_bytes_read` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/main.rs:150:18 [INFO] [stdout] | [INFO] [stdout] 150 | fn do_create<'a>(mut disk: Disk<'a>, [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/main.rs:167:18 [INFO] [stdout] | [INFO] [stdout] 167 | fn do_remove<'a>(mut disk: Disk<'a>, [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/main.rs:185:16 [INFO] [stdout] | [INFO] [stdout] 185 | fn do_stat<'a>(mut disk: Disk<'a>, [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/main.rs:204:18 [INFO] [stdout] | [INFO] [stdout] 204 | fn do_copyin<'a>(mut disk: Disk<'a>, [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/main.rs:205:5 [INFO] [stdout] | [INFO] [stdout] 205 | mut fs: FileSystem<'a>, args: Vec<&str>) [INFO] [stdout] | ----^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/main.rs:222:19 [INFO] [stdout] | [INFO] [stdout] 222 | fn do_copyout<'a>(mut disk: Disk<'a>, [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/main.rs:223:5 [INFO] [stdout] | [INFO] [stdout] 223 | mut fs: FileSystem<'a>, args: Vec<&str>) [INFO] [stdout] | ----^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/main.rs:262:9 [INFO] [stdout] | [INFO] [stdout] 262 | let mut offset = 0; [INFO] [stdout] | ----^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/main.rs:325:15 [INFO] [stdout] | [INFO] [stdout] 325 | fn do_cat<'a>(mut fs: FileSystem<'a>, args: Vec<&str>) -> FileSystem<'a> { [INFO] [stdout] | ----^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison is useless due to type limits [INFO] [stdout] --> src/main.rs:157:16 [INFO] [stdout] | [INFO] [stdout] 157 | if inumber >= 0 { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_comparisons)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/main.rs:282:9 [INFO] [stdout] | [INFO] [stdout] 282 | file.seek(SeekFrom::Start( n as u64 * Disk::BLOCK_SIZE as u64)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/main.rs:315:13 [INFO] [stdout] | [INFO] [stdout] 315 | file.write(&mut buff); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/main.rs:317:13 [INFO] [stdout] | [INFO] [stdout] 317 | file.write(&mut buffer); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unreachable expression [INFO] [stdout] --> src/tfs/mod.rs:407:9 [INFO] [stdout] | [INFO] [stdout] 353 | / loop { [INFO] [stdout] 354 | | if bytes_read == length || j == length { [INFO] [stdout] 355 | | return bytes_read as i64; [INFO] [stdout] 356 | | } [INFO] [stdout] ... | [INFO] [stdout] 404 | | println!("BYTES INDEX: {}, {}", block_index, block_offset); [INFO] [stdout] 405 | | } [INFO] [stdout] | |_________- any code following this expression is unreachable [INFO] [stdout] 406 | [INFO] [stdout] 407 | -1 [INFO] [stdout] | ^^ unreachable expression [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unreachable_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unreachable expression [INFO] [stdout] --> src/tfs/mod.rs:533:9 [INFO] [stdout] | [INFO] [stdout] 507 | / loop { [INFO] [stdout] 508 | | if bytes_writen < length && (offset + bytes_writen) < data.len() { [INFO] [stdout] 509 | | let bytes_wr = self.write_to_block(block_num, block_offset, data, length - bytes_writen, offset + bytes_writen); [INFO] [stdout] 510 | | println!("bytes_writen: {}", bytes_wr); [INFO] [stdout] ... | [INFO] [stdout] 530 | | } [INFO] [stdout] 531 | | } [INFO] [stdout] | |_________- any code following this expression is unreachable [INFO] [stdout] 532 | [INFO] [stdout] 533 | bytes_writen as i64 [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ unreachable expression [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `i` [INFO] [stdout] --> src/tfs/mod.rs:140:13 [INFO] [stdout] | [INFO] [stdout] 140 | for i in 0..nBlocks - inodeBlocks - 1 { [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_i` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `metaData` [INFO] [stdout] --> src/tfs/mod.rs:225:18 [INFO] [stdout] | [INFO] [stdout] 225 | Some(metaData) => { [INFO] [stdout] | ^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_metaData` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `disk` [INFO] [stdout] --> src/tfs/mod.rs:227:26 [INFO] [stdout] | [INFO] [stdout] 227 | Some(disk) => { [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_disk` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `i` [INFO] [stdout] --> src/tfs/mod.rs:855:17 [INFO] [stdout] | [INFO] [stdout] 855 | let mut i = 0; [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_i` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/tfs/disk.rs:60:13 [INFO] [stdout] | [INFO] [stdout] 60 | let mut file = OpenOptions::new() [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/tfs/disk.rs:104:18 [INFO] [stdout] | [INFO] [stdout] 104 | Some(mut file) => { [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/tfs/disk.rs:116:18 [INFO] [stdout] | [INFO] [stdout] 116 | Some(mut file) => { [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/tfs/mod.rs:345:13 [INFO] [stdout] | [INFO] [stdout] 345 | let mut block_index = (offset as f64 / Disk::BLOCK_SIZE as f64).floor() as usize; [INFO] [stdout] | ----^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/tfs/mod.rs:450:13 [INFO] [stdout] | [INFO] [stdout] 450 | let mut disc = match &mut self.disk { [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/tfs/mod.rs:684:13 [INFO] [stdout] | [INFO] [stdout] 684 | let mut disk = match &mut self.disk { [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/tfs/mod.rs:855:13 [INFO] [stdout] | [INFO] [stdout] 855 | let mut i = 0; [INFO] [stdout] | ----^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary `unsafe` block [INFO] [stdout] --> src/tfs/types.rs:90:9 [INFO] [stdout] | [INFO] [stdout] 90 | unsafe { [INFO] [stdout] | ^^^^^^ unnecessary `unsafe` block [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_unsafe)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary `unsafe` block [INFO] [stdout] --> src/tfs/types.rs:96:9 [INFO] [stdout] | [INFO] [stdout] 96 | unsafe { [INFO] [stdout] | ^^^^^^ unnecessary `unsafe` block [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary `unsafe` block [INFO] [stdout] --> src/tfs/types.rs:102:9 [INFO] [stdout] | [INFO] [stdout] 102 | unsafe { [INFO] [stdout] | ^^^^^^ unnecessary `unsafe` block [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary `unsafe` block [INFO] [stdout] --> src/tfs/types.rs:108:9 [INFO] [stdout] | [INFO] [stdout] 108 | unsafe { [INFO] [stdout] | ^^^^^^ unnecessary `unsafe` block [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function is never used: `disk_open` [INFO] [stdout] --> src/tfs/disk.rs:132:8 [INFO] [stdout] | [INFO] [stdout] 132 | fn disk_open() { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function is never used: `disk_read_write` [INFO] [stdout] --> src/tfs/disk.rs:139:8 [INFO] [stdout] | [INFO] [stdout] 139 | fn disk_read_write() { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function is never used: `disk_clone` [INFO] [stdout] --> src/tfs/disk.rs:152:8 [INFO] [stdout] | [INFO] [stdout] 152 | fn disk_clone() { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function is never used: `as_u32_be` [INFO] [stdout] --> src/tfs/utility.rs:1:8 [INFO] [stdout] | [INFO] [stdout] 1 | pub fn as_u32_be(array: &[u8; 4]) -> u32 { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function is never used: `as_u32_le` [INFO] [stdout] --> src/tfs/utility.rs:8:8 [INFO] [stdout] | [INFO] [stdout] 8 | pub fn as_u32_le(array: &[u8; 4]) -> u32 { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function is never used: `as_u32` [INFO] [stdout] --> src/tfs/utility.rs:15:8 [INFO] [stdout] | [INFO] [stdout] 15 | pub fn as_u32(array: &[u8]) -> u32 { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function is never used: `test_debug` [INFO] [stdout] --> src/tfs/mod.rs:795:8 [INFO] [stdout] | [INFO] [stdout] 795 | fn test_debug() { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function is never used: `test_format` [INFO] [stdout] --> src/tfs/mod.rs:805:8 [INFO] [stdout] | [INFO] [stdout] 805 | fn test_format() { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function is never used: `test_mount` [INFO] [stdout] --> src/tfs/mod.rs:813:8 [INFO] [stdout] | [INFO] [stdout] 813 | fn test_mount() { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function is never used: `test_create_remove_inode` [INFO] [stdout] --> src/tfs/mod.rs:821:8 [INFO] [stdout] | [INFO] [stdout] 821 | fn test_create_remove_inode() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `metaData` should have a snake case name [INFO] [stdout] --> src/tfs/mod.rs:9:9 [INFO] [stdout] | [INFO] [stdout] 9 | pub metaData: Option, [INFO] [stdout] | ^^^^^^^^ help: convert the identifier to snake case: `meta_data` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_snake_case)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `inodeBitMap` should have a snake case name [INFO] [stdout] --> src/tfs/mod.rs:10:9 [INFO] [stdout] | [INFO] [stdout] 10 | pub inodeBitMap: Option>, [INFO] [stdout] | ^^^^^^^^^^^ help: convert the identifier to snake case: `inode_bit_map` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `dataBitMap` should have a snake case name [INFO] [stdout] --> src/tfs/mod.rs:11:9 [INFO] [stdout] | [INFO] [stdout] 11 | pub dataBitMap: Option>, [INFO] [stdout] | ^^^^^^^^^^ help: convert the identifier to snake case: `data_bit_map` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `metaData` should have a snake case name [INFO] [stdout] --> src/tfs/mod.rs:54:18 [INFO] [stdout] | [INFO] [stdout] 54 | Some(metaData) => Self::debug_print(metaData), [INFO] [stdout] | ^^^^^^^^ help: convert the identifier to snake case: `meta_data` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `metaData` should have a snake case name [INFO] [stdout] --> src/tfs/mod.rs:60:13 [INFO] [stdout] | [INFO] [stdout] 60 | let metaData = Self::read_meta_data(disk); [INFO] [stdout] | ^^^^^^^^ help: convert the identifier to snake case: `meta_data` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `inodeTable` should have a snake case name [INFO] [stdout] --> src/tfs/mod.rs:66:13 [INFO] [stdout] | [INFO] [stdout] 66 | let inodeTable = &meta_data.inodeTable; [INFO] [stdout] | ^^^^^^^^^^ help: convert the identifier to snake case: `inode_table` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `metaData` should have a snake case name [INFO] [stdout] --> src/tfs/mod.rs:122:13 [INFO] [stdout] | [INFO] [stdout] 122 | let metaData = Self::read_meta_data(disk); [INFO] [stdout] | ^^^^^^^^ help: convert the identifier to snake case: `meta_data` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `metaData2` should have a snake case name [INFO] [stdout] --> src/tfs/mod.rs:123:13 [INFO] [stdout] | [INFO] [stdout] 123 | let metaData2 = Self::read_meta_data(disk); // ...have no idea how to make a copy [INFO] [stdout] | ^^^^^^^^^ help: convert the identifier to snake case: `meta_data2` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `nBlocks` should have a snake case name [INFO] [stdout] --> src/tfs/mod.rs:133:13 [INFO] [stdout] | [INFO] [stdout] 133 | let nBlocks = metaData.superBlock.Blocks; [INFO] [stdout] | ^^^^^^^ help: convert the identifier to snake case: `n_blocks` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `inodeBlocks` should have a snake case name [INFO] [stdout] --> src/tfs/mod.rs:134:13 [INFO] [stdout] | [INFO] [stdout] 134 | let inodeBlocks = metaData.superBlock.InodeBlocks; [INFO] [stdout] | ^^^^^^^^^^^ help: convert the identifier to snake case: `inode_blocks` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `metaData` should have a snake case name [INFO] [stdout] --> src/tfs/mod.rs:200:38 [INFO] [stdout] | [INFO] [stdout] 200 | ... Some(metaData) => { [INFO] [stdout] | ^^^^^^^^ help: convert the identifier to snake case: `meta_data` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `metaData` should have a snake case name [INFO] [stdout] --> src/tfs/mod.rs:225:18 [INFO] [stdout] | [INFO] [stdout] 225 | Some(metaData) => { [INFO] [stdout] | ^^^^^^^^ help: convert the identifier to snake case: `meta_data` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `metaData` should have a snake case name [INFO] [stdout] --> src/tfs/mod.rs:248:22 [INFO] [stdout] | [INFO] [stdout] 248 | Some(metaData) => { [INFO] [stdout] | ^^^^^^^^ help: convert the identifier to snake case: `meta_data` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `ibitMap` should have a snake case name [INFO] [stdout] --> src/tfs/mod.rs:257:22 [INFO] [stdout] | [INFO] [stdout] 257 | Some(ibitMap)=> { [INFO] [stdout] | ^^^^^^^ help: convert the identifier to snake case: `ibit_map` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `superBlock` should have a snake case name [INFO] [stdout] --> src/tfs/mod.rs:544:13 [INFO] [stdout] | [INFO] [stdout] 544 | let superBlock = block.superblock(); [INFO] [stdout] | ^^^^^^^^^^ help: convert the identifier to snake case: `super_block` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `inodeTable` should have a snake case name [INFO] [stdout] --> src/tfs/mod.rs:547:17 [INFO] [stdout] | [INFO] [stdout] 547 | let mut inodeTable = Vec::new(); [INFO] [stdout] | ^^^^^^^^^^ help: convert the identifier to snake case: `inode_table` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `metaData` should have a snake case name [INFO] [stdout] --> src/tfs/mod.rs:563:18 [INFO] [stdout] | [INFO] [stdout] 563 | Some(metaData) => { [INFO] [stdout] | ^^^^^^^^ help: convert the identifier to snake case: `meta_data` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `metaData` should have a snake case name [INFO] [stdout] --> src/tfs/mod.rs:581:18 [INFO] [stdout] | [INFO] [stdout] 581 | Some(metaData) => { [INFO] [stdout] | ^^^^^^^^ help: convert the identifier to snake case: `meta_data` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `metaData` should have a snake case name [INFO] [stdout] --> src/tfs/mod.rs:658:26 [INFO] [stdout] | [INFO] [stdout] 658 | Some(metaData) => { [INFO] [stdout] | ^^^^^^^^ help: convert the identifier to snake case: `meta_data` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `dataBitMap` should have a snake case name [INFO] [stdout] --> src/tfs/mod.rs:693:31 [INFO] [stdout] | [INFO] [stdout] 693 | let get_free_block = |dataBitMap: Option<&Vec>| { [INFO] [stdout] | ^^^^^^^^^^ help: convert the identifier to snake case: `data_bit_map` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `dataBitMap` should have a snake case name [INFO] [stdout] --> src/tfs/mod.rs:695:22 [INFO] [stdout] | [INFO] [stdout] 695 | Some(dataBitMap) => { [INFO] [stdout] | ^^^^^^^^^^ help: convert the identifier to snake case: `data_bit_map` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `dataBitMap` should have a snake case name [INFO] [stdout] --> src/tfs/mod.rs:718:22 [INFO] [stdout] | [INFO] [stdout] 718 | Some(dataBitMap) => { [INFO] [stdout] | ^^^^^^^^^^ help: convert the identifier to snake case: `data_bit_map` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `metaData` should have a snake case name [INFO] [stdout] --> src/tfs/mod.rs:725:22 [INFO] [stdout] | [INFO] [stdout] 725 | Some(metaData) => { [INFO] [stdout] | ^^^^^^^^ help: convert the identifier to snake case: `meta_data` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `FileDescriptor` should have a snake case name [INFO] [stdout] --> src/tfs/disk.rs:10:5 [INFO] [stdout] | [INFO] [stdout] 10 | FileDescriptor: Option, [INFO] [stdout] | ^^^^^^^^^^^^^^ help: convert the identifier to snake case: `file_descriptor` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `Blocks` should have a snake case name [INFO] [stdout] --> src/tfs/disk.rs:11:5 [INFO] [stdout] | [INFO] [stdout] 11 | Blocks: usize, // Number of blocks in disk image [INFO] [stdout] | ^^^^^^ help: convert the identifier to snake case: `blocks` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `Reads` should have a snake case name [INFO] [stdout] --> src/tfs/disk.rs:12:5 [INFO] [stdout] | [INFO] [stdout] 12 | Reads: usize, // Number of reads performed [INFO] [stdout] | ^^^^^ help: convert the identifier to snake case: `reads` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `Writes` should have a snake case name [INFO] [stdout] --> src/tfs/disk.rs:13:5 [INFO] [stdout] | [INFO] [stdout] 13 | Writes: usize, // Number of writes performed [INFO] [stdout] | ^^^^^^ help: convert the identifier to snake case (notice the capitalization): `writes` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `Mounts` should have a snake case name [INFO] [stdout] --> src/tfs/disk.rs:14:5 [INFO] [stdout] | [INFO] [stdout] 14 | Mounts: usize, // Number of mounts [INFO] [stdout] | ^^^^^^ help: convert the identifier to snake case: `mounts` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `Path` should have a snake case name [INFO] [stdout] --> src/tfs/disk.rs:15:5 [INFO] [stdout] | [INFO] [stdout] 15 | Path: &'a str // file path for the disk [INFO] [stdout] | ^^^^ help: convert the identifier to snake case: `path` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison is useless due to type limits [INFO] [stdout] --> src/tfs/disk.rs:21:12 [INFO] [stdout] | [INFO] [stdout] 21 | if blocknum < 0 { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_comparisons)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/tfs/disk.rs:68:17 [INFO] [stdout] | [INFO] [stdout] 68 | f.set_len((nblocks as u64) * (Self::BLOCK_SIZE as u64)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/tfs/disk.rs:105:17 [INFO] [stdout] | [INFO] [stdout] 105 | file.seek(SeekFrom::Start( blocknum as u64 * Self::BLOCK_SIZE as u64)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/tfs/disk.rs:106:17 [INFO] [stdout] | [INFO] [stdout] 106 | file.read(data); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/tfs/disk.rs:117:17 [INFO] [stdout] | [INFO] [stdout] 117 | file.seek(SeekFrom::Start(blocknum as u64 * Self::BLOCK_SIZE as u64)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/tfs/disk.rs:118:17 [INFO] [stdout] | [INFO] [stdout] 118 | file.write(data); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `MagicNumber` should have a snake case name [INFO] [stdout] --> src/tfs/types.rs:13:9 [INFO] [stdout] | [INFO] [stdout] 13 | pub MagicNumber: u32, [INFO] [stdout] | ^^^^^^^^^^^ help: convert the identifier to snake case: `magic_number` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `Blocks` should have a snake case name [INFO] [stdout] --> src/tfs/types.rs:14:9 [INFO] [stdout] | [INFO] [stdout] 14 | pub Blocks: u32, [INFO] [stdout] | ^^^^^^ help: convert the identifier to snake case: `blocks` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `InodeBlocks` should have a snake case name [INFO] [stdout] --> src/tfs/types.rs:15:9 [INFO] [stdout] | [INFO] [stdout] 15 | pub InodeBlocks: u32, [INFO] [stdout] | ^^^^^^^^^^^ help: convert the identifier to snake case: `inode_blocks` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `Inodes` should have a snake case name [INFO] [stdout] --> src/tfs/types.rs:16:9 [INFO] [stdout] | [INFO] [stdout] 16 | pub Inodes: u32 [INFO] [stdout] | ^^^^^^ help: convert the identifier to snake case (notice the capitalization): `inodes` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `Valid` should have a snake case name [INFO] [stdout] --> src/tfs/types.rs:22:9 [INFO] [stdout] | [INFO] [stdout] 22 | pub Valid: u32, // whether or not inode is valid (or allocated) [INFO] [stdout] | ^^^^^ help: convert the identifier to snake case (notice the capitalization): `valid` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `Size` should have a snake case name [INFO] [stdout] --> src/tfs/types.rs:23:9 [INFO] [stdout] | [INFO] [stdout] 23 | pub Size: u32, // size of file [INFO] [stdout] | ^^^^ help: convert the identifier to snake case (notice the capitalization): `size` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `Direct` should have a snake case name [INFO] [stdout] --> src/tfs/types.rs:24:9 [INFO] [stdout] | [INFO] [stdout] 24 | pub Direct: [u32; POINTERS_PER_INODE], [INFO] [stdout] | ^^^^^^ help: convert the identifier to snake case: `direct` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `Indirect` should have a snake case name [INFO] [stdout] --> src/tfs/types.rs:25:9 [INFO] [stdout] | [INFO] [stdout] 25 | pub Indirect: u32 [INFO] [stdout] | ^^^^^^^^ help: convert the identifier to snake case (notice the capitalization): `indirect` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `Super` should have a snake case name [INFO] [stdout] --> src/tfs/types.rs:31:9 [INFO] [stdout] | [INFO] [stdout] 31 | pub Super: Superblock, [INFO] [stdout] | ^^^^^ help: rename the identifier [INFO] [stdout] | [INFO] [stdout] = note: `super` cannot be used as a raw identifier [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `Inodes` should have a snake case name [INFO] [stdout] --> src/tfs/types.rs:32:9 [INFO] [stdout] | [INFO] [stdout] 32 | pub Inodes: [Inode; INODES_PER_BLOCK], [INFO] [stdout] | ^^^^^^ help: convert the identifier to snake case (notice the capitalization): `inodes` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `Pointers` should have a snake case name [INFO] [stdout] --> src/tfs/types.rs:33:9 [INFO] [stdout] | [INFO] [stdout] 33 | pub Pointers: [u32; POINTERS_PER_BLOCK], [INFO] [stdout] | ^^^^^^^^ help: convert the identifier to snake case: `pointers` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `Data` should have a snake case name [INFO] [stdout] --> src/tfs/types.rs:34:9 [INFO] [stdout] | [INFO] [stdout] 34 | pub Data: [u8; Disk::BLOCK_SIZE] [INFO] [stdout] | ^^^^ help: convert the identifier to snake case: `data` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `superBlock` should have a snake case name [INFO] [stdout] --> src/tfs/types.rs:40:9 [INFO] [stdout] | [INFO] [stdout] 40 | pub superBlock: Superblock, [INFO] [stdout] | ^^^^^^^^^^ help: convert the identifier to snake case: `super_block` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `inodeTable` should have a snake case name [INFO] [stdout] --> src/tfs/types.rs:41:9 [INFO] [stdout] | [INFO] [stdout] 41 | pub inodeTable: Vec<[Inode; INODES_PER_BLOCK]> [INFO] [stdout] | ^^^^^^^^^^ help: convert the identifier to snake case: `inode_table` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 17 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 77 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished test [unoptimized + debuginfo] target(s) in 0.70s [INFO] running `Command { std: "docker" "inspect" "8768b2f2bd84ef79ef19051c5fce7105509f3be841d4f4f0e8e1e7e39dad610c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "8768b2f2bd84ef79ef19051c5fce7105509f3be841d4f4f0e8e1e7e39dad610c", kill_on_drop: false }` [INFO] [stdout] 8768b2f2bd84ef79ef19051c5fce7105509f3be841d4f4f0e8e1e7e39dad610c [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-107/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-107/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:5736fa189c1c60b01babf4b8b698fe57b6ecc41933a7ff2e0b8d7a221459412b" "/opt/rustwide/cargo-home/bin/cargo" "+722e1797249a965b6335aebd65d777f917e498f1" "test" "--frozen", kill_on_drop: false }` [INFO] [stdout] e87eeb56f99243848a8883b159734630de9eb5168953e286995af8409384df43 [INFO] running `Command { std: "docker" "start" "-a" "e87eeb56f99243848a8883b159734630de9eb5168953e286995af8409384df43", kill_on_drop: false }` [INFO] [stderr] warning: unused import: `super::utility` [INFO] [stderr] --> src/tfs/types.rs:3:5 [INFO] [stderr] | [INFO] [stderr] 3 | use super::utility; [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(unused_imports)]` on by default [INFO] [stderr] [INFO] [stderr] warning: unreachable expression [INFO] [stderr] --> src/tfs/mod.rs:407:9 [INFO] [stderr] | [INFO] [stderr] 353 | / loop { [INFO] [stderr] 354 | | if bytes_read == length || j == length { [INFO] [stderr] 355 | | return bytes_read as i64; [INFO] [stderr] 356 | | } [INFO] [stderr] ... | [INFO] [stderr] 404 | | println!("BYTES INDEX: {}, {}", block_index, block_offset); [INFO] [stderr] 405 | | } [INFO] [stderr] | |_________- any code following this expression is unreachable [INFO] [stderr] 406 | [INFO] [stderr] 407 | -1 [INFO] [stderr] | ^^ unreachable expression [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(unreachable_code)]` on by default [INFO] [stderr] [INFO] [stderr] warning: unreachable expression [INFO] [stderr] --> src/tfs/mod.rs:533:9 [INFO] [stderr] | [INFO] [stderr] 507 | / loop { [INFO] [stderr] 508 | | if bytes_writen < length && (offset + bytes_writen) < data.len() { [INFO] [stderr] 509 | | let bytes_wr = self.write_to_block(block_num, block_offset, data, length - bytes_writen, offset + bytes_writen); [INFO] [stderr] 510 | | println!("bytes_writen: {}", bytes_wr); [INFO] [stderr] ... | [INFO] [stderr] 530 | | } [INFO] [stderr] 531 | | } [INFO] [stderr] | |_________- any code following this expression is unreachable [INFO] [stderr] 532 | [INFO] [stderr] 533 | bytes_writen as i64 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ unreachable expression [INFO] [stderr] [INFO] [stderr] warning: unused variable: `i` [INFO] [stderr] --> src/tfs/mod.rs:140:13 [INFO] [stderr] | [INFO] [stderr] 140 | for i in 0..nBlocks - inodeBlocks - 1 { [INFO] [stderr] | ^ help: if this is intentional, prefix it with an underscore: `_i` [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(unused_variables)]` on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `metaData` [INFO] [stderr] --> src/tfs/mod.rs:225:18 [INFO] [stderr] | [INFO] [stderr] 225 | Some(metaData) => { [INFO] [stderr] | ^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_metaData` [INFO] [stderr] [INFO] [stderr] warning: unused variable: `disk` [INFO] [stderr] --> src/tfs/mod.rs:227:26 [INFO] [stderr] | [INFO] [stderr] 227 | Some(disk) => { [INFO] [stderr] | ^^^^ help: if this is intentional, prefix it with an underscore: `_disk` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/tfs/disk.rs:60:13 [INFO] [stderr] | [INFO] [stderr] 60 | let mut file = OpenOptions::new() [INFO] [stderr] | ----^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(unused_mut)]` on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/tfs/disk.rs:104:18 [INFO] [stderr] | [INFO] [stderr] 104 | Some(mut file) => { [INFO] [stderr] | ----^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/tfs/disk.rs:116:18 [INFO] [stderr] | [INFO] [stderr] 116 | Some(mut file) => { [INFO] [stderr] | ----^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/tfs/mod.rs:345:13 [INFO] [stderr] | [INFO] [stderr] 345 | let mut block_index = (offset as f64 / Disk::BLOCK_SIZE as f64).floor() as usize; [INFO] [stderr] | ----^^^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/tfs/mod.rs:450:13 [INFO] [stderr] | [INFO] [stderr] 450 | let mut disc = match &mut self.disk { [INFO] [stderr] | ----^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/tfs/mod.rs:684:13 [INFO] [stderr] | [INFO] [stderr] 684 | let mut disk = match &mut self.disk { [INFO] [stderr] | ----^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: unnecessary `unsafe` block [INFO] [stderr] --> src/tfs/types.rs:90:9 [INFO] [stderr] | [INFO] [stderr] 90 | unsafe { [INFO] [stderr] | ^^^^^^ unnecessary `unsafe` block [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(unused_unsafe)]` on by default [INFO] [stderr] [INFO] [stderr] warning: unnecessary `unsafe` block [INFO] [stderr] --> src/tfs/types.rs:96:9 [INFO] [stderr] | [INFO] [stderr] 96 | unsafe { [INFO] [stderr] | ^^^^^^ unnecessary `unsafe` block [INFO] [stderr] [INFO] [stderr] warning: unnecessary `unsafe` block [INFO] [stderr] --> src/tfs/types.rs:102:9 [INFO] [stderr] | [INFO] [stderr] 102 | unsafe { [INFO] [stderr] | ^^^^^^ unnecessary `unsafe` block [INFO] [stderr] [INFO] [stderr] warning: unnecessary `unsafe` block [INFO] [stderr] --> src/tfs/types.rs:108:9 [INFO] [stderr] | [INFO] [stderr] 108 | unsafe { [INFO] [stderr] | ^^^^^^ unnecessary `unsafe` block [INFO] [stderr] [INFO] [stderr] warning: function is never used: `as_u32_be` [INFO] [stderr] --> src/tfs/utility.rs:1:8 [INFO] [stderr] | [INFO] [stderr] 1 | pub fn as_u32_be(array: &[u8; 4]) -> u32 { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(dead_code)]` on by default [INFO] [stderr] [INFO] [stderr] warning: function is never used: `as_u32_le` [INFO] [stderr] --> src/tfs/utility.rs:8:8 [INFO] [stderr] | [INFO] [stderr] 8 | pub fn as_u32_le(array: &[u8; 4]) -> u32 { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `as_u32` [INFO] [stderr] --> src/tfs/utility.rs:15:8 [INFO] [stderr] | [INFO] [stderr] 15 | pub fn as_u32(array: &[u8]) -> u32 { [INFO] [stderr] | ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: structure field `metaData` should have a snake case name [INFO] [stderr] --> src/tfs/mod.rs:9:9 [INFO] [stderr] | [INFO] [stderr] 9 | pub metaData: Option, [INFO] [stderr] | ^^^^^^^^ help: convert the identifier to snake case: `meta_data` [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(non_snake_case)]` on by default [INFO] [stderr] [INFO] [stderr] warning: structure field `inodeBitMap` should have a snake case name [INFO] [stderr] --> src/tfs/mod.rs:10:9 [INFO] [stderr] | [INFO] [stderr] 10 | pub inodeBitMap: Option>, [INFO] [stderr] | ^^^^^^^^^^^ help: convert the identifier to snake case: `inode_bit_map` [INFO] [stderr] [INFO] [stderr] warning: structure field `dataBitMap` should have a snake case name [INFO] [stderr] --> src/tfs/mod.rs:11:9 [INFO] [stderr] | [INFO] [stderr] 11 | pub dataBitMap: Option>, [INFO] [stderr] | ^^^^^^^^^^ help: convert the identifier to snake case: `data_bit_map` [INFO] [stderr] [INFO] [stderr] warning: variable `metaData` should have a snake case name [INFO] [stderr] --> src/tfs/mod.rs:54:18 [INFO] [stderr] | [INFO] [stderr] 54 | Some(metaData) => Self::debug_print(metaData), [INFO] [stderr] | ^^^^^^^^ help: convert the identifier to snake case: `meta_data` [INFO] [stderr] [INFO] [stderr] warning: variable `metaData` should have a snake case name [INFO] [stderr] --> src/tfs/mod.rs:60:13 [INFO] [stderr] | [INFO] [stderr] 60 | let metaData = Self::read_meta_data(disk); [INFO] [stderr] | ^^^^^^^^ help: convert the identifier to snake case: `meta_data` [INFO] [stderr] [INFO] [stderr] warning: variable `inodeTable` should have a snake case name [INFO] [stderr] --> src/tfs/mod.rs:66:13 [INFO] [stderr] | [INFO] [stderr] 66 | let inodeTable = &meta_data.inodeTable; [INFO] [stderr] | ^^^^^^^^^^ help: convert the identifier to snake case: `inode_table` [INFO] [stderr] [INFO] [stderr] warning: variable `metaData` should have a snake case name [INFO] [stderr] --> src/tfs/mod.rs:122:13 [INFO] [stderr] | [INFO] [stderr] 122 | let metaData = Self::read_meta_data(disk); [INFO] [stderr] | ^^^^^^^^ help: convert the identifier to snake case: `meta_data` [INFO] [stderr] [INFO] [stderr] warning: variable `metaData2` should have a snake case name [INFO] [stderr] --> src/tfs/mod.rs:123:13 [INFO] [stderr] | [INFO] [stderr] 123 | let metaData2 = Self::read_meta_data(disk); // ...have no idea how to make a copy [INFO] [stderr] | ^^^^^^^^^ help: convert the identifier to snake case: `meta_data2` [INFO] [stderr] [INFO] [stderr] warning: variable `nBlocks` should have a snake case name [INFO] [stderr] --> src/tfs/mod.rs:133:13 [INFO] [stderr] | [INFO] [stderr] 133 | let nBlocks = metaData.superBlock.Blocks; [INFO] [stderr] | ^^^^^^^ help: convert the identifier to snake case: `n_blocks` [INFO] [stderr] [INFO] [stderr] warning: variable `inodeBlocks` should have a snake case name [INFO] [stderr] --> src/tfs/mod.rs:134:13 [INFO] [stderr] | [INFO] [stderr] 134 | let inodeBlocks = metaData.superBlock.InodeBlocks; [INFO] [stderr] | ^^^^^^^^^^^ help: convert the identifier to snake case: `inode_blocks` [INFO] [stderr] [INFO] [stderr] warning: variable `metaData` should have a snake case name [INFO] [stderr] --> src/tfs/mod.rs:200:38 [INFO] [stderr] | [INFO] [stderr] 200 | ... Some(metaData) => { [INFO] [stderr] | ^^^^^^^^ help: convert the identifier to snake case: `meta_data` [INFO] [stderr] [INFO] [stderr] warning: variable `metaData` should have a snake case name [INFO] [stderr] --> src/tfs/mod.rs:225:18 [INFO] [stderr] | [INFO] [stderr] 225 | Some(metaData) => { [INFO] [stderr] | ^^^^^^^^ help: convert the identifier to snake case: `meta_data` [INFO] [stderr] [INFO] [stderr] warning: variable `metaData` should have a snake case name [INFO] [stderr] --> src/tfs/mod.rs:248:22 [INFO] [stderr] | [INFO] [stderr] 248 | Some(metaData) => { [INFO] [stderr] | ^^^^^^^^ help: convert the identifier to snake case: `meta_data` [INFO] [stderr] [INFO] [stderr] warning: variable `ibitMap` should have a snake case name [INFO] [stderr] --> src/tfs/mod.rs:257:22 [INFO] [stderr] | [INFO] [stderr] 257 | Some(ibitMap)=> { [INFO] [stderr] | ^^^^^^^ help: convert the identifier to snake case: `ibit_map` [INFO] [stderr] [INFO] [stderr] warning: variable `superBlock` should have a snake case name [INFO] [stderr] --> src/tfs/mod.rs:544:13 [INFO] [stderr] | [INFO] [stderr] 544 | let superBlock = block.superblock(); [INFO] [stderr] | ^^^^^^^^^^ help: convert the identifier to snake case: `super_block` [INFO] [stderr] [INFO] [stderr] warning: variable `inodeTable` should have a snake case name [INFO] [stderr] --> src/tfs/mod.rs:547:17 [INFO] [stderr] | [INFO] [stderr] 547 | let mut inodeTable = Vec::new(); [INFO] [stderr] | ^^^^^^^^^^ help: convert the identifier to snake case: `inode_table` [INFO] [stderr] [INFO] [stderr] warning: variable `metaData` should have a snake case name [INFO] [stderr] --> src/tfs/mod.rs:563:18 [INFO] [stderr] | [INFO] [stderr] 563 | Some(metaData) => { [INFO] [stderr] | ^^^^^^^^ help: convert the identifier to snake case: `meta_data` [INFO] [stderr] [INFO] [stderr] warning: variable `metaData` should have a snake case name [INFO] [stderr] --> src/tfs/mod.rs:581:18 [INFO] [stderr] | [INFO] [stderr] 581 | Some(metaData) => { [INFO] [stderr] | ^^^^^^^^ help: convert the identifier to snake case: `meta_data` [INFO] [stderr] [INFO] [stderr] warning: variable `metaData` should have a snake case name [INFO] [stderr] --> src/tfs/mod.rs:658:26 [INFO] [stderr] | [INFO] [stderr] 658 | Some(metaData) => { [INFO] [stderr] | ^^^^^^^^ help: convert the identifier to snake case: `meta_data` [INFO] [stderr] [INFO] [stderr] warning: variable `dataBitMap` should have a snake case name [INFO] [stderr] --> src/tfs/mod.rs:693:31 [INFO] [stderr] | [INFO] [stderr] 693 | let get_free_block = |dataBitMap: Option<&Vec>| { [INFO] [stderr] | ^^^^^^^^^^ help: convert the identifier to snake case: `data_bit_map` [INFO] [stderr] [INFO] [stderr] warning: variable `dataBitMap` should have a snake case name [INFO] [stderr] --> src/tfs/mod.rs:695:22 [INFO] [stderr] | [INFO] [stderr] 695 | Some(dataBitMap) => { [INFO] [stderr] | ^^^^^^^^^^ help: convert the identifier to snake case: `data_bit_map` [INFO] [stderr] [INFO] [stderr] warning: variable `dataBitMap` should have a snake case name [INFO] [stderr] --> src/tfs/mod.rs:718:22 [INFO] [stderr] | [INFO] [stderr] 718 | Some(dataBitMap) => { [INFO] [stderr] | ^^^^^^^^^^ help: convert the identifier to snake case: `data_bit_map` [INFO] [stderr] [INFO] [stderr] warning: variable `metaData` should have a snake case name [INFO] [stderr] --> src/tfs/mod.rs:725:22 [INFO] [stderr] | [INFO] [stderr] 725 | Some(metaData) => { [INFO] [stderr] | ^^^^^^^^ help: convert the identifier to snake case: `meta_data` [INFO] [stderr] [INFO] [stderr] warning: structure field `FileDescriptor` should have a snake case name [INFO] [stderr] --> src/tfs/disk.rs:10:5 [INFO] [stderr] | [INFO] [stderr] 10 | FileDescriptor: Option, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: convert the identifier to snake case: `file_descriptor` [INFO] [stderr] [INFO] [stderr] warning: structure field `Blocks` should have a snake case name [INFO] [stderr] --> src/tfs/disk.rs:11:5 [INFO] [stderr] | [INFO] [stderr] 11 | Blocks: usize, // Number of blocks in disk image [INFO] [stderr] | ^^^^^^ help: convert the identifier to snake case: `blocks` [INFO] [stderr] [INFO] [stderr] warning: structure field `Reads` should have a snake case name [INFO] [stderr] --> src/tfs/disk.rs:12:5 [INFO] [stderr] | [INFO] [stderr] 12 | Reads: usize, // Number of reads performed [INFO] [stderr] | ^^^^^ help: convert the identifier to snake case: `reads` [INFO] [stderr] [INFO] [stderr] warning: structure field `Writes` should have a snake case name [INFO] [stderr] --> src/tfs/disk.rs:13:5 [INFO] [stderr] | [INFO] [stderr] 13 | Writes: usize, // Number of writes performed [INFO] [stderr] | ^^^^^^ help: convert the identifier to snake case (notice the capitalization): `writes` [INFO] [stderr] [INFO] [stderr] warning: structure field `Mounts` should have a snake case name [INFO] [stderr] --> src/tfs/disk.rs:14:5 [INFO] [stderr] | [INFO] [stderr] 14 | Mounts: usize, // Number of mounts [INFO] [stderr] | ^^^^^^ help: convert the identifier to snake case: `mounts` [INFO] [stderr] [INFO] [stderr] warning: structure field `Path` should have a snake case name [INFO] [stderr] --> src/tfs/disk.rs:15:5 [INFO] [stderr] | [INFO] [stderr] 15 | Path: &'a str // file path for the disk [INFO] [stderr] | ^^^^ help: convert the identifier to snake case: `path` [INFO] [stderr] [INFO] [stderr] warning: comparison is useless due to type limits [INFO] [stderr] --> src/tfs/disk.rs:21:12 [INFO] [stderr] | [INFO] [stderr] 21 | if blocknum < 0 { [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(unused_comparisons)]` on by default [INFO] [stderr] [INFO] [stderr] warning: unused `Result` that must be used [INFO] [stderr] --> src/tfs/disk.rs:68:17 [INFO] [stderr] | [INFO] [stderr] 68 | f.set_len((nblocks as u64) * (Self::BLOCK_SIZE as u64)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(unused_must_use)]` on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: unused `Result` that must be used [INFO] [stderr] --> src/tfs/disk.rs:105:17 [INFO] [stderr] | [INFO] [stderr] 105 | file.seek(SeekFrom::Start( blocknum as u64 * Self::BLOCK_SIZE as u64)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: unused `Result` that must be used [INFO] [stderr] --> src/tfs/disk.rs:106:17 [INFO] [stderr] | [INFO] [stderr] 106 | file.read(data); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: unused `Result` that must be used [INFO] [stderr] --> src/tfs/disk.rs:117:17 [INFO] [stderr] | [INFO] [stderr] 117 | file.seek(SeekFrom::Start(blocknum as u64 * Self::BLOCK_SIZE as u64)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: unused `Result` that must be used [INFO] [stderr] --> src/tfs/disk.rs:118:17 [INFO] [stderr] | [INFO] [stderr] 118 | file.write(data); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: structure field `MagicNumber` should have a snake case name [INFO] [stderr] --> src/tfs/types.rs:13:9 [INFO] [stderr] | [INFO] [stderr] 13 | pub MagicNumber: u32, [INFO] [stderr] | ^^^^^^^^^^^ help: convert the identifier to snake case: `magic_number` [INFO] [stderr] [INFO] [stderr] warning: structure field `Blocks` should have a snake case name [INFO] [stderr] --> src/tfs/types.rs:14:9 [INFO] [stderr] | [INFO] [stderr] 14 | pub Blocks: u32, [INFO] [stderr] | ^^^^^^ help: convert the identifier to snake case: `blocks` [INFO] [stderr] [INFO] [stderr] warning: structure field `InodeBlocks` should have a snake case name [INFO] [stderr] --> src/tfs/types.rs:15:9 [INFO] [stderr] | [INFO] [stderr] 15 | pub InodeBlocks: u32, [INFO] [stderr] | ^^^^^^^^^^^ help: convert the identifier to snake case: `inode_blocks` [INFO] [stderr] [INFO] [stderr] warning: structure field `Inodes` should have a snake case name [INFO] [stderr] --> src/tfs/types.rs:16:9 [INFO] [stderr] | [INFO] [stderr] 16 | pub Inodes: u32 [INFO] [stderr] | ^^^^^^ help: convert the identifier to snake case (notice the capitalization): `inodes` [INFO] [stderr] [INFO] [stderr] warning: structure field `Valid` should have a snake case name [INFO] [stderr] --> src/tfs/types.rs:22:9 [INFO] [stderr] | [INFO] [stderr] 22 | pub Valid: u32, // whether or not inode is valid (or allocated) [INFO] [stderr] | ^^^^^ help: convert the identifier to snake case (notice the capitalization): `valid` [INFO] [stderr] [INFO] [stderr] warning: structure field `Size` should have a snake case name [INFO] [stderr] --> src/tfs/types.rs:23:9 [INFO] [stderr] | [INFO] [stderr] 23 | pub Size: u32, // size of file [INFO] [stderr] | ^^^^ help: convert the identifier to snake case (notice the capitalization): `size` [INFO] [stderr] [INFO] [stderr] warning: structure field `Direct` should have a snake case name [INFO] [stderr] --> src/tfs/types.rs:24:9 [INFO] [stderr] | [INFO] [stderr] 24 | pub Direct: [u32; POINTERS_PER_INODE], [INFO] [stderr] | ^^^^^^ help: convert the identifier to snake case: `direct` [INFO] [stderr] [INFO] [stderr] warning: structure field `Indirect` should have a snake case name [INFO] [stderr] --> src/tfs/types.rs:25:9 [INFO] [stderr] | [INFO] [stderr] 25 | pub Indirect: u32 [INFO] [stderr] | ^^^^^^^^ help: convert the identifier to snake case (notice the capitalization): `indirect` [INFO] [stderr] [INFO] [stderr] warning: structure field `Super` should have a snake case name [INFO] [stderr] --> src/tfs/types.rs:31:9 [INFO] [stderr] | [INFO] [stderr] 31 | pub Super: Superblock, [INFO] [stderr] | ^^^^^ help: rename the identifier [INFO] [stderr] | [INFO] [stderr] = note: `super` cannot be used as a raw identifier [INFO] [stderr] [INFO] [stderr] warning: structure field `Inodes` should have a snake case name [INFO] [stderr] --> src/tfs/types.rs:32:9 [INFO] [stderr] | [INFO] [stderr] 32 | pub Inodes: [Inode; INODES_PER_BLOCK], [INFO] [stderr] | ^^^^^^ help: convert the identifier to snake case (notice the capitalization): `inodes` [INFO] [stderr] [INFO] [stderr] warning: structure field `Pointers` should have a snake case name [INFO] [stderr] --> src/tfs/types.rs:33:9 [INFO] [stderr] | [INFO] [stderr] 33 | pub Pointers: [u32; POINTERS_PER_BLOCK], [INFO] [stderr] | ^^^^^^^^ help: convert the identifier to snake case: `pointers` [INFO] [stderr] [INFO] [stderr] warning: structure field `Data` should have a snake case name [INFO] [stderr] --> src/tfs/types.rs:34:9 [INFO] [stderr] | [INFO] [stderr] 34 | pub Data: [u8; Disk::BLOCK_SIZE] [INFO] [stderr] | ^^^^ help: convert the identifier to snake case: `data` [INFO] [stderr] [INFO] [stderr] warning: structure field `superBlock` should have a snake case name [INFO] [stderr] --> src/tfs/types.rs:40:9 [INFO] [stderr] | [INFO] [stderr] 40 | pub superBlock: Superblock, [INFO] [stderr] | ^^^^^^^^^^ help: convert the identifier to snake case: `super_block` [INFO] [stderr] [INFO] [stderr] warning: structure field `inodeTable` should have a snake case name [INFO] [stderr] --> src/tfs/types.rs:41:9 [INFO] [stderr] | [INFO] [stderr] 41 | pub inodeTable: Vec<[Inode; INODES_PER_BLOCK]> [INFO] [stderr] | ^^^^^^^^^^ help: convert the identifier to snake case: `inode_table` [INFO] [stderr] [INFO] [stderr] warning: `disk` (lib) generated 68 warnings [INFO] [stderr] warning: unused variable: `i` [INFO] [stderr] --> src/tfs/mod.rs:855:17 [INFO] [stderr] | [INFO] [stderr] 855 | let mut i = 0; [INFO] [stderr] | ^ help: if this is intentional, prefix it with an underscore: `_i` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/tfs/mod.rs:855:13 [INFO] [stderr] | [INFO] [stderr] 855 | let mut i = 0; [INFO] [stderr] | ----^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: function is never used: `disk_open` [INFO] [stderr] --> src/tfs/disk.rs:132:8 [INFO] [stderr] | [INFO] [stderr] 132 | fn disk_open() { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(dead_code)]` on by default [INFO] [stderr] [INFO] [stderr] warning: function is never used: `disk_read_write` [INFO] [stderr] --> src/tfs/disk.rs:139:8 [INFO] [stderr] | [INFO] [stderr] 139 | fn disk_read_write() { [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `disk_clone` [INFO] [stderr] --> src/tfs/disk.rs:152:8 [INFO] [stderr] | [INFO] [stderr] 152 | fn disk_clone() { [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `as_u32_be` [INFO] [stderr] --> src/tfs/utility.rs:1:8 [INFO] [stderr] | [INFO] [stderr] 1 | pub fn as_u32_be(array: &[u8; 4]) -> u32 { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `test_debug` [INFO] [stderr] --> src/tfs/mod.rs:795:8 [INFO] [stderr] | [INFO] [stderr] 795 | fn test_debug() { [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `test_format` [INFO] [stderr] --> src/tfs/mod.rs:805:8 [INFO] [stderr] | [INFO] [stderr] 805 | fn test_format() { [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `test_mount` [INFO] [stderr] --> src/tfs/mod.rs:813:8 [INFO] [stderr] | [INFO] [stderr] 813 | fn test_mount() { [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `test_create_remove_inode` [INFO] [stderr] --> src/tfs/mod.rs:821:8 [INFO] [stderr] | [INFO] [stderr] 821 | fn test_create_remove_inode() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::error::Error` [INFO] [stderr] --> src/main.rs:5:5 [INFO] [stderr] | [INFO] [stderr] 5 | use std::error::Error; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(unused_imports)]` on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `File` [INFO] [stderr] --> src/main.rs:251:19 [INFO] [stderr] | [INFO] [stderr] 251 | use std::fs::{File, OpenOptions}; [INFO] [stderr] | ^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `File` [INFO] [stderr] --> src/main.rs:294:19 [INFO] [stderr] | [INFO] [stderr] 294 | use std::fs::{File, OpenOptions}; [INFO] [stderr] | ^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused variable: `bytes_read` [INFO] [stderr] --> src/main.rs:84:9 [INFO] [stderr] | [INFO] [stderr] 84 | let bytes_read = stdin().read_line(&mut line).unwrap(); [INFO] [stderr] | ^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_bytes_read` [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(unused_variables)]` on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:150:18 [INFO] [stderr] | [INFO] [stderr] 150 | fn do_create<'a>(mut disk: Disk<'a>, [INFO] [stderr] | ----^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(unused_mut)]` on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:167:18 [INFO] [stderr] | [INFO] [stderr] 167 | fn do_remove<'a>(mut disk: Disk<'a>, [INFO] [stderr] | ----^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:185:16 [INFO] [stderr] | [INFO] [stderr] 185 | fn do_stat<'a>(mut disk: Disk<'a>, [INFO] [stderr] | ----^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:204:18 [INFO] [stderr] | [INFO] [stderr] 204 | fn do_copyin<'a>(mut disk: Disk<'a>, [INFO] [stderr] | ----^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:205:5 [INFO] [stderr] | [INFO] [stderr] 205 | mut fs: FileSystem<'a>, args: Vec<&str>) [INFO] [stderr] | ----^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:222:19 [INFO] [stderr] | [INFO] [stderr] 222 | fn do_copyout<'a>(mut disk: Disk<'a>, [INFO] [stderr] | ----^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:223:5 [INFO] [stderr] | [INFO] [stderr] 223 | mut fs: FileSystem<'a>, args: Vec<&str>) [INFO] [stderr] | ----^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:262:9 [INFO] [stderr] | [INFO] [stderr] 262 | let mut offset = 0; [INFO] [stderr] | ----^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:325:15 [INFO] [stderr] | [INFO] [stderr] 325 | fn do_cat<'a>(mut fs: FileSystem<'a>, args: Vec<&str>) -> FileSystem<'a> { [INFO] [stderr] | ----^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: comparison is useless due to type limits [INFO] [stderr] --> src/main.rs:157:16 [INFO] [stderr] | [INFO] [stderr] 157 | if inumber >= 0 { [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(unused_comparisons)]` on by default [INFO] [stderr] [INFO] [stderr] warning: unused `Result` that must be used [INFO] [stderr] --> src/main.rs:282:9 [INFO] [stderr] | [INFO] [stderr] 282 | file.seek(SeekFrom::Start( n as u64 * Disk::BLOCK_SIZE as u64)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(unused_must_use)]` on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: unused `Result` that must be used [INFO] [stderr] --> src/main.rs:315:13 [INFO] [stderr] | [INFO] [stderr] 315 | file.write(&mut buff); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: unused `Result` that must be used [INFO] [stderr] --> src/main.rs:317:13 [INFO] [stderr] | [INFO] [stderr] 317 | file.write(&mut buffer); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: `disk` (lib test) generated 77 warnings (67 duplicates) [INFO] [stderr] warning: `disk` (bin "disk" test) generated 17 warnings [INFO] [stderr] Finished test [unoptimized + debuginfo] target(s) in 0.01s [INFO] [stderr] Running unittests (/opt/rustwide/target/debug/deps/disk-7e70265a5c4d432a) [INFO] [stdout] [INFO] [stdout] running 1 test [INFO] [stdout] test tfs::tests::test_fs_read_write ... FAILED [INFO] [stdout] [INFO] [stdout] failures: [INFO] [stdout] [INFO] [stdout] ---- tfs::tests::test_fs_read_write stdout ---- [INFO] [stdout] thread 'tfs::tests::test_fs_read_write' panicked at 'Could not open: ./data/image.100, Read-only file system (os error 30)', src/tfs/disk.rs:72:17 [INFO] [stdout] stack backtrace: [INFO] [stdout] 0: 0x562f37ec029c - std::backtrace_rs::backtrace::libunwind::trace::h7630ba4cba718aa0 [INFO] [stdout] at /rustc/722e1797249a965b6335aebd65d777f917e498f1/library/std/src/../../backtrace/src/backtrace/libunwind.rs:93:5 [INFO] [stdout] 1: 0x562f37ec029c - std::backtrace_rs::backtrace::trace_unsynchronized::he7498e79c157f5ac [INFO] [stdout] at /rustc/722e1797249a965b6335aebd65d777f917e498f1/library/std/src/../../backtrace/src/backtrace/mod.rs:66:5 [INFO] [stdout] 2: 0x562f37ec029c - std::sys_common::backtrace::_print_fmt::hdaebadaee17bca49 [INFO] [stdout] at /rustc/722e1797249a965b6335aebd65d777f917e498f1/library/std/src/sys_common/backtrace.rs:67:5 [INFO] [stdout] 3: 0x562f37ec029c - ::fmt::h82b0e3aaf8a96140 [INFO] [stdout] at /rustc/722e1797249a965b6335aebd65d777f917e498f1/library/std/src/sys_common/backtrace.rs:46:22 [INFO] [stdout] 4: 0x562f37ee2d2c - core::fmt::write::h72801a82c94e6ff1 [INFO] [stdout] at /rustc/722e1797249a965b6335aebd65d777f917e498f1/library/core/src/fmt/mod.rs:1149:17 [INFO] [stdout] 5: 0x562f37ebc1a5 - std::io::Write::write_fmt::h21d7683cabdb4c35 [INFO] [stdout] at /rustc/722e1797249a965b6335aebd65d777f917e498f1/library/std/src/io/mod.rs:1697:15 [INFO] [stdout] 6: 0x562f37ec1cf0 - std::sys_common::backtrace::_print::h1c9a1d19c48821c1 [INFO] [stdout] at /rustc/722e1797249a965b6335aebd65d777f917e498f1/library/std/src/sys_common/backtrace.rs:49:5 [INFO] [stdout] 7: 0x562f37ec1cf0 - std::sys_common::backtrace::print::h7ce8802039fa9d0e [INFO] [stdout] at /rustc/722e1797249a965b6335aebd65d777f917e498f1/library/std/src/sys_common/backtrace.rs:36:9 [INFO] [stdout] 8: 0x562f37ec1cf0 - std::panicking::default_hook::{{closure}}::hb2a74a8c1499c326 [INFO] [stdout] at /rustc/722e1797249a965b6335aebd65d777f917e498f1/library/std/src/panicking.rs:211:50 [INFO] [stdout] 9: 0x562f37ec18d6 - std::panicking::default_hook::hf4f180b00076f2b2 [INFO] [stdout] at /rustc/722e1797249a965b6335aebd65d777f917e498f1/library/std/src/panicking.rs:225:9 [INFO] [stdout] 10: 0x562f37ec23a4 - std::panicking::rust_panic_with_hook::he85ce8435493b711 [INFO] [stdout] at /rustc/722e1797249a965b6335aebd65d777f917e498f1/library/std/src/panicking.rs:606:17 [INFO] [stdout] 11: 0x562f37ec1e80 - std::panicking::begin_panic_handler::{{closure}}::h31e15f69e6235bd2 [INFO] [stdout] at /rustc/722e1797249a965b6335aebd65d777f917e498f1/library/std/src/panicking.rs:502:13 [INFO] [stdout] 12: 0x562f37ec0754 - std::sys_common::backtrace::__rust_end_short_backtrace::hfce2fadb61aaa3ae [INFO] [stdout] at /rustc/722e1797249a965b6335aebd65d777f917e498f1/library/std/src/sys_common/backtrace.rs:139:18 [INFO] [stdout] 13: 0x562f37ec1de9 - rust_begin_unwind [INFO] [stdout] at /rustc/722e1797249a965b6335aebd65d777f917e498f1/library/std/src/panicking.rs:498:5 [INFO] [stdout] 14: 0x562f37e5a871 - core::panicking::panic_fmt::h7b8580d81fcbbacd [INFO] [stdout] at /rustc/722e1797249a965b6335aebd65d777f917e498f1/library/core/src/panicking.rs:107:14 [INFO] [stdout] 15: 0x562f37e69186 - disk::tfs::disk::Disk::open::hf814724e12e96129 [INFO] [stdout] at /opt/rustwide/workdir/src/tfs/disk.rs:72:17 [INFO] [stdout] 16: 0x562f37e68e0d - disk::tfs::disk::Disk::from_file::h377137807adf7065 [INFO] [stdout] at /opt/rustwide/workdir/src/tfs/disk.rs:44:9 [INFO] [stdout] 17: 0x562f37e6249b - disk::tfs::tests::test_fs_read_write::hd87bb06feb62f39c [INFO] [stdout] at /opt/rustwide/workdir/src/tfs/mod.rs:850:24 [INFO] [stdout] 18: 0x562f37e6245a - disk::tfs::tests::test_fs_read_write::{{closure}}::hc8d134db591f2fc3 [INFO] [stdout] at /opt/rustwide/workdir/src/tfs/mod.rs:849:5 [INFO] [stdout] 19: 0x562f37e6311e - core::ops::function::FnOnce::call_once::hfff1fd53a6c4a317 [INFO] [stdout] at /rustc/722e1797249a965b6335aebd65d777f917e498f1/library/core/src/ops/function.rs:227:5 [INFO] [stdout] 20: 0x562f37e9db13 - core::ops::function::FnOnce::call_once::h449577f1c5b077cb [INFO] [stdout] at /rustc/722e1797249a965b6335aebd65d777f917e498f1/library/core/src/ops/function.rs:227:5 [INFO] [stdout] 21: 0x562f37e9db13 - test::__rust_begin_short_backtrace::h8c2a0a5090591869 [INFO] [stdout] at /rustc/722e1797249a965b6335aebd65d777f917e498f1/library/test/src/lib.rs:585:5 [INFO] [stdout] 22: 0x562f37e9c6a7 - as core::ops::function::FnOnce>::call_once::hea00a22128a38543 [INFO] [stdout] at /rustc/722e1797249a965b6335aebd65d777f917e498f1/library/alloc/src/boxed.rs:1694:9 [INFO] [stdout] 23: 0x562f37e9c6a7 - as core::ops::function::FnOnce<()>>::call_once::he10b35c3c50d78a0 [INFO] [stdout] at /rustc/722e1797249a965b6335aebd65d777f917e498f1/library/core/src/panic/unwind_safe.rs:271:9 [INFO] [stdout] 24: 0x562f37e9c6a7 - std::panicking::try::do_call::hc868e78bbc5af2ab [INFO] [stdout] at /rustc/722e1797249a965b6335aebd65d777f917e498f1/library/std/src/panicking.rs:406:40 [INFO] [stdout] 25: 0x562f37e9c6a7 - std::panicking::try::he468aede74df1b04 [INFO] [stdout] at /rustc/722e1797249a965b6335aebd65d777f917e498f1/library/std/src/panicking.rs:370:19 [INFO] [stdout] 26: 0x562f37e9c6a7 - std::panic::catch_unwind::hce3c9152e1cf772d [INFO] [stdout] at /rustc/722e1797249a965b6335aebd65d777f917e498f1/library/std/src/panic.rs:133:14 [INFO] [stdout] 27: 0x562f37e9c6a7 - test::run_test_in_process::h9c4ab8162080cf8c [INFO] [stdout] at /rustc/722e1797249a965b6335aebd65d777f917e498f1/library/test/src/lib.rs:608:18 [INFO] [stdout] 28: 0x562f37e9c6a7 - test::run_test::run_test_inner::{{closure}}::he9483433cef16afe [INFO] [stdout] at /rustc/722e1797249a965b6335aebd65d777f917e498f1/library/test/src/lib.rs:500:39 [INFO] [stdout] 29: 0x562f37e699ee - test::run_test::run_test_inner::{{closure}}::h479f1f872a5501ea [INFO] [stdout] at /rustc/722e1797249a965b6335aebd65d777f917e498f1/library/test/src/lib.rs:527:37 [INFO] [stdout] 30: 0x562f37e699ee - std::sys_common::backtrace::__rust_begin_short_backtrace::h0f1e9b1f279687bc [INFO] [stdout] at /rustc/722e1797249a965b6335aebd65d777f917e498f1/library/std/src/sys_common/backtrace.rs:123:18 [INFO] [stdout] 31: 0x562f37e6e818 - std::thread::Builder::spawn_unchecked::{{closure}}::{{closure}}::he5560613c5f5cb83 [INFO] [stdout] at /rustc/722e1797249a965b6335aebd65d777f917e498f1/library/std/src/thread/mod.rs:484:17 [INFO] [stdout] 32: 0x562f37e6e818 - as core::ops::function::FnOnce<()>>::call_once::h8190a68cb05ab92f [INFO] [stdout] at /rustc/722e1797249a965b6335aebd65d777f917e498f1/library/core/src/panic/unwind_safe.rs:271:9 [INFO] [stdout] 33: 0x562f37e6e818 - std::panicking::try::do_call::h6ae22f5ac22596e4 [INFO] [stdout] at /rustc/722e1797249a965b6335aebd65d777f917e498f1/library/std/src/panicking.rs:406:40 [INFO] [stdout] 34: 0x562f37e6e818 - std::panicking::try::h2381c25487d6a7c2 [INFO] [stdout] at /rustc/722e1797249a965b6335aebd65d777f917e498f1/library/std/src/panicking.rs:370:19 [INFO] [stdout] 35: 0x562f37e6e818 - std::panic::catch_unwind::hfe902f4d5c9d7b6d [INFO] [stdout] at /rustc/722e1797249a965b6335aebd65d777f917e498f1/library/std/src/panic.rs:133:14 [INFO] [stdout] 36: 0x562f37e6e818 - std::thread::Builder::spawn_unchecked::{{closure}}::h547fad40771a584e [INFO] [stdout] at /rustc/722e1797249a965b6335aebd65d777f917e498f1/library/std/src/thread/mod.rs:483:30 [INFO] [stdout] 37: 0x562f37e6e818 - core::ops::function::FnOnce::call_once{{vtable.shim}}::he8602a9971738410 [INFO] [stdout] at /rustc/722e1797249a965b6335aebd65d777f917e498f1/library/core/src/ops/function.rs:227:5 [INFO] [stdout] 38: 0x562f37ec6e33 - as core::ops::function::FnOnce>::call_once::he162a5c338a10a39 [INFO] [stdout] at /rustc/722e1797249a965b6335aebd65d777f917e498f1/library/alloc/src/boxed.rs:1694:9 [INFO] [stdout] 39: 0x562f37ec6e33 - as core::ops::function::FnOnce>::call_once::hb27497b21740dd97 [INFO] [stdout] at /rustc/722e1797249a965b6335aebd65d777f917e498f1/library/alloc/src/boxed.rs:1694:9 [INFO] [stdout] 40: 0x562f37ec6e33 - std::sys::unix::thread::Thread::new::thread_start::he467e990e49c5136 [INFO] [stdout] at /rustc/722e1797249a965b6335aebd65d777f917e498f1/library/std/src/sys/unix/thread.rs:106:17 [INFO] [stdout] 41: 0x7fcb0f384609 - start_thread [INFO] [stdout] 42: 0x7fcb0f156293 - clone [INFO] [stdout] 43: 0x0 - [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] failures: [INFO] [stdout] tfs::tests::test_fs_read_write [INFO] [stdout] [INFO] [stdout] test result: FAILED. 0 passed; 1 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.01s [INFO] [stdout] [INFO] [stderr] error: test failed, to rerun pass '--lib' [INFO] running `Command { std: "docker" "inspect" "e87eeb56f99243848a8883b159734630de9eb5168953e286995af8409384df43", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "e87eeb56f99243848a8883b159734630de9eb5168953e286995af8409384df43", kill_on_drop: false }` [INFO] [stdout] e87eeb56f99243848a8883b159734630de9eb5168953e286995af8409384df43