[INFO] cloning repository https://github.com/CloseChoice/rtag [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/CloseChoice/rtag" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FCloseChoice%2Frtag", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FCloseChoice%2Frtag'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 907018ce8132b02d60016fa05a2479cd91fabc84 [INFO] testing CloseChoice/rtag against try#722e1797249a965b6335aebd65d777f917e498f1 for pr-91031 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FCloseChoice%2Frtag" "/workspace/builds/worker-52/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-52/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/CloseChoice/rtag on toolchain 722e1797249a965b6335aebd65d777f917e498f1 [INFO] running `Command { std: "/workspace/cargo-home/bin/cargo" "+722e1797249a965b6335aebd65d777f917e498f1" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/CloseChoice/rtag [INFO] finished tweaking git repo https://github.com/CloseChoice/rtag [INFO] tweaked toml for git repo https://github.com/CloseChoice/rtag written to /workspace/builds/worker-52/source/Cargo.toml [INFO] crate git repo https://github.com/CloseChoice/rtag already has a lockfile, it will not be regenerated [INFO] running `Command { std: "/workspace/cargo-home/bin/cargo" "+722e1797249a965b6335aebd65d777f917e498f1" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded rusqlite v0.24.2 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-52/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-52/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:5736fa189c1c60b01babf4b8b698fe57b6ecc41933a7ff2e0b8d7a221459412b" "/opt/rustwide/cargo-home/bin/cargo" "+722e1797249a965b6335aebd65d777f917e498f1" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 185a5ad49903dce02740fcd02d472fc8daf276d7afa2875a5372f2f3e046c18d [INFO] running `Command { std: "docker" "start" "-a" "185a5ad49903dce02740fcd02d472fc8daf276d7afa2875a5372f2f3e046c18d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "185a5ad49903dce02740fcd02d472fc8daf276d7afa2875a5372f2f3e046c18d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "185a5ad49903dce02740fcd02d472fc8daf276d7afa2875a5372f2f3e046c18d", kill_on_drop: false }` [INFO] [stdout] 185a5ad49903dce02740fcd02d472fc8daf276d7afa2875a5372f2f3e046c18d [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-52/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-52/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:5736fa189c1c60b01babf4b8b698fe57b6ecc41933a7ff2e0b8d7a221459412b" "/opt/rustwide/cargo-home/bin/cargo" "+722e1797249a965b6335aebd65d777f917e498f1" "build" "--frozen" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 3bbdec9743ac4a03ce1ff222268a5c055af52393c4dcf703e6fed6b023581d1c [INFO] running `Command { std: "docker" "start" "-a" "3bbdec9743ac4a03ce1ff222268a5c055af52393c4dcf703e6fed6b023581d1c", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Compiling memchr v2.3.4 [INFO] [stderr] Compiling libc v0.2.86 [INFO] [stderr] Compiling serde v1.0.123 [INFO] [stderr] Compiling byteorder v1.4.2 [INFO] [stderr] Compiling ahash v0.4.7 [INFO] [stderr] Compiling itoa v0.4.7 [INFO] [stderr] Compiling encode_unicode v0.3.6 [INFO] [stderr] Compiling fallible-iterator v0.2.0 [INFO] [stderr] Compiling yaml-rust v0.3.5 [INFO] [stderr] Compiling ansi_term v0.9.0 [INFO] [stderr] Compiling bitflags v0.9.1 [INFO] [stderr] Compiling strsim v0.6.0 [INFO] [stderr] Compiling fallible-streaming-iterator v0.1.9 [INFO] [stderr] Compiling libsqlite3-sys v0.20.1 [INFO] [stderr] Compiling textwrap v0.9.0 [INFO] [stderr] Compiling hashbrown v0.9.1 [INFO] [stderr] Compiling regex-automata v0.1.9 [INFO] [stderr] Compiling csv-core v0.1.10 [INFO] [stderr] Compiling hashlink v0.6.0 [INFO] [stderr] Compiling rusqlite v0.24.2 [INFO] [stderr] Compiling dirs v1.0.5 [INFO] [stderr] Compiling atty v0.2.14 [INFO] [stderr] Compiling clap v2.27.1 [INFO] [stderr] Compiling term v0.5.2 [INFO] [stderr] Compiling bstr v0.2.15 [INFO] [stderr] Compiling csv v1.1.5 [INFO] [stderr] Compiling prettytable-rs v0.8.0 [INFO] [stderr] Compiling rtag v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `Statement` [INFO] [stdout] --> src/rtag_sqlite.rs:1:27 [INFO] [stdout] | [INFO] [stdout] 1 | use rusqlite::{NO_PARAMS, Statement}; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Cell` [INFO] [stdout] --> src/rtag_sqlite.rs:3:31 [INFO] [stdout] | [INFO] [stdout] 3 | use prettytable::{Table, Row, Cell}; [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/rtag_sqlite.rs:37:63 [INFO] [stdout] | [INFO] [stdout] 37 | fn get_id_of_tag(conn: &Connection, tag_name: &str) -> Result<(i32)> { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 37 - fn get_id_of_tag(conn: &Connection, tag_name: &str) -> Result<(i32)> { [INFO] [stdout] 37 + fn get_id_of_tag(conn: &Connection, tag_name: &str) -> Result { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: type `dim_fct_tag` should have an upper camel case name [INFO] [stdout] --> src/rtag_sqlite.rs:82:8 [INFO] [stdout] | [INFO] [stdout] 82 | struct dim_fct_tag { [INFO] [stdout] | ^^^^^^^^^^^ help: convert the identifier to upper camel case: `DimFctTag` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_camel_case_types)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: type `dim_tag` should have an upper camel case name [INFO] [stdout] --> src/rtag_sqlite.rs:90:8 [INFO] [stdout] | [INFO] [stdout] 90 | struct dim_tag { [INFO] [stdout] | ^^^^^^^ help: convert the identifier to upper camel case: `DimTag` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: type `id` should have an upper camel case name [INFO] [stdout] --> src/rtag_sqlite.rs:97:8 [INFO] [stdout] | [INFO] [stdout] 97 | struct id { [INFO] [stdout] | ^^ help: convert the identifier to upper camel case (notice the capitalization): `Id` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `AppSettings` [INFO] [stdout] --> src/main.rs:8:17 [INFO] [stdout] | [INFO] [stdout] 8 | use clap::{App, AppSettings, Arg, SubCommand}; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::path::Path` [INFO] [stdout] --> src/main.rs:10:5 [INFO] [stdout] | [INFO] [stdout] 10 | use std::path::Path; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `e` [INFO] [stdout] --> src/rtag_sqlite.rs:58:17 [INFO] [stdout] | [INFO] [stdout] 58 | Err(e) => { [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_e` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field is never read: `id` [INFO] [stdout] --> src/rtag_sqlite.rs:91:5 [INFO] [stdout] | [INFO] [stdout] 91 | id: i32, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field is never read: `tag_name` [INFO] [stdout] --> src/rtag_sqlite.rs:92:5 [INFO] [stdout] | [INFO] [stdout] 92 | tag_name: String, [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field is never read: `time_created` [INFO] [stdout] --> src/rtag_sqlite.rs:93:5 [INFO] [stdout] | [INFO] [stdout] 93 | time_created: String, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function is never used: `save_to_sqlite` [INFO] [stdout] --> src/main.rs:205:4 [INFO] [stdout] | [INFO] [stdout] 205 | fn save_to_sqlite() {} [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/main.rs:152:13 [INFO] [stdout] | [INFO] [stdout] 152 | show_all(&conn); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/main.rs:157:17 [INFO] [stdout] | [INFO] [stdout] 157 | show_tags(&conn, tags); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/main.rs:163:17 [INFO] [stdout] | [INFO] [stdout] 163 | show_paths(&conn, path_vec); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/main.rs:175:17 [INFO] [stdout] | [INFO] [stdout] 175 | delete_by_tag(&conn, tag_vec); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/main.rs:179:17 [INFO] [stdout] | [INFO] [stdout] 179 | delete_by_id(&conn, ids); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/main.rs:195:13 [INFO] [stdout] | [INFO] [stdout] 195 | insert_path(&conn, path.to_str().unwrap(), tag.unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: static variable `dim_fct_rows` should have an upper case name [INFO] [stdout] --> src/rtag_sqlite.rs:5:8 [INFO] [stdout] | [INFO] [stdout] 5 | static dim_fct_rows: &'static [&'static str] = &["ID", "TAG", "PATH", "TIME_CREATED"]; [INFO] [stdout] | ^^^^^^^^^^^^ help: convert the identifier to upper case: `DIM_FCT_ROWS` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_upper_case_globals)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/rtag_sqlite.rs:56:17 [INFO] [stdout] | [INFO] [stdout] 56 | insert_path_tag_to_fct_tag(conn, id, path, tag); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/rtag_sqlite.rs:60:17 [INFO] [stdout] | [INFO] [stdout] 60 | create_new_tag(conn, tag); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/rtag_sqlite.rs:62:17 [INFO] [stdout] | [INFO] [stdout] 62 | insert_path_tag_to_fct_tag(conn, tag_id, path, tag); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/rtag_sqlite.rs:165:5 [INFO] [stdout] | [INFO] [stdout] 165 | delete_by_id(&conn, ids); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 24 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 28.87s [INFO] running `Command { std: "docker" "inspect" "3bbdec9743ac4a03ce1ff222268a5c055af52393c4dcf703e6fed6b023581d1c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "3bbdec9743ac4a03ce1ff222268a5c055af52393c4dcf703e6fed6b023581d1c", kill_on_drop: false }` [INFO] [stdout] 3bbdec9743ac4a03ce1ff222268a5c055af52393c4dcf703e6fed6b023581d1c [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-52/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-52/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:5736fa189c1c60b01babf4b8b698fe57b6ecc41933a7ff2e0b8d7a221459412b" "/opt/rustwide/cargo-home/bin/cargo" "+722e1797249a965b6335aebd65d777f917e498f1" "test" "--frozen" "--no-run" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] c7a82214a08f050828ee025c3cef8e2bb8ce8bb30c31e40aa8b1f111ef5a1bd9 [INFO] running `Command { std: "docker" "start" "-a" "c7a82214a08f050828ee025c3cef8e2bb8ce8bb30c31e40aa8b1f111ef5a1bd9", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Compiling rtag v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `Statement` [INFO] [stdout] --> src/rtag_sqlite.rs:1:27 [INFO] [stdout] | [INFO] [stdout] 1 | use rusqlite::{NO_PARAMS, Statement}; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Cell` [INFO] [stdout] --> src/rtag_sqlite.rs:3:31 [INFO] [stdout] | [INFO] [stdout] 3 | use prettytable::{Table, Row, Cell}; [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/rtag_sqlite.rs:37:63 [INFO] [stdout] | [INFO] [stdout] 37 | fn get_id_of_tag(conn: &Connection, tag_name: &str) -> Result<(i32)> { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 37 - fn get_id_of_tag(conn: &Connection, tag_name: &str) -> Result<(i32)> { [INFO] [stdout] 37 + fn get_id_of_tag(conn: &Connection, tag_name: &str) -> Result { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: type `dim_fct_tag` should have an upper camel case name [INFO] [stdout] --> src/rtag_sqlite.rs:82:8 [INFO] [stdout] | [INFO] [stdout] 82 | struct dim_fct_tag { [INFO] [stdout] | ^^^^^^^^^^^ help: convert the identifier to upper camel case: `DimFctTag` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_camel_case_types)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: type `dim_tag` should have an upper camel case name [INFO] [stdout] --> src/rtag_sqlite.rs:90:8 [INFO] [stdout] | [INFO] [stdout] 90 | struct dim_tag { [INFO] [stdout] | ^^^^^^^ help: convert the identifier to upper camel case: `DimTag` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: type `id` should have an upper camel case name [INFO] [stdout] --> src/rtag_sqlite.rs:97:8 [INFO] [stdout] | [INFO] [stdout] 97 | struct id { [INFO] [stdout] | ^^ help: convert the identifier to upper camel case (notice the capitalization): `Id` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `AppSettings` [INFO] [stdout] --> src/main.rs:8:17 [INFO] [stdout] | [INFO] [stdout] 8 | use clap::{App, AppSettings, Arg, SubCommand}; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::path::Path` [INFO] [stdout] --> src/main.rs:10:5 [INFO] [stdout] | [INFO] [stdout] 10 | use std::path::Path; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `e` [INFO] [stdout] --> src/rtag_sqlite.rs:58:17 [INFO] [stdout] | [INFO] [stdout] 58 | Err(e) => { [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_e` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field is never read: `id` [INFO] [stdout] --> src/rtag_sqlite.rs:91:5 [INFO] [stdout] | [INFO] [stdout] 91 | id: i32, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field is never read: `tag_name` [INFO] [stdout] --> src/rtag_sqlite.rs:92:5 [INFO] [stdout] | [INFO] [stdout] 92 | tag_name: String, [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field is never read: `time_created` [INFO] [stdout] --> src/rtag_sqlite.rs:93:5 [INFO] [stdout] | [INFO] [stdout] 93 | time_created: String, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function is never used: `save_to_sqlite` [INFO] [stdout] --> src/main.rs:205:4 [INFO] [stdout] | [INFO] [stdout] 205 | fn save_to_sqlite() {} [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/main.rs:152:13 [INFO] [stdout] | [INFO] [stdout] 152 | show_all(&conn); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/main.rs:157:17 [INFO] [stdout] | [INFO] [stdout] 157 | show_tags(&conn, tags); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/main.rs:163:17 [INFO] [stdout] | [INFO] [stdout] 163 | show_paths(&conn, path_vec); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/main.rs:175:17 [INFO] [stdout] | [INFO] [stdout] 175 | delete_by_tag(&conn, tag_vec); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/main.rs:179:17 [INFO] [stdout] | [INFO] [stdout] 179 | delete_by_id(&conn, ids); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/main.rs:195:13 [INFO] [stdout] | [INFO] [stdout] 195 | insert_path(&conn, path.to_str().unwrap(), tag.unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: static variable `dim_fct_rows` should have an upper case name [INFO] [stdout] --> src/rtag_sqlite.rs:5:8 [INFO] [stdout] | [INFO] [stdout] 5 | static dim_fct_rows: &'static [&'static str] = &["ID", "TAG", "PATH", "TIME_CREATED"]; [INFO] [stdout] | ^^^^^^^^^^^^ help: convert the identifier to upper case: `DIM_FCT_ROWS` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_upper_case_globals)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/rtag_sqlite.rs:56:17 [INFO] [stdout] | [INFO] [stdout] 56 | insert_path_tag_to_fct_tag(conn, id, path, tag); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/rtag_sqlite.rs:60:17 [INFO] [stdout] | [INFO] [stdout] 60 | create_new_tag(conn, tag); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/rtag_sqlite.rs:62:17 [INFO] [stdout] | [INFO] [stdout] 62 | insert_path_tag_to_fct_tag(conn, tag_id, path, tag); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/rtag_sqlite.rs:165:5 [INFO] [stdout] | [INFO] [stdout] 165 | delete_by_id(&conn, ids); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 24 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished test [unoptimized + debuginfo] target(s) in 3.60s [INFO] running `Command { std: "docker" "inspect" "c7a82214a08f050828ee025c3cef8e2bb8ce8bb30c31e40aa8b1f111ef5a1bd9", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "c7a82214a08f050828ee025c3cef8e2bb8ce8bb30c31e40aa8b1f111ef5a1bd9", kill_on_drop: false }` [INFO] [stdout] c7a82214a08f050828ee025c3cef8e2bb8ce8bb30c31e40aa8b1f111ef5a1bd9 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-52/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-52/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:5736fa189c1c60b01babf4b8b698fe57b6ecc41933a7ff2e0b8d7a221459412b" "/opt/rustwide/cargo-home/bin/cargo" "+722e1797249a965b6335aebd65d777f917e498f1" "test" "--frozen", kill_on_drop: false }` [INFO] [stdout] d005db6f5bd1bd4c2a4105b4a923c77bd9f92080159408b6aa1fb9d9040dfcb7 [INFO] running `Command { std: "docker" "start" "-a" "d005db6f5bd1bd4c2a4105b4a923c77bd9f92080159408b6aa1fb9d9040dfcb7", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] warning: unused import: `Statement` [INFO] [stderr] --> src/rtag_sqlite.rs:1:27 [INFO] [stderr] | [INFO] [stderr] 1 | use rusqlite::{NO_PARAMS, Statement}; [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(unused_imports)]` on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `Cell` [INFO] [stderr] --> src/rtag_sqlite.rs:3:31 [INFO] [stderr] | [INFO] [stderr] 3 | use prettytable::{Table, Row, Cell}; [INFO] [stderr] | ^^^^ [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around type [INFO] [stderr] --> src/rtag_sqlite.rs:37:63 [INFO] [stderr] | [INFO] [stderr] 37 | fn get_id_of_tag(conn: &Connection, tag_name: &str) -> Result<(i32)> { [INFO] [stderr] | ^ ^ [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(unused_parens)]` on by default [INFO] [stderr] help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] 37 - fn get_id_of_tag(conn: &Connection, tag_name: &str) -> Result<(i32)> { [INFO] [stderr] 37 + fn get_id_of_tag(conn: &Connection, tag_name: &str) -> Result { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: type `dim_fct_tag` should have an upper camel case name [INFO] [stderr] --> src/rtag_sqlite.rs:82:8 [INFO] [stderr] | [INFO] [stderr] 82 | struct dim_fct_tag { [INFO] [stderr] | ^^^^^^^^^^^ help: convert the identifier to upper camel case: `DimFctTag` [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(non_camel_case_types)]` on by default [INFO] [stderr] [INFO] [stderr] warning: type `dim_tag` should have an upper camel case name [INFO] [stderr] --> src/rtag_sqlite.rs:90:8 [INFO] [stderr] | [INFO] [stderr] 90 | struct dim_tag { [INFO] [stderr] | ^^^^^^^ help: convert the identifier to upper camel case: `DimTag` [INFO] [stderr] [INFO] [stderr] warning: type `id` should have an upper camel case name [INFO] [stderr] --> src/rtag_sqlite.rs:97:8 [INFO] [stderr] | [INFO] [stderr] 97 | struct id { [INFO] [stderr] | ^^ help: convert the identifier to upper camel case (notice the capitalization): `Id` [INFO] [stderr] [INFO] [stderr] warning: unused import: `AppSettings` [INFO] [stderr] --> src/main.rs:8:17 [INFO] [stderr] | [INFO] [stderr] 8 | use clap::{App, AppSettings, Arg, SubCommand}; [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::path::Path` [INFO] [stderr] --> src/main.rs:10:5 [INFO] [stderr] | [INFO] [stderr] 10 | use std::path::Path; [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused variable: `e` [INFO] [stderr] --> src/rtag_sqlite.rs:58:17 [INFO] [stderr] | [INFO] [stderr] 58 | Err(e) => { [INFO] [stderr] | ^ help: if this is intentional, prefix it with an underscore: `_e` [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(unused_variables)]` on by default [INFO] [stderr] [INFO] [stderr] warning: field is never read: `id` [INFO] [stderr] --> src/rtag_sqlite.rs:91:5 [INFO] [stderr] | [INFO] [stderr] 91 | id: i32, [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(dead_code)]` on by default [INFO] [stderr] [INFO] [stderr] warning: field is never read: `tag_name` [INFO] [stderr] --> src/rtag_sqlite.rs:92:5 [INFO] [stderr] | [INFO] [stderr] 92 | tag_name: String, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never read: `time_created` [INFO] [stderr] --> src/rtag_sqlite.rs:93:5 [INFO] [stderr] | [INFO] [stderr] 93 | time_created: String, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `save_to_sqlite` [INFO] [stderr] --> src/main.rs:205:4 [INFO] [stderr] | [INFO] [stderr] 205 | fn save_to_sqlite() {} [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused `Result` that must be used [INFO] [stderr] --> src/main.rs:152:13 [INFO] [stderr] | [INFO] [stderr] 152 | show_all(&conn); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(unused_must_use)]` on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: unused `Result` that must be used [INFO] [stderr] --> src/main.rs:157:17 [INFO] [stderr] | [INFO] [stderr] 157 | show_tags(&conn, tags); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: unused `Result` that must be used [INFO] [stderr] --> src/main.rs:163:17 [INFO] [stderr] | [INFO] [stderr] 163 | show_paths(&conn, path_vec); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: unused `Result` that must be used [INFO] [stderr] --> src/main.rs:175:17 [INFO] [stderr] | [INFO] [stderr] 175 | delete_by_tag(&conn, tag_vec); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: unused `Result` that must be used [INFO] [stderr] --> src/main.rs:179:17 [INFO] [stderr] | [INFO] [stderr] 179 | delete_by_id(&conn, ids); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: unused `Result` that must be used [INFO] [stderr] --> src/main.rs:195:13 [INFO] [stderr] | [INFO] [stderr] 195 | insert_path(&conn, path.to_str().unwrap(), tag.unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: static variable `dim_fct_rows` should have an upper case name [INFO] [stderr] --> src/rtag_sqlite.rs:5:8 [INFO] [stderr] | [INFO] [stderr] 5 | static dim_fct_rows: &'static [&'static str] = &["ID", "TAG", "PATH", "TIME_CREATED"]; [INFO] [stderr] | ^^^^^^^^^^^^ help: convert the identifier to upper case: `DIM_FCT_ROWS` [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(non_upper_case_globals)]` on by default [INFO] [stderr] [INFO] [stderr] warning: unused `Result` that must be used [INFO] [stderr] --> src/rtag_sqlite.rs:56:17 [INFO] [stderr] | [INFO] [stderr] 56 | insert_path_tag_to_fct_tag(conn, id, path, tag); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: unused `Result` that must be used [INFO] [stderr] --> src/rtag_sqlite.rs:60:17 [INFO] [stderr] | [INFO] [stderr] 60 | create_new_tag(conn, tag); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: unused `Result` that must be used [INFO] [stderr] --> src/rtag_sqlite.rs:62:17 [INFO] [stderr] | [INFO] [stderr] 62 | insert_path_tag_to_fct_tag(conn, tag_id, path, tag); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: unused `Result` that must be used [INFO] [stderr] --> src/rtag_sqlite.rs:165:5 [INFO] [stderr] | [INFO] [stderr] 165 | delete_by_id(&conn, ids); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: `rtag` (bin "rtag" test) generated 24 warnings [INFO] [stderr] Finished test [unoptimized + debuginfo] target(s) in 0.29s [INFO] [stderr] Running unittests (/opt/rustwide/target/debug/deps/rtag-5ffb7ac6d562ae0a) [INFO] [stdout] [INFO] [stdout] running 0 tests [INFO] [stdout] [INFO] [stdout] test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s [INFO] [stdout] [INFO] running `Command { std: "docker" "inspect" "d005db6f5bd1bd4c2a4105b4a923c77bd9f92080159408b6aa1fb9d9040dfcb7", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "d005db6f5bd1bd4c2a4105b4a923c77bd9f92080159408b6aa1fb9d9040dfcb7", kill_on_drop: false }` [INFO] [stdout] d005db6f5bd1bd4c2a4105b4a923c77bd9f92080159408b6aa1fb9d9040dfcb7