[INFO] cloning repository https://github.com/saterus/gilded-rose-rust [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/saterus/gilded-rose-rust" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fsaterus%2Fgilded-rose-rust", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fsaterus%2Fgilded-rose-rust'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 8a8ec0b54b71eb6cfc764dda770b60843d95b73e [INFO] testing saterus/gilded-rose-rust against master#62efba8a050c64249dab942951bb28f710208bc8 for pr-90799 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fsaterus%2Fgilded-rose-rust" "/workspace/builds/worker-8/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-8/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/saterus/gilded-rose-rust on toolchain 62efba8a050c64249dab942951bb28f710208bc8 [INFO] running `Command { std: "/workspace/cargo-home/bin/cargo" "+62efba8a050c64249dab942951bb28f710208bc8" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/saterus/gilded-rose-rust [INFO] finished tweaking git repo https://github.com/saterus/gilded-rose-rust [INFO] tweaked toml for git repo https://github.com/saterus/gilded-rose-rust written to /workspace/builds/worker-8/source/Cargo.toml [INFO] crate git repo https://github.com/saterus/gilded-rose-rust already has a lockfile, it will not be regenerated [INFO] running `Command { std: "/workspace/cargo-home/bin/cargo" "+62efba8a050c64249dab942951bb28f710208bc8" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-8/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-8/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:5736fa189c1c60b01babf4b8b698fe57b6ecc41933a7ff2e0b8d7a221459412b" "/opt/rustwide/cargo-home/bin/cargo" "+62efba8a050c64249dab942951bb28f710208bc8" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stderr] WARNING: Your kernel does not support swap limit capabilities or the cgroup is not mounted. Memory limited without swap. [INFO] [stdout] 8ae797d8f41f1b342ee28e1eed030e8b92584a55b53ec3bfac975297664127b2 [INFO] running `Command { std: "docker" "start" "-a" "8ae797d8f41f1b342ee28e1eed030e8b92584a55b53ec3bfac975297664127b2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "8ae797d8f41f1b342ee28e1eed030e8b92584a55b53ec3bfac975297664127b2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "8ae797d8f41f1b342ee28e1eed030e8b92584a55b53ec3bfac975297664127b2", kill_on_drop: false }` [INFO] [stdout] 8ae797d8f41f1b342ee28e1eed030e8b92584a55b53ec3bfac975297664127b2 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-8/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-8/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:5736fa189c1c60b01babf4b8b698fe57b6ecc41933a7ff2e0b8d7a221459412b" "/opt/rustwide/cargo-home/bin/cargo" "+62efba8a050c64249dab942951bb28f710208bc8" "build" "--frozen" "--message-format=json", kill_on_drop: false }` [INFO] [stderr] WARNING: Your kernel does not support swap limit capabilities or the cgroup is not mounted. Memory limited without swap. [INFO] [stdout] 95acff64f9b218030a45e71ef36b3cbd13482d646c875fa03f380ebd838a9c57 [INFO] running `Command { std: "docker" "start" "-a" "95acff64f9b218030a45e71ef36b3cbd13482d646c875fa03f380ebd838a9c57", kill_on_drop: false }` [INFO] [stderr] Compiling gilded_rose v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/main.rs:32:12 [INFO] [stdout] | [INFO] [stdout] 32 | if (items[i].name != "Aged Brie" && items[i].name != "Backstage passes to a TAFKAL80ETC concert") [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 32 - if (items[i].name != "Aged Brie" && items[i].name != "Backstage passes to a TAFKAL80ETC concert") [INFO] [stdout] 32 + if items[i].name != "Aged Brie" && items[i].name != "Backstage passes to a TAFKAL80ETC concert" [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/main.rs:34:16 [INFO] [stdout] | [INFO] [stdout] 34 | if (items[i].quality > 0) [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 34 - if (items[i].quality > 0) [INFO] [stdout] 34 + if items[i].quality > 0 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/main.rs:36:20 [INFO] [stdout] | [INFO] [stdout] 36 | if (items[i].name != "Sulfuras, Hand of Ragnaros") [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 36 - if (items[i].name != "Sulfuras, Hand of Ragnaros") [INFO] [stdout] 36 + if items[i].name != "Sulfuras, Hand of Ragnaros" [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/main.rs:44:16 [INFO] [stdout] | [INFO] [stdout] 44 | if (items[i].quality < 50) [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 44 - if (items[i].quality < 50) [INFO] [stdout] 44 + if items[i].quality < 50 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/main.rs:48:20 [INFO] [stdout] | [INFO] [stdout] 48 | if (items[i].name == "Backstage passes to a TAFKAL80ETC concert") [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 48 - if (items[i].name == "Backstage passes to a TAFKAL80ETC concert") [INFO] [stdout] 48 + if items[i].name == "Backstage passes to a TAFKAL80ETC concert" [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/main.rs:50:24 [INFO] [stdout] | [INFO] [stdout] 50 | if (items[i].sell_in < 11) [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 50 - if (items[i].sell_in < 11) [INFO] [stdout] 50 + if items[i].sell_in < 11 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/main.rs:52:28 [INFO] [stdout] | [INFO] [stdout] 52 | if (items[i].quality < 50) [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 52 - if (items[i].quality < 50) [INFO] [stdout] 52 + if items[i].quality < 50 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/main.rs:58:24 [INFO] [stdout] | [INFO] [stdout] 58 | if (items[i].sell_in < 6) [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 58 - if (items[i].sell_in < 6) [INFO] [stdout] 58 + if items[i].sell_in < 6 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/main.rs:60:28 [INFO] [stdout] | [INFO] [stdout] 60 | if (items[i].quality < 50) [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 60 - if (items[i].quality < 50) [INFO] [stdout] 60 + if items[i].quality < 50 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/main.rs:69:12 [INFO] [stdout] | [INFO] [stdout] 69 | if (items[i].name != "Sulfuras, Hand of Ragnaros") [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 69 - if (items[i].name != "Sulfuras, Hand of Ragnaros") [INFO] [stdout] 69 + if items[i].name != "Sulfuras, Hand of Ragnaros" [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/main.rs:74:12 [INFO] [stdout] | [INFO] [stdout] 74 | if (items[i].sell_in < 0) [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 74 - if (items[i].sell_in < 0) [INFO] [stdout] 74 + if items[i].sell_in < 0 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/main.rs:76:16 [INFO] [stdout] | [INFO] [stdout] 76 | if (items[i].name != "Aged Brie") [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 76 - if (items[i].name != "Aged Brie") [INFO] [stdout] 76 + if items[i].name != "Aged Brie" [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/main.rs:78:20 [INFO] [stdout] | [INFO] [stdout] 78 | if (items[i].name != "Backstage passes to a TAFKAL80ETC concert") [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 78 - if (items[i].name != "Backstage passes to a TAFKAL80ETC concert") [INFO] [stdout] 78 + if items[i].name != "Backstage passes to a TAFKAL80ETC concert" [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/main.rs:80:24 [INFO] [stdout] | [INFO] [stdout] 80 | if (items[i].quality > 0) [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 80 - if (items[i].quality > 0) [INFO] [stdout] 80 + if items[i].quality > 0 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/main.rs:82:28 [INFO] [stdout] | [INFO] [stdout] 82 | if (items[i].name != "Sulfuras, Hand of Ragnaros") [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 82 - if (items[i].name != "Sulfuras, Hand of Ragnaros") [INFO] [stdout] 82 + if items[i].name != "Sulfuras, Hand of Ragnaros" [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/main.rs:95:20 [INFO] [stdout] | [INFO] [stdout] 95 | if (items[i].quality < 50) [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 95 - if (items[i].quality < 50) [INFO] [stdout] 95 + if items[i].quality < 50 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `UpdateQuality` should have a snake case name [INFO] [stdout] --> src/main.rs:28:4 [INFO] [stdout] | [INFO] [stdout] 28 | fn UpdateQuality(items: &mut [Item]) [INFO] [stdout] | ^^^^^^^^^^^^^ help: convert the identifier to snake case: `update_quality` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_snake_case)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 17 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.24s [INFO] running `Command { std: "docker" "inspect" "95acff64f9b218030a45e71ef36b3cbd13482d646c875fa03f380ebd838a9c57", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "95acff64f9b218030a45e71ef36b3cbd13482d646c875fa03f380ebd838a9c57", kill_on_drop: false }` [INFO] [stdout] 95acff64f9b218030a45e71ef36b3cbd13482d646c875fa03f380ebd838a9c57 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-8/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-8/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:5736fa189c1c60b01babf4b8b698fe57b6ecc41933a7ff2e0b8d7a221459412b" "/opt/rustwide/cargo-home/bin/cargo" "+62efba8a050c64249dab942951bb28f710208bc8" "test" "--frozen" "--no-run" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] a633d1980e47a39c16a58780efdc69314f38338b0099801d7a3d2edc96ac48f2 [INFO] [stderr] WARNING: Your kernel does not support swap limit capabilities or the cgroup is not mounted. Memory limited without swap. [INFO] running `Command { std: "docker" "start" "-a" "a633d1980e47a39c16a58780efdc69314f38338b0099801d7a3d2edc96ac48f2", kill_on_drop: false }` [INFO] [stderr] Compiling gilded_rose v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/main.rs:32:12 [INFO] [stdout] | [INFO] [stdout] 32 | if (items[i].name != "Aged Brie" && items[i].name != "Backstage passes to a TAFKAL80ETC concert") [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 32 - if (items[i].name != "Aged Brie" && items[i].name != "Backstage passes to a TAFKAL80ETC concert") [INFO] [stdout] 32 + if items[i].name != "Aged Brie" && items[i].name != "Backstage passes to a TAFKAL80ETC concert" [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/main.rs:34:16 [INFO] [stdout] | [INFO] [stdout] 34 | if (items[i].quality > 0) [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 34 - if (items[i].quality > 0) [INFO] [stdout] 34 + if items[i].quality > 0 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/main.rs:36:20 [INFO] [stdout] | [INFO] [stdout] 36 | if (items[i].name != "Sulfuras, Hand of Ragnaros") [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 36 - if (items[i].name != "Sulfuras, Hand of Ragnaros") [INFO] [stdout] 36 + if items[i].name != "Sulfuras, Hand of Ragnaros" [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/main.rs:44:16 [INFO] [stdout] | [INFO] [stdout] 44 | if (items[i].quality < 50) [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 44 - if (items[i].quality < 50) [INFO] [stdout] 44 + if items[i].quality < 50 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/main.rs:48:20 [INFO] [stdout] | [INFO] [stdout] 48 | if (items[i].name == "Backstage passes to a TAFKAL80ETC concert") [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 48 - if (items[i].name == "Backstage passes to a TAFKAL80ETC concert") [INFO] [stdout] 48 + if items[i].name == "Backstage passes to a TAFKAL80ETC concert" [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/main.rs:50:24 [INFO] [stdout] | [INFO] [stdout] 50 | if (items[i].sell_in < 11) [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 50 - if (items[i].sell_in < 11) [INFO] [stdout] 50 + if items[i].sell_in < 11 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/main.rs:52:28 [INFO] [stdout] | [INFO] [stdout] 52 | if (items[i].quality < 50) [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 52 - if (items[i].quality < 50) [INFO] [stdout] 52 + if items[i].quality < 50 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/main.rs:58:24 [INFO] [stdout] | [INFO] [stdout] 58 | if (items[i].sell_in < 6) [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 58 - if (items[i].sell_in < 6) [INFO] [stdout] 58 + if items[i].sell_in < 6 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/main.rs:60:28 [INFO] [stdout] | [INFO] [stdout] 60 | if (items[i].quality < 50) [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 60 - if (items[i].quality < 50) [INFO] [stdout] 60 + if items[i].quality < 50 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/main.rs:69:12 [INFO] [stdout] | [INFO] [stdout] 69 | if (items[i].name != "Sulfuras, Hand of Ragnaros") [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 69 - if (items[i].name != "Sulfuras, Hand of Ragnaros") [INFO] [stdout] 69 + if items[i].name != "Sulfuras, Hand of Ragnaros" [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/main.rs:74:12 [INFO] [stdout] | [INFO] [stdout] 74 | if (items[i].sell_in < 0) [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 74 - if (items[i].sell_in < 0) [INFO] [stdout] 74 + if items[i].sell_in < 0 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/main.rs:76:16 [INFO] [stdout] | [INFO] [stdout] 76 | if (items[i].name != "Aged Brie") [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 76 - if (items[i].name != "Aged Brie") [INFO] [stdout] 76 + if items[i].name != "Aged Brie" [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/main.rs:78:20 [INFO] [stdout] | [INFO] [stdout] 78 | if (items[i].name != "Backstage passes to a TAFKAL80ETC concert") [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 78 - if (items[i].name != "Backstage passes to a TAFKAL80ETC concert") [INFO] [stdout] 78 + if items[i].name != "Backstage passes to a TAFKAL80ETC concert" [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/main.rs:80:24 [INFO] [stdout] | [INFO] [stdout] 80 | if (items[i].quality > 0) [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 80 - if (items[i].quality > 0) [INFO] [stdout] 80 + if items[i].quality > 0 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/main.rs:82:28 [INFO] [stdout] | [INFO] [stdout] 82 | if (items[i].name != "Sulfuras, Hand of Ragnaros") [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 82 - if (items[i].name != "Sulfuras, Hand of Ragnaros") [INFO] [stdout] 82 + if items[i].name != "Sulfuras, Hand of Ragnaros" [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/main.rs:95:20 [INFO] [stdout] | [INFO] [stdout] 95 | if (items[i].quality < 50) [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 95 - if (items[i].quality < 50) [INFO] [stdout] 95 + if items[i].quality < 50 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `UpdateQuality` should have a snake case name [INFO] [stdout] --> src/main.rs:28:4 [INFO] [stdout] | [INFO] [stdout] 28 | fn UpdateQuality(items: &mut [Item]) [INFO] [stdout] | ^^^^^^^^^^^^^ help: convert the identifier to snake case: `update_quality` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_snake_case)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 17 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished test [unoptimized + debuginfo] target(s) in 1.13s [INFO] running `Command { std: "docker" "inspect" "a633d1980e47a39c16a58780efdc69314f38338b0099801d7a3d2edc96ac48f2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a633d1980e47a39c16a58780efdc69314f38338b0099801d7a3d2edc96ac48f2", kill_on_drop: false }` [INFO] [stdout] a633d1980e47a39c16a58780efdc69314f38338b0099801d7a3d2edc96ac48f2 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-8/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-8/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:5736fa189c1c60b01babf4b8b698fe57b6ecc41933a7ff2e0b8d7a221459412b" "/opt/rustwide/cargo-home/bin/cargo" "+62efba8a050c64249dab942951bb28f710208bc8" "test" "--frozen", kill_on_drop: false }` [INFO] [stdout] 356bf26cfbdcf39344b1a7d63ac9c858fcfc1d84d8578276a3f8a95cb35fb57e [INFO] [stderr] WARNING: Your kernel does not support swap limit capabilities or the cgroup is not mounted. Memory limited without swap. [INFO] running `Command { std: "docker" "start" "-a" "356bf26cfbdcf39344b1a7d63ac9c858fcfc1d84d8578276a3f8a95cb35fb57e", kill_on_drop: false }` [INFO] [stderr] warning: unnecessary parentheses around `if` condition [INFO] [stderr] --> src/main.rs:32:12 [INFO] [stderr] | [INFO] [stderr] 32 | if (items[i].name != "Aged Brie" && items[i].name != "Backstage passes to a TAFKAL80ETC concert") [INFO] [stderr] | ^ ^ [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(unused_parens)]` on by default [INFO] [stderr] help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] 32 - if (items[i].name != "Aged Brie" && items[i].name != "Backstage passes to a TAFKAL80ETC concert") [INFO] [stderr] 32 + if items[i].name != "Aged Brie" && items[i].name != "Backstage passes to a TAFKAL80ETC concert" [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `if` condition [INFO] [stderr] --> src/main.rs:34:16 [INFO] [stderr] | [INFO] [stderr] 34 | if (items[i].quality > 0) [INFO] [stderr] | ^ ^ [INFO] [stderr] | [INFO] [stderr] help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] 34 - if (items[i].quality > 0) [INFO] [stderr] 34 + if items[i].quality > 0 [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `if` condition [INFO] [stderr] --> src/main.rs:36:20 [INFO] [stderr] | [INFO] [stderr] 36 | if (items[i].name != "Sulfuras, Hand of Ragnaros") [INFO] [stderr] | ^ ^ [INFO] [stderr] | [INFO] [stderr] help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] 36 - if (items[i].name != "Sulfuras, Hand of Ragnaros") [INFO] [stderr] 36 + if items[i].name != "Sulfuras, Hand of Ragnaros" [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `if` condition [INFO] [stderr] --> src/main.rs:44:16 [INFO] [stderr] | [INFO] [stderr] 44 | if (items[i].quality < 50) [INFO] [stderr] | ^ ^ [INFO] [stderr] | [INFO] [stderr] help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] 44 - if (items[i].quality < 50) [INFO] [stderr] 44 + if items[i].quality < 50 [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `if` condition [INFO] [stderr] --> src/main.rs:48:20 [INFO] [stderr] | [INFO] [stderr] 48 | if (items[i].name == "Backstage passes to a TAFKAL80ETC concert") [INFO] [stderr] | ^ ^ [INFO] [stderr] | [INFO] [stderr] help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] 48 - if (items[i].name == "Backstage passes to a TAFKAL80ETC concert") [INFO] [stderr] 48 + if items[i].name == "Backstage passes to a TAFKAL80ETC concert" [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `if` condition [INFO] [stderr] --> src/main.rs:50:24 [INFO] [stderr] | [INFO] [stderr] 50 | if (items[i].sell_in < 11) [INFO] [stderr] | ^ ^ [INFO] [stderr] | [INFO] [stderr] help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] 50 - if (items[i].sell_in < 11) [INFO] [stderr] 50 + if items[i].sell_in < 11 [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `if` condition [INFO] [stderr] --> src/main.rs:52:28 [INFO] [stderr] | [INFO] [stderr] 52 | if (items[i].quality < 50) [INFO] [stderr] | ^ ^ [INFO] [stderr] | [INFO] [stderr] help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] 52 - if (items[i].quality < 50) [INFO] [stderr] 52 + if items[i].quality < 50 [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `if` condition [INFO] [stderr] --> src/main.rs:58:24 [INFO] [stderr] | [INFO] [stderr] 58 | if (items[i].sell_in < 6) [INFO] [stderr] | ^ ^ [INFO] [stderr] | [INFO] [stderr] help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] 58 - if (items[i].sell_in < 6) [INFO] [stderr] 58 + if items[i].sell_in < 6 [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `if` condition [INFO] [stderr] --> src/main.rs:60:28 [INFO] [stderr] | [INFO] [stderr] 60 | if (items[i].quality < 50) [INFO] [stderr] | ^ ^ [INFO] [stderr] | [INFO] [stderr] help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] 60 - if (items[i].quality < 50) [INFO] [stderr] 60 + if items[i].quality < 50 [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `if` condition [INFO] [stderr] --> src/main.rs:69:12 [INFO] [stderr] | [INFO] [stderr] 69 | if (items[i].name != "Sulfuras, Hand of Ragnaros") [INFO] [stderr] | ^ ^ [INFO] [stderr] | [INFO] [stderr] help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] 69 - if (items[i].name != "Sulfuras, Hand of Ragnaros") [INFO] [stderr] 69 + if items[i].name != "Sulfuras, Hand of Ragnaros" [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `if` condition [INFO] [stderr] --> src/main.rs:74:12 [INFO] [stderr] | [INFO] [stderr] 74 | if (items[i].sell_in < 0) [INFO] [stderr] | ^ ^ [INFO] [stderr] | [INFO] [stderr] help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] 74 - if (items[i].sell_in < 0) [INFO] [stderr] 74 + if items[i].sell_in < 0 [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `if` condition [INFO] [stderr] --> src/main.rs:76:16 [INFO] [stderr] | [INFO] [stderr] 76 | if (items[i].name != "Aged Brie") [INFO] [stderr] | ^ ^ [INFO] [stderr] | [INFO] [stderr] help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] 76 - if (items[i].name != "Aged Brie") [INFO] [stderr] 76 + if items[i].name != "Aged Brie" [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `if` condition [INFO] [stderr] --> src/main.rs:78:20 [INFO] [stderr] | [INFO] [stderr] 78 | if (items[i].name != "Backstage passes to a TAFKAL80ETC concert") [INFO] [stderr] | ^ ^ [INFO] [stderr] | [INFO] [stderr] help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] 78 - if (items[i].name != "Backstage passes to a TAFKAL80ETC concert") [INFO] [stderr] 78 + if items[i].name != "Backstage passes to a TAFKAL80ETC concert" [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `if` condition [INFO] [stderr] --> src/main.rs:80:24 [INFO] [stderr] | [INFO] [stderr] 80 | if (items[i].quality > 0) [INFO] [stderr] | ^ ^ [INFO] [stderr] | [INFO] [stderr] help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] 80 - if (items[i].quality > 0) [INFO] [stderr] 80 + if items[i].quality > 0 [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `if` condition [INFO] [stderr] --> src/main.rs:82:28 [INFO] [stderr] | [INFO] [stderr] 82 | if (items[i].name != "Sulfuras, Hand of Ragnaros") [INFO] [stderr] | ^ ^ [INFO] [stderr] | [INFO] [stderr] help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] 82 - if (items[i].name != "Sulfuras, Hand of Ragnaros") [INFO] [stderr] 82 + if items[i].name != "Sulfuras, Hand of Ragnaros" [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `if` condition [INFO] [stderr] --> src/main.rs:95:20 [INFO] [stderr] | [INFO] [stderr] 95 | if (items[i].quality < 50) [INFO] [stderr] | ^ ^ [INFO] [stderr] | [INFO] [stderr] help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] 95 - if (items[i].quality < 50) [INFO] [stderr] 95 + if items[i].quality < 50 [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: function `UpdateQuality` should have a snake case name [INFO] [stderr] --> src/main.rs:28:4 [INFO] [stderr] | [INFO] [stderr] 28 | fn UpdateQuality(items: &mut [Item]) [INFO] [stderr] | ^^^^^^^^^^^^^ help: convert the identifier to snake case: `update_quality` [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(non_snake_case)]` on by default [INFO] [stderr] [INFO] [stderr] warning: `gilded_rose` (bin "gilded_rose" test) generated 17 warnings [INFO] [stderr] Finished test [unoptimized + debuginfo] target(s) in 0.01s [INFO] [stdout] [INFO] [stderr] Running unittests (/opt/rustwide/target/debug/deps/gilded_rose-0880fa10fd182ab7) [INFO] [stdout] running 0 tests [INFO] [stderr] Running unittests (/opt/rustwide/target/debug/deps/gilded_rose-3b3a8fa4fe1b3e03) [INFO] [stdout] [INFO] [stdout] test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] running 1 test [INFO] [stdout] test normal_items_decrease_quality ... ok [INFO] [stdout] [INFO] [stdout] test result: ok. 1 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s [INFO] [stdout] [INFO] [stderr] Doc-tests gilded_rose [INFO] [stdout] [INFO] [stdout] running 0 tests [INFO] [stdout] [INFO] [stdout] test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s [INFO] [stdout] [INFO] running `Command { std: "docker" "inspect" "356bf26cfbdcf39344b1a7d63ac9c858fcfc1d84d8578276a3f8a95cb35fb57e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "356bf26cfbdcf39344b1a7d63ac9c858fcfc1d84d8578276a3f8a95cb35fb57e", kill_on_drop: false }` [INFO] [stdout] 356bf26cfbdcf39344b1a7d63ac9c858fcfc1d84d8578276a3f8a95cb35fb57e