[INFO] fetching crate graphsearch 0.6.0... [INFO] checking graphsearch-0.6.0 against try#07fecb9cf34c4979a772ba38c99d6d9144768413 for pr-87710 [INFO] extracting crate graphsearch 0.6.0 into /workspace/builds/worker-80/source [INFO] validating manifest of crates.io crate graphsearch 0.6.0 on toolchain 07fecb9cf34c4979a772ba38c99d6d9144768413 [INFO] running `Command { std: "/workspace/cargo-home/bin/cargo" "+07fecb9cf34c4979a772ba38c99d6d9144768413" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate graphsearch 0.6.0 [INFO] finished tweaking crates.io crate graphsearch 0.6.0 [INFO] tweaked toml for crates.io crate graphsearch 0.6.0 written to /workspace/builds/worker-80/source/Cargo.toml [INFO] running `Command { std: "/workspace/cargo-home/bin/cargo" "+07fecb9cf34c4979a772ba38c99d6d9144768413" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update", kill_on_drop: false }` [INFO] running `Command { std: "/workspace/cargo-home/bin/cargo" "+07fecb9cf34c4979a772ba38c99d6d9144768413" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-80/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-80/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:34b6a614d2c27851fe6cbf88fbd1137609cefab8b10d0615aaeb6fd47975d74e" "/opt/rustwide/cargo-home/bin/cargo" "+07fecb9cf34c4979a772ba38c99d6d9144768413" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] cc575a88ef569b47fa1a633b8ca7e5048c8d420cc09129af716487b9630c6e10 [INFO] running `Command { std: "docker" "start" "-a" "cc575a88ef569b47fa1a633b8ca7e5048c8d420cc09129af716487b9630c6e10", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "cc575a88ef569b47fa1a633b8ca7e5048c8d420cc09129af716487b9630c6e10", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "cc575a88ef569b47fa1a633b8ca7e5048c8d420cc09129af716487b9630c6e10", kill_on_drop: false }` [INFO] [stdout] cc575a88ef569b47fa1a633b8ca7e5048c8d420cc09129af716487b9630c6e10 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-80/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-80/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:34b6a614d2c27851fe6cbf88fbd1137609cefab8b10d0615aaeb6fd47975d74e" "/opt/rustwide/cargo-home/bin/cargo" "+07fecb9cf34c4979a772ba38c99d6d9144768413" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 2f8e30337271fe27c93597da979119d5329ed7281299da93c699ba7ee205c282 [INFO] running `Command { std: "docker" "start" "-a" "2f8e30337271fe27c93597da979119d5329ed7281299da93c699ba7ee205c282", kill_on_drop: false }` [INFO] [stderr] Checking graphsearch v0.6.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unnecessary parentheses around `for` iterator expression [INFO] [stdout] --> src/lib.rs:299:14 [INFO] [stdout] | [INFO] [stdout] 299 | for i in (0..path.len()-1) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.93s [INFO] [stdout] warning: unnecessary parentheses around `for` iterator expression [INFO] [stdout] --> src/lib.rs:320:14 [INFO] [stdout] | [INFO] [stdout] 320 | for i in (0..self.graph.len()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `for` iterator expression [INFO] [stdout] --> src/lib.rs:432:16 [INFO] [stdout] | [INFO] [stdout] 432 | for i in (0..expected_path.len()) { assert_eq!(result[i], expected_path[i]); } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `for` iterator expression [INFO] [stdout] --> src/lib.rs:493:16 [INFO] [stdout] | [INFO] [stdout] 493 | for i in (0..expected_path.len()) { assert_eq!(result[i], expected_path[i]); } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `for` iterator expression [INFO] [stdout] --> src/lib.rs:556:16 [INFO] [stdout] | [INFO] [stdout] 556 | for i in (0..expected_path.len()) { assert_eq!(result[i], expected_path[i]); } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `for` iterator expression [INFO] [stdout] --> src/lib.rs:616:16 [INFO] [stdout] | [INFO] [stdout] 616 | for i in (0..expected_path.len()) { assert_eq!(result[i], expected_path[i]); } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `for` iterator expression [INFO] [stdout] --> src/lib.rs:678:16 [INFO] [stdout] | [INFO] [stdout] 678 | for i in (0..expected_path.len()) { assert_eq!(result[i], expected_path[i]); } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `for` iterator expression [INFO] [stdout] --> src/lib.rs:738:16 [INFO] [stdout] | [INFO] [stdout] 738 | for i in (0..expected_path.len()) { assert_eq!(result[i], expected_path[i]); } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `for` iterator expression [INFO] [stdout] --> src/lib.rs:830:16 [INFO] [stdout] | [INFO] [stdout] 830 | for i in (0..expected_path.len()) { assert_eq!(result[i], expected_path[i]); } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `for` iterator expression [INFO] [stdout] --> src/lib.rs:299:14 [INFO] [stdout] | [INFO] [stdout] 299 | for i in (0..path.len()-1) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `for` iterator expression [INFO] [stdout] --> src/lib.rs:320:14 [INFO] [stdout] | [INFO] [stdout] 320 | for i in (0..self.graph.len()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/lib.rs:352:11 [INFO] [stdout] | [INFO] [stdout] 352 | let mut v: Option; [INFO] [stdout] | ----^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 10 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/lib.rs:352:11 [INFO] [stdout] | [INFO] [stdout] 352 | let mut v: Option; [INFO] [stdout] | ----^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] running `Command { std: "docker" "inspect" "2f8e30337271fe27c93597da979119d5329ed7281299da93c699ba7ee205c282", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "2f8e30337271fe27c93597da979119d5329ed7281299da93c699ba7ee205c282", kill_on_drop: false }` [INFO] [stdout] 2f8e30337271fe27c93597da979119d5329ed7281299da93c699ba7ee205c282