[INFO] cloning repository https://github.com/jonknet/GbInRust [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/jonknet/GbInRust" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fjonknet%2FGbInRust", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fjonknet%2FGbInRust'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 2bb36e46a26c288b5b133e8ca3d972327efb88ba [INFO] checking jonknet/GbInRust against try#3e59a8c2f14152ccc92a6c079f592dc2dc6fa93f for pr-87248 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fjonknet%2FGbInRust" "/workspace/builds/worker-3/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-3/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/jonknet/GbInRust on toolchain 3e59a8c2f14152ccc92a6c079f592dc2dc6fa93f [INFO] running `Command { std: "/workspace/cargo-home/bin/cargo" "+3e59a8c2f14152ccc92a6c079f592dc2dc6fa93f" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/jonknet/GbInRust [INFO] finished tweaking git repo https://github.com/jonknet/GbInRust [INFO] tweaked toml for git repo https://github.com/jonknet/GbInRust written to /workspace/builds/worker-3/source/Cargo.toml [INFO] crate git repo https://github.com/jonknet/GbInRust already has a lockfile, it will not be regenerated [INFO] running `Command { std: "/workspace/cargo-home/bin/cargo" "+3e59a8c2f14152ccc92a6c079f592dc2dc6fa93f" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded version-compare v0.0.10 [INFO] [stderr] Downloaded sdl2 v0.34.5 [INFO] [stderr] Downloaded sdl2-sys v0.34.5 [INFO] [stderr] Downloaded tokio v1.6.0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:34b6a614d2c27851fe6cbf88fbd1137609cefab8b10d0615aaeb6fd47975d74e" "/opt/rustwide/cargo-home/bin/cargo" "+3e59a8c2f14152ccc92a6c079f592dc2dc6fa93f" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] d224c2a3b1fcf45f5696f6a00d2d3907a27dbebe941e14f19d048bd88566c742 [INFO] [stderr] WARNING: Your kernel does not support swap limit capabilities or the cgroup is not mounted. Memory limited without swap. [INFO] running `Command { std: "docker" "start" "-a" "d224c2a3b1fcf45f5696f6a00d2d3907a27dbebe941e14f19d048bd88566c742", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "d224c2a3b1fcf45f5696f6a00d2d3907a27dbebe941e14f19d048bd88566c742", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "d224c2a3b1fcf45f5696f6a00d2d3907a27dbebe941e14f19d048bd88566c742", kill_on_drop: false }` [INFO] [stdout] d224c2a3b1fcf45f5696f6a00d2d3907a27dbebe941e14f19d048bd88566c742 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:34b6a614d2c27851fe6cbf88fbd1137609cefab8b10d0615aaeb6fd47975d74e" "/opt/rustwide/cargo-home/bin/cargo" "+3e59a8c2f14152ccc92a6c079f592dc2dc6fa93f" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 450d6f647d3e498cb451ca3ef8e32afd5e148952367433324cddff48025bd284 [INFO] [stderr] WARNING: Your kernel does not support swap limit capabilities or the cgroup is not mounted. Memory limited without swap. [INFO] running `Command { std: "docker" "start" "-a" "450d6f647d3e498cb451ca3ef8e32afd5e148952367433324cddff48025bd284", kill_on_drop: false }` [INFO] [stderr] Checking cfg-if v1.0.0 [INFO] [stderr] Compiling libc v0.2.94 [INFO] [stderr] Compiling proc-macro2 v1.0.27 [INFO] [stderr] Checking scopeguard v1.1.0 [INFO] [stderr] Compiling unicode-xid v0.2.2 [INFO] [stderr] Compiling cfg-if v0.1.10 [INFO] [stderr] Compiling syn v1.0.72 [INFO] [stderr] Compiling log v0.4.14 [INFO] [stderr] Compiling memchr v2.4.0 [INFO] [stderr] Checking smallvec v1.6.1 [INFO] [stderr] Checking bytes v1.0.1 [INFO] [stderr] Checking once_cell v1.7.2 [INFO] [stderr] Checking pin-project-lite v0.2.6 [INFO] [stderr] Compiling crossbeam-utils v0.8.4 [INFO] [stderr] Compiling memoffset v0.6.3 [INFO] [stderr] Compiling tokio v1.6.0 [INFO] [stderr] Compiling num-traits v0.2.14 [INFO] [stderr] Checking lock_api v0.4.4 [INFO] [stderr] Compiling sdl2-sys v0.34.5 [INFO] [stderr] Checking instant v0.1.9 [INFO] [stderr] Compiling sdl2 v0.34.5 [INFO] [stderr] Checking crossbeam-epoch v0.9.4 [INFO] [stderr] Checking crossbeam-channel v0.5.1 [INFO] [stderr] Checking crossbeam-queue v0.3.1 [INFO] [stderr] Compiling quote v1.0.9 [INFO] [stderr] Checking parking_lot_core v0.8.3 [INFO] [stderr] Checking mio v0.7.11 [INFO] [stderr] Checking signal-hook-registry v1.3.0 [INFO] [stderr] Checking num_cpus v1.13.0 [INFO] [stderr] Checking parking_lot v0.11.1 [INFO] [stderr] Checking crossbeam-deque v0.8.0 [INFO] [stderr] Checking crossbeam v0.8.0 [INFO] [stderr] Compiling tokio-macros v1.2.0 [INFO] [stderr] Checking rustygb v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `borrow::BorrowMut` [INFO] [stdout] --> src/main.rs:4:11 [INFO] [stdout] | [INFO] [stdout] 4 | use std::{borrow::BorrowMut, fs}; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::path::Path` [INFO] [stdout] --> src/main.rs:5:5 [INFO] [stdout] | [INFO] [stdout] 5 | use std::path::Path; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::fs::File` [INFO] [stdout] --> src/main.rs:6:5 [INFO] [stdout] | [INFO] [stdout] 6 | use std::fs::File; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `RwLock` [INFO] [stdout] --> src/main.rs:7:22 [INFO] [stdout] | [INFO] [stdout] 7 | use std::sync::{Arc, RwLock, Mutex}; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::cell::RefCell` [INFO] [stdout] --> src/main.rs:13:5 [INFO] [stdout] | [INFO] [stdout] 13 | use std::cell::RefCell; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Deref` [INFO] [stdout] --> src/main.rs:15:16 [INFO] [stdout] | [INFO] [stdout] 15 | use std::ops::{Deref, AddAssign}; [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `AtomicU64`, `Ordering` [INFO] [stdout] --> src/main.rs:16:25 [INFO] [stdout] | [INFO] [stdout] 16 | use std::sync::atomic::{AtomicU64,Ordering}; [INFO] [stdout] | ^^^^^^^^^ ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Thread` [INFO] [stdout] --> src/main.rs:18:31 [INFO] [stdout] | [INFO] [stdout] 18 | use std::thread::{JoinHandle, Thread}; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::error::Error` [INFO] [stdout] --> src/main.rs:19:5 [INFO] [stdout] | [INFO] [stdout] 19 | use std::error::Error; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `Infallible`, `TryInto` [INFO] [stdout] --> src/main.rs:20:20 [INFO] [stdout] | [INFO] [stdout] 20 | use std::convert::{TryInto, Infallible}; [INFO] [stdout] | ^^^^^^^ ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `BorrowMut`, `Borrow`, `Mutex`, `RwLock` [INFO] [stdout] --> src/cpu.rs:4:20 [INFO] [stdout] | [INFO] [stdout] 4 | use std::{borrow::{Borrow, BorrowMut}, sync::{Arc, Mutex, MutexGuard, RwLock}}; [INFO] [stdout] | ^^^^^^ ^^^^^^^^^ ^^^^^ ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::ops::BitAnd` [INFO] [stdout] --> src/cpu.rs:5:5 [INFO] [stdout] | [INFO] [stdout] 5 | use std::ops::BitAnd; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `num_traits::AsPrimitive` [INFO] [stdout] --> src/cpu/ops.rs:2:5 [INFO] [stdout] | [INFO] [stdout] 2 | use num_traits::AsPrimitive; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/cpu/ops.rs:723:12 [INFO] [stdout] | [INFO] [stdout] 723 | if (v2.is_negative()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/cpu/ops.rs:805:12 [INFO] [stdout] | [INFO] [stdout] 805 | if (cond) { [INFO] [stdout] | ^^^^^^ help: remove these parentheses [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `b` should have an upper camel case name [INFO] [stdout] --> src/cpu.rs:14:5 [INFO] [stdout] | [INFO] [stdout] 14 | b,c,d,e,h,l,a,f, [INFO] [stdout] | ^ help: convert the identifier to upper camel case: `B` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_camel_case_types)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `c` should have an upper camel case name [INFO] [stdout] --> src/cpu.rs:14:7 [INFO] [stdout] | [INFO] [stdout] 14 | b,c,d,e,h,l,a,f, [INFO] [stdout] | ^ help: convert the identifier to upper camel case (notice the capitalization): `C` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `d` should have an upper camel case name [INFO] [stdout] --> src/cpu.rs:14:9 [INFO] [stdout] | [INFO] [stdout] 14 | b,c,d,e,h,l,a,f, [INFO] [stdout] | ^ help: convert the identifier to upper camel case: `D` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `e` should have an upper camel case name [INFO] [stdout] --> src/cpu.rs:14:11 [INFO] [stdout] | [INFO] [stdout] 14 | b,c,d,e,h,l,a,f, [INFO] [stdout] | ^ help: convert the identifier to upper camel case: `E` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `h` should have an upper camel case name [INFO] [stdout] --> src/cpu.rs:14:13 [INFO] [stdout] | [INFO] [stdout] 14 | b,c,d,e,h,l,a,f, [INFO] [stdout] | ^ help: convert the identifier to upper camel case: `H` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `l` should have an upper camel case name [INFO] [stdout] --> src/cpu.rs:14:15 [INFO] [stdout] | [INFO] [stdout] 14 | b,c,d,e,h,l,a,f, [INFO] [stdout] | ^ help: convert the identifier to upper camel case: `L` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `a` should have an upper camel case name [INFO] [stdout] --> src/cpu.rs:14:17 [INFO] [stdout] | [INFO] [stdout] 14 | b,c,d,e,h,l,a,f, [INFO] [stdout] | ^ help: convert the identifier to upper camel case: `A` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `f` should have an upper camel case name [INFO] [stdout] --> src/cpu.rs:14:19 [INFO] [stdout] | [INFO] [stdout] 14 | b,c,d,e,h,l,a,f, [INFO] [stdout] | ^ help: convert the identifier to upper camel case (notice the capitalization): `F` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `af` should have an upper camel case name [INFO] [stdout] --> src/cpu.rs:15:5 [INFO] [stdout] | [INFO] [stdout] 15 | af,bc,de,hl, [INFO] [stdout] | ^^ help: convert the identifier to upper camel case: `Af` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `bc` should have an upper camel case name [INFO] [stdout] --> src/cpu.rs:15:8 [INFO] [stdout] | [INFO] [stdout] 15 | af,bc,de,hl, [INFO] [stdout] | ^^ help: convert the identifier to upper camel case: `Bc` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `de` should have an upper camel case name [INFO] [stdout] --> src/cpu.rs:15:11 [INFO] [stdout] | [INFO] [stdout] 15 | af,bc,de,hl, [INFO] [stdout] | ^^ help: convert the identifier to upper camel case: `De` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `hl` should have an upper camel case name [INFO] [stdout] --> src/cpu.rs:15:14 [INFO] [stdout] | [INFO] [stdout] 15 | af,bc,de,hl, [INFO] [stdout] | ^^ help: convert the identifier to upper camel case: `Hl` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `pc` should have an upper camel case name [INFO] [stdout] --> src/cpu.rs:16:5 [INFO] [stdout] | [INFO] [stdout] 16 | pc,sp [INFO] [stdout] | ^^ help: convert the identifier to upper camel case: `Pc` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `sp` should have an upper camel case name [INFO] [stdout] --> src/cpu.rs:16:8 [INFO] [stdout] | [INFO] [stdout] 16 | pc,sp [INFO] [stdout] | ^^ help: convert the identifier to upper camel case (notice the capitalization): `Sp` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `Arc`, `RwLock` [INFO] [stdout] --> src/mem.rs:1:17 [INFO] [stdout] | [INFO] [stdout] 1 | use std::sync::{RwLock, Arc}; [INFO] [stdout] | ^^^^^^ ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `crate::cpu::Register::a` [INFO] [stdout] --> src/mem.rs:2:5 [INFO] [stdout] | [INFO] [stdout] 2 | use crate::cpu::Register::a; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/mem.rs:45:11 [INFO] [stdout] | [INFO] [stdout] 45 | if(val > 255) { [INFO] [stdout] | ^^^^^^^^^^^ help: remove these parentheses [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `Mutex`, `ptr::null`, `thread` [INFO] [stdout] --> src/ppu.rs:2:11 [INFO] [stdout] | [INFO] [stdout] 2 | use std::{ptr::null, sync::{Arc, Mutex, MutexGuard}, thread}; [INFO] [stdout] | ^^^^^^^^^ ^^^^^ ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::ops::Deref` [INFO] [stdout] --> src/ppu.rs:4:5 [INFO] [stdout] | [INFO] [stdout] 4 | use std::ops::Deref; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::cell::RefCell` [INFO] [stdout] --> src/ppu.rs:5:5 [INFO] [stdout] | [INFO] [stdout] 5 | use std::cell::RefCell; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::time::Duration` [INFO] [stdout] --> src/ppu.rs:6:5 [INFO] [stdout] | [INFO] [stdout] 6 | use std::time::Duration; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Ordering` [INFO] [stdout] --> src/ppu.rs:7:36 [INFO] [stdout] | [INFO] [stdout] 7 | use std::sync::atomic::{AtomicU64, Ordering}; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around assigned value [INFO] [stdout] --> src/ppu.rs:90:27 [INFO] [stdout] | [INFO] [stdout] 90 | let sx: i16 = (s.x as i16 - 8); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary trailing semicolon [INFO] [stdout] --> src/ppu.rs:148:74 [INFO] [stdout] | [INFO] [stdout] 148 | pub fn render_screen_to_fb(&mut self, mut lock: MutexGuard){ ; [INFO] [stdout] | ^ help: remove this semicolon [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(redundant_semicolons)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around function argument [INFO] [stdout] --> src/main.rs:115:33 [INFO] [stdout] | [INFO] [stdout] 115 | cpu_thread = Box::from(Some((thread::spawn(move || { [INFO] [stdout] | _________________________________^ [INFO] [stdout] 116 | | let mut cpumtx1 = cpumtx.lock().unwrap(); [INFO] [stdout] 117 | | let mut start = time::Instant::now(); [INFO] [stdout] 118 | | [INFO] [stdout] ... | [INFO] [stdout] 135 | | } [INFO] [stdout] 136 | | })))); [INFO] [stdout] | |_______^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 115 | cpu_thread = Box::from(Some(thread::spawn(move || { [INFO] [stdout] 116 | let mut cpumtx1 = cpumtx.lock().unwrap(); [INFO] [stdout] 117 | let mut start = time::Instant::now(); [INFO] [stdout] 118 | [INFO] [stdout] 119 | cpumtx1.R.pc = 0; [INFO] [stdout] 120 | loop { [INFO] [stdout] ... [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `while` condition [INFO] [stdout] --> src/main.rs:131:22 [INFO] [stdout] | [INFO] [stdout] 131 | while(!cpu_resume.load()){ [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `borrow::BorrowMut` [INFO] [stdout] --> src/main.rs:4:11 [INFO] [stdout] | [INFO] [stdout] 4 | use std::{borrow::BorrowMut, fs}; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::path::Path` [INFO] [stdout] --> src/main.rs:5:5 [INFO] [stdout] | [INFO] [stdout] 5 | use std::path::Path; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::fs::File` [INFO] [stdout] --> src/main.rs:6:5 [INFO] [stdout] | [INFO] [stdout] 6 | use std::fs::File; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `RwLock` [INFO] [stdout] --> src/main.rs:7:22 [INFO] [stdout] | [INFO] [stdout] 7 | use std::sync::{Arc, RwLock, Mutex}; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::cell::RefCell` [INFO] [stdout] --> src/main.rs:13:5 [INFO] [stdout] | [INFO] [stdout] 13 | use std::cell::RefCell; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Deref` [INFO] [stdout] --> src/main.rs:15:16 [INFO] [stdout] | [INFO] [stdout] 15 | use std::ops::{Deref, AddAssign}; [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `AtomicU64`, `Ordering` [INFO] [stdout] --> src/main.rs:16:25 [INFO] [stdout] | [INFO] [stdout] 16 | use std::sync::atomic::{AtomicU64,Ordering}; [INFO] [stdout] | ^^^^^^^^^ ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Thread` [INFO] [stdout] --> src/main.rs:18:31 [INFO] [stdout] | [INFO] [stdout] 18 | use std::thread::{JoinHandle, Thread}; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::error::Error` [INFO] [stdout] --> src/main.rs:19:5 [INFO] [stdout] | [INFO] [stdout] 19 | use std::error::Error; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `Infallible`, `TryInto` [INFO] [stdout] --> src/main.rs:20:20 [INFO] [stdout] | [INFO] [stdout] 20 | use std::convert::{TryInto, Infallible}; [INFO] [stdout] | ^^^^^^^ ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `BorrowMut`, `Borrow`, `Mutex`, `RwLock` [INFO] [stdout] --> src/cpu.rs:4:20 [INFO] [stdout] | [INFO] [stdout] 4 | use std::{borrow::{Borrow, BorrowMut}, sync::{Arc, Mutex, MutexGuard, RwLock}}; [INFO] [stdout] | ^^^^^^ ^^^^^^^^^ ^^^^^ ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::ops::BitAnd` [INFO] [stdout] --> src/cpu.rs:5:5 [INFO] [stdout] | [INFO] [stdout] 5 | use std::ops::BitAnd; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `num_traits::AsPrimitive` [INFO] [stdout] --> src/cpu/ops.rs:2:5 [INFO] [stdout] | [INFO] [stdout] 2 | use num_traits::AsPrimitive; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/cpu/ops.rs:723:12 [INFO] [stdout] | [INFO] [stdout] 723 | if (v2.is_negative()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/cpu/ops.rs:805:12 [INFO] [stdout] | [INFO] [stdout] 805 | if (cond) { [INFO] [stdout] | ^^^^^^ help: remove these parentheses [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `b` should have an upper camel case name [INFO] [stdout] --> src/cpu.rs:14:5 [INFO] [stdout] | [INFO] [stdout] 14 | b,c,d,e,h,l,a,f, [INFO] [stdout] | ^ help: convert the identifier to upper camel case: `B` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_camel_case_types)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `c` should have an upper camel case name [INFO] [stdout] --> src/cpu.rs:14:7 [INFO] [stdout] | [INFO] [stdout] 14 | b,c,d,e,h,l,a,f, [INFO] [stdout] | ^ help: convert the identifier to upper camel case (notice the capitalization): `C` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `d` should have an upper camel case name [INFO] [stdout] --> src/cpu.rs:14:9 [INFO] [stdout] | [INFO] [stdout] 14 | b,c,d,e,h,l,a,f, [INFO] [stdout] | ^ help: convert the identifier to upper camel case: `D` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `e` should have an upper camel case name [INFO] [stdout] --> src/cpu.rs:14:11 [INFO] [stdout] | [INFO] [stdout] 14 | b,c,d,e,h,l,a,f, [INFO] [stdout] | ^ help: convert the identifier to upper camel case: `E` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `h` should have an upper camel case name [INFO] [stdout] --> src/cpu.rs:14:13 [INFO] [stdout] | [INFO] [stdout] 14 | b,c,d,e,h,l,a,f, [INFO] [stdout] | ^ help: convert the identifier to upper camel case: `H` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `l` should have an upper camel case name [INFO] [stdout] --> src/cpu.rs:14:15 [INFO] [stdout] | [INFO] [stdout] 14 | b,c,d,e,h,l,a,f, [INFO] [stdout] | ^ help: convert the identifier to upper camel case: `L` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `a` should have an upper camel case name [INFO] [stdout] --> src/cpu.rs:14:17 [INFO] [stdout] | [INFO] [stdout] 14 | b,c,d,e,h,l,a,f, [INFO] [stdout] | ^ help: convert the identifier to upper camel case: `A` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `f` should have an upper camel case name [INFO] [stdout] --> src/cpu.rs:14:19 [INFO] [stdout] | [INFO] [stdout] 14 | b,c,d,e,h,l,a,f, [INFO] [stdout] | ^ help: convert the identifier to upper camel case (notice the capitalization): `F` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `af` should have an upper camel case name [INFO] [stdout] --> src/cpu.rs:15:5 [INFO] [stdout] | [INFO] [stdout] 15 | af,bc,de,hl, [INFO] [stdout] | ^^ help: convert the identifier to upper camel case: `Af` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `bc` should have an upper camel case name [INFO] [stdout] --> src/cpu.rs:15:8 [INFO] [stdout] | [INFO] [stdout] 15 | af,bc,de,hl, [INFO] [stdout] | ^^ help: convert the identifier to upper camel case: `Bc` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `de` should have an upper camel case name [INFO] [stdout] --> src/cpu.rs:15:11 [INFO] [stdout] | [INFO] [stdout] 15 | af,bc,de,hl, [INFO] [stdout] | ^^ help: convert the identifier to upper camel case: `De` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `hl` should have an upper camel case name [INFO] [stdout] --> src/cpu.rs:15:14 [INFO] [stdout] | [INFO] [stdout] 15 | af,bc,de,hl, [INFO] [stdout] | ^^ help: convert the identifier to upper camel case: `Hl` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `pc` should have an upper camel case name [INFO] [stdout] --> src/cpu.rs:16:5 [INFO] [stdout] | [INFO] [stdout] 16 | pc,sp [INFO] [stdout] | ^^ help: convert the identifier to upper camel case: `Pc` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `sp` should have an upper camel case name [INFO] [stdout] --> src/cpu.rs:16:8 [INFO] [stdout] | [INFO] [stdout] 16 | pc,sp [INFO] [stdout] | ^^ help: convert the identifier to upper camel case (notice the capitalization): `Sp` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `Arc`, `RwLock` [INFO] [stdout] --> src/mem.rs:1:17 [INFO] [stdout] | [INFO] [stdout] 1 | use std::sync::{RwLock, Arc}; [INFO] [stdout] | ^^^^^^ ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `crate::cpu::Register::a` [INFO] [stdout] --> src/mem.rs:2:5 [INFO] [stdout] | [INFO] [stdout] 2 | use crate::cpu::Register::a; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/mem.rs:45:11 [INFO] [stdout] | [INFO] [stdout] 45 | if(val > 255) { [INFO] [stdout] | ^^^^^^^^^^^ help: remove these parentheses [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `Mutex`, `ptr::null`, `thread` [INFO] [stdout] --> src/ppu.rs:2:11 [INFO] [stdout] | [INFO] [stdout] 2 | use std::{ptr::null, sync::{Arc, Mutex, MutexGuard}, thread}; [INFO] [stdout] | ^^^^^^^^^ ^^^^^ ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::ops::Deref` [INFO] [stdout] --> src/ppu.rs:4:5 [INFO] [stdout] | [INFO] [stdout] 4 | use std::ops::Deref; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::cell::RefCell` [INFO] [stdout] --> src/ppu.rs:5:5 [INFO] [stdout] | [INFO] [stdout] 5 | use std::cell::RefCell; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::time::Duration` [INFO] [stdout] --> src/ppu.rs:6:5 [INFO] [stdout] | [INFO] [stdout] 6 | use std::time::Duration; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Ordering` [INFO] [stdout] --> src/ppu.rs:7:36 [INFO] [stdout] | [INFO] [stdout] 7 | use std::sync::atomic::{AtomicU64, Ordering}; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around assigned value [INFO] [stdout] --> src/ppu.rs:90:27 [INFO] [stdout] | [INFO] [stdout] 90 | let sx: i16 = (s.x as i16 - 8); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary trailing semicolon [INFO] [stdout] --> src/ppu.rs:148:74 [INFO] [stdout] | [INFO] [stdout] 148 | pub fn render_screen_to_fb(&mut self, mut lock: MutexGuard){ ; [INFO] [stdout] | ^ help: remove this semicolon [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(redundant_semicolons)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around function argument [INFO] [stdout] --> src/main.rs:115:33 [INFO] [stdout] | [INFO] [stdout] 115 | cpu_thread = Box::from(Some((thread::spawn(move || { [INFO] [stdout] | _________________________________^ [INFO] [stdout] 116 | | let mut cpumtx1 = cpumtx.lock().unwrap(); [INFO] [stdout] 117 | | let mut start = time::Instant::now(); [INFO] [stdout] 118 | | [INFO] [stdout] ... | [INFO] [stdout] 135 | | } [INFO] [stdout] 136 | | })))); [INFO] [stdout] | |_______^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 115 | cpu_thread = Box::from(Some(thread::spawn(move || { [INFO] [stdout] 116 | let mut cpumtx1 = cpumtx.lock().unwrap(); [INFO] [stdout] 117 | let mut start = time::Instant::now(); [INFO] [stdout] 118 | [INFO] [stdout] 119 | cpumtx1.R.pc = 0; [INFO] [stdout] 120 | loop { [INFO] [stdout] ... [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `while` condition [INFO] [stdout] --> src/main.rs:131:22 [INFO] [stdout] | [INFO] [stdout] 131 | while(!cpu_resume.load()){ [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `ppumtx` [INFO] [stdout] --> src/main.rs:83:13 [INFO] [stdout] | [INFO] [stdout] 83 | let mut ppumtx = Arc::clone(&ppu); [INFO] [stdout] | ^^^^^^ help: if this is intentional, prefix it with an underscore: `_ppumtx` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: value assigned to `cpu_thread` is never read [INFO] [stdout] --> src/main.rs:86:13 [INFO] [stdout] | [INFO] [stdout] 86 | let mut cpu_thread: Box>> = Box::new(None); [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_assignments)]` on by default [INFO] [stdout] = help: maybe it is overwritten before being read? [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `buffer` [INFO] [stdout] --> src/ppu.rs:60:17 [INFO] [stdout] | [INFO] [stdout] 60 | let mut buffer: [u8;256] = [0;256]; [INFO] [stdout] | ^^^^^^ help: if this is intentional, prefix it with an underscore: `_buffer` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `scy` [INFO] [stdout] --> src/ppu.rs:74:13 [INFO] [stdout] | [INFO] [stdout] 74 | let scy = mlock.read(0xFF42); [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_scy` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `scx` [INFO] [stdout] --> src/ppu.rs:75:13 [INFO] [stdout] | [INFO] [stdout] 75 | let scx = mlock.read(0xFF43); [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_scx` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `pitch` [INFO] [stdout] --> src/ppu.rs:138:53 [INFO] [stdout] | [INFO] [stdout] 138 | texture.with_lock(None, |buffer: &mut [u8], pitch: usize| { [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_pitch` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `ppumtx` [INFO] [stdout] --> src/main.rs:83:13 [INFO] [stdout] | [INFO] [stdout] 83 | let mut ppumtx = Arc::clone(&ppu); [INFO] [stdout] | ^^^^^^ help: if this is intentional, prefix it with an underscore: `_ppumtx` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: value assigned to `cpu_thread` is never read [INFO] [stdout] --> src/main.rs:86:13 [INFO] [stdout] | [INFO] [stdout] 86 | let mut cpu_thread: Box>> = Box::new(None); [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_assignments)]` on by default [INFO] [stdout] = help: maybe it is overwritten before being read? [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `buffer` [INFO] [stdout] --> src/ppu.rs:60:17 [INFO] [stdout] | [INFO] [stdout] 60 | let mut buffer: [u8;256] = [0;256]; [INFO] [stdout] | ^^^^^^ help: if this is intentional, prefix it with an underscore: `_buffer` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `scy` [INFO] [stdout] --> src/ppu.rs:74:13 [INFO] [stdout] | [INFO] [stdout] 74 | let scy = mlock.read(0xFF42); [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_scy` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `scx` [INFO] [stdout] --> src/ppu.rs:75:13 [INFO] [stdout] | [INFO] [stdout] 75 | let scx = mlock.read(0xFF43); [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_scx` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `pitch` [INFO] [stdout] --> src/ppu.rs:138:53 [INFO] [stdout] | [INFO] [stdout] 138 | texture.with_lock(None, |buffer: &mut [u8], pitch: usize| { [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_pitch` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/main.rs:91:17 [INFO] [stdout] | [INFO] [stdout] 91 | let mut mtx3 = mtx2.try_lock(); [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error[E0596]: cannot borrow data in a `&` reference as mutable [INFO] [stdout] --> src/main.rs:96:64 [INFO] [stdout] | [INFO] [stdout] 96 | ppumtx2.lock().unwrap().render_line(i, &mut mtx3.as_ref().unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ cannot borrow as mutable [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/main.rs:122:21 [INFO] [stdout] | [INFO] [stdout] 122 | let mut mtx4 = mtx1.try_lock(); [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/main.rs:37:9 [INFO] [stdout] | [INFO] [stdout] 37 | let mut globalCycles = Arc::new(Mutex::new(0)); [INFO] [stdout] | ----^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/main.rs:39:9 [INFO] [stdout] | [INFO] [stdout] 39 | let mut mem = Arc::new(Mutex::new(Memory::new(0))); [INFO] [stdout] | ----^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/main.rs:40:9 [INFO] [stdout] | [INFO] [stdout] 40 | let mut cpu = Arc::new(Mutex::new(Cpu::new())); [INFO] [stdout] | ----^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/main.rs:41:9 [INFO] [stdout] | [INFO] [stdout] 41 | let mut ppu = Arc::new(Mutex::new(Ppu::new())); [INFO] [stdout] | ----^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/main.rs:43:9 [INFO] [stdout] | [INFO] [stdout] 43 | let mut memmtx = Arc::clone(&mem); [INFO] [stdout] | ----^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/main.rs:83:9 [INFO] [stdout] | [INFO] [stdout] 83 | let mut ppumtx = Arc::clone(&ppu); [INFO] [stdout] | ----^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/main.rs:84:9 [INFO] [stdout] | [INFO] [stdout] 84 | let mut mtx2 = Arc::clone(&mem); [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/main.rs:85:9 [INFO] [stdout] | [INFO] [stdout] 85 | let mut gc1 = Arc::clone(&globalCycles); [INFO] [stdout] | ----^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/main.rs:114:9 [INFO] [stdout] | [INFO] [stdout] 114 | let mut mtx1 = Arc::clone(&mem); [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/main.rs:142:9 [INFO] [stdout] | [INFO] [stdout] 142 | let mut ppumtx2 = Arc::clone(&ppu); [INFO] [stdout] | ----^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/main.rs:156:17 [INFO] [stdout] | [INFO] [stdout] 156 | let mut mtx = ppumtx2.try_lock(); [INFO] [stdout] | ----^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error[E0015]: calls in statics are limited to constant functions, tuple structs and tuple variants [INFO] [stdout] --> src/main.rs:89:47 [INFO] [stdout] | [INFO] [stdout] 89 | static ppumtx2: Arc> = ppumtx2.into(); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/main.rs:91:17 [INFO] [stdout] | [INFO] [stdout] 91 | let mut mtx3 = mtx2.try_lock(); [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error[E0596]: cannot borrow data in a `&` reference as mutable [INFO] [stdout] --> src/main.rs:96:64 [INFO] [stdout] | [INFO] [stdout] 96 | ppumtx2.lock().unwrap().render_line(i, &mut mtx3.as_ref().unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ cannot borrow as mutable [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/main.rs:122:21 [INFO] [stdout] | [INFO] [stdout] 122 | let mut mtx4 = mtx1.try_lock(); [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/main.rs:37:9 [INFO] [stdout] | [INFO] [stdout] 37 | let mut globalCycles = Arc::new(Mutex::new(0)); [INFO] [stdout] | ----^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/main.rs:39:9 [INFO] [stdout] | [INFO] [stdout] 39 | let mut mem = Arc::new(Mutex::new(Memory::new(0))); [INFO] [stdout] | ----^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/main.rs:40:9 [INFO] [stdout] | [INFO] [stdout] 40 | let mut cpu = Arc::new(Mutex::new(Cpu::new())); [INFO] [stdout] | ----^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/main.rs:41:9 [INFO] [stdout] | [INFO] [stdout] 41 | let mut ppu = Arc::new(Mutex::new(Ppu::new())); [INFO] [stdout] | ----^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/main.rs:43:9 [INFO] [stdout] | [INFO] [stdout] 43 | let mut memmtx = Arc::clone(&mem); [INFO] [stdout] | ----^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/main.rs:83:9 [INFO] [stdout] | [INFO] [stdout] 83 | let mut ppumtx = Arc::clone(&ppu); [INFO] [stdout] | ----^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/main.rs:84:9 [INFO] [stdout] | [INFO] [stdout] 84 | let mut mtx2 = Arc::clone(&mem); [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/main.rs:85:9 [INFO] [stdout] | [INFO] [stdout] 85 | let mut gc1 = Arc::clone(&globalCycles); [INFO] [stdout] | ----^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/main.rs:114:9 [INFO] [stdout] | [INFO] [stdout] 114 | let mut mtx1 = Arc::clone(&mem); [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/main.rs:142:9 [INFO] [stdout] | [INFO] [stdout] 142 | let mut ppumtx2 = Arc::clone(&ppu); [INFO] [stdout] | ----^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/main.rs:156:17 [INFO] [stdout] | [INFO] [stdout] 156 | let mut mtx = ppumtx2.try_lock(); [INFO] [stdout] | ----^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error[E0015]: calls in statics are limited to constant functions, tuple structs and tuple variants [INFO] [stdout] --> src/main.rs:89:47 [INFO] [stdout] | [INFO] [stdout] 89 | static ppumtx2: Arc> = ppumtx2.into(); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error[E0507]: cannot move out of static item `ppumtx2` [INFO] [stdout] --> src/main.rs:89:47 [INFO] [stdout] | [INFO] [stdout] 89 | static ppumtx2: Arc> = ppumtx2.into(); [INFO] [stdout] | ^^^^^^^ move occurs because `ppumtx2` has type `Arc>`, which does not implement the `Copy` trait [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error[E0507]: cannot move out of static item `ppumtx2` [INFO] [stdout] --> src/main.rs:89:47 [INFO] [stdout] | [INFO] [stdout] 89 | static ppumtx2: Arc> = ppumtx2.into(); [INFO] [stdout] | ^^^^^^^ move occurs because `ppumtx2` has type `Arc>`, which does not implement the `Copy` trait [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/cpu.rs:54:13 [INFO] [stdout] | [INFO] [stdout] 54 | let mut lock = mtx; [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/cpu.rs:98:13 [INFO] [stdout] | [INFO] [stdout] 98 | let mut lock = m; [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/cpu.rs:54:13 [INFO] [stdout] | [INFO] [stdout] 54 | let mut lock = mtx; [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/cpu.rs:106:38 [INFO] [stdout] | [INFO] [stdout] 106 | pub fn push(&mut self, val: u16, mut m: &mut MutexGuard){ [INFO] [stdout] | ----^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/cpu.rs:98:13 [INFO] [stdout] | [INFO] [stdout] 98 | let mut lock = m; [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/cpu.rs:106:38 [INFO] [stdout] | [INFO] [stdout] 106 | pub fn push(&mut self, val: u16, mut m: &mut MutexGuard){ [INFO] [stdout] | ----^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/ppu.rs:60:13 [INFO] [stdout] | [INFO] [stdout] 60 | let mut buffer: [u8;256] = [0;256]; [INFO] [stdout] | ----^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/ppu.rs:95:17 [INFO] [stdout] | [INFO] [stdout] 95 | for mut x in i..8 { [INFO] [stdout] | ----^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors; 65 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] Some errors have detailed explanations: E0015, E0507, E0596. [INFO] [stdout] [INFO] [stdout] For more information about an error, try `rustc --explain E0015`. [INFO] [stdout] [INFO] [stderr] error: could not compile `rustygb` due to 4 previous errors; 65 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/ppu.rs:60:13 [INFO] [stdout] | [INFO] [stdout] 60 | let mut buffer: [u8;256] = [0;256]; [INFO] [stdout] | ----^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/ppu.rs:95:17 [INFO] [stdout] | [INFO] [stdout] 95 | for mut x in i..8 { [INFO] [stdout] | ----^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors; 65 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] Some errors have detailed explanations: E0015, E0507, E0596. [INFO] [stdout] [INFO] [stdout] For more information about an error, try `rustc --explain E0015`. [INFO] [stdout] [INFO] [stderr] error: build failed [INFO] running `Command { std: "docker" "inspect" "450d6f647d3e498cb451ca3ef8e32afd5e148952367433324cddff48025bd284", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "450d6f647d3e498cb451ca3ef8e32afd5e148952367433324cddff48025bd284", kill_on_drop: false }` [INFO] [stdout] 450d6f647d3e498cb451ca3ef8e32afd5e148952367433324cddff48025bd284