[INFO] fetching crate rust_ofp 0.2.1... [INFO] checking rust_ofp-0.2.1 against master#5a8a44196b3cf099f8c9b0156bd902eaec0b4e5f for pr-87248 [INFO] extracting crate rust_ofp 0.2.1 into /workspace/builds/worker-5/source [INFO] validating manifest of crates.io crate rust_ofp 0.2.1 on toolchain 5a8a44196b3cf099f8c9b0156bd902eaec0b4e5f [INFO] running `Command { std: "/workspace/cargo-home/bin/cargo" "+5a8a44196b3cf099f8c9b0156bd902eaec0b4e5f" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate rust_ofp 0.2.1 [INFO] finished tweaking crates.io crate rust_ofp 0.2.1 [INFO] tweaked toml for crates.io crate rust_ofp 0.2.1 written to /workspace/builds/worker-5/source/Cargo.toml [INFO] running `Command { std: "/workspace/cargo-home/bin/cargo" "+5a8a44196b3cf099f8c9b0156bd902eaec0b4e5f" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "/workspace/cargo-home/bin/cargo" "+5a8a44196b3cf099f8c9b0156bd902eaec0b4e5f" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:34b6a614d2c27851fe6cbf88fbd1137609cefab8b10d0615aaeb6fd47975d74e" "/opt/rustwide/cargo-home/bin/cargo" "+5a8a44196b3cf099f8c9b0156bd902eaec0b4e5f" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 34222417881a9e6112810666514387232941362c8de376463d069511bc0a53cc [INFO] running `Command { std: "docker" "start" "-a" "34222417881a9e6112810666514387232941362c8de376463d069511bc0a53cc", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "34222417881a9e6112810666514387232941362c8de376463d069511bc0a53cc", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "34222417881a9e6112810666514387232941362c8de376463d069511bc0a53cc", kill_on_drop: false }` [INFO] [stdout] 34222417881a9e6112810666514387232941362c8de376463d069511bc0a53cc [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:34b6a614d2c27851fe6cbf88fbd1137609cefab8b10d0615aaeb6fd47975d74e" "/opt/rustwide/cargo-home/bin/cargo" "+5a8a44196b3cf099f8c9b0156bd902eaec0b4e5f" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 8cfa465d05007b337ac948feb03395bf326bb975d524aa549cfea879d9139646 [INFO] running `Command { std: "docker" "start" "-a" "8cfa465d05007b337ac948feb03395bf326bb975d524aa549cfea879d9139646", kill_on_drop: false }` [INFO] [stderr] Checking byteorder v1.4.3 [INFO] [stderr] Checking rust_ofp v0.2.1 (/opt/rustwide/workdir) [INFO] [stdout] warning: anonymous parameters are deprecated and will be removed in the next edition. [INFO] [stdout] --> src/ofp_controller.rs:12:21 [INFO] [stdout] | [INFO] [stdout] 12 | fn send_message(u32, Self::Message, &mut TcpStream); [INFO] [stdout] | ^^^ help: try naming the parameter or explicitly ignoring it: `_: u32` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(anonymous_parameters)]` on by default [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2018! [INFO] [stdout] = note: for more information, see issue #41686 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: anonymous parameters are deprecated and will be removed in the next edition. [INFO] [stdout] --> src/ofp_controller.rs:12:26 [INFO] [stdout] | [INFO] [stdout] 12 | fn send_message(u32, Self::Message, &mut TcpStream); [INFO] [stdout] | ^^^^^^^^^^^^^ help: try naming the parameter or explicitly ignoring it: `_: Self::Message` [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2018! [INFO] [stdout] = note: for more information, see issue #41686 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: anonymous parameters are deprecated and will be removed in the next edition. [INFO] [stdout] --> src/ofp_controller.rs:12:41 [INFO] [stdout] | [INFO] [stdout] 12 | fn send_message(u32, Self::Message, &mut TcpStream); [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try naming the parameter or explicitly ignoring it: `_: &mut TcpStream` [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2018! [INFO] [stdout] = note: for more information, see issue #41686 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: anonymous parameters are deprecated and will be removed in the next edition. [INFO] [stdout] --> src/ofp_controller.rs:14:32 [INFO] [stdout] | [INFO] [stdout] 14 | fn handle_client_connected(&mut TcpStream); [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try naming the parameter or explicitly ignoring it: `_: &mut TcpStream` [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2018! [INFO] [stdout] = note: for more information, see issue #41686 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: anonymous parameters are deprecated and will be removed in the next edition. [INFO] [stdout] --> src/ofp_message.rs:8:16 [INFO] [stdout] | [INFO] [stdout] 8 | fn size_of(&Self) -> usize; [INFO] [stdout] | ^^^^^ help: try naming the parameter or explicitly ignoring it: `_: &Self` [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2018! [INFO] [stdout] = note: for more information, see issue #41686 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: anonymous parameters are deprecated and will be removed in the next edition. [INFO] [stdout] --> src/ofp_message.rs:10:18 [INFO] [stdout] | [INFO] [stdout] 10 | fn header_of(u32, &Self) -> OfpHeader; [INFO] [stdout] | ^^^ help: try naming the parameter or explicitly ignoring it: `_: u32` [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2018! [INFO] [stdout] = note: for more information, see issue #41686 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: anonymous parameters are deprecated and will be removed in the next edition. [INFO] [stdout] --> src/ofp_message.rs:10:23 [INFO] [stdout] | [INFO] [stdout] 10 | fn header_of(u32, &Self) -> OfpHeader; [INFO] [stdout] | ^^^^^ help: try naming the parameter or explicitly ignoring it: `_: &Self` [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2018! [INFO] [stdout] = note: for more information, see issue #41686 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: anonymous parameters are deprecated and will be removed in the next edition. [INFO] [stdout] --> src/ofp_message.rs:12:16 [INFO] [stdout] | [INFO] [stdout] 12 | fn marshal(u32, Self) -> Vec; [INFO] [stdout] | ^^^ help: try naming the parameter or explicitly ignoring it: `_: u32` [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2018! [INFO] [stdout] = note: for more information, see issue #41686 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: anonymous parameters are deprecated and will be removed in the next edition. [INFO] [stdout] --> src/ofp_message.rs:12:21 [INFO] [stdout] | [INFO] [stdout] 12 | fn marshal(u32, Self) -> Vec; [INFO] [stdout] | ^^^^ help: try naming the parameter or explicitly ignoring it: `_: Self` [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2018! [INFO] [stdout] = note: for more information, see issue #41686 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: anonymous parameters are deprecated and will be removed in the next edition. [INFO] [stdout] --> src/ofp_message.rs:15:14 [INFO] [stdout] | [INFO] [stdout] 15 | fn parse(&OfpHeader, &[u8]) -> (u32, Self); [INFO] [stdout] | ^^^^^^^^^^ help: try naming the parameter or explicitly ignoring it: `_: &OfpHeader` [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2018! [INFO] [stdout] = note: for more information, see issue #41686 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: anonymous parameters are deprecated and will be removed in the next edition. [INFO] [stdout] --> src/ofp_message.rs:15:26 [INFO] [stdout] | [INFO] [stdout] 15 | fn parse(&OfpHeader, &[u8]) -> (u32, Self); [INFO] [stdout] | ^^^^^ help: try naming the parameter or explicitly ignoring it: `_: &[u8]` [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2018! [INFO] [stdout] = note: for more information, see issue #41686 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: anonymous parameters are deprecated and will be removed in the next edition. [INFO] [stdout] --> src/openflow0x01.rs:40:16 [INFO] [stdout] | [INFO] [stdout] 40 | fn size_of(&Self) -> usize; [INFO] [stdout] | ^^^^^ help: try naming the parameter or explicitly ignoring it: `_: &Self` [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2018! [INFO] [stdout] = note: for more information, see issue #41686 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: anonymous parameters are deprecated and will be removed in the next edition. [INFO] [stdout] --> src/openflow0x01.rs:44:16 [INFO] [stdout] | [INFO] [stdout] 44 | fn marshal(Self, &mut Vec); [INFO] [stdout] | ^^^^ help: try naming the parameter or explicitly ignoring it: `_: Self` [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2018! [INFO] [stdout] = note: for more information, see issue #41686 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: anonymous parameters are deprecated and will be removed in the next edition. [INFO] [stdout] --> src/openflow0x01.rs:44:22 [INFO] [stdout] | [INFO] [stdout] 44 | fn marshal(Self, &mut Vec); [INFO] [stdout] | ^^^^^^^^^^^^ help: try naming the parameter or explicitly ignoring it: `_: &mut Vec` [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2018! [INFO] [stdout] = note: for more information, see issue #41686 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary trailing semicolon [INFO] [stdout] --> src/packet.rs:18:6 [INFO] [stdout] | [INFO] [stdout] 18 | }; [INFO] [stdout] | ^ help: remove this semicolon [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(redundant_semicolons)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: anonymous parameters are deprecated and will be removed in the next edition. [INFO] [stdout] --> src/ofp_controller.rs:12:21 [INFO] [stdout] | [INFO] [stdout] 12 | fn send_message(u32, Self::Message, &mut TcpStream); [INFO] [stdout] | ^^^ help: try naming the parameter or explicitly ignoring it: `_: u32` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(anonymous_parameters)]` on by default [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2018! [INFO] [stdout] = note: for more information, see issue #41686 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: anonymous parameters are deprecated and will be removed in the next edition. [INFO] [stdout] --> src/ofp_controller.rs:12:26 [INFO] [stdout] | [INFO] [stdout] 12 | fn send_message(u32, Self::Message, &mut TcpStream); [INFO] [stdout] | ^^^^^^^^^^^^^ help: try naming the parameter or explicitly ignoring it: `_: Self::Message` [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2018! [INFO] [stdout] = note: for more information, see issue #41686 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: anonymous parameters are deprecated and will be removed in the next edition. [INFO] [stdout] --> src/ofp_controller.rs:12:41 [INFO] [stdout] | [INFO] [stdout] 12 | fn send_message(u32, Self::Message, &mut TcpStream); [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try naming the parameter or explicitly ignoring it: `_: &mut TcpStream` [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2018! [INFO] [stdout] = note: for more information, see issue #41686 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: anonymous parameters are deprecated and will be removed in the next edition. [INFO] [stdout] --> src/ofp_controller.rs:14:32 [INFO] [stdout] | [INFO] [stdout] 14 | fn handle_client_connected(&mut TcpStream); [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try naming the parameter or explicitly ignoring it: `_: &mut TcpStream` [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2018! [INFO] [stdout] = note: for more information, see issue #41686 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: anonymous parameters are deprecated and will be removed in the next edition. [INFO] [stdout] --> src/ofp_message.rs:8:16 [INFO] [stdout] | [INFO] [stdout] 8 | fn size_of(&Self) -> usize; [INFO] [stdout] | ^^^^^ help: try naming the parameter or explicitly ignoring it: `_: &Self` [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2018! [INFO] [stdout] = note: for more information, see issue #41686 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: anonymous parameters are deprecated and will be removed in the next edition. [INFO] [stdout] --> src/ofp_message.rs:10:18 [INFO] [stdout] | [INFO] [stdout] 10 | fn header_of(u32, &Self) -> OfpHeader; [INFO] [stdout] | ^^^ help: try naming the parameter or explicitly ignoring it: `_: u32` [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2018! [INFO] [stdout] = note: for more information, see issue #41686 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: anonymous parameters are deprecated and will be removed in the next edition. [INFO] [stdout] --> src/ofp_message.rs:10:23 [INFO] [stdout] | [INFO] [stdout] 10 | fn header_of(u32, &Self) -> OfpHeader; [INFO] [stdout] | ^^^^^ help: try naming the parameter or explicitly ignoring it: `_: &Self` [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2018! [INFO] [stdout] = note: for more information, see issue #41686 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: anonymous parameters are deprecated and will be removed in the next edition. [INFO] [stdout] --> src/ofp_message.rs:12:16 [INFO] [stdout] | [INFO] [stdout] 12 | fn marshal(u32, Self) -> Vec; [INFO] [stdout] | ^^^ help: try naming the parameter or explicitly ignoring it: `_: u32` [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2018! [INFO] [stdout] = note: for more information, see issue #41686 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: anonymous parameters are deprecated and will be removed in the next edition. [INFO] [stdout] --> src/ofp_message.rs:12:21 [INFO] [stdout] | [INFO] [stdout] 12 | fn marshal(u32, Self) -> Vec; [INFO] [stdout] | ^^^^ help: try naming the parameter or explicitly ignoring it: `_: Self` [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2018! [INFO] [stdout] = note: for more information, see issue #41686 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: anonymous parameters are deprecated and will be removed in the next edition. [INFO] [stdout] --> src/ofp_message.rs:15:14 [INFO] [stdout] | [INFO] [stdout] 15 | fn parse(&OfpHeader, &[u8]) -> (u32, Self); [INFO] [stdout] | ^^^^^^^^^^ help: try naming the parameter or explicitly ignoring it: `_: &OfpHeader` [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2018! [INFO] [stdout] = note: for more information, see issue #41686 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: anonymous parameters are deprecated and will be removed in the next edition. [INFO] [stdout] --> src/ofp_message.rs:15:26 [INFO] [stdout] | [INFO] [stdout] 15 | fn parse(&OfpHeader, &[u8]) -> (u32, Self); [INFO] [stdout] | ^^^^^ help: try naming the parameter or explicitly ignoring it: `_: &[u8]` [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2018! [INFO] [stdout] = note: for more information, see issue #41686 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: anonymous parameters are deprecated and will be removed in the next edition. [INFO] [stdout] --> src/openflow0x01.rs:40:16 [INFO] [stdout] | [INFO] [stdout] 40 | fn size_of(&Self) -> usize; [INFO] [stdout] | ^^^^^ help: try naming the parameter or explicitly ignoring it: `_: &Self` [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2018! [INFO] [stdout] = note: for more information, see issue #41686 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: anonymous parameters are deprecated and will be removed in the next edition. [INFO] [stdout] --> src/openflow0x01.rs:44:16 [INFO] [stdout] | [INFO] [stdout] 44 | fn marshal(Self, &mut Vec); [INFO] [stdout] | ^^^^ help: try naming the parameter or explicitly ignoring it: `_: Self` [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2018! [INFO] [stdout] = note: for more information, see issue #41686 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: anonymous parameters are deprecated and will be removed in the next edition. [INFO] [stdout] --> src/openflow0x01.rs:44:22 [INFO] [stdout] | [INFO] [stdout] 44 | fn marshal(Self, &mut Vec); [INFO] [stdout] | ^^^^^^^^^^^^ help: try naming the parameter or explicitly ignoring it: `_: &mut Vec` [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2018! [INFO] [stdout] = note: for more information, see issue #41686 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary trailing semicolon [INFO] [stdout] --> src/packet.rs:18:6 [INFO] [stdout] | [INFO] [stdout] 18 | }; [INFO] [stdout] | ^ help: remove this semicolon [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(redundant_semicolons)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 15 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 15 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.19s [INFO] running `Command { std: "docker" "inspect" "8cfa465d05007b337ac948feb03395bf326bb975d524aa549cfea879d9139646", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "8cfa465d05007b337ac948feb03395bf326bb975d524aa549cfea879d9139646", kill_on_drop: false }` [INFO] [stdout] 8cfa465d05007b337ac948feb03395bf326bb975d524aa549cfea879d9139646