[INFO] cloning repository https://github.com/qalens/kata-stringcalculator [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/qalens/kata-stringcalculator" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fqalens%2Fkata-stringcalculator", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fqalens%2Fkata-stringcalculator'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 7c8c06e08a003ed4ed6a2c3eda4a44640c5ff206 [INFO] checking qalens/kata-stringcalculator against master#5a8a44196b3cf099f8c9b0156bd902eaec0b4e5f for pr-87248 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fqalens%2Fkata-stringcalculator" "/workspace/builds/worker-14/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-14/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/qalens/kata-stringcalculator on toolchain 5a8a44196b3cf099f8c9b0156bd902eaec0b4e5f [INFO] running `Command { std: "/workspace/cargo-home/bin/cargo" "+5a8a44196b3cf099f8c9b0156bd902eaec0b4e5f" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/qalens/kata-stringcalculator [INFO] finished tweaking git repo https://github.com/qalens/kata-stringcalculator [INFO] tweaked toml for git repo https://github.com/qalens/kata-stringcalculator written to /workspace/builds/worker-14/source/Cargo.toml [INFO] crate git repo https://github.com/qalens/kata-stringcalculator already has a lockfile, it will not be regenerated [INFO] running `Command { std: "/workspace/cargo-home/bin/cargo" "+5a8a44196b3cf099f8c9b0156bd902eaec0b4e5f" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-14/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-14/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:34b6a614d2c27851fe6cbf88fbd1137609cefab8b10d0615aaeb6fd47975d74e" "/opt/rustwide/cargo-home/bin/cargo" "+5a8a44196b3cf099f8c9b0156bd902eaec0b4e5f" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 384991e21fa3c52472570c12d6710879a07be39f3faf76efb1a2c95123a6fc62 [INFO] running `Command { std: "docker" "start" "-a" "384991e21fa3c52472570c12d6710879a07be39f3faf76efb1a2c95123a6fc62", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "384991e21fa3c52472570c12d6710879a07be39f3faf76efb1a2c95123a6fc62", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "384991e21fa3c52472570c12d6710879a07be39f3faf76efb1a2c95123a6fc62", kill_on_drop: false }` [INFO] [stdout] 384991e21fa3c52472570c12d6710879a07be39f3faf76efb1a2c95123a6fc62 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-14/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-14/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:34b6a614d2c27851fe6cbf88fbd1137609cefab8b10d0615aaeb6fd47975d74e" "/opt/rustwide/cargo-home/bin/cargo" "+5a8a44196b3cf099f8c9b0156bd902eaec0b4e5f" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 03a7045aa876fb1b6f2bbdf71ed59d3399a1efc4e959cd58301c49a0c9fb7c6f [INFO] running `Command { std: "docker" "start" "-a" "03a7045aa876fb1b6f2bbdf71ed59d3399a1efc4e959cd58301c49a0c9fb7c6f", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Checking stringcalculator v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/stringcalc.rs:11:11 [INFO] [stdout] | [INFO] [stdout] 11 | if(line.starts_with("//") && index == 0){ [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/stringcalc.rs:26:15 [INFO] [stdout] | [INFO] [stdout] 26 | if(val.starts_with('-')){ [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/stringcalc.rs:36:7 [INFO] [stdout] | [INFO] [stdout] 36 | if(!negatives.is_empty()){ [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/stringcalc.rs:11:11 [INFO] [stdout] | [INFO] [stdout] 11 | if(line.starts_with("//") && index == 0){ [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/stringcalc.rs:26:15 [INFO] [stdout] | [INFO] [stdout] 26 | if(val.starts_with('-')){ [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/stringcalc.rs:36:7 [INFO] [stdout] | [INFO] [stdout] 36 | if(!negatives.is_empty()){ [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/stringcalc.rs:3:9 [INFO] [stdout] | [INFO] [stdout] 3 | let mut x = numbers.clone(); [INFO] [stdout] | ----^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/stringcalc.rs:5:9 [INFO] [stdout] | [INFO] [stdout] 5 | let mut split=x.split('\n'); [INFO] [stdout] | ----^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function is never used: `add` [INFO] [stdout] --> src/stringcalc.rs:1:8 [INFO] [stdout] | [INFO] [stdout] 1 | pub fn add(numbers: & str) -> usize{ [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: panic message is not a string literal [INFO] [stdout] --> src/stringcalc.rs:37:16 [INFO] [stdout] | [INFO] [stdout] 37 | panic!(format!("negatives not allowed {0}",negatives.join(" "))); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_fmt_panics)]` on by default [INFO] [stdout] = note: this usage of panic!() is deprecated; it will be a hard error in Rust 2021 [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: the panic!() macro supports formatting, so there's no need for the format!() macro here [INFO] [stdout] help: remove the `format!(..)` macro call [INFO] [stdout] | [INFO] [stdout] 37 | panic!("negatives not allowed {0}",negatives.join(" ")); [INFO] [stdout] | -- -- [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/stringcalc.rs:3:9 [INFO] [stdout] | [INFO] [stdout] 3 | let mut x = numbers.clone(); [INFO] [stdout] | ----^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/stringcalc.rs:5:9 [INFO] [stdout] | [INFO] [stdout] 5 | let mut split=x.split('\n'); [INFO] [stdout] | ----^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 7 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: panic message is not a string literal [INFO] [stdout] --> src/stringcalc.rs:37:16 [INFO] [stdout] | [INFO] [stdout] 37 | panic!(format!("negatives not allowed {0}",negatives.join(" "))); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_fmt_panics)]` on by default [INFO] [stdout] = note: this usage of panic!() is deprecated; it will be a hard error in Rust 2021 [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: the panic!() macro supports formatting, so there's no need for the format!() macro here [INFO] [stdout] help: remove the `format!(..)` macro call [INFO] [stdout] | [INFO] [stdout] 37 | panic!("negatives not allowed {0}",negatives.join(" ")); [INFO] [stdout] | -- -- [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.40s [INFO] [stdout] warning: 6 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] running `Command { std: "docker" "inspect" "03a7045aa876fb1b6f2bbdf71ed59d3399a1efc4e959cd58301c49a0c9fb7c6f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "03a7045aa876fb1b6f2bbdf71ed59d3399a1efc4e959cd58301c49a0c9fb7c6f", kill_on_drop: false }` [INFO] [stdout] 03a7045aa876fb1b6f2bbdf71ed59d3399a1efc4e959cd58301c49a0c9fb7c6f