[INFO] fetching crate helixiser 0.4.2... [INFO] checking helixiser-0.4.2 against try#a7a572ce3edd6d476191fbfe92c9c1986e009b34 for pr-87190-3 [INFO] extracting crate helixiser 0.4.2 into /workspace/builds/worker-57/source [INFO] validating manifest of crates.io crate helixiser 0.4.2 on toolchain a7a572ce3edd6d476191fbfe92c9c1986e009b34 [INFO] running `Command { std: "/workspace/cargo-home/bin/cargo" "+a7a572ce3edd6d476191fbfe92c9c1986e009b34" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate helixiser 0.4.2 [INFO] finished tweaking crates.io crate helixiser 0.4.2 [INFO] tweaked toml for crates.io crate helixiser 0.4.2 written to /workspace/builds/worker-57/source/Cargo.toml [INFO] crate crates.io crate helixiser 0.4.2 already has a lockfile, it will not be regenerated [INFO] running `Command { std: "/workspace/cargo-home/bin/cargo" "+a7a572ce3edd6d476191fbfe92c9c1986e009b34" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded memoffset v0.5.5 [INFO] [stderr] Downloaded color_quant v1.0.1 [INFO] [stderr] Downloaded rayon-core v1.8.0 [INFO] [stderr] Downloaded bytemuck v1.4.0 [INFO] [stderr] Downloaded transpose v0.1.0 [INFO] [stderr] Downloaded rustfft v3.0.1 [INFO] [stderr] Downloaded rayon v1.4.0 [INFO] [stderr] Downloaded image v0.23.9 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-57/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-57/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:34b6a614d2c27851fe6cbf88fbd1137609cefab8b10d0615aaeb6fd47975d74e" "/opt/rustwide/cargo-home/bin/cargo" "+a7a572ce3edd6d476191fbfe92c9c1986e009b34" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 716b9081979170e4af5b5168ee7991d00321b2710d0e4c0f20f6981b518d0af7 [INFO] running `Command { std: "docker" "start" "-a" "716b9081979170e4af5b5168ee7991d00321b2710d0e4c0f20f6981b518d0af7", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "716b9081979170e4af5b5168ee7991d00321b2710d0e4c0f20f6981b518d0af7", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "716b9081979170e4af5b5168ee7991d00321b2710d0e4c0f20f6981b518d0af7", kill_on_drop: false }` [INFO] [stdout] 716b9081979170e4af5b5168ee7991d00321b2710d0e4c0f20f6981b518d0af7 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-57/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-57/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:34b6a614d2c27851fe6cbf88fbd1137609cefab8b10d0615aaeb6fd47975d74e" "/opt/rustwide/cargo-home/bin/cargo" "+a7a572ce3edd6d476191fbfe92c9c1986e009b34" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] c95b3db4e70dfbabf171cbf979f10a014fc57ea04ade77f571b5294bd3479bae [INFO] running `Command { std: "docker" "start" "-a" "c95b3db4e70dfbabf171cbf979f10a014fc57ea04ade77f571b5294bd3479bae", kill_on_drop: false }` [INFO] [stderr] Copying to /tmp/fixit [INFO] [stderr] Running `cargo fix --edition` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Compiling autocfg v1.0.1 [INFO] [stderr] Checking cfg-if v0.1.10 [INFO] [stderr] Checking lazy_static v1.4.0 [INFO] [stderr] Compiling libc v0.2.76 [INFO] [stderr] Compiling byteorder v1.3.4 [INFO] [stderr] Checking scopeguard v1.1.0 [INFO] [stderr] Compiling rayon-core v1.8.0 [INFO] [stderr] Checking adler32 v1.2.0 [INFO] [stderr] Compiling bitflags v1.2.1 [INFO] [stderr] Checking either v1.6.0 [INFO] [stderr] Checking lzw v0.10.0 [INFO] [stderr] Compiling ndarray v0.13.1 [INFO] [stderr] Checking rawpointer v0.2.1 [INFO] [stderr] Checking color_quant v1.0.1 [INFO] [stderr] Checking transpose v0.1.0 [INFO] [stderr] Checking bytemuck v1.4.0 [INFO] [stderr] Checking strength_reduce v0.2.3 [INFO] [stderr] Checking scoped_threadpool v0.1.9 [INFO] [stderr] Checking open v1.4.0 [INFO] [stderr] Checking assert_approx_eq v1.1.0 [INFO] [stderr] Checking crc32fast v1.2.0 [INFO] [stderr] Checking miniz_oxide v0.3.7 [INFO] [stderr] Checking matrixmultiply v0.2.3 [INFO] [stderr] Checking gif v0.10.3 [INFO] [stderr] Compiling num-traits v0.2.12 [INFO] [stderr] Compiling num-integer v0.1.43 [INFO] [stderr] Compiling crossbeam-utils v0.7.2 [INFO] [stderr] Compiling memoffset v0.5.5 [INFO] [stderr] Compiling crossbeam-epoch v0.8.2 [INFO] [stderr] Compiling num-bigint v0.3.0 [INFO] [stderr] Compiling num-rational v0.3.0 [INFO] [stderr] Compiling rayon v1.4.0 [INFO] [stderr] Compiling num-complex v0.2.4 [INFO] [stderr] Compiling num-iter v0.1.41 [INFO] [stderr] Checking deflate v0.8.6 [INFO] [stderr] Checking tiff v0.5.0 [INFO] [stderr] Checking png v0.16.7 [INFO] [stderr] Checking crossbeam-channel v0.4.4 [INFO] [stderr] Checking num-complex v0.3.0 [INFO] [stderr] Checking num_cpus v1.13.0 [INFO] [stderr] Checking crossbeam-deque v0.7.3 [INFO] [stderr] Checking rustfft v3.0.1 [INFO] [stderr] Checking num v0.3.0 [INFO] [stderr] Checking jpeg-decoder v0.1.20 [INFO] [stderr] Checking image v0.23.9 [INFO] [stderr] Checking helixiser v0.4.2 (/tmp/fixit) [INFO] [stderr] Migrating src/lib.rs from 2018 edition to 2021 [INFO] [stderr] Fixed src/diffraction_simulator.rs (4 fixes) [INFO] [stderr] Fixed src/fft_2D.rs (4 fixes) [INFO] [stderr] Fixed src/utilities.rs (2 fixes) [INFO] [stderr] Fixed src/diffraction_analytic.rs (2 fixes) [INFO] [stdout] warning: value assigned to `val` is never read [INFO] [stdout] --> src/diffraction_simulator.rs:63:17 [INFO] [stdout] | [INFO] [stdout] 63 | let mut val:f64 = 0.; [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_assignments)]` on by default [INFO] [stdout] = help: maybe it is overwritten before being read? [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: module `fft_2D` should have a snake case name [INFO] [stdout] --> src/lib.rs:13:9 [INFO] [stdout] | [INFO] [stdout] 13 | pub mod fft_2D; [INFO] [stdout] | ^^^^^^ help: convert the identifier to snake case: `fft_2_d` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_snake_case)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `J0` should have a snake case name [INFO] [stdout] --> src/bessel_utils.rs:16:8 [INFO] [stdout] | [INFO] [stdout] 16 | pub fn J0(x: f64) -> f64 { [INFO] [stdout] | ^^ help: convert the identifier to snake case: `j0` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `J1` should have a snake case name [INFO] [stdout] --> src/bessel_utils.rs:32:8 [INFO] [stdout] | [INFO] [stdout] 32 | pub fn J1(x: f64) -> f64 { [INFO] [stdout] | ^^ help: convert the identifier to snake case: `j1` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `J0a` should have a snake case name [INFO] [stdout] --> src/bessel_utils.rs:48:8 [INFO] [stdout] | [INFO] [stdout] 48 | pub fn J0a(x: f64) -> f64 { [INFO] [stdout] | ^^^ help: convert the identifier to snake case: `j0a` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `J0b` should have a snake case name [INFO] [stdout] --> src/bessel_utils.rs:59:8 [INFO] [stdout] | [INFO] [stdout] 59 | pub fn J0b(x: f64) -> f64 { [INFO] [stdout] | ^^^ help: convert the identifier to snake case: `j0b` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `J1a` should have a snake case name [INFO] [stdout] --> src/bessel_utils.rs:65:8 [INFO] [stdout] | [INFO] [stdout] 65 | pub fn J1a(x: f64) -> f64 { [INFO] [stdout] | ^^^ help: convert the identifier to snake case: `j1a` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `J1b` should have a snake case name [INFO] [stdout] --> src/bessel_utils.rs:74:8 [INFO] [stdout] | [INFO] [stdout] 74 | pub fn J1b(x: f64) -> f64 { [INFO] [stdout] | ^^^ help: convert the identifier to snake case: `j1b` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `nextBessel` should have a snake case name [INFO] [stdout] --> src/bessel_utils.rs:86:8 [INFO] [stdout] | [INFO] [stdout] 86 | pub fn nextBessel(n: u64, x: f64, Jn_minus_one: f64, Jn_minus_two: f64) -> f64 { [INFO] [stdout] | ^^^^^^^^^^ help: convert the identifier to snake case: `next_bessel` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `Jn_minus_one` should have a snake case name [INFO] [stdout] --> src/bessel_utils.rs:86:35 [INFO] [stdout] | [INFO] [stdout] 86 | pub fn nextBessel(n: u64, x: f64, Jn_minus_one: f64, Jn_minus_two: f64) -> f64 { [INFO] [stdout] | ^^^^^^^^^^^^ help: convert the identifier to snake case: `jn_minus_one` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `Jn_minus_two` should have a snake case name [INFO] [stdout] --> src/bessel_utils.rs:86:54 [INFO] [stdout] | [INFO] [stdout] 86 | pub fn nextBessel(n: u64, x: f64, Jn_minus_one: f64, Jn_minus_two: f64) -> f64 { [INFO] [stdout] | ^^^^^^^^^^^^ help: convert the identifier to snake case: `jn_minus_two` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `Jn` should have a snake case name [INFO] [stdout] --> src/bessel_utils.rs:127:8 [INFO] [stdout] | [INFO] [stdout] 127 | pub fn Jn(n: u64, x: f64) -> f64 { [INFO] [stdout] | ^^ help: convert the identifier to snake case: `jn` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `Ufac` should have a snake case name [INFO] [stdout] --> src/diffraction_analytic.rs:63:13 [INFO] [stdout] | [INFO] [stdout] 63 | let mut Ufac: Array1 = Array::zeros(raster_size as usize); [INFO] [stdout] | ^^^^ help: convert the identifier to snake case (notice the capitalization): `ufac` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `FFT_1D` should have a snake case name [INFO] [stdout] --> src/fft_2D.rs:18:4 [INFO] [stdout] | [INFO] [stdout] 18 | fn FFT_1D(mut slice: ArrayViewMut1, length: usize){ [INFO] [stdout] | ^^^^^^ help: convert the identifier to snake case: `fft_1_d` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `FFT_2D` should have a snake case name [INFO] [stdout] --> src/fft_2D.rs:30:8 [INFO] [stdout] | [INFO] [stdout] 30 | pub fn FFT_2D(mut image: Array2) -> Array2{ [INFO] [stdout] | ^^^^^^ help: convert the identifier to snake case: `fft_2_d` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `FFTshift` should have a snake case name [INFO] [stdout] --> src/fft_2D.rs:53:4 [INFO] [stdout] | [INFO] [stdout] 53 | fn FFTshift(image: &mut Array2){ [INFO] [stdout] | ^^^^^^^^ help: convert the identifier to snake case: `fftshift` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison is useless due to type limits [INFO] [stdout] --> src/diffraction_simulator.rs:60:8 [INFO] [stdout] | [INFO] [stdout] 60 | if (x >= 0) && (x < image.ncols()) && [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_comparisons)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison is useless due to type limits [INFO] [stdout] --> src/diffraction_simulator.rs:61:9 [INFO] [stdout] | [INFO] [stdout] 61 | (z >= 0) && (z < image.nrows()) { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison is useless due to type limits [INFO] [stdout] --> src/diffraction_simulator.rs:84:8 [INFO] [stdout] | [INFO] [stdout] 84 | if (x >= 0) && (x < image.ncols()) && [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison is useless due to type limits [INFO] [stdout] --> src/diffraction_simulator.rs:85:9 [INFO] [stdout] | [INFO] [stdout] 85 | (z >= 0) && (z < image.nrows()) { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 20 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Migrating src/main.rs from 2018 edition to 2021 [INFO] [stdout] warning: value assigned to `val` is never read [INFO] [stdout] --> src/diffraction_simulator.rs:63:17 [INFO] [stdout] | [INFO] [stdout] 63 | let mut val:f64 = 0.; [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_assignments)]` on by default [INFO] [stdout] = help: maybe it is overwritten before being read? [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: module `fft_2D` should have a snake case name [INFO] [stdout] --> src/lib.rs:13:9 [INFO] [stdout] | [INFO] [stdout] 13 | pub mod fft_2D; [INFO] [stdout] | ^^^^^^ help: convert the identifier to snake case: `fft_2_d` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_snake_case)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `J0` should have a snake case name [INFO] [stdout] --> src/bessel_utils.rs:16:8 [INFO] [stdout] | [INFO] [stdout] 16 | pub fn J0(x: f64) -> f64 { [INFO] [stdout] | ^^ help: convert the identifier to snake case: `j0` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `J1` should have a snake case name [INFO] [stdout] --> src/bessel_utils.rs:32:8 [INFO] [stdout] | [INFO] [stdout] 32 | pub fn J1(x: f64) -> f64 { [INFO] [stdout] | ^^ help: convert the identifier to snake case: `j1` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `J0a` should have a snake case name [INFO] [stdout] --> src/bessel_utils.rs:48:8 [INFO] [stdout] | [INFO] [stdout] 48 | pub fn J0a(x: f64) -> f64 { [INFO] [stdout] | ^^^ help: convert the identifier to snake case: `j0a` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `J0b` should have a snake case name [INFO] [stdout] --> src/bessel_utils.rs:59:8 [INFO] [stdout] | [INFO] [stdout] 59 | pub fn J0b(x: f64) -> f64 { [INFO] [stdout] | ^^^ help: convert the identifier to snake case: `j0b` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `J1a` should have a snake case name [INFO] [stdout] --> src/bessel_utils.rs:65:8 [INFO] [stdout] | [INFO] [stdout] 65 | pub fn J1a(x: f64) -> f64 { [INFO] [stdout] | ^^^ help: convert the identifier to snake case: `j1a` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `J1b` should have a snake case name [INFO] [stdout] --> src/bessel_utils.rs:74:8 [INFO] [stdout] | [INFO] [stdout] 74 | pub fn J1b(x: f64) -> f64 { [INFO] [stdout] | ^^^ help: convert the identifier to snake case: `j1b` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `nextBessel` should have a snake case name [INFO] [stdout] --> src/bessel_utils.rs:86:8 [INFO] [stdout] | [INFO] [stdout] 86 | pub fn nextBessel(n: u64, x: f64, Jn_minus_one: f64, Jn_minus_two: f64) -> f64 { [INFO] [stdout] | ^^^^^^^^^^ help: convert the identifier to snake case: `next_bessel` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `Jn_minus_one` should have a snake case name [INFO] [stdout] --> src/bessel_utils.rs:86:35 [INFO] [stdout] | [INFO] [stdout] 86 | pub fn nextBessel(n: u64, x: f64, Jn_minus_one: f64, Jn_minus_two: f64) -> f64 { [INFO] [stdout] | ^^^^^^^^^^^^ help: convert the identifier to snake case: `jn_minus_one` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `Jn_minus_two` should have a snake case name [INFO] [stdout] --> src/bessel_utils.rs:86:54 [INFO] [stdout] | [INFO] [stdout] 86 | pub fn nextBessel(n: u64, x: f64, Jn_minus_one: f64, Jn_minus_two: f64) -> f64 { [INFO] [stdout] | ^^^^^^^^^^^^ help: convert the identifier to snake case: `jn_minus_two` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `Jn` should have a snake case name [INFO] [stdout] --> src/bessel_utils.rs:127:8 [INFO] [stdout] | [INFO] [stdout] 127 | pub fn Jn(n: u64, x: f64) -> f64 { [INFO] [stdout] | ^^ help: convert the identifier to snake case: `jn` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `Ufac` should have a snake case name [INFO] [stdout] --> src/diffraction_analytic.rs:63:13 [INFO] [stdout] | [INFO] [stdout] 63 | let mut Ufac: Array1 = Array::zeros(raster_size as usize); [INFO] [stdout] | ^^^^ help: convert the identifier to snake case (notice the capitalization): `ufac` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `FFT_1D` should have a snake case name [INFO] [stdout] --> src/fft_2D.rs:18:4 [INFO] [stdout] | [INFO] [stdout] 18 | fn FFT_1D(mut slice: ArrayViewMut1, length: usize){ [INFO] [stdout] | ^^^^^^ help: convert the identifier to snake case: `fft_1_d` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `FFT_2D` should have a snake case name [INFO] [stdout] --> src/fft_2D.rs:30:8 [INFO] [stdout] | [INFO] [stdout] 30 | pub fn FFT_2D(mut image: Array2) -> Array2{ [INFO] [stdout] | ^^^^^^ help: convert the identifier to snake case: `fft_2_d` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `FFTshift` should have a snake case name [INFO] [stdout] --> src/fft_2D.rs:53:4 [INFO] [stdout] | [INFO] [stdout] 53 | fn FFTshift(image: &mut Array2){ [INFO] [stdout] | ^^^^^^^^ help: convert the identifier to snake case: `fftshift` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison is useless due to type limits [INFO] [stdout] --> src/diffraction_simulator.rs:60:8 [INFO] [stdout] | [INFO] [stdout] 60 | if (x >= 0) && (x < image.ncols()) && [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_comparisons)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison is useless due to type limits [INFO] [stdout] --> src/diffraction_simulator.rs:61:9 [INFO] [stdout] | [INFO] [stdout] 61 | (z >= 0) && (z < image.nrows()) { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison is useless due to type limits [INFO] [stdout] --> src/diffraction_simulator.rs:84:8 [INFO] [stdout] | [INFO] [stdout] 84 | if (x >= 0) && (x < image.ncols()) && [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison is useless due to type limits [INFO] [stdout] --> src/diffraction_simulator.rs:85:9 [INFO] [stdout] | [INFO] [stdout] 85 | (z >= 0) && (z < image.nrows()) { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 20 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Fixed src/main.rs (11 fixes) [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 21.53s [INFO] [stderr] Running `cargo check` to verify 2021 [INFO] [stderr] Checking helixiser v0.4.2 (/tmp/fixit) [INFO] [stdout] warning: value assigned to `val` is never read [INFO] [stdout] --> src/diffraction_simulator.rs:63:17 [INFO] [stdout] | [INFO] [stdout] 63 | let mut val:f64 = 0.; [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_assignments)]` on by default [INFO] [stdout] = help: maybe it is overwritten before being read? [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: value assigned to `val` is never read [INFO] [stdout] --> src/diffraction_simulator.rs:63:17 [INFO] [stdout] | [INFO] [stdout] 63 | let mut val:f64 = 0.; [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_assignments)]` on by default [INFO] [stdout] = help: maybe it is overwritten before being read? [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: module `fft_2D` should have a snake case name [INFO] [stdout] --> src/lib.rs:13:9 [INFO] [stdout] | [INFO] [stdout] 13 | pub mod fft_2D; [INFO] [stdout] | ^^^^^^ help: convert the identifier to snake case: `fft_2_d` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_snake_case)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `J0` should have a snake case name [INFO] [stdout] --> src/bessel_utils.rs:16:8 [INFO] [stdout] | [INFO] [stdout] 16 | pub fn J0(x: f64) -> f64 { [INFO] [stdout] | ^^ help: convert the identifier to snake case: `j0` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `J1` should have a snake case name [INFO] [stdout] --> src/bessel_utils.rs:32:8 [INFO] [stdout] | [INFO] [stdout] 32 | pub fn J1(x: f64) -> f64 { [INFO] [stdout] | ^^ help: convert the identifier to snake case: `j1` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `J0a` should have a snake case name [INFO] [stdout] --> src/bessel_utils.rs:48:8 [INFO] [stdout] | [INFO] [stdout] 48 | pub fn J0a(x: f64) -> f64 { [INFO] [stdout] | ^^^ help: convert the identifier to snake case: `j0a` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `J0b` should have a snake case name [INFO] [stdout] --> src/bessel_utils.rs:59:8 [INFO] [stdout] | [INFO] [stdout] 59 | pub fn J0b(x: f64) -> f64 { [INFO] [stdout] | ^^^ help: convert the identifier to snake case: `j0b` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `J1a` should have a snake case name [INFO] [stdout] --> src/bessel_utils.rs:65:8 [INFO] [stdout] | [INFO] [stdout] 65 | pub fn J1a(x: f64) -> f64 { [INFO] [stdout] | ^^^ help: convert the identifier to snake case: `j1a` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `J1b` should have a snake case name [INFO] [stdout] --> src/bessel_utils.rs:74:8 [INFO] [stdout] | [INFO] [stdout] 74 | pub fn J1b(x: f64) -> f64 { [INFO] [stdout] | ^^^ help: convert the identifier to snake case: `j1b` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `nextBessel` should have a snake case name [INFO] [stdout] --> src/bessel_utils.rs:86:8 [INFO] [stdout] | [INFO] [stdout] 86 | pub fn nextBessel(n: u64, x: f64, Jn_minus_one: f64, Jn_minus_two: f64) -> f64 { [INFO] [stdout] | ^^^^^^^^^^ help: convert the identifier to snake case: `next_bessel` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `Jn_minus_one` should have a snake case name [INFO] [stdout] --> src/bessel_utils.rs:86:35 [INFO] [stdout] | [INFO] [stdout] 86 | pub fn nextBessel(n: u64, x: f64, Jn_minus_one: f64, Jn_minus_two: f64) -> f64 { [INFO] [stdout] | ^^^^^^^^^^^^ help: convert the identifier to snake case: `jn_minus_one` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `Jn_minus_two` should have a snake case name [INFO] [stdout] --> src/bessel_utils.rs:86:54 [INFO] [stdout] | [INFO] [stdout] 86 | pub fn nextBessel(n: u64, x: f64, Jn_minus_one: f64, Jn_minus_two: f64) -> f64 { [INFO] [stdout] | ^^^^^^^^^^^^ help: convert the identifier to snake case: `jn_minus_two` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `Jn` should have a snake case name [INFO] [stdout] --> src/bessel_utils.rs:127:8 [INFO] [stdout] | [INFO] [stdout] 127 | pub fn Jn(n: u64, x: f64) -> f64 { [INFO] [stdout] | ^^ help: convert the identifier to snake case: `jn` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `Ufac` should have a snake case name [INFO] [stdout] --> src/diffraction_analytic.rs:63:13 [INFO] [stdout] | [INFO] [stdout] 63 | let mut Ufac: Array1 = Array::zeros(raster_size as usize); [INFO] [stdout] | ^^^^ help: convert the identifier to snake case (notice the capitalization): `ufac` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `FFT_1D` should have a snake case name [INFO] [stdout] --> src/fft_2D.rs:18:4 [INFO] [stdout] | [INFO] [stdout] 18 | fn FFT_1D(mut slice: ArrayViewMut1, length: usize){ [INFO] [stdout] | ^^^^^^ help: convert the identifier to snake case: `fft_1_d` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `FFT_2D` should have a snake case name [INFO] [stdout] --> src/fft_2D.rs:30:8 [INFO] [stdout] | [INFO] [stdout] 30 | pub fn FFT_2D(mut image: Array2) -> Array2{ [INFO] [stdout] | ^^^^^^ help: convert the identifier to snake case: `fft_2_d` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `FFTshift` should have a snake case name [INFO] [stdout] --> src/fft_2D.rs:53:4 [INFO] [stdout] | [INFO] [stdout] 53 | fn FFTshift(image: &mut Array2){ [INFO] [stdout] | ^^^^^^^^ help: convert the identifier to snake case: `fftshift` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison is useless due to type limits [INFO] [stdout] --> src/diffraction_simulator.rs:60:8 [INFO] [stdout] | [INFO] [stdout] 60 | if (x >= 0) && (x < image.ncols()) && [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_comparisons)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison is useless due to type limits [INFO] [stdout] --> src/diffraction_simulator.rs:61:9 [INFO] [stdout] | [INFO] [stdout] 61 | (z >= 0) && (z < image.nrows()) { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison is useless due to type limits [INFO] [stdout] --> src/diffraction_simulator.rs:84:8 [INFO] [stdout] | [INFO] [stdout] 84 | if (x >= 0) && (x < image.ncols()) && [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison is useless due to type limits [INFO] [stdout] --> src/diffraction_simulator.rs:85:9 [INFO] [stdout] | [INFO] [stdout] 85 | (z >= 0) && (z < image.nrows()) { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: module `fft_2D` should have a snake case name [INFO] [stdout] --> src/lib.rs:13:9 [INFO] [stdout] | [INFO] [stdout] 13 | pub mod fft_2D; [INFO] [stdout] | ^^^^^^ help: convert the identifier to snake case: `fft_2_d` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_snake_case)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `J0` should have a snake case name [INFO] [stdout] --> src/bessel_utils.rs:16:8 [INFO] [stdout] | [INFO] [stdout] 16 | pub fn J0(x: f64) -> f64 { [INFO] [stdout] | ^^ help: convert the identifier to snake case: `j0` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `J1` should have a snake case name [INFO] [stdout] --> src/bessel_utils.rs:32:8 [INFO] [stdout] | [INFO] [stdout] 32 | pub fn J1(x: f64) -> f64 { [INFO] [stdout] | ^^ help: convert the identifier to snake case: `j1` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `J0a` should have a snake case name [INFO] [stdout] --> src/bessel_utils.rs:48:8 [INFO] [stdout] | [INFO] [stdout] 48 | pub fn J0a(x: f64) -> f64 { [INFO] [stdout] | ^^^ help: convert the identifier to snake case: `j0a` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `J0b` should have a snake case name [INFO] [stdout] --> src/bessel_utils.rs:59:8 [INFO] [stdout] | [INFO] [stdout] 59 | pub fn J0b(x: f64) -> f64 { [INFO] [stdout] | ^^^ help: convert the identifier to snake case: `j0b` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `J1a` should have a snake case name [INFO] [stdout] --> src/bessel_utils.rs:65:8 [INFO] [stdout] | [INFO] [stdout] 65 | pub fn J1a(x: f64) -> f64 { [INFO] [stdout] | ^^^ help: convert the identifier to snake case: `j1a` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `J1b` should have a snake case name [INFO] [stdout] --> src/bessel_utils.rs:74:8 [INFO] [stdout] | [INFO] [stdout] 74 | pub fn J1b(x: f64) -> f64 { [INFO] [stdout] | ^^^ help: convert the identifier to snake case: `j1b` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `nextBessel` should have a snake case name [INFO] [stdout] --> src/bessel_utils.rs:86:8 [INFO] [stdout] | [INFO] [stdout] 86 | pub fn nextBessel(n: u64, x: f64, Jn_minus_one: f64, Jn_minus_two: f64) -> f64 { [INFO] [stdout] | ^^^^^^^^^^ help: convert the identifier to snake case: `next_bessel` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `Jn_minus_one` should have a snake case name [INFO] [stdout] --> src/bessel_utils.rs:86:35 [INFO] [stdout] | [INFO] [stdout] 86 | pub fn nextBessel(n: u64, x: f64, Jn_minus_one: f64, Jn_minus_two: f64) -> f64 { [INFO] [stdout] | ^^^^^^^^^^^^ help: convert the identifier to snake case: `jn_minus_one` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `Jn_minus_two` should have a snake case name [INFO] [stdout] --> src/bessel_utils.rs:86:54 [INFO] [stdout] | [INFO] [stdout] 86 | pub fn nextBessel(n: u64, x: f64, Jn_minus_one: f64, Jn_minus_two: f64) -> f64 { [INFO] [stdout] | ^^^^^^^^^^^^ help: convert the identifier to snake case: `jn_minus_two` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `Jn` should have a snake case name [INFO] [stdout] --> src/bessel_utils.rs:127:8 [INFO] [stdout] | [INFO] [stdout] 127 | pub fn Jn(n: u64, x: f64) -> f64 { [INFO] [stdout] | ^^ help: convert the identifier to snake case: `jn` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `Ufac` should have a snake case name [INFO] [stdout] --> src/diffraction_analytic.rs:63:13 [INFO] [stdout] | [INFO] [stdout] 63 | let mut Ufac: Array1 = Array::zeros(raster_size as usize); [INFO] [stdout] | ^^^^ help: convert the identifier to snake case (notice the capitalization): `ufac` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `FFT_1D` should have a snake case name [INFO] [stdout] --> src/fft_2D.rs:18:4 [INFO] [stdout] | [INFO] [stdout] 18 | fn FFT_1D(mut slice: ArrayViewMut1, length: usize){ [INFO] [stdout] | ^^^^^^ help: convert the identifier to snake case: `fft_1_d` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `FFT_2D` should have a snake case name [INFO] [stdout] --> src/fft_2D.rs:30:8 [INFO] [stdout] | [INFO] [stdout] 30 | pub fn FFT_2D(mut image: Array2) -> Array2{ [INFO] [stdout] | ^^^^^^ help: convert the identifier to snake case: `fft_2_d` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `FFTshift` should have a snake case name [INFO] [stdout] --> src/fft_2D.rs:53:4 [INFO] [stdout] | [INFO] [stdout] 53 | fn FFTshift(image: &mut Array2){ [INFO] [stdout] | ^^^^^^^^ help: convert the identifier to snake case: `fftshift` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison is useless due to type limits [INFO] [stdout] --> src/diffraction_simulator.rs:60:8 [INFO] [stdout] | [INFO] [stdout] 60 | if (x >= 0) && (x < image.ncols()) && [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_comparisons)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison is useless due to type limits [INFO] [stdout] --> src/diffraction_simulator.rs:61:9 [INFO] [stdout] | [INFO] [stdout] 61 | (z >= 0) && (z < image.nrows()) { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison is useless due to type limits [INFO] [stdout] --> src/diffraction_simulator.rs:84:8 [INFO] [stdout] | [INFO] [stdout] 84 | if (x >= 0) && (x < image.ncols()) && [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison is useless due to type limits [INFO] [stdout] --> src/diffraction_simulator.rs:85:9 [INFO] [stdout] | [INFO] [stdout] 85 | (z >= 0) && (z < image.nrows()) { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 20 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 20 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.88s [INFO] running `Command { std: "docker" "inspect" "c95b3db4e70dfbabf171cbf979f10a014fc57ea04ade77f571b5294bd3479bae", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "c95b3db4e70dfbabf171cbf979f10a014fc57ea04ade77f571b5294bd3479bae", kill_on_drop: false }` [INFO] [stdout] c95b3db4e70dfbabf171cbf979f10a014fc57ea04ade77f571b5294bd3479bae