[INFO] cloning repository https://github.com/zenja/nes [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/zenja/nes" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fzenja%2Fnes", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fzenja%2Fnes'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 6cb4d7a5edf5d566024090643c103b803e157aea [INFO] checking zenja/nes against try#a7a572ce3edd6d476191fbfe92c9c1986e009b34 for pr-87190-3 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fzenja%2Fnes" "/workspace/builds/worker-17/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-17/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/zenja/nes on toolchain a7a572ce3edd6d476191fbfe92c9c1986e009b34 [INFO] running `Command { std: "/workspace/cargo-home/bin/cargo" "+a7a572ce3edd6d476191fbfe92c9c1986e009b34" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/zenja/nes [INFO] finished tweaking git repo https://github.com/zenja/nes [INFO] tweaked toml for git repo https://github.com/zenja/nes written to /workspace/builds/worker-17/source/Cargo.toml [INFO] crate git repo https://github.com/zenja/nes already has a lockfile, it will not be regenerated [INFO] running `Command { std: "/workspace/cargo-home/bin/cargo" "+a7a572ce3edd6d476191fbfe92c9c1986e009b34" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-17/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-17/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:34b6a614d2c27851fe6cbf88fbd1137609cefab8b10d0615aaeb6fd47975d74e" "/opt/rustwide/cargo-home/bin/cargo" "+a7a572ce3edd6d476191fbfe92c9c1986e009b34" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] f7b66fd305681754197eaa0ca38d0372eeda197ec47d8d7b07a5332f6bd889eb [INFO] running `Command { std: "docker" "start" "-a" "f7b66fd305681754197eaa0ca38d0372eeda197ec47d8d7b07a5332f6bd889eb", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "f7b66fd305681754197eaa0ca38d0372eeda197ec47d8d7b07a5332f6bd889eb", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "f7b66fd305681754197eaa0ca38d0372eeda197ec47d8d7b07a5332f6bd889eb", kill_on_drop: false }` [INFO] [stdout] f7b66fd305681754197eaa0ca38d0372eeda197ec47d8d7b07a5332f6bd889eb [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-17/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-17/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:34b6a614d2c27851fe6cbf88fbd1137609cefab8b10d0615aaeb6fd47975d74e" "/opt/rustwide/cargo-home/bin/cargo" "+a7a572ce3edd6d476191fbfe92c9c1986e009b34" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 13c6c2712ecbbd961a5205e842af54eb32c68dbc1cd1213ec34ed343f552df3b [INFO] running `Command { std: "docker" "start" "-a" "13c6c2712ecbbd961a5205e842af54eb32c68dbc1cd1213ec34ed343f552df3b", kill_on_drop: false }` [INFO] [stderr] Copying to /tmp/fixit [INFO] [stderr] Running `cargo fix --edition` [INFO] [stderr] Compiling memchr v2.4.0 [INFO] [stderr] Checking regex-syntax v0.6.25 [INFO] [stderr] Checking either v1.6.1 [INFO] [stderr] Checking lazy_static v1.4.0 [INFO] [stderr] Checking itertools v0.10.1 [INFO] [stderr] Checking aho-corasick v0.7.18 [INFO] [stderr] Checking regex v1.5.4 [INFO] [stderr] Checking nes v0.1.0 (/tmp/fixit) [INFO] [stderr] Migrating src/lib.rs from 2018 edition to 2021 [INFO] [stdout] warning: associated function is never used: `fetch` [INFO] [stdout] --> src/cpu/addr.rs:53:8 [INFO] [stdout] | [INFO] [stdout] 53 | fn fetch<'a, I>(&self, bytes: I) -> Address [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function is never used: `read_bytes` [INFO] [stdout] --> src/cpu/addr.rs:76:4 [INFO] [stdout] | [INFO] [stdout] 76 | fn read_bytes<'a, I>(mut bytes: I, num_bytes: u8) -> u16 [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated function is never used: `stack_push_u16` [INFO] [stdout] --> src/cpu/mod.rs:797:8 [INFO] [stdout] | [INFO] [stdout] 797 | fn stack_push_u16(&mut self, data: u16) { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated function is never used: `set_from_bits` [INFO] [stdout] --> src/cpu/mod.rs:854:8 [INFO] [stdout] | [INFO] [stdout] 854 | fn set_from_bits(&mut self, bits: u8) { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field is never read: `num_chr_banks` [INFO] [stdout] --> src/mapper/mapper_0.rs:3:5 [INFO] [stdout] | [INFO] [stdout] 3 | num_chr_banks: u8, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `update_status_Z_N` should have a snake case name [INFO] [stdout] --> src/cpu/mod.rs:781:8 [INFO] [stdout] | [INFO] [stdout] 781 | fn update_status_Z_N(&mut self, result: u8) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: convert the identifier to snake case: `update_status_z_n` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_snake_case)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison is useless due to type limits [INFO] [stdout] --> src/mapper/mapper_0.rs:23:30 [INFO] [stdout] | [INFO] [stdout] 23 | if addr >= 0x8000 && addr <= 0xFFFF { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_comparisons)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison is useless due to type limits [INFO] [stdout] --> src/mapper/mapper_0.rs:36:30 [INFO] [stdout] | [INFO] [stdout] 36 | if addr >= 0x8000 && addr <= 0xFFFF { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 8 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Migrating src/bin/nes.rs from 2018 edition to 2021 [INFO] [stderr] Migrating tests/nestest.rs from 2018 edition to 2021 [INFO] [stdout] warning: associated function is never used: `stack_push_u16` [INFO] [stdout] --> src/cpu/mod.rs:797:8 [INFO] [stdout] | [INFO] [stdout] 797 | fn stack_push_u16(&mut self, data: u16) { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated function is never used: `set_from_bits` [INFO] [stdout] --> src/cpu/mod.rs:854:8 [INFO] [stdout] | [INFO] [stdout] 854 | fn set_from_bits(&mut self, bits: u8) { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field is never read: `num_chr_banks` [INFO] [stdout] --> src/mapper/mapper_0.rs:3:5 [INFO] [stdout] | [INFO] [stdout] 3 | num_chr_banks: u8, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `update_status_Z_N` should have a snake case name [INFO] [stdout] --> src/cpu/mod.rs:781:8 [INFO] [stdout] | [INFO] [stdout] 781 | fn update_status_Z_N(&mut self, result: u8) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: convert the identifier to snake case: `update_status_z_n` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_snake_case)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison is useless due to type limits [INFO] [stdout] --> src/mapper/mapper_0.rs:23:30 [INFO] [stdout] | [INFO] [stdout] 23 | if addr >= 0x8000 && addr <= 0xFFFF { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_comparisons)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison is useless due to type limits [INFO] [stdout] --> src/mapper/mapper_0.rs:36:30 [INFO] [stdout] | [INFO] [stdout] 36 | if addr >= 0x8000 && addr <= 0xFFFF { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 6 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 14.49s [INFO] [stderr] Running `cargo check` to verify 2021 [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Checking nes v0.1.0 (/tmp/fixit) [INFO] [stdout] warning: associated function is never used: `fetch` [INFO] [stdout] --> src/cpu/addr.rs:53:8 [INFO] [stdout] | [INFO] [stdout] 53 | fn fetch<'a, I>(&self, bytes: I) -> Address [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function is never used: `read_bytes` [INFO] [stdout] --> src/cpu/addr.rs:76:4 [INFO] [stdout] | [INFO] [stdout] 76 | fn read_bytes<'a, I>(mut bytes: I, num_bytes: u8) -> u16 [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated function is never used: `stack_push_u16` [INFO] [stdout] --> src/cpu/mod.rs:797:8 [INFO] [stdout] | [INFO] [stdout] 797 | fn stack_push_u16(&mut self, data: u16) { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated function is never used: `set_from_bits` [INFO] [stdout] --> src/cpu/mod.rs:854:8 [INFO] [stdout] | [INFO] [stdout] 854 | fn set_from_bits(&mut self, bits: u8) { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field is never read: `num_chr_banks` [INFO] [stdout] --> src/mapper/mapper_0.rs:3:5 [INFO] [stdout] | [INFO] [stdout] 3 | num_chr_banks: u8, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `update_status_Z_N` should have a snake case name [INFO] [stdout] --> src/cpu/mod.rs:781:8 [INFO] [stdout] | [INFO] [stdout] 781 | fn update_status_Z_N(&mut self, result: u8) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: convert the identifier to snake case: `update_status_z_n` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_snake_case)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison is useless due to type limits [INFO] [stdout] --> src/mapper/mapper_0.rs:23:30 [INFO] [stdout] | [INFO] [stdout] 23 | if addr >= 0x8000 && addr <= 0xFFFF { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_comparisons)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison is useless due to type limits [INFO] [stdout] --> src/mapper/mapper_0.rs:36:30 [INFO] [stdout] | [INFO] [stdout] 36 | if addr >= 0x8000 && addr <= 0xFFFF { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 8 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated function is never used: `stack_push_u16` [INFO] [stdout] --> src/cpu/mod.rs:797:8 [INFO] [stdout] | [INFO] [stdout] 797 | fn stack_push_u16(&mut self, data: u16) { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated function is never used: `set_from_bits` [INFO] [stdout] --> src/cpu/mod.rs:854:8 [INFO] [stdout] | [INFO] [stdout] 854 | fn set_from_bits(&mut self, bits: u8) { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field is never read: `num_chr_banks` [INFO] [stdout] --> src/mapper/mapper_0.rs:3:5 [INFO] [stdout] | [INFO] [stdout] 3 | num_chr_banks: u8, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `update_status_Z_N` should have a snake case name [INFO] [stdout] --> src/cpu/mod.rs:781:8 [INFO] [stdout] | [INFO] [stdout] 781 | fn update_status_Z_N(&mut self, result: u8) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: convert the identifier to snake case: `update_status_z_n` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_snake_case)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison is useless due to type limits [INFO] [stdout] --> src/mapper/mapper_0.rs:23:30 [INFO] [stdout] | [INFO] [stdout] 23 | if addr >= 0x8000 && addr <= 0xFFFF { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_comparisons)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison is useless due to type limits [INFO] [stdout] --> src/mapper/mapper_0.rs:36:30 [INFO] [stdout] | [INFO] [stdout] 36 | if addr >= 0x8000 && addr <= 0xFFFF { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 6 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.22s [INFO] running `Command { std: "docker" "inspect" "13c6c2712ecbbd961a5205e842af54eb32c68dbc1cd1213ec34ed343f552df3b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "13c6c2712ecbbd961a5205e842af54eb32c68dbc1cd1213ec34ed343f552df3b", kill_on_drop: false }` [INFO] [stdout] 13c6c2712ecbbd961a5205e842af54eb32c68dbc1cd1213ec34ed343f552df3b