[INFO] cloning repository https://github.com/yufrice/nesnes [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/yufrice/nesnes" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fyufrice%2Fnesnes", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fyufrice%2Fnesnes'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] e4fe3ae0711fce9849c84c4c087b476c44152318 [INFO] checking yufrice/nesnes against try#a7a572ce3edd6d476191fbfe92c9c1986e009b34 for pr-87190-3 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fyufrice%2Fnesnes" "/workspace/builds/worker-0/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-0/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/yufrice/nesnes on toolchain a7a572ce3edd6d476191fbfe92c9c1986e009b34 [INFO] running `Command { std: "/workspace/cargo-home/bin/cargo" "+a7a572ce3edd6d476191fbfe92c9c1986e009b34" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/yufrice/nesnes [INFO] finished tweaking git repo https://github.com/yufrice/nesnes [INFO] tweaked toml for git repo https://github.com/yufrice/nesnes written to /workspace/builds/worker-0/source/Cargo.toml [INFO] crate git repo https://github.com/yufrice/nesnes already has a lockfile, it will not be regenerated [INFO] running `Command { std: "/workspace/cargo-home/bin/cargo" "+a7a572ce3edd6d476191fbfe92c9c1986e009b34" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:34b6a614d2c27851fe6cbf88fbd1137609cefab8b10d0615aaeb6fd47975d74e" "/opt/rustwide/cargo-home/bin/cargo" "+a7a572ce3edd6d476191fbfe92c9c1986e009b34" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stderr] WARNING: Your kernel does not support swap limit capabilities or the cgroup is not mounted. Memory limited without swap. [INFO] [stdout] 45602a19f52997d6a9e8a93f0cf344adc2a15a77193e9c5c5ceb5b41000c414e [INFO] running `Command { std: "docker" "start" "-a" "45602a19f52997d6a9e8a93f0cf344adc2a15a77193e9c5c5ceb5b41000c414e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "45602a19f52997d6a9e8a93f0cf344adc2a15a77193e9c5c5ceb5b41000c414e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "45602a19f52997d6a9e8a93f0cf344adc2a15a77193e9c5c5ceb5b41000c414e", kill_on_drop: false }` [INFO] [stdout] 45602a19f52997d6a9e8a93f0cf344adc2a15a77193e9c5c5ceb5b41000c414e [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:34b6a614d2c27851fe6cbf88fbd1137609cefab8b10d0615aaeb6fd47975d74e" "/opt/rustwide/cargo-home/bin/cargo" "+a7a572ce3edd6d476191fbfe92c9c1986e009b34" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 0d610e99f855d14a21615a850044027af456227b4a56beb416b5024359f37e6d [INFO] [stderr] WARNING: Your kernel does not support swap limit capabilities or the cgroup is not mounted. Memory limited without swap. [INFO] running `Command { std: "docker" "start" "-a" "0d610e99f855d14a21615a850044027af456227b4a56beb416b5024359f37e6d", kill_on_drop: false }` [INFO] [stderr] Copying to /tmp/fixit [INFO] [stderr] Running `cargo fix --edition` [INFO] [stderr] Compiling autocfg v0.1.2 [INFO] [stderr] Checking rand_core v0.4.0 [INFO] [stderr] Compiling libc v0.2.51 [INFO] [stderr] Compiling num-traits v0.2.6 [INFO] [stderr] Compiling memchr v2.2.0 [INFO] [stderr] Compiling num-integer v0.1.39 [INFO] [stderr] Checking lazy_static v1.3.0 [INFO] [stderr] Compiling num-iter v0.1.37 [INFO] [stderr] Checking ucd-util v0.1.3 [INFO] [stderr] Compiling regex v1.1.5 [INFO] [stderr] Checking utf8-ranges v1.0.2 [INFO] [stderr] Compiling sdl2 v0.32.2 [INFO] [stderr] Checking quick-error v1.2.2 [INFO] [stderr] Checking bitflags v1.0.4 [INFO] [stderr] Checking termcolor v1.0.4 [INFO] [stderr] Compiling sdl2-sys v0.32.5 [INFO] [stderr] Checking humantime v1.2.0 [INFO] [stderr] Checking rand_core v0.3.1 [INFO] [stderr] Checking rand_jitter v0.1.3 [INFO] [stderr] Checking thread_local v0.3.6 [INFO] [stderr] Checking regex-syntax v0.6.6 [INFO] [stderr] Checking rand_hc v0.1.0 [INFO] [stderr] Checking rand_isaac v0.1.1 [INFO] [stderr] Checking rand_xorshift v0.1.1 [INFO] [stderr] Compiling rand_pcg v0.1.2 [INFO] [stderr] Compiling rand_chacha v0.1.1 [INFO] [stderr] Compiling rand v0.6.5 [INFO] [stderr] Checking aho-corasick v0.7.3 [INFO] [stderr] Checking rand_os v0.1.3 [INFO] [stderr] Checking atty v0.2.11 [INFO] [stderr] Checking num v0.1.42 [INFO] [stderr] Checking env_logger v0.6.1 [INFO] [stderr] Checking nesnes v0.1.0 (/tmp/fixit) [INFO] [stderr] Migrating src/lib.rs from 2018 edition to 2021 [INFO] [stderr] Fixed src/arch/memory.rs (12 fixes) [INFO] [stderr] Fixed src/arch/ppu.rs (7 fixes) [INFO] [stdout] warning: variant `a` should have an upper camel case name [INFO] [stdout] --> src/arch/mod.rs:23:5 [INFO] [stdout] | [INFO] [stdout] 23 | a, [INFO] [stdout] | ^ help: convert the identifier to upper camel case: `A` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_camel_case_types)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `x` should have an upper camel case name [INFO] [stdout] --> src/arch/mod.rs:24:5 [INFO] [stdout] | [INFO] [stdout] 24 | x, [INFO] [stdout] | ^ help: convert the identifier to upper camel case (notice the capitalization): `X` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `y` should have an upper camel case name [INFO] [stdout] --> src/arch/mod.rs:25:5 [INFO] [stdout] | [INFO] [stdout] 25 | y, [INFO] [stdout] | ^ help: convert the identifier to upper camel case (notice the capitalization): `Y` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `pc` should have an upper camel case name [INFO] [stdout] --> src/arch/mod.rs:26:5 [INFO] [stdout] | [INFO] [stdout] 26 | pc, [INFO] [stdout] | ^^ help: convert the identifier to upper camel case: `Pc` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `sp` should have an upper camel case name [INFO] [stdout] --> src/arch/mod.rs:27:5 [INFO] [stdout] | [INFO] [stdout] 27 | sp, [INFO] [stdout] | ^^ help: convert the identifier to upper camel case (notice the capitalization): `Sp` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `p` should have an upper camel case name [INFO] [stdout] --> src/arch/mod.rs:28:5 [INFO] [stdout] | [INFO] [stdout] 28 | p, [INFO] [stdout] | ^ help: convert the identifier to upper camel case: `P` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `a` should have an upper camel case name [INFO] [stdout] --> src/arch/mod.rs:23:5 [INFO] [stdout] | [INFO] [stdout] 23 | a, [INFO] [stdout] | ^ help: convert the identifier to upper camel case: `A` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_camel_case_types)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `x` should have an upper camel case name [INFO] [stdout] --> src/arch/mod.rs:24:5 [INFO] [stdout] | [INFO] [stdout] 24 | x, [INFO] [stdout] | ^ help: convert the identifier to upper camel case (notice the capitalization): `X` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `y` should have an upper camel case name [INFO] [stdout] --> src/arch/mod.rs:25:5 [INFO] [stdout] | [INFO] [stdout] 25 | y, [INFO] [stdout] | ^ help: convert the identifier to upper camel case (notice the capitalization): `Y` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `pc` should have an upper camel case name [INFO] [stdout] --> src/arch/mod.rs:26:5 [INFO] [stdout] | [INFO] [stdout] 26 | pc, [INFO] [stdout] | ^^ help: convert the identifier to upper camel case: `Pc` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `sp` should have an upper camel case name [INFO] [stdout] --> src/arch/mod.rs:27:5 [INFO] [stdout] | [INFO] [stdout] 27 | sp, [INFO] [stdout] | ^^ help: convert the identifier to upper camel case (notice the capitalization): `Sp` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `p` should have an upper camel case name [INFO] [stdout] --> src/arch/mod.rs:28:5 [INFO] [stdout] | [INFO] [stdout] 28 | p, [INFO] [stdout] | ^ help: convert the identifier to upper camel case: `P` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field is never read: `ioa` [INFO] [stdout] --> src/arch/memory.rs:18:5 [INFO] [stdout] | [INFO] [stdout] 18 | pub(crate) ioa: [u8; 0x0020], [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant is never constructed: `DISPLAY2` [INFO] [stdout] --> src/arch/ppu.rs:19:5 [INFO] [stdout] | [INFO] [stdout] 19 | DISPLAY2, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant is never constructed: `DISPLAY3` [INFO] [stdout] --> src/arch/ppu.rs:20:5 [INFO] [stdout] | [INFO] [stdout] 20 | DISPLAY3, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant is never constructed: `DISPLAY4` [INFO] [stdout] --> src/arch/ppu.rs:21:5 [INFO] [stdout] | [INFO] [stdout] 21 | DISPLAY4, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field is never read: `display1` [INFO] [stdout] --> src/arch/ppu.rs:34:5 [INFO] [stdout] | [INFO] [stdout] 34 | pub(crate) display1: RefCell, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field is never read: `mirroring` [INFO] [stdout] --> src/arch/ppu.rs:35:5 [INFO] [stdout] | [INFO] [stdout] 35 | pub(crate) mirroring: Mirroring, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated function is never used: `read` [INFO] [stdout] --> src/arch/ppu.rs:114:12 [INFO] [stdout] | [INFO] [stdout] 114 | pub fn read(&self, adr: u8) { [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated function is never used: `soft_reset` [INFO] [stdout] --> src/arch/register.rs:46:19 [INFO] [stdout] | [INFO] [stdout] 46 | pub(crate) fn soft_reset(&self) { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated function is never used: `nmi` [INFO] [stdout] --> src/arch/register.rs:51:19 [INFO] [stdout] | [INFO] [stdout] 51 | pub(crate) fn nmi(&self) { [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated function is never used: `irq` [INFO] [stdout] --> src/arch/register.rs:68:19 [INFO] [stdout] | [INFO] [stdout] 68 | pub(crate) fn irq(&self) { [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant is never constructed: `pc` [INFO] [stdout] --> src/arch/mod.rs:26:5 [INFO] [stdout] | [INFO] [stdout] 26 | pc, [INFO] [stdout] | ^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant is never constructed: `p` [INFO] [stdout] --> src/arch/mod.rs:28:5 [INFO] [stdout] | [INFO] [stdout] 28 | p, [INFO] [stdout] | ^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant is never used: `DISPLAY_SIZE` [INFO] [stdout] --> src/lib.rs:16:1 [INFO] [stdout] | [INFO] [stdout] 16 | const DISPLAY_SIZE: usize = 184_320; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `nz_withSet` should have a snake case name [INFO] [stdout] --> src/arch/op.rs:275:8 [INFO] [stdout] | [INFO] [stdout] 275 | fn nz_withSet(&self, value: u8, addr: WriteAddr) { [INFO] [stdout] | ^^^^^^^^^^ help: convert the identifier to snake case: `nz_with_set` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_snake_case)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `nzc_withSet` should have a snake case name [INFO] [stdout] --> src/arch/op.rs:296:19 [INFO] [stdout] | [INFO] [stdout] 296 | pub(crate) fn nzc_withSet(&self, result: u16, addr: WriteAddr) { [INFO] [stdout] | ^^^^^^^^^^^ help: convert the identifier to snake case: `nzc_with_set` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `nvzc_withSet` should have a snake case name [INFO] [stdout] --> src/arch/op.rs:311:19 [INFO] [stdout] | [INFO] [stdout] 311 | pub(crate) fn nvzc_withSet(&self, pre: u16, rhs: u16, result: u16, addr: WriteAddr) { [INFO] [stdout] | ^^^^^^^^^^^^ help: convert the identifier to snake case: `nvzc_with_set` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: static variable `color_palettes` should have an upper case name [INFO] [stdout] --> src/arch/ppu.rs:128:16 [INFO] [stdout] | [INFO] [stdout] 128 | static color_palettes: [[u8; 0x03]; 0x40] = [ [INFO] [stdout] | ^^^^^^^^^^^^^^ help: convert the identifier to upper case: `COLOR_PALETTES` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_upper_case_globals)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 23 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field is never read: `ioa` [INFO] [stdout] --> src/arch/memory.rs:18:5 [INFO] [stdout] | [INFO] [stdout] 18 | pub(crate) ioa: [u8; 0x0020], [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant is never constructed: `DISPLAY2` [INFO] [stdout] --> src/arch/ppu.rs:19:5 [INFO] [stdout] | [INFO] [stdout] 19 | DISPLAY2, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant is never constructed: `DISPLAY3` [INFO] [stdout] --> src/arch/ppu.rs:20:5 [INFO] [stdout] | [INFO] [stdout] 20 | DISPLAY3, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant is never constructed: `DISPLAY4` [INFO] [stdout] --> src/arch/ppu.rs:21:5 [INFO] [stdout] | [INFO] [stdout] 21 | DISPLAY4, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field is never read: `display1` [INFO] [stdout] --> src/arch/ppu.rs:34:5 [INFO] [stdout] | [INFO] [stdout] 34 | pub(crate) display1: RefCell, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field is never read: `mirroring` [INFO] [stdout] --> src/arch/ppu.rs:35:5 [INFO] [stdout] | [INFO] [stdout] 35 | pub(crate) mirroring: Mirroring, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated function is never used: `read` [INFO] [stdout] --> src/arch/ppu.rs:114:12 [INFO] [stdout] | [INFO] [stdout] 114 | pub fn read(&self, adr: u8) { [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated function is never used: `soft_reset` [INFO] [stdout] --> src/arch/register.rs:46:19 [INFO] [stdout] | [INFO] [stdout] 46 | pub(crate) fn soft_reset(&self) { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated function is never used: `nmi` [INFO] [stdout] --> src/arch/register.rs:51:19 [INFO] [stdout] | [INFO] [stdout] 51 | pub(crate) fn nmi(&self) { [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated function is never used: `irq` [INFO] [stdout] --> src/arch/register.rs:68:19 [INFO] [stdout] | [INFO] [stdout] 68 | pub(crate) fn irq(&self) { [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant is never constructed: `pc` [INFO] [stdout] --> src/arch/mod.rs:26:5 [INFO] [stdout] | [INFO] [stdout] 26 | pc, [INFO] [stdout] | ^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant is never constructed: `p` [INFO] [stdout] --> src/arch/mod.rs:28:5 [INFO] [stdout] | [INFO] [stdout] 28 | p, [INFO] [stdout] | ^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant is never used: `DISPLAY_SIZE` [INFO] [stdout] --> src/lib.rs:16:1 [INFO] [stdout] | [INFO] [stdout] 16 | const DISPLAY_SIZE: usize = 184_320; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `nz_withSet` should have a snake case name [INFO] [stdout] --> src/arch/op.rs:275:8 [INFO] [stdout] | [INFO] [stdout] 275 | fn nz_withSet(&self, value: u8, addr: WriteAddr) { [INFO] [stdout] | ^^^^^^^^^^ help: convert the identifier to snake case: `nz_with_set` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_snake_case)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `nzc_withSet` should have a snake case name [INFO] [stdout] --> src/arch/op.rs:296:19 [INFO] [stdout] | [INFO] [stdout] 296 | pub(crate) fn nzc_withSet(&self, result: u16, addr: WriteAddr) { [INFO] [stdout] | ^^^^^^^^^^^ help: convert the identifier to snake case: `nzc_with_set` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `nvzc_withSet` should have a snake case name [INFO] [stdout] --> src/arch/op.rs:311:19 [INFO] [stdout] | [INFO] [stdout] 311 | pub(crate) fn nvzc_withSet(&self, pre: u16, rhs: u16, result: u16, addr: WriteAddr) { [INFO] [stdout] | ^^^^^^^^^^^^ help: convert the identifier to snake case: `nvzc_with_set` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: static variable `color_palettes` should have an upper case name [INFO] [stdout] --> src/arch/ppu.rs:128:16 [INFO] [stdout] | [INFO] [stdout] 128 | static color_palettes: [[u8; 0x03]; 0x40] = [ [INFO] [stdout] | ^^^^^^^^^^^^^^ help: convert the identifier to upper case: `COLOR_PALETTES` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_upper_case_globals)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 23 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Migrating src/main.rs from 2018 edition to 2021 [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 22.18s [INFO] [stderr] Running `cargo check` to verify 2021 [INFO] [stderr] Checking nesnes v0.1.0 (/tmp/fixit) [INFO] [stdout] warning: variant `a` should have an upper camel case name [INFO] [stdout] --> src/arch/mod.rs:23:5 [INFO] [stdout] | [INFO] [stdout] 23 | a, [INFO] [stdout] | ^ help: convert the identifier to upper camel case: `A` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_camel_case_types)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `x` should have an upper camel case name [INFO] [stdout] --> src/arch/mod.rs:24:5 [INFO] [stdout] | [INFO] [stdout] 24 | x, [INFO] [stdout] | ^ help: convert the identifier to upper camel case (notice the capitalization): `X` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `y` should have an upper camel case name [INFO] [stdout] --> src/arch/mod.rs:25:5 [INFO] [stdout] | [INFO] [stdout] 25 | y, [INFO] [stdout] | ^ help: convert the identifier to upper camel case (notice the capitalization): `Y` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `pc` should have an upper camel case name [INFO] [stdout] --> src/arch/mod.rs:26:5 [INFO] [stdout] | [INFO] [stdout] 26 | pc, [INFO] [stdout] | ^^ help: convert the identifier to upper camel case: `Pc` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `sp` should have an upper camel case name [INFO] [stdout] --> src/arch/mod.rs:27:5 [INFO] [stdout] | [INFO] [stdout] 27 | sp, [INFO] [stdout] | ^^ help: convert the identifier to upper camel case (notice the capitalization): `Sp` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `p` should have an upper camel case name [INFO] [stdout] --> src/arch/mod.rs:28:5 [INFO] [stdout] | [INFO] [stdout] 28 | p, [INFO] [stdout] | ^ help: convert the identifier to upper camel case: `P` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `a` should have an upper camel case name [INFO] [stdout] --> src/arch/mod.rs:23:5 [INFO] [stdout] | [INFO] [stdout] 23 | a, [INFO] [stdout] | ^ help: convert the identifier to upper camel case: `A` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_camel_case_types)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `x` should have an upper camel case name [INFO] [stdout] --> src/arch/mod.rs:24:5 [INFO] [stdout] | [INFO] [stdout] 24 | x, [INFO] [stdout] | ^ help: convert the identifier to upper camel case (notice the capitalization): `X` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `y` should have an upper camel case name [INFO] [stdout] --> src/arch/mod.rs:25:5 [INFO] [stdout] | [INFO] [stdout] 25 | y, [INFO] [stdout] | ^ help: convert the identifier to upper camel case (notice the capitalization): `Y` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `pc` should have an upper camel case name [INFO] [stdout] --> src/arch/mod.rs:26:5 [INFO] [stdout] | [INFO] [stdout] 26 | pc, [INFO] [stdout] | ^^ help: convert the identifier to upper camel case: `Pc` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `sp` should have an upper camel case name [INFO] [stdout] --> src/arch/mod.rs:27:5 [INFO] [stdout] | [INFO] [stdout] 27 | sp, [INFO] [stdout] | ^^ help: convert the identifier to upper camel case (notice the capitalization): `Sp` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `p` should have an upper camel case name [INFO] [stdout] --> src/arch/mod.rs:28:5 [INFO] [stdout] | [INFO] [stdout] 28 | p, [INFO] [stdout] | ^ help: convert the identifier to upper camel case: `P` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field is never read: `ioa` [INFO] [stdout] --> src/arch/memory.rs:18:5 [INFO] [stdout] | [INFO] [stdout] 18 | pub(crate) ioa: [u8; 0x0020], [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant is never constructed: `DISPLAY2` [INFO] [stdout] --> src/arch/ppu.rs:19:5 [INFO] [stdout] | [INFO] [stdout] 19 | DISPLAY2, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant is never constructed: `DISPLAY3` [INFO] [stdout] --> src/arch/ppu.rs:20:5 [INFO] [stdout] | [INFO] [stdout] 20 | DISPLAY3, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant is never constructed: `DISPLAY4` [INFO] [stdout] --> src/arch/ppu.rs:21:5 [INFO] [stdout] | [INFO] [stdout] 21 | DISPLAY4, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field is never read: `display1` [INFO] [stdout] --> src/arch/ppu.rs:34:5 [INFO] [stdout] | [INFO] [stdout] 34 | pub(crate) display1: RefCell, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field is never read: `mirroring` [INFO] [stdout] --> src/arch/ppu.rs:35:5 [INFO] [stdout] | [INFO] [stdout] 35 | pub(crate) mirroring: Mirroring, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated function is never used: `read` [INFO] [stdout] --> src/arch/ppu.rs:114:12 [INFO] [stdout] | [INFO] [stdout] 114 | pub fn read(&self, adr: u8) { [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated function is never used: `soft_reset` [INFO] [stdout] --> src/arch/register.rs:46:19 [INFO] [stdout] | [INFO] [stdout] 46 | pub(crate) fn soft_reset(&self) { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated function is never used: `nmi` [INFO] [stdout] --> src/arch/register.rs:51:19 [INFO] [stdout] | [INFO] [stdout] 51 | pub(crate) fn nmi(&self) { [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated function is never used: `irq` [INFO] [stdout] --> src/arch/register.rs:68:19 [INFO] [stdout] | [INFO] [stdout] 68 | pub(crate) fn irq(&self) { [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant is never constructed: `pc` [INFO] [stdout] --> src/arch/mod.rs:26:5 [INFO] [stdout] | [INFO] [stdout] 26 | pc, [INFO] [stdout] | ^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant is never constructed: `p` [INFO] [stdout] --> src/arch/mod.rs:28:5 [INFO] [stdout] | [INFO] [stdout] 28 | p, [INFO] [stdout] | ^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant is never used: `DISPLAY_SIZE` [INFO] [stdout] --> src/lib.rs:16:1 [INFO] [stdout] | [INFO] [stdout] 16 | const DISPLAY_SIZE: usize = 184_320; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `nz_withSet` should have a snake case name [INFO] [stdout] --> src/arch/op.rs:275:8 [INFO] [stdout] | [INFO] [stdout] 275 | fn nz_withSet(&self, value: u8, addr: WriteAddr) { [INFO] [stdout] | ^^^^^^^^^^ help: convert the identifier to snake case: `nz_with_set` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_snake_case)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `nzc_withSet` should have a snake case name [INFO] [stdout] --> src/arch/op.rs:296:19 [INFO] [stdout] | [INFO] [stdout] 296 | pub(crate) fn nzc_withSet(&self, result: u16, addr: WriteAddr) { [INFO] [stdout] | ^^^^^^^^^^^ help: convert the identifier to snake case: `nzc_with_set` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `nvzc_withSet` should have a snake case name [INFO] [stdout] --> src/arch/op.rs:311:19 [INFO] [stdout] | [INFO] [stdout] 311 | pub(crate) fn nvzc_withSet(&self, pre: u16, rhs: u16, result: u16, addr: WriteAddr) { [INFO] [stdout] | ^^^^^^^^^^^^ help: convert the identifier to snake case: `nvzc_with_set` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: static variable `color_palettes` should have an upper case name [INFO] [stdout] --> src/arch/ppu.rs:128:16 [INFO] [stdout] | [INFO] [stdout] 128 | static color_palettes: [[u8; 0x03]; 0x40] = [ [INFO] [stdout] | ^^^^^^^^^^^^^^ help: convert the identifier to upper case: `COLOR_PALETTES` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_upper_case_globals)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 23 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field is never read: `ioa` [INFO] [stdout] --> src/arch/memory.rs:18:5 [INFO] [stdout] | [INFO] [stdout] 18 | pub(crate) ioa: [u8; 0x0020], [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant is never constructed: `DISPLAY2` [INFO] [stdout] --> src/arch/ppu.rs:19:5 [INFO] [stdout] | [INFO] [stdout] 19 | DISPLAY2, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant is never constructed: `DISPLAY3` [INFO] [stdout] --> src/arch/ppu.rs:20:5 [INFO] [stdout] | [INFO] [stdout] 20 | DISPLAY3, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant is never constructed: `DISPLAY4` [INFO] [stdout] --> src/arch/ppu.rs:21:5 [INFO] [stdout] | [INFO] [stdout] 21 | DISPLAY4, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field is never read: `display1` [INFO] [stdout] --> src/arch/ppu.rs:34:5 [INFO] [stdout] | [INFO] [stdout] 34 | pub(crate) display1: RefCell, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field is never read: `mirroring` [INFO] [stdout] --> src/arch/ppu.rs:35:5 [INFO] [stdout] | [INFO] [stdout] 35 | pub(crate) mirroring: Mirroring, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated function is never used: `read` [INFO] [stdout] --> src/arch/ppu.rs:114:12 [INFO] [stdout] | [INFO] [stdout] 114 | pub fn read(&self, adr: u8) { [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated function is never used: `soft_reset` [INFO] [stdout] --> src/arch/register.rs:46:19 [INFO] [stdout] | [INFO] [stdout] 46 | pub(crate) fn soft_reset(&self) { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated function is never used: `nmi` [INFO] [stdout] --> src/arch/register.rs:51:19 [INFO] [stdout] | [INFO] [stdout] 51 | pub(crate) fn nmi(&self) { [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated function is never used: `irq` [INFO] [stdout] --> src/arch/register.rs:68:19 [INFO] [stdout] | [INFO] [stdout] 68 | pub(crate) fn irq(&self) { [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant is never constructed: `pc` [INFO] [stdout] --> src/arch/mod.rs:26:5 [INFO] [stdout] | [INFO] [stdout] 26 | pc, [INFO] [stdout] | ^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant is never constructed: `p` [INFO] [stdout] --> src/arch/mod.rs:28:5 [INFO] [stdout] | [INFO] [stdout] 28 | p, [INFO] [stdout] | ^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant is never used: `DISPLAY_SIZE` [INFO] [stdout] --> src/lib.rs:16:1 [INFO] [stdout] | [INFO] [stdout] 16 | const DISPLAY_SIZE: usize = 184_320; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `nz_withSet` should have a snake case name [INFO] [stdout] --> src/arch/op.rs:275:8 [INFO] [stdout] | [INFO] [stdout] 275 | fn nz_withSet(&self, value: u8, addr: WriteAddr) { [INFO] [stdout] | ^^^^^^^^^^ help: convert the identifier to snake case: `nz_with_set` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_snake_case)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `nzc_withSet` should have a snake case name [INFO] [stdout] --> src/arch/op.rs:296:19 [INFO] [stdout] | [INFO] [stdout] 296 | pub(crate) fn nzc_withSet(&self, result: u16, addr: WriteAddr) { [INFO] [stdout] | ^^^^^^^^^^^ help: convert the identifier to snake case: `nzc_with_set` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `nvzc_withSet` should have a snake case name [INFO] [stdout] --> src/arch/op.rs:311:19 [INFO] [stdout] | [INFO] [stdout] 311 | pub(crate) fn nvzc_withSet(&self, pre: u16, rhs: u16, result: u16, addr: WriteAddr) { [INFO] [stdout] | ^^^^^^^^^^^^ help: convert the identifier to snake case: `nvzc_with_set` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: static variable `color_palettes` should have an upper case name [INFO] [stdout] --> src/arch/ppu.rs:128:16 [INFO] [stdout] | [INFO] [stdout] 128 | static color_palettes: [[u8; 0x03]; 0x40] = [ [INFO] [stdout] | ^^^^^^^^^^^^^^ help: convert the identifier to upper case: `COLOR_PALETTES` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_upper_case_globals)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 23 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.51s [INFO] running `Command { std: "docker" "inspect" "0d610e99f855d14a21615a850044027af456227b4a56beb416b5024359f37e6d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "0d610e99f855d14a21615a850044027af456227b4a56beb416b5024359f37e6d", kill_on_drop: false }` [INFO] [stdout] 0d610e99f855d14a21615a850044027af456227b4a56beb416b5024359f37e6d