[INFO] cloning repository https://github.com/arora-aditya/just-another-ray-tracer [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/arora-aditya/just-another-ray-tracer" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Farora-aditya%2Fjust-another-ray-tracer", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Farora-aditya%2Fjust-another-ray-tracer'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 3e2d170c47330f795ca19a1109c4a7e6eb8118e7 [INFO] checking arora-aditya/just-another-ray-tracer against try#a7a572ce3edd6d476191fbfe92c9c1986e009b34 for pr-87190-3 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Farora-aditya%2Fjust-another-ray-tracer" "/workspace/builds/worker-2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/arora-aditya/just-another-ray-tracer on toolchain a7a572ce3edd6d476191fbfe92c9c1986e009b34 [INFO] running `Command { std: "/workspace/cargo-home/bin/cargo" "+a7a572ce3edd6d476191fbfe92c9c1986e009b34" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/arora-aditya/just-another-ray-tracer [INFO] finished tweaking git repo https://github.com/arora-aditya/just-another-ray-tracer [INFO] tweaked toml for git repo https://github.com/arora-aditya/just-another-ray-tracer written to /workspace/builds/worker-2/source/Cargo.toml [INFO] crate git repo https://github.com/arora-aditya/just-another-ray-tracer already has a lockfile, it will not be regenerated [INFO] running `Command { std: "/workspace/cargo-home/bin/cargo" "+a7a572ce3edd6d476191fbfe92c9c1986e009b34" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:34b6a614d2c27851fe6cbf88fbd1137609cefab8b10d0615aaeb6fd47975d74e" "/opt/rustwide/cargo-home/bin/cargo" "+a7a572ce3edd6d476191fbfe92c9c1986e009b34" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] ab4ae231f7e572c3682f94a1d737eb270d651b3b6edbe914b5292a92a2367837 [INFO] running `Command { std: "docker" "start" "-a" "ab4ae231f7e572c3682f94a1d737eb270d651b3b6edbe914b5292a92a2367837", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "ab4ae231f7e572c3682f94a1d737eb270d651b3b6edbe914b5292a92a2367837", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "ab4ae231f7e572c3682f94a1d737eb270d651b3b6edbe914b5292a92a2367837", kill_on_drop: false }` [INFO] [stdout] ab4ae231f7e572c3682f94a1d737eb270d651b3b6edbe914b5292a92a2367837 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:34b6a614d2c27851fe6cbf88fbd1137609cefab8b10d0615aaeb6fd47975d74e" "/opt/rustwide/cargo-home/bin/cargo" "+a7a572ce3edd6d476191fbfe92c9c1986e009b34" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 1b86a2d39ae16df04132947679f8e7a30c7df62cef9298b04b9c268883977343 [INFO] running `Command { std: "docker" "start" "-a" "1b86a2d39ae16df04132947679f8e7a30c7df62cef9298b04b9c268883977343", kill_on_drop: false }` [INFO] [stderr] Copying to /tmp/fixit [INFO] [stderr] Running `cargo fix --edition` [INFO] [stderr] Checking weezl v0.1.5 [INFO] [stderr] Checking byteorder v1.4.3 [INFO] [stderr] Checking adler v1.0.2 [INFO] [stderr] Compiling libm v0.2.1 [INFO] [stderr] Compiling miniz_oxide v0.4.4 [INFO] [stderr] Compiling crossbeam-utils v0.7.0 [INFO] [stderr] Compiling crossbeam-epoch v0.8.0 [INFO] [stderr] Checking c2-chacha v0.2.2 [INFO] [stderr] Compiling memoffset v0.5.3 [INFO] [stderr] Checking num_cpus v1.11.1 [INFO] [stderr] Checking getrandom v0.1.12 [INFO] [stderr] Checking rand_core v0.5.1 [INFO] [stderr] Checking deflate v0.8.6 [INFO] [stderr] Checking rand_chacha v0.2.1 [INFO] [stderr] Checking gif v0.11.2 [INFO] [stderr] Checking rand v0.7.2 [INFO] [stderr] Checking crossbeam-queue v0.2.0 [INFO] [stderr] Checking png v0.16.8 [INFO] [stderr] Checking crossbeam-deque v0.7.2 [INFO] [stderr] Checking rayon-core v1.6.1 [INFO] [stderr] Checking rayon v1.2.1 [INFO] [stderr] Checking jpeg-decoder v0.1.22 [INFO] [stderr] Checking tiff v0.6.1 [INFO] [stderr] Checking image v0.23.14 [INFO] [stderr] Checking ray-tracing-in-a-weekend v0.1.0 (/tmp/fixit) [INFO] [stderr] Migrating src/main.rs from 2018 edition to 2021 [INFO] [stdout] error[E0432]: unresolved import `super::vec3` [INFO] [stdout] --> src/tracer/ray.rs:50:9 [INFO] [stdout] | [INFO] [stdout] 50 | use super::vec3; [INFO] [stdout] | ^^^^^^^---- [INFO] [stdout] | | | [INFO] [stdout] | | help: a similar name exists in the module (notice the capitalization): `Vec3` [INFO] [stdout] | no `vec3` in `tracer::ray` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error[E0422]: cannot find struct, variant or union type `Vec3` in this scope [INFO] [stdout] --> src/tracer/ray.rs:57:20 [INFO] [stdout] | [INFO] [stdout] 57 | a: Vec3{e: [1.0, 0.0, 2.0]}, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] help: a struct with a similar name exists [INFO] [stdout] | [INFO] [stdout] 57 | a: Vec{e: [1.0, 0.0, 2.0]}, [INFO] [stdout] | ~~~ [INFO] [stdout] help: consider importing this struct [INFO] [stdout] | [INFO] [stdout] 50 | use crate::textures::image::Vec3; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error[E0422]: cannot find struct, variant or union type `Vec3` in this scope [INFO] [stdout] --> src/tracer/ray.rs:58:20 [INFO] [stdout] | [INFO] [stdout] 58 | b: Vec3{e: [4.0, 5.0, 6.0]}, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] help: a struct with a similar name exists [INFO] [stdout] | [INFO] [stdout] 58 | b: Vec{e: [4.0, 5.0, 6.0]}, [INFO] [stdout] | ~~~ [INFO] [stdout] help: consider importing this struct [INFO] [stdout] | [INFO] [stdout] 50 | use crate::textures::image::Vec3; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error[E0422]: cannot find struct, variant or union type `Vec3` in this scope [INFO] [stdout] --> src/tracer/ray.rs:60:13 [INFO] [stdout] | [INFO] [stdout] 60 | Vec3{e: [17.0, 20.0, 26.0]} [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] help: a struct with a similar name exists [INFO] [stdout] | [INFO] [stdout] 60 | Vec{e: [17.0, 20.0, 26.0]} [INFO] [stdout] | ~~~ [INFO] [stdout] help: consider importing this struct [INFO] [stdout] | [INFO] [stdout] 50 | use crate::textures::image::Vec3; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error[E0422]: cannot find struct, variant or union type `Vec3` in this scope [INFO] [stdout] --> src/tracer/ray.rs:68:20 [INFO] [stdout] | [INFO] [stdout] 68 | a: Vec3{e: [1.0, 0.0, 2.0]}, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] help: a struct with a similar name exists [INFO] [stdout] | [INFO] [stdout] 68 | a: Vec{e: [1.0, 0.0, 2.0]}, [INFO] [stdout] | ~~~ [INFO] [stdout] help: consider importing this struct [INFO] [stdout] | [INFO] [stdout] 50 | use crate::textures::image::Vec3; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error[E0422]: cannot find struct, variant or union type `Vec3` in this scope [INFO] [stdout] --> src/tracer/ray.rs:69:20 [INFO] [stdout] | [INFO] [stdout] 69 | b: Vec3{e: [4.0, 5.0, 6.0]}, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] help: a struct with a similar name exists [INFO] [stdout] | [INFO] [stdout] 69 | b: Vec{e: [4.0, 5.0, 6.0]}, [INFO] [stdout] | ~~~ [INFO] [stdout] help: consider importing this struct [INFO] [stdout] | [INFO] [stdout] 50 | use crate::textures::image::Vec3; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error[E0422]: cannot find struct, variant or union type `Vec3` in this scope [INFO] [stdout] --> src/tracer/ray.rs:71:13 [INFO] [stdout] | [INFO] [stdout] 71 | Vec3{e: [1.0, 0.0, 2.0]} [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] help: a struct with a similar name exists [INFO] [stdout] | [INFO] [stdout] 71 | Vec{e: [1.0, 0.0, 2.0]} [INFO] [stdout] | ~~~ [INFO] [stdout] help: consider importing this struct [INFO] [stdout] | [INFO] [stdout] 50 | use crate::textures::image::Vec3; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error[E0422]: cannot find struct, variant or union type `Vec3` in this scope [INFO] [stdout] --> src/tracer/ray.rs:79:20 [INFO] [stdout] | [INFO] [stdout] 79 | a: Vec3{e: [1.0, 0.0, 2.0]}, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] help: a struct with a similar name exists [INFO] [stdout] | [INFO] [stdout] 79 | a: Vec{e: [1.0, 0.0, 2.0]}, [INFO] [stdout] | ~~~ [INFO] [stdout] help: consider importing this struct [INFO] [stdout] | [INFO] [stdout] 50 | use crate::textures::image::Vec3; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error[E0422]: cannot find struct, variant or union type `Vec3` in this scope [INFO] [stdout] --> src/tracer/ray.rs:80:20 [INFO] [stdout] | [INFO] [stdout] 80 | b: Vec3{e: [4.0, 5.0, 6.0]}, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] help: a struct with a similar name exists [INFO] [stdout] | [INFO] [stdout] 80 | b: Vec{e: [4.0, 5.0, 6.0]}, [INFO] [stdout] | ~~~ [INFO] [stdout] help: consider importing this struct [INFO] [stdout] | [INFO] [stdout] 50 | use crate::textures::image::Vec3; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error[E0422]: cannot find struct, variant or union type `Vec3` in this scope [INFO] [stdout] --> src/tracer/ray.rs:82:13 [INFO] [stdout] | [INFO] [stdout] 82 | Vec3{e: [4.0, 5.0, 6.0]} [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] help: a struct with a similar name exists [INFO] [stdout] | [INFO] [stdout] 82 | Vec{e: [4.0, 5.0, 6.0]} [INFO] [stdout] | ~~~ [INFO] [stdout] help: consider importing this struct [INFO] [stdout] | [INFO] [stdout] 50 | use crate::textures::image::Vec3; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `self` [INFO] [stdout] --> src/render/mod.rs:7:26 [INFO] [stdout] | [INFO] [stdout] 7 | use crate::tracer::ray::{self, Ray}; [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `crate::material` [INFO] [stdout] --> src/render/mod.rs:12:5 [INFO] [stdout] | [INFO] [stdout] 12 | use crate::material; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `SphereThing` [INFO] [stdout] --> src/render/mod.rs:16:52 [INFO] [stdout] | [INFO] [stdout] 16 | use crate::objects::sphere::{Sphere, MovingSphere, SphereThing}; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `self` [INFO] [stdout] --> src/render/mod.rs:18:29 [INFO] [stdout] | [INFO] [stdout] 18 | use crate::camera::camera::{self, Camera}; [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `crate::textures::texture::Texture` [INFO] [stdout] --> src/render/mod.rs:19:5 [INFO] [stdout] | [INFO] [stdout] 19 | use crate::textures::texture::Texture; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/render/mod.rs:40:16 [INFO] [stdout] | [INFO] [stdout] 40 | if ((center-Vec3{e: [4.0,0.2,0.0]}).length() > 0.9) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Random` [INFO] [stdout] --> src/tracer/vec3.rs:13:26 [INFO] [stdout] | [INFO] [stdout] 13 | use crate::utils::{self, Random}; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around block return value [INFO] [stdout] --> src/tracer/vec3.rs:88:9 [INFO] [stdout] | [INFO] [stdout] 88 | (self.e[0]*self.e[0] + self.e[1]*self.e[1] + self.e[2]*self.e[2]) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `MulAssign` [INFO] [stdout] --> src/tracer/color.rs:1:48 [INFO] [stdout] | [INFO] [stdout] 1 | use std::ops::{Add, AddAssign, DivAssign, Mul, MulAssign}; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `core::borrow::Borrow` [INFO] [stdout] --> src/objects/hittable_list.rs:2:5 [INFO] [stdout] | [INFO] [stdout] 2 | use core::borrow::Borrow; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/objects/hittable_list.rs:27:12 [INFO] [stdout] | [INFO] [stdout] 27 | if (self.hitables.is_empty()){ [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/objects/sphere.rs:14:23 [INFO] [stdout] | [INFO] [stdout] 14 | pub material: Box, [INFO] [stdout] | ^^^^^^^^ help: use `dyn`: `dyn Material` [INFO] [stdout] | [INFO] [stdout] = note: `--force-warn bare-trait-objects` implied by `--force-warn rust-2021-compatibility` [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/objects/sphere.rs:19:57 [INFO] [stdout] | [INFO] [stdout] 19 | pub fn new(center: Vec3, radius: f32, material: Box) -> Sphere{ [INFO] [stdout] | ^^^^^^^^ help: use `dyn`: `dyn Material` [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/objects/sphere.rs:74:23 [INFO] [stdout] | [INFO] [stdout] 74 | pub material: Box, [INFO] [stdout] | ^^^^^^^^ help: use `dyn`: `dyn Material` [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `core::borrow::Borrow` [INFO] [stdout] --> src/objects/aabb.rs:3:5 [INFO] [stdout] | [INFO] [stdout] 3 | use core::borrow::Borrow; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `crate::objects::hittable::Hittable` [INFO] [stdout] --> src/objects/aabb.rs:7:5 [INFO] [stdout] | [INFO] [stdout] 7 | use crate::objects::hittable::Hittable; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `crate::objects::hittable::HitRecord` [INFO] [stdout] --> src/objects/aabb.rs:8:5 [INFO] [stdout] | [INFO] [stdout] 8 | use crate::objects::hittable::HitRecord; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `crate::material::metal::MetalMaterial` [INFO] [stdout] --> src/objects/aabb.rs:9:5 [INFO] [stdout] | [INFO] [stdout] 9 | use crate::material::metal::MetalMaterial; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/objects/aabb.rs:39:16 [INFO] [stdout] | [INFO] [stdout] 39 | if (inv_d < 0.0){ [INFO] [stdout] | ^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/objects/aabb.rs:42:29 [INFO] [stdout] | [INFO] [stdout] 42 | let t_min2 = if (t0 > t_min) { t0 } else { t_min }; [INFO] [stdout] | ^^^^^^^^^^^^ help: remove these parentheses [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/objects/aabb.rs:43:29 [INFO] [stdout] | [INFO] [stdout] 43 | let t_max2 = if (t1 < t_max) { t1 } else { t_max }; [INFO] [stdout] | ^^^^^^^^^^^^ help: remove these parentheses [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/objects/aabb.rs:44:16 [INFO] [stdout] | [INFO] [stdout] 44 | if (t_max2 <= t_min2){ [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `crate::tracer::vec3` [INFO] [stdout] --> src/objects/bvh_node.rs:6:5 [INFO] [stdout] | [INFO] [stdout] 6 | use crate::tracer::vec3; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `Vec3`, `self` [INFO] [stdout] --> src/material/base.rs:4:27 [INFO] [stdout] | [INFO] [stdout] 4 | use crate::tracer::vec3::{self, Vec3}; [INFO] [stdout] | ^^^^ ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `self` [INFO] [stdout] --> src/material/base.rs:5:20 [INFO] [stdout] | [INFO] [stdout] 5 | use crate::utils::{self, Random}; [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: patterns aren't allowed in functions without bodies [INFO] [stdout] --> src/material/base.rs:13:23 [INFO] [stdout] | [INFO] [stdout] 13 | fn scatter(&self, mut random: &mut Random, r_in: Ray, hit_record: HitRecord) -> Option; [INFO] [stdout] | ^^^^^^^^^^ help: remove `mut` from the parameter: `random` [INFO] [stdout] | [INFO] [stdout] = note: `#[deny(patterns_in_fns_without_body)]` on by default [INFO] [stdout] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release! [INFO] [stdout] = note: for more information, see issue #35203 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `self` [INFO] [stdout] --> src/material/dielectric.rs:7:20 [INFO] [stdout] | [INFO] [stdout] 7 | use crate::utils::{self, Random}; [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `crate::textures::perlin::Perlin` [INFO] [stdout] --> src/textures/image.rs:4:5 [INFO] [stdout] | [INFO] [stdout] 4 | use crate::textures::perlin::Perlin; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error[E0063]: missing field `_time` in initializer of `Ray` [INFO] [stdout] --> src/tracer/ray.rs:56:13 [INFO] [stdout] | [INFO] [stdout] 56 | Ray { [INFO] [stdout] | ^^^ missing `_time` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error[E0063]: missing field `_time` in initializer of `Ray` [INFO] [stdout] --> src/tracer/ray.rs:67:13 [INFO] [stdout] | [INFO] [stdout] 67 | Ray { [INFO] [stdout] | ^^^ missing `_time` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error[E0063]: missing field `_time` in initializer of `Ray` [INFO] [stdout] --> src/tracer/ray.rs:78:13 [INFO] [stdout] | [INFO] [stdout] 78 | Ray { [INFO] [stdout] | ^^^ missing `_time` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 14 previous errors; 27 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] Some errors have detailed explanations: E0063, E0422, E0432. [INFO] [stdout] [INFO] [stdout] For more information about an error, try `rustc --explain E0063`. [INFO] [stdout] [INFO] [stderr] error: could not compile `ray-tracing-in-a-weekend` due to 15 previous errors; 27 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: unused import: `self` [INFO] [stdout] --> src/render/mod.rs:7:26 [INFO] [stdout] | [INFO] [stdout] 7 | use crate::tracer::ray::{self, Ray}; [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `crate::material` [INFO] [stdout] --> src/render/mod.rs:12:5 [INFO] [stdout] | [INFO] [stdout] 12 | use crate::material; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `SphereThing` [INFO] [stdout] --> src/render/mod.rs:16:52 [INFO] [stdout] | [INFO] [stdout] 16 | use crate::objects::sphere::{Sphere, MovingSphere, SphereThing}; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `self` [INFO] [stdout] --> src/render/mod.rs:18:29 [INFO] [stdout] | [INFO] [stdout] 18 | use crate::camera::camera::{self, Camera}; [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `crate::textures::texture::Texture` [INFO] [stdout] --> src/render/mod.rs:19:5 [INFO] [stdout] | [INFO] [stdout] 19 | use crate::textures::texture::Texture; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/render/mod.rs:40:16 [INFO] [stdout] | [INFO] [stdout] 40 | if ((center-Vec3{e: [4.0,0.2,0.0]}).length() > 0.9) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Random` [INFO] [stdout] --> src/tracer/vec3.rs:13:26 [INFO] [stdout] | [INFO] [stdout] 13 | use crate::utils::{self, Random}; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around block return value [INFO] [stdout] --> src/tracer/vec3.rs:88:9 [INFO] [stdout] | [INFO] [stdout] 88 | (self.e[0]*self.e[0] + self.e[1]*self.e[1] + self.e[2]*self.e[2]) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `MulAssign` [INFO] [stdout] --> src/tracer/color.rs:1:48 [INFO] [stdout] | [INFO] [stdout] 1 | use std::ops::{Add, AddAssign, DivAssign, Mul, MulAssign}; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `core::borrow::Borrow` [INFO] [stdout] --> src/objects/hittable_list.rs:2:5 [INFO] [stdout] | [INFO] [stdout] 2 | use core::borrow::Borrow; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/objects/hittable_list.rs:27:12 [INFO] [stdout] | [INFO] [stdout] 27 | if (self.hitables.is_empty()){ [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/objects/sphere.rs:14:23 [INFO] [stdout] | [INFO] [stdout] 14 | pub material: Box, [INFO] [stdout] | ^^^^^^^^ help: use `dyn`: `dyn Material` [INFO] [stdout] | [INFO] [stdout] = note: `--force-warn bare-trait-objects` implied by `--force-warn rust-2021-compatibility` [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/objects/sphere.rs:19:57 [INFO] [stdout] | [INFO] [stdout] 19 | pub fn new(center: Vec3, radius: f32, material: Box) -> Sphere{ [INFO] [stdout] | ^^^^^^^^ help: use `dyn`: `dyn Material` [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/objects/sphere.rs:74:23 [INFO] [stdout] | [INFO] [stdout] 74 | pub material: Box, [INFO] [stdout] | ^^^^^^^^ help: use `dyn`: `dyn Material` [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `core::borrow::Borrow` [INFO] [stdout] --> src/objects/aabb.rs:3:5 [INFO] [stdout] | [INFO] [stdout] 3 | use core::borrow::Borrow; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `crate::objects::hittable::Hittable` [INFO] [stdout] --> src/objects/aabb.rs:7:5 [INFO] [stdout] | [INFO] [stdout] 7 | use crate::objects::hittable::Hittable; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `crate::objects::hittable::HitRecord` [INFO] [stdout] --> src/objects/aabb.rs:8:5 [INFO] [stdout] | [INFO] [stdout] 8 | use crate::objects::hittable::HitRecord; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `crate::material::metal::MetalMaterial` [INFO] [stdout] --> src/objects/aabb.rs:9:5 [INFO] [stdout] | [INFO] [stdout] 9 | use crate::material::metal::MetalMaterial; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/objects/aabb.rs:39:16 [INFO] [stdout] | [INFO] [stdout] 39 | if (inv_d < 0.0){ [INFO] [stdout] | ^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/objects/aabb.rs:42:29 [INFO] [stdout] | [INFO] [stdout] 42 | let t_min2 = if (t0 > t_min) { t0 } else { t_min }; [INFO] [stdout] | ^^^^^^^^^^^^ help: remove these parentheses [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/objects/aabb.rs:43:29 [INFO] [stdout] | [INFO] [stdout] 43 | let t_max2 = if (t1 < t_max) { t1 } else { t_max }; [INFO] [stdout] | ^^^^^^^^^^^^ help: remove these parentheses [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/objects/aabb.rs:44:16 [INFO] [stdout] | [INFO] [stdout] 44 | if (t_max2 <= t_min2){ [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `crate::tracer::vec3` [INFO] [stdout] --> src/objects/bvh_node.rs:6:5 [INFO] [stdout] | [INFO] [stdout] 6 | use crate::tracer::vec3; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `Vec3`, `self` [INFO] [stdout] --> src/material/base.rs:4:27 [INFO] [stdout] | [INFO] [stdout] 4 | use crate::tracer::vec3::{self, Vec3}; [INFO] [stdout] | ^^^^ ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `self` [INFO] [stdout] --> src/material/base.rs:5:20 [INFO] [stdout] | [INFO] [stdout] 5 | use crate::utils::{self, Random}; [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: patterns aren't allowed in functions without bodies [INFO] [stdout] --> src/material/base.rs:13:23 [INFO] [stdout] | [INFO] [stdout] 13 | fn scatter(&self, mut random: &mut Random, r_in: Ray, hit_record: HitRecord) -> Option; [INFO] [stdout] | ^^^^^^^^^^ help: remove `mut` from the parameter: `random` [INFO] [stdout] | [INFO] [stdout] = note: `#[deny(patterns_in_fns_without_body)]` on by default [INFO] [stdout] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release! [INFO] [stdout] = note: for more information, see issue #35203 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `self` [INFO] [stdout] --> src/material/dielectric.rs:7:20 [INFO] [stdout] | [INFO] [stdout] 7 | use crate::utils::{self, Random}; [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `crate::textures::perlin::Perlin` [INFO] [stdout] --> src/textures/image.rs:4:5 [INFO] [stdout] | [INFO] [stdout] 4 | use crate::textures::perlin::Perlin; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to previous error; 27 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: build failed [INFO] [stderr] error: failed to migrate to next edition [INFO] [stderr] [INFO] [stderr] Caused by: [INFO] [stderr] process didn't exit successfully: `cargo fix --edition --allow-no-vcs --allow-dirty --frozen --all --all-targets --message-format=json` (exit status: 101) [INFO] running `Command { std: "docker" "inspect" "1b86a2d39ae16df04132947679f8e7a30c7df62cef9298b04b9c268883977343", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "1b86a2d39ae16df04132947679f8e7a30c7df62cef9298b04b9c268883977343", kill_on_drop: false }` [INFO] [stdout] 1b86a2d39ae16df04132947679f8e7a30c7df62cef9298b04b9c268883977343