[INFO] cloning repository https://github.com/ISRAEL-DUFF/tfs [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/ISRAEL-DUFF/tfs" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FISRAEL-DUFF%2Ftfs", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FISRAEL-DUFF%2Ftfs'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] f789f2f3b43776982f61a9245c09b6055a5566ab [INFO] checking ISRAEL-DUFF/tfs against try#a7a572ce3edd6d476191fbfe92c9c1986e009b34 for pr-87190-3 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FISRAEL-DUFF%2Ftfs" "/workspace/builds/worker-10/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-10/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/ISRAEL-DUFF/tfs on toolchain a7a572ce3edd6d476191fbfe92c9c1986e009b34 [INFO] running `Command { std: "/workspace/cargo-home/bin/cargo" "+a7a572ce3edd6d476191fbfe92c9c1986e009b34" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/ISRAEL-DUFF/tfs [INFO] finished tweaking git repo https://github.com/ISRAEL-DUFF/tfs [INFO] tweaked toml for git repo https://github.com/ISRAEL-DUFF/tfs written to /workspace/builds/worker-10/source/Cargo.toml [INFO] crate git repo https://github.com/ISRAEL-DUFF/tfs already has a lockfile, it will not be regenerated [INFO] running `Command { std: "/workspace/cargo-home/bin/cargo" "+a7a572ce3edd6d476191fbfe92c9c1986e009b34" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-10/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-10/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:34b6a614d2c27851fe6cbf88fbd1137609cefab8b10d0615aaeb6fd47975d74e" "/opt/rustwide/cargo-home/bin/cargo" "+a7a572ce3edd6d476191fbfe92c9c1986e009b34" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 1390d51ac8e49e34e5a42b51eda4dd73f3ed1084b99deb755357ea0d969464f8 [INFO] running `Command { std: "docker" "start" "-a" "1390d51ac8e49e34e5a42b51eda4dd73f3ed1084b99deb755357ea0d969464f8", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "1390d51ac8e49e34e5a42b51eda4dd73f3ed1084b99deb755357ea0d969464f8", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "1390d51ac8e49e34e5a42b51eda4dd73f3ed1084b99deb755357ea0d969464f8", kill_on_drop: false }` [INFO] [stdout] 1390d51ac8e49e34e5a42b51eda4dd73f3ed1084b99deb755357ea0d969464f8 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-10/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-10/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:34b6a614d2c27851fe6cbf88fbd1137609cefab8b10d0615aaeb6fd47975d74e" "/opt/rustwide/cargo-home/bin/cargo" "+a7a572ce3edd6d476191fbfe92c9c1986e009b34" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] e476689ad052dd95b176909fc9f652e3932267e7b584b150c562b594d657b4e5 [INFO] running `Command { std: "docker" "start" "-a" "e476689ad052dd95b176909fc9f652e3932267e7b584b150c562b594d657b4e5", kill_on_drop: false }` [INFO] [stderr] Copying to /tmp/fixit [INFO] [stderr] Running `cargo fix --edition` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Checking disk v0.1.0 (/tmp/fixit) [INFO] [stderr] Migrating src/lib.rs from 2018 edition to 2021 [INFO] [stderr] Fixed src/tfs/types.rs (1 fix) [INFO] [stderr] Fixed src/tfs/mod.rs (6 fixes) [INFO] [stderr] Fixed src/tfs/disk.rs (3 fixes) [INFO] [stdout] warning: unreachable expression [INFO] [stdout] --> src/tfs/mod.rs:407:9 [INFO] [stdout] | [INFO] [stdout] 353 | / loop { [INFO] [stdout] 354 | | if bytes_read == length || j == length { [INFO] [stdout] 355 | | return bytes_read as i64; [INFO] [stdout] 356 | | } [INFO] [stdout] ... | [INFO] [stdout] 404 | | println!("BYTES INDEX: {}, {}", block_index, block_offset); [INFO] [stdout] 405 | | } [INFO] [stdout] | |_________- any code following this expression is unreachable [INFO] [stdout] 406 | [INFO] [stdout] 407 | -1 [INFO] [stdout] | ^^ unreachable expression [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unreachable_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unreachable expression [INFO] [stdout] --> src/tfs/mod.rs:533:9 [INFO] [stdout] | [INFO] [stdout] 507 | / loop { [INFO] [stdout] 508 | | if bytes_writen < length && (offset + bytes_writen) < data.len() { [INFO] [stdout] 509 | | let bytes_wr = self.write_to_block(block_num, block_offset, data, length - bytes_writen, offset + bytes_writen); [INFO] [stdout] 510 | | println!("bytes_writen: {}", bytes_wr); [INFO] [stdout] ... | [INFO] [stdout] 530 | | } [INFO] [stdout] 531 | | } [INFO] [stdout] | |_________- any code following this expression is unreachable [INFO] [stdout] 532 | [INFO] [stdout] 533 | bytes_writen as i64 [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ unreachable expression [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary `unsafe` block [INFO] [stdout] --> src/tfs/types.rs:90:9 [INFO] [stdout] | [INFO] [stdout] 90 | unsafe { [INFO] [stdout] | ^^^^^^ unnecessary `unsafe` block [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_unsafe)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary `unsafe` block [INFO] [stdout] --> src/tfs/types.rs:96:9 [INFO] [stdout] | [INFO] [stdout] 96 | unsafe { [INFO] [stdout] | ^^^^^^ unnecessary `unsafe` block [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary `unsafe` block [INFO] [stdout] --> src/tfs/types.rs:102:9 [INFO] [stdout] | [INFO] [stdout] 102 | unsafe { [INFO] [stdout] | ^^^^^^ unnecessary `unsafe` block [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary `unsafe` block [INFO] [stdout] --> src/tfs/types.rs:108:9 [INFO] [stdout] | [INFO] [stdout] 108 | unsafe { [INFO] [stdout] | ^^^^^^ unnecessary `unsafe` block [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function is never used: `as_u32_be` [INFO] [stdout] --> src/tfs/utility.rs:1:8 [INFO] [stdout] | [INFO] [stdout] 1 | pub fn as_u32_be(array: &[u8; 4]) -> u32 { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function is never used: `as_u32_le` [INFO] [stdout] --> src/tfs/utility.rs:8:8 [INFO] [stdout] | [INFO] [stdout] 8 | pub fn as_u32_le(array: &[u8; 4]) -> u32 { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function is never used: `as_u32` [INFO] [stdout] --> src/tfs/utility.rs:15:8 [INFO] [stdout] | [INFO] [stdout] 15 | pub fn as_u32(array: &[u8]) -> u32 { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `metaData` should have a snake case name [INFO] [stdout] --> src/tfs/mod.rs:9:9 [INFO] [stdout] | [INFO] [stdout] 9 | pub metaData: Option, [INFO] [stdout] | ^^^^^^^^ help: convert the identifier to snake case: `meta_data` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_snake_case)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `inodeBitMap` should have a snake case name [INFO] [stdout] --> src/tfs/mod.rs:10:9 [INFO] [stdout] | [INFO] [stdout] 10 | pub inodeBitMap: Option>, [INFO] [stdout] | ^^^^^^^^^^^ help: convert the identifier to snake case: `inode_bit_map` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `dataBitMap` should have a snake case name [INFO] [stdout] --> src/tfs/mod.rs:11:9 [INFO] [stdout] | [INFO] [stdout] 11 | pub dataBitMap: Option>, [INFO] [stdout] | ^^^^^^^^^^ help: convert the identifier to snake case: `data_bit_map` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `metaData` should have a snake case name [INFO] [stdout] --> src/tfs/mod.rs:54:18 [INFO] [stdout] | [INFO] [stdout] 54 | Some(metaData) => Self::debug_print(metaData), [INFO] [stdout] | ^^^^^^^^ help: convert the identifier to snake case: `meta_data` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `metaData` should have a snake case name [INFO] [stdout] --> src/tfs/mod.rs:60:13 [INFO] [stdout] | [INFO] [stdout] 60 | let metaData = Self::read_meta_data(disk); [INFO] [stdout] | ^^^^^^^^ help: convert the identifier to snake case: `meta_data` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `inodeTable` should have a snake case name [INFO] [stdout] --> src/tfs/mod.rs:66:13 [INFO] [stdout] | [INFO] [stdout] 66 | let inodeTable = &meta_data.inodeTable; [INFO] [stdout] | ^^^^^^^^^^ help: convert the identifier to snake case: `inode_table` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `metaData` should have a snake case name [INFO] [stdout] --> src/tfs/mod.rs:122:13 [INFO] [stdout] | [INFO] [stdout] 122 | let metaData = Self::read_meta_data(disk); [INFO] [stdout] | ^^^^^^^^ help: convert the identifier to snake case: `meta_data` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `metaData2` should have a snake case name [INFO] [stdout] --> src/tfs/mod.rs:123:13 [INFO] [stdout] | [INFO] [stdout] 123 | let metaData2 = Self::read_meta_data(disk); // ...have no idea how to make a copy [INFO] [stdout] | ^^^^^^^^^ help: convert the identifier to snake case: `meta_data2` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `nBlocks` should have a snake case name [INFO] [stdout] --> src/tfs/mod.rs:133:13 [INFO] [stdout] | [INFO] [stdout] 133 | let nBlocks = metaData.superBlock.Blocks; [INFO] [stdout] | ^^^^^^^ help: convert the identifier to snake case: `n_blocks` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `inodeBlocks` should have a snake case name [INFO] [stdout] --> src/tfs/mod.rs:134:13 [INFO] [stdout] | [INFO] [stdout] 134 | let inodeBlocks = metaData.superBlock.InodeBlocks; [INFO] [stdout] | ^^^^^^^^^^^ help: convert the identifier to snake case: `inode_blocks` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `metaData` should have a snake case name [INFO] [stdout] --> src/tfs/mod.rs:200:38 [INFO] [stdout] | [INFO] [stdout] 200 | ... Some(metaData) => { [INFO] [stdout] | ^^^^^^^^ help: convert the identifier to snake case: `meta_data` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `_metaData` should have a snake case name [INFO] [stdout] --> src/tfs/mod.rs:225:18 [INFO] [stdout] | [INFO] [stdout] 225 | Some(_metaData) => { [INFO] [stdout] | ^^^^^^^^^ help: convert the identifier to snake case: `_meta_data` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `metaData` should have a snake case name [INFO] [stdout] --> src/tfs/mod.rs:248:22 [INFO] [stdout] | [INFO] [stdout] 248 | Some(metaData) => { [INFO] [stdout] | ^^^^^^^^ help: convert the identifier to snake case: `meta_data` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `ibitMap` should have a snake case name [INFO] [stdout] --> src/tfs/mod.rs:257:22 [INFO] [stdout] | [INFO] [stdout] 257 | Some(ibitMap)=> { [INFO] [stdout] | ^^^^^^^ help: convert the identifier to snake case: `ibit_map` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `superBlock` should have a snake case name [INFO] [stdout] --> src/tfs/mod.rs:544:13 [INFO] [stdout] | [INFO] [stdout] 544 | let superBlock = block.superblock(); [INFO] [stdout] | ^^^^^^^^^^ help: convert the identifier to snake case: `super_block` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `inodeTable` should have a snake case name [INFO] [stdout] --> src/tfs/mod.rs:547:17 [INFO] [stdout] | [INFO] [stdout] 547 | let mut inodeTable = Vec::new(); [INFO] [stdout] | ^^^^^^^^^^ help: convert the identifier to snake case: `inode_table` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `metaData` should have a snake case name [INFO] [stdout] --> src/tfs/mod.rs:563:18 [INFO] [stdout] | [INFO] [stdout] 563 | Some(metaData) => { [INFO] [stdout] | ^^^^^^^^ help: convert the identifier to snake case: `meta_data` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `metaData` should have a snake case name [INFO] [stdout] --> src/tfs/mod.rs:581:18 [INFO] [stdout] | [INFO] [stdout] 581 | Some(metaData) => { [INFO] [stdout] | ^^^^^^^^ help: convert the identifier to snake case: `meta_data` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `metaData` should have a snake case name [INFO] [stdout] --> src/tfs/mod.rs:658:26 [INFO] [stdout] | [INFO] [stdout] 658 | Some(metaData) => { [INFO] [stdout] | ^^^^^^^^ help: convert the identifier to snake case: `meta_data` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `dataBitMap` should have a snake case name [INFO] [stdout] --> src/tfs/mod.rs:693:31 [INFO] [stdout] | [INFO] [stdout] 693 | let get_free_block = |dataBitMap: Option<&Vec>| { [INFO] [stdout] | ^^^^^^^^^^ help: convert the identifier to snake case: `data_bit_map` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `dataBitMap` should have a snake case name [INFO] [stdout] --> src/tfs/mod.rs:695:22 [INFO] [stdout] | [INFO] [stdout] 695 | Some(dataBitMap) => { [INFO] [stdout] | ^^^^^^^^^^ help: convert the identifier to snake case: `data_bit_map` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `dataBitMap` should have a snake case name [INFO] [stdout] --> src/tfs/mod.rs:718:22 [INFO] [stdout] | [INFO] [stdout] 718 | Some(dataBitMap) => { [INFO] [stdout] | ^^^^^^^^^^ help: convert the identifier to snake case: `data_bit_map` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `metaData` should have a snake case name [INFO] [stdout] --> src/tfs/mod.rs:725:22 [INFO] [stdout] | [INFO] [stdout] 725 | Some(metaData) => { [INFO] [stdout] | ^^^^^^^^ help: convert the identifier to snake case: `meta_data` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `FileDescriptor` should have a snake case name [INFO] [stdout] --> src/tfs/disk.rs:10:5 [INFO] [stdout] | [INFO] [stdout] 10 | FileDescriptor: Option, [INFO] [stdout] | ^^^^^^^^^^^^^^ help: convert the identifier to snake case: `file_descriptor` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `Blocks` should have a snake case name [INFO] [stdout] --> src/tfs/disk.rs:11:5 [INFO] [stdout] | [INFO] [stdout] 11 | Blocks: usize, // Number of blocks in disk image [INFO] [stdout] | ^^^^^^ help: convert the identifier to snake case: `blocks` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `Reads` should have a snake case name [INFO] [stdout] --> src/tfs/disk.rs:12:5 [INFO] [stdout] | [INFO] [stdout] 12 | Reads: usize, // Number of reads performed [INFO] [stdout] | ^^^^^ help: convert the identifier to snake case: `reads` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `Writes` should have a snake case name [INFO] [stdout] --> src/tfs/disk.rs:13:5 [INFO] [stdout] | [INFO] [stdout] 13 | Writes: usize, // Number of writes performed [INFO] [stdout] | ^^^^^^ help: convert the identifier to snake case (notice the capitalization): `writes` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `Mounts` should have a snake case name [INFO] [stdout] --> src/tfs/disk.rs:14:5 [INFO] [stdout] | [INFO] [stdout] 14 | Mounts: usize, // Number of mounts [INFO] [stdout] | ^^^^^^ help: convert the identifier to snake case: `mounts` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `Path` should have a snake case name [INFO] [stdout] --> src/tfs/disk.rs:15:5 [INFO] [stdout] | [INFO] [stdout] 15 | Path: &'a str // file path for the disk [INFO] [stdout] | ^^^^ help: convert the identifier to snake case: `path` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison is useless due to type limits [INFO] [stdout] --> src/tfs/disk.rs:21:12 [INFO] [stdout] | [INFO] [stdout] 21 | if blocknum < 0 { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_comparisons)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/tfs/disk.rs:68:17 [INFO] [stdout] | [INFO] [stdout] 68 | f.set_len((nblocks as u64) * (Self::BLOCK_SIZE as u64)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/tfs/disk.rs:105:17 [INFO] [stdout] | [INFO] [stdout] 105 | file.seek(SeekFrom::Start( blocknum as u64 * Self::BLOCK_SIZE as u64)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/tfs/disk.rs:106:17 [INFO] [stdout] | [INFO] [stdout] 106 | file.read(data); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/tfs/disk.rs:117:17 [INFO] [stdout] | [INFO] [stdout] 117 | file.seek(SeekFrom::Start(blocknum as u64 * Self::BLOCK_SIZE as u64)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/tfs/disk.rs:118:17 [INFO] [stdout] | [INFO] [stdout] 118 | file.write(data); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `MagicNumber` should have a snake case name [INFO] [stdout] --> src/tfs/types.rs:13:9 [INFO] [stdout] | [INFO] [stdout] 13 | pub MagicNumber: u32, [INFO] [stdout] | ^^^^^^^^^^^ help: convert the identifier to snake case: `magic_number` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `Blocks` should have a snake case name [INFO] [stdout] --> src/tfs/types.rs:14:9 [INFO] [stdout] | [INFO] [stdout] 14 | pub Blocks: u32, [INFO] [stdout] | ^^^^^^ help: convert the identifier to snake case: `blocks` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `InodeBlocks` should have a snake case name [INFO] [stdout] --> src/tfs/types.rs:15:9 [INFO] [stdout] | [INFO] [stdout] 15 | pub InodeBlocks: u32, [INFO] [stdout] | ^^^^^^^^^^^ help: convert the identifier to snake case: `inode_blocks` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `Inodes` should have a snake case name [INFO] [stdout] --> src/tfs/types.rs:16:9 [INFO] [stdout] | [INFO] [stdout] 16 | pub Inodes: u32 [INFO] [stdout] | ^^^^^^ help: convert the identifier to snake case (notice the capitalization): `inodes` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `Valid` should have a snake case name [INFO] [stdout] --> src/tfs/types.rs:22:9 [INFO] [stdout] | [INFO] [stdout] 22 | pub Valid: u32, // whether or not inode is valid (or allocated) [INFO] [stdout] | ^^^^^ help: convert the identifier to snake case (notice the capitalization): `valid` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `Size` should have a snake case name [INFO] [stdout] --> src/tfs/types.rs:23:9 [INFO] [stdout] | [INFO] [stdout] 23 | pub Size: u32, // size of file [INFO] [stdout] | ^^^^ help: convert the identifier to snake case (notice the capitalization): `size` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `Direct` should have a snake case name [INFO] [stdout] --> src/tfs/types.rs:24:9 [INFO] [stdout] | [INFO] [stdout] 24 | pub Direct: [u32; POINTERS_PER_INODE], [INFO] [stdout] | ^^^^^^ help: convert the identifier to snake case: `direct` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `Indirect` should have a snake case name [INFO] [stdout] --> src/tfs/types.rs:25:9 [INFO] [stdout] | [INFO] [stdout] 25 | pub Indirect: u32 [INFO] [stdout] | ^^^^^^^^ help: convert the identifier to snake case (notice the capitalization): `indirect` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `Super` should have a snake case name [INFO] [stdout] --> src/tfs/types.rs:31:9 [INFO] [stdout] | [INFO] [stdout] 31 | pub Super: Superblock, [INFO] [stdout] | ^^^^^ help: rename the identifier [INFO] [stdout] | [INFO] [stdout] = note: `super` cannot be used as a raw identifier [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `Inodes` should have a snake case name [INFO] [stdout] --> src/tfs/types.rs:32:9 [INFO] [stdout] | [INFO] [stdout] 32 | pub Inodes: [Inode; INODES_PER_BLOCK], [INFO] [stdout] | ^^^^^^ help: convert the identifier to snake case (notice the capitalization): `inodes` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `Pointers` should have a snake case name [INFO] [stdout] --> src/tfs/types.rs:33:9 [INFO] [stdout] | [INFO] [stdout] 33 | pub Pointers: [u32; POINTERS_PER_BLOCK], [INFO] [stdout] | ^^^^^^^^ help: convert the identifier to snake case: `pointers` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `Data` should have a snake case name [INFO] [stdout] --> src/tfs/types.rs:34:9 [INFO] [stdout] | [INFO] [stdout] 34 | pub Data: [u8; Disk::BLOCK_SIZE] [INFO] [stdout] | ^^^^ help: convert the identifier to snake case: `data` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `superBlock` should have a snake case name [INFO] [stdout] --> src/tfs/types.rs:40:9 [INFO] [stdout] | [INFO] [stdout] 40 | pub superBlock: Superblock, [INFO] [stdout] | ^^^^^^^^^^ help: convert the identifier to snake case: `super_block` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `inodeTable` should have a snake case name [INFO] [stdout] --> src/tfs/types.rs:41:9 [INFO] [stdout] | [INFO] [stdout] 41 | pub inodeTable: Vec<[Inode; INODES_PER_BLOCK]> [INFO] [stdout] | ^^^^^^^^^^ help: convert the identifier to snake case: `inode_table` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 58 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Fixed src/tfs/mod.rs (2 fixes) [INFO] [stderr] Migrating src/main.rs from 2018 edition to 2021 [INFO] [stdout] warning: unreachable expression [INFO] [stdout] --> src/tfs/mod.rs:407:9 [INFO] [stdout] | [INFO] [stdout] 353 | / loop { [INFO] [stdout] 354 | | if bytes_read == length || j == length { [INFO] [stdout] 355 | | return bytes_read as i64; [INFO] [stdout] 356 | | } [INFO] [stdout] ... | [INFO] [stdout] 404 | | println!("BYTES INDEX: {}, {}", block_index, block_offset); [INFO] [stdout] 405 | | } [INFO] [stdout] | |_________- any code following this expression is unreachable [INFO] [stdout] 406 | [INFO] [stdout] 407 | -1 [INFO] [stdout] | ^^ unreachable expression [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unreachable_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unreachable expression [INFO] [stdout] --> src/tfs/mod.rs:533:9 [INFO] [stdout] | [INFO] [stdout] 507 | / loop { [INFO] [stdout] 508 | | if bytes_writen < length && (offset + bytes_writen) < data.len() { [INFO] [stdout] 509 | | let bytes_wr = self.write_to_block(block_num, block_offset, data, length - bytes_writen, offset + bytes_writen); [INFO] [stdout] 510 | | println!("bytes_writen: {}", bytes_wr); [INFO] [stdout] ... | [INFO] [stdout] 530 | | } [INFO] [stdout] 531 | | } [INFO] [stdout] | |_________- any code following this expression is unreachable [INFO] [stdout] 532 | [INFO] [stdout] 533 | bytes_writen as i64 [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ unreachable expression [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary `unsafe` block [INFO] [stdout] --> src/tfs/types.rs:90:9 [INFO] [stdout] | [INFO] [stdout] 90 | unsafe { [INFO] [stdout] | ^^^^^^ unnecessary `unsafe` block [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_unsafe)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary `unsafe` block [INFO] [stdout] --> src/tfs/types.rs:96:9 [INFO] [stdout] | [INFO] [stdout] 96 | unsafe { [INFO] [stdout] | ^^^^^^ unnecessary `unsafe` block [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary `unsafe` block [INFO] [stdout] --> src/tfs/types.rs:102:9 [INFO] [stdout] | [INFO] [stdout] 102 | unsafe { [INFO] [stdout] | ^^^^^^ unnecessary `unsafe` block [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary `unsafe` block [INFO] [stdout] --> src/tfs/types.rs:108:9 [INFO] [stdout] | [INFO] [stdout] 108 | unsafe { [INFO] [stdout] | ^^^^^^ unnecessary `unsafe` block [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function is never used: `disk_open` [INFO] [stdout] --> src/tfs/disk.rs:132:8 [INFO] [stdout] | [INFO] [stdout] 132 | fn disk_open() { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function is never used: `disk_read_write` [INFO] [stdout] --> src/tfs/disk.rs:139:8 [INFO] [stdout] | [INFO] [stdout] 139 | fn disk_read_write() { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function is never used: `disk_clone` [INFO] [stdout] --> src/tfs/disk.rs:152:8 [INFO] [stdout] | [INFO] [stdout] 152 | fn disk_clone() { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function is never used: `as_u32_be` [INFO] [stdout] --> src/tfs/utility.rs:1:8 [INFO] [stdout] | [INFO] [stdout] 1 | pub fn as_u32_be(array: &[u8; 4]) -> u32 { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function is never used: `as_u32_le` [INFO] [stdout] --> src/tfs/utility.rs:8:8 [INFO] [stdout] | [INFO] [stdout] 8 | pub fn as_u32_le(array: &[u8; 4]) -> u32 { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function is never used: `as_u32` [INFO] [stdout] --> src/tfs/utility.rs:15:8 [INFO] [stdout] | [INFO] [stdout] 15 | pub fn as_u32(array: &[u8]) -> u32 { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function is never used: `test_debug` [INFO] [stdout] --> src/tfs/mod.rs:795:8 [INFO] [stdout] | [INFO] [stdout] 795 | fn test_debug() { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function is never used: `test_format` [INFO] [stdout] --> src/tfs/mod.rs:805:8 [INFO] [stdout] | [INFO] [stdout] 805 | fn test_format() { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function is never used: `test_mount` [INFO] [stdout] --> src/tfs/mod.rs:813:8 [INFO] [stdout] | [INFO] [stdout] 813 | fn test_mount() { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function is never used: `test_create_remove_inode` [INFO] [stdout] --> src/tfs/mod.rs:821:8 [INFO] [stdout] | [INFO] [stdout] 821 | fn test_create_remove_inode() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `metaData` should have a snake case name [INFO] [stdout] --> src/tfs/mod.rs:9:9 [INFO] [stdout] | [INFO] [stdout] 9 | pub metaData: Option, [INFO] [stdout] | ^^^^^^^^ help: convert the identifier to snake case: `meta_data` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_snake_case)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `inodeBitMap` should have a snake case name [INFO] [stdout] --> src/tfs/mod.rs:10:9 [INFO] [stdout] | [INFO] [stdout] 10 | pub inodeBitMap: Option>, [INFO] [stdout] | ^^^^^^^^^^^ help: convert the identifier to snake case: `inode_bit_map` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `dataBitMap` should have a snake case name [INFO] [stdout] --> src/tfs/mod.rs:11:9 [INFO] [stdout] | [INFO] [stdout] 11 | pub dataBitMap: Option>, [INFO] [stdout] | ^^^^^^^^^^ help: convert the identifier to snake case: `data_bit_map` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `metaData` should have a snake case name [INFO] [stdout] --> src/tfs/mod.rs:54:18 [INFO] [stdout] | [INFO] [stdout] 54 | Some(metaData) => Self::debug_print(metaData), [INFO] [stdout] | ^^^^^^^^ help: convert the identifier to snake case: `meta_data` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `metaData` should have a snake case name [INFO] [stdout] --> src/tfs/mod.rs:60:13 [INFO] [stdout] | [INFO] [stdout] 60 | let metaData = Self::read_meta_data(disk); [INFO] [stdout] | ^^^^^^^^ help: convert the identifier to snake case: `meta_data` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `inodeTable` should have a snake case name [INFO] [stdout] --> src/tfs/mod.rs:66:13 [INFO] [stdout] | [INFO] [stdout] 66 | let inodeTable = &meta_data.inodeTable; [INFO] [stdout] | ^^^^^^^^^^ help: convert the identifier to snake case: `inode_table` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `metaData` should have a snake case name [INFO] [stdout] --> src/tfs/mod.rs:122:13 [INFO] [stdout] | [INFO] [stdout] 122 | let metaData = Self::read_meta_data(disk); [INFO] [stdout] | ^^^^^^^^ help: convert the identifier to snake case: `meta_data` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `metaData2` should have a snake case name [INFO] [stdout] --> src/tfs/mod.rs:123:13 [INFO] [stdout] | [INFO] [stdout] 123 | let metaData2 = Self::read_meta_data(disk); // ...have no idea how to make a copy [INFO] [stdout] | ^^^^^^^^^ help: convert the identifier to snake case: `meta_data2` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `nBlocks` should have a snake case name [INFO] [stdout] --> src/tfs/mod.rs:133:13 [INFO] [stdout] | [INFO] [stdout] 133 | let nBlocks = metaData.superBlock.Blocks; [INFO] [stdout] | ^^^^^^^ help: convert the identifier to snake case: `n_blocks` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `inodeBlocks` should have a snake case name [INFO] [stdout] --> src/tfs/mod.rs:134:13 [INFO] [stdout] | [INFO] [stdout] 134 | let inodeBlocks = metaData.superBlock.InodeBlocks; [INFO] [stdout] | ^^^^^^^^^^^ help: convert the identifier to snake case: `inode_blocks` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `metaData` should have a snake case name [INFO] [stdout] --> src/tfs/mod.rs:200:38 [INFO] [stdout] | [INFO] [stdout] 200 | ... Some(metaData) => { [INFO] [stdout] | ^^^^^^^^ help: convert the identifier to snake case: `meta_data` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `_metaData` should have a snake case name [INFO] [stdout] --> src/tfs/mod.rs:225:18 [INFO] [stdout] | [INFO] [stdout] 225 | Some(_metaData) => { [INFO] [stdout] | ^^^^^^^^^ help: convert the identifier to snake case: `_meta_data` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `metaData` should have a snake case name [INFO] [stdout] --> src/tfs/mod.rs:248:22 [INFO] [stdout] | [INFO] [stdout] 248 | Some(metaData) => { [INFO] [stdout] | ^^^^^^^^ help: convert the identifier to snake case: `meta_data` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `ibitMap` should have a snake case name [INFO] [stdout] --> src/tfs/mod.rs:257:22 [INFO] [stdout] | [INFO] [stdout] 257 | Some(ibitMap)=> { [INFO] [stdout] | ^^^^^^^ help: convert the identifier to snake case: `ibit_map` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `superBlock` should have a snake case name [INFO] [stdout] --> src/tfs/mod.rs:544:13 [INFO] [stdout] | [INFO] [stdout] 544 | let superBlock = block.superblock(); [INFO] [stdout] | ^^^^^^^^^^ help: convert the identifier to snake case: `super_block` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `inodeTable` should have a snake case name [INFO] [stdout] --> src/tfs/mod.rs:547:17 [INFO] [stdout] | [INFO] [stdout] 547 | let mut inodeTable = Vec::new(); [INFO] [stdout] | ^^^^^^^^^^ help: convert the identifier to snake case: `inode_table` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `metaData` should have a snake case name [INFO] [stdout] --> src/tfs/mod.rs:563:18 [INFO] [stdout] | [INFO] [stdout] 563 | Some(metaData) => { [INFO] [stdout] | ^^^^^^^^ help: convert the identifier to snake case: `meta_data` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `metaData` should have a snake case name [INFO] [stdout] --> src/tfs/mod.rs:581:18 [INFO] [stdout] | [INFO] [stdout] 581 | Some(metaData) => { [INFO] [stdout] | ^^^^^^^^ help: convert the identifier to snake case: `meta_data` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `metaData` should have a snake case name [INFO] [stdout] --> src/tfs/mod.rs:658:26 [INFO] [stdout] | [INFO] [stdout] 658 | Some(metaData) => { [INFO] [stdout] | ^^^^^^^^ help: convert the identifier to snake case: `meta_data` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `dataBitMap` should have a snake case name [INFO] [stdout] --> src/tfs/mod.rs:693:31 [INFO] [stdout] | [INFO] [stdout] 693 | let get_free_block = |dataBitMap: Option<&Vec>| { [INFO] [stdout] | ^^^^^^^^^^ help: convert the identifier to snake case: `data_bit_map` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `dataBitMap` should have a snake case name [INFO] [stdout] --> src/tfs/mod.rs:695:22 [INFO] [stdout] | [INFO] [stdout] 695 | Some(dataBitMap) => { [INFO] [stdout] | ^^^^^^^^^^ help: convert the identifier to snake case: `data_bit_map` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `dataBitMap` should have a snake case name [INFO] [stdout] --> src/tfs/mod.rs:718:22 [INFO] [stdout] | [INFO] [stdout] 718 | Some(dataBitMap) => { [INFO] [stdout] | ^^^^^^^^^^ help: convert the identifier to snake case: `data_bit_map` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `metaData` should have a snake case name [INFO] [stdout] --> src/tfs/mod.rs:725:22 [INFO] [stdout] | [INFO] [stdout] 725 | Some(metaData) => { [INFO] [stdout] | ^^^^^^^^ help: convert the identifier to snake case: `meta_data` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `FileDescriptor` should have a snake case name [INFO] [stdout] --> src/tfs/disk.rs:10:5 [INFO] [stdout] | [INFO] [stdout] 10 | FileDescriptor: Option, [INFO] [stdout] | ^^^^^^^^^^^^^^ help: convert the identifier to snake case: `file_descriptor` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `Blocks` should have a snake case name [INFO] [stdout] --> src/tfs/disk.rs:11:5 [INFO] [stdout] | [INFO] [stdout] 11 | Blocks: usize, // Number of blocks in disk image [INFO] [stdout] | ^^^^^^ help: convert the identifier to snake case: `blocks` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `Reads` should have a snake case name [INFO] [stdout] --> src/tfs/disk.rs:12:5 [INFO] [stdout] | [INFO] [stdout] 12 | Reads: usize, // Number of reads performed [INFO] [stdout] | ^^^^^ help: convert the identifier to snake case: `reads` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `Writes` should have a snake case name [INFO] [stdout] --> src/tfs/disk.rs:13:5 [INFO] [stdout] | [INFO] [stdout] 13 | Writes: usize, // Number of writes performed [INFO] [stdout] | ^^^^^^ help: convert the identifier to snake case (notice the capitalization): `writes` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `Mounts` should have a snake case name [INFO] [stdout] --> src/tfs/disk.rs:14:5 [INFO] [stdout] | [INFO] [stdout] 14 | Mounts: usize, // Number of mounts [INFO] [stdout] | ^^^^^^ help: convert the identifier to snake case: `mounts` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `Path` should have a snake case name [INFO] [stdout] --> src/tfs/disk.rs:15:5 [INFO] [stdout] | [INFO] [stdout] 15 | Path: &'a str // file path for the disk [INFO] [stdout] | ^^^^ help: convert the identifier to snake case: `path` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison is useless due to type limits [INFO] [stdout] --> src/tfs/disk.rs:21:12 [INFO] [stdout] | [INFO] [stdout] 21 | if blocknum < 0 { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_comparisons)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/tfs/disk.rs:68:17 [INFO] [stdout] | [INFO] [stdout] 68 | f.set_len((nblocks as u64) * (Self::BLOCK_SIZE as u64)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/tfs/disk.rs:105:17 [INFO] [stdout] | [INFO] [stdout] 105 | file.seek(SeekFrom::Start( blocknum as u64 * Self::BLOCK_SIZE as u64)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/tfs/disk.rs:106:17 [INFO] [stdout] | [INFO] [stdout] 106 | file.read(data); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/tfs/disk.rs:117:17 [INFO] [stdout] | [INFO] [stdout] 117 | file.seek(SeekFrom::Start(blocknum as u64 * Self::BLOCK_SIZE as u64)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/tfs/disk.rs:118:17 [INFO] [stdout] | [INFO] [stdout] 118 | file.write(data); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `MagicNumber` should have a snake case name [INFO] [stdout] --> src/tfs/types.rs:13:9 [INFO] [stdout] | [INFO] [stdout] 13 | pub MagicNumber: u32, [INFO] [stdout] | ^^^^^^^^^^^ help: convert the identifier to snake case: `magic_number` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `Blocks` should have a snake case name [INFO] [stdout] --> src/tfs/types.rs:14:9 [INFO] [stdout] | [INFO] [stdout] 14 | pub Blocks: u32, [INFO] [stdout] | ^^^^^^ help: convert the identifier to snake case: `blocks` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `InodeBlocks` should have a snake case name [INFO] [stdout] --> src/tfs/types.rs:15:9 [INFO] [stdout] | [INFO] [stdout] 15 | pub InodeBlocks: u32, [INFO] [stdout] | ^^^^^^^^^^^ help: convert the identifier to snake case: `inode_blocks` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `Inodes` should have a snake case name [INFO] [stdout] --> src/tfs/types.rs:16:9 [INFO] [stdout] | [INFO] [stdout] 16 | pub Inodes: u32 [INFO] [stdout] | ^^^^^^ help: convert the identifier to snake case (notice the capitalization): `inodes` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `Valid` should have a snake case name [INFO] [stdout] --> src/tfs/types.rs:22:9 [INFO] [stdout] | [INFO] [stdout] 22 | pub Valid: u32, // whether or not inode is valid (or allocated) [INFO] [stdout] | ^^^^^ help: convert the identifier to snake case (notice the capitalization): `valid` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `Size` should have a snake case name [INFO] [stdout] --> src/tfs/types.rs:23:9 [INFO] [stdout] | [INFO] [stdout] 23 | pub Size: u32, // size of file [INFO] [stdout] | ^^^^ help: convert the identifier to snake case (notice the capitalization): `size` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `Direct` should have a snake case name [INFO] [stdout] --> src/tfs/types.rs:24:9 [INFO] [stdout] | [INFO] [stdout] 24 | pub Direct: [u32; POINTERS_PER_INODE], [INFO] [stdout] | ^^^^^^ help: convert the identifier to snake case: `direct` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `Indirect` should have a snake case name [INFO] [stdout] --> src/tfs/types.rs:25:9 [INFO] [stdout] | [INFO] [stdout] 25 | pub Indirect: u32 [INFO] [stdout] | ^^^^^^^^ help: convert the identifier to snake case (notice the capitalization): `indirect` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `Super` should have a snake case name [INFO] [stdout] --> src/tfs/types.rs:31:9 [INFO] [stdout] | [INFO] [stdout] 31 | pub Super: Superblock, [INFO] [stdout] | ^^^^^ help: rename the identifier [INFO] [stdout] | [INFO] [stdout] = note: `super` cannot be used as a raw identifier [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `Inodes` should have a snake case name [INFO] [stdout] --> src/tfs/types.rs:32:9 [INFO] [stdout] | [INFO] [stdout] 32 | pub Inodes: [Inode; INODES_PER_BLOCK], [INFO] [stdout] | ^^^^^^ help: convert the identifier to snake case (notice the capitalization): `inodes` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `Pointers` should have a snake case name [INFO] [stdout] --> src/tfs/types.rs:33:9 [INFO] [stdout] | [INFO] [stdout] 33 | pub Pointers: [u32; POINTERS_PER_BLOCK], [INFO] [stdout] | ^^^^^^^^ help: convert the identifier to snake case: `pointers` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `Data` should have a snake case name [INFO] [stdout] --> src/tfs/types.rs:34:9 [INFO] [stdout] | [INFO] [stdout] 34 | pub Data: [u8; Disk::BLOCK_SIZE] [INFO] [stdout] | ^^^^ help: convert the identifier to snake case: `data` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `superBlock` should have a snake case name [INFO] [stdout] --> src/tfs/types.rs:40:9 [INFO] [stdout] | [INFO] [stdout] 40 | pub superBlock: Superblock, [INFO] [stdout] | ^^^^^^^^^^ help: convert the identifier to snake case: `super_block` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `inodeTable` should have a snake case name [INFO] [stdout] --> src/tfs/types.rs:41:9 [INFO] [stdout] | [INFO] [stdout] 41 | pub inodeTable: Vec<[Inode; INODES_PER_BLOCK]> [INFO] [stdout] | ^^^^^^^^^^ help: convert the identifier to snake case: `inode_table` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 65 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Fixed src/main.rs (13 fixes) [INFO] [stdout] warning: comparison is useless due to type limits [INFO] [stdout] --> src/main.rs:157:16 [INFO] [stdout] | [INFO] [stdout] 157 | if inumber >= 0 { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_comparisons)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/main.rs:282:9 [INFO] [stdout] | [INFO] [stdout] 282 | file.seek(SeekFrom::Start( n as u64 * Disk::BLOCK_SIZE as u64)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/main.rs:315:13 [INFO] [stdout] | [INFO] [stdout] 315 | file.write(&mut buff); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/main.rs:317:13 [INFO] [stdout] | [INFO] [stdout] 317 | file.write(&mut buffer); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison is useless due to type limits [INFO] [stdout] --> src/main.rs:157:16 [INFO] [stdout] | [INFO] [stdout] 157 | if inumber >= 0 { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_comparisons)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/main.rs:282:9 [INFO] [stdout] | [INFO] [stdout] 282 | file.seek(SeekFrom::Start( n as u64 * Disk::BLOCK_SIZE as u64)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/main.rs:315:13 [INFO] [stdout] | [INFO] [stdout] 315 | file.write(&mut buff); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/main.rs:317:13 [INFO] [stdout] | [INFO] [stdout] 317 | file.write(&mut buffer); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 4 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 4 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 21.40s [INFO] [stderr] Running `cargo check` to verify 2021 [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Checking disk v0.1.0 (/tmp/fixit) [INFO] [stdout] warning: unreachable expression [INFO] [stdout] --> src/tfs/mod.rs:407:9 [INFO] [stdout] | [INFO] [stdout] 353 | / loop { [INFO] [stdout] 354 | | if bytes_read == length || j == length { [INFO] [stdout] 355 | | return bytes_read as i64; [INFO] [stdout] 356 | | } [INFO] [stdout] ... | [INFO] [stdout] 404 | | println!("BYTES INDEX: {}, {}", block_index, block_offset); [INFO] [stdout] 405 | | } [INFO] [stdout] | |_________- any code following this expression is unreachable [INFO] [stdout] 406 | [INFO] [stdout] 407 | -1 [INFO] [stdout] | ^^ unreachable expression [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unreachable_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unreachable expression [INFO] [stdout] --> src/tfs/mod.rs:533:9 [INFO] [stdout] | [INFO] [stdout] 507 | / loop { [INFO] [stdout] 508 | | if bytes_writen < length && (offset + bytes_writen) < data.len() { [INFO] [stdout] 509 | | let bytes_wr = self.write_to_block(block_num, block_offset, data, length - bytes_writen, offset + bytes_writen); [INFO] [stdout] 510 | | println!("bytes_writen: {}", bytes_wr); [INFO] [stdout] ... | [INFO] [stdout] 530 | | } [INFO] [stdout] 531 | | } [INFO] [stdout] | |_________- any code following this expression is unreachable [INFO] [stdout] 532 | [INFO] [stdout] 533 | bytes_writen as i64 [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ unreachable expression [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unreachable expression [INFO] [stdout] --> src/tfs/mod.rs:407:9 [INFO] [stdout] | [INFO] [stdout] 353 | / loop { [INFO] [stdout] 354 | | if bytes_read == length || j == length { [INFO] [stdout] 355 | | return bytes_read as i64; [INFO] [stdout] 356 | | } [INFO] [stdout] ... | [INFO] [stdout] 404 | | println!("BYTES INDEX: {}, {}", block_index, block_offset); [INFO] [stdout] 405 | | } [INFO] [stdout] | |_________- any code following this expression is unreachable [INFO] [stdout] 406 | [INFO] [stdout] 407 | -1 [INFO] [stdout] | ^^ unreachable expression [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unreachable_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unreachable expression [INFO] [stdout] --> src/tfs/mod.rs:533:9 [INFO] [stdout] | [INFO] [stdout] 507 | / loop { [INFO] [stdout] 508 | | if bytes_writen < length && (offset + bytes_writen) < data.len() { [INFO] [stdout] 509 | | let bytes_wr = self.write_to_block(block_num, block_offset, data, length - bytes_writen, offset + bytes_writen); [INFO] [stdout] 510 | | println!("bytes_writen: {}", bytes_wr); [INFO] [stdout] ... | [INFO] [stdout] 530 | | } [INFO] [stdout] 531 | | } [INFO] [stdout] | |_________- any code following this expression is unreachable [INFO] [stdout] 532 | [INFO] [stdout] 533 | bytes_writen as i64 [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ unreachable expression [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary `unsafe` block [INFO] [stdout] --> src/tfs/types.rs:90:9 [INFO] [stdout] | [INFO] [stdout] 90 | unsafe { [INFO] [stdout] | ^^^^^^ unnecessary `unsafe` block [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_unsafe)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary `unsafe` block [INFO] [stdout] --> src/tfs/types.rs:96:9 [INFO] [stdout] | [INFO] [stdout] 96 | unsafe { [INFO] [stdout] | ^^^^^^ unnecessary `unsafe` block [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary `unsafe` block [INFO] [stdout] --> src/tfs/types.rs:102:9 [INFO] [stdout] | [INFO] [stdout] 102 | unsafe { [INFO] [stdout] | ^^^^^^ unnecessary `unsafe` block [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary `unsafe` block [INFO] [stdout] --> src/tfs/types.rs:108:9 [INFO] [stdout] | [INFO] [stdout] 108 | unsafe { [INFO] [stdout] | ^^^^^^ unnecessary `unsafe` block [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function is never used: `as_u32_be` [INFO] [stdout] --> src/tfs/utility.rs:1:8 [INFO] [stdout] | [INFO] [stdout] 1 | pub fn as_u32_be(array: &[u8; 4]) -> u32 { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function is never used: `as_u32_le` [INFO] [stdout] --> src/tfs/utility.rs:8:8 [INFO] [stdout] | [INFO] [stdout] 8 | pub fn as_u32_le(array: &[u8; 4]) -> u32 { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function is never used: `as_u32` [INFO] [stdout] --> src/tfs/utility.rs:15:8 [INFO] [stdout] | [INFO] [stdout] 15 | pub fn as_u32(array: &[u8]) -> u32 { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `metaData` should have a snake case name [INFO] [stdout] --> src/tfs/mod.rs:9:9 [INFO] [stdout] | [INFO] [stdout] 9 | pub metaData: Option, [INFO] [stdout] | ^^^^^^^^ help: convert the identifier to snake case: `meta_data` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_snake_case)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `inodeBitMap` should have a snake case name [INFO] [stdout] --> src/tfs/mod.rs:10:9 [INFO] [stdout] | [INFO] [stdout] 10 | pub inodeBitMap: Option>, [INFO] [stdout] | ^^^^^^^^^^^ help: convert the identifier to snake case: `inode_bit_map` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `dataBitMap` should have a snake case name [INFO] [stdout] --> src/tfs/mod.rs:11:9 [INFO] [stdout] | [INFO] [stdout] 11 | pub dataBitMap: Option>, [INFO] [stdout] | ^^^^^^^^^^ help: convert the identifier to snake case: `data_bit_map` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `metaData` should have a snake case name [INFO] [stdout] --> src/tfs/mod.rs:54:18 [INFO] [stdout] | [INFO] [stdout] 54 | Some(metaData) => Self::debug_print(metaData), [INFO] [stdout] | ^^^^^^^^ help: convert the identifier to snake case: `meta_data` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `metaData` should have a snake case name [INFO] [stdout] --> src/tfs/mod.rs:60:13 [INFO] [stdout] | [INFO] [stdout] 60 | let metaData = Self::read_meta_data(disk); [INFO] [stdout] | ^^^^^^^^ help: convert the identifier to snake case: `meta_data` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `inodeTable` should have a snake case name [INFO] [stdout] --> src/tfs/mod.rs:66:13 [INFO] [stdout] | [INFO] [stdout] 66 | let inodeTable = &meta_data.inodeTable; [INFO] [stdout] | ^^^^^^^^^^ help: convert the identifier to snake case: `inode_table` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `metaData` should have a snake case name [INFO] [stdout] --> src/tfs/mod.rs:122:13 [INFO] [stdout] | [INFO] [stdout] 122 | let metaData = Self::read_meta_data(disk); [INFO] [stdout] | ^^^^^^^^ help: convert the identifier to snake case: `meta_data` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `metaData2` should have a snake case name [INFO] [stdout] --> src/tfs/mod.rs:123:13 [INFO] [stdout] | [INFO] [stdout] 123 | let metaData2 = Self::read_meta_data(disk); // ...have no idea how to make a copy [INFO] [stdout] | ^^^^^^^^^ help: convert the identifier to snake case: `meta_data2` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `nBlocks` should have a snake case name [INFO] [stdout] --> src/tfs/mod.rs:133:13 [INFO] [stdout] | [INFO] [stdout] 133 | let nBlocks = metaData.superBlock.Blocks; [INFO] [stdout] | ^^^^^^^ help: convert the identifier to snake case: `n_blocks` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `inodeBlocks` should have a snake case name [INFO] [stdout] --> src/tfs/mod.rs:134:13 [INFO] [stdout] | [INFO] [stdout] 134 | let inodeBlocks = metaData.superBlock.InodeBlocks; [INFO] [stdout] | ^^^^^^^^^^^ help: convert the identifier to snake case: `inode_blocks` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `metaData` should have a snake case name [INFO] [stdout] --> src/tfs/mod.rs:200:38 [INFO] [stdout] | [INFO] [stdout] 200 | ... Some(metaData) => { [INFO] [stdout] | ^^^^^^^^ help: convert the identifier to snake case: `meta_data` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `_metaData` should have a snake case name [INFO] [stdout] --> src/tfs/mod.rs:225:18 [INFO] [stdout] | [INFO] [stdout] 225 | Some(_metaData) => { [INFO] [stdout] | ^^^^^^^^^ help: convert the identifier to snake case: `_meta_data` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `metaData` should have a snake case name [INFO] [stdout] --> src/tfs/mod.rs:248:22 [INFO] [stdout] | [INFO] [stdout] 248 | Some(metaData) => { [INFO] [stdout] | ^^^^^^^^ help: convert the identifier to snake case: `meta_data` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `ibitMap` should have a snake case name [INFO] [stdout] --> src/tfs/mod.rs:257:22 [INFO] [stdout] | [INFO] [stdout] 257 | Some(ibitMap)=> { [INFO] [stdout] | ^^^^^^^ help: convert the identifier to snake case: `ibit_map` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `superBlock` should have a snake case name [INFO] [stdout] --> src/tfs/mod.rs:544:13 [INFO] [stdout] | [INFO] [stdout] 544 | let superBlock = block.superblock(); [INFO] [stdout] | ^^^^^^^^^^ help: convert the identifier to snake case: `super_block` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `inodeTable` should have a snake case name [INFO] [stdout] --> src/tfs/mod.rs:547:17 [INFO] [stdout] | [INFO] [stdout] 547 | let mut inodeTable = Vec::new(); [INFO] [stdout] | ^^^^^^^^^^ help: convert the identifier to snake case: `inode_table` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `metaData` should have a snake case name [INFO] [stdout] --> src/tfs/mod.rs:563:18 [INFO] [stdout] | [INFO] [stdout] 563 | Some(metaData) => { [INFO] [stdout] | ^^^^^^^^ help: convert the identifier to snake case: `meta_data` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `metaData` should have a snake case name [INFO] [stdout] --> src/tfs/mod.rs:581:18 [INFO] [stdout] | [INFO] [stdout] 581 | Some(metaData) => { [INFO] [stdout] | ^^^^^^^^ help: convert the identifier to snake case: `meta_data` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `metaData` should have a snake case name [INFO] [stdout] --> src/tfs/mod.rs:658:26 [INFO] [stdout] | [INFO] [stdout] 658 | Some(metaData) => { [INFO] [stdout] | ^^^^^^^^ help: convert the identifier to snake case: `meta_data` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `dataBitMap` should have a snake case name [INFO] [stdout] --> src/tfs/mod.rs:693:31 [INFO] [stdout] | [INFO] [stdout] 693 | let get_free_block = |dataBitMap: Option<&Vec>| { [INFO] [stdout] | ^^^^^^^^^^ help: convert the identifier to snake case: `data_bit_map` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `dataBitMap` should have a snake case name [INFO] [stdout] --> src/tfs/mod.rs:695:22 [INFO] [stdout] | [INFO] [stdout] 695 | Some(dataBitMap) => { [INFO] [stdout] | ^^^^^^^^^^ help: convert the identifier to snake case: `data_bit_map` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `dataBitMap` should have a snake case name [INFO] [stdout] --> src/tfs/mod.rs:718:22 [INFO] [stdout] | [INFO] [stdout] 718 | Some(dataBitMap) => { [INFO] [stdout] | ^^^^^^^^^^ help: convert the identifier to snake case: `data_bit_map` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `metaData` should have a snake case name [INFO] [stdout] --> src/tfs/mod.rs:725:22 [INFO] [stdout] | [INFO] [stdout] 725 | Some(metaData) => { [INFO] [stdout] | ^^^^^^^^ help: convert the identifier to snake case: `meta_data` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `FileDescriptor` should have a snake case name [INFO] [stdout] --> src/tfs/disk.rs:10:5 [INFO] [stdout] | [INFO] [stdout] 10 | FileDescriptor: Option, [INFO] [stdout] | ^^^^^^^^^^^^^^ help: convert the identifier to snake case: `file_descriptor` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `Blocks` should have a snake case name [INFO] [stdout] --> src/tfs/disk.rs:11:5 [INFO] [stdout] | [INFO] [stdout] 11 | Blocks: usize, // Number of blocks in disk image [INFO] [stdout] | ^^^^^^ help: convert the identifier to snake case: `blocks` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `Reads` should have a snake case name [INFO] [stdout] --> src/tfs/disk.rs:12:5 [INFO] [stdout] | [INFO] [stdout] 12 | Reads: usize, // Number of reads performed [INFO] [stdout] | ^^^^^ help: convert the identifier to snake case: `reads` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `Writes` should have a snake case name [INFO] [stdout] --> src/tfs/disk.rs:13:5 [INFO] [stdout] | [INFO] [stdout] 13 | Writes: usize, // Number of writes performed [INFO] [stdout] | ^^^^^^ help: convert the identifier to snake case (notice the capitalization): `writes` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `Mounts` should have a snake case name [INFO] [stdout] --> src/tfs/disk.rs:14:5 [INFO] [stdout] | [INFO] [stdout] 14 | Mounts: usize, // Number of mounts [INFO] [stdout] | ^^^^^^ help: convert the identifier to snake case: `mounts` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `Path` should have a snake case name [INFO] [stdout] --> src/tfs/disk.rs:15:5 [INFO] [stdout] | [INFO] [stdout] 15 | Path: &'a str // file path for the disk [INFO] [stdout] | ^^^^ help: convert the identifier to snake case: `path` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison is useless due to type limits [INFO] [stdout] --> src/tfs/disk.rs:21:12 [INFO] [stdout] | [INFO] [stdout] 21 | if blocknum < 0 { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_comparisons)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/tfs/disk.rs:68:17 [INFO] [stdout] | [INFO] [stdout] 68 | f.set_len((nblocks as u64) * (Self::BLOCK_SIZE as u64)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/tfs/disk.rs:105:17 [INFO] [stdout] | [INFO] [stdout] 105 | file.seek(SeekFrom::Start( blocknum as u64 * Self::BLOCK_SIZE as u64)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/tfs/disk.rs:106:17 [INFO] [stdout] | [INFO] [stdout] 106 | file.read(data); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/tfs/disk.rs:117:17 [INFO] [stdout] | [INFO] [stdout] 117 | file.seek(SeekFrom::Start(blocknum as u64 * Self::BLOCK_SIZE as u64)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/tfs/disk.rs:118:17 [INFO] [stdout] | [INFO] [stdout] 118 | file.write(data); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `MagicNumber` should have a snake case name [INFO] [stdout] --> src/tfs/types.rs:13:9 [INFO] [stdout] | [INFO] [stdout] 13 | pub MagicNumber: u32, [INFO] [stdout] | ^^^^^^^^^^^ help: convert the identifier to snake case: `magic_number` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `Blocks` should have a snake case name [INFO] [stdout] --> src/tfs/types.rs:14:9 [INFO] [stdout] | [INFO] [stdout] 14 | pub Blocks: u32, [INFO] [stdout] | ^^^^^^ help: convert the identifier to snake case: `blocks` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `InodeBlocks` should have a snake case name [INFO] [stdout] --> src/tfs/types.rs:15:9 [INFO] [stdout] | [INFO] [stdout] 15 | pub InodeBlocks: u32, [INFO] [stdout] | ^^^^^^^^^^^ help: convert the identifier to snake case: `inode_blocks` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `Inodes` should have a snake case name [INFO] [stdout] --> src/tfs/types.rs:16:9 [INFO] [stdout] | [INFO] [stdout] 16 | pub Inodes: u32 [INFO] [stdout] | ^^^^^^ help: convert the identifier to snake case (notice the capitalization): `inodes` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `Valid` should have a snake case name [INFO] [stdout] --> src/tfs/types.rs:22:9 [INFO] [stdout] | [INFO] [stdout] 22 | pub Valid: u32, // whether or not inode is valid (or allocated) [INFO] [stdout] | ^^^^^ help: convert the identifier to snake case (notice the capitalization): `valid` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `Size` should have a snake case name [INFO] [stdout] --> src/tfs/types.rs:23:9 [INFO] [stdout] | [INFO] [stdout] 23 | pub Size: u32, // size of file [INFO] [stdout] | ^^^^ help: convert the identifier to snake case (notice the capitalization): `size` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `Direct` should have a snake case name [INFO] [stdout] --> src/tfs/types.rs:24:9 [INFO] [stdout] | [INFO] [stdout] 24 | pub Direct: [u32; POINTERS_PER_INODE], [INFO] [stdout] | ^^^^^^ help: convert the identifier to snake case: `direct` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `Indirect` should have a snake case name [INFO] [stdout] --> src/tfs/types.rs:25:9 [INFO] [stdout] | [INFO] [stdout] 25 | pub Indirect: u32 [INFO] [stdout] | ^^^^^^^^ help: convert the identifier to snake case (notice the capitalization): `indirect` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `Super` should have a snake case name [INFO] [stdout] --> src/tfs/types.rs:31:9 [INFO] [stdout] | [INFO] [stdout] 31 | pub Super: Superblock, [INFO] [stdout] | ^^^^^ help: rename the identifier [INFO] [stdout] | [INFO] [stdout] = note: `super` cannot be used as a raw identifier [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `Inodes` should have a snake case name [INFO] [stdout] --> src/tfs/types.rs:32:9 [INFO] [stdout] | [INFO] [stdout] 32 | pub Inodes: [Inode; INODES_PER_BLOCK], [INFO] [stdout] | ^^^^^^ help: convert the identifier to snake case (notice the capitalization): `inodes` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `Pointers` should have a snake case name [INFO] [stdout] --> src/tfs/types.rs:33:9 [INFO] [stdout] | [INFO] [stdout] 33 | pub Pointers: [u32; POINTERS_PER_BLOCK], [INFO] [stdout] | ^^^^^^^^ help: convert the identifier to snake case: `pointers` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `Data` should have a snake case name [INFO] [stdout] --> src/tfs/types.rs:34:9 [INFO] [stdout] | [INFO] [stdout] 34 | pub Data: [u8; Disk::BLOCK_SIZE] [INFO] [stdout] | ^^^^ help: convert the identifier to snake case: `data` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `superBlock` should have a snake case name [INFO] [stdout] --> src/tfs/types.rs:40:9 [INFO] [stdout] | [INFO] [stdout] 40 | pub superBlock: Superblock, [INFO] [stdout] | ^^^^^^^^^^ help: convert the identifier to snake case: `super_block` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `inodeTable` should have a snake case name [INFO] [stdout] --> src/tfs/types.rs:41:9 [INFO] [stdout] | [INFO] [stdout] 41 | pub inodeTable: Vec<[Inode; INODES_PER_BLOCK]> [INFO] [stdout] | ^^^^^^^^^^ help: convert the identifier to snake case: `inode_table` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 58 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary `unsafe` block [INFO] [stdout] --> src/tfs/types.rs:90:9 [INFO] [stdout] | [INFO] [stdout] 90 | unsafe { [INFO] [stdout] | ^^^^^^ unnecessary `unsafe` block [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_unsafe)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary `unsafe` block [INFO] [stdout] --> src/tfs/types.rs:96:9 [INFO] [stdout] | [INFO] [stdout] 96 | unsafe { [INFO] [stdout] | ^^^^^^ unnecessary `unsafe` block [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary `unsafe` block [INFO] [stdout] --> src/tfs/types.rs:102:9 [INFO] [stdout] | [INFO] [stdout] 102 | unsafe { [INFO] [stdout] | ^^^^^^ unnecessary `unsafe` block [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary `unsafe` block [INFO] [stdout] --> src/tfs/types.rs:108:9 [INFO] [stdout] | [INFO] [stdout] 108 | unsafe { [INFO] [stdout] | ^^^^^^ unnecessary `unsafe` block [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function is never used: `disk_open` [INFO] [stdout] --> src/tfs/disk.rs:132:8 [INFO] [stdout] | [INFO] [stdout] 132 | fn disk_open() { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function is never used: `disk_read_write` [INFO] [stdout] --> src/tfs/disk.rs:139:8 [INFO] [stdout] | [INFO] [stdout] 139 | fn disk_read_write() { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function is never used: `disk_clone` [INFO] [stdout] --> src/tfs/disk.rs:152:8 [INFO] [stdout] | [INFO] [stdout] 152 | fn disk_clone() { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function is never used: `as_u32_be` [INFO] [stdout] --> src/tfs/utility.rs:1:8 [INFO] [stdout] | [INFO] [stdout] 1 | pub fn as_u32_be(array: &[u8; 4]) -> u32 { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function is never used: `as_u32_le` [INFO] [stdout] --> src/tfs/utility.rs:8:8 [INFO] [stdout] | [INFO] [stdout] 8 | pub fn as_u32_le(array: &[u8; 4]) -> u32 { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function is never used: `as_u32` [INFO] [stdout] --> src/tfs/utility.rs:15:8 [INFO] [stdout] | [INFO] [stdout] 15 | pub fn as_u32(array: &[u8]) -> u32 { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function is never used: `test_debug` [INFO] [stdout] --> src/tfs/mod.rs:795:8 [INFO] [stdout] | [INFO] [stdout] 795 | fn test_debug() { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function is never used: `test_format` [INFO] [stdout] --> src/tfs/mod.rs:805:8 [INFO] [stdout] | [INFO] [stdout] 805 | fn test_format() { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function is never used: `test_mount` [INFO] [stdout] --> src/tfs/mod.rs:813:8 [INFO] [stdout] | [INFO] [stdout] 813 | fn test_mount() { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function is never used: `test_create_remove_inode` [INFO] [stdout] --> src/tfs/mod.rs:821:8 [INFO] [stdout] | [INFO] [stdout] 821 | fn test_create_remove_inode() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `metaData` should have a snake case name [INFO] [stdout] --> src/tfs/mod.rs:9:9 [INFO] [stdout] | [INFO] [stdout] 9 | pub metaData: Option, [INFO] [stdout] | ^^^^^^^^ help: convert the identifier to snake case: `meta_data` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_snake_case)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `inodeBitMap` should have a snake case name [INFO] [stdout] --> src/tfs/mod.rs:10:9 [INFO] [stdout] | [INFO] [stdout] 10 | pub inodeBitMap: Option>, [INFO] [stdout] | ^^^^^^^^^^^ help: convert the identifier to snake case: `inode_bit_map` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `dataBitMap` should have a snake case name [INFO] [stdout] --> src/tfs/mod.rs:11:9 [INFO] [stdout] | [INFO] [stdout] 11 | pub dataBitMap: Option>, [INFO] [stdout] | ^^^^^^^^^^ help: convert the identifier to snake case: `data_bit_map` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `metaData` should have a snake case name [INFO] [stdout] --> src/tfs/mod.rs:54:18 [INFO] [stdout] | [INFO] [stdout] 54 | Some(metaData) => Self::debug_print(metaData), [INFO] [stdout] | ^^^^^^^^ help: convert the identifier to snake case: `meta_data` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `metaData` should have a snake case name [INFO] [stdout] --> src/tfs/mod.rs:60:13 [INFO] [stdout] | [INFO] [stdout] 60 | let metaData = Self::read_meta_data(disk); [INFO] [stdout] | ^^^^^^^^ help: convert the identifier to snake case: `meta_data` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `inodeTable` should have a snake case name [INFO] [stdout] --> src/tfs/mod.rs:66:13 [INFO] [stdout] | [INFO] [stdout] 66 | let inodeTable = &meta_data.inodeTable; [INFO] [stdout] | ^^^^^^^^^^ help: convert the identifier to snake case: `inode_table` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `metaData` should have a snake case name [INFO] [stdout] --> src/tfs/mod.rs:122:13 [INFO] [stdout] | [INFO] [stdout] 122 | let metaData = Self::read_meta_data(disk); [INFO] [stdout] | ^^^^^^^^ help: convert the identifier to snake case: `meta_data` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `metaData2` should have a snake case name [INFO] [stdout] --> src/tfs/mod.rs:123:13 [INFO] [stdout] | [INFO] [stdout] 123 | let metaData2 = Self::read_meta_data(disk); // ...have no idea how to make a copy [INFO] [stdout] | ^^^^^^^^^ help: convert the identifier to snake case: `meta_data2` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `nBlocks` should have a snake case name [INFO] [stdout] --> src/tfs/mod.rs:133:13 [INFO] [stdout] | [INFO] [stdout] 133 | let nBlocks = metaData.superBlock.Blocks; [INFO] [stdout] | ^^^^^^^ help: convert the identifier to snake case: `n_blocks` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `inodeBlocks` should have a snake case name [INFO] [stdout] --> src/tfs/mod.rs:134:13 [INFO] [stdout] | [INFO] [stdout] 134 | let inodeBlocks = metaData.superBlock.InodeBlocks; [INFO] [stdout] | ^^^^^^^^^^^ help: convert the identifier to snake case: `inode_blocks` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `metaData` should have a snake case name [INFO] [stdout] --> src/tfs/mod.rs:200:38 [INFO] [stdout] | [INFO] [stdout] 200 | ... Some(metaData) => { [INFO] [stdout] | ^^^^^^^^ help: convert the identifier to snake case: `meta_data` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `_metaData` should have a snake case name [INFO] [stdout] --> src/tfs/mod.rs:225:18 [INFO] [stdout] | [INFO] [stdout] 225 | Some(_metaData) => { [INFO] [stdout] | ^^^^^^^^^ help: convert the identifier to snake case: `_meta_data` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `metaData` should have a snake case name [INFO] [stdout] --> src/tfs/mod.rs:248:22 [INFO] [stdout] | [INFO] [stdout] 248 | Some(metaData) => { [INFO] [stdout] | ^^^^^^^^ help: convert the identifier to snake case: `meta_data` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `ibitMap` should have a snake case name [INFO] [stdout] --> src/tfs/mod.rs:257:22 [INFO] [stdout] | [INFO] [stdout] 257 | Some(ibitMap)=> { [INFO] [stdout] | ^^^^^^^ help: convert the identifier to snake case: `ibit_map` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `superBlock` should have a snake case name [INFO] [stdout] --> src/tfs/mod.rs:544:13 [INFO] [stdout] | [INFO] [stdout] 544 | let superBlock = block.superblock(); [INFO] [stdout] | ^^^^^^^^^^ help: convert the identifier to snake case: `super_block` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `inodeTable` should have a snake case name [INFO] [stdout] --> src/tfs/mod.rs:547:17 [INFO] [stdout] | [INFO] [stdout] 547 | let mut inodeTable = Vec::new(); [INFO] [stdout] | ^^^^^^^^^^ help: convert the identifier to snake case: `inode_table` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `metaData` should have a snake case name [INFO] [stdout] --> src/tfs/mod.rs:563:18 [INFO] [stdout] | [INFO] [stdout] 563 | Some(metaData) => { [INFO] [stdout] | ^^^^^^^^ help: convert the identifier to snake case: `meta_data` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `metaData` should have a snake case name [INFO] [stdout] --> src/tfs/mod.rs:581:18 [INFO] [stdout] | [INFO] [stdout] 581 | Some(metaData) => { [INFO] [stdout] | ^^^^^^^^ help: convert the identifier to snake case: `meta_data` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `metaData` should have a snake case name [INFO] [stdout] --> src/tfs/mod.rs:658:26 [INFO] [stdout] | [INFO] [stdout] 658 | Some(metaData) => { [INFO] [stdout] | ^^^^^^^^ help: convert the identifier to snake case: `meta_data` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `dataBitMap` should have a snake case name [INFO] [stdout] --> src/tfs/mod.rs:693:31 [INFO] [stdout] | [INFO] [stdout] 693 | let get_free_block = |dataBitMap: Option<&Vec>| { [INFO] [stdout] | ^^^^^^^^^^ help: convert the identifier to snake case: `data_bit_map` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `dataBitMap` should have a snake case name [INFO] [stdout] --> src/tfs/mod.rs:695:22 [INFO] [stdout] | [INFO] [stdout] 695 | Some(dataBitMap) => { [INFO] [stdout] | ^^^^^^^^^^ help: convert the identifier to snake case: `data_bit_map` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `dataBitMap` should have a snake case name [INFO] [stdout] --> src/tfs/mod.rs:718:22 [INFO] [stdout] | [INFO] [stdout] 718 | Some(dataBitMap) => { [INFO] [stdout] | ^^^^^^^^^^ help: convert the identifier to snake case: `data_bit_map` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `metaData` should have a snake case name [INFO] [stdout] --> src/tfs/mod.rs:725:22 [INFO] [stdout] | [INFO] [stdout] 725 | Some(metaData) => { [INFO] [stdout] | ^^^^^^^^ help: convert the identifier to snake case: `meta_data` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `FileDescriptor` should have a snake case name [INFO] [stdout] --> src/tfs/disk.rs:10:5 [INFO] [stdout] | [INFO] [stdout] 10 | FileDescriptor: Option, [INFO] [stdout] | ^^^^^^^^^^^^^^ help: convert the identifier to snake case: `file_descriptor` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `Blocks` should have a snake case name [INFO] [stdout] --> src/tfs/disk.rs:11:5 [INFO] [stdout] | [INFO] [stdout] 11 | Blocks: usize, // Number of blocks in disk image [INFO] [stdout] | ^^^^^^ help: convert the identifier to snake case: `blocks` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `Reads` should have a snake case name [INFO] [stdout] --> src/tfs/disk.rs:12:5 [INFO] [stdout] | [INFO] [stdout] 12 | Reads: usize, // Number of reads performed [INFO] [stdout] | ^^^^^ help: convert the identifier to snake case: `reads` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `Writes` should have a snake case name [INFO] [stdout] --> src/tfs/disk.rs:13:5 [INFO] [stdout] | [INFO] [stdout] 13 | Writes: usize, // Number of writes performed [INFO] [stdout] | ^^^^^^ help: convert the identifier to snake case (notice the capitalization): `writes` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `Mounts` should have a snake case name [INFO] [stdout] --> src/tfs/disk.rs:14:5 [INFO] [stdout] | [INFO] [stdout] 14 | Mounts: usize, // Number of mounts [INFO] [stdout] | ^^^^^^ help: convert the identifier to snake case: `mounts` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `Path` should have a snake case name [INFO] [stdout] --> src/tfs/disk.rs:15:5 [INFO] [stdout] | [INFO] [stdout] 15 | Path: &'a str // file path for the disk [INFO] [stdout] | ^^^^ help: convert the identifier to snake case: `path` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison is useless due to type limits [INFO] [stdout] --> src/tfs/disk.rs:21:12 [INFO] [stdout] | [INFO] [stdout] 21 | if blocknum < 0 { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_comparisons)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/tfs/disk.rs:68:17 [INFO] [stdout] | [INFO] [stdout] 68 | f.set_len((nblocks as u64) * (Self::BLOCK_SIZE as u64)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/tfs/disk.rs:105:17 [INFO] [stdout] | [INFO] [stdout] 105 | file.seek(SeekFrom::Start( blocknum as u64 * Self::BLOCK_SIZE as u64)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/tfs/disk.rs:106:17 [INFO] [stdout] | [INFO] [stdout] 106 | file.read(data); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/tfs/disk.rs:117:17 [INFO] [stdout] | [INFO] [stdout] 117 | file.seek(SeekFrom::Start(blocknum as u64 * Self::BLOCK_SIZE as u64)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/tfs/disk.rs:118:17 [INFO] [stdout] | [INFO] [stdout] 118 | file.write(data); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `MagicNumber` should have a snake case name [INFO] [stdout] --> src/tfs/types.rs:13:9 [INFO] [stdout] | [INFO] [stdout] 13 | pub MagicNumber: u32, [INFO] [stdout] | ^^^^^^^^^^^ help: convert the identifier to snake case: `magic_number` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `Blocks` should have a snake case name [INFO] [stdout] --> src/tfs/types.rs:14:9 [INFO] [stdout] | [INFO] [stdout] 14 | pub Blocks: u32, [INFO] [stdout] | ^^^^^^ help: convert the identifier to snake case: `blocks` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `InodeBlocks` should have a snake case name [INFO] [stdout] --> src/tfs/types.rs:15:9 [INFO] [stdout] | [INFO] [stdout] 15 | pub InodeBlocks: u32, [INFO] [stdout] | ^^^^^^^^^^^ help: convert the identifier to snake case: `inode_blocks` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `Inodes` should have a snake case name [INFO] [stdout] --> src/tfs/types.rs:16:9 [INFO] [stdout] | [INFO] [stdout] 16 | pub Inodes: u32 [INFO] [stdout] | ^^^^^^ help: convert the identifier to snake case (notice the capitalization): `inodes` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `Valid` should have a snake case name [INFO] [stdout] --> src/tfs/types.rs:22:9 [INFO] [stdout] | [INFO] [stdout] 22 | pub Valid: u32, // whether or not inode is valid (or allocated) [INFO] [stdout] | ^^^^^ help: convert the identifier to snake case (notice the capitalization): `valid` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `Size` should have a snake case name [INFO] [stdout] --> src/tfs/types.rs:23:9 [INFO] [stdout] | [INFO] [stdout] 23 | pub Size: u32, // size of file [INFO] [stdout] | ^^^^ help: convert the identifier to snake case (notice the capitalization): `size` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `Direct` should have a snake case name [INFO] [stdout] --> src/tfs/types.rs:24:9 [INFO] [stdout] | [INFO] [stdout] 24 | pub Direct: [u32; POINTERS_PER_INODE], [INFO] [stdout] | ^^^^^^ help: convert the identifier to snake case: `direct` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `Indirect` should have a snake case name [INFO] [stdout] --> src/tfs/types.rs:25:9 [INFO] [stdout] | [INFO] [stdout] 25 | pub Indirect: u32 [INFO] [stdout] | ^^^^^^^^ help: convert the identifier to snake case (notice the capitalization): `indirect` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `Super` should have a snake case name [INFO] [stdout] --> src/tfs/types.rs:31:9 [INFO] [stdout] | [INFO] [stdout] 31 | pub Super: Superblock, [INFO] [stdout] | ^^^^^ help: rename the identifier [INFO] [stdout] | [INFO] [stdout] = note: `super` cannot be used as a raw identifier [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `Inodes` should have a snake case name [INFO] [stdout] --> src/tfs/types.rs:32:9 [INFO] [stdout] | [INFO] [stdout] 32 | pub Inodes: [Inode; INODES_PER_BLOCK], [INFO] [stdout] | ^^^^^^ help: convert the identifier to snake case (notice the capitalization): `inodes` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `Pointers` should have a snake case name [INFO] [stdout] --> src/tfs/types.rs:33:9 [INFO] [stdout] | [INFO] [stdout] 33 | pub Pointers: [u32; POINTERS_PER_BLOCK], [INFO] [stdout] | ^^^^^^^^ help: convert the identifier to snake case: `pointers` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `Data` should have a snake case name [INFO] [stdout] --> src/tfs/types.rs:34:9 [INFO] [stdout] | [INFO] [stdout] 34 | pub Data: [u8; Disk::BLOCK_SIZE] [INFO] [stdout] | ^^^^ help: convert the identifier to snake case: `data` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `superBlock` should have a snake case name [INFO] [stdout] --> src/tfs/types.rs:40:9 [INFO] [stdout] | [INFO] [stdout] 40 | pub superBlock: Superblock, [INFO] [stdout] | ^^^^^^^^^^ help: convert the identifier to snake case: `super_block` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `inodeTable` should have a snake case name [INFO] [stdout] --> src/tfs/types.rs:41:9 [INFO] [stdout] | [INFO] [stdout] 41 | pub inodeTable: Vec<[Inode; INODES_PER_BLOCK]> [INFO] [stdout] | ^^^^^^^^^^ help: convert the identifier to snake case: `inode_table` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 65 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison is useless due to type limits [INFO] [stdout] --> src/main.rs:157:16 [INFO] [stdout] | [INFO] [stdout] 157 | if inumber >= 0 { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_comparisons)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/main.rs:282:9 [INFO] [stdout] | [INFO] [stdout] 282 | file.seek(SeekFrom::Start( n as u64 * Disk::BLOCK_SIZE as u64)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/main.rs:315:13 [INFO] [stdout] | [INFO] [stdout] 315 | file.write(&mut buff); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/main.rs:317:13 [INFO] [stdout] | [INFO] [stdout] 317 | file.write(&mut buffer); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 4 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison is useless due to type limits [INFO] [stdout] --> src/main.rs:157:16 [INFO] [stdout] | [INFO] [stdout] 157 | if inumber >= 0 { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_comparisons)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/main.rs:282:9 [INFO] [stdout] | [INFO] [stdout] 282 | file.seek(SeekFrom::Start( n as u64 * Disk::BLOCK_SIZE as u64)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/main.rs:315:13 [INFO] [stdout] | [INFO] [stdout] 315 | file.write(&mut buff); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/main.rs:317:13 [INFO] [stdout] | [INFO] [stdout] 317 | file.write(&mut buffer); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 4 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 4.25s [INFO] running `Command { std: "docker" "inspect" "e476689ad052dd95b176909fc9f652e3932267e7b584b150c562b594d657b4e5", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "e476689ad052dd95b176909fc9f652e3932267e7b584b150c562b594d657b4e5", kill_on_drop: false }` [INFO] [stdout] e476689ad052dd95b176909fc9f652e3932267e7b584b150c562b594d657b4e5