[INFO] fetching crate spaniel 0.1.0... [INFO] checking spaniel-0.1.0 against master#33fdb797f59421c7bbecaa4588ed5d7a31a9494a for pr-87190-3 [INFO] extracting crate spaniel 0.1.0 into /workspace/builds/worker-85/source [INFO] validating manifest of crates.io crate spaniel 0.1.0 on toolchain 33fdb797f59421c7bbecaa4588ed5d7a31a9494a [INFO] running `Command { std: "/workspace/cargo-home/bin/cargo" "+33fdb797f59421c7bbecaa4588ed5d7a31a9494a" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate spaniel 0.1.0 [INFO] finished tweaking crates.io crate spaniel 0.1.0 [INFO] tweaked toml for crates.io crate spaniel 0.1.0 written to /workspace/builds/worker-85/source/Cargo.toml [INFO] running `Command { std: "/workspace/cargo-home/bin/cargo" "+33fdb797f59421c7bbecaa4588ed5d7a31a9494a" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "/workspace/cargo-home/bin/cargo" "+33fdb797f59421c7bbecaa4588ed5d7a31a9494a" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-85/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-85/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:34b6a614d2c27851fe6cbf88fbd1137609cefab8b10d0615aaeb6fd47975d74e" "/opt/rustwide/cargo-home/bin/cargo" "+33fdb797f59421c7bbecaa4588ed5d7a31a9494a" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 663911f4652614e738c5982895c1d4e0c05adcb1b992a6c732801cdfe0e7f523 [INFO] running `Command { std: "docker" "start" "-a" "663911f4652614e738c5982895c1d4e0c05adcb1b992a6c732801cdfe0e7f523", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "663911f4652614e738c5982895c1d4e0c05adcb1b992a6c732801cdfe0e7f523", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "663911f4652614e738c5982895c1d4e0c05adcb1b992a6c732801cdfe0e7f523", kill_on_drop: false }` [INFO] [stdout] 663911f4652614e738c5982895c1d4e0c05adcb1b992a6c732801cdfe0e7f523 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-85/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-85/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:34b6a614d2c27851fe6cbf88fbd1137609cefab8b10d0615aaeb6fd47975d74e" "/opt/rustwide/cargo-home/bin/cargo" "+33fdb797f59421c7bbecaa4588ed5d7a31a9494a" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 3f0fc3b9722144bb2317544bf9ff64f41e2e620a47fd439851db2fe55014f0a9 [INFO] running `Command { std: "docker" "start" "-a" "3f0fc3b9722144bb2317544bf9ff64f41e2e620a47fd439851db2fe55014f0a9", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Compiling libc v0.2.100 [INFO] [stderr] Compiling log v0.4.14 [INFO] [stderr] Checking cfg-if v1.0.0 [INFO] [stderr] Checking iovec v0.1.4 [INFO] [stderr] Checking bytes v0.4.12 [INFO] [stderr] Checking tokio-io v0.1.13 [INFO] [stderr] Checking spaniel v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/protocol/codec/writer.rs:127:58 [INFO] [stdout] | [INFO] [stdout] 127 | pub fn buffer_data(&mut self, data: Bytes) -> Result<(usize), WriteError> { [INFO] [stdout] | ^^^^^^^ help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/protocol/codec/writer.rs:251:60 [INFO] [stdout] | [INFO] [stdout] 251 | pub fn buffer_frame(&mut self, frame: Frame) -> Result<(usize), WriteError> { [INFO] [stdout] | ^^^^^^^ help: remove these parentheses [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/protocol/codec/writer.rs:260:62 [INFO] [stdout] | [INFO] [stdout] 260 | pub fn buffer_and_flush(&mut self, frame: Frame) -> Poll<(usize), WriteError> { [INFO] [stdout] | ^^^^^^^ help: remove these parentheses [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/protocol/codec/writer.rs:127:58 [INFO] [stdout] | [INFO] [stdout] 127 | pub fn buffer_data(&mut self, data: Bytes) -> Result<(usize), WriteError> { [INFO] [stdout] | ^^^^^^^ help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/protocol/codec/writer.rs:251:60 [INFO] [stdout] | [INFO] [stdout] 251 | pub fn buffer_frame(&mut self, frame: Frame) -> Result<(usize), WriteError> { [INFO] [stdout] | ^^^^^^^ help: remove these parentheses [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/protocol/codec/writer.rs:260:62 [INFO] [stdout] | [INFO] [stdout] 260 | pub fn buffer_and_flush(&mut self, frame: Frame) -> Poll<(usize), WriteError> { [INFO] [stdout] | ^^^^^^^ help: remove these parentheses [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated module `tokio_io::codec::length_delimited`: Moved to tokio-codec [INFO] [stdout] --> src/protocol/codec/mod.rs:11:22 [INFO] [stdout] | [INFO] [stdout] 11 | use tokio_io::codec::length_delimited::{self, Framed}; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated struct `tokio_io::codec::length_delimited::Framed`: Moved to tokio-codec [INFO] [stdout] --> src/protocol/codec/mod.rs:11:47 [INFO] [stdout] | [INFO] [stdout] 11 | use tokio_io::codec::length_delimited::{self, Framed}; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated struct `tokio_io::codec::length_delimited::Framed`: Moved to tokio-codec [INFO] [stdout] --> src/protocol/codec/mod.rs:23:12 [INFO] [stdout] | [INFO] [stdout] 23 | inner: Framed, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated struct `tokio_io::codec::length_delimited::Builder`: Moved to tokio-codec [INFO] [stdout] --> src/protocol/codec/mod.rs:32:38 [INFO] [stdout] | [INFO] [stdout] 32 | inner: length_delimited::Builder::new() [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated module `tokio_io::codec::length_delimited`: Moved to tokio-codec [INFO] [stdout] --> src/protocol/codec/reader.rs:7:22 [INFO] [stdout] | [INFO] [stdout] 7 | use tokio_io::codec::length_delimited; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated struct `tokio_io::codec::length_delimited::FramedRead`: Moved to tokio-codec [INFO] [stdout] --> src/protocol/codec/reader.rs:12:28 [INFO] [stdout] | [INFO] [stdout] 12 | src: length_delimited::FramedRead, [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated struct `tokio_io::codec::length_delimited::Builder`: Moved to tokio-codec [INFO] [stdout] --> src/protocol/codec/reader.rs:19:37 [INFO] [stdout] | [INFO] [stdout] 19 | let src = length_delimited::Builder::new() [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated module `tokio_io::codec::length_delimited`: Moved to tokio-codec [INFO] [stdout] --> src/protocol/codec/mod.rs:11:22 [INFO] [stdout] | [INFO] [stdout] 11 | use tokio_io::codec::length_delimited::{self, Framed}; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated struct `tokio_io::codec::length_delimited::Framed`: Moved to tokio-codec [INFO] [stdout] --> src/protocol/codec/mod.rs:11:47 [INFO] [stdout] | [INFO] [stdout] 11 | use tokio_io::codec::length_delimited::{self, Framed}; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated struct `tokio_io::codec::length_delimited::Framed`: Moved to tokio-codec [INFO] [stdout] --> src/protocol/codec/mod.rs:23:12 [INFO] [stdout] | [INFO] [stdout] 23 | inner: Framed, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated struct `tokio_io::codec::length_delimited::Builder`: Moved to tokio-codec [INFO] [stdout] --> src/protocol/codec/mod.rs:32:38 [INFO] [stdout] | [INFO] [stdout] 32 | inner: length_delimited::Builder::new() [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated module `tokio_io::codec::length_delimited`: Moved to tokio-codec [INFO] [stdout] --> src/protocol/codec/reader.rs:7:22 [INFO] [stdout] | [INFO] [stdout] 7 | use tokio_io::codec::length_delimited; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated struct `tokio_io::codec::length_delimited::FramedRead`: Moved to tokio-codec [INFO] [stdout] --> src/protocol/codec/reader.rs:12:28 [INFO] [stdout] | [INFO] [stdout] 12 | src: length_delimited::FramedRead, [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated struct `tokio_io::codec::length_delimited::Builder`: Moved to tokio-codec [INFO] [stdout] --> src/protocol/codec/reader.rs:19:37 [INFO] [stdout] | [INFO] [stdout] 19 | let src = length_delimited::Builder::new() [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated associated function `std::error::Error::description`: use the Display impl or to_string() [INFO] [stdout] --> src/protocol/codec/writer.rs:60:44 [INFO] [stdout] | [INFO] [stdout] 60 | write!(f, "writer error: {}", self.description()) [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated associated function `std::error::Error::description`: use the Display impl or to_string() [INFO] [stdout] --> src/protocol/codec/writer.rs:60:44 [INFO] [stdout] | [INFO] [stdout] 60 | write!(f, "writer error: {}", self.description()) [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `src` [INFO] [stdout] --> src/protocol/frames.rs:305:28 [INFO] [stdout] | [INFO] [stdout] 305 | fn decode_from(src: &mut B) -> Result { [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_src` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `src` [INFO] [stdout] --> src/protocol/frames.rs:305:28 [INFO] [stdout] | [INFO] [stdout] 305 | fn decode_from(src: &mut B) -> Result { [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_src` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `dst` [INFO] [stdout] --> src/protocol/frames.rs:309:38 [INFO] [stdout] | [INFO] [stdout] 309 | fn encode_into(&self, dst: &mut B) -> Result<(), ()> { [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_dst` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `dst` [INFO] [stdout] --> src/protocol/frames.rs:309:38 [INFO] [stdout] | [INFO] [stdout] 309 | fn encode_into(&self, dst: &mut B) -> Result<(), ()> { [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_dst` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/protocol/codec/writer.rs:196:21 [INFO] [stdout] | [INFO] [stdout] 196 | let mut buf = self.current.as_mut().unwrap(); [INFO] [stdout] | ----^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/protocol/codec/writer.rs:196:21 [INFO] [stdout] | [INFO] [stdout] 196 | let mut buf = self.current.as_mut().unwrap(); [INFO] [stdout] | ----^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated function is never used: `notify_all` [INFO] [stdout] --> src/connection.rs:195:8 [INFO] [stdout] | [INFO] [stdout] 195 | fn notify_all(&mut self) { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated function is never used: `notify_all` [INFO] [stdout] --> src/connection.rs:195:8 [INFO] [stdout] | [INFO] [stdout] 195 | fn notify_all(&mut self) { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant is never constructed: `CreditBased` [INFO] [stdout] --> src/flow_control.rs:8:5 [INFO] [stdout] | [INFO] [stdout] 8 | CreditBased(FlowControlRatio), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant is never constructed: `CreditBased` [INFO] [stdout] --> src/flow_control.rs:8:5 [INFO] [stdout] | [INFO] [stdout] 8 | CreditBased(FlowControlRatio), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated function is never used: `push_front` [INFO] [stdout] --> src/protocol/codec/buffer.rs:21:12 [INFO] [stdout] | [INFO] [stdout] 21 | pub fn push_front(&mut self, value: B) { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated function is never used: `push_front` [INFO] [stdout] --> src/protocol/codec/buffer.rs:21:12 [INFO] [stdout] | [INFO] [stdout] 21 | pub fn push_front(&mut self, value: B) { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant is never constructed: `Error` [INFO] [stdout] --> src/protocol/codec/writer.rs:72:5 [INFO] [stdout] | [INFO] [stdout] 72 | Error, [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant is never constructed: `Error` [INFO] [stdout] --> src/protocol/codec/writer.rs:72:5 [INFO] [stdout] | [INFO] [stdout] 72 | Error, [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated function is never used: `set_watermarks` [INFO] [stdout] --> src/protocol/codec/writer.rs:119:12 [INFO] [stdout] | [INFO] [stdout] 119 | pub fn set_watermarks(&mut self, high: usize, low: usize) { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated function is never used: `set_watermarks` [INFO] [stdout] --> src/protocol/codec/writer.rs:119:12 [INFO] [stdout] | [INFO] [stdout] 119 | pub fn set_watermarks(&mut self, high: usize, low: usize) { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated function is never used: `write_and_flush` [INFO] [stdout] --> src/protocol/codec/writer.rs:220:12 [INFO] [stdout] | [INFO] [stdout] 220 | pub fn write_and_flush(&mut self, data: Bytes) -> Poll<(), std::io::Error> { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated function is never used: `write_and_flush` [INFO] [stdout] --> src/protocol/codec/writer.rs:220:12 [INFO] [stdout] | [INFO] [stdout] 220 | pub fn write_and_flush(&mut self, data: Bytes) -> Poll<(), std::io::Error> { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 20 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 20 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 3.09s [INFO] running `Command { std: "docker" "inspect" "3f0fc3b9722144bb2317544bf9ff64f41e2e620a47fd439851db2fe55014f0a9", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "3f0fc3b9722144bb2317544bf9ff64f41e2e620a47fd439851db2fe55014f0a9", kill_on_drop: false }` [INFO] [stdout] 3f0fc3b9722144bb2317544bf9ff64f41e2e620a47fd439851db2fe55014f0a9