[INFO] fetching crate jab 0.0.1... [INFO] checking jab-0.0.1 against master#33fdb797f59421c7bbecaa4588ed5d7a31a9494a for pr-87190-3 [INFO] extracting crate jab 0.0.1 into /workspace/builds/worker-63/source [INFO] validating manifest of crates.io crate jab 0.0.1 on toolchain 33fdb797f59421c7bbecaa4588ed5d7a31a9494a [INFO] running `Command { std: "/workspace/cargo-home/bin/cargo" "+33fdb797f59421c7bbecaa4588ed5d7a31a9494a" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate jab 0.0.1 [INFO] finished tweaking crates.io crate jab 0.0.1 [INFO] tweaked toml for crates.io crate jab 0.0.1 written to /workspace/builds/worker-63/source/Cargo.toml [INFO] crate crates.io crate jab 0.0.1 already has a lockfile, it will not be regenerated [INFO] running `Command { std: "/workspace/cargo-home/bin/cargo" "+33fdb797f59421c7bbecaa4588ed5d7a31a9494a" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: only one of `license` or `license-file` is necessary [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-63/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-63/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:34b6a614d2c27851fe6cbf88fbd1137609cefab8b10d0615aaeb6fd47975d74e" "/opt/rustwide/cargo-home/bin/cargo" "+33fdb797f59421c7bbecaa4588ed5d7a31a9494a" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] f8b4a0129fec55fb6b8e8827d12bd88c4b49ee8e24d97c29505e14e53e8b19b7 [INFO] running `Command { std: "docker" "start" "-a" "f8b4a0129fec55fb6b8e8827d12bd88c4b49ee8e24d97c29505e14e53e8b19b7", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "f8b4a0129fec55fb6b8e8827d12bd88c4b49ee8e24d97c29505e14e53e8b19b7", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "f8b4a0129fec55fb6b8e8827d12bd88c4b49ee8e24d97c29505e14e53e8b19b7", kill_on_drop: false }` [INFO] [stdout] f8b4a0129fec55fb6b8e8827d12bd88c4b49ee8e24d97c29505e14e53e8b19b7 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-63/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-63/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:34b6a614d2c27851fe6cbf88fbd1137609cefab8b10d0615aaeb6fd47975d74e" "/opt/rustwide/cargo-home/bin/cargo" "+33fdb797f59421c7bbecaa4588ed5d7a31a9494a" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 03a781cc0649fb7d66bcbd4a0398b7a242c66c43a72bf1c709e1ea3f28c405b0 [INFO] running `Command { std: "docker" "start" "-a" "03a781cc0649fb7d66bcbd4a0398b7a242c66c43a72bf1c709e1ea3f28c405b0", kill_on_drop: false }` [INFO] [stderr] warning: only one of `license` or `license-file` is necessary [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Compiling libc v0.2.66 [INFO] [stderr] Compiling proc-macro2 v1.0.8 [INFO] [stderr] Compiling unicode-xid v0.2.0 [INFO] [stderr] Compiling syn v1.0.13 [INFO] [stderr] Compiling pkg-config v0.3.17 [INFO] [stderr] Compiling serde v1.0.104 [INFO] [stderr] Checking cfg-if v0.1.10 [INFO] [stderr] Compiling memchr v2.3.0 [INFO] [stderr] Compiling matches v0.1.8 [INFO] [stderr] Compiling smallvec v1.1.0 [INFO] [stderr] Compiling percent-encoding v2.1.0 [INFO] [stderr] Compiling semver-parser v0.7.0 [INFO] [stderr] Checking lazy_static v1.4.0 [INFO] [stderr] Compiling log v0.4.8 [INFO] [stderr] Checking regex-syntax v0.6.13 [INFO] [stderr] Compiling autocfg v1.0.0 [INFO] [stderr] Compiling ryu v1.0.2 [INFO] [stderr] Compiling failure_derive v0.1.6 [INFO] [stderr] Checking unicode-width v0.1.7 [INFO] [stderr] Checking openssl-probe v0.1.2 [INFO] [stderr] Checking predicates-core v1.0.0 [INFO] [stderr] Checking vec_map v0.8.1 [INFO] [stderr] Checking itoa v0.4.4 [INFO] [stderr] Checking normalize-line-endings v0.2.2 [INFO] [stderr] Checking difference v2.0.0 [INFO] [stderr] Checking treeline v0.1.0 [INFO] [stderr] Checking fragile v0.3.0 [INFO] [stderr] Checking downcast v0.10.0 [INFO] [stderr] Compiling unicode-normalization v0.1.11 [INFO] [stderr] Compiling unicode-bidi v0.3.4 [INFO] [stderr] Checking thread_local v1.0.1 [INFO] [stderr] Checking textwrap v0.11.0 [INFO] [stderr] Checking predicates-tree v1.0.0 [INFO] [stderr] Compiling num-traits v0.2.11 [INFO] [stderr] Checking aho-corasick v0.7.6 [INFO] [stderr] Compiling quote v1.0.2 [INFO] [stderr] Compiling jobserver v0.1.19 [INFO] [stderr] Compiling cc v1.0.50 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking dirs-sys v0.3.4 [INFO] [stderr] Checking errno v0.2.4 [INFO] [stderr] Checking idna v0.2.0 [INFO] [stderr] Checking dirs v2.0.2 [INFO] [stderr] Checking pager v0.15.0 [INFO] [stderr] Checking clap v2.33.0 [INFO] [stderr] Checking float-cmp v0.5.3 [INFO] [stderr] Checking url v2.1.1 [INFO] [stderr] Checking regex v1.3.3 [INFO] [stderr] Compiling openssl-sys v0.9.53 [INFO] [stderr] Compiling libz-sys v1.0.25 [INFO] [stderr] Compiling libssh2-sys v0.2.14 [INFO] [stderr] Compiling backtrace-sys v0.1.32 [INFO] [stderr] Compiling libgit2-sys v0.10.0 [INFO] [stderr] Checking env_logger v0.7.1 [INFO] [stderr] Checking predicates v1.0.2 [INFO] [stderr] Checking backtrace v0.3.43 [INFO] [stderr] Checking git2 v0.11.0 [INFO] [stderr] Compiling synstructure v0.12.3 [INFO] [stderr] Compiling serde_derive v1.0.104 [INFO] [stderr] Compiling mockall_derive v0.6.0 [INFO] [stderr] Checking failure v0.1.6 [INFO] [stderr] Checking mockall v0.6.0 [INFO] [stderr] Compiling semver v0.9.0 [INFO] [stderr] Compiling toml v0.5.6 [INFO] [stderr] Checking serde_json v1.0.46 [INFO] [stderr] Compiling cargo-lock v4.0.1 [INFO] [stderr] Compiling built v0.4.0 [INFO] [stderr] Compiling jab v0.0.1 (/opt/rustwide/workdir) [INFO] [stdout] warning: unnecessary braces around method argument [INFO] [stdout] --> src/lib/db/postgresql/client.rs:119:14 [INFO] [stdout] | [INFO] [stdout] 119 | .ok_or({ DbError::parse_error(db_uri, DbUriParsingStep::DbName, None) })?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these braces [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_braces)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary braces around method argument [INFO] [stdout] --> src/lib/db/postgresql/client.rs:129:16 [INFO] [stdout] | [INFO] [stdout] 129 | .ok_or({ DbError::parse_error(db_uri, DbUriParsingStep::Credential, None) })?, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these braces [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary braces around method argument [INFO] [stdout] --> src/lib/db/postgresql/client.rs:133:14 [INFO] [stdout] | [INFO] [stdout] 133 | .ok_or({ DbError::parse_error(db_uri, DbUriParsingStep::HostAndPort, None) })?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these braces [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary braces around method argument [INFO] [stdout] --> src/lib/db/postgresql/client.rs:138:14 [INFO] [stdout] | [INFO] [stdout] 138 | .ok_or({ DbError::parse_error(db_uri, DbUriParsingStep::Host, None) })?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these braces [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary braces around method argument [INFO] [stdout] --> src/lib/db/postgresql/client.rs:144:14 [INFO] [stdout] | [INFO] [stdout] 144 | .ok_or({ DbError::parse_error(db_uri, DbUriParsingStep::CredentialUsername, None) })?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these braces [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary braces around method argument [INFO] [stdout] --> src/lib/db/postgresql/client.rs:175:9 [INFO] [stdout] | [INFO] [stdout] 175 | .or({ Some("".into()) }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: remove these braces [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary braces around method argument [INFO] [stdout] --> src/lib/db/postgresql/client.rs:177:43 [INFO] [stdout] | [INFO] [stdout] 177 | let port = db_connection_config.port.or({ Some("".into()) }).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: remove these braces [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary braces around method argument [INFO] [stdout] --> src/lib/db/postgresql/client.rs:119:14 [INFO] [stdout] | [INFO] [stdout] 119 | .ok_or({ DbError::parse_error(db_uri, DbUriParsingStep::DbName, None) })?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these braces [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_braces)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `super::*` [INFO] [stdout] --> src/lib/git.rs:241:9 [INFO] [stdout] | [INFO] [stdout] 241 | use super::*; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary braces around method argument [INFO] [stdout] --> src/lib/db/postgresql/client.rs:129:16 [INFO] [stdout] | [INFO] [stdout] 129 | .ok_or({ DbError::parse_error(db_uri, DbUriParsingStep::Credential, None) })?, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these braces [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary braces around method argument [INFO] [stdout] --> src/lib/db/postgresql/client.rs:133:14 [INFO] [stdout] | [INFO] [stdout] 133 | .ok_or({ DbError::parse_error(db_uri, DbUriParsingStep::HostAndPort, None) })?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these braces [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary braces around method argument [INFO] [stdout] --> src/lib/db/postgresql/client.rs:138:14 [INFO] [stdout] | [INFO] [stdout] 138 | .ok_or({ DbError::parse_error(db_uri, DbUriParsingStep::Host, None) })?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these braces [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary braces around method argument [INFO] [stdout] --> src/lib/db/postgresql/client.rs:144:14 [INFO] [stdout] | [INFO] [stdout] 144 | .ok_or({ DbError::parse_error(db_uri, DbUriParsingStep::CredentialUsername, None) })?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these braces [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary braces around method argument [INFO] [stdout] --> src/lib/db/postgresql/client.rs:175:9 [INFO] [stdout] | [INFO] [stdout] 175 | .or({ Some("".into()) }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: remove these braces [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary braces around method argument [INFO] [stdout] --> src/lib/db/postgresql/client.rs:177:43 [INFO] [stdout] | [INFO] [stdout] 177 | let port = db_connection_config.port.or({ Some("".into()) }).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: remove these braces [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: module `DbConnectionConfigTest` should have a snake case name [INFO] [stdout] --> src/lib/db/postgresql/client.rs:271:7 [INFO] [stdout] | [INFO] [stdout] 271 | mod DbConnectionConfigTest { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: convert the identifier to snake case: `db_connection_config_test` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_snake_case)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 7 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 9 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `show_cli` [INFO] [stdout] --> src/bin/jab.rs:159:22 [INFO] [stdout] | [INFO] [stdout] 159 | } else if let Some(show_cli) = cli.subcommand_matches("show") { [INFO] [stdout] | ^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_show_cli` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `show_cli` [INFO] [stdout] --> src/bin/jab.rs:159:22 [INFO] [stdout] | [INFO] [stdout] 159 | } else if let Some(show_cli) = cli.subcommand_matches("show") { [INFO] [stdout] | ^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_show_cli` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 33.44s [INFO] running `Command { std: "docker" "inspect" "03a781cc0649fb7d66bcbd4a0398b7a242c66c43a72bf1c709e1ea3f28c405b0", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "03a781cc0649fb7d66bcbd4a0398b7a242c66c43a72bf1c709e1ea3f28c405b0", kill_on_drop: false }` [INFO] [stdout] 03a781cc0649fb7d66bcbd4a0398b7a242c66c43a72bf1c709e1ea3f28c405b0