[INFO] cloning repository https://github.com/smt923/chip8 [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/smt923/chip8" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fsmt923%2Fchip8", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fsmt923%2Fchip8'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] a040c2fd498a6fa3c697f7a10b61064bbb0c9a24 [INFO] checking smt923/chip8 against master#33fdb797f59421c7bbecaa4588ed5d7a31a9494a for pr-87190-3 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fsmt923%2Fchip8" "/workspace/builds/worker-23/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-23/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/smt923/chip8 on toolchain 33fdb797f59421c7bbecaa4588ed5d7a31a9494a [INFO] running `Command { std: "/workspace/cargo-home/bin/cargo" "+33fdb797f59421c7bbecaa4588ed5d7a31a9494a" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/smt923/chip8 [INFO] finished tweaking git repo https://github.com/smt923/chip8 [INFO] tweaked toml for git repo https://github.com/smt923/chip8 written to /workspace/builds/worker-23/source/Cargo.toml [INFO] crate git repo https://github.com/smt923/chip8 already has a lockfile, it will not be regenerated [INFO] running `Command { std: "/workspace/cargo-home/bin/cargo" "+33fdb797f59421c7bbecaa4588ed5d7a31a9494a" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-23/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-23/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:34b6a614d2c27851fe6cbf88fbd1137609cefab8b10d0615aaeb6fd47975d74e" "/opt/rustwide/cargo-home/bin/cargo" "+33fdb797f59421c7bbecaa4588ed5d7a31a9494a" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 6d74b2c0aecd2909e10275aec71e59c9b5b44c6ab08e8a42be16009b73e72fb8 [INFO] running `Command { std: "docker" "start" "-a" "6d74b2c0aecd2909e10275aec71e59c9b5b44c6ab08e8a42be16009b73e72fb8", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "6d74b2c0aecd2909e10275aec71e59c9b5b44c6ab08e8a42be16009b73e72fb8", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "6d74b2c0aecd2909e10275aec71e59c9b5b44c6ab08e8a42be16009b73e72fb8", kill_on_drop: false }` [INFO] [stdout] 6d74b2c0aecd2909e10275aec71e59c9b5b44c6ab08e8a42be16009b73e72fb8 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-23/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-23/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:34b6a614d2c27851fe6cbf88fbd1137609cefab8b10d0615aaeb6fd47975d74e" "/opt/rustwide/cargo-home/bin/cargo" "+33fdb797f59421c7bbecaa4588ed5d7a31a9494a" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 617306c3cdf7caebe8c5df2bc697f99e450bac28a03ed12293a76b12f1cfc5dc [INFO] running `Command { std: "docker" "start" "-a" "617306c3cdf7caebe8c5df2bc697f99e450bac28a03ed12293a76b12f1cfc5dc", kill_on_drop: false }` [INFO] [stderr] Checking num-traits v0.1.40 [INFO] [stderr] Checking libc v0.2.30 [INFO] [stderr] Compiling sdl2-sys v0.30.0 [INFO] [stderr] Checking lazy_static v0.2.8 [INFO] [stderr] Checking bitflags v0.7.0 [INFO] [stderr] Checking rand v0.3.16 [INFO] [stderr] Checking num-integer v0.1.35 [INFO] [stderr] Checking num-iter v0.1.34 [INFO] [stderr] Checking num v0.1.40 [INFO] [stderr] Checking sdl2 v0.30.0 [INFO] [stderr] Checking chip8 v0.0.2 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused imports: `thread`, `time` [INFO] [stdout] --> src/chip8.rs:4:11 [INFO] [stdout] | [INFO] [stdout] 4 | use std::{thread, time}; [INFO] [stdout] | ^^^^^^ ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around assigned value [INFO] [stdout] --> src/chip8.rs:290:35 [INFO] [stdout] | [INFO] [stdout] 290 | let mut idx = (x + xl + ((y + yl as usize) * SCREEN_W)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Chip8` [INFO] [stdout] --> src/display.rs:7:33 [INFO] [stdout] | [INFO] [stdout] 7 | use chip8::{SCREEN_H, SCREEN_W, Chip8}; [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `display::Display` [INFO] [stdout] --> src/main.rs:10:5 [INFO] [stdout] | [INFO] [stdout] 10 | use display::Display; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `input::Input` [INFO] [stdout] --> src/main.rs:11:5 [INFO] [stdout] | [INFO] [stdout] 11 | use input::Input; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `thread`, `time` [INFO] [stdout] --> src/chip8.rs:4:11 [INFO] [stdout] | [INFO] [stdout] 4 | use std::{thread, time}; [INFO] [stdout] | ^^^^^^ ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `sdl2::pixels` [INFO] [stdout] --> src/main.rs:17:5 [INFO] [stdout] | [INFO] [stdout] 17 | use sdl2::pixels; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused label [INFO] [stdout] --> src/main.rs:43:9 [INFO] [stdout] | [INFO] [stdout] 43 | 'running: loop { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_labels)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around assigned value [INFO] [stdout] --> src/chip8.rs:290:35 [INFO] [stdout] | [INFO] [stdout] 290 | let mut idx = (x + xl + ((y + yl as usize) * SCREEN_W)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Chip8` [INFO] [stdout] --> src/display.rs:7:33 [INFO] [stdout] | [INFO] [stdout] 7 | use chip8::{SCREEN_H, SCREEN_W, Chip8}; [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `display::Display` [INFO] [stdout] --> src/main.rs:10:5 [INFO] [stdout] | [INFO] [stdout] 10 | use display::Display; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `input::Input` [INFO] [stdout] --> src/main.rs:11:5 [INFO] [stdout] | [INFO] [stdout] 11 | use input::Input; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `sdl2::pixels` [INFO] [stdout] --> src/main.rs:17:5 [INFO] [stdout] | [INFO] [stdout] 17 | use sdl2::pixels; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused label [INFO] [stdout] --> src/main.rs:43:9 [INFO] [stdout] | [INFO] [stdout] 43 | 'running: loop { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_labels)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: label name `'running` shadows a label name that is already in scope [INFO] [stdout] --> src/main.rs:73:5 [INFO] [stdout] | [INFO] [stdout] 43 | 'running: loop { [INFO] [stdout] | -------- first declared here [INFO] [stdout] ... [INFO] [stdout] 73 | 'running: loop { [INFO] [stdout] | ^^^^^^^^ label `'running` already in scope [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: label name `'running` shadows a label name that is already in scope [INFO] [stdout] --> src/main.rs:73:5 [INFO] [stdout] | [INFO] [stdout] 43 | 'running: loop { [INFO] [stdout] | -------- first declared here [INFO] [stdout] ... [INFO] [stdout] 73 | 'running: loop { [INFO] [stdout] | ^^^^^^^^ label `'running` already in scope [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated associated function `core::str::::trim_right_matches`: superseded by `trim_end_matches` [INFO] [stdout] --> src/chip8.rs:383:23 [INFO] [stdout] | [INFO] [stdout] 383 | stack = stack.trim_right_matches(" ").to_string(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: replace the use of the deprecated associated function: `trim_end_matches` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated associated function `core::str::::trim_right_matches`: superseded by `trim_end_matches` [INFO] [stdout] --> src/chip8.rs:400:21 [INFO] [stdout] | [INFO] [stdout] 400 | regs = regs.trim_right_matches(" ").to_string(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: replace the use of the deprecated associated function: `trim_end_matches` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated associated function `core::str::::trim_right_matches`: superseded by `trim_end_matches` [INFO] [stdout] --> src/chip8.rs:383:23 [INFO] [stdout] | [INFO] [stdout] 383 | stack = stack.trim_right_matches(" ").to_string(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: replace the use of the deprecated associated function: `trim_end_matches` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated associated function `core::str::::trim_right_matches`: superseded by `trim_end_matches` [INFO] [stdout] --> src/chip8.rs:400:21 [INFO] [stdout] | [INFO] [stdout] 400 | regs = regs.trim_right_matches(" ").to_string(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: replace the use of the deprecated associated function: `trim_end_matches` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/chip8.rs:276:13 [INFO] [stdout] | [INFO] [stdout] 276 | let mut n = rand::thread_rng().gen_range(0, 255); [INFO] [stdout] | ----^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/chip8.rs:276:13 [INFO] [stdout] | [INFO] [stdout] 276 | let mut n = rand::thread_rng().gen_range(0, 255); [INFO] [stdout] | ----^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: panic message is not a string literal [INFO] [stdout] --> src/main.rs:32:28 [INFO] [stdout] | [INFO] [stdout] 32 | Err(why) => panic!(why), [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_fmt_panics)]` on by default [INFO] [stdout] = note: this usage of panic!() is deprecated; it will be a hard error in Rust 2021 [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: add a "{}" format string to Display the message [INFO] [stdout] | [INFO] [stdout] 32 | Err(why) => panic!("{}", why), [INFO] [stdout] | +++++ [INFO] [stdout] help: or use std::panic::panic_any instead [INFO] [stdout] | [INFO] [stdout] 32 | Err(why) => std::panic::panic_any(why), [INFO] [stdout] | ~~~~~~~~~~~~~~~~~~~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `V` should have a snake case name [INFO] [stdout] --> src/chip8.rs:25:5 [INFO] [stdout] | [INFO] [stdout] 25 | V: [u8; 16], [INFO] [stdout] | ^ help: convert the identifier to snake case (notice the capitalization): `v` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_snake_case)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `xA` should have a snake case name [INFO] [stdout] --> src/chip8.rs:268:8 [INFO] [stdout] | [INFO] [stdout] 268 | fn xA(&mut self) { [INFO] [stdout] | ^^ help: convert the identifier to snake case: `x_a` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `xB` should have a snake case name [INFO] [stdout] --> src/chip8.rs:272:8 [INFO] [stdout] | [INFO] [stdout] 272 | fn xB(&mut self) { [INFO] [stdout] | ^^ help: convert the identifier to snake case: `x_b` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `xC` should have a snake case name [INFO] [stdout] --> src/chip8.rs:275:8 [INFO] [stdout] | [INFO] [stdout] 275 | fn xC(&mut self) { [INFO] [stdout] | ^^ help: convert the identifier to snake case: `x_c` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `xD` should have a snake case name [INFO] [stdout] --> src/chip8.rs:280:8 [INFO] [stdout] | [INFO] [stdout] 280 | fn xD(&mut self) { [INFO] [stdout] | ^^ help: convert the identifier to snake case: `x_d` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `xE` should have a snake case name [INFO] [stdout] --> src/chip8.rs:306:8 [INFO] [stdout] | [INFO] [stdout] 306 | fn xE(&mut self) { [INFO] [stdout] | ^^ help: convert the identifier to snake case: `x_e` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `xF` should have a snake case name [INFO] [stdout] --> src/chip8.rs:314:8 [INFO] [stdout] | [INFO] [stdout] 314 | fn xF(&mut self) { [INFO] [stdout] | ^^ help: convert the identifier to snake case: `x_f` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: panic message is not a string literal [INFO] [stdout] --> src/main.rs:32:28 [INFO] [stdout] | [INFO] [stdout] 32 | Err(why) => panic!(why), [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_fmt_panics)]` on by default [INFO] [stdout] = note: this usage of panic!() is deprecated; it will be a hard error in Rust 2021 [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: add a "{}" format string to Display the message [INFO] [stdout] | [INFO] [stdout] 32 | Err(why) => panic!("{}", why), [INFO] [stdout] | +++++ [INFO] [stdout] help: or use std::panic::panic_any instead [INFO] [stdout] | [INFO] [stdout] 32 | Err(why) => std::panic::panic_any(why), [INFO] [stdout] | ~~~~~~~~~~~~~~~~~~~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `V` should have a snake case name [INFO] [stdout] --> src/chip8.rs:25:5 [INFO] [stdout] | [INFO] [stdout] 25 | V: [u8; 16], [INFO] [stdout] | ^ help: convert the identifier to snake case (notice the capitalization): `v` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_snake_case)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `xA` should have a snake case name [INFO] [stdout] --> src/chip8.rs:268:8 [INFO] [stdout] | [INFO] [stdout] 268 | fn xA(&mut self) { [INFO] [stdout] | ^^ help: convert the identifier to snake case: `x_a` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `xB` should have a snake case name [INFO] [stdout] --> src/chip8.rs:272:8 [INFO] [stdout] | [INFO] [stdout] 272 | fn xB(&mut self) { [INFO] [stdout] | ^^ help: convert the identifier to snake case: `x_b` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `xC` should have a snake case name [INFO] [stdout] --> src/chip8.rs:275:8 [INFO] [stdout] | [INFO] [stdout] 275 | fn xC(&mut self) { [INFO] [stdout] | ^^ help: convert the identifier to snake case: `x_c` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `xD` should have a snake case name [INFO] [stdout] --> src/chip8.rs:280:8 [INFO] [stdout] | [INFO] [stdout] 280 | fn xD(&mut self) { [INFO] [stdout] | ^^ help: convert the identifier to snake case: `x_d` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `xE` should have a snake case name [INFO] [stdout] --> src/chip8.rs:306:8 [INFO] [stdout] | [INFO] [stdout] 306 | fn xE(&mut self) { [INFO] [stdout] | ^^ help: convert the identifier to snake case: `x_e` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `xF` should have a snake case name [INFO] [stdout] --> src/chip8.rs:314:8 [INFO] [stdout] | [INFO] [stdout] 314 | fn xF(&mut self) { [INFO] [stdout] | ^^ help: convert the identifier to snake case: `x_f` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 19 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 19 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 5.11s [INFO] running `Command { std: "docker" "inspect" "617306c3cdf7caebe8c5df2bc697f99e450bac28a03ed12293a76b12f1cfc5dc", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "617306c3cdf7caebe8c5df2bc697f99e450bac28a03ed12293a76b12f1cfc5dc", kill_on_drop: false }` [INFO] [stdout] 617306c3cdf7caebe8c5df2bc697f99e450bac28a03ed12293a76b12f1cfc5dc