[INFO] cloning repository https://github.com/muggenhor/rudoku [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/muggenhor/rudoku" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fmuggenhor%2Frudoku", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fmuggenhor%2Frudoku'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] e56514818b3e07b6644c305613068004d23f7ccf [INFO] checking muggenhor/rudoku against master#33fdb797f59421c7bbecaa4588ed5d7a31a9494a for pr-87190-3 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fmuggenhor%2Frudoku" "/workspace/builds/worker-15/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-15/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/muggenhor/rudoku on toolchain 33fdb797f59421c7bbecaa4588ed5d7a31a9494a [INFO] running `Command { std: "/workspace/cargo-home/bin/cargo" "+33fdb797f59421c7bbecaa4588ed5d7a31a9494a" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/muggenhor/rudoku [INFO] finished tweaking git repo https://github.com/muggenhor/rudoku [INFO] tweaked toml for git repo https://github.com/muggenhor/rudoku written to /workspace/builds/worker-15/source/Cargo.toml [INFO] crate git repo https://github.com/muggenhor/rudoku already has a lockfile, it will not be regenerated [INFO] running `Command { std: "/workspace/cargo-home/bin/cargo" "+33fdb797f59421c7bbecaa4588ed5d7a31a9494a" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-15/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-15/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:34b6a614d2c27851fe6cbf88fbd1137609cefab8b10d0615aaeb6fd47975d74e" "/opt/rustwide/cargo-home/bin/cargo" "+33fdb797f59421c7bbecaa4588ed5d7a31a9494a" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] b9fa2f8a1fb2725e91c27f5240ec4de20482ebdcc33f0287671450dab92be60c [INFO] running `Command { std: "docker" "start" "-a" "b9fa2f8a1fb2725e91c27f5240ec4de20482ebdcc33f0287671450dab92be60c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "b9fa2f8a1fb2725e91c27f5240ec4de20482ebdcc33f0287671450dab92be60c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "b9fa2f8a1fb2725e91c27f5240ec4de20482ebdcc33f0287671450dab92be60c", kill_on_drop: false }` [INFO] [stdout] b9fa2f8a1fb2725e91c27f5240ec4de20482ebdcc33f0287671450dab92be60c [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-15/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-15/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:34b6a614d2c27851fe6cbf88fbd1137609cefab8b10d0615aaeb6fd47975d74e" "/opt/rustwide/cargo-home/bin/cargo" "+33fdb797f59421c7bbecaa4588ed5d7a31a9494a" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] aacbb96159ba0c57faf56fc75b9849dea7271b63b5922363a1f180db0235905d [INFO] running `Command { std: "docker" "start" "-a" "aacbb96159ba0c57faf56fc75b9849dea7271b63b5922363a1f180db0235905d", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Checking libc v0.1.8 [INFO] [stderr] Checking regex v0.1.30 [INFO] [stderr] Checking log v0.3.1 [INFO] [stderr] Checking env_logger v0.3.1 [INFO] [stderr] Checking rudoku v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unnecessary parentheses around `for` iterator expression [INFO] [stdout] --> src/rudoku/mod.rs:47:18 [INFO] [stdout] | [INFO] [stdout] 47 | for i in (0 .. 9) { [INFO] [stdout] | ^^^^^^^^ help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `for` iterator expression [INFO] [stdout] --> src/rudoku/mod.rs:47:18 [INFO] [stdout] | [INFO] [stdout] 47 | for i in (0 .. 9) { [INFO] [stdout] | ^^^^^^^^ help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `for` iterator expression [INFO] [stdout] --> src/rudoku/mod.rs:67:20 [INFO] [stdout] | [INFO] [stdout] 67 | for row in (0 .. self.cells.len()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `for` iterator expression [INFO] [stdout] --> src/rudoku/mod.rs:67:20 [INFO] [stdout] | [INFO] [stdout] 67 | for row in (0 .. self.cells.len()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `for` iterator expression [INFO] [stdout] --> src/rudoku/mod.rs:68:24 [INFO] [stdout] | [INFO] [stdout] 68 | for col in (0 .. self.cells[row].len()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `for` iterator expression [INFO] [stdout] --> src/rudoku/mod.rs:68:24 [INFO] [stdout] | [INFO] [stdout] 68 | for col in (0 .. self.cells[row].len()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `for` iterator expression [INFO] [stdout] --> src/rudoku/mod.rs:85:20 [INFO] [stdout] | [INFO] [stdout] 85 | for row in (0 .. self.cells.len()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `for` iterator expression [INFO] [stdout] --> src/rudoku/mod.rs:85:20 [INFO] [stdout] | [INFO] [stdout] 85 | for row in (0 .. self.cells.len()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `for` iterator expression [INFO] [stdout] --> src/rudoku/mod.rs:101:32 [INFO] [stdout] | [INFO] [stdout] 101 | for col in (0 .. self.cells[row].len()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `for` iterator expression [INFO] [stdout] --> src/rudoku/mod.rs:101:32 [INFO] [stdout] | [INFO] [stdout] 101 | for col in (0 .. self.cells[row].len()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `for` iterator expression [INFO] [stdout] --> src/rudoku/mod.rs:111:20 [INFO] [stdout] | [INFO] [stdout] 111 | for col in (0 .. self.cells[0].len()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `for` iterator expression [INFO] [stdout] --> src/rudoku/mod.rs:111:20 [INFO] [stdout] | [INFO] [stdout] 111 | for col in (0 .. self.cells[0].len()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `for` iterator expression [INFO] [stdout] --> src/rudoku/mod.rs:113:24 [INFO] [stdout] | [INFO] [stdout] 113 | for row in (0 .. self.cells.len()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `for` iterator expression [INFO] [stdout] --> src/rudoku/mod.rs:113:24 [INFO] [stdout] | [INFO] [stdout] 113 | for row in (0 .. self.cells.len()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `for` iterator expression [INFO] [stdout] --> src/rudoku/mod.rs:118:24 [INFO] [stdout] | [INFO] [stdout] 118 | for row in (0 .. self.cells.len()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `for` iterator expression [INFO] [stdout] --> src/rudoku/mod.rs:118:24 [INFO] [stdout] | [INFO] [stdout] 118 | for row in (0 .. self.cells.len()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `for` iterator expression [INFO] [stdout] --> src/rudoku/mod.rs:127:32 [INFO] [stdout] | [INFO] [stdout] 127 | for row in (0 .. self.cells.len()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `for` iterator expression [INFO] [stdout] --> src/rudoku/mod.rs:127:32 [INFO] [stdout] | [INFO] [stdout] 127 | for row in (0 .. self.cells.len()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `for` iterator expression [INFO] [stdout] --> src/rudoku/mod.rs:137:26 [INFO] [stdout] | [INFO] [stdout] 137 | for row_block in (0 .. 3) { [INFO] [stdout] | ^^^^^^^^ help: remove these parentheses [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `for` iterator expression [INFO] [stdout] --> src/rudoku/mod.rs:137:26 [INFO] [stdout] | [INFO] [stdout] 137 | for row_block in (0 .. 3) { [INFO] [stdout] | ^^^^^^^^ help: remove these parentheses [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `for` iterator expression [INFO] [stdout] --> src/rudoku/mod.rs:138:30 [INFO] [stdout] | [INFO] [stdout] 138 | for col_block in (0 .. 3) { [INFO] [stdout] | ^^^^^^^^ help: remove these parentheses [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `for` iterator expression [INFO] [stdout] --> src/rudoku/mod.rs:138:30 [INFO] [stdout] | [INFO] [stdout] 138 | for col_block in (0 .. 3) { [INFO] [stdout] | ^^^^^^^^ help: remove these parentheses [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `for` iterator expression [INFO] [stdout] --> src/rudoku/mod.rs:141:26 [INFO] [stdout] | [INFO] [stdout] 141 | for i in (0 .. 9) { [INFO] [stdout] | ^^^^^^^^ help: remove these parentheses [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `for` iterator expression [INFO] [stdout] --> src/rudoku/mod.rs:141:26 [INFO] [stdout] | [INFO] [stdout] 141 | for i in (0 .. 9) { [INFO] [stdout] | ^^^^^^^^ help: remove these parentheses [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `for` iterator expression [INFO] [stdout] --> src/rudoku/mod.rs:150:26 [INFO] [stdout] | [INFO] [stdout] 150 | for i in (0 .. 9) { [INFO] [stdout] | ^^^^^^^^ help: remove these parentheses [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `for` iterator expression [INFO] [stdout] --> src/rudoku/mod.rs:163:34 [INFO] [stdout] | [INFO] [stdout] 163 | for i in (0 .. 9) { [INFO] [stdout] | ^^^^^^^^ help: remove these parentheses [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `for` iterator expression [INFO] [stdout] --> src/rudoku/mod.rs:150:26 [INFO] [stdout] | [INFO] [stdout] 150 | for i in (0 .. 9) { [INFO] [stdout] | ^^^^^^^^ help: remove these parentheses [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `for` iterator expression [INFO] [stdout] --> src/rudoku/mod.rs:163:34 [INFO] [stdout] | [INFO] [stdout] 163 | for i in (0 .. 9) { [INFO] [stdout] | ^^^^^^^^ help: remove these parentheses [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `...` range patterns are deprecated [INFO] [stdout] --> src/rudoku/mod.rs:271:16 [INFO] [stdout] | [INFO] [stdout] 271 | '1'...'9' => cur_puzzle.set_item(col_num, row_num, (c as usize - '0' as usize)), [INFO] [stdout] | ^^^ help: use `..=` for an inclusive range [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(ellipsis_inclusive_range_patterns)]` on by default [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `...` range patterns are deprecated [INFO] [stdout] --> src/rudoku/mod.rs:271:16 [INFO] [stdout] | [INFO] [stdout] 271 | '1'...'9' => cur_puzzle.set_item(col_num, row_num, (c as usize - '0' as usize)), [INFO] [stdout] | ^^^ help: use `..=` for an inclusive range [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(ellipsis_inclusive_range_patterns)]` on by default [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around method argument [INFO] [stdout] --> src/rudoku/mod.rs:271:64 [INFO] [stdout] | [INFO] [stdout] 271 | '1'...'9' => cur_puzzle.set_item(col_num, row_num, (c as usize - '0' as usize)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around method argument [INFO] [stdout] --> src/rudoku/mod.rs:271:64 [INFO] [stdout] | [INFO] [stdout] 271 | '1'...'9' => cur_puzzle.set_item(col_num, row_num, (c as usize - '0' as usize)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 16 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 16 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.04s [INFO] running `Command { std: "docker" "inspect" "aacbb96159ba0c57faf56fc75b9849dea7271b63b5922363a1f180db0235905d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "aacbb96159ba0c57faf56fc75b9849dea7271b63b5922363a1f180db0235905d", kill_on_drop: false }` [INFO] [stdout] aacbb96159ba0c57faf56fc75b9849dea7271b63b5922363a1f180db0235905d