[INFO] cloning repository https://github.com/conundrumer/crossword [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/conundrumer/crossword" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fconundrumer%2Fcrossword", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fconundrumer%2Fcrossword'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] cec0ee1cc7277c14c4afeb48fc9488b7fa941ab3 [INFO] checking conundrumer/crossword against master#33fdb797f59421c7bbecaa4588ed5d7a31a9494a for pr-87190-3 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fconundrumer%2Fcrossword" "/workspace/builds/worker-1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-1/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/conundrumer/crossword on toolchain 33fdb797f59421c7bbecaa4588ed5d7a31a9494a [INFO] running `Command { std: "/workspace/cargo-home/bin/cargo" "+33fdb797f59421c7bbecaa4588ed5d7a31a9494a" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/conundrumer/crossword [INFO] finished tweaking git repo https://github.com/conundrumer/crossword [INFO] tweaked toml for git repo https://github.com/conundrumer/crossword written to /workspace/builds/worker-1/source/Cargo.toml [INFO] crate git repo https://github.com/conundrumer/crossword already has a lockfile, it will not be regenerated [INFO] running `Command { std: "/workspace/cargo-home/bin/cargo" "+33fdb797f59421c7bbecaa4588ed5d7a31a9494a" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:34b6a614d2c27851fe6cbf88fbd1137609cefab8b10d0615aaeb6fd47975d74e" "/opt/rustwide/cargo-home/bin/cargo" "+33fdb797f59421c7bbecaa4588ed5d7a31a9494a" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] f96e0968da00675c9fa318e340bc9572049e711924f8ec00d0311390bbb99b24 [INFO] running `Command { std: "docker" "start" "-a" "f96e0968da00675c9fa318e340bc9572049e711924f8ec00d0311390bbb99b24", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "f96e0968da00675c9fa318e340bc9572049e711924f8ec00d0311390bbb99b24", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "f96e0968da00675c9fa318e340bc9572049e711924f8ec00d0311390bbb99b24", kill_on_drop: false }` [INFO] [stdout] f96e0968da00675c9fa318e340bc9572049e711924f8ec00d0311390bbb99b24 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:34b6a614d2c27851fe6cbf88fbd1137609cefab8b10d0615aaeb6fd47975d74e" "/opt/rustwide/cargo-home/bin/cargo" "+33fdb797f59421c7bbecaa4588ed5d7a31a9494a" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 216b8fe1f9198d008e81a68abbb9bfbc6d062e925fb4dd1d1bb9c8ecb7d98a2b [INFO] running `Command { std: "docker" "start" "-a" "216b8fe1f9198d008e81a68abbb9bfbc6d062e925fb4dd1d1bb9c8ecb7d98a2b", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Checking crossword v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unnecessary parentheses around function argument [INFO] [stdout] --> src/grid.rs:25:21 [INFO] [stdout] | [INFO] [stdout] 25 | vec![Empty; ((bb.width() as usize) * (bb.height() as usize))] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/generate.rs:41:38 [INFO] [stdout] | [INFO] [stdout] 41 | pub fn iter<'b>(&'b self) -> Box + 'b> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `dyn`: `dyn Iterator + 'b` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(bare_trait_objects)]` on by default [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/generate.rs:46:62 [INFO] [stdout] | [INFO] [stdout] 46 | pub fn multi_iter<'b>(&'b self, num_iters: usize) -> Box + 'b> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `dyn`: `dyn Iterator + 'b` [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/generate.rs:78:112 [INFO] [stdout] | [INFO] [stdout] 78 | ... -> Box>)> + 'b> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `dyn`: `dyn Iterator>)> + 'b` [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/generate.rs:89:114 [INFO] [stdout] | [INFO] [stdout] 89 | ...size>>, seed: u64) -> Box + 'b> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `dyn`: `dyn Iterator + 'b` [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/generate.rs:100:104 [INFO] [stdout] | [INFO] [stdout] 100 | ... -> Box>)> + 'b> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `dyn`: `dyn Iterator>)> + 'b` [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around function argument [INFO] [stdout] --> src/grid.rs:25:21 [INFO] [stdout] | [INFO] [stdout] 25 | vec![Empty; ((bb.width() as usize) * (bb.height() as usize))] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/generate.rs:41:38 [INFO] [stdout] | [INFO] [stdout] 41 | pub fn iter<'b>(&'b self) -> Box + 'b> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `dyn`: `dyn Iterator + 'b` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(bare_trait_objects)]` on by default [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/generate.rs:46:62 [INFO] [stdout] | [INFO] [stdout] 46 | pub fn multi_iter<'b>(&'b self, num_iters: usize) -> Box + 'b> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `dyn`: `dyn Iterator + 'b` [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/generate.rs:78:112 [INFO] [stdout] | [INFO] [stdout] 78 | ... -> Box>)> + 'b> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `dyn`: `dyn Iterator>)> + 'b` [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/generate.rs:89:114 [INFO] [stdout] | [INFO] [stdout] 89 | ...size>>, seed: u64) -> Box + 'b> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `dyn`: `dyn Iterator + 'b` [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/generate.rs:100:104 [INFO] [stdout] | [INFO] [stdout] 100 | ... -> Box>)> + 'b> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `dyn`: `dyn Iterator>)> + 'b` [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/generate.rs:187:73 [INFO] [stdout] | [INFO] [stdout] 187 | pub fn test_generator(words: Vec<&str>, num_areas: usize, test_fn: &Fn(Generator) -> ()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: use `dyn`: `dyn Fn(Generator) -> ()` [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: an associated function with this name may be added to the standard library in the future [INFO] [stdout] --> src/filter.rs:32:57 [INFO] [stdout] | [INFO] [stdout] 32 | if let Some(area) = cell_areas.borrow().last() { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unstable_name_collisions)]` on by default [INFO] [stdout] = warning: once this associated item is added to the standard library, the ambiguity may cause an error or change in behavior! [INFO] [stdout] = note: for more information, see issue #48919 [INFO] [stdout] = help: call with fully qualified syntax `CollectionWithLast::last(...)` to keep using the current method [INFO] [stdout] = help: add `#![feature(map_first_last)]` to the crate attributes to enable `BTreeSet::::last` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: an associated function with this name may be added to the standard library in the future [INFO] [stdout] --> src/filter.rs:56:44 [INFO] [stdout] | [INFO] [stdout] 56 | if let Some(last_area) = areas.last() { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: once this associated item is added to the standard library, the ambiguity may cause an error or change in behavior! [INFO] [stdout] = note: for more information, see issue #48919 [INFO] [stdout] = help: call with fully qualified syntax `CollectionWithLast::last(...)` to keep using the current method [INFO] [stdout] = help: add `#![feature(map_first_last)]` to the crate attributes to enable `BTreeSet::::last` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: an associated function with this name may be added to the standard library in the future [INFO] [stdout] --> src/filter.rs:32:57 [INFO] [stdout] | [INFO] [stdout] 32 | if let Some(area) = cell_areas.borrow().last() { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unstable_name_collisions)]` on by default [INFO] [stdout] = warning: once this associated item is added to the standard library, the ambiguity may cause an error or change in behavior! [INFO] [stdout] = note: for more information, see issue #48919 [INFO] [stdout] = help: call with fully qualified syntax `CollectionWithLast::last(...)` to keep using the current method [INFO] [stdout] = help: add `#![feature(map_first_last)]` to the crate attributes to enable `BTreeSet::::last` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: an associated function with this name may be added to the standard library in the future [INFO] [stdout] --> src/filter.rs:56:44 [INFO] [stdout] | [INFO] [stdout] 56 | if let Some(last_area) = areas.last() { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: once this associated item is added to the standard library, the ambiguity may cause an error or change in behavior! [INFO] [stdout] = note: for more information, see issue #48919 [INFO] [stdout] = help: call with fully qualified syntax `CollectionWithLast::last(...)` to keep using the current method [INFO] [stdout] = help: add `#![feature(map_first_last)]` to the crate attributes to enable `BTreeSet::::last` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/filter.rs:115:17 [INFO] [stdout] | [INFO] [stdout] 115 | let mut seen = &mut self.seen.borrow_mut(); [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated function is never used: `is_valid` [INFO] [stdout] --> src/crossword.rs:38:12 [INFO] [stdout] | [INFO] [stdout] 38 | pub fn is_valid(&self) -> bool { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated function is never used: `iter` [INFO] [stdout] --> src/generate.rs:41:12 [INFO] [stdout] | [INFO] [stdout] 41 | pub fn iter<'b>(&'b self) -> Box + 'b> { [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the feature `conservative_impl_trait` has been stable since 1.26.0 and no longer requires an attribute to enable [INFO] [stdout] --> src/main.rs:1:12 [INFO] [stdout] | [INFO] [stdout] 1 | #![feature(conservative_impl_trait)] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(stable_features)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 12 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/filter.rs:115:17 [INFO] [stdout] | [INFO] [stdout] 115 | let mut seen = &mut self.seen.borrow_mut(); [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: type alias is never used: `WordPosition` [INFO] [stdout] --> src/generate.rs:185:5 [INFO] [stdout] | [INFO] [stdout] 185 | type WordPosition = (&'static str, Position); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the feature `conservative_impl_trait` has been stable since 1.26.0 and no longer requires an attribute to enable [INFO] [stdout] --> src/main.rs:1:12 [INFO] [stdout] | [INFO] [stdout] 1 | #![feature(conservative_impl_trait)] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(stable_features)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 12 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 10.17s [INFO] running `Command { std: "docker" "inspect" "216b8fe1f9198d008e81a68abbb9bfbc6d062e925fb4dd1d1bb9c8ecb7d98a2b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "216b8fe1f9198d008e81a68abbb9bfbc6d062e925fb4dd1d1bb9c8ecb7d98a2b", kill_on_drop: false }` [INFO] [stdout] 216b8fe1f9198d008e81a68abbb9bfbc6d062e925fb4dd1d1bb9c8ecb7d98a2b