[INFO] cloning repository https://github.com/audiocogs/mp3.rs [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/audiocogs/mp3.rs" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Faudiocogs%2Fmp3.rs", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Faudiocogs%2Fmp3.rs'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 407184f0ad208eceedbeb578340a0fe76f681af5 [INFO] checking audiocogs/mp3.rs against master#33fdb797f59421c7bbecaa4588ed5d7a31a9494a for pr-87190-3 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Faudiocogs%2Fmp3.rs" "/workspace/builds/worker-12/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-12/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/audiocogs/mp3.rs on toolchain 33fdb797f59421c7bbecaa4588ed5d7a31a9494a [INFO] running `Command { std: "/workspace/cargo-home/bin/cargo" "+33fdb797f59421c7bbecaa4588ed5d7a31a9494a" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/audiocogs/mp3.rs [INFO] finished tweaking git repo https://github.com/audiocogs/mp3.rs [INFO] tweaked toml for git repo https://github.com/audiocogs/mp3.rs written to /workspace/builds/worker-12/source/Cargo.toml [INFO] crate git repo https://github.com/audiocogs/mp3.rs already has a lockfile, it will not be regenerated [INFO] running `Command { std: "/workspace/cargo-home/bin/cargo" "+33fdb797f59421c7bbecaa4588ed5d7a31a9494a" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-12/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-12/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:34b6a614d2c27851fe6cbf88fbd1137609cefab8b10d0615aaeb6fd47975d74e" "/opt/rustwide/cargo-home/bin/cargo" "+33fdb797f59421c7bbecaa4588ed5d7a31a9494a" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 8701a2284f6029d2291affe1758e7d42efe8c0339537691c21fdc5b39c30ff71 [INFO] running `Command { std: "docker" "start" "-a" "8701a2284f6029d2291affe1758e7d42efe8c0339537691c21fdc5b39c30ff71", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "8701a2284f6029d2291affe1758e7d42efe8c0339537691c21fdc5b39c30ff71", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "8701a2284f6029d2291affe1758e7d42efe8c0339537691c21fdc5b39c30ff71", kill_on_drop: false }` [INFO] [stdout] 8701a2284f6029d2291affe1758e7d42efe8c0339537691c21fdc5b39c30ff71 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-12/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-12/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:34b6a614d2c27851fe6cbf88fbd1137609cefab8b10d0615aaeb6fd47975d74e" "/opt/rustwide/cargo-home/bin/cargo" "+33fdb797f59421c7bbecaa4588ed5d7a31a9494a" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 97898e58dbc87f3e9e80e17970a8a4740b1800c652f7b6c5eb8d98716906d1ef [INFO] running `Command { std: "docker" "start" "-a" "97898e58dbc87f3e9e80e17970a8a4740b1800c652f7b6c5eb8d98716906d1ef", kill_on_drop: false }` [INFO] [stderr] Checking bitflags v0.1.1 [INFO] [stderr] Checking mp3 v0.0.1 (/opt/rustwide/workdir) [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/frame.rs:12:33 [INFO] [stdout] | [INFO] [stdout] 12 | pub fn read_from(reader: &mut peeker::Peeker) -> io::Result> { [INFO] [stdout] | ^^^^^^^^^^^^^^ help: use `dyn`: `dyn peeker::Peeker` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(bare_trait_objects)]` on by default [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/header.rs:195:33 [INFO] [stdout] | [INFO] [stdout] 195 | pub fn read_from(reader: &mut Peeker) -> io::Result> { [INFO] [stdout] | ^^^^^^ help: use `dyn`: `dyn Peeker` [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/peeker.rs:33:38 [INFO] [stdout] | [INFO] [stdout] 33 | let mut pkr = Box::new(buf) as Box; [INFO] [stdout] | ^^^^^^ help: use `dyn`: `dyn Peeker` [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/peeker.rs:41:38 [INFO] [stdout] | [INFO] [stdout] 41 | let mut pkr = Box::new(buf) as Box; [INFO] [stdout] | ^^^^^^ help: use `dyn`: `dyn Peeker` [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::io::SeekFrom` [INFO] [stdout] --> src/bitreader.rs:3:5 [INFO] [stdout] | [INFO] [stdout] 3 | use std::io::SeekFrom; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/bitreader.rs:8:20 [INFO] [stdout] | [INFO] [stdout] 8 | reader: &'a mut (io::Read + 'a) [INFO] [stdout] | ^^^^^^^^^^^^^ help: use `dyn`: `dyn io::Read + 'a` [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/bitreader.rs:12:30 [INFO] [stdout] | [INFO] [stdout] 12 | pub fn new(reader: &'a mut io::Read) -> BitReader<'a> { [INFO] [stdout] | ^^^^^^^^ help: use `dyn`: `dyn io::Read` [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `for` iterator expression [INFO] [stdout] --> src/bitreader.rs:19:14 [INFO] [stdout] | [INFO] [stdout] 19 | for _ in (0..n) { [INFO] [stdout] | ^^^^^^ help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/frame.rs:12:33 [INFO] [stdout] | [INFO] [stdout] 12 | pub fn read_from(reader: &mut peeker::Peeker) -> io::Result> { [INFO] [stdout] | ^^^^^^^^^^^^^^ help: use `dyn`: `dyn peeker::Peeker` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(bare_trait_objects)]` on by default [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/header.rs:195:33 [INFO] [stdout] | [INFO] [stdout] 195 | pub fn read_from(reader: &mut Peeker) -> io::Result> { [INFO] [stdout] | ^^^^^^ help: use `dyn`: `dyn Peeker` [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::io::Cursor` [INFO] [stdout] --> src/peeker.rs:3:5 [INFO] [stdout] | [INFO] [stdout] 3 | use std::io::Cursor; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::io::Cursor` [INFO] [stdout] --> src/bitreader.rs:2:5 [INFO] [stdout] | [INFO] [stdout] 2 | use std::io::Cursor; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::io::SeekFrom` [INFO] [stdout] --> src/bitreader.rs:3:5 [INFO] [stdout] | [INFO] [stdout] 3 | use std::io::SeekFrom; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/bitreader.rs:8:20 [INFO] [stdout] | [INFO] [stdout] 8 | reader: &'a mut (io::Read + 'a) [INFO] [stdout] | ^^^^^^^^^^^^^ help: use `dyn`: `dyn io::Read + 'a` [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/bitreader.rs:12:30 [INFO] [stdout] | [INFO] [stdout] 12 | pub fn new(reader: &'a mut io::Read) -> BitReader<'a> { [INFO] [stdout] | ^^^^^^^^ help: use `dyn`: `dyn io::Read` [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `for` iterator expression [INFO] [stdout] --> src/bitreader.rs:19:14 [INFO] [stdout] | [INFO] [stdout] 19 | for _ in (0..n) { [INFO] [stdout] | ^^^^^^ help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::io` [INFO] [stdout] --> src/layer1.rs:1:5 [INFO] [stdout] | [INFO] [stdout] 1 | use std::io; [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::io::Cursor` [INFO] [stdout] --> src/layer1.rs:2:5 [INFO] [stdout] | [INFO] [stdout] 2 | use std::io::Cursor; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::io::Seek` [INFO] [stdout] --> src/peeker.rs:2:5 [INFO] [stdout] | [INFO] [stdout] 2 | use std::io::Seek; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `samples` [INFO] [stdout] --> src/main.rs:26:15 [INFO] [stdout] | [INFO] [stdout] 26 | let samples = layer1::decode_layer1(&mut reader, h.header); [INFO] [stdout] | ^^^^^^^ help: if this is intentional, prefix it with an underscore: `_samples` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 12 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::io::Seek` [INFO] [stdout] --> src/peeker.rs:2:5 [INFO] [stdout] | [INFO] [stdout] 2 | use std::io::Seek; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `samples` [INFO] [stdout] --> src/main.rs:26:15 [INFO] [stdout] | [INFO] [stdout] 26 | let samples = layer1::decode_layer1(&mut reader, h.header); [INFO] [stdout] | ^^^^^^^ help: if this is intentional, prefix it with an underscore: `_samples` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/peeker.rs:32:7 [INFO] [stdout] | [INFO] [stdout] 32 | let mut buf = Cursor::new(vec![0xFFu8, 0xAA, 0x44, 0xA3]); [INFO] [stdout] | ----^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/peeker.rs:40:7 [INFO] [stdout] | [INFO] [stdout] 40 | let mut buf = Cursor::new(vec![0xFFu8, 0xAA, 0x44, 0xA3, 0x34, 0x99, 0x44]); [INFO] [stdout] | ----^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 12 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.85s [INFO] running `Command { std: "docker" "inspect" "97898e58dbc87f3e9e80e17970a8a4740b1800c652f7b6c5eb8d98716906d1ef", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "97898e58dbc87f3e9e80e17970a8a4740b1800c652f7b6c5eb8d98716906d1ef", kill_on_drop: false }` [INFO] [stdout] 97898e58dbc87f3e9e80e17970a8a4740b1800c652f7b6c5eb8d98716906d1ef