[INFO] cloning repository https://github.com/TomasLongo/rdnglst [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/TomasLongo/rdnglst" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FTomasLongo%2Frdnglst", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FTomasLongo%2Frdnglst'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] cb2623d68b3ccfe10fc78c2b9a337b22445d89aa [INFO] testing TomasLongo/rdnglst against master#432e145bd5a974c5b6f4dd9b352891bd7502b69d for pr-87041 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FTomasLongo%2Frdnglst" "/workspace/builds/worker-5/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-5/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/TomasLongo/rdnglst on toolchain 432e145bd5a974c5b6f4dd9b352891bd7502b69d [INFO] running `Command { std: "/workspace/cargo-home/bin/cargo" "+432e145bd5a974c5b6f4dd9b352891bd7502b69d" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/TomasLongo/rdnglst [INFO] finished tweaking git repo https://github.com/TomasLongo/rdnglst [INFO] tweaked toml for git repo https://github.com/TomasLongo/rdnglst written to /workspace/builds/worker-5/source/Cargo.toml [INFO] crate git repo https://github.com/TomasLongo/rdnglst already has a lockfile, it will not be regenerated [INFO] running `Command { std: "/workspace/cargo-home/bin/cargo" "+432e145bd5a974c5b6f4dd9b352891bd7502b69d" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:34b6a614d2c27851fe6cbf88fbd1137609cefab8b10d0615aaeb6fd47975d74e" "/opt/rustwide/cargo-home/bin/cargo" "+432e145bd5a974c5b6f4dd9b352891bd7502b69d" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 8a87a77c96abe443630540dea0e73e4f4226b0a3b3c26847bb085709761dd053 [INFO] running `Command { std: "docker" "start" "-a" "8a87a77c96abe443630540dea0e73e4f4226b0a3b3c26847bb085709761dd053", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "8a87a77c96abe443630540dea0e73e4f4226b0a3b3c26847bb085709761dd053", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "8a87a77c96abe443630540dea0e73e4f4226b0a3b3c26847bb085709761dd053", kill_on_drop: false }` [INFO] [stdout] 8a87a77c96abe443630540dea0e73e4f4226b0a3b3c26847bb085709761dd053 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:34b6a614d2c27851fe6cbf88fbd1137609cefab8b10d0615aaeb6fd47975d74e" "/opt/rustwide/cargo-home/bin/cargo" "+432e145bd5a974c5b6f4dd9b352891bd7502b69d" "build" "--frozen" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 5672c4b33607239a9d7d6b6a2abedbb80192e0e09664b18664ec3ec0a86f567d [INFO] running `Command { std: "docker" "start" "-a" "5672c4b33607239a9d7d6b6a2abedbb80192e0e09664b18664ec3ec0a86f567d", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.81 [INFO] [stderr] Compiling proc-macro2 v1.0.24 [INFO] [stderr] Compiling version_check v0.9.2 [INFO] [stderr] Compiling cfg-if v0.1.10 [INFO] [stderr] Compiling syn v1.0.57 [INFO] [stderr] Compiling smallvec v1.6.0 [INFO] [stderr] Compiling scopeguard v1.1.0 [INFO] [stderr] Compiling serde v1.0.120 [INFO] [stderr] Compiling vec_map v0.8.2 [INFO] [stderr] Compiling remove_dir_all v0.5.3 [INFO] [stderr] Compiling numtoa v0.1.0 [INFO] [stderr] Compiling strsim v0.8.0 [INFO] [stderr] Compiling ansi_term v0.11.0 [INFO] [stderr] Compiling fallible-streaming-iterator v0.1.9 [INFO] [stderr] Compiling zeroize v0.9.3 [INFO] [stderr] Compiling fallible-iterator v0.2.0 [INFO] [stderr] Compiling heck v0.3.2 [INFO] [stderr] Compiling instant v0.1.9 [INFO] [stderr] Compiling libsqlite3-sys v0.20.1 [INFO] [stderr] Compiling textwrap v0.11.0 [INFO] [stderr] Compiling hashbrown v0.9.1 [INFO] [stderr] Compiling regex v1.4.2 [INFO] [stderr] Compiling log v0.4.11 [INFO] [stderr] Compiling lock_api v0.4.2 [INFO] [stderr] Compiling proc-macro-error-attr v1.0.4 [INFO] [stderr] Compiling proc-macro-error v1.0.4 [INFO] [stderr] Compiling hashlink v0.6.0 [INFO] [stderr] Compiling quote v1.0.8 [INFO] [stderr] Compiling rusqlite v0.24.2 [INFO] [stderr] Compiling getrandom v0.1.16 [INFO] [stderr] Compiling mio v0.7.7 [INFO] [stderr] Compiling parking_lot_core v0.8.2 [INFO] [stderr] Compiling signal-hook-registry v1.3.0 [INFO] [stderr] Compiling terminal_size v0.1.15 [INFO] [stderr] Compiling atty v0.2.14 [INFO] [stderr] Compiling termion v1.5.5 [INFO] [stderr] Compiling console v0.13.0 [INFO] [stderr] Compiling clap v2.33.3 [INFO] [stderr] Compiling rand_core v0.5.1 [INFO] [stderr] Compiling signal-hook v0.1.17 [INFO] [stderr] Compiling parking_lot v0.11.1 [INFO] [stderr] Compiling rand_chacha v0.2.2 [INFO] [stderr] Compiling tui v0.14.0 [INFO] [stderr] Compiling crossterm v0.19.0 [INFO] [stderr] Compiling rand v0.7.3 [INFO] [stderr] Compiling tempfile v3.1.0 [INFO] [stderr] Compiling dialoguer v0.7.1 [INFO] [stderr] Compiling toml v0.5.8 [INFO] [stderr] Compiling structopt-derive v0.4.14 [INFO] [stderr] Compiling strum_macros v0.20.1 [INFO] [stderr] Compiling comfy-table v1.5.0 [INFO] [stderr] Compiling structopt v0.3.21 [INFO] [stderr] Compiling readinglist v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `MappedRows` [INFO] [stdout] --> src/lib.rs:2:27 [INFO] [stdout] | [INFO] [stdout] 2 | use rusqlite::{NO_PARAMS, MappedRows, types::FromSql, types::FromSqlResult, types::ValueRef}; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `s` [INFO] [stdout] --> src/lib.rs:24:16 [INFO] [stdout] | [INFO] [stdout] 24 | Ok(s) => { [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_s` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `stringToFormatEnum` should have a snake case name [INFO] [stdout] --> src/lib.rs:32:8 [INFO] [stdout] | [INFO] [stdout] 32 | pub fn stringToFormatEnum(toConvert: &str) -> Format { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: convert the identifier to snake case: `string_to_format_enum` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_snake_case)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `toConvert` should have a snake case name [INFO] [stdout] --> src/lib.rs:32:27 [INFO] [stdout] | [INFO] [stdout] 32 | pub fn stringToFormatEnum(toConvert: &str) -> Format { [INFO] [stdout] | ^^^^^^^^^ help: convert the identifier to snake case: `to_convert` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `formatEnumToString` should have a snake case name [INFO] [stdout] --> src/lib.rs:43:8 [INFO] [stdout] | [INFO] [stdout] 43 | pub fn formatEnumToString(f: &Format) -> String { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: convert the identifier to snake case: `format_enum_to_string` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait method `getById` should have a snake case name [INFO] [stdout] --> src/lib.rs:51:8 [INFO] [stdout] | [INFO] [stdout] 51 | fn getById(&self, id: i64) -> Result; [INFO] [stdout] | ^^^^^^^ help: convert the identifier to snake case: `get_by_id` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait method `deleteById` should have a snake case name [INFO] [stdout] --> src/lib.rs:52:8 [INFO] [stdout] | [INFO] [stdout] 52 | fn deleteById(&self, id: i64) -> Result; [INFO] [stdout] | ^^^^^^^^^^ help: convert the identifier to snake case: `delete_by_id` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait method `updateEntry` should have a snake case name [INFO] [stdout] --> src/lib.rs:53:8 [INFO] [stdout] | [INFO] [stdout] 53 | fn updateEntry(&self, toUpdate: &ReadingEntry); [INFO] [stdout] | ^^^^^^^^^^^ help: convert the identifier to snake case: `update_entry` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `toUpdate` should have a snake case name [INFO] [stdout] --> src/lib.rs:53:27 [INFO] [stdout] | [INFO] [stdout] 53 | fn updateEntry(&self, toUpdate: &ReadingEntry); [INFO] [stdout] | ^^^^^^^^ help: convert the identifier to snake case: `to_update` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait method `addEntry` should have a snake case name [INFO] [stdout] --> src/lib.rs:54:8 [INFO] [stdout] | [INFO] [stdout] 54 | fn addEntry(&self, e: &ReadingEntry); [INFO] [stdout] | ^^^^^^^^ help: convert the identifier to snake case: `add_entry` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait method `getAllEntries` should have a snake case name [INFO] [stdout] --> src/lib.rs:55:8 [INFO] [stdout] | [INFO] [stdout] 55 | fn getAllEntries(&self) -> Result>; [INFO] [stdout] | ^^^^^^^^^^^^^ help: convert the identifier to snake case: `get_all_entries` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `entryToDelete` should have a snake case name [INFO] [stdout] --> src/lib.rs:114:13 [INFO] [stdout] | [INFO] [stdout] 114 | let entryToDelete = self.getById(id)?; [INFO] [stdout] | ^^^^^^^^^^^^^ help: convert the identifier to snake case: `entry_to_delete` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `toUpdate` should have a snake case name [INFO] [stdout] --> src/lib.rs:122:27 [INFO] [stdout] | [INFO] [stdout] 122 | fn updateEntry(&self, toUpdate: &ReadingEntry) { [INFO] [stdout] | ^^^^^^^^ help: convert the identifier to snake case: `to_update` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `insertString` should have a snake case name [INFO] [stdout] --> src/lib.rs:123:13 [INFO] [stdout] | [INFO] [stdout] 123 | ... let insertString = "update reading_entries set title = ?1, author = ?2, genre = ?3, format = ?4, tags = ?5, status = ?6 where id = ... [INFO] [stdout] | ^^^^^^^^^^^^ help: convert the identifier to snake case: `insert_string` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/lib.rs:124:9 [INFO] [stdout] | [INFO] [stdout] 124 | / ... self.conn.execute(insertString, [INFO] [stdout] 125 | | ... &[&toUpdate.title, &toUpdate.author, &toUpdate.genre, &formatEnumToString(&toUpdate.format), &toUpdate.tags.join(" "), &toUpdate.status, &toUpdate.id.to_string()]); [INFO] [stdout] | |____________________________________________________________________________________________________________________________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `insertString` should have a snake case name [INFO] [stdout] --> src/lib.rs:129:13 [INFO] [stdout] | [INFO] [stdout] 129 | let insertString = "insert into reading_entries (title, author, genre, format, tags, status) values (?1, ?2, ?3, ?4, ?5, ?6);"; [INFO] [stdout] | ^^^^^^^^^^^^ help: convert the identifier to snake case: `insert_string` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/lib.rs:130:9 [INFO] [stdout] | [INFO] [stdout] 130 | ... self.conn.execute(insertString, &[&re.title, &re.author, &re.genre, &formatEnumToString(&re.format), &re.tags.join(" "), &re.status]); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `entryList` should have a snake case name [INFO] [stdout] --> src/lib.rs:158:17 [INFO] [stdout] | [INFO] [stdout] 158 | let mut entryList = Vec::new(); [INFO] [stdout] | ^^^^^^^^^ help: convert the identifier to snake case: `entry_list` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 18 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `super::CONFIG` [INFO] [stdout] --> src/querylanguage.rs:1:5 [INFO] [stdout] | [INFO] [stdout] 1 | use super::CONFIG; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::result` [INFO] [stdout] --> src/querylanguage.rs:4:5 [INFO] [stdout] | [INFO] [stdout] 4 | use std::result; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Connection` [INFO] [stdout] --> src/main.rs:10:16 [INFO] [stdout] | [INFO] [stdout] 10 | use rusqlite::{Connection, Result}; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/main.rs:206:12 [INFO] [stdout] | [INFO] [stdout] 206 | if (dir.len() == 1) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning[E0170]: pattern binding `Equal` is named the same as one of the variants of the type `CompType` [INFO] [stdout] --> src/querylanguage.rs:26:9 [INFO] [stdout] | [INFO] [stdout] 26 | Equal => { [INFO] [stdout] | ^^^^^ help: to match on the variant, qualify the path: `CompType::Equal` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(bindings_with_variant_name)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `splits` [INFO] [stdout] --> src/main.rs:101:9 [INFO] [stdout] | [INFO] [stdout] 101 | let splits = tags.split(" "); [INFO] [stdout] | ^^^^^^ help: if this is intentional, prefix it with an underscore: `_splits` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `Equal` [INFO] [stdout] --> src/querylanguage.rs:26:9 [INFO] [stdout] | [INFO] [stdout] 26 | Equal => { [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_Equal` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/querylanguage.rs:129:9 [INFO] [stdout] | [INFO] [stdout] 129 | let mut comp: Comparison = Comparison::default(); [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct is never constructed: `Table` [INFO] [stdout] --> src/querylanguage.rs:76:12 [INFO] [stdout] | [INFO] [stdout] 76 | pub struct Table { [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant is never constructed: `Col` [INFO] [stdout] --> src/querylanguage.rs:91:5 [INFO] [stdout] | [INFO] [stdout] 91 | Col, [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant is never constructed: `Contains` [INFO] [stdout] --> src/querylanguage.rs:244:5 [INFO] [stdout] | [INFO] [stdout] 244 | Contains, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant is never constructed: `Or` [INFO] [stdout] --> src/querylanguage.rs:251:5 [INFO] [stdout] | [INFO] [stdout] 251 | Or [INFO] [stdout] | ^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated function is never used: `new` [INFO] [stdout] --> src/querylanguage.rs:274:8 [INFO] [stdout] | [INFO] [stdout] 274 | fn new(left: Comparison, right: Option, t: ModType) -> Modifier { [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function is never used: `info` [INFO] [stdout] --> src/log.rs:3:8 [INFO] [stdout] | [INFO] [stdout] 3 | pub fn info(msg: &String) { [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: panic message is not a string literal [INFO] [stdout] --> src/querylanguage.rs:176:28 [INFO] [stdout] | [INFO] [stdout] 176 | panic!(String::from("Expected a col ident")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_fmt_panics)]` on by default [INFO] [stdout] = note: this usage of panic!() is deprecated; it will be a hard error in Rust 2021 [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: add a "{}" format string to Display the message [INFO] [stdout] | [INFO] [stdout] 176 | panic!("{}", String::from("Expected a col ident")); [INFO] [stdout] | ^^^^^ [INFO] [stdout] help: or use std::panic::panic_any instead [INFO] [stdout] | [INFO] [stdout] 176 | std::panic::panic_any(String::from("Expected a col ident")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: panic message is not a string literal [INFO] [stdout] --> src/querylanguage.rs:231:16 [INFO] [stdout] | [INFO] [stdout] 231 | panic!(String::from("Wrong state")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this usage of panic!() is deprecated; it will be a hard error in Rust 2021 [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: add a "{}" format string to Display the message [INFO] [stdout] | [INFO] [stdout] 231 | panic!("{}", String::from("Wrong state")); [INFO] [stdout] | ^^^^^ [INFO] [stdout] help: or use std::panic::panic_any instead [INFO] [stdout] | [INFO] [stdout] 231 | std::panic::panic_any(String::from("Wrong state")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `withId` should have a snake case name [INFO] [stdout] --> src/main.rs:37:5 [INFO] [stdout] | [INFO] [stdout] 37 | withId: bool, [INFO] [stdout] | ^^^^^^ help: convert the identifier to snake case: `with_id` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_snake_case)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `promptForUpdate` should have a snake case name [INFO] [stdout] --> src/main.rs:70:4 [INFO] [stdout] | [INFO] [stdout] 70 | fn promptForUpdate(toUpdate: &ReadingEntry) -> ReadingEntry { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: convert the identifier to snake case: `prompt_for_update` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `toUpdate` should have a snake case name [INFO] [stdout] --> src/main.rs:70:20 [INFO] [stdout] | [INFO] [stdout] 70 | fn promptForUpdate(toUpdate: &ReadingEntry) -> ReadingEntry { [INFO] [stdout] | ^^^^^^^^ help: convert the identifier to snake case: `to_update` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `splittedTags` should have a snake case name [INFO] [stdout] --> src/main.rs:78:9 [INFO] [stdout] | [INFO] [stdout] 78 | let splittedTags = tags.split(" ").map(|x| String::from(x)).collect(); [INFO] [stdout] | ^^^^^^^^^^^^ help: convert the identifier to snake case: `splitted_tags` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `splittedTags` should have a snake case name [INFO] [stdout] --> src/main.rs:103:9 [INFO] [stdout] | [INFO] [stdout] 103 | let splittedTags = tags.split(" ").map(|x| String::from(x)).collect(); [INFO] [stdout] | ^^^^^^^^^^^^ help: convert the identifier to snake case: `splitted_tags` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `withId` should have a snake case name [INFO] [stdout] --> src/main.rs:126:45 [INFO] [stdout] | [INFO] [stdout] 126 | fn print_table(entries: &Vec, withId: bool) -> Table { [INFO] [stdout] | ^^^^^^ help: convert the identifier to snake case: `with_id` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `formatString` should have a snake case name [INFO] [stdout] --> src/main.rs:139:13 [INFO] [stdout] | [INFO] [stdout] 139 | let formatString = formatEnumToString(&e.format); [INFO] [stdout] | ^^^^^^^^^^^^ help: convert the identifier to snake case: `format_string` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `idString` should have a snake case name [INFO] [stdout] --> src/main.rs:149:13 [INFO] [stdout] | [INFO] [stdout] 149 | let idString = &e.id.to_string(); [INFO] [stdout] | ^^^^^^^^ help: convert the identifier to snake case: `id_string` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `createHeaderVec` should have a snake case name [INFO] [stdout] --> src/main.rs:160:4 [INFO] [stdout] | [INFO] [stdout] 160 | fn createHeaderVec() -> Vec { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: convert the identifier to snake case: `create_header_vec` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `createTableRowFromReadingEntry` should have a snake case name [INFO] [stdout] --> src/main.rs:170:4 [INFO] [stdout] | [INFO] [stdout] 170 | fn createTableRowFromReadingEntry(re: &ReadingEntry) -> TableRow { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: convert the identifier to snake case: `create_table_row_from_reading_entry` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `initConfig` should have a snake case name [INFO] [stdout] --> src/main.rs:181:4 [INFO] [stdout] | [INFO] [stdout] 181 | fn initConfig() -> Config { [INFO] [stdout] | ^^^^^^^^^^ help: convert the identifier to snake case: `init_config` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `expandTilde` should have a snake case name [INFO] [stdout] --> src/main.rs:199:4 [INFO] [stdout] | [INFO] [stdout] 199 | fn expandTilde(dir: &String) -> String { [INFO] [stdout] | ^^^^^^^^^^^ help: convert the identifier to snake case: `expand_tilde` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `createAppFolderIfNeccessary` should have a snake case name [INFO] [stdout] --> src/main.rs:217:4 [INFO] [stdout] | [INFO] [stdout] 217 | fn createAppFolderIfNeccessary() -> std::io::Result<()>{ [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: convert the identifier to snake case: `create_app_folder_if_neccessary` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/main.rs:231:5 [INFO] [stdout] | [INFO] [stdout] 231 | createAppFolderIfNeccessary(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `toUpdate` should have a snake case name [INFO] [stdout] --> src/main.rs:241:17 [INFO] [stdout] | [INFO] [stdout] 241 | let toUpdate = backend.getById(id)?; [INFO] [stdout] | ^^^^^^^^ help: convert the identifier to snake case: `to_update` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/main.rs:246:13 [INFO] [stdout] | [INFO] [stdout] 246 | backend.deleteById(id); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `filteredEntries` should have a snake case name [INFO] [stdout] --> src/main.rs:253:21 [INFO] [stdout] | [INFO] [stdout] 253 | let filteredEntries = entries.into_iter() [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: convert the identifier to snake case: `filtered_entries` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `Equal` should have a snake case name [INFO] [stdout] --> src/querylanguage.rs:26:9 [INFO] [stdout] | [INFO] [stdout] 26 | Equal => { [INFO] [stdout] | ^^^^^ help: convert the identifier to snake case: `equal` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `currentModifier` should have a snake case name [INFO] [stdout] --> src/querylanguage.rs:136:13 [INFO] [stdout] | [INFO] [stdout] 136 | let mut currentModifier: &mut Modifier = &mut root; [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: convert the identifier to snake case: `current_modifier` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `withId` should have a snake case name [INFO] [stdout] --> src/config.rs:4:9 [INFO] [stdout] | [INFO] [stdout] 4 | pub withId: bool, [INFO] [stdout] | ^^^^^^ help: convert the identifier to snake case: `with_id` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 36 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] For more information about this error, try `rustc --explain E0170`. [INFO] [stdout] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 34.13s [INFO] running `Command { std: "docker" "inspect" "5672c4b33607239a9d7d6b6a2abedbb80192e0e09664b18664ec3ec0a86f567d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "5672c4b33607239a9d7d6b6a2abedbb80192e0e09664b18664ec3ec0a86f567d", kill_on_drop: false }` [INFO] [stdout] 5672c4b33607239a9d7d6b6a2abedbb80192e0e09664b18664ec3ec0a86f567d [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:34b6a614d2c27851fe6cbf88fbd1137609cefab8b10d0615aaeb6fd47975d74e" "/opt/rustwide/cargo-home/bin/cargo" "+432e145bd5a974c5b6f4dd9b352891bd7502b69d" "test" "--frozen" "--no-run" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 36dc19e3c6c046226ce6d45f0b3922c9e53c07b0d32ee404e906af575241bdec [INFO] running `Command { std: "docker" "start" "-a" "36dc19e3c6c046226ce6d45f0b3922c9e53c07b0d32ee404e906af575241bdec", kill_on_drop: false }` [INFO] [stdout] warning: unused import: `MappedRows` [INFO] [stdout] --> src/lib.rs:2:27 [INFO] [stdout] | [INFO] [stdout] 2 | use rusqlite::{NO_PARAMS, MappedRows, types::FromSql, types::FromSqlResult, types::ValueRef}; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `s` [INFO] [stdout] --> src/lib.rs:24:16 [INFO] [stdout] | [INFO] [stdout] 24 | Ok(s) => { [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_s` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `stringToFormatEnum` should have a snake case name [INFO] [stdout] --> src/lib.rs:32:8 [INFO] [stdout] | [INFO] [stdout] 32 | pub fn stringToFormatEnum(toConvert: &str) -> Format { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: convert the identifier to snake case: `string_to_format_enum` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_snake_case)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `toConvert` should have a snake case name [INFO] [stdout] --> src/lib.rs:32:27 [INFO] [stdout] | [INFO] [stdout] 32 | pub fn stringToFormatEnum(toConvert: &str) -> Format { [INFO] [stdout] | ^^^^^^^^^ help: convert the identifier to snake case: `to_convert` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `formatEnumToString` should have a snake case name [INFO] [stdout] --> src/lib.rs:43:8 [INFO] [stdout] | [INFO] [stdout] 43 | pub fn formatEnumToString(f: &Format) -> String { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: convert the identifier to snake case: `format_enum_to_string` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait method `getById` should have a snake case name [INFO] [stdout] --> src/lib.rs:51:8 [INFO] [stdout] | [INFO] [stdout] 51 | fn getById(&self, id: i64) -> Result; [INFO] [stdout] | ^^^^^^^ help: convert the identifier to snake case: `get_by_id` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait method `deleteById` should have a snake case name [INFO] [stdout] --> src/lib.rs:52:8 [INFO] [stdout] | [INFO] [stdout] 52 | fn deleteById(&self, id: i64) -> Result; [INFO] [stdout] | ^^^^^^^^^^ help: convert the identifier to snake case: `delete_by_id` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait method `updateEntry` should have a snake case name [INFO] [stdout] --> src/lib.rs:53:8 [INFO] [stdout] | [INFO] [stdout] 53 | fn updateEntry(&self, toUpdate: &ReadingEntry); [INFO] [stdout] | ^^^^^^^^^^^ help: convert the identifier to snake case: `update_entry` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `toUpdate` should have a snake case name [INFO] [stdout] --> src/lib.rs:53:27 [INFO] [stdout] | [INFO] [stdout] 53 | fn updateEntry(&self, toUpdate: &ReadingEntry); [INFO] [stdout] | ^^^^^^^^ help: convert the identifier to snake case: `to_update` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait method `addEntry` should have a snake case name [INFO] [stdout] --> src/lib.rs:54:8 [INFO] [stdout] | [INFO] [stdout] 54 | fn addEntry(&self, e: &ReadingEntry); [INFO] [stdout] | ^^^^^^^^ help: convert the identifier to snake case: `add_entry` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait method `getAllEntries` should have a snake case name [INFO] [stdout] --> src/lib.rs:55:8 [INFO] [stdout] | [INFO] [stdout] 55 | fn getAllEntries(&self) -> Result>; [INFO] [stdout] | ^^^^^^^^^^^^^ help: convert the identifier to snake case: `get_all_entries` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `entryToDelete` should have a snake case name [INFO] [stdout] --> src/lib.rs:114:13 [INFO] [stdout] | [INFO] [stdout] 114 | let entryToDelete = self.getById(id)?; [INFO] [stdout] | ^^^^^^^^^^^^^ help: convert the identifier to snake case: `entry_to_delete` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `toUpdate` should have a snake case name [INFO] [stdout] --> src/lib.rs:122:27 [INFO] [stdout] | [INFO] [stdout] 122 | fn updateEntry(&self, toUpdate: &ReadingEntry) { [INFO] [stdout] | ^^^^^^^^ help: convert the identifier to snake case: `to_update` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `insertString` should have a snake case name [INFO] [stdout] --> src/lib.rs:123:13 [INFO] [stdout] | [INFO] [stdout] 123 | ... let insertString = "update reading_entries set title = ?1, author = ?2, genre = ?3, format = ?4, tags = ?5, status = ?6 where id = ... [INFO] [stdout] | ^^^^^^^^^^^^ help: convert the identifier to snake case: `insert_string` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/lib.rs:124:9 [INFO] [stdout] | [INFO] [stdout] 124 | / ... self.conn.execute(insertString, [INFO] [stdout] 125 | | ... &[&toUpdate.title, &toUpdate.author, &toUpdate.genre, &formatEnumToString(&toUpdate.format), &toUpdate.tags.join(" "), &toUpdate.status, &toUpdate.id.to_string()]); [INFO] [stdout] | |____________________________________________________________________________________________________________________________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `insertString` should have a snake case name [INFO] [stdout] --> src/lib.rs:129:13 [INFO] [stdout] | [INFO] [stdout] 129 | let insertString = "insert into reading_entries (title, author, genre, format, tags, status) values (?1, ?2, ?3, ?4, ?5, ?6);"; [INFO] [stdout] | ^^^^^^^^^^^^ help: convert the identifier to snake case: `insert_string` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/lib.rs:130:9 [INFO] [stdout] | [INFO] [stdout] 130 | ... self.conn.execute(insertString, &[&re.title, &re.author, &re.genre, &formatEnumToString(&re.format), &re.tags.join(" "), &re.status]); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `entryList` should have a snake case name [INFO] [stdout] --> src/lib.rs:158:17 [INFO] [stdout] | [INFO] [stdout] 158 | let mut entryList = Vec::new(); [INFO] [stdout] | ^^^^^^^^^ help: convert the identifier to snake case: `entry_list` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 18 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Compiling readinglist v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `MappedRows` [INFO] [stdout] --> src/lib.rs:2:27 [INFO] [stdout] | [INFO] [stdout] 2 | use rusqlite::{NO_PARAMS, MappedRows, types::FromSql, types::FromSqlResult, types::ValueRef}; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `s` [INFO] [stdout] --> src/lib.rs:24:16 [INFO] [stdout] | [INFO] [stdout] 24 | Ok(s) => { [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_s` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `stringToFormatEnum` should have a snake case name [INFO] [stdout] --> src/lib.rs:32:8 [INFO] [stdout] | [INFO] [stdout] 32 | pub fn stringToFormatEnum(toConvert: &str) -> Format { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: convert the identifier to snake case: `string_to_format_enum` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_snake_case)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `toConvert` should have a snake case name [INFO] [stdout] --> src/lib.rs:32:27 [INFO] [stdout] | [INFO] [stdout] 32 | pub fn stringToFormatEnum(toConvert: &str) -> Format { [INFO] [stdout] | ^^^^^^^^^ help: convert the identifier to snake case: `to_convert` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `formatEnumToString` should have a snake case name [INFO] [stdout] --> src/lib.rs:43:8 [INFO] [stdout] | [INFO] [stdout] 43 | pub fn formatEnumToString(f: &Format) -> String { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: convert the identifier to snake case: `format_enum_to_string` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait method `getById` should have a snake case name [INFO] [stdout] --> src/lib.rs:51:8 [INFO] [stdout] | [INFO] [stdout] 51 | fn getById(&self, id: i64) -> Result; [INFO] [stdout] | ^^^^^^^ help: convert the identifier to snake case: `get_by_id` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait method `deleteById` should have a snake case name [INFO] [stdout] --> src/lib.rs:52:8 [INFO] [stdout] | [INFO] [stdout] 52 | fn deleteById(&self, id: i64) -> Result; [INFO] [stdout] | ^^^^^^^^^^ help: convert the identifier to snake case: `delete_by_id` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait method `updateEntry` should have a snake case name [INFO] [stdout] --> src/lib.rs:53:8 [INFO] [stdout] | [INFO] [stdout] 53 | fn updateEntry(&self, toUpdate: &ReadingEntry); [INFO] [stdout] | ^^^^^^^^^^^ help: convert the identifier to snake case: `update_entry` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `toUpdate` should have a snake case name [INFO] [stdout] --> src/lib.rs:53:27 [INFO] [stdout] | [INFO] [stdout] 53 | fn updateEntry(&self, toUpdate: &ReadingEntry); [INFO] [stdout] | ^^^^^^^^ help: convert the identifier to snake case: `to_update` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait method `addEntry` should have a snake case name [INFO] [stdout] --> src/lib.rs:54:8 [INFO] [stdout] | [INFO] [stdout] 54 | fn addEntry(&self, e: &ReadingEntry); [INFO] [stdout] | ^^^^^^^^ help: convert the identifier to snake case: `add_entry` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait method `getAllEntries` should have a snake case name [INFO] [stdout] --> src/lib.rs:55:8 [INFO] [stdout] | [INFO] [stdout] 55 | fn getAllEntries(&self) -> Result>; [INFO] [stdout] | ^^^^^^^^^^^^^ help: convert the identifier to snake case: `get_all_entries` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `entryToDelete` should have a snake case name [INFO] [stdout] --> src/lib.rs:114:13 [INFO] [stdout] | [INFO] [stdout] 114 | let entryToDelete = self.getById(id)?; [INFO] [stdout] | ^^^^^^^^^^^^^ help: convert the identifier to snake case: `entry_to_delete` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `toUpdate` should have a snake case name [INFO] [stdout] --> src/lib.rs:122:27 [INFO] [stdout] | [INFO] [stdout] 122 | fn updateEntry(&self, toUpdate: &ReadingEntry) { [INFO] [stdout] | ^^^^^^^^ help: convert the identifier to snake case: `to_update` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `insertString` should have a snake case name [INFO] [stdout] --> src/lib.rs:123:13 [INFO] [stdout] | [INFO] [stdout] 123 | ... let insertString = "update reading_entries set title = ?1, author = ?2, genre = ?3, format = ?4, tags = ?5, status = ?6 where id = ... [INFO] [stdout] | ^^^^^^^^^^^^ help: convert the identifier to snake case: `insert_string` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `super::CONFIG` [INFO] [stdout] --> src/querylanguage.rs:1:5 [INFO] [stdout] | [INFO] [stdout] 1 | use super::CONFIG; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::result` [INFO] [stdout] --> src/querylanguage.rs:4:5 [INFO] [stdout] | [INFO] [stdout] 4 | use std::result; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Connection` [INFO] [stdout] --> src/main.rs:10:16 [INFO] [stdout] | [INFO] [stdout] 10 | use rusqlite::{Connection, Result}; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/main.rs:206:12 [INFO] [stdout] | [INFO] [stdout] 206 | if (dir.len() == 1) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/lib.rs:124:9 [INFO] [stdout] | [INFO] [stdout] 124 | / ... self.conn.execute(insertString, [INFO] [stdout] 125 | | ... &[&toUpdate.title, &toUpdate.author, &toUpdate.genre, &formatEnumToString(&toUpdate.format), &toUpdate.tags.join(" "), &toUpdate.status, &toUpdate.id.to_string()]); [INFO] [stdout] | |____________________________________________________________________________________________________________________________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `insertString` should have a snake case name [INFO] [stdout] --> src/lib.rs:129:13 [INFO] [stdout] | [INFO] [stdout] 129 | let insertString = "insert into reading_entries (title, author, genre, format, tags, status) values (?1, ?2, ?3, ?4, ?5, ?6);"; [INFO] [stdout] | ^^^^^^^^^^^^ help: convert the identifier to snake case: `insert_string` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/lib.rs:130:9 [INFO] [stdout] | [INFO] [stdout] 130 | ... self.conn.execute(insertString, &[&re.title, &re.author, &re.genre, &formatEnumToString(&re.format), &re.tags.join(" "), &re.status]); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `entryList` should have a snake case name [INFO] [stdout] --> src/lib.rs:158:17 [INFO] [stdout] | [INFO] [stdout] 158 | let mut entryList = Vec::new(); [INFO] [stdout] | ^^^^^^^^^ help: convert the identifier to snake case: `entry_list` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning[E0170]: pattern binding `Equal` is named the same as one of the variants of the type `CompType` [INFO] [stdout] --> src/querylanguage.rs:26:9 [INFO] [stdout] | [INFO] [stdout] 26 | Equal => { [INFO] [stdout] | ^^^^^ help: to match on the variant, qualify the path: `CompType::Equal` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(bindings_with_variant_name)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `splits` [INFO] [stdout] --> src/main.rs:101:9 [INFO] [stdout] | [INFO] [stdout] 101 | let splits = tags.split(" "); [INFO] [stdout] | ^^^^^^ help: if this is intentional, prefix it with an underscore: `_splits` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `Equal` [INFO] [stdout] --> src/querylanguage.rs:26:9 [INFO] [stdout] | [INFO] [stdout] 26 | Equal => { [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_Equal` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/querylanguage.rs:129:9 [INFO] [stdout] | [INFO] [stdout] 129 | let mut comp: Comparison = Comparison::default(); [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct is never constructed: `Table` [INFO] [stdout] --> src/querylanguage.rs:76:12 [INFO] [stdout] | [INFO] [stdout] 76 | pub struct Table { [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant is never constructed: `Col` [INFO] [stdout] --> src/querylanguage.rs:91:5 [INFO] [stdout] | [INFO] [stdout] 91 | Col, [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant is never constructed: `Contains` [INFO] [stdout] --> src/querylanguage.rs:244:5 [INFO] [stdout] | [INFO] [stdout] 244 | Contains, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant is never constructed: `Or` [INFO] [stdout] --> src/querylanguage.rs:251:5 [INFO] [stdout] | [INFO] [stdout] 251 | Or [INFO] [stdout] | ^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated function is never used: `new` [INFO] [stdout] --> src/querylanguage.rs:274:8 [INFO] [stdout] | [INFO] [stdout] 274 | fn new(left: Comparison, right: Option, t: ModType) -> Modifier { [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function is never used: `info` [INFO] [stdout] --> src/log.rs:3:8 [INFO] [stdout] | [INFO] [stdout] 3 | pub fn info(msg: &String) { [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: panic message is not a string literal [INFO] [stdout] --> src/querylanguage.rs:176:28 [INFO] [stdout] | [INFO] [stdout] 176 | panic!(String::from("Expected a col ident")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_fmt_panics)]` on by default [INFO] [stdout] = note: this usage of panic!() is deprecated; it will be a hard error in Rust 2021 [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: add a "{}" format string to Display the message [INFO] [stdout] | [INFO] [stdout] 176 | panic!("{}", String::from("Expected a col ident")); [INFO] [stdout] | ^^^^^ [INFO] [stdout] help: or use std::panic::panic_any instead [INFO] [stdout] | [INFO] [stdout] 176 | std::panic::panic_any(String::from("Expected a col ident")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: panic message is not a string literal [INFO] [stdout] --> src/querylanguage.rs:231:16 [INFO] [stdout] | [INFO] [stdout] 231 | panic!(String::from("Wrong state")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this usage of panic!() is deprecated; it will be a hard error in Rust 2021 [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: add a "{}" format string to Display the message [INFO] [stdout] | [INFO] [stdout] 231 | panic!("{}", String::from("Wrong state")); [INFO] [stdout] | ^^^^^ [INFO] [stdout] help: or use std::panic::panic_any instead [INFO] [stdout] | [INFO] [stdout] 231 | std::panic::panic_any(String::from("Wrong state")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `withId` should have a snake case name [INFO] [stdout] --> src/main.rs:37:5 [INFO] [stdout] | [INFO] [stdout] 37 | withId: bool, [INFO] [stdout] | ^^^^^^ help: convert the identifier to snake case: `with_id` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_snake_case)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `promptForUpdate` should have a snake case name [INFO] [stdout] --> src/main.rs:70:4 [INFO] [stdout] | [INFO] [stdout] 70 | fn promptForUpdate(toUpdate: &ReadingEntry) -> ReadingEntry { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: convert the identifier to snake case: `prompt_for_update` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `toUpdate` should have a snake case name [INFO] [stdout] --> src/main.rs:70:20 [INFO] [stdout] | [INFO] [stdout] 70 | fn promptForUpdate(toUpdate: &ReadingEntry) -> ReadingEntry { [INFO] [stdout] | ^^^^^^^^ help: convert the identifier to snake case: `to_update` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `splittedTags` should have a snake case name [INFO] [stdout] --> src/main.rs:78:9 [INFO] [stdout] | [INFO] [stdout] 78 | let splittedTags = tags.split(" ").map(|x| String::from(x)).collect(); [INFO] [stdout] | ^^^^^^^^^^^^ help: convert the identifier to snake case: `splitted_tags` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `splittedTags` should have a snake case name [INFO] [stdout] --> src/main.rs:103:9 [INFO] [stdout] | [INFO] [stdout] 103 | let splittedTags = tags.split(" ").map(|x| String::from(x)).collect(); [INFO] [stdout] | ^^^^^^^^^^^^ help: convert the identifier to snake case: `splitted_tags` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `withId` should have a snake case name [INFO] [stdout] --> src/main.rs:126:45 [INFO] [stdout] | [INFO] [stdout] 126 | fn print_table(entries: &Vec, withId: bool) -> Table { [INFO] [stdout] | ^^^^^^ help: convert the identifier to snake case: `with_id` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `formatString` should have a snake case name [INFO] [stdout] --> src/main.rs:139:13 [INFO] [stdout] | [INFO] [stdout] 139 | let formatString = formatEnumToString(&e.format); [INFO] [stdout] | ^^^^^^^^^^^^ help: convert the identifier to snake case: `format_string` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `idString` should have a snake case name [INFO] [stdout] --> src/main.rs:149:13 [INFO] [stdout] | [INFO] [stdout] 149 | let idString = &e.id.to_string(); [INFO] [stdout] | ^^^^^^^^ help: convert the identifier to snake case: `id_string` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `createHeaderVec` should have a snake case name [INFO] [stdout] --> src/main.rs:160:4 [INFO] [stdout] | [INFO] [stdout] 160 | fn createHeaderVec() -> Vec { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: convert the identifier to snake case: `create_header_vec` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `createTableRowFromReadingEntry` should have a snake case name [INFO] [stdout] --> src/main.rs:170:4 [INFO] [stdout] | [INFO] [stdout] 170 | fn createTableRowFromReadingEntry(re: &ReadingEntry) -> TableRow { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: convert the identifier to snake case: `create_table_row_from_reading_entry` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `initConfig` should have a snake case name [INFO] [stdout] --> src/main.rs:181:4 [INFO] [stdout] | [INFO] [stdout] 181 | fn initConfig() -> Config { [INFO] [stdout] | ^^^^^^^^^^ help: convert the identifier to snake case: `init_config` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `expandTilde` should have a snake case name [INFO] [stdout] --> src/main.rs:199:4 [INFO] [stdout] | [INFO] [stdout] 199 | fn expandTilde(dir: &String) -> String { [INFO] [stdout] | ^^^^^^^^^^^ help: convert the identifier to snake case: `expand_tilde` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `createAppFolderIfNeccessary` should have a snake case name [INFO] [stdout] --> src/main.rs:217:4 [INFO] [stdout] | [INFO] [stdout] 217 | fn createAppFolderIfNeccessary() -> std::io::Result<()>{ [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: convert the identifier to snake case: `create_app_folder_if_neccessary` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/main.rs:231:5 [INFO] [stdout] | [INFO] [stdout] 231 | createAppFolderIfNeccessary(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `toUpdate` should have a snake case name [INFO] [stdout] --> src/main.rs:241:17 [INFO] [stdout] | [INFO] [stdout] 241 | let toUpdate = backend.getById(id)?; [INFO] [stdout] | ^^^^^^^^ help: convert the identifier to snake case: `to_update` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/main.rs:246:13 [INFO] [stdout] | [INFO] [stdout] 246 | backend.deleteById(id); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `filteredEntries` should have a snake case name [INFO] [stdout] --> src/main.rs:253:21 [INFO] [stdout] | [INFO] [stdout] 253 | let filteredEntries = entries.into_iter() [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: convert the identifier to snake case: `filtered_entries` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `Equal` should have a snake case name [INFO] [stdout] --> src/querylanguage.rs:26:9 [INFO] [stdout] | [INFO] [stdout] 26 | Equal => { [INFO] [stdout] | ^^^^^ help: convert the identifier to snake case: `equal` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `currentModifier` should have a snake case name [INFO] [stdout] --> src/querylanguage.rs:136:13 [INFO] [stdout] | [INFO] [stdout] 136 | let mut currentModifier: &mut Modifier = &mut root; [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: convert the identifier to snake case: `current_modifier` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `withId` should have a snake case name [INFO] [stdout] --> src/config.rs:4:9 [INFO] [stdout] | [INFO] [stdout] 4 | pub withId: bool, [INFO] [stdout] | ^^^^^^ help: convert the identifier to snake case: `with_id` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 18 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 36 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] For more information about this error, try `rustc --explain E0170`. [INFO] [stdout] [INFO] [stderr] Finished test [unoptimized + debuginfo] target(s) in 2.57s [INFO] running `Command { std: "docker" "inspect" "36dc19e3c6c046226ce6d45f0b3922c9e53c07b0d32ee404e906af575241bdec", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "36dc19e3c6c046226ce6d45f0b3922c9e53c07b0d32ee404e906af575241bdec", kill_on_drop: false }` [INFO] [stdout] 36dc19e3c6c046226ce6d45f0b3922c9e53c07b0d32ee404e906af575241bdec [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:34b6a614d2c27851fe6cbf88fbd1137609cefab8b10d0615aaeb6fd47975d74e" "/opt/rustwide/cargo-home/bin/cargo" "+432e145bd5a974c5b6f4dd9b352891bd7502b69d" "test" "--frozen", kill_on_drop: false }` [INFO] [stdout] 46b34f0a46bf96cead489a0fbbee6444270df2960a85f99f88cb51bfeeb59187 [INFO] running `Command { std: "docker" "start" "-a" "46b34f0a46bf96cead489a0fbbee6444270df2960a85f99f88cb51bfeeb59187", kill_on_drop: false }` [INFO] [stderr] warning: unused import: `MappedRows` [INFO] [stderr] --> src/lib.rs:2:27 [INFO] [stderr] | [INFO] [stderr] 2 | use rusqlite::{NO_PARAMS, MappedRows, types::FromSql, types::FromSqlResult, types::ValueRef}; [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(unused_imports)]` on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `s` [INFO] [stderr] --> src/lib.rs:24:16 [INFO] [stderr] | [INFO] [stderr] 24 | Ok(s) => { [INFO] [stderr] | ^ help: if this is intentional, prefix it with an underscore: `_s` [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(unused_variables)]` on by default [INFO] [stderr] [INFO] [stderr] warning: function `stringToFormatEnum` should have a snake case name [INFO] [stderr] --> src/lib.rs:32:8 [INFO] [stderr] | [INFO] [stderr] 32 | pub fn stringToFormatEnum(toConvert: &str) -> Format { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: convert the identifier to snake case: `string_to_format_enum` [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(non_snake_case)]` on by default [INFO] [stderr] [INFO] [stderr] warning: variable `toConvert` should have a snake case name [INFO] [stderr] --> src/lib.rs:32:27 [INFO] [stderr] | [INFO] [stderr] 32 | pub fn stringToFormatEnum(toConvert: &str) -> Format { [INFO] [stderr] | ^^^^^^^^^ help: convert the identifier to snake case: `to_convert` [INFO] [stderr] [INFO] [stderr] warning: function `formatEnumToString` should have a snake case name [INFO] [stderr] --> src/lib.rs:43:8 [INFO] [stderr] | [INFO] [stderr] 43 | pub fn formatEnumToString(f: &Format) -> String { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: convert the identifier to snake case: `format_enum_to_string` [INFO] [stderr] [INFO] [stderr] warning: trait method `getById` should have a snake case name [INFO] [stderr] --> src/lib.rs:51:8 [INFO] [stderr] | [INFO] [stderr] 51 | fn getById(&self, id: i64) -> Result; [INFO] [stderr] | ^^^^^^^ help: convert the identifier to snake case: `get_by_id` [INFO] [stderr] [INFO] [stderr] warning: trait method `deleteById` should have a snake case name [INFO] [stderr] --> src/lib.rs:52:8 [INFO] [stderr] | [INFO] [stderr] 52 | fn deleteById(&self, id: i64) -> Result; [INFO] [stderr] | ^^^^^^^^^^ help: convert the identifier to snake case: `delete_by_id` [INFO] [stderr] [INFO] [stderr] warning: trait method `updateEntry` should have a snake case name [INFO] [stderr] --> src/lib.rs:53:8 [INFO] [stderr] | [INFO] [stderr] 53 | fn updateEntry(&self, toUpdate: &ReadingEntry); [INFO] [stderr] | ^^^^^^^^^^^ help: convert the identifier to snake case: `update_entry` [INFO] [stderr] [INFO] [stderr] warning: variable `toUpdate` should have a snake case name [INFO] [stderr] --> src/lib.rs:53:27 [INFO] [stderr] | [INFO] [stderr] 53 | fn updateEntry(&self, toUpdate: &ReadingEntry); [INFO] [stderr] | ^^^^^^^^ help: convert the identifier to snake case: `to_update` [INFO] [stderr] [INFO] [stderr] warning: trait method `addEntry` should have a snake case name [INFO] [stderr] --> src/lib.rs:54:8 [INFO] [stderr] | [INFO] [stderr] 54 | fn addEntry(&self, e: &ReadingEntry); [INFO] [stderr] | ^^^^^^^^ help: convert the identifier to snake case: `add_entry` [INFO] [stderr] [INFO] [stderr] warning: trait method `getAllEntries` should have a snake case name [INFO] [stderr] --> src/lib.rs:55:8 [INFO] [stderr] | [INFO] [stderr] 55 | fn getAllEntries(&self) -> Result>; [INFO] [stderr] | ^^^^^^^^^^^^^ help: convert the identifier to snake case: `get_all_entries` [INFO] [stderr] [INFO] [stderr] warning: variable `entryToDelete` should have a snake case name [INFO] [stderr] --> src/lib.rs:114:13 [INFO] [stderr] | [INFO] [stderr] 114 | let entryToDelete = self.getById(id)?; [INFO] [stderr] | ^^^^^^^^^^^^^ help: convert the identifier to snake case: `entry_to_delete` [INFO] [stderr] [INFO] [stderr] warning: variable `toUpdate` should have a snake case name [INFO] [stderr] --> src/lib.rs:122:27 [INFO] [stderr] | [INFO] [stderr] 122 | fn updateEntry(&self, toUpdate: &ReadingEntry) { [INFO] [stderr] | ^^^^^^^^ help: convert the identifier to snake case: `to_update` [INFO] [stderr] [INFO] [stderr] warning: variable `insertString` should have a snake case name [INFO] [stderr] --> src/lib.rs:123:13 [INFO] [stderr] | [INFO] [stderr] 123 | ... let insertString = "update reading_entries set title = ?1, author = ?2, genre = ?3, format = ?4, tags = ?5, status = ?6 where id = ... [INFO] [stderr] | ^^^^^^^^^^^^ help: convert the identifier to snake case: `insert_string` [INFO] [stderr] [INFO] [stderr] warning: unused `Result` that must be used [INFO] [stderr] --> src/lib.rs:124:9 [INFO] [stderr] | [INFO] [stderr] 124 | / ... self.conn.execute(insertString, [INFO] [stderr] 125 | | ... &[&toUpdate.title, &toUpdate.author, &toUpdate.genre, &formatEnumToString(&toUpdate.format), &toUpdate.tags.join(" "), &toUpdate.status, &toUpdate.id.to_string()]); [INFO] [stderr] | |____________________________________________________________________________________________________________________________________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(unused_must_use)]` on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: variable `insertString` should have a snake case name [INFO] [stderr] --> src/lib.rs:129:13 [INFO] [stderr] | [INFO] [stderr] 129 | let insertString = "insert into reading_entries (title, author, genre, format, tags, status) values (?1, ?2, ?3, ?4, ?5, ?6);"; [INFO] [stderr] | ^^^^^^^^^^^^ help: convert the identifier to snake case: `insert_string` [INFO] [stderr] [INFO] [stderr] warning: unused `Result` that must be used [INFO] [stderr] --> src/lib.rs:130:9 [INFO] [stderr] | [INFO] [stderr] 130 | ... self.conn.execute(insertString, &[&re.title, &re.author, &re.genre, &formatEnumToString(&re.format), &re.tags.join(" "), &re.status]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: variable `entryList` should have a snake case name [INFO] [stderr] --> src/lib.rs:158:17 [INFO] [stderr] | [INFO] [stderr] 158 | let mut entryList = Vec::new(); [INFO] [stderr] | ^^^^^^^^^ help: convert the identifier to snake case: `entry_list` [INFO] [stderr] [INFO] [stderr] warning: 18 warnings emitted [INFO] [stderr] [INFO] [stderr] warning: unused import: `MappedRows` [INFO] [stderr] --> src/lib.rs:2:27 [INFO] [stderr] | [INFO] [stderr] 2 | use rusqlite::{NO_PARAMS, MappedRows, types::FromSql, types::FromSqlResult, types::ValueRef}; [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(unused_imports)]` on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `s` [INFO] [stderr] --> src/lib.rs:24:16 [INFO] [stderr] | [INFO] [stderr] 24 | Ok(s) => { [INFO] [stderr] | ^ help: if this is intentional, prefix it with an underscore: `_s` [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(unused_variables)]` on by default [INFO] [stderr] [INFO] [stderr] warning: function `stringToFormatEnum` should have a snake case name [INFO] [stderr] --> src/lib.rs:32:8 [INFO] [stderr] | [INFO] [stderr] 32 | pub fn stringToFormatEnum(toConvert: &str) -> Format { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: convert the identifier to snake case: `string_to_format_enum` [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(non_snake_case)]` on by default [INFO] [stderr] [INFO] [stderr] warning: variable `toConvert` should have a snake case name [INFO] [stderr] --> src/lib.rs:32:27 [INFO] [stderr] | [INFO] [stderr] 32 | pub fn stringToFormatEnum(toConvert: &str) -> Format { [INFO] [stderr] | ^^^^^^^^^ help: convert the identifier to snake case: `to_convert` [INFO] [stderr] [INFO] [stderr] warning: function `formatEnumToString` should have a snake case name [INFO] [stderr] --> src/lib.rs:43:8 [INFO] [stderr] | [INFO] [stderr] 43 | pub fn formatEnumToString(f: &Format) -> String { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: convert the identifier to snake case: `format_enum_to_string` [INFO] [stderr] [INFO] [stderr] warning: trait method `getById` should have a snake case name [INFO] [stderr] --> src/lib.rs:51:8 [INFO] [stderr] | [INFO] [stderr] 51 | fn getById(&self, id: i64) -> Result; [INFO] [stderr] | ^^^^^^^ help: convert the identifier to snake case: `get_by_id` [INFO] [stderr] [INFO] [stderr] warning: trait method `deleteById` should have a snake case name [INFO] [stderr] --> src/lib.rs:52:8 [INFO] [stderr] | [INFO] [stderr] 52 | fn deleteById(&self, id: i64) -> Result; [INFO] [stderr] | ^^^^^^^^^^ help: convert the identifier to snake case: `delete_by_id` [INFO] [stderr] [INFO] [stderr] warning: trait method `updateEntry` should have a snake case name [INFO] [stderr] --> src/lib.rs:53:8 [INFO] [stderr] | [INFO] [stderr] 53 | fn updateEntry(&self, toUpdate: &ReadingEntry); [INFO] [stderr] | ^^^^^^^^^^^ help: convert the identifier to snake case: `update_entry` [INFO] [stderr] [INFO] [stderr] warning: variable `toUpdate` should have a snake case name [INFO] [stderr] --> src/lib.rs:53:27 [INFO] [stderr] | [INFO] [stderr] 53 | fn updateEntry(&self, toUpdate: &ReadingEntry); [INFO] [stderr] | ^^^^^^^^ help: convert the identifier to snake case: `to_update` [INFO] [stderr] [INFO] [stderr] warning: trait method `addEntry` should have a snake case name [INFO] [stderr] --> src/lib.rs:54:8 [INFO] [stderr] | [INFO] [stderr] 54 | fn addEntry(&self, e: &ReadingEntry); [INFO] [stderr] | ^^^^^^^^ help: convert the identifier to snake case: `add_entry` [INFO] [stderr] [INFO] [stderr] warning: trait method `getAllEntries` should have a snake case name [INFO] [stderr] --> src/lib.rs:55:8 [INFO] [stderr] | [INFO] [stderr] 55 | fn getAllEntries(&self) -> Result>; [INFO] [stderr] | ^^^^^^^^^^^^^ help: convert the identifier to snake case: `get_all_entries` [INFO] [stderr] [INFO] [stderr] warning: variable `entryToDelete` should have a snake case name [INFO] [stderr] --> src/lib.rs:114:13 [INFO] [stderr] | [INFO] [stderr] 114 | let entryToDelete = self.getById(id)?; [INFO] [stderr] | ^^^^^^^^^^^^^ help: convert the identifier to snake case: `entry_to_delete` [INFO] [stderr] [INFO] [stderr] warning: variable `toUpdate` should have a snake case name [INFO] [stderr] --> src/lib.rs:122:27 [INFO] [stderr] | [INFO] [stderr] 122 | fn updateEntry(&self, toUpdate: &ReadingEntry) { [INFO] [stderr] | ^^^^^^^^ help: convert the identifier to snake case: `to_update` [INFO] [stderr] [INFO] [stderr] warning: variable `insertString` should have a snake case name [INFO] [stdout] [INFO] [stderr] --> src/lib.rs:123:13 [INFO] [stdout] running 0 tests [INFO] [stderr] | [INFO] [stdout] [INFO] [stderr] 123 | ... let insertString = "update reading_entries set title = ?1, author = ?2, genre = ?3, format = ?4, tags = ?5, status = ?6 where id = ... [INFO] [stdout] test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s [INFO] [stderr] | ^^^^^^^^^^^^ help: convert the identifier to snake case: `insert_string` [INFO] [stdout] [INFO] [stderr] [INFO] [stderr] warning: unused `Result` that must be used [INFO] [stderr] --> src/lib.rs:124:9 [INFO] [stderr] | [INFO] [stderr] 124 | / ... self.conn.execute(insertString, [INFO] [stderr] 125 | | ... &[&toUpdate.title, &toUpdate.author, &toUpdate.genre, &formatEnumToString(&toUpdate.format), &toUpdate.tags.join(" "), &toUpdate.status, &toUpdate.id.to_string()]); [INFO] [stderr] | |____________________________________________________________________________________________________________________________________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(unused_must_use)]` on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: variable `insertString` should have a snake case name [INFO] [stderr] --> src/lib.rs:129:13 [INFO] [stderr] | [INFO] [stderr] 129 | let insertString = "insert into reading_entries (title, author, genre, format, tags, status) values (?1, ?2, ?3, ?4, ?5, ?6);"; [INFO] [stderr] | ^^^^^^^^^^^^ help: convert the identifier to snake case: `insert_string` [INFO] [stderr] [INFO] [stderr] warning: unused `Result` that must be used [INFO] [stderr] --> src/lib.rs:130:9 [INFO] [stderr] | [INFO] [stderr] 130 | ... self.conn.execute(insertString, &[&re.title, &re.author, &re.genre, &formatEnumToString(&re.format), &re.tags.join(" "), &re.status]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: variable `entryList` should have a snake case name [INFO] [stderr] --> src/lib.rs:158:17 [INFO] [stderr] | [INFO] [stderr] 158 | let mut entryList = Vec::new(); [INFO] [stderr] | ^^^^^^^^^ help: convert the identifier to snake case: `entry_list` [INFO] [stderr] [INFO] [stderr] warning: 18 warnings emitted [INFO] [stderr] [INFO] [stderr] warning: unused import: `super::CONFIG` [INFO] [stderr] --> src/querylanguage.rs:1:5 [INFO] [stderr] | [INFO] [stderr] 1 | use super::CONFIG; [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(unused_imports)]` on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::result` [INFO] [stderr] --> src/querylanguage.rs:4:5 [INFO] [stderr] | [INFO] [stderr] 4 | use std::result; [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `Connection` [INFO] [stderr] --> src/main.rs:10:16 [INFO] [stderr] | [INFO] [stderr] 10 | use rusqlite::{Connection, Result}; [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `if` condition [INFO] [stderr] --> src/main.rs:206:12 [INFO] [stderr] | [INFO] [stderr] 206 | if (dir.len() == 1) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(unused_parens)]` on by default [INFO] [stderr] [INFO] [stderr] warning[E0170]: pattern binding `Equal` is named the same as one of the variants of the type `CompType` [INFO] [stderr] --> src/querylanguage.rs:26:9 [INFO] [stderr] | [INFO] [stderr] 26 | Equal => { [INFO] [stderr] | ^^^^^ help: to match on the variant, qualify the path: `CompType::Equal` [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(bindings_with_variant_name)]` on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `splits` [INFO] [stderr] --> src/main.rs:101:9 [INFO] [stderr] | [INFO] [stderr] 101 | let splits = tags.split(" "); [INFO] [stderr] | ^^^^^^ help: if this is intentional, prefix it with an underscore: `_splits` [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(unused_variables)]` on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `Equal` [INFO] [stderr] --> src/querylanguage.rs:26:9 [INFO] [stderr] | [INFO] [stderr] 26 | Equal => { [INFO] [stderr] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_Equal` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/querylanguage.rs:129:9 [INFO] [stderr] | [INFO] [stderr] 129 | let mut comp: Comparison = Comparison::default(); [INFO] [stderr] | ----^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(unused_mut)]` on by default [INFO] [stderr] [INFO] [stderr] warning: struct is never constructed: `Table` [INFO] [stderr] --> src/querylanguage.rs:76:12 [INFO] [stderr] | [INFO] [stderr] 76 | pub struct Table { [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(dead_code)]` on by default [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Col` [INFO] [stderr] --> src/querylanguage.rs:91:5 [INFO] [stderr] | [INFO] [stderr] 91 | Col, [INFO] [stderr] | ^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Contains` [INFO] [stderr] --> src/querylanguage.rs:244:5 [INFO] [stderr] | [INFO] [stderr] 244 | Contains, [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Or` [INFO] [stderr] --> src/querylanguage.rs:251:5 [INFO] [stderr] | [INFO] [stderr] 251 | Or [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: associated function is never used: `new` [INFO] [stderr] --> src/querylanguage.rs:274:8 [INFO] [stderr] | [INFO] [stderr] 274 | fn new(left: Comparison, right: Option, t: ModType) -> Modifier { [INFO] [stderr] | ^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `info` [INFO] [stderr] --> src/log.rs:3:8 [INFO] [stderr] | [INFO] [stderr] 3 | pub fn info(msg: &String) { [INFO] [stderr] | ^^^^ [INFO] [stderr] [INFO] [stderr] warning: panic message is not a string literal [INFO] [stderr] --> src/querylanguage.rs:176:28 [INFO] [stderr] | [INFO] [stderr] 176 | panic!(String::from("Expected a col ident")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(non_fmt_panics)]` on by default [INFO] [stderr] = note: this usage of panic!() is deprecated; it will be a hard error in Rust 2021 [INFO] [stderr] = note: for more information, see [INFO] [stderr] help: add a "{}" format string to Display the message [INFO] [stderr] | [INFO] [stderr] 176 | panic!("{}", String::from("Expected a col ident")); [INFO] [stderr] | ^^^^^ [INFO] [stderr] help: or use std::panic::panic_any instead [INFO] [stderr] | [INFO] [stderr] 176 | std::panic::panic_any(String::from("Expected a col ident")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: panic message is not a string literal [INFO] [stderr] --> src/querylanguage.rs:231:16 [INFO] [stderr] | [INFO] [stderr] 231 | panic!(String::from("Wrong state")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this usage of panic!() is deprecated; it will be a hard error in Rust 2021 [INFO] [stderr] = note: for more information, see [INFO] [stderr] help: add a "{}" format string to Display the message [INFO] [stderr] | [INFO] [stderr] 231 | panic!("{}", String::from("Wrong state")); [INFO] [stderr] | ^^^^^ [INFO] [stderr] help: or use std::panic::panic_any instead [INFO] [stderr] | [INFO] [stderr] 231 | std::panic::panic_any(String::from("Wrong state")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: structure field `withId` should have a snake case name [INFO] [stderr] --> src/main.rs:37:5 [INFO] [stderr] | [INFO] [stderr] 37 | withId: bool, [INFO] [stderr] | ^^^^^^ help: convert the identifier to snake case: `with_id` [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(non_snake_case)]` on by default [INFO] [stderr] [INFO] [stderr] warning: function `promptForUpdate` should have a snake case name [INFO] [stderr] --> src/main.rs:70:4 [INFO] [stderr] | [INFO] [stderr] 70 | fn promptForUpdate(toUpdate: &ReadingEntry) -> ReadingEntry { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: convert the identifier to snake case: `prompt_for_update` [INFO] [stderr] [INFO] [stderr] warning: variable `toUpdate` should have a snake case name [INFO] [stderr] --> src/main.rs:70:20 [INFO] [stderr] | [INFO] [stderr] 70 | fn promptForUpdate(toUpdate: &ReadingEntry) -> ReadingEntry { [INFO] [stderr] | ^^^^^^^^ help: convert the identifier to snake case: `to_update` [INFO] [stderr] [INFO] [stderr] warning: variable `splittedTags` should have a snake case name [INFO] [stderr] --> src/main.rs:78:9 [INFO] [stderr] | [INFO] [stderr] 78 | let splittedTags = tags.split(" ").map(|x| String::from(x)).collect(); [INFO] [stderr] | ^^^^^^^^^^^^ help: convert the identifier to snake case: `splitted_tags` [INFO] [stderr] [INFO] [stderr] warning: variable `splittedTags` should have a snake case name [INFO] [stderr] --> src/main.rs:103:9 [INFO] [stderr] | [INFO] [stderr] 103 | let splittedTags = tags.split(" ").map(|x| String::from(x)).collect(); [INFO] [stderr] | ^^^^^^^^^^^^ help: convert the identifier to snake case: `splitted_tags` [INFO] [stderr] [INFO] [stderr] warning: variable `withId` should have a snake case name [INFO] [stderr] --> src/main.rs:126:45 [INFO] [stderr] | [INFO] [stderr] 126 | fn print_table(entries: &Vec, withId: bool) -> Table { [INFO] [stderr] | ^^^^^^ help: convert the identifier to snake case: `with_id` [INFO] [stderr] [INFO] [stderr] warning: variable `formatString` should have a snake case name [INFO] [stderr] --> src/main.rs:139:13 [INFO] [stderr] | [INFO] [stderr] 139 | let formatString = formatEnumToString(&e.format); [INFO] [stderr] | ^^^^^^^^^^^^ help: convert the identifier to snake case: `format_string` [INFO] [stderr] [INFO] [stderr] warning: variable `idString` should have a snake case name [INFO] [stderr] --> src/main.rs:149:13 [INFO] [stderr] | [INFO] [stderr] 149 | let idString = &e.id.to_string(); [INFO] [stderr] | ^^^^^^^^ help: convert the identifier to snake case: `id_string` [INFO] [stderr] [INFO] [stderr] warning: function `createHeaderVec` should have a snake case name [INFO] [stderr] --> src/main.rs:160:4 [INFO] [stderr] | [INFO] [stderr] 160 | fn createHeaderVec() -> Vec { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: convert the identifier to snake case: `create_header_vec` [INFO] [stderr] [INFO] [stderr] warning: function `createTableRowFromReadingEntry` should have a snake case name [INFO] [stderr] --> src/main.rs:170:4 [INFO] [stderr] | [INFO] [stderr] 170 | fn createTableRowFromReadingEntry(re: &ReadingEntry) -> TableRow { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: convert the identifier to snake case: `create_table_row_from_reading_entry` [INFO] [stderr] [INFO] [stderr] warning: function `initConfig` should have a snake case name [INFO] [stderr] --> src/main.rs:181:4 [INFO] [stderr] | [INFO] [stderr] 181 | fn initConfig() -> Config { [INFO] [stderr] | ^^^^^^^^^^ help: convert the identifier to snake case: `init_config` [INFO] [stderr] [INFO] [stderr] warning: function `expandTilde` should have a snake case name [INFO] [stderr] --> src/main.rs:199:4 [INFO] [stderr] | [INFO] [stderr] 199 | fn expandTilde(dir: &String) -> String { [INFO] [stderr] | ^^^^^^^^^^^ help: convert the identifier to snake case: `expand_tilde` [INFO] [stderr] [INFO] [stderr] warning: function `createAppFolderIfNeccessary` should have a snake case name [INFO] [stderr] --> src/main.rs:217:4 [INFO] [stderr] | [INFO] [stderr] 217 | fn createAppFolderIfNeccessary() -> std::io::Result<()>{ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: convert the identifier to snake case: `create_app_folder_if_neccessary` [INFO] [stderr] [INFO] [stderr] warning: unused `Result` that must be used [INFO] [stderr] --> src/main.rs:231:5 [INFO] [stderr] | [INFO] [stderr] 231 | createAppFolderIfNeccessary(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(unused_must_use)]` on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: variable `toUpdate` should have a snake case name [INFO] [stderr] --> src/main.rs:241:17 [INFO] [stderr] | [INFO] [stderr] 241 | let toUpdate = backend.getById(id)?; [INFO] [stderr] | ^^^^^^^^ help: convert the identifier to snake case: `to_update` [INFO] [stderr] [INFO] [stderr] warning: unused `Result` that must be used [INFO] [stderr] --> src/main.rs:246:13 [INFO] [stderr] | [INFO] [stderr] 246 | backend.deleteById(id); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: variable `filteredEntries` should have a snake case name [INFO] [stderr] --> src/main.rs:253:21 [INFO] [stderr] | [INFO] [stderr] 253 | let filteredEntries = entries.into_iter() [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: convert the identifier to snake case: `filtered_entries` [INFO] [stderr] [INFO] [stderr] warning: variable `Equal` should have a snake case name [INFO] [stderr] --> src/querylanguage.rs:26:9 [INFO] [stderr] | [INFO] [stderr] 26 | Equal => { [INFO] [stderr] | ^^^^^ help: convert the identifier to snake case: `equal` [INFO] [stderr] [INFO] [stderr] warning: variable `currentModifier` should have a snake case name [INFO] [stderr] --> src/querylanguage.rs:136:13 [INFO] [stderr] | [INFO] [stderr] 136 | let mut currentModifier: &mut Modifier = &mut root; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: convert the identifier to snake case: `current_modifier` [INFO] [stderr] [INFO] [stderr] warning: structure field `withId` should have a snake case name [INFO] [stderr] --> src/config.rs:4:9 [INFO] [stderr] | [INFO] [stderr] 4 | pub withId: bool, [INFO] [stderr] | ^^^^^^ help: convert the identifier to snake case: `with_id` [INFO] [stderr] [INFO] [stderr] warning: 36 warnings emitted [INFO] [stderr] [INFO] [stderr] For more information about this error, try `rustc --explain E0170`. [INFO] [stderr] Finished test [unoptimized + debuginfo] target(s) in 0.06s [INFO] [stderr] Running unittests (/opt/rustwide/target/debug/deps/readinglist-33593ea9c7c791bc) [INFO] [stderr] Running unittests (/opt/rustwide/target/debug/deps/readinglist-b764450b81724a50) [INFO] [stdout] [INFO] [stdout] running 4 tests [INFO] [stdout] test querylanguage::equal_comparison_works ... ok [INFO] [stdout] test querylanguage::test_query_parsing_single_value ... ok [INFO] [stdout] test querylanguage::test_query_parsing_multivalue ... ok [INFO] [stderr] error: test failed, to rerun pass '--bin readinglist' [INFO] [stdout] test test_expand_tilde ... FAILED [INFO] [stdout] [INFO] [stdout] failures: [INFO] [stdout] [INFO] [stdout] ---- test_expand_tilde stdout ---- [INFO] [stdout] thread 'test_expand_tilde' panicked at 'assertion failed: `(left == right)` [INFO] [stdout] left: `"/root/foo"`, [INFO] [stdout] right: `"/Users/tlongo/foo"`', src/main.rs:195:5 [INFO] [stdout] stack backtrace: [INFO] [stdout] 0: 0x55c3a3edd960 - std::backtrace_rs::backtrace::libunwind::trace::h706b838f5bbd876b [INFO] [stdout] at /rustc/432e145bd5a974c5b6f4dd9b352891bd7502b69d/library/std/src/../../backtrace/src/backtrace/libunwind.rs:90:5 [INFO] [stdout] 1: 0x55c3a3edd960 - std::backtrace_rs::backtrace::trace_unsynchronized::hc15f29ae7822b7b8 [INFO] [stdout] at /rustc/432e145bd5a974c5b6f4dd9b352891bd7502b69d/library/std/src/../../backtrace/src/backtrace/mod.rs:66:5 [INFO] [stdout] 2: 0x55c3a3edd960 - std::sys_common::backtrace::_print_fmt::h7c580c971f91926c [INFO] [stdout] at /rustc/432e145bd5a974c5b6f4dd9b352891bd7502b69d/library/std/src/sys_common/backtrace.rs:67:5 [INFO] [stdout] 3: 0x55c3a3edd960 - ::fmt::h2a772198c4032452 [INFO] [stdout] at /rustc/432e145bd5a974c5b6f4dd9b352891bd7502b69d/library/std/src/sys_common/backtrace.rs:46:22 [INFO] [stdout] 4: 0x55c3a3f0152c - core::fmt::write::h9a6d9c74526a6c1b [INFO] [stdout] at /rustc/432e145bd5a974c5b6f4dd9b352891bd7502b69d/library/core/src/fmt/mod.rs:1115:17 [INFO] [stdout] 5: 0x55c3a3eda5a5 - std::io::Write::write_fmt::h583dff5009d01a9f [INFO] [stdout] at /rustc/432e145bd5a974c5b6f4dd9b352891bd7502b69d/library/std/src/io/mod.rs:1663:15 [INFO] [stdout] 6: 0x55c3a3edfadb - std::sys_common::backtrace::_print::h5b3c171e6f864ae4 [INFO] [stdout] at /rustc/432e145bd5a974c5b6f4dd9b352891bd7502b69d/library/std/src/sys_common/backtrace.rs:49:5 [INFO] [stdout] 7: 0x55c3a3edfadb - std::sys_common::backtrace::print::h93b9e9ed2a98e611 [INFO] [stdout] at /rustc/432e145bd5a974c5b6f4dd9b352891bd7502b69d/library/std/src/sys_common/backtrace.rs:36:9 [INFO] [stdout] 8: 0x55c3a3edfadb - std::panicking::default_hook::{{closure}}::hd8da92bb68d520c5 [INFO] [stdout] at /rustc/432e145bd5a974c5b6f4dd9b352891bd7502b69d/library/std/src/panicking.rs:208:50 [INFO] [stdout] 9: 0x55c3a3edf5ec - std::panicking::default_hook::hdbc8b2951c5afbab [INFO] [stdout] at /rustc/432e145bd5a974c5b6f4dd9b352891bd7502b69d/library/std/src/panicking.rs:222:9 [INFO] [stdout] 10: 0x55c3a3ee01a4 - std::panicking::rust_panic_with_hook::h8a4c841655926f4e [INFO] [stdout] at /rustc/432e145bd5a974c5b6f4dd9b352891bd7502b69d/library/std/src/panicking.rs:622:17 [INFO] [stdout] 11: 0x55c3a3edfc87 - std::panicking::begin_panic_handler::{{closure}}::h471b6bc74904b7b0 [INFO] [stdout] at /rustc/432e145bd5a974c5b6f4dd9b352891bd7502b69d/library/std/src/panicking.rs:519:13 [INFO] [stdout] 12: 0x55c3a3edde5c - std::sys_common::backtrace::__rust_end_short_backtrace::h309f5c707f29932f [INFO] [stdout] at /rustc/432e145bd5a974c5b6f4dd9b352891bd7502b69d/library/std/src/sys_common/backtrace.rs:141:18 [INFO] [stdout] 13: 0x55c3a3edfbe9 - rust_begin_unwind [INFO] [stdout] at /rustc/432e145bd5a974c5b6f4dd9b352891bd7502b69d/library/std/src/panicking.rs:515:5 [INFO] [stdout] 14: 0x55c3a3d487b1 - core::panicking::panic_fmt::hcf5f6d96e1dd7099 [INFO] [stdout] at /rustc/432e145bd5a974c5b6f4dd9b352891bd7502b69d/library/core/src/panicking.rs:92:14 [INFO] [stdout] 15: 0x55c3a3effe48 - core::panicking::assert_failed_inner::h6ded2444c01d76f2 [INFO] [stdout] 16: 0x55c3a3d4ff0a - core::panicking::assert_failed::h125085c47f30f72b [INFO] [stdout] at /rustc/432e145bd5a974c5b6f4dd9b352891bd7502b69d/library/core/src/panicking.rs:117:5 [INFO] [stdout] 17: 0x55c3a3d52f7e - readinglist::test_expand_tilde::h594e7821b6257086 [INFO] [stdout] at /opt/rustwide/workdir/src/main.rs:195:5 [INFO] [stdout] 18: 0x55c3a3d52aba - readinglist::test_expand_tilde::{{closure}}::hf73fe409ca31176a [INFO] [stdout] at /opt/rustwide/workdir/src/main.rs:192:1 [INFO] [stdout] 19: 0x55c3a3d5608e - core::ops::function::FnOnce::call_once::ha4449135a7a8c685 [INFO] [stdout] at /rustc/432e145bd5a974c5b6f4dd9b352891bd7502b69d/library/core/src/ops/function.rs:227:5 [INFO] [stdout] 20: 0x55c3a3d7ed43 - core::ops::function::FnOnce::call_once::h99a97b0ff983bd25 [INFO] [stdout] at /rustc/432e145bd5a974c5b6f4dd9b352891bd7502b69d/library/core/src/ops/function.rs:227:5 [INFO] [stdout] 21: 0x55c3a3d7ed43 - test::__rust_begin_short_backtrace::h8fe0d26ed1584e50 [INFO] [stdout] at /rustc/432e145bd5a974c5b6f4dd9b352891bd7502b69d/library/test/src/lib.rs:577:5 [INFO] [stdout] 22: 0x55c3a3d7d7d0 - as core::ops::function::FnOnce>::call_once::he6b90e352f394d8f [INFO] [stdout] at /rustc/432e145bd5a974c5b6f4dd9b352891bd7502b69d/library/alloc/src/boxed.rs:1572:9 [INFO] [stdout] 23: 0x55c3a3d7d7d0 - as core::ops::function::FnOnce<()>>::call_once::h1c05475e029700b8 [INFO] [stdout] at /rustc/432e145bd5a974c5b6f4dd9b352891bd7502b69d/library/std/src/panic.rs:347:9 [INFO] [stdout] 24: 0x55c3a3d7d7d0 - std::panicking::try::do_call::he6de943476ae628a [INFO] [stdout] at /rustc/432e145bd5a974c5b6f4dd9b352891bd7502b69d/library/std/src/panicking.rs:401:40 [INFO] [stdout] 25: 0x55c3a3d7d7d0 - std::panicking::try::ha21937b8feb06f89 [INFO] [stdout] at /rustc/432e145bd5a974c5b6f4dd9b352891bd7502b69d/library/std/src/panicking.rs:365:19 [INFO] [stdout] 26: 0x55c3a3d7d7d0 - std::panic::catch_unwind::ha79830b3325c9fa6 [INFO] [stdout] at /rustc/432e145bd5a974c5b6f4dd9b352891bd7502b69d/library/std/src/panic.rs:434:14 [INFO] [stdout] 27: 0x55c3a3d7d7d0 - test::run_test_in_process::h1ab180b83ee2d5b5 [INFO] [stdout] at /rustc/432e145bd5a974c5b6f4dd9b352891bd7502b69d/library/test/src/lib.rs:600:18 [INFO] [stdout] 28: 0x55c3a3d7d7d0 - test::run_test::run_test_inner::{{closure}}::h8258ffe088f187a1 [INFO] [stdout] at /rustc/432e145bd5a974c5b6f4dd9b352891bd7502b69d/library/test/src/lib.rs:492:39 [INFO] [stdout] 29: 0x55c3a3d56d92 - test::run_test::run_test_inner::{{closure}}::hc697b214abd32bc6 [INFO] [stdout] at /rustc/432e145bd5a974c5b6f4dd9b352891bd7502b69d/library/test/src/lib.rs:519:37 [INFO] [stdout] 30: 0x55c3a3d56d92 - std::sys_common::backtrace::__rust_begin_short_backtrace::h64de0d3f894854a9 [INFO] [stdout] at /rustc/432e145bd5a974c5b6f4dd9b352891bd7502b69d/library/std/src/sys_common/backtrace.rs:125:18 [INFO] [stdout] 31: 0x55c3a3d5a9e8 - std::thread::Builder::spawn_unchecked::{{closure}}::{{closure}}::h1fd98fc86e533ece [INFO] [stdout] at /rustc/432e145bd5a974c5b6f4dd9b352891bd7502b69d/library/std/src/thread/mod.rs:476:17 [INFO] [stdout] 32: 0x55c3a3d5a9e8 - as core::ops::function::FnOnce<()>>::call_once::h4e2a7abf702e4cfd [INFO] [stdout] at /rustc/432e145bd5a974c5b6f4dd9b352891bd7502b69d/library/std/src/panic.rs:347:9 [INFO] [stdout] 33: 0x55c3a3d5a9e8 - std::panicking::try::do_call::h4496392321a3c8c0 [INFO] [stdout] at /rustc/432e145bd5a974c5b6f4dd9b352891bd7502b69d/library/std/src/panicking.rs:401:40 [INFO] [stdout] 34: 0x55c3a3d5a9e8 - std::panicking::try::hf1e14258e04e8e9a [INFO] [stdout] at /rustc/432e145bd5a974c5b6f4dd9b352891bd7502b69d/library/std/src/panicking.rs:365:19 [INFO] [stdout] 35: 0x55c3a3d5a9e8 - std::panic::catch_unwind::hb72c3777cd55642f [INFO] [stdout] at /rustc/432e145bd5a974c5b6f4dd9b352891bd7502b69d/library/std/src/panic.rs:434:14 [INFO] [stdout] 36: 0x55c3a3d5a9e8 - std::thread::Builder::spawn_unchecked::{{closure}}::h2d7915a5910e148e [INFO] [stdout] at /rustc/432e145bd5a974c5b6f4dd9b352891bd7502b69d/library/std/src/thread/mod.rs:475:30 [INFO] [stdout] 37: 0x55c3a3d5a9e8 - core::ops::function::FnOnce::call_once{{vtable.shim}}::h83fd2f1ef5be797c [INFO] [stdout] at /rustc/432e145bd5a974c5b6f4dd9b352891bd7502b69d/library/core/src/ops/function.rs:227:5 [INFO] [stdout] 38: 0x55c3a3ee4dc7 - as core::ops::function::FnOnce>::call_once::ha8b1d5a0092467fc [INFO] [stdout] at /rustc/432e145bd5a974c5b6f4dd9b352891bd7502b69d/library/alloc/src/boxed.rs:1572:9 [INFO] [stdout] 39: 0x55c3a3ee4dc7 - as core::ops::function::FnOnce>::call_once::h4b9f24ec4e8a879e [INFO] [stdout] at /rustc/432e145bd5a974c5b6f4dd9b352891bd7502b69d/library/alloc/src/boxed.rs:1572:9 [INFO] [stdout] 40: 0x55c3a3ee4dc7 - std::sys::unix::thread::Thread::new::thread_start::h2a0e98fbc4ab4c32 [INFO] [stdout] at /rustc/432e145bd5a974c5b6f4dd9b352891bd7502b69d/library/std/src/sys/unix/thread.rs:72:17 [INFO] [stdout] 41: 0x7f10c6051609 - start_thread [INFO] [stdout] 42: 0x7f10c5e23293 - clone [INFO] [stdout] 43: 0x0 - [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] failures: [INFO] [stdout] test_expand_tilde [INFO] [stdout] [INFO] [stdout] test result: FAILED. 3 passed; 1 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.05s [INFO] [stdout] [INFO] running `Command { std: "docker" "inspect" "46b34f0a46bf96cead489a0fbbee6444270df2960a85f99f88cb51bfeeb59187", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "46b34f0a46bf96cead489a0fbbee6444270df2960a85f99f88cb51bfeeb59187", kill_on_drop: false }` [INFO] [stdout] 46b34f0a46bf96cead489a0fbbee6444270df2960a85f99f88cb51bfeeb59187