[INFO] fetching crate nestools 1.3.1... [INFO] testing nestools-1.3.1 against master#b70888601af92f6cdc0364abab3446e418b91d36 for pr-86479 [INFO] extracting crate nestools 1.3.1 into /workspace/builds/worker-8/source [INFO] validating manifest of crates.io crate nestools 1.3.1 on toolchain b70888601af92f6cdc0364abab3446e418b91d36 [INFO] running `Command { std: "/workspace/cargo-home/bin/cargo" "+b70888601af92f6cdc0364abab3446e418b91d36" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate nestools 1.3.1 [INFO] finished tweaking crates.io crate nestools 1.3.1 [INFO] tweaked toml for crates.io crate nestools 1.3.1 written to /workspace/builds/worker-8/source/Cargo.toml [INFO] running `Command { std: "/workspace/cargo-home/bin/cargo" "+b70888601af92f6cdc0364abab3446e418b91d36" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update", kill_on_drop: false }` [INFO] running `Command { std: "/workspace/cargo-home/bin/cargo" "+b70888601af92f6cdc0364abab3446e418b91d36" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-8/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-8/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:34b6a614d2c27851fe6cbf88fbd1137609cefab8b10d0615aaeb6fd47975d74e" "/opt/rustwide/cargo-home/bin/cargo" "+b70888601af92f6cdc0364abab3446e418b91d36" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] a79fb303335d360b5cfe7ebf2324d071fb2190892ec72e9044476a47e935e47e [INFO] running `Command { std: "docker" "start" "-a" "a79fb303335d360b5cfe7ebf2324d071fb2190892ec72e9044476a47e935e47e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "a79fb303335d360b5cfe7ebf2324d071fb2190892ec72e9044476a47e935e47e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a79fb303335d360b5cfe7ebf2324d071fb2190892ec72e9044476a47e935e47e", kill_on_drop: false }` [INFO] [stdout] a79fb303335d360b5cfe7ebf2324d071fb2190892ec72e9044476a47e935e47e [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-8/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-8/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:34b6a614d2c27851fe6cbf88fbd1137609cefab8b10d0615aaeb6fd47975d74e" "/opt/rustwide/cargo-home/bin/cargo" "+b70888601af92f6cdc0364abab3446e418b91d36" "build" "--frozen" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] bd95eab789e1db5dc0328230286501a67d3c7079adfb34f71d588906fcbbccd1 [INFO] running `Command { std: "docker" "start" "-a" "bd95eab789e1db5dc0328230286501a67d3c7079adfb34f71d588906fcbbccd1", kill_on_drop: false }` [INFO] [stderr] Compiling serde_derive v1.0.127 [INFO] [stderr] Compiling rgb v0.8.27 [INFO] [stderr] Compiling getopts v0.2.21 [INFO] [stderr] Compiling syn v1.0.74 [INFO] [stderr] Compiling serde_yaml v0.7.5 [INFO] [stderr] Compiling lodepng v2.7.3 [INFO] [stderr] Compiling nestools v1.3.1 (/opt/rustwide/workdir) [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/binaries/spritesheetc.rs:282:46 [INFO] [stdout] | [INFO] [stdout] 282 | pub fn run(config: Config) -> Result<(), Box> { [INFO] [stdout] | ^^^^^^^^^^^^ help: use `dyn`: `dyn error::Error` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(bare_trait_objects)]` on by default [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see issue #80165 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/binaries/spritesheetc.rs:283:20 [INFO] [stdout] | [INFO] [stdout] 283 | let input: Box = match config.input { [INFO] [stdout] | ^^^^ help: use `dyn`: `dyn Read` [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see issue #80165 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/binaries/spritesheetc.rs:291:22 [INFO] [stdout] | [INFO] [stdout] 291 | let mut chr: Box = match config.chr { [INFO] [stdout] | ^^^^^ help: use `dyn`: `dyn Write` [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see issue #80165 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/sprites/sheet.rs:78:21 [INFO] [stdout] | [INFO] [stdout] 78 | let mut tile_number = (y * width) + x; [INFO] [stdout] | ----^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/sprites/sheet.rs:132:25 [INFO] [stdout] | [INFO] [stdout] 132 | let mut tile_number = frame_offset + y_offset + x; [INFO] [stdout] | ----^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 5 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 12.40s [INFO] running `Command { std: "docker" "inspect" "bd95eab789e1db5dc0328230286501a67d3c7079adfb34f71d588906fcbbccd1", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "bd95eab789e1db5dc0328230286501a67d3c7079adfb34f71d588906fcbbccd1", kill_on_drop: false }` [INFO] [stdout] bd95eab789e1db5dc0328230286501a67d3c7079adfb34f71d588906fcbbccd1 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-8/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-8/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:34b6a614d2c27851fe6cbf88fbd1137609cefab8b10d0615aaeb6fd47975d74e" "/opt/rustwide/cargo-home/bin/cargo" "+b70888601af92f6cdc0364abab3446e418b91d36" "test" "--frozen" "--no-run" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] d78ef499ab01819b49e87a792c86d4aa8204faa3b8e39475bdcf31330b65d4b7 [INFO] running `Command { std: "docker" "start" "-a" "d78ef499ab01819b49e87a792c86d4aa8204faa3b8e39475bdcf31330b65d4b7", kill_on_drop: false }` [INFO] [stderr] Compiling nestools v1.3.1 (/opt/rustwide/workdir) [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/binaries/spritesheetc.rs:282:46 [INFO] [stdout] | [INFO] [stdout] 282 | pub fn run(config: Config) -> Result<(), Box> { [INFO] [stdout] | ^^^^^^^^^^^^ help: use `dyn`: `dyn error::Error` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(bare_trait_objects)]` on by default [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see issue #80165 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/binaries/spritesheetc.rs:283:20 [INFO] [stdout] | [INFO] [stdout] 283 | let input: Box = match config.input { [INFO] [stdout] | ^^^^ help: use `dyn`: `dyn Read` [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see issue #80165 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/binaries/spritesheetc.rs:291:22 [INFO] [stdout] | [INFO] [stdout] 291 | let mut chr: Box = match config.chr { [INFO] [stdout] | ^^^^^ help: use `dyn`: `dyn Write` [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see issue #80165 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/sprites/sheet.rs:78:21 [INFO] [stdout] | [INFO] [stdout] 78 | let mut tile_number = (y * width) + x; [INFO] [stdout] | ----^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/sprites/sheet.rs:132:25 [INFO] [stdout] | [INFO] [stdout] 132 | let mut tile_number = frame_offset + y_offset + x; [INFO] [stdout] | ----^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 5 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/binaries/spritesheetc.rs:282:46 [INFO] [stdout] | [INFO] [stdout] 282 | pub fn run(config: Config) -> Result<(), Box> { [INFO] [stdout] | ^^^^^^^^^^^^ help: use `dyn`: `dyn error::Error` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(bare_trait_objects)]` on by default [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see issue #80165 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/binaries/spritesheetc.rs:283:20 [INFO] [stdout] | [INFO] [stdout] 283 | let input: Box = match config.input { [INFO] [stdout] | ^^^^ help: use `dyn`: `dyn Read` [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see issue #80165 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/binaries/spritesheetc.rs:291:22 [INFO] [stdout] | [INFO] [stdout] 291 | let mut chr: Box = match config.chr { [INFO] [stdout] | ^^^^^ help: use `dyn`: `dyn Write` [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see issue #80165 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/sprites/sheet.rs:78:21 [INFO] [stdout] | [INFO] [stdout] 78 | let mut tile_number = (y * width) + x; [INFO] [stdout] | ----^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/sprites/sheet.rs:132:25 [INFO] [stdout] | [INFO] [stdout] 132 | let mut tile_number = frame_offset + y_offset + x; [INFO] [stdout] | ----^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 5 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished test [unoptimized + debuginfo] target(s) in 1.38s [INFO] running `Command { std: "docker" "inspect" "d78ef499ab01819b49e87a792c86d4aa8204faa3b8e39475bdcf31330b65d4b7", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "d78ef499ab01819b49e87a792c86d4aa8204faa3b8e39475bdcf31330b65d4b7", kill_on_drop: false }` [INFO] [stdout] d78ef499ab01819b49e87a792c86d4aa8204faa3b8e39475bdcf31330b65d4b7 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-8/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-8/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:34b6a614d2c27851fe6cbf88fbd1137609cefab8b10d0615aaeb6fd47975d74e" "/opt/rustwide/cargo-home/bin/cargo" "+b70888601af92f6cdc0364abab3446e418b91d36" "test" "--frozen", kill_on_drop: false }` [INFO] [stdout] becfa55984e2392fe357de96b71722dbe93d228192207a5600d27ecaa2455011 [INFO] running `Command { std: "docker" "start" "-a" "becfa55984e2392fe357de96b71722dbe93d228192207a5600d27ecaa2455011", kill_on_drop: false }` [INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stderr] --> src/binaries/spritesheetc.rs:282:46 [INFO] [stderr] | [INFO] [stderr] 282 | pub fn run(config: Config) -> Result<(), Box> { [INFO] [stderr] | ^^^^^^^^^^^^ help: use `dyn`: `dyn error::Error` [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(bare_trait_objects)]` on by default [INFO] [stderr] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stderr] = note: for more information, see issue #80165 [INFO] [stderr] [INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stderr] --> src/binaries/spritesheetc.rs:283:20 [INFO] [stderr] | [INFO] [stderr] 283 | let input: Box = match config.input { [INFO] [stderr] | ^^^^ help: use `dyn`: `dyn Read` [INFO] [stderr] | [INFO] [stderr] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stderr] = note: for more information, see issue #80165 [INFO] [stderr] [INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stderr] --> src/binaries/spritesheetc.rs:291:22 [INFO] [stderr] | [INFO] [stderr] 291 | let mut chr: Box = match config.chr { [INFO] [stderr] | ^^^^^ help: use `dyn`: `dyn Write` [INFO] [stderr] | [INFO] [stderr] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stderr] = note: for more information, see issue #80165 [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/sprites/sheet.rs:78:21 [INFO] [stderr] | [INFO] [stderr] 78 | let mut tile_number = (y * width) + x; [INFO] [stderr] | ----^^^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(unused_mut)]` on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/sprites/sheet.rs:132:25 [INFO] [stderr] | [INFO] [stderr] 132 | let mut tile_number = frame_offset + y_offset + x; [INFO] [stderr] | ----^^^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: `nestools` (lib) generated 5 warnings [INFO] [stderr] warning: `nestools` (lib test) generated 5 warnings (5 duplicates) [INFO] [stderr] Finished test [unoptimized + debuginfo] target(s) in 0.03s [INFO] [stdout] [INFO] [stderr] Running unittests (/opt/rustwide/target/debug/deps/nestools-55fcea18cf4ec7fb) [INFO] [stdout] running 0 tests [INFO] [stderr] Running unittests (/opt/rustwide/target/debug/deps/spritesheetc-06676def75b0c6ba) [INFO] [stdout] [INFO] [stdout] test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s [INFO] [stdout] [INFO] [stderr] Doc-tests nestools [INFO] [stdout] [INFO] [stdout] running 0 tests [INFO] [stdout] [INFO] [stdout] test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] running 2 tests [INFO] [stdout] test src/sprites/mod.rs - sprites::Tile::iter (line 70) ... ok [INFO] [stdout] test src/sprites/mod.rs - sprites::Tile::from_bytes (line 117) ... ok [INFO] [stdout] [INFO] [stdout] test result: ok. 2 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 1.06s [INFO] [stdout] [INFO] running `Command { std: "docker" "inspect" "becfa55984e2392fe357de96b71722dbe93d228192207a5600d27ecaa2455011", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "becfa55984e2392fe357de96b71722dbe93d228192207a5600d27ecaa2455011", kill_on_drop: false }` [INFO] [stdout] becfa55984e2392fe357de96b71722dbe93d228192207a5600d27ecaa2455011