[INFO] cloning repository https://github.com/christopherjmedlin/yalc8emu [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/christopherjmedlin/yalc8emu" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fchristopherjmedlin%2Fyalc8emu", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fchristopherjmedlin%2Fyalc8emu'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] fa140db9922c8fff32635f89eb72ce5c7183ab59 [INFO] testing christopherjmedlin/yalc8emu against try#ce59db7a1b1b012fb2793c4641c1bdecad7a128b for pr-85530 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fchristopherjmedlin%2Fyalc8emu" "/workspace/builds/worker-14/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-14/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/christopherjmedlin/yalc8emu on toolchain ce59db7a1b1b012fb2793c4641c1bdecad7a128b [INFO] running `Command { std: "/workspace/cargo-home/bin/cargo" "+ce59db7a1b1b012fb2793c4641c1bdecad7a128b" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/christopherjmedlin/yalc8emu [INFO] finished tweaking git repo https://github.com/christopherjmedlin/yalc8emu [INFO] tweaked toml for git repo https://github.com/christopherjmedlin/yalc8emu written to /workspace/builds/worker-14/source/Cargo.toml [INFO] crate git repo https://github.com/christopherjmedlin/yalc8emu already has a lockfile, it will not be regenerated [INFO] running `Command { std: "/workspace/cargo-home/bin/cargo" "+ce59db7a1b1b012fb2793c4641c1bdecad7a128b" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-14/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-14/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:20528e8c29e4536546f0102ce88568b16ea7538393a33fcca951030f7af10457" "/opt/rustwide/cargo-home/bin/cargo" "+ce59db7a1b1b012fb2793c4641c1bdecad7a128b" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 04b7f577934480b2fdb25ee9c560812e26c1a2daee01c8f925372eae0baed185 [INFO] running `Command { std: "docker" "start" "-a" "04b7f577934480b2fdb25ee9c560812e26c1a2daee01c8f925372eae0baed185", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "04b7f577934480b2fdb25ee9c560812e26c1a2daee01c8f925372eae0baed185", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "04b7f577934480b2fdb25ee9c560812e26c1a2daee01c8f925372eae0baed185", kill_on_drop: false }` [INFO] [stdout] 04b7f577934480b2fdb25ee9c560812e26c1a2daee01c8f925372eae0baed185 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-14/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-14/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:20528e8c29e4536546f0102ce88568b16ea7538393a33fcca951030f7af10457" "/opt/rustwide/cargo-home/bin/cargo" "+ce59db7a1b1b012fb2793c4641c1bdecad7a128b" "build" "--frozen" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 142474b2f3b245fd229e1978a1f2721f185abd59a2365d68b8cc7cc43b9e34c2 [INFO] running `Command { std: "docker" "start" "-a" "142474b2f3b245fd229e1978a1f2721f185abd59a2365d68b8cc7cc43b9e34c2", kill_on_drop: false }` [INFO] [stderr] Compiling num-traits v0.2.6 [INFO] [stderr] Compiling num-integer v0.1.39 [INFO] [stderr] Compiling num-iter v0.1.37 [INFO] [stderr] Compiling libc v0.2.43 [INFO] [stderr] Compiling rand_core v0.3.0 [INFO] [stderr] Compiling bitflags v0.7.0 [INFO] [stderr] Compiling sdl2-sys v0.31.0 [INFO] [stderr] Compiling rand_core v0.2.2 [INFO] [stderr] Compiling rand v0.4.3 [INFO] [stderr] Compiling rand v0.5.5 [INFO] [stderr] Compiling rand v0.3.22 [INFO] [stderr] Compiling num v0.1.42 [INFO] [stderr] Compiling sdl2 v0.31.0 [INFO] [stderr] Compiling chip8 v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `Duration` [INFO] [stdout] --> src/cpu/timers.rs:1:26 [INFO] [stdout] | [INFO] [stdout] 1 | use std::time::{Instant, Duration}; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/cpu/timers.rs:42:37 [INFO] [stdout] | [INFO] [stdout] 42 | fn elapsed_millis(&mut self) -> (u64) { [INFO] [stdout] | ^^^^^ help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::num::Wrapping` [INFO] [stdout] --> src/cpu/mod.rs:6:5 [INFO] [stdout] | [INFO] [stdout] 6 | use std::num::Wrapping; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/cpu/mod.rs:127:30 [INFO] [stdout] | [INFO] [stdout] 127 | fn op_00E0(&mut self) -> (usize) { [INFO] [stdout] | ^^^^^^^ help: remove these parentheses [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/cpu/mod.rs:133:30 [INFO] [stdout] | [INFO] [stdout] 133 | fn op_00EE(&mut self) -> (usize) { [INFO] [stdout] | ^^^^^^^ help: remove these parentheses [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/cpu/mod.rs:140:42 [INFO] [stdout] | [INFO] [stdout] 140 | fn op_1nnn(&mut self, nnn: usize) -> (usize) { [INFO] [stdout] | ^^^^^^^ help: remove these parentheses [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/cpu/mod.rs:146:42 [INFO] [stdout] | [INFO] [stdout] 146 | fn op_2nnn(&mut self, nnn: usize) -> (usize) { [INFO] [stdout] | ^^^^^^^ help: remove these parentheses [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/cpu/mod.rs:155:48 [INFO] [stdout] | [INFO] [stdout] 155 | fn op_3xkk(&mut self, x: usize, kk: u8) -> (usize) { [INFO] [stdout] | ^^^^^^^ help: remove these parentheses [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/cpu/mod.rs:163:48 [INFO] [stdout] | [INFO] [stdout] 163 | fn op_4xkk(&mut self, x: usize, kk: u8) -> (usize) { [INFO] [stdout] | ^^^^^^^ help: remove these parentheses [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/cpu/mod.rs:171:50 [INFO] [stdout] | [INFO] [stdout] 171 | fn op_5xy0(&mut self, x: usize, y: usize) -> (usize) { [INFO] [stdout] | ^^^^^^^ help: remove these parentheses [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/cpu/mod.rs:179:48 [INFO] [stdout] | [INFO] [stdout] 179 | fn op_6xkk(&mut self, x: usize, kk: u8) -> (usize) { [INFO] [stdout] | ^^^^^^^ help: remove these parentheses [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/cpu/mod.rs:185:48 [INFO] [stdout] | [INFO] [stdout] 185 | fn op_7xkk(&mut self, x: usize, kk: u8) -> (usize) { [INFO] [stdout] | ^^^^^^^ help: remove these parentheses [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/cpu/mod.rs:192:50 [INFO] [stdout] | [INFO] [stdout] 192 | fn op_8xy0(&mut self, x: usize, y: usize) -> (usize) { [INFO] [stdout] | ^^^^^^^ help: remove these parentheses [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/cpu/mod.rs:198:50 [INFO] [stdout] | [INFO] [stdout] 198 | fn op_8xy1(&mut self, x: usize, y: usize) -> (usize) { [INFO] [stdout] | ^^^^^^^ help: remove these parentheses [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/cpu/mod.rs:204:50 [INFO] [stdout] | [INFO] [stdout] 204 | fn op_8xy2(&mut self, x: usize, y: usize) -> (usize) { [INFO] [stdout] | ^^^^^^^ help: remove these parentheses [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/cpu/mod.rs:210:50 [INFO] [stdout] | [INFO] [stdout] 210 | fn op_8xy3(&mut self, x: usize, y: usize) -> (usize) { [INFO] [stdout] | ^^^^^^^ help: remove these parentheses [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/cpu/mod.rs:216:50 [INFO] [stdout] | [INFO] [stdout] 216 | fn op_8xy4(&mut self, x: usize, y: usize) -> (usize) { [INFO] [stdout] | ^^^^^^^ help: remove these parentheses [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/cpu/mod.rs:230:50 [INFO] [stdout] | [INFO] [stdout] 230 | fn op_8xy5(&mut self, x: usize, y: usize) -> (usize) { [INFO] [stdout] | ^^^^^^^ help: remove these parentheses [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/cpu/mod.rs:245:40 [INFO] [stdout] | [INFO] [stdout] 245 | fn op_8xy6(&mut self, x: usize) -> (usize) { [INFO] [stdout] | ^^^^^^^ help: remove these parentheses [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/cpu/mod.rs:253:50 [INFO] [stdout] | [INFO] [stdout] 253 | fn op_8xy7(&mut self, x: usize, y: usize) -> (usize) { [INFO] [stdout] | ^^^^^^^ help: remove these parentheses [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/cpu/mod.rs:264:40 [INFO] [stdout] | [INFO] [stdout] 264 | fn op_8xyE(&mut self, x: usize) -> (usize) { [INFO] [stdout] | ^^^^^^^ help: remove these parentheses [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/cpu/mod.rs:271:50 [INFO] [stdout] | [INFO] [stdout] 271 | fn op_9xy0(&mut self, x: usize, y: usize) -> (usize) { [INFO] [stdout] | ^^^^^^^ help: remove these parentheses [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/cpu/mod.rs:279:42 [INFO] [stdout] | [INFO] [stdout] 279 | fn op_Annn(&mut self, nnn: usize) -> (usize) { [INFO] [stdout] | ^^^^^^^ help: remove these parentheses [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/cpu/mod.rs:285:42 [INFO] [stdout] | [INFO] [stdout] 285 | fn op_Bnnn(&mut self, nnn: usize) -> (usize) { [INFO] [stdout] | ^^^^^^^ help: remove these parentheses [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/cpu/mod.rs:291:48 [INFO] [stdout] | [INFO] [stdout] 291 | fn op_Cxkk(&mut self, x: usize, kk: u8) -> (usize) { [INFO] [stdout] | ^^^^^^^ help: remove these parentheses [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/cpu/mod.rs:298:60 [INFO] [stdout] | [INFO] [stdout] 298 | fn op_Dxyn(&mut self, x: usize, y: usize, n: usize) -> (usize) { [INFO] [stdout] | ^^^^^^^ help: remove these parentheses [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/cpu/mod.rs:312:41 [INFO] [stdout] | [INFO] [stdout] 312 | fn op_Ex9E (&mut self, x: usize) -> (usize) { [INFO] [stdout] | ^^^^^^^ help: remove these parentheses [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/cpu/mod.rs:318:40 [INFO] [stdout] | [INFO] [stdout] 318 | fn op_ExA1(&mut self, x: usize) -> (usize) { [INFO] [stdout] | ^^^^^^^ help: remove these parentheses [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/cpu/mod.rs:324:40 [INFO] [stdout] | [INFO] [stdout] 324 | fn op_Fx07(&mut self, x: usize) -> (usize) { [INFO] [stdout] | ^^^^^^^ help: remove these parentheses [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/cpu/mod.rs:330:40 [INFO] [stdout] | [INFO] [stdout] 330 | fn op_Fx0A(&mut self, x: usize) -> (usize) { [INFO] [stdout] | ^^^^^^^ help: remove these parentheses [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/cpu/mod.rs:344:40 [INFO] [stdout] | [INFO] [stdout] 344 | fn op_Fx15(&mut self, x: usize) -> (usize) { [INFO] [stdout] | ^^^^^^^ help: remove these parentheses [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/cpu/mod.rs:350:40 [INFO] [stdout] | [INFO] [stdout] 350 | fn op_Fx18(&mut self, x: usize) -> (usize) { [INFO] [stdout] | ^^^^^^^ help: remove these parentheses [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/cpu/mod.rs:356:40 [INFO] [stdout] | [INFO] [stdout] 356 | fn op_Fx1E(&mut self, x: usize) -> (usize) { [INFO] [stdout] | ^^^^^^^ help: remove these parentheses [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/cpu/mod.rs:362:40 [INFO] [stdout] | [INFO] [stdout] 362 | fn op_Fx29(&mut self, x: usize) -> (usize) { [INFO] [stdout] | ^^^^^^^ help: remove these parentheses [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/cpu/mod.rs:368:40 [INFO] [stdout] | [INFO] [stdout] 368 | fn op_Fx33(&mut self, x: usize) -> (usize) { [INFO] [stdout] | ^^^^^^^ help: remove these parentheses [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/cpu/mod.rs:376:40 [INFO] [stdout] | [INFO] [stdout] 376 | fn op_Fx55(&mut self, x: usize) -> (usize) { [INFO] [stdout] | ^^^^^^^ help: remove these parentheses [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/cpu/mod.rs:378:22 [INFO] [stdout] | [INFO] [stdout] 378 | let end = if (x > 0xf) {0xf} else {x}; [INFO] [stdout] | ^^^^^^^^^ help: remove these parentheses [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/cpu/mod.rs:387:40 [INFO] [stdout] | [INFO] [stdout] 387 | fn op_Fx65(&mut self, x: usize) -> (usize) { [INFO] [stdout] | ^^^^^^^ help: remove these parentheses [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/cpu/mod.rs:389:22 [INFO] [stdout] | [INFO] [stdout] 389 | let end = if (x > 0xf) {0xf} else {x}; [INFO] [stdout] | ^^^^^^^^^ help: remove these parentheses [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/cpu/mod.rs:397:49 [INFO] [stdout] | [INFO] [stdout] 397 | fn unimplemented(&mut self, opcode: u16) -> (usize) { [INFO] [stdout] | ^^^^^^^ help: remove these parentheses [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/display.rs:22:76 [INFO] [stdout] | [INFO] [stdout] 22 | pub fn draw(&mut self, x: usize, y: usize, n: usize, sprite: &[u8]) -> (bool) { [INFO] [stdout] | ^^^^^^ help: remove these parentheses [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/display.rs:68:51 [INFO] [stdout] | [INFO] [stdout] 68 | pub fn get_pixel(self, x: usize, y: usize) -> (bool) { [INFO] [stdout] | ^^^^^^ help: remove these parentheses [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `b` [INFO] [stdout] --> src/cpu/mod.rs:50:18 [INFO] [stdout] | [INFO] [stdout] 50 | for (i, &b) in rom.iter().enumerate() { [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_b` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `why` [INFO] [stdout] --> src/rom.rs:9:13 [INFO] [stdout] | [INFO] [stdout] 9 | Err(why) => panic!("Couldn't open ROM"), [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_why` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `result` [INFO] [stdout] --> src/display.rs:57:25 [INFO] [stdout] | [INFO] [stdout] 57 | let result = canvas.fill_rect(Rect::new(x_coord, y_coord, 10, 10)); [INFO] [stdout] | ^^^^^^ help: if this is intentional, prefix it with an underscore: `_result` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `event_keycode` [INFO] [stdout] --> src/keypad.rs:24:13 [INFO] [stdout] | [INFO] [stdout] 24 | let event_keycode: Keycode; [INFO] [stdout] | ^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_event_keycode` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/cpu/timers.rs:16:13 [INFO] [stdout] | [INFO] [stdout] 16 | let mut timers = TimerSubsystem { [INFO] [stdout] | ----^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated function is never used: `get_pixel` [INFO] [stdout] --> src/display.rs:68:12 [INFO] [stdout] | [INFO] [stdout] 68 | pub fn get_pixel(self, x: usize, y: usize) -> (bool) { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `op_00E0` should have a snake case name [INFO] [stdout] --> src/cpu/mod.rs:127:8 [INFO] [stdout] | [INFO] [stdout] 127 | fn op_00E0(&mut self) -> (usize) { [INFO] [stdout] | ^^^^^^^ help: convert the identifier to snake case: `op_00_e0` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_snake_case)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `op_00EE` should have a snake case name [INFO] [stdout] --> src/cpu/mod.rs:133:8 [INFO] [stdout] | [INFO] [stdout] 133 | fn op_00EE(&mut self) -> (usize) { [INFO] [stdout] | ^^^^^^^ help: convert the identifier to snake case: `op_00_ee` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `op_8xyE` should have a snake case name [INFO] [stdout] --> src/cpu/mod.rs:264:8 [INFO] [stdout] | [INFO] [stdout] 264 | fn op_8xyE(&mut self, x: usize) -> (usize) { [INFO] [stdout] | ^^^^^^^ help: convert the identifier to snake case: `op_8xy_e` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `op_Annn` should have a snake case name [INFO] [stdout] --> src/cpu/mod.rs:279:8 [INFO] [stdout] | [INFO] [stdout] 279 | fn op_Annn(&mut self, nnn: usize) -> (usize) { [INFO] [stdout] | ^^^^^^^ help: convert the identifier to snake case: `op_annn` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `op_Bnnn` should have a snake case name [INFO] [stdout] --> src/cpu/mod.rs:285:8 [INFO] [stdout] | [INFO] [stdout] 285 | fn op_Bnnn(&mut self, nnn: usize) -> (usize) { [INFO] [stdout] | ^^^^^^^ help: convert the identifier to snake case: `op_bnnn` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `op_Cxkk` should have a snake case name [INFO] [stdout] --> src/cpu/mod.rs:291:8 [INFO] [stdout] | [INFO] [stdout] 291 | fn op_Cxkk(&mut self, x: usize, kk: u8) -> (usize) { [INFO] [stdout] | ^^^^^^^ help: convert the identifier to snake case (notice the capitalization): `op_cxkk` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `op_Dxyn` should have a snake case name [INFO] [stdout] --> src/cpu/mod.rs:298:8 [INFO] [stdout] | [INFO] [stdout] 298 | fn op_Dxyn(&mut self, x: usize, y: usize, n: usize) -> (usize) { [INFO] [stdout] | ^^^^^^^ help: convert the identifier to snake case: `op_dxyn` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `op_Ex9E` should have a snake case name [INFO] [stdout] --> src/cpu/mod.rs:312:8 [INFO] [stdout] | [INFO] [stdout] 312 | fn op_Ex9E (&mut self, x: usize) -> (usize) { [INFO] [stdout] | ^^^^^^^ help: convert the identifier to snake case: `op_ex9_e` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `op_ExA1` should have a snake case name [INFO] [stdout] --> src/cpu/mod.rs:318:8 [INFO] [stdout] | [INFO] [stdout] 318 | fn op_ExA1(&mut self, x: usize) -> (usize) { [INFO] [stdout] | ^^^^^^^ help: convert the identifier to snake case: `op_ex_a1` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `op_Fx07` should have a snake case name [INFO] [stdout] --> src/cpu/mod.rs:324:8 [INFO] [stdout] | [INFO] [stdout] 324 | fn op_Fx07(&mut self, x: usize) -> (usize) { [INFO] [stdout] | ^^^^^^^ help: convert the identifier to snake case (notice the capitalization): `op_fx07` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `op_Fx0A` should have a snake case name [INFO] [stdout] --> src/cpu/mod.rs:330:8 [INFO] [stdout] | [INFO] [stdout] 330 | fn op_Fx0A(&mut self, x: usize) -> (usize) { [INFO] [stdout] | ^^^^^^^ help: convert the identifier to snake case: `op_fx0_a` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `op_Fx15` should have a snake case name [INFO] [stdout] --> src/cpu/mod.rs:344:8 [INFO] [stdout] | [INFO] [stdout] 344 | fn op_Fx15(&mut self, x: usize) -> (usize) { [INFO] [stdout] | ^^^^^^^ help: convert the identifier to snake case (notice the capitalization): `op_fx15` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `op_Fx18` should have a snake case name [INFO] [stdout] --> src/cpu/mod.rs:350:8 [INFO] [stdout] | [INFO] [stdout] 350 | fn op_Fx18(&mut self, x: usize) -> (usize) { [INFO] [stdout] | ^^^^^^^ help: convert the identifier to snake case (notice the capitalization): `op_fx18` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `op_Fx1E` should have a snake case name [INFO] [stdout] --> src/cpu/mod.rs:356:8 [INFO] [stdout] | [INFO] [stdout] 356 | fn op_Fx1E(&mut self, x: usize) -> (usize) { [INFO] [stdout] | ^^^^^^^ help: convert the identifier to snake case: `op_fx1_e` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `op_Fx29` should have a snake case name [INFO] [stdout] --> src/cpu/mod.rs:362:8 [INFO] [stdout] | [INFO] [stdout] 362 | fn op_Fx29(&mut self, x: usize) -> (usize) { [INFO] [stdout] | ^^^^^^^ help: convert the identifier to snake case (notice the capitalization): `op_fx29` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `op_Fx33` should have a snake case name [INFO] [stdout] --> src/cpu/mod.rs:368:8 [INFO] [stdout] | [INFO] [stdout] 368 | fn op_Fx33(&mut self, x: usize) -> (usize) { [INFO] [stdout] | ^^^^^^^ help: convert the identifier to snake case (notice the capitalization): `op_fx33` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `op_Fx55` should have a snake case name [INFO] [stdout] --> src/cpu/mod.rs:376:8 [INFO] [stdout] | [INFO] [stdout] 376 | fn op_Fx55(&mut self, x: usize) -> (usize) { [INFO] [stdout] | ^^^^^^^ help: convert the identifier to snake case (notice the capitalization): `op_fx55` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `op_Fx65` should have a snake case name [INFO] [stdout] --> src/cpu/mod.rs:387:8 [INFO] [stdout] | [INFO] [stdout] 387 | fn op_Fx65(&mut self, x: usize) -> (usize) { [INFO] [stdout] | ^^^^^^^ help: convert the identifier to snake case (notice the capitalization): `op_fx65` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/rom.rs:13:5 [INFO] [stdout] | [INFO] [stdout] 13 | file.read(buf); [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 67 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 9.13s [INFO] running `Command { std: "docker" "inspect" "142474b2f3b245fd229e1978a1f2721f185abd59a2365d68b8cc7cc43b9e34c2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "142474b2f3b245fd229e1978a1f2721f185abd59a2365d68b8cc7cc43b9e34c2", kill_on_drop: false }` [INFO] [stdout] 142474b2f3b245fd229e1978a1f2721f185abd59a2365d68b8cc7cc43b9e34c2 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-14/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-14/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:20528e8c29e4536546f0102ce88568b16ea7538393a33fcca951030f7af10457" "/opt/rustwide/cargo-home/bin/cargo" "+ce59db7a1b1b012fb2793c4641c1bdecad7a128b" "test" "--frozen" "--no-run" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 314f93874dfe1cf4a8707ad16e88d6561d0730c2f8eb74789d64c7464c883ae7 [INFO] running `Command { std: "docker" "start" "-a" "314f93874dfe1cf4a8707ad16e88d6561d0730c2f8eb74789d64c7464c883ae7", kill_on_drop: false }` [INFO] [stderr] Compiling chip8 v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/cpu/timers.rs:42:37 [INFO] [stdout] | [INFO] [stdout] 42 | fn elapsed_millis(&mut self) -> (u64) { [INFO] [stdout] | ^^^^^ help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::num::Wrapping` [INFO] [stdout] --> src/cpu/mod.rs:6:5 [INFO] [stdout] | [INFO] [stdout] 6 | use std::num::Wrapping; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/cpu/mod.rs:127:30 [INFO] [stdout] | [INFO] [stdout] 127 | fn op_00E0(&mut self) -> (usize) { [INFO] [stdout] | ^^^^^^^ help: remove these parentheses [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/cpu/mod.rs:133:30 [INFO] [stdout] | [INFO] [stdout] 133 | fn op_00EE(&mut self) -> (usize) { [INFO] [stdout] | ^^^^^^^ help: remove these parentheses [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/cpu/mod.rs:140:42 [INFO] [stdout] | [INFO] [stdout] 140 | fn op_1nnn(&mut self, nnn: usize) -> (usize) { [INFO] [stdout] | ^^^^^^^ help: remove these parentheses [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/cpu/mod.rs:146:42 [INFO] [stdout] | [INFO] [stdout] 146 | fn op_2nnn(&mut self, nnn: usize) -> (usize) { [INFO] [stdout] | ^^^^^^^ help: remove these parentheses [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/cpu/mod.rs:155:48 [INFO] [stdout] | [INFO] [stdout] 155 | fn op_3xkk(&mut self, x: usize, kk: u8) -> (usize) { [INFO] [stdout] | ^^^^^^^ help: remove these parentheses [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/cpu/mod.rs:163:48 [INFO] [stdout] | [INFO] [stdout] 163 | fn op_4xkk(&mut self, x: usize, kk: u8) -> (usize) { [INFO] [stdout] | ^^^^^^^ help: remove these parentheses [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/cpu/mod.rs:171:50 [INFO] [stdout] | [INFO] [stdout] 171 | fn op_5xy0(&mut self, x: usize, y: usize) -> (usize) { [INFO] [stdout] | ^^^^^^^ help: remove these parentheses [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/cpu/mod.rs:179:48 [INFO] [stdout] | [INFO] [stdout] 179 | fn op_6xkk(&mut self, x: usize, kk: u8) -> (usize) { [INFO] [stdout] | ^^^^^^^ help: remove these parentheses [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/cpu/mod.rs:185:48 [INFO] [stdout] | [INFO] [stdout] 185 | fn op_7xkk(&mut self, x: usize, kk: u8) -> (usize) { [INFO] [stdout] | ^^^^^^^ help: remove these parentheses [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/cpu/mod.rs:192:50 [INFO] [stdout] | [INFO] [stdout] 192 | fn op_8xy0(&mut self, x: usize, y: usize) -> (usize) { [INFO] [stdout] | ^^^^^^^ help: remove these parentheses [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/cpu/mod.rs:198:50 [INFO] [stdout] | [INFO] [stdout] 198 | fn op_8xy1(&mut self, x: usize, y: usize) -> (usize) { [INFO] [stdout] | ^^^^^^^ help: remove these parentheses [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/cpu/mod.rs:204:50 [INFO] [stdout] | [INFO] [stdout] 204 | fn op_8xy2(&mut self, x: usize, y: usize) -> (usize) { [INFO] [stdout] | ^^^^^^^ help: remove these parentheses [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/cpu/mod.rs:210:50 [INFO] [stdout] | [INFO] [stdout] 210 | fn op_8xy3(&mut self, x: usize, y: usize) -> (usize) { [INFO] [stdout] | ^^^^^^^ help: remove these parentheses [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/cpu/mod.rs:216:50 [INFO] [stdout] | [INFO] [stdout] 216 | fn op_8xy4(&mut self, x: usize, y: usize) -> (usize) { [INFO] [stdout] | ^^^^^^^ help: remove these parentheses [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/cpu/mod.rs:230:50 [INFO] [stdout] | [INFO] [stdout] 230 | fn op_8xy5(&mut self, x: usize, y: usize) -> (usize) { [INFO] [stdout] | ^^^^^^^ help: remove these parentheses [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/cpu/mod.rs:245:40 [INFO] [stdout] | [INFO] [stdout] 245 | fn op_8xy6(&mut self, x: usize) -> (usize) { [INFO] [stdout] | ^^^^^^^ help: remove these parentheses [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/cpu/mod.rs:253:50 [INFO] [stdout] | [INFO] [stdout] 253 | fn op_8xy7(&mut self, x: usize, y: usize) -> (usize) { [INFO] [stdout] | ^^^^^^^ help: remove these parentheses [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/cpu/mod.rs:264:40 [INFO] [stdout] | [INFO] [stdout] 264 | fn op_8xyE(&mut self, x: usize) -> (usize) { [INFO] [stdout] | ^^^^^^^ help: remove these parentheses [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/cpu/mod.rs:271:50 [INFO] [stdout] | [INFO] [stdout] 271 | fn op_9xy0(&mut self, x: usize, y: usize) -> (usize) { [INFO] [stdout] | ^^^^^^^ help: remove these parentheses [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/cpu/mod.rs:279:42 [INFO] [stdout] | [INFO] [stdout] 279 | fn op_Annn(&mut self, nnn: usize) -> (usize) { [INFO] [stdout] | ^^^^^^^ help: remove these parentheses [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/cpu/mod.rs:285:42 [INFO] [stdout] | [INFO] [stdout] 285 | fn op_Bnnn(&mut self, nnn: usize) -> (usize) { [INFO] [stdout] | ^^^^^^^ help: remove these parentheses [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/cpu/mod.rs:291:48 [INFO] [stdout] | [INFO] [stdout] 291 | fn op_Cxkk(&mut self, x: usize, kk: u8) -> (usize) { [INFO] [stdout] | ^^^^^^^ help: remove these parentheses [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/cpu/mod.rs:298:60 [INFO] [stdout] | [INFO] [stdout] 298 | fn op_Dxyn(&mut self, x: usize, y: usize, n: usize) -> (usize) { [INFO] [stdout] | ^^^^^^^ help: remove these parentheses [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/cpu/mod.rs:312:41 [INFO] [stdout] | [INFO] [stdout] 312 | fn op_Ex9E (&mut self, x: usize) -> (usize) { [INFO] [stdout] | ^^^^^^^ help: remove these parentheses [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/cpu/mod.rs:318:40 [INFO] [stdout] | [INFO] [stdout] 318 | fn op_ExA1(&mut self, x: usize) -> (usize) { [INFO] [stdout] | ^^^^^^^ help: remove these parentheses [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/cpu/mod.rs:324:40 [INFO] [stdout] | [INFO] [stdout] 324 | fn op_Fx07(&mut self, x: usize) -> (usize) { [INFO] [stdout] | ^^^^^^^ help: remove these parentheses [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/cpu/mod.rs:330:40 [INFO] [stdout] | [INFO] [stdout] 330 | fn op_Fx0A(&mut self, x: usize) -> (usize) { [INFO] [stdout] | ^^^^^^^ help: remove these parentheses [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/cpu/mod.rs:344:40 [INFO] [stdout] | [INFO] [stdout] 344 | fn op_Fx15(&mut self, x: usize) -> (usize) { [INFO] [stdout] | ^^^^^^^ help: remove these parentheses [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/cpu/mod.rs:350:40 [INFO] [stdout] | [INFO] [stdout] 350 | fn op_Fx18(&mut self, x: usize) -> (usize) { [INFO] [stdout] | ^^^^^^^ help: remove these parentheses [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/cpu/mod.rs:356:40 [INFO] [stdout] | [INFO] [stdout] 356 | fn op_Fx1E(&mut self, x: usize) -> (usize) { [INFO] [stdout] | ^^^^^^^ help: remove these parentheses [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/cpu/mod.rs:362:40 [INFO] [stdout] | [INFO] [stdout] 362 | fn op_Fx29(&mut self, x: usize) -> (usize) { [INFO] [stdout] | ^^^^^^^ help: remove these parentheses [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/cpu/mod.rs:368:40 [INFO] [stdout] | [INFO] [stdout] 368 | fn op_Fx33(&mut self, x: usize) -> (usize) { [INFO] [stdout] | ^^^^^^^ help: remove these parentheses [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/cpu/mod.rs:376:40 [INFO] [stdout] | [INFO] [stdout] 376 | fn op_Fx55(&mut self, x: usize) -> (usize) { [INFO] [stdout] | ^^^^^^^ help: remove these parentheses [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/cpu/mod.rs:378:22 [INFO] [stdout] | [INFO] [stdout] 378 | let end = if (x > 0xf) {0xf} else {x}; [INFO] [stdout] | ^^^^^^^^^ help: remove these parentheses [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/cpu/mod.rs:387:40 [INFO] [stdout] | [INFO] [stdout] 387 | fn op_Fx65(&mut self, x: usize) -> (usize) { [INFO] [stdout] | ^^^^^^^ help: remove these parentheses [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/cpu/mod.rs:389:22 [INFO] [stdout] | [INFO] [stdout] 389 | let end = if (x > 0xf) {0xf} else {x}; [INFO] [stdout] | ^^^^^^^^^ help: remove these parentheses [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/cpu/mod.rs:397:49 [INFO] [stdout] | [INFO] [stdout] 397 | fn unimplemented(&mut self, opcode: u16) -> (usize) { [INFO] [stdout] | ^^^^^^^ help: remove these parentheses [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/display.rs:22:76 [INFO] [stdout] | [INFO] [stdout] 22 | pub fn draw(&mut self, x: usize, y: usize, n: usize, sprite: &[u8]) -> (bool) { [INFO] [stdout] | ^^^^^^ help: remove these parentheses [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/display.rs:68:51 [INFO] [stdout] | [INFO] [stdout] 68 | pub fn get_pixel(self, x: usize, y: usize) -> (bool) { [INFO] [stdout] | ^^^^^^ help: remove these parentheses [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `b` [INFO] [stdout] --> src/cpu/mod.rs:50:18 [INFO] [stdout] | [INFO] [stdout] 50 | for (i, &b) in rom.iter().enumerate() { [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_b` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `why` [INFO] [stdout] --> src/rom.rs:9:13 [INFO] [stdout] | [INFO] [stdout] 9 | Err(why) => panic!("Couldn't open ROM"), [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_why` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `result` [INFO] [stdout] --> src/display.rs:57:25 [INFO] [stdout] | [INFO] [stdout] 57 | let result = canvas.fill_rect(Rect::new(x_coord, y_coord, 10, 10)); [INFO] [stdout] | ^^^^^^ help: if this is intentional, prefix it with an underscore: `_result` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `pixels_cleared` [INFO] [stdout] --> src/display.rs:97:13 [INFO] [stdout] | [INFO] [stdout] 97 | let pixels_cleared = display.draw(63, 31, 5, &sprite); [INFO] [stdout] | ^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_pixels_cleared` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `event_keycode` [INFO] [stdout] --> src/keypad.rs:24:13 [INFO] [stdout] | [INFO] [stdout] 24 | let event_keycode: Keycode; [INFO] [stdout] | ^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_event_keycode` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/cpu/timers.rs:16:13 [INFO] [stdout] | [INFO] [stdout] 16 | let mut timers = TimerSubsystem { [INFO] [stdout] | ----^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `op_00E0` should have a snake case name [INFO] [stdout] --> src/cpu/mod.rs:127:8 [INFO] [stdout] | [INFO] [stdout] 127 | fn op_00E0(&mut self) -> (usize) { [INFO] [stdout] | ^^^^^^^ help: convert the identifier to snake case: `op_00_e0` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_snake_case)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `op_00EE` should have a snake case name [INFO] [stdout] --> src/cpu/mod.rs:133:8 [INFO] [stdout] | [INFO] [stdout] 133 | fn op_00EE(&mut self) -> (usize) { [INFO] [stdout] | ^^^^^^^ help: convert the identifier to snake case: `op_00_ee` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `op_8xyE` should have a snake case name [INFO] [stdout] --> src/cpu/mod.rs:264:8 [INFO] [stdout] | [INFO] [stdout] 264 | fn op_8xyE(&mut self, x: usize) -> (usize) { [INFO] [stdout] | ^^^^^^^ help: convert the identifier to snake case: `op_8xy_e` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `op_Annn` should have a snake case name [INFO] [stdout] --> src/cpu/mod.rs:279:8 [INFO] [stdout] | [INFO] [stdout] 279 | fn op_Annn(&mut self, nnn: usize) -> (usize) { [INFO] [stdout] | ^^^^^^^ help: convert the identifier to snake case: `op_annn` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `op_Bnnn` should have a snake case name [INFO] [stdout] --> src/cpu/mod.rs:285:8 [INFO] [stdout] | [INFO] [stdout] 285 | fn op_Bnnn(&mut self, nnn: usize) -> (usize) { [INFO] [stdout] | ^^^^^^^ help: convert the identifier to snake case: `op_bnnn` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `op_Cxkk` should have a snake case name [INFO] [stdout] --> src/cpu/mod.rs:291:8 [INFO] [stdout] | [INFO] [stdout] 291 | fn op_Cxkk(&mut self, x: usize, kk: u8) -> (usize) { [INFO] [stdout] | ^^^^^^^ help: convert the identifier to snake case (notice the capitalization): `op_cxkk` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `op_Dxyn` should have a snake case name [INFO] [stdout] --> src/cpu/mod.rs:298:8 [INFO] [stdout] | [INFO] [stdout] 298 | fn op_Dxyn(&mut self, x: usize, y: usize, n: usize) -> (usize) { [INFO] [stdout] | ^^^^^^^ help: convert the identifier to snake case: `op_dxyn` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `op_Ex9E` should have a snake case name [INFO] [stdout] --> src/cpu/mod.rs:312:8 [INFO] [stdout] | [INFO] [stdout] 312 | fn op_Ex9E (&mut self, x: usize) -> (usize) { [INFO] [stdout] | ^^^^^^^ help: convert the identifier to snake case: `op_ex9_e` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `op_ExA1` should have a snake case name [INFO] [stdout] --> src/cpu/mod.rs:318:8 [INFO] [stdout] | [INFO] [stdout] 318 | fn op_ExA1(&mut self, x: usize) -> (usize) { [INFO] [stdout] | ^^^^^^^ help: convert the identifier to snake case: `op_ex_a1` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `op_Fx07` should have a snake case name [INFO] [stdout] --> src/cpu/mod.rs:324:8 [INFO] [stdout] | [INFO] [stdout] 324 | fn op_Fx07(&mut self, x: usize) -> (usize) { [INFO] [stdout] | ^^^^^^^ help: convert the identifier to snake case (notice the capitalization): `op_fx07` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `op_Fx0A` should have a snake case name [INFO] [stdout] --> src/cpu/mod.rs:330:8 [INFO] [stdout] | [INFO] [stdout] 330 | fn op_Fx0A(&mut self, x: usize) -> (usize) { [INFO] [stdout] | ^^^^^^^ help: convert the identifier to snake case: `op_fx0_a` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `op_Fx15` should have a snake case name [INFO] [stdout] --> src/cpu/mod.rs:344:8 [INFO] [stdout] | [INFO] [stdout] 344 | fn op_Fx15(&mut self, x: usize) -> (usize) { [INFO] [stdout] | ^^^^^^^ help: convert the identifier to snake case (notice the capitalization): `op_fx15` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `op_Fx18` should have a snake case name [INFO] [stdout] --> src/cpu/mod.rs:350:8 [INFO] [stdout] | [INFO] [stdout] 350 | fn op_Fx18(&mut self, x: usize) -> (usize) { [INFO] [stdout] | ^^^^^^^ help: convert the identifier to snake case (notice the capitalization): `op_fx18` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `op_Fx1E` should have a snake case name [INFO] [stdout] --> src/cpu/mod.rs:356:8 [INFO] [stdout] | [INFO] [stdout] 356 | fn op_Fx1E(&mut self, x: usize) -> (usize) { [INFO] [stdout] | ^^^^^^^ help: convert the identifier to snake case: `op_fx1_e` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `op_Fx29` should have a snake case name [INFO] [stdout] --> src/cpu/mod.rs:362:8 [INFO] [stdout] | [INFO] [stdout] 362 | fn op_Fx29(&mut self, x: usize) -> (usize) { [INFO] [stdout] | ^^^^^^^ help: convert the identifier to snake case (notice the capitalization): `op_fx29` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `op_Fx33` should have a snake case name [INFO] [stdout] --> src/cpu/mod.rs:368:8 [INFO] [stdout] | [INFO] [stdout] 368 | fn op_Fx33(&mut self, x: usize) -> (usize) { [INFO] [stdout] | ^^^^^^^ help: convert the identifier to snake case (notice the capitalization): `op_fx33` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `op_Fx55` should have a snake case name [INFO] [stdout] --> src/cpu/mod.rs:376:8 [INFO] [stdout] | [INFO] [stdout] 376 | fn op_Fx55(&mut self, x: usize) -> (usize) { [INFO] [stdout] | ^^^^^^^ help: convert the identifier to snake case (notice the capitalization): `op_fx55` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `op_Fx65` should have a snake case name [INFO] [stdout] --> src/cpu/mod.rs:387:8 [INFO] [stdout] | [INFO] [stdout] 387 | fn op_Fx65(&mut self, x: usize) -> (usize) { [INFO] [stdout] | ^^^^^^^ help: convert the identifier to snake case (notice the capitalization): `op_fx65` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `test_2nnn_and_00EE` should have a snake case name [INFO] [stdout] --> src/cpu/tests.rs:68:4 [INFO] [stdout] | [INFO] [stdout] 68 | fn test_2nnn_and_00EE() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: convert the identifier to snake case: `test_2nnn_and_00_ee` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `test_8xyE` should have a snake case name [INFO] [stdout] --> src/cpu/tests.rs:170:19 [INFO] [stdout] | [INFO] [stdout] 170 | test_register_op!(test_8xyE, 0x821E, 123, 20, 40, 0); [INFO] [stdout] | ^^^^^^^^^ help: convert the identifier to snake case: `test_8xy_e` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `test_8xyE_odd` should have a snake case name [INFO] [stdout] --> src/cpu/tests.rs:171:19 [INFO] [stdout] | [INFO] [stdout] 171 | test_register_op!(test_8xyE_odd, 0x821E, 123, 21, 42, 1); [INFO] [stdout] | ^^^^^^^^^^^^^ help: convert the identifier to snake case: `test_8xy_e_odd` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `test_Annn` should have a snake case name [INFO] [stdout] --> src/cpu/tests.rs:187:4 [INFO] [stdout] | [INFO] [stdout] 187 | fn test_Annn() { [INFO] [stdout] | ^^^^^^^^^ help: convert the identifier to snake case: `test_annn` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `test_Bnnn` should have a snake case name [INFO] [stdout] --> src/cpu/tests.rs:195:4 [INFO] [stdout] | [INFO] [stdout] 195 | fn test_Bnnn() { [INFO] [stdout] | ^^^^^^^^^ help: convert the identifier to snake case: `test_bnnn` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `test_Dxyn` should have a snake case name [INFO] [stdout] --> src/cpu/tests.rs:204:4 [INFO] [stdout] | [INFO] [stdout] 204 | fn test_Dxyn() { [INFO] [stdout] | ^^^^^^^^^ help: convert the identifier to snake case: `test_dxyn` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `test_Cnnn` should have a snake case name [INFO] [stdout] --> src/cpu/tests.rs:214:4 [INFO] [stdout] | [INFO] [stdout] 214 | fn test_Cnnn() { [INFO] [stdout] | ^^^^^^^^^ help: convert the identifier to snake case (notice the capitalization): `test_cnnn` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `test_Fx1E` should have a snake case name [INFO] [stdout] --> src/cpu/tests.rs:222:4 [INFO] [stdout] | [INFO] [stdout] 222 | fn test_Fx1E() { [INFO] [stdout] | ^^^^^^^^^ help: convert the identifier to snake case: `test_fx1_e` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `test_Fx29` should have a snake case name [INFO] [stdout] --> src/cpu/tests.rs:232:4 [INFO] [stdout] | [INFO] [stdout] 232 | fn test_Fx29() { [INFO] [stdout] | ^^^^^^^^^ help: convert the identifier to snake case (notice the capitalization): `test_fx29` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `test_Fx33` should have a snake case name [INFO] [stdout] --> src/cpu/tests.rs:248:4 [INFO] [stdout] | [INFO] [stdout] 248 | fn test_Fx33() { [INFO] [stdout] | ^^^^^^^^^ help: convert the identifier to snake case (notice the capitalization): `test_fx33` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `test_Fx55` should have a snake case name [INFO] [stdout] --> src/cpu/tests.rs:260:4 [INFO] [stdout] | [INFO] [stdout] 260 | fn test_Fx55() { [INFO] [stdout] | ^^^^^^^^^ help: convert the identifier to snake case (notice the capitalization): `test_fx55` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `test_Fx65` should have a snake case name [INFO] [stdout] --> src/cpu/tests.rs:277:4 [INFO] [stdout] | [INFO] [stdout] 277 | fn test_Fx65() { [INFO] [stdout] | ^^^^^^^^^ help: convert the identifier to snake case (notice the capitalization): `test_fx65` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `test_Fx07` should have a snake case name [INFO] [stdout] --> src/cpu/tests.rs:292:4 [INFO] [stdout] | [INFO] [stdout] 292 | fn test_Fx07() { [INFO] [stdout] | ^^^^^^^^^ help: convert the identifier to snake case (notice the capitalization): `test_fx07` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `test_Fx15_and_Fx18` should have a snake case name [INFO] [stdout] --> src/cpu/tests.rs:301:4 [INFO] [stdout] | [INFO] [stdout] 301 | fn test_Fx15_and_Fx18() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: convert the identifier to snake case (notice the capitalization): `test_fx15_and_fx18` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/rom.rs:13:5 [INFO] [stdout] | [INFO] [stdout] 13 | file.read(buf); [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 80 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished test [unoptimized + debuginfo] target(s) in 1.28s [INFO] running `Command { std: "docker" "inspect" "314f93874dfe1cf4a8707ad16e88d6561d0730c2f8eb74789d64c7464c883ae7", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "314f93874dfe1cf4a8707ad16e88d6561d0730c2f8eb74789d64c7464c883ae7", kill_on_drop: false }` [INFO] [stdout] 314f93874dfe1cf4a8707ad16e88d6561d0730c2f8eb74789d64c7464c883ae7 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-14/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-14/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:20528e8c29e4536546f0102ce88568b16ea7538393a33fcca951030f7af10457" "/opt/rustwide/cargo-home/bin/cargo" "+ce59db7a1b1b012fb2793c4641c1bdecad7a128b" "test" "--frozen", kill_on_drop: false }` [INFO] [stdout] 0a577540958d0e8cb5a96794fdd167bc70f24683e62d16c842d02dfe71400a3c [INFO] running `Command { std: "docker" "start" "-a" "0a577540958d0e8cb5a96794fdd167bc70f24683e62d16c842d02dfe71400a3c", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] warning: unnecessary parentheses around type [INFO] [stderr] --> src/cpu/timers.rs:42:37 [INFO] [stderr] | [INFO] [stderr] 42 | fn elapsed_millis(&mut self) -> (u64) { [INFO] [stderr] | ^^^^^ help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(unused_parens)]` on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::num::Wrapping` [INFO] [stderr] --> src/cpu/mod.rs:6:5 [INFO] [stderr] | [INFO] [stderr] 6 | use std::num::Wrapping; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(unused_imports)]` on by default [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around type [INFO] [stderr] --> src/cpu/mod.rs:127:30 [INFO] [stderr] | [INFO] [stderr] 127 | fn op_00E0(&mut self) -> (usize) { [INFO] [stderr] | ^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around type [INFO] [stderr] --> src/cpu/mod.rs:133:30 [INFO] [stderr] | [INFO] [stderr] 133 | fn op_00EE(&mut self) -> (usize) { [INFO] [stderr] | ^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around type [INFO] [stderr] --> src/cpu/mod.rs:140:42 [INFO] [stderr] | [INFO] [stderr] 140 | fn op_1nnn(&mut self, nnn: usize) -> (usize) { [INFO] [stderr] | ^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around type [INFO] [stderr] --> src/cpu/mod.rs:146:42 [INFO] [stderr] | [INFO] [stderr] 146 | fn op_2nnn(&mut self, nnn: usize) -> (usize) { [INFO] [stderr] | ^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around type [INFO] [stderr] --> src/cpu/mod.rs:155:48 [INFO] [stderr] | [INFO] [stderr] 155 | fn op_3xkk(&mut self, x: usize, kk: u8) -> (usize) { [INFO] [stderr] | ^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around type [INFO] [stderr] --> src/cpu/mod.rs:163:48 [INFO] [stderr] | [INFO] [stderr] 163 | fn op_4xkk(&mut self, x: usize, kk: u8) -> (usize) { [INFO] [stderr] | ^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around type [INFO] [stderr] --> src/cpu/mod.rs:171:50 [INFO] [stderr] | [INFO] [stderr] 171 | fn op_5xy0(&mut self, x: usize, y: usize) -> (usize) { [INFO] [stderr] | ^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around type [INFO] [stderr] --> src/cpu/mod.rs:179:48 [INFO] [stderr] | [INFO] [stderr] 179 | fn op_6xkk(&mut self, x: usize, kk: u8) -> (usize) { [INFO] [stderr] | ^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around type [INFO] [stderr] --> src/cpu/mod.rs:185:48 [INFO] [stderr] | [INFO] [stderr] 185 | fn op_7xkk(&mut self, x: usize, kk: u8) -> (usize) { [INFO] [stderr] | ^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around type [INFO] [stderr] --> src/cpu/mod.rs:192:50 [INFO] [stderr] | [INFO] [stderr] 192 | fn op_8xy0(&mut self, x: usize, y: usize) -> (usize) { [INFO] [stderr] | ^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around type [INFO] [stderr] --> src/cpu/mod.rs:198:50 [INFO] [stderr] | [INFO] [stderr] 198 | fn op_8xy1(&mut self, x: usize, y: usize) -> (usize) { [INFO] [stderr] | ^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around type [INFO] [stderr] --> src/cpu/mod.rs:204:50 [INFO] [stderr] | [INFO] [stderr] 204 | fn op_8xy2(&mut self, x: usize, y: usize) -> (usize) { [INFO] [stderr] | ^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around type [INFO] [stderr] --> src/cpu/mod.rs:210:50 [INFO] [stderr] | [INFO] [stderr] 210 | fn op_8xy3(&mut self, x: usize, y: usize) -> (usize) { [INFO] [stderr] | ^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around type [INFO] [stderr] --> src/cpu/mod.rs:216:50 [INFO] [stderr] | [INFO] [stderr] 216 | fn op_8xy4(&mut self, x: usize, y: usize) -> (usize) { [INFO] [stderr] | ^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around type [INFO] [stderr] --> src/cpu/mod.rs:230:50 [INFO] [stderr] | [INFO] [stderr] 230 | fn op_8xy5(&mut self, x: usize, y: usize) -> (usize) { [INFO] [stderr] | ^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around type [INFO] [stderr] --> src/cpu/mod.rs:245:40 [INFO] [stderr] | [INFO] [stderr] 245 | fn op_8xy6(&mut self, x: usize) -> (usize) { [INFO] [stderr] | ^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around type [INFO] [stderr] --> src/cpu/mod.rs:253:50 [INFO] [stderr] | [INFO] [stderr] 253 | fn op_8xy7(&mut self, x: usize, y: usize) -> (usize) { [INFO] [stderr] | ^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around type [INFO] [stderr] --> src/cpu/mod.rs:264:40 [INFO] [stderr] | [INFO] [stderr] 264 | fn op_8xyE(&mut self, x: usize) -> (usize) { [INFO] [stderr] | ^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around type [INFO] [stderr] --> src/cpu/mod.rs:271:50 [INFO] [stderr] | [INFO] [stderr] 271 | fn op_9xy0(&mut self, x: usize, y: usize) -> (usize) { [INFO] [stderr] | ^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around type [INFO] [stderr] --> src/cpu/mod.rs:279:42 [INFO] [stderr] | [INFO] [stderr] 279 | fn op_Annn(&mut self, nnn: usize) -> (usize) { [INFO] [stderr] | ^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around type [INFO] [stderr] --> src/cpu/mod.rs:285:42 [INFO] [stderr] | [INFO] [stderr] 285 | fn op_Bnnn(&mut self, nnn: usize) -> (usize) { [INFO] [stderr] | ^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around type [INFO] [stderr] --> src/cpu/mod.rs:291:48 [INFO] [stderr] | [INFO] [stderr] 291 | fn op_Cxkk(&mut self, x: usize, kk: u8) -> (usize) { [INFO] [stderr] | ^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around type [INFO] [stderr] --> src/cpu/mod.rs:298:60 [INFO] [stderr] | [INFO] [stderr] 298 | fn op_Dxyn(&mut self, x: usize, y: usize, n: usize) -> (usize) { [INFO] [stderr] | ^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around type [INFO] [stderr] --> src/cpu/mod.rs:312:41 [INFO] [stderr] | [INFO] [stderr] 312 | fn op_Ex9E (&mut self, x: usize) -> (usize) { [INFO] [stderr] | ^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around type [INFO] [stderr] --> src/cpu/mod.rs:318:40 [INFO] [stderr] | [INFO] [stderr] 318 | fn op_ExA1(&mut self, x: usize) -> (usize) { [INFO] [stderr] | ^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around type [INFO] [stderr] --> src/cpu/mod.rs:324:40 [INFO] [stderr] | [INFO] [stderr] 324 | fn op_Fx07(&mut self, x: usize) -> (usize) { [INFO] [stderr] | ^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around type [INFO] [stderr] --> src/cpu/mod.rs:330:40 [INFO] [stderr] | [INFO] [stderr] 330 | fn op_Fx0A(&mut self, x: usize) -> (usize) { [INFO] [stderr] | ^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around type [INFO] [stderr] --> src/cpu/mod.rs:344:40 [INFO] [stderr] | [INFO] [stderr] 344 | fn op_Fx15(&mut self, x: usize) -> (usize) { [INFO] [stderr] | ^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around type [INFO] [stderr] --> src/cpu/mod.rs:350:40 [INFO] [stderr] | [INFO] [stderr] 350 | fn op_Fx18(&mut self, x: usize) -> (usize) { [INFO] [stderr] | ^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around type [INFO] [stderr] --> src/cpu/mod.rs:356:40 [INFO] [stderr] | [INFO] [stderr] 356 | fn op_Fx1E(&mut self, x: usize) -> (usize) { [INFO] [stderr] | ^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around type [INFO] [stderr] --> src/cpu/mod.rs:362:40 [INFO] [stderr] | [INFO] [stderr] 362 | fn op_Fx29(&mut self, x: usize) -> (usize) { [INFO] [stderr] | ^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around type [INFO] [stderr] --> src/cpu/mod.rs:368:40 [INFO] [stderr] | [INFO] [stderr] 368 | fn op_Fx33(&mut self, x: usize) -> (usize) { [INFO] [stderr] | ^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around type [INFO] [stderr] --> src/cpu/mod.rs:376:40 [INFO] [stderr] | [INFO] [stderr] 376 | fn op_Fx55(&mut self, x: usize) -> (usize) { [INFO] [stderr] | ^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `if` condition [INFO] [stderr] --> src/cpu/mod.rs:378:22 [INFO] [stderr] | [INFO] [stderr] 378 | let end = if (x > 0xf) {0xf} else {x}; [INFO] [stderr] | ^^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around type [INFO] [stderr] --> src/cpu/mod.rs:387:40 [INFO] [stderr] | [INFO] [stderr] 387 | fn op_Fx65(&mut self, x: usize) -> (usize) { [INFO] [stderr] | ^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `if` condition [INFO] [stderr] --> src/cpu/mod.rs:389:22 [INFO] [stderr] | [INFO] [stderr] 389 | let end = if (x > 0xf) {0xf} else {x}; [INFO] [stderr] | ^^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around type [INFO] [stderr] --> src/cpu/mod.rs:397:49 [INFO] [stderr] | [INFO] [stderr] 397 | fn unimplemented(&mut self, opcode: u16) -> (usize) { [INFO] [stderr] | ^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around type [INFO] [stderr] --> src/display.rs:22:76 [INFO] [stderr] | [INFO] [stderr] 22 | pub fn draw(&mut self, x: usize, y: usize, n: usize, sprite: &[u8]) -> (bool) { [INFO] [stderr] | ^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around type [INFO] [stderr] --> src/display.rs:68:51 [INFO] [stderr] | [INFO] [stderr] 68 | pub fn get_pixel(self, x: usize, y: usize) -> (bool) { [INFO] [stderr] | ^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: unused variable: `b` [INFO] [stderr] --> src/cpu/mod.rs:50:18 [INFO] [stderr] | [INFO] [stderr] 50 | for (i, &b) in rom.iter().enumerate() { [INFO] [stderr] | ^ help: if this is intentional, prefix it with an underscore: `_b` [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(unused_variables)]` on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `why` [INFO] [stderr] --> src/rom.rs:9:13 [INFO] [stderr] | [INFO] [stderr] 9 | Err(why) => panic!("Couldn't open ROM"), [INFO] [stderr] | ^^^ help: if this is intentional, prefix it with an underscore: `_why` [INFO] [stderr] [INFO] [stderr] warning: unused variable: `result` [INFO] [stderr] --> src/display.rs:57:25 [INFO] [stderr] | [INFO] [stderr] 57 | let result = canvas.fill_rect(Rect::new(x_coord, y_coord, 10, 10)); [INFO] [stderr] | ^^^^^^ help: if this is intentional, prefix it with an underscore: `_result` [INFO] [stderr] [INFO] [stderr] warning: unused variable: `pixels_cleared` [INFO] [stderr] --> src/display.rs:97:13 [INFO] [stderr] | [INFO] [stderr] 97 | let pixels_cleared = display.draw(63, 31, 5, &sprite); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_pixels_cleared` [INFO] [stderr] [INFO] [stderr] warning: unused variable: `event_keycode` [INFO] [stderr] --> src/keypad.rs:24:13 [INFO] [stderr] | [INFO] [stderr] 24 | let event_keycode: Keycode; [INFO] [stderr] | ^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_event_keycode` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/cpu/timers.rs:16:13 [INFO] [stderr] | [INFO] [stderr] 16 | let mut timers = TimerSubsystem { [INFO] [stderr] | ----^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(unused_mut)]` on by default [INFO] [stderr] [INFO] [stderr] warning: method `op_00E0` should have a snake case name [INFO] [stderr] --> src/cpu/mod.rs:127:8 [INFO] [stderr] | [INFO] [stderr] 127 | fn op_00E0(&mut self) -> (usize) { [INFO] [stderr] | ^^^^^^^ help: convert the identifier to snake case: `op_00_e0` [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(non_snake_case)]` on by default [INFO] [stderr] [INFO] [stderr] warning: method `op_00EE` should have a snake case name [INFO] [stderr] --> src/cpu/mod.rs:133:8 [INFO] [stderr] | [INFO] [stderr] 133 | fn op_00EE(&mut self) -> (usize) { [INFO] [stderr] | ^^^^^^^ help: convert the identifier to snake case: `op_00_ee` [INFO] [stderr] [INFO] [stderr] warning: method `op_8xyE` should have a snake case name [INFO] [stderr] --> src/cpu/mod.rs:264:8 [INFO] [stderr] | [INFO] [stderr] 264 | fn op_8xyE(&mut self, x: usize) -> (usize) { [INFO] [stderr] | ^^^^^^^ help: convert the identifier to snake case: `op_8xy_e` [INFO] [stderr] [INFO] [stderr] warning: method `op_Annn` should have a snake case name [INFO] [stderr] --> src/cpu/mod.rs:279:8 [INFO] [stderr] | [INFO] [stderr] 279 | fn op_Annn(&mut self, nnn: usize) -> (usize) { [INFO] [stderr] | ^^^^^^^ help: convert the identifier to snake case: `op_annn` [INFO] [stderr] [INFO] [stderr] warning: method `op_Bnnn` should have a snake case name [INFO] [stderr] --> src/cpu/mod.rs:285:8 [INFO] [stderr] | [INFO] [stderr] 285 | fn op_Bnnn(&mut self, nnn: usize) -> (usize) { [INFO] [stderr] | ^^^^^^^ help: convert the identifier to snake case: `op_bnnn` [INFO] [stderr] [INFO] [stderr] warning: method `op_Cxkk` should have a snake case name [INFO] [stderr] --> src/cpu/mod.rs:291:8 [INFO] [stderr] | [INFO] [stderr] 291 | fn op_Cxkk(&mut self, x: usize, kk: u8) -> (usize) { [INFO] [stderr] | ^^^^^^^ help: convert the identifier to snake case (notice the capitalization): `op_cxkk` [INFO] [stderr] [INFO] [stderr] warning: method `op_Dxyn` should have a snake case name [INFO] [stderr] --> src/cpu/mod.rs:298:8 [INFO] [stderr] | [INFO] [stderr] 298 | fn op_Dxyn(&mut self, x: usize, y: usize, n: usize) -> (usize) { [INFO] [stderr] | ^^^^^^^ help: convert the identifier to snake case: `op_dxyn` [INFO] [stderr] [INFO] [stderr] warning: method `op_Ex9E` should have a snake case name [INFO] [stderr] --> src/cpu/mod.rs:312:8 [INFO] [stderr] | [INFO] [stderr] 312 | fn op_Ex9E (&mut self, x: usize) -> (usize) { [INFO] [stderr] | ^^^^^^^ help: convert the identifier to snake case: `op_ex9_e` [INFO] [stderr] [INFO] [stderr] warning: method `op_ExA1` should have a snake case name [INFO] [stderr] --> src/cpu/mod.rs:318:8 [INFO] [stderr] | [INFO] [stderr] 318 | fn op_ExA1(&mut self, x: usize) -> (usize) { [INFO] [stderr] | ^^^^^^^ help: convert the identifier to snake case: `op_ex_a1` [INFO] [stderr] [INFO] [stderr] warning: method `op_Fx07` should have a snake case name [INFO] [stderr] --> src/cpu/mod.rs:324:8 [INFO] [stderr] | [INFO] [stderr] 324 | fn op_Fx07(&mut self, x: usize) -> (usize) { [INFO] [stderr] | ^^^^^^^ help: convert the identifier to snake case (notice the capitalization): `op_fx07` [INFO] [stderr] [INFO] [stderr] warning: method `op_Fx0A` should have a snake case name [INFO] [stderr] --> src/cpu/mod.rs:330:8 [INFO] [stderr] | [INFO] [stderr] 330 | fn op_Fx0A(&mut self, x: usize) -> (usize) { [INFO] [stderr] | ^^^^^^^ help: convert the identifier to snake case: `op_fx0_a` [INFO] [stderr] [INFO] [stderr] warning: method `op_Fx15` should have a snake case name [INFO] [stderr] --> src/cpu/mod.rs:344:8 [INFO] [stderr] | [INFO] [stderr] 344 | fn op_Fx15(&mut self, x: usize) -> (usize) { [INFO] [stderr] | ^^^^^^^ help: convert the identifier to snake case (notice the capitalization): `op_fx15` [INFO] [stderr] [INFO] [stderr] warning: method `op_Fx18` should have a snake case name [INFO] [stderr] --> src/cpu/mod.rs:350:8 [INFO] [stderr] | [INFO] [stderr] 350 | fn op_Fx18(&mut self, x: usize) -> (usize) { [INFO] [stderr] | ^^^^^^^ help: convert the identifier to snake case (notice the capitalization): `op_fx18` [INFO] [stderr] [INFO] [stderr] warning: method `op_Fx1E` should have a snake case name [INFO] [stderr] --> src/cpu/mod.rs:356:8 [INFO] [stderr] | [INFO] [stderr] 356 | fn op_Fx1E(&mut self, x: usize) -> (usize) { [INFO] [stderr] | ^^^^^^^ help: convert the identifier to snake case: `op_fx1_e` [INFO] [stderr] [INFO] [stderr] warning: method `op_Fx29` should have a snake case name [INFO] [stderr] --> src/cpu/mod.rs:362:8 [INFO] [stderr] | [INFO] [stderr] 362 | fn op_Fx29(&mut self, x: usize) -> (usize) { [INFO] [stderr] | ^^^^^^^ help: convert the identifier to snake case (notice the capitalization): `op_fx29` [INFO] [stderr] [INFO] [stderr] warning: method `op_Fx33` should have a snake case name [INFO] [stderr] --> src/cpu/mod.rs:368:8 [INFO] [stderr] | [INFO] [stderr] 368 | fn op_Fx33(&mut self, x: usize) -> (usize) { [INFO] [stderr] | ^^^^^^^ help: convert the identifier to snake case (notice the capitalization): `op_fx33` [INFO] [stderr] [INFO] [stderr] warning: method `op_Fx55` should have a snake case name [INFO] [stderr] --> src/cpu/mod.rs:376:8 [INFO] [stderr] | [INFO] [stderr] 376 | fn op_Fx55(&mut self, x: usize) -> (usize) { [INFO] [stderr] | ^^^^^^^ help: convert the identifier to snake case (notice the capitalization): `op_fx55` [INFO] [stderr] [INFO] [stderr] warning: method `op_Fx65` should have a snake case name [INFO] [stderr] --> src/cpu/mod.rs:387:8 [INFO] [stderr] | [INFO] [stderr] 387 | fn op_Fx65(&mut self, x: usize) -> (usize) { [INFO] [stderr] | ^^^^^^^ help: convert the identifier to snake case (notice the capitalization): `op_fx65` [INFO] [stderr] [INFO] [stderr] warning: function `test_2nnn_and_00EE` should have a snake case name [INFO] [stderr] --> src/cpu/tests.rs:68:4 [INFO] [stderr] | [INFO] [stderr] 68 | fn test_2nnn_and_00EE() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: convert the identifier to snake case: `test_2nnn_and_00_ee` [INFO] [stderr] [INFO] [stderr] warning: function `test_8xyE` should have a snake case name [INFO] [stderr] --> src/cpu/tests.rs:170:19 [INFO] [stderr] | [INFO] [stderr] 170 | test_register_op!(test_8xyE, 0x821E, 123, 20, 40, 0); [INFO] [stderr] | ^^^^^^^^^ help: convert the identifier to snake case: `test_8xy_e` [INFO] [stderr] [INFO] [stderr] warning: function `test_8xyE_odd` should have a snake case name [INFO] [stderr] --> src/cpu/tests.rs:171:19 [INFO] [stderr] | [INFO] [stderr] 171 | test_register_op!(test_8xyE_odd, 0x821E, 123, 21, 42, 1); [INFO] [stderr] | ^^^^^^^^^^^^^ help: convert the identifier to snake case: `test_8xy_e_odd` [INFO] [stderr] [INFO] [stderr] warning: function `test_Annn` should have a snake case name [INFO] [stderr] --> src/cpu/tests.rs:187:4 [INFO] [stderr] | [INFO] [stderr] 187 | fn test_Annn() { [INFO] [stderr] | ^^^^^^^^^ help: convert the identifier to snake case: `test_annn` [INFO] [stderr] [INFO] [stderr] warning: function `test_Bnnn` should have a snake case name [INFO] [stderr] --> src/cpu/tests.rs:195:4 [INFO] [stderr] | [INFO] [stderr] 195 | fn test_Bnnn() { [INFO] [stderr] | ^^^^^^^^^ help: convert the identifier to snake case: `test_bnnn` [INFO] [stderr] [INFO] [stderr] warning: function `test_Dxyn` should have a snake case name [INFO] [stderr] --> src/cpu/tests.rs:204:4 [INFO] [stderr] | [INFO] [stderr] 204 | fn test_Dxyn() { [INFO] [stderr] | ^^^^^^^^^ help: convert the identifier to snake case: `test_dxyn` [INFO] [stderr] [INFO] [stderr] warning: function `test_Cnnn` should have a snake case name [INFO] [stderr] --> src/cpu/tests.rs:214:4 [INFO] [stderr] | [INFO] [stderr] 214 | fn test_Cnnn() { [INFO] [stderr] | ^^^^^^^^^ help: convert the identifier to snake case (notice the capitalization): `test_cnnn` [INFO] [stderr] [INFO] [stderr] warning: function `test_Fx1E` should have a snake case name [INFO] [stderr] --> src/cpu/tests.rs:222:4 [INFO] [stderr] | [INFO] [stderr] 222 | fn test_Fx1E() { [INFO] [stderr] | ^^^^^^^^^ help: convert the identifier to snake case: `test_fx1_e` [INFO] [stderr] [INFO] [stderr] warning: function `test_Fx29` should have a snake case name [INFO] [stderr] --> src/cpu/tests.rs:232:4 [INFO] [stderr] | [INFO] [stderr] 232 | fn test_Fx29() { [INFO] [stderr] | ^^^^^^^^^ help: convert the identifier to snake case (notice the capitalization): `test_fx29` [INFO] [stderr] [INFO] [stderr] warning: function `test_Fx33` should have a snake case name [INFO] [stderr] --> src/cpu/tests.rs:248:4 [INFO] [stderr] | [INFO] [stderr] 248 | fn test_Fx33() { [INFO] [stderr] | ^^^^^^^^^ help: convert the identifier to snake case (notice the capitalization): `test_fx33` [INFO] [stderr] [INFO] [stderr] warning: function `test_Fx55` should have a snake case name [INFO] [stderr] --> src/cpu/tests.rs:260:4 [INFO] [stderr] | [INFO] [stderr] 260 | fn test_Fx55() { [INFO] [stderr] | ^^^^^^^^^ help: convert the identifier to snake case (notice the capitalization): `test_fx55` [INFO] [stderr] [INFO] [stderr] warning: function `test_Fx65` should have a snake case name [INFO] [stderr] --> src/cpu/tests.rs:277:4 [INFO] [stderr] | [INFO] [stderr] 277 | fn test_Fx65() { [INFO] [stderr] | ^^^^^^^^^ help: convert the identifier to snake case (notice the capitalization): `test_fx65` [INFO] [stderr] [INFO] [stderr] warning: function `test_Fx07` should have a snake case name [INFO] [stderr] --> src/cpu/tests.rs:292:4 [INFO] [stderr] | [INFO] [stderr] 292 | fn test_Fx07() { [INFO] [stderr] | ^^^^^^^^^ help: convert the identifier to snake case (notice the capitalization): `test_fx07` [INFO] [stderr] [INFO] [stderr] warning: function `test_Fx15_and_Fx18` should have a snake case name [INFO] [stderr] --> src/cpu/tests.rs:301:4 [INFO] [stderr] | [INFO] [stderr] 301 | fn test_Fx15_and_Fx18() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: convert the identifier to snake case (notice the capitalization): `test_fx15_and_fx18` [INFO] [stderr] [INFO] [stderr] warning: unused `Result` that must be used [INFO] [stderr] --> src/rom.rs:13:5 [INFO] [stderr] | [INFO] [stderr] 13 | file.read(buf); [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(unused_must_use)]` on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: 80 warnings emitted [INFO] [stderr] [INFO] [stderr] Finished test [unoptimized + debuginfo] target(s) in 0.92s [INFO] [stderr] Running unittests (/opt/rustwide/target/debug/deps/chip8-0d930853d752b679) [INFO] [stdout] [INFO] [stdout] running 43 tests [INFO] [stdout] test cpu::tests::test_6xkk ... ok [INFO] [stdout] test cpu::tests::test_7xkk ... ok [INFO] [stdout] test cpu::tests::test_8xy5 ... ok [INFO] [stdout] test cpu::tests::test_load_rom ... ok [INFO] [stdout] test cpu::tests::test_8xy1 ... ok [INFO] [stdout] test cpu::tests::test_get_opcode ... ok [INFO] [stdout] test cpu::tests::test_8xy0 ... ok [INFO] [stdout] test cpu::tests::test_8xy6_odd ... ok [INFO] [stdout] test cpu::tests::test_new_chip8 ... ok [INFO] [stdout] test display::tests::test_clear ... ok [INFO] [stdout] test cpu::tests::test_cycle ... ok [INFO] [stdout] test cpu::tests::test_8xy7 ... ok [INFO] [stdout] test cpu::tests::test_8xy7_borrow ... ok [INFO] [stdout] test cpu::tests::test_8xyE ... ok [INFO] [stdout] test cpu::tests::test_8xyE_odd ... ok [INFO] [stdout] test cpu::tests::test_9xy0 ... ok [INFO] [stdout] test keypad::tests::test_get_key ... ok [INFO] [stdout] test cpu::tests::test_Fx55 ... ok [INFO] [stdout] test keypad::tests::test_wait_for_keypress ... ok [INFO] [stdout] test cpu::tests::test_Cnnn ... ok [INFO] [stdout] test cpu::tests::test_Fx15_and_Fx18 ... ok [INFO] [stdout] test cpu::tests::test_8xy6 ... ok [INFO] [stdout] test cpu::tests::test_Fx1E ... ok [INFO] [stdout] test cpu::tests::test_Fx29 ... ok [INFO] [stdout] test cpu::tests::test_Fx33 ... ok [INFO] [stdout] test rom::tests::test_load_rom_file ... ok [INFO] [stdout] test cpu::tests::test_5xy0 ... ok [INFO] [stdout] test cpu::tests::test_8xy5_borrow ... ok [INFO] [stdout] test display::tests::test_draw_wrap_around ... ok [INFO] [stdout] test cpu::tests::test_8xy4_carry ... ok [INFO] [stdout] test cpu::tests::test_8xy4 ... ok [INFO] [stdout] test cpu::tests::test_8xy2 ... ok [INFO] [stdout] test cpu::tests::test_1nnn ... ok [INFO] [stdout] test cpu::tests::test_8xy3 ... ok [INFO] [stdout] test cpu::tests::test_Dxyn ... ok [INFO] [stdout] test cpu::tests::test_Fx65 ... ok [INFO] [stdout] test cpu::tests::test_2nnn_and_00EE ... ok [INFO] [stdout] test cpu::tests::test_Bnnn ... ok [INFO] [stdout] test cpu::tests::test_Annn ... ok [INFO] [stdout] test cpu::tests::test_Fx07 ... ok [INFO] [stdout] test display::tests::test_draw ... FAILED [INFO] [stdout] test cpu::tests::test_3xkk_and_4xkk ... ok [INFO] [stderr] error: test failed, to rerun pass '--bin chip8' [INFO] [stdout] test cpu::timers::tests::test_timer_subsystem ... ok [INFO] [stdout] [INFO] [stdout] failures: [INFO] [stdout] [INFO] [stdout] ---- display::tests::test_draw stdout ---- [INFO] [stdout] thread 'display::tests::test_draw' panicked at 'assertion failed: `(left == right)` [INFO] [stdout] left: `[false, true, true, true]`, [INFO] [stdout] right: `[true, true, true, true]`', src/display.rs:87:9 [INFO] [stdout] stack backtrace: [INFO] [stdout] 0: 0x563c603cce40 - std[77c0456e0eb29f0c]::backtrace_rs::backtrace::libunwind::trace [INFO] [stdout] at /rustc/ce59db7a1b1b012fb2793c4641c1bdecad7a128b/library/std/src/../../backtrace/src/backtrace/libunwind.rs:90:5 [INFO] [stdout] 1: 0x563c603cce40 - std[77c0456e0eb29f0c]::backtrace_rs::backtrace::trace_unsynchronized:: [INFO] [stdout] at /rustc/ce59db7a1b1b012fb2793c4641c1bdecad7a128b/library/std/src/../../backtrace/src/backtrace/mod.rs:66:5 [INFO] [stdout] 2: 0x563c603cce40 - std[77c0456e0eb29f0c]::sys_common::backtrace::_print_fmt [INFO] [stdout] at /rustc/ce59db7a1b1b012fb2793c4641c1bdecad7a128b/library/std/src/sys_common/backtrace.rs:67:5 [INFO] [stdout] 3: 0x563c603cce40 - ::fmt [INFO] [stdout] at /rustc/ce59db7a1b1b012fb2793c4641c1bdecad7a128b/library/std/src/sys_common/backtrace.rs:46:22 [INFO] [stdout] 4: 0x563c603ef67c - core[ee1ca6415511a9c4]::fmt::write [INFO] [stdout] at /rustc/ce59db7a1b1b012fb2793c4641c1bdecad7a128b/library/core/src/fmt/mod.rs:1110:17 [INFO] [stdout] 5: 0x563c603c9ca5 - as std[77c0456e0eb29f0c]::io::Write>::write_fmt [INFO] [stdout] at /rustc/ce59db7a1b1b012fb2793c4641c1bdecad7a128b/library/std/src/io/mod.rs:1584:15 [INFO] [stdout] 6: 0x563c603cefcb - std[77c0456e0eb29f0c]::sys_common::backtrace::_print [INFO] [stdout] at /rustc/ce59db7a1b1b012fb2793c4641c1bdecad7a128b/library/std/src/sys_common/backtrace.rs:49:5 [INFO] [stdout] 7: 0x563c603cefcb - std[77c0456e0eb29f0c]::sys_common::backtrace::print [INFO] [stdout] at /rustc/ce59db7a1b1b012fb2793c4641c1bdecad7a128b/library/std/src/sys_common/backtrace.rs:36:9 [INFO] [stdout] 8: 0x563c603cefcb - std[77c0456e0eb29f0c]::panicking::default_hook::{closure#1} [INFO] [stdout] at /rustc/ce59db7a1b1b012fb2793c4641c1bdecad7a128b/library/std/src/panicking.rs:208:50 [INFO] [stdout] 9: 0x563c603ceadc - std[77c0456e0eb29f0c]::panicking::default_hook [INFO] [stdout] at /rustc/ce59db7a1b1b012fb2793c4641c1bdecad7a128b/library/std/src/panicking.rs:222:9 [INFO] [stdout] 10: 0x563c603cf671 - std[77c0456e0eb29f0c]::panicking::rust_panic_with_hook [INFO] [stdout] at /rustc/ce59db7a1b1b012fb2793c4641c1bdecad7a128b/library/std/src/panicking.rs:622:17 [INFO] [stdout] 11: 0x563c603cf177 - std[77c0456e0eb29f0c]::panicking::begin_panic_handler::{closure#0} [INFO] [stdout] at /rustc/ce59db7a1b1b012fb2793c4641c1bdecad7a128b/library/std/src/panicking.rs:519:13 [INFO] [stdout] 12: 0x563c603cd33c - std[77c0456e0eb29f0c]::sys_common::backtrace::__rust_end_short_backtrace:: [INFO] [stdout] at /rustc/ce59db7a1b1b012fb2793c4641c1bdecad7a128b/library/std/src/sys_common/backtrace.rs:141:18 [INFO] [stdout] 13: 0x563c603cf0d9 - rust_begin_unwind [INFO] [stdout] at /rustc/ce59db7a1b1b012fb2793c4641c1bdecad7a128b/library/std/src/panicking.rs:515:5 [INFO] [stdout] 14: 0x563c6034a4b1 - core[ee1ca6415511a9c4]::panicking::panic_fmt [INFO] [stdout] at /rustc/ce59db7a1b1b012fb2793c4641c1bdecad7a128b/library/core/src/panicking.rs:92:14 [INFO] [stdout] 15: 0x563c603edf98 - core[ee1ca6415511a9c4]::panicking::assert_failed_inner [INFO] [stdout] 16: 0x563c60354996 - core[ee1ca6415511a9c4]::panicking::assert_failed::<[bool], [bool; 4: usize]> [INFO] [stdout] at /rustc/ce59db7a1b1b012fb2793c4641c1bdecad7a128b/library/core/src/panicking.rs:117:5 [INFO] [stdout] 17: 0x563c60353309 - chip8[1a31020488107476]::display::tests::test_draw [INFO] [stdout] at /opt/rustwide/workdir/src/display.rs:87:9 [INFO] [stdout] 18: 0x563c6035307a - chip8[1a31020488107476]::display::tests::test_draw::{closure#0} [INFO] [stdout] at /opt/rustwide/workdir/src/display.rs:78:5 [INFO] [stdout] 19: 0x563c603548be - >::call_once [INFO] [stdout] at /rustc/ce59db7a1b1b012fb2793c4641c1bdecad7a128b/library/core/src/ops/function.rs:227:5 [INFO] [stdout] 20: 0x563c6037b883 - >::call_once [INFO] [stdout] at /rustc/ce59db7a1b1b012fb2793c4641c1bdecad7a128b/library/core/src/ops/function.rs:227:5 [INFO] [stdout] 21: 0x563c6037b883 - test[eeb9024d9ac7bc83]::__rust_begin_short_backtrace:: [INFO] [stdout] at /rustc/ce59db7a1b1b012fb2793c4641c1bdecad7a128b/library/test/src/lib.rs:577:5 [INFO] [stdout] 22: 0x563c6037a34c - + core[ee1ca6415511a9c4]::marker::Send> as core[ee1ca6415511a9c4]::ops::function::FnOnce<()>>::call_once [INFO] [stdout] at /rustc/ce59db7a1b1b012fb2793c4641c1bdecad7a128b/library/alloc/src/boxed.rs:1575:9 [INFO] [stdout] 23: 0x563c6037a34c - + core[ee1ca6415511a9c4]::marker::Send>> as core[ee1ca6415511a9c4]::ops::function::FnOnce<()>>::call_once [INFO] [stdout] at /rustc/ce59db7a1b1b012fb2793c4641c1bdecad7a128b/library/std/src/panic.rs:346:9 [INFO] [stdout] 24: 0x563c6037a34c - std[77c0456e0eb29f0c]::panicking::try::do_call:: + core[ee1ca6415511a9c4]::marker::Send>>, ()> [INFO] [stdout] at /rustc/ce59db7a1b1b012fb2793c4641c1bdecad7a128b/library/std/src/panicking.rs:401:40 [INFO] [stdout] 25: 0x563c6037a34c - std[77c0456e0eb29f0c]::panicking::try::<(), std[77c0456e0eb29f0c]::panic::AssertUnwindSafe + core[ee1ca6415511a9c4]::marker::Send>>> [INFO] [stdout] at /rustc/ce59db7a1b1b012fb2793c4641c1bdecad7a128b/library/std/src/panicking.rs:365:19 [INFO] [stdout] 26: 0x563c6037a34c - std[77c0456e0eb29f0c]::panic::catch_unwind:: + core[ee1ca6415511a9c4]::marker::Send>>, ()> [INFO] [stdout] at /rustc/ce59db7a1b1b012fb2793c4641c1bdecad7a128b/library/std/src/panic.rs:433:14 [INFO] [stdout] 27: 0x563c6037a34c - test[eeb9024d9ac7bc83]::run_test_in_process [INFO] [stdout] at /rustc/ce59db7a1b1b012fb2793c4641c1bdecad7a128b/library/test/src/lib.rs:600:18 [INFO] [stdout] 28: 0x563c6037a34c - test[eeb9024d9ac7bc83]::run_test::run_test_inner::{closure#0} [INFO] [stdout] at /rustc/ce59db7a1b1b012fb2793c4641c1bdecad7a128b/library/test/src/lib.rs:492:39 [INFO] [stdout] 29: 0x563c6035a012 - test[eeb9024d9ac7bc83]::run_test::run_test_inner::{closure#1} [INFO] [stdout] at /rustc/ce59db7a1b1b012fb2793c4641c1bdecad7a128b/library/test/src/lib.rs:519:37 [INFO] [stdout] 30: 0x563c6035a012 - std[77c0456e0eb29f0c]::sys_common::backtrace::__rust_begin_short_backtrace:: [INFO] [stdout] at /rustc/ce59db7a1b1b012fb2793c4641c1bdecad7a128b/library/std/src/sys_common/backtrace.rs:125:18 [INFO] [stdout] 31: 0x563c6035a8f8 - ::spawn_unchecked::::{closure#0}::{closure#0} [INFO] [stdout] at /rustc/ce59db7a1b1b012fb2793c4641c1bdecad7a128b/library/std/src/thread/mod.rs:481:17 [INFO] [stdout] 32: 0x563c6035a8f8 - ::spawn_unchecked::{closure#0}::{closure#0}> as core[ee1ca6415511a9c4]::ops::function::FnOnce<()>>::call_once [INFO] [stdout] at /rustc/ce59db7a1b1b012fb2793c4641c1bdecad7a128b/library/std/src/panic.rs:346:9 [INFO] [stdout] 33: 0x563c6035a8f8 - std[77c0456e0eb29f0c]::panicking::try::do_call::::spawn_unchecked::{closure#0}::{closure#0}>, ()> [INFO] [stdout] at /rustc/ce59db7a1b1b012fb2793c4641c1bdecad7a128b/library/std/src/panicking.rs:401:40 [INFO] [stdout] 34: 0x563c6035a8f8 - std[77c0456e0eb29f0c]::panicking::try::<(), std[77c0456e0eb29f0c]::panic::AssertUnwindSafe<::spawn_unchecked::{closure#0}::{closure#0}>> [INFO] [stdout] at /rustc/ce59db7a1b1b012fb2793c4641c1bdecad7a128b/library/std/src/panicking.rs:365:19 [INFO] [stdout] 35: 0x563c6035a8f8 - std[77c0456e0eb29f0c]::panic::catch_unwind::::spawn_unchecked::{closure#0}::{closure#0}>, ()> [INFO] [stdout] at /rustc/ce59db7a1b1b012fb2793c4641c1bdecad7a128b/library/std/src/panic.rs:433:14 [INFO] [stdout] 36: 0x563c6035a8f8 - ::spawn_unchecked::::{closure#0} [INFO] [stdout] at /rustc/ce59db7a1b1b012fb2793c4641c1bdecad7a128b/library/std/src/thread/mod.rs:480:30 [INFO] [stdout] 37: 0x563c6035a8f8 - <::spawn_unchecked::{closure#0} as core[ee1ca6415511a9c4]::ops::function::FnOnce<()>>::call_once::{shim:vtable#0} [INFO] [stdout] at /rustc/ce59db7a1b1b012fb2793c4641c1bdecad7a128b/library/core/src/ops/function.rs:227:5 [INFO] [stdout] 38: 0x563c603d4187 - > as core[ee1ca6415511a9c4]::ops::function::FnOnce<()>>::call_once [INFO] [stdout] at /rustc/ce59db7a1b1b012fb2793c4641c1bdecad7a128b/library/alloc/src/boxed.rs:1575:9 [INFO] [stdout] 39: 0x563c603d4187 - >> as core[ee1ca6415511a9c4]::ops::function::FnOnce<()>>::call_once [INFO] [stdout] at /rustc/ce59db7a1b1b012fb2793c4641c1bdecad7a128b/library/alloc/src/boxed.rs:1575:9 [INFO] [stdout] 40: 0x563c603d4187 - ::new::thread_start [INFO] [stdout] at /rustc/ce59db7a1b1b012fb2793c4641c1bdecad7a128b/library/std/src/sys/unix/thread.rs:71:17 [INFO] [stdout] 41: 0x7fbdd05c7609 - start_thread [INFO] [stdout] 42: 0x7fbdd0399293 - clone [INFO] [stdout] 43: 0x0 - [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] failures: [INFO] [stdout] display::tests::test_draw [INFO] [stdout] [INFO] [stdout] test result: FAILED. 42 passed; 1 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.10s [INFO] [stdout] [INFO] running `Command { std: "docker" "inspect" "0a577540958d0e8cb5a96794fdd167bc70f24683e62d16c842d02dfe71400a3c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "0a577540958d0e8cb5a96794fdd167bc70f24683e62d16c842d02dfe71400a3c", kill_on_drop: false }` [INFO] [stdout] 0a577540958d0e8cb5a96794fdd167bc70f24683e62d16c842d02dfe71400a3c