[INFO] cloning repository https://github.com/TomasLongo/rdnglst [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/TomasLongo/rdnglst" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FTomasLongo%2Frdnglst", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FTomasLongo%2Frdnglst'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] cb2623d68b3ccfe10fc78c2b9a337b22445d89aa [INFO] testing TomasLongo/rdnglst against try#ce59db7a1b1b012fb2793c4641c1bdecad7a128b for pr-85530 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FTomasLongo%2Frdnglst" "/workspace/builds/worker-6/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-6/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/TomasLongo/rdnglst on toolchain ce59db7a1b1b012fb2793c4641c1bdecad7a128b [INFO] running `Command { std: "/workspace/cargo-home/bin/cargo" "+ce59db7a1b1b012fb2793c4641c1bdecad7a128b" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/TomasLongo/rdnglst [INFO] finished tweaking git repo https://github.com/TomasLongo/rdnglst [INFO] tweaked toml for git repo https://github.com/TomasLongo/rdnglst written to /workspace/builds/worker-6/source/Cargo.toml [INFO] crate git repo https://github.com/TomasLongo/rdnglst already has a lockfile, it will not be regenerated [INFO] running `Command { std: "/workspace/cargo-home/bin/cargo" "+ce59db7a1b1b012fb2793c4641c1bdecad7a128b" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded comfy-table v1.5.0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:20528e8c29e4536546f0102ce88568b16ea7538393a33fcca951030f7af10457" "/opt/rustwide/cargo-home/bin/cargo" "+ce59db7a1b1b012fb2793c4641c1bdecad7a128b" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] f637ee708e4b457db7d33d0d9040b82cc79e1cd18ecdcb2db14a1f3a6a2cfbf6 [INFO] [stderr] WARNING: Your kernel does not support swap limit capabilities or the cgroup is not mounted. Memory limited without swap. [INFO] running `Command { std: "docker" "start" "-a" "f637ee708e4b457db7d33d0d9040b82cc79e1cd18ecdcb2db14a1f3a6a2cfbf6", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "f637ee708e4b457db7d33d0d9040b82cc79e1cd18ecdcb2db14a1f3a6a2cfbf6", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "f637ee708e4b457db7d33d0d9040b82cc79e1cd18ecdcb2db14a1f3a6a2cfbf6", kill_on_drop: false }` [INFO] [stdout] f637ee708e4b457db7d33d0d9040b82cc79e1cd18ecdcb2db14a1f3a6a2cfbf6 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:20528e8c29e4536546f0102ce88568b16ea7538393a33fcca951030f7af10457" "/opt/rustwide/cargo-home/bin/cargo" "+ce59db7a1b1b012fb2793c4641c1bdecad7a128b" "build" "--frozen" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] cd7b96c308bc2c9c3295bcc567674208839d2951061b41ed1baa897bdbf42515 [INFO] [stderr] WARNING: Your kernel does not support swap limit capabilities or the cgroup is not mounted. Memory limited without swap. [INFO] running `Command { std: "docker" "start" "-a" "cd7b96c308bc2c9c3295bcc567674208839d2951061b41ed1baa897bdbf42515", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.81 [INFO] [stderr] Compiling cfg-if v1.0.0 [INFO] [stderr] Compiling proc-macro2 v1.0.24 [INFO] [stderr] Compiling unicode-xid v0.2.1 [INFO] [stderr] Compiling bitflags v1.2.1 [INFO] [stderr] Compiling version_check v0.9.2 [INFO] [stderr] Compiling getrandom v0.1.16 [INFO] [stderr] Compiling cfg-if v0.1.10 [INFO] [stderr] Compiling syn v1.0.57 [INFO] [stderr] Compiling log v0.4.11 [INFO] [stderr] Compiling unicode-width v0.1.8 [INFO] [stderr] Compiling unicode-segmentation v1.7.1 [INFO] [stderr] Compiling lazy_static v1.4.0 [INFO] [stderr] Compiling smallvec v1.6.0 [INFO] [stderr] Compiling ppv-lite86 v0.2.10 [INFO] [stderr] Compiling scopeguard v1.1.0 [INFO] [stderr] Compiling pkg-config v0.3.19 [INFO] [stderr] Compiling serde v1.0.120 [INFO] [stderr] Compiling memchr v2.3.4 [INFO] [stderr] Compiling ahash v0.4.7 [INFO] [stderr] Compiling strsim v0.8.0 [INFO] [stderr] Compiling numtoa v0.1.0 [INFO] [stderr] Compiling ansi_term v0.11.0 [INFO] [stderr] Compiling remove_dir_all v0.5.3 [INFO] [stderr] Compiling vec_map v0.8.2 [INFO] [stderr] Compiling fallible-iterator v0.2.0 [INFO] [stderr] Compiling fallible-streaming-iterator v0.1.9 [INFO] [stderr] Compiling cassowary v0.3.0 [INFO] [stderr] Compiling zeroize v0.9.3 [INFO] [stderr] Compiling strum v0.20.0 [INFO] [stderr] Compiling instant v0.1.9 [INFO] [stderr] Compiling textwrap v0.11.0 [INFO] [stderr] Compiling lock_api v0.4.2 [INFO] [stderr] Compiling hashbrown v0.9.1 [INFO] [stderr] Compiling heck v0.3.2 [INFO] [stderr] Compiling proc-macro-error-attr v1.0.4 [INFO] [stderr] Compiling proc-macro-error v1.0.4 [INFO] [stderr] Compiling libsqlite3-sys v0.20.1 [INFO] [stderr] Compiling hashlink v0.6.0 [INFO] [stderr] Compiling quote v1.0.8 [INFO] [stderr] Compiling signal-hook-registry v1.3.0 [INFO] [stderr] Compiling parking_lot_core v0.8.2 [INFO] [stderr] Compiling mio v0.7.7 [INFO] [stderr] Compiling atty v0.2.14 [INFO] [stderr] Compiling terminal_size v0.1.15 [INFO] [stderr] Compiling termion v1.5.5 [INFO] [stderr] Compiling clap v2.33.3 [INFO] [stderr] Compiling console v0.13.0 [INFO] [stderr] Compiling rand_core v0.5.1 [INFO] [stderr] Compiling rusqlite v0.24.2 [INFO] [stderr] Compiling parking_lot v0.11.1 [INFO] [stderr] Compiling signal-hook v0.1.17 [INFO] [stderr] Compiling rand_chacha v0.2.2 [INFO] [stderr] Compiling tui v0.14.0 [INFO] [stderr] Compiling crossterm v0.19.0 [INFO] [stderr] Compiling rand v0.7.3 [INFO] [stderr] Compiling tempfile v3.1.0 [INFO] [stderr] Compiling dialoguer v0.7.1 [INFO] [stderr] Compiling toml v0.5.8 [INFO] [stderr] Compiling structopt-derive v0.4.14 [INFO] [stderr] Compiling strum_macros v0.20.1 [INFO] [stderr] Compiling comfy-table v1.5.0 [INFO] [stderr] Compiling structopt v0.3.21 [INFO] [stderr] Compiling readinglist v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `MappedRows` [INFO] [stdout] --> src/lib.rs:2:27 [INFO] [stdout] | [INFO] [stdout] 2 | use rusqlite::{NO_PARAMS, MappedRows, types::FromSql, types::FromSqlResult, types::ValueRef}; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `s` [INFO] [stdout] --> src/lib.rs:24:16 [INFO] [stdout] | [INFO] [stdout] 24 | Ok(s) => { [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_s` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `stringToFormatEnum` should have a snake case name [INFO] [stdout] --> src/lib.rs:32:8 [INFO] [stdout] | [INFO] [stdout] 32 | pub fn stringToFormatEnum(toConvert: &str) -> Format { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: convert the identifier to snake case: `string_to_format_enum` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_snake_case)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `toConvert` should have a snake case name [INFO] [stdout] --> src/lib.rs:32:27 [INFO] [stdout] | [INFO] [stdout] 32 | pub fn stringToFormatEnum(toConvert: &str) -> Format { [INFO] [stdout] | ^^^^^^^^^ help: convert the identifier to snake case: `to_convert` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `formatEnumToString` should have a snake case name [INFO] [stdout] --> src/lib.rs:43:8 [INFO] [stdout] | [INFO] [stdout] 43 | pub fn formatEnumToString(f: &Format) -> String { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: convert the identifier to snake case: `format_enum_to_string` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait method `getById` should have a snake case name [INFO] [stdout] --> src/lib.rs:51:8 [INFO] [stdout] | [INFO] [stdout] 51 | fn getById(&self, id: i64) -> Result; [INFO] [stdout] | ^^^^^^^ help: convert the identifier to snake case: `get_by_id` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait method `deleteById` should have a snake case name [INFO] [stdout] --> src/lib.rs:52:8 [INFO] [stdout] | [INFO] [stdout] 52 | fn deleteById(&self, id: i64) -> Result; [INFO] [stdout] | ^^^^^^^^^^ help: convert the identifier to snake case: `delete_by_id` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait method `updateEntry` should have a snake case name [INFO] [stdout] --> src/lib.rs:53:8 [INFO] [stdout] | [INFO] [stdout] 53 | fn updateEntry(&self, toUpdate: &ReadingEntry); [INFO] [stdout] | ^^^^^^^^^^^ help: convert the identifier to snake case: `update_entry` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `toUpdate` should have a snake case name [INFO] [stdout] --> src/lib.rs:53:27 [INFO] [stdout] | [INFO] [stdout] 53 | fn updateEntry(&self, toUpdate: &ReadingEntry); [INFO] [stdout] | ^^^^^^^^ help: convert the identifier to snake case: `to_update` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait method `addEntry` should have a snake case name [INFO] [stdout] --> src/lib.rs:54:8 [INFO] [stdout] | [INFO] [stdout] 54 | fn addEntry(&self, e: &ReadingEntry); [INFO] [stdout] | ^^^^^^^^ help: convert the identifier to snake case: `add_entry` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait method `getAllEntries` should have a snake case name [INFO] [stdout] --> src/lib.rs:55:8 [INFO] [stdout] | [INFO] [stdout] 55 | fn getAllEntries(&self) -> Result>; [INFO] [stdout] | ^^^^^^^^^^^^^ help: convert the identifier to snake case: `get_all_entries` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `entryToDelete` should have a snake case name [INFO] [stdout] --> src/lib.rs:114:13 [INFO] [stdout] | [INFO] [stdout] 114 | let entryToDelete = self.getById(id)?; [INFO] [stdout] | ^^^^^^^^^^^^^ help: convert the identifier to snake case: `entry_to_delete` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `toUpdate` should have a snake case name [INFO] [stdout] --> src/lib.rs:122:27 [INFO] [stdout] | [INFO] [stdout] 122 | fn updateEntry(&self, toUpdate: &ReadingEntry) { [INFO] [stdout] | ^^^^^^^^ help: convert the identifier to snake case: `to_update` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `insertString` should have a snake case name [INFO] [stdout] --> src/lib.rs:123:13 [INFO] [stdout] | [INFO] [stdout] 123 | ... let insertString = "update reading_entries set title = ?1, author = ?2, genre = ?3, format = ?4, tags = ?5, status = ?6 where id = ... [INFO] [stdout] | ^^^^^^^^^^^^ help: convert the identifier to snake case: `insert_string` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/lib.rs:124:9 [INFO] [stdout] | [INFO] [stdout] 124 | / ... self.conn.execute(insertString, [INFO] [stdout] 125 | | ... &[&toUpdate.title, &toUpdate.author, &toUpdate.genre, &formatEnumToString(&toUpdate.format), &toUpdate.tags.join(" "), &toUpdate.status, &toUpdate.id.to_string()]); [INFO] [stdout] | |____________________________________________________________________________________________________________________________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `insertString` should have a snake case name [INFO] [stdout] --> src/lib.rs:129:13 [INFO] [stdout] | [INFO] [stdout] 129 | let insertString = "insert into reading_entries (title, author, genre, format, tags, status) values (?1, ?2, ?3, ?4, ?5, ?6);"; [INFO] [stdout] | ^^^^^^^^^^^^ help: convert the identifier to snake case: `insert_string` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/lib.rs:130:9 [INFO] [stdout] | [INFO] [stdout] 130 | ... self.conn.execute(insertString, &[&re.title, &re.author, &re.genre, &formatEnumToString(&re.format), &re.tags.join(" "), &re.status]); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `entryList` should have a snake case name [INFO] [stdout] --> src/lib.rs:158:17 [INFO] [stdout] | [INFO] [stdout] 158 | let mut entryList = Vec::new(); [INFO] [stdout] | ^^^^^^^^^ help: convert the identifier to snake case: `entry_list` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 18 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `super::CONFIG` [INFO] [stdout] --> src/querylanguage.rs:1:5 [INFO] [stdout] | [INFO] [stdout] 1 | use super::CONFIG; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::result` [INFO] [stdout] --> src/querylanguage.rs:4:5 [INFO] [stdout] | [INFO] [stdout] 4 | use std::result; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Connection` [INFO] [stdout] --> src/main.rs:10:16 [INFO] [stdout] | [INFO] [stdout] 10 | use rusqlite::{Connection, Result}; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/main.rs:206:12 [INFO] [stdout] | [INFO] [stdout] 206 | if (dir.len() == 1) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning[E0170]: pattern binding `Equal` is named the same as one of the variants of the type `CompType` [INFO] [stdout] --> src/querylanguage.rs:26:9 [INFO] [stdout] | [INFO] [stdout] 26 | Equal => { [INFO] [stdout] | ^^^^^ help: to match on the variant, qualify the path: `CompType::Equal` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(bindings_with_variant_name)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `splits` [INFO] [stdout] --> src/main.rs:101:9 [INFO] [stdout] | [INFO] [stdout] 101 | let splits = tags.split(" "); [INFO] [stdout] | ^^^^^^ help: if this is intentional, prefix it with an underscore: `_splits` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `Equal` [INFO] [stdout] --> src/querylanguage.rs:26:9 [INFO] [stdout] | [INFO] [stdout] 26 | Equal => { [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_Equal` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/querylanguage.rs:129:9 [INFO] [stdout] | [INFO] [stdout] 129 | let mut comp: Comparison = Comparison::default(); [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct is never constructed: `Table` [INFO] [stdout] --> src/querylanguage.rs:76:12 [INFO] [stdout] | [INFO] [stdout] 76 | pub struct Table { [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant is never constructed: `Col` [INFO] [stdout] --> src/querylanguage.rs:91:5 [INFO] [stdout] | [INFO] [stdout] 91 | Col, [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant is never constructed: `Contains` [INFO] [stdout] --> src/querylanguage.rs:244:5 [INFO] [stdout] | [INFO] [stdout] 244 | Contains, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant is never constructed: `Or` [INFO] [stdout] --> src/querylanguage.rs:251:5 [INFO] [stdout] | [INFO] [stdout] 251 | Or [INFO] [stdout] | ^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated function is never used: `new` [INFO] [stdout] --> src/querylanguage.rs:274:8 [INFO] [stdout] | [INFO] [stdout] 274 | fn new(left: Comparison, right: Option, t: ModType) -> Modifier { [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function is never used: `info` [INFO] [stdout] --> src/log.rs:3:8 [INFO] [stdout] | [INFO] [stdout] 3 | pub fn info(msg: &String) { [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: panic message is not a string literal [INFO] [stdout] --> src/querylanguage.rs:176:28 [INFO] [stdout] | [INFO] [stdout] 176 | panic!(String::from("Expected a col ident")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_fmt_panic)]` on by default [INFO] [stdout] = note: this is no longer accepted in Rust 2021 [INFO] [stdout] help: add a "{}" format string to Display the message [INFO] [stdout] | [INFO] [stdout] 176 | panic!("{}", String::from("Expected a col ident")); [INFO] [stdout] | ^^^^^ [INFO] [stdout] help: or use std::panic::panic_any instead [INFO] [stdout] | [INFO] [stdout] 176 | std::panic::panic_any(String::from("Expected a col ident")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: panic message is not a string literal [INFO] [stdout] --> src/querylanguage.rs:231:16 [INFO] [stdout] | [INFO] [stdout] 231 | panic!(String::from("Wrong state")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this is no longer accepted in Rust 2021 [INFO] [stdout] help: add a "{}" format string to Display the message [INFO] [stdout] | [INFO] [stdout] 231 | panic!("{}", String::from("Wrong state")); [INFO] [stdout] | ^^^^^ [INFO] [stdout] help: or use std::panic::panic_any instead [INFO] [stdout] | [INFO] [stdout] 231 | std::panic::panic_any(String::from("Wrong state")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `withId` should have a snake case name [INFO] [stdout] --> src/main.rs:37:5 [INFO] [stdout] | [INFO] [stdout] 37 | withId: bool, [INFO] [stdout] | ^^^^^^ help: convert the identifier to snake case: `with_id` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_snake_case)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `promptForUpdate` should have a snake case name [INFO] [stdout] --> src/main.rs:70:4 [INFO] [stdout] | [INFO] [stdout] 70 | fn promptForUpdate(toUpdate: &ReadingEntry) -> ReadingEntry { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: convert the identifier to snake case: `prompt_for_update` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `toUpdate` should have a snake case name [INFO] [stdout] --> src/main.rs:70:20 [INFO] [stdout] | [INFO] [stdout] 70 | fn promptForUpdate(toUpdate: &ReadingEntry) -> ReadingEntry { [INFO] [stdout] | ^^^^^^^^ help: convert the identifier to snake case: `to_update` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `splittedTags` should have a snake case name [INFO] [stdout] --> src/main.rs:78:9 [INFO] [stdout] | [INFO] [stdout] 78 | let splittedTags = tags.split(" ").map(|x| String::from(x)).collect(); [INFO] [stdout] | ^^^^^^^^^^^^ help: convert the identifier to snake case: `splitted_tags` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `splittedTags` should have a snake case name [INFO] [stdout] --> src/main.rs:103:9 [INFO] [stdout] | [INFO] [stdout] 103 | let splittedTags = tags.split(" ").map(|x| String::from(x)).collect(); [INFO] [stdout] | ^^^^^^^^^^^^ help: convert the identifier to snake case: `splitted_tags` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `withId` should have a snake case name [INFO] [stdout] --> src/main.rs:126:45 [INFO] [stdout] | [INFO] [stdout] 126 | fn print_table(entries: &Vec, withId: bool) -> Table { [INFO] [stdout] | ^^^^^^ help: convert the identifier to snake case: `with_id` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `formatString` should have a snake case name [INFO] [stdout] --> src/main.rs:139:13 [INFO] [stdout] | [INFO] [stdout] 139 | let formatString = formatEnumToString(&e.format); [INFO] [stdout] | ^^^^^^^^^^^^ help: convert the identifier to snake case: `format_string` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `idString` should have a snake case name [INFO] [stdout] --> src/main.rs:149:13 [INFO] [stdout] | [INFO] [stdout] 149 | let idString = &e.id.to_string(); [INFO] [stdout] | ^^^^^^^^ help: convert the identifier to snake case: `id_string` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `createHeaderVec` should have a snake case name [INFO] [stdout] --> src/main.rs:160:4 [INFO] [stdout] | [INFO] [stdout] 160 | fn createHeaderVec() -> Vec { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: convert the identifier to snake case: `create_header_vec` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `createTableRowFromReadingEntry` should have a snake case name [INFO] [stdout] --> src/main.rs:170:4 [INFO] [stdout] | [INFO] [stdout] 170 | fn createTableRowFromReadingEntry(re: &ReadingEntry) -> TableRow { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: convert the identifier to snake case: `create_table_row_from_reading_entry` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `initConfig` should have a snake case name [INFO] [stdout] --> src/main.rs:181:4 [INFO] [stdout] | [INFO] [stdout] 181 | fn initConfig() -> Config { [INFO] [stdout] | ^^^^^^^^^^ help: convert the identifier to snake case: `init_config` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `expandTilde` should have a snake case name [INFO] [stdout] --> src/main.rs:199:4 [INFO] [stdout] | [INFO] [stdout] 199 | fn expandTilde(dir: &String) -> String { [INFO] [stdout] | ^^^^^^^^^^^ help: convert the identifier to snake case: `expand_tilde` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `createAppFolderIfNeccessary` should have a snake case name [INFO] [stdout] --> src/main.rs:217:4 [INFO] [stdout] | [INFO] [stdout] 217 | fn createAppFolderIfNeccessary() -> std::io::Result<()>{ [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: convert the identifier to snake case: `create_app_folder_if_neccessary` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/main.rs:231:5 [INFO] [stdout] | [INFO] [stdout] 231 | createAppFolderIfNeccessary(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `toUpdate` should have a snake case name [INFO] [stdout] --> src/main.rs:241:17 [INFO] [stdout] | [INFO] [stdout] 241 | let toUpdate = backend.getById(id)?; [INFO] [stdout] | ^^^^^^^^ help: convert the identifier to snake case: `to_update` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/main.rs:246:13 [INFO] [stdout] | [INFO] [stdout] 246 | backend.deleteById(id); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `filteredEntries` should have a snake case name [INFO] [stdout] --> src/main.rs:253:21 [INFO] [stdout] | [INFO] [stdout] 253 | let filteredEntries = entries.into_iter() [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: convert the identifier to snake case: `filtered_entries` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `Equal` should have a snake case name [INFO] [stdout] --> src/querylanguage.rs:26:9 [INFO] [stdout] | [INFO] [stdout] 26 | Equal => { [INFO] [stdout] | ^^^^^ help: convert the identifier to snake case: `equal` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `currentModifier` should have a snake case name [INFO] [stdout] --> src/querylanguage.rs:136:13 [INFO] [stdout] | [INFO] [stdout] 136 | let mut currentModifier: &mut Modifier = &mut root; [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: convert the identifier to snake case: `current_modifier` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `withId` should have a snake case name [INFO] [stdout] --> src/config.rs:4:9 [INFO] [stdout] | [INFO] [stdout] 4 | pub withId: bool, [INFO] [stdout] | ^^^^^^ help: convert the identifier to snake case: `with_id` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 36 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] For more information about this error, try `rustc --explain E0170`. [INFO] [stdout] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 46.83s [INFO] running `Command { std: "docker" "inspect" "cd7b96c308bc2c9c3295bcc567674208839d2951061b41ed1baa897bdbf42515", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "cd7b96c308bc2c9c3295bcc567674208839d2951061b41ed1baa897bdbf42515", kill_on_drop: false }` [INFO] [stdout] cd7b96c308bc2c9c3295bcc567674208839d2951061b41ed1baa897bdbf42515 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:20528e8c29e4536546f0102ce88568b16ea7538393a33fcca951030f7af10457" "/opt/rustwide/cargo-home/bin/cargo" "+ce59db7a1b1b012fb2793c4641c1bdecad7a128b" "test" "--frozen" "--no-run" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 1482fa2454b53ae1dc2095819e5e4b0752bad24721e3e2b9373200aad2751f25 [INFO] [stderr] WARNING: Your kernel does not support swap limit capabilities or the cgroup is not mounted. Memory limited without swap. [INFO] running `Command { std: "docker" "start" "-a" "1482fa2454b53ae1dc2095819e5e4b0752bad24721e3e2b9373200aad2751f25", kill_on_drop: false }` [INFO] [stdout] warning: unused import: `MappedRows` [INFO] [stdout] --> src/lib.rs:2:27 [INFO] [stdout] | [INFO] [stdout] 2 | use rusqlite::{NO_PARAMS, MappedRows, types::FromSql, types::FromSqlResult, types::ValueRef}; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Compiling readinglist v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused variable: `s` [INFO] [stdout] --> src/lib.rs:24:16 [INFO] [stdout] | [INFO] [stdout] 24 | Ok(s) => { [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_s` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `stringToFormatEnum` should have a snake case name [INFO] [stdout] --> src/lib.rs:32:8 [INFO] [stdout] | [INFO] [stdout] 32 | pub fn stringToFormatEnum(toConvert: &str) -> Format { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: convert the identifier to snake case: `string_to_format_enum` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_snake_case)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `toConvert` should have a snake case name [INFO] [stdout] --> src/lib.rs:32:27 [INFO] [stdout] | [INFO] [stdout] 32 | pub fn stringToFormatEnum(toConvert: &str) -> Format { [INFO] [stdout] | ^^^^^^^^^ help: convert the identifier to snake case: `to_convert` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `formatEnumToString` should have a snake case name [INFO] [stdout] --> src/lib.rs:43:8 [INFO] [stdout] | [INFO] [stdout] 43 | pub fn formatEnumToString(f: &Format) -> String { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: convert the identifier to snake case: `format_enum_to_string` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait method `getById` should have a snake case name [INFO] [stdout] --> src/lib.rs:51:8 [INFO] [stdout] | [INFO] [stdout] 51 | fn getById(&self, id: i64) -> Result; [INFO] [stdout] | ^^^^^^^ help: convert the identifier to snake case: `get_by_id` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait method `deleteById` should have a snake case name [INFO] [stdout] --> src/lib.rs:52:8 [INFO] [stdout] | [INFO] [stdout] 52 | fn deleteById(&self, id: i64) -> Result; [INFO] [stdout] | ^^^^^^^^^^ help: convert the identifier to snake case: `delete_by_id` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait method `updateEntry` should have a snake case name [INFO] [stdout] --> src/lib.rs:53:8 [INFO] [stdout] | [INFO] [stdout] 53 | fn updateEntry(&self, toUpdate: &ReadingEntry); [INFO] [stdout] | ^^^^^^^^^^^ help: convert the identifier to snake case: `update_entry` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `toUpdate` should have a snake case name [INFO] [stdout] --> src/lib.rs:53:27 [INFO] [stdout] | [INFO] [stdout] 53 | fn updateEntry(&self, toUpdate: &ReadingEntry); [INFO] [stdout] | ^^^^^^^^ help: convert the identifier to snake case: `to_update` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait method `addEntry` should have a snake case name [INFO] [stdout] --> src/lib.rs:54:8 [INFO] [stdout] | [INFO] [stdout] 54 | fn addEntry(&self, e: &ReadingEntry); [INFO] [stdout] | ^^^^^^^^ help: convert the identifier to snake case: `add_entry` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait method `getAllEntries` should have a snake case name [INFO] [stdout] --> src/lib.rs:55:8 [INFO] [stdout] | [INFO] [stdout] 55 | fn getAllEntries(&self) -> Result>; [INFO] [stdout] | ^^^^^^^^^^^^^ help: convert the identifier to snake case: `get_all_entries` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `entryToDelete` should have a snake case name [INFO] [stdout] --> src/lib.rs:114:13 [INFO] [stdout] | [INFO] [stdout] 114 | let entryToDelete = self.getById(id)?; [INFO] [stdout] | ^^^^^^^^^^^^^ help: convert the identifier to snake case: `entry_to_delete` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `toUpdate` should have a snake case name [INFO] [stdout] --> src/lib.rs:122:27 [INFO] [stdout] | [INFO] [stdout] 122 | fn updateEntry(&self, toUpdate: &ReadingEntry) { [INFO] [stdout] | ^^^^^^^^ help: convert the identifier to snake case: `to_update` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `insertString` should have a snake case name [INFO] [stdout] --> src/lib.rs:123:13 [INFO] [stdout] | [INFO] [stdout] 123 | ... let insertString = "update reading_entries set title = ?1, author = ?2, genre = ?3, format = ?4, tags = ?5, status = ?6 where id = ... [INFO] [stdout] | ^^^^^^^^^^^^ help: convert the identifier to snake case: `insert_string` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/lib.rs:124:9 [INFO] [stdout] | [INFO] [stdout] 124 | / ... self.conn.execute(insertString, [INFO] [stdout] 125 | | ... &[&toUpdate.title, &toUpdate.author, &toUpdate.genre, &formatEnumToString(&toUpdate.format), &toUpdate.tags.join(" "), &toUpdate.status, &toUpdate.id.to_string()]); [INFO] [stdout] | |____________________________________________________________________________________________________________________________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `insertString` should have a snake case name [INFO] [stdout] --> src/lib.rs:129:13 [INFO] [stdout] | [INFO] [stdout] 129 | let insertString = "insert into reading_entries (title, author, genre, format, tags, status) values (?1, ?2, ?3, ?4, ?5, ?6);"; [INFO] [stdout] | ^^^^^^^^^^^^ help: convert the identifier to snake case: `insert_string` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/lib.rs:130:9 [INFO] [stdout] | [INFO] [stdout] 130 | ... self.conn.execute(insertString, &[&re.title, &re.author, &re.genre, &formatEnumToString(&re.format), &re.tags.join(" "), &re.status]); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `entryList` should have a snake case name [INFO] [stdout] --> src/lib.rs:158:17 [INFO] [stdout] | [INFO] [stdout] 158 | let mut entryList = Vec::new(); [INFO] [stdout] | ^^^^^^^^^ help: convert the identifier to snake case: `entry_list` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 18 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `MappedRows` [INFO] [stdout] --> src/lib.rs:2:27 [INFO] [stdout] | [INFO] [stdout] 2 | use rusqlite::{NO_PARAMS, MappedRows, types::FromSql, types::FromSqlResult, types::ValueRef}; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `s` [INFO] [stdout] --> src/lib.rs:24:16 [INFO] [stdout] | [INFO] [stdout] 24 | Ok(s) => { [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_s` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `stringToFormatEnum` should have a snake case name [INFO] [stdout] --> src/lib.rs:32:8 [INFO] [stdout] | [INFO] [stdout] 32 | pub fn stringToFormatEnum(toConvert: &str) -> Format { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: convert the identifier to snake case: `string_to_format_enum` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_snake_case)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `toConvert` should have a snake case name [INFO] [stdout] --> src/lib.rs:32:27 [INFO] [stdout] | [INFO] [stdout] 32 | pub fn stringToFormatEnum(toConvert: &str) -> Format { [INFO] [stdout] | ^^^^^^^^^ help: convert the identifier to snake case: `to_convert` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `formatEnumToString` should have a snake case name [INFO] [stdout] --> src/lib.rs:43:8 [INFO] [stdout] | [INFO] [stdout] 43 | pub fn formatEnumToString(f: &Format) -> String { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: convert the identifier to snake case: `format_enum_to_string` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait method `getById` should have a snake case name [INFO] [stdout] --> src/lib.rs:51:8 [INFO] [stdout] | [INFO] [stdout] 51 | fn getById(&self, id: i64) -> Result; [INFO] [stdout] | ^^^^^^^ help: convert the identifier to snake case: `get_by_id` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait method `deleteById` should have a snake case name [INFO] [stdout] --> src/lib.rs:52:8 [INFO] [stdout] | [INFO] [stdout] 52 | fn deleteById(&self, id: i64) -> Result; [INFO] [stdout] | ^^^^^^^^^^ help: convert the identifier to snake case: `delete_by_id` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait method `updateEntry` should have a snake case name [INFO] [stdout] --> src/lib.rs:53:8 [INFO] [stdout] | [INFO] [stdout] 53 | fn updateEntry(&self, toUpdate: &ReadingEntry); [INFO] [stdout] | ^^^^^^^^^^^ help: convert the identifier to snake case: `update_entry` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `toUpdate` should have a snake case name [INFO] [stdout] --> src/lib.rs:53:27 [INFO] [stdout] | [INFO] [stdout] 53 | fn updateEntry(&self, toUpdate: &ReadingEntry); [INFO] [stdout] | ^^^^^^^^ help: convert the identifier to snake case: `to_update` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait method `addEntry` should have a snake case name [INFO] [stdout] --> src/lib.rs:54:8 [INFO] [stdout] | [INFO] [stdout] 54 | fn addEntry(&self, e: &ReadingEntry); [INFO] [stdout] | ^^^^^^^^ help: convert the identifier to snake case: `add_entry` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait method `getAllEntries` should have a snake case name [INFO] [stdout] --> src/lib.rs:55:8 [INFO] [stdout] | [INFO] [stdout] 55 | fn getAllEntries(&self) -> Result>; [INFO] [stdout] | ^^^^^^^^^^^^^ help: convert the identifier to snake case: `get_all_entries` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `entryToDelete` should have a snake case name [INFO] [stdout] --> src/lib.rs:114:13 [INFO] [stdout] | [INFO] [stdout] 114 | let entryToDelete = self.getById(id)?; [INFO] [stdout] | ^^^^^^^^^^^^^ help: convert the identifier to snake case: `entry_to_delete` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `toUpdate` should have a snake case name [INFO] [stdout] --> src/lib.rs:122:27 [INFO] [stdout] | [INFO] [stdout] 122 | fn updateEntry(&self, toUpdate: &ReadingEntry) { [INFO] [stdout] | ^^^^^^^^ help: convert the identifier to snake case: `to_update` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `insertString` should have a snake case name [INFO] [stdout] --> src/lib.rs:123:13 [INFO] [stdout] | [INFO] [stdout] 123 | ... let insertString = "update reading_entries set title = ?1, author = ?2, genre = ?3, format = ?4, tags = ?5, status = ?6 where id = ... [INFO] [stdout] | ^^^^^^^^^^^^ help: convert the identifier to snake case: `insert_string` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/lib.rs:124:9 [INFO] [stdout] | [INFO] [stdout] 124 | / ... self.conn.execute(insertString, [INFO] [stdout] 125 | | ... &[&toUpdate.title, &toUpdate.author, &toUpdate.genre, &formatEnumToString(&toUpdate.format), &toUpdate.tags.join(" "), &toUpdate.status, &toUpdate.id.to_string()]); [INFO] [stdout] | |____________________________________________________________________________________________________________________________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `insertString` should have a snake case name [INFO] [stdout] --> src/lib.rs:129:13 [INFO] [stdout] | [INFO] [stdout] 129 | let insertString = "insert into reading_entries (title, author, genre, format, tags, status) values (?1, ?2, ?3, ?4, ?5, ?6);"; [INFO] [stdout] | ^^^^^^^^^^^^ help: convert the identifier to snake case: `insert_string` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/lib.rs:130:9 [INFO] [stdout] | [INFO] [stdout] 130 | ... self.conn.execute(insertString, &[&re.title, &re.author, &re.genre, &formatEnumToString(&re.format), &re.tags.join(" "), &re.status]); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `entryList` should have a snake case name [INFO] [stdout] --> src/lib.rs:158:17 [INFO] [stdout] | [INFO] [stdout] 158 | let mut entryList = Vec::new(); [INFO] [stdout] | ^^^^^^^^^ help: convert the identifier to snake case: `entry_list` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `super::CONFIG` [INFO] [stdout] --> src/querylanguage.rs:1:5 [INFO] [stdout] | [INFO] [stdout] 1 | use super::CONFIG; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::result` [INFO] [stdout] --> src/querylanguage.rs:4:5 [INFO] [stdout] | [INFO] [stdout] 4 | use std::result; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Connection` [INFO] [stdout] --> src/main.rs:10:16 [INFO] [stdout] | [INFO] [stdout] 10 | use rusqlite::{Connection, Result}; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/main.rs:206:12 [INFO] [stdout] | [INFO] [stdout] 206 | if (dir.len() == 1) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning[E0170]: pattern binding `Equal` is named the same as one of the variants of the type `CompType` [INFO] [stdout] --> src/querylanguage.rs:26:9 [INFO] [stdout] | [INFO] [stdout] 26 | Equal => { [INFO] [stdout] | ^^^^^ help: to match on the variant, qualify the path: `CompType::Equal` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(bindings_with_variant_name)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `splits` [INFO] [stdout] --> src/main.rs:101:9 [INFO] [stdout] | [INFO] [stdout] 101 | let splits = tags.split(" "); [INFO] [stdout] | ^^^^^^ help: if this is intentional, prefix it with an underscore: `_splits` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `Equal` [INFO] [stdout] --> src/querylanguage.rs:26:9 [INFO] [stdout] | [INFO] [stdout] 26 | Equal => { [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_Equal` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/querylanguage.rs:129:9 [INFO] [stdout] | [INFO] [stdout] 129 | let mut comp: Comparison = Comparison::default(); [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct is never constructed: `Table` [INFO] [stdout] --> src/querylanguage.rs:76:12 [INFO] [stdout] | [INFO] [stdout] 76 | pub struct Table { [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant is never constructed: `Col` [INFO] [stdout] --> src/querylanguage.rs:91:5 [INFO] [stdout] | [INFO] [stdout] 91 | Col, [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant is never constructed: `Contains` [INFO] [stdout] --> src/querylanguage.rs:244:5 [INFO] [stdout] | [INFO] [stdout] 244 | Contains, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant is never constructed: `Or` [INFO] [stdout] --> src/querylanguage.rs:251:5 [INFO] [stdout] | [INFO] [stdout] 251 | Or [INFO] [stdout] | ^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated function is never used: `new` [INFO] [stdout] --> src/querylanguage.rs:274:8 [INFO] [stdout] | [INFO] [stdout] 274 | fn new(left: Comparison, right: Option, t: ModType) -> Modifier { [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function is never used: `info` [INFO] [stdout] --> src/log.rs:3:8 [INFO] [stdout] | [INFO] [stdout] 3 | pub fn info(msg: &String) { [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: panic message is not a string literal [INFO] [stdout] --> src/querylanguage.rs:176:28 [INFO] [stdout] | [INFO] [stdout] 176 | panic!(String::from("Expected a col ident")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_fmt_panic)]` on by default [INFO] [stdout] = note: this is no longer accepted in Rust 2021 [INFO] [stdout] help: add a "{}" format string to Display the message [INFO] [stdout] | [INFO] [stdout] 176 | panic!("{}", String::from("Expected a col ident")); [INFO] [stdout] | ^^^^^ [INFO] [stdout] help: or use std::panic::panic_any instead [INFO] [stdout] | [INFO] [stdout] 176 | std::panic::panic_any(String::from("Expected a col ident")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: panic message is not a string literal [INFO] [stdout] --> src/querylanguage.rs:231:16 [INFO] [stdout] | [INFO] [stdout] 231 | panic!(String::from("Wrong state")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this is no longer accepted in Rust 2021 [INFO] [stdout] help: add a "{}" format string to Display the message [INFO] [stdout] | [INFO] [stdout] 231 | panic!("{}", String::from("Wrong state")); [INFO] [stdout] | ^^^^^ [INFO] [stdout] help: or use std::panic::panic_any instead [INFO] [stdout] | [INFO] [stdout] 231 | std::panic::panic_any(String::from("Wrong state")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `withId` should have a snake case name [INFO] [stdout] --> src/main.rs:37:5 [INFO] [stdout] | [INFO] [stdout] 37 | withId: bool, [INFO] [stdout] | ^^^^^^ help: convert the identifier to snake case: `with_id` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_snake_case)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `promptForUpdate` should have a snake case name [INFO] [stdout] --> src/main.rs:70:4 [INFO] [stdout] | [INFO] [stdout] 70 | fn promptForUpdate(toUpdate: &ReadingEntry) -> ReadingEntry { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: convert the identifier to snake case: `prompt_for_update` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `toUpdate` should have a snake case name [INFO] [stdout] --> src/main.rs:70:20 [INFO] [stdout] | [INFO] [stdout] 70 | fn promptForUpdate(toUpdate: &ReadingEntry) -> ReadingEntry { [INFO] [stdout] | ^^^^^^^^ help: convert the identifier to snake case: `to_update` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `splittedTags` should have a snake case name [INFO] [stdout] --> src/main.rs:78:9 [INFO] [stdout] | [INFO] [stdout] 78 | let splittedTags = tags.split(" ").map(|x| String::from(x)).collect(); [INFO] [stdout] | ^^^^^^^^^^^^ help: convert the identifier to snake case: `splitted_tags` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `splittedTags` should have a snake case name [INFO] [stdout] --> src/main.rs:103:9 [INFO] [stdout] | [INFO] [stdout] 103 | let splittedTags = tags.split(" ").map(|x| String::from(x)).collect(); [INFO] [stdout] | ^^^^^^^^^^^^ help: convert the identifier to snake case: `splitted_tags` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `withId` should have a snake case name [INFO] [stdout] --> src/main.rs:126:45 [INFO] [stdout] | [INFO] [stdout] 126 | fn print_table(entries: &Vec, withId: bool) -> Table { [INFO] [stdout] | ^^^^^^ help: convert the identifier to snake case: `with_id` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `formatString` should have a snake case name [INFO] [stdout] --> src/main.rs:139:13 [INFO] [stdout] | [INFO] [stdout] 139 | let formatString = formatEnumToString(&e.format); [INFO] [stdout] | ^^^^^^^^^^^^ help: convert the identifier to snake case: `format_string` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `idString` should have a snake case name [INFO] [stdout] --> src/main.rs:149:13 [INFO] [stdout] | [INFO] [stdout] 149 | let idString = &e.id.to_string(); [INFO] [stdout] | ^^^^^^^^ help: convert the identifier to snake case: `id_string` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `createHeaderVec` should have a snake case name [INFO] [stdout] --> src/main.rs:160:4 [INFO] [stdout] | [INFO] [stdout] 160 | fn createHeaderVec() -> Vec { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: convert the identifier to snake case: `create_header_vec` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `createTableRowFromReadingEntry` should have a snake case name [INFO] [stdout] --> src/main.rs:170:4 [INFO] [stdout] | [INFO] [stdout] 170 | fn createTableRowFromReadingEntry(re: &ReadingEntry) -> TableRow { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: convert the identifier to snake case: `create_table_row_from_reading_entry` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `initConfig` should have a snake case name [INFO] [stdout] --> src/main.rs:181:4 [INFO] [stdout] | [INFO] [stdout] 181 | fn initConfig() -> Config { [INFO] [stdout] | ^^^^^^^^^^ help: convert the identifier to snake case: `init_config` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `expandTilde` should have a snake case name [INFO] [stdout] --> src/main.rs:199:4 [INFO] [stdout] | [INFO] [stdout] 199 | fn expandTilde(dir: &String) -> String { [INFO] [stdout] | ^^^^^^^^^^^ help: convert the identifier to snake case: `expand_tilde` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `createAppFolderIfNeccessary` should have a snake case name [INFO] [stdout] --> src/main.rs:217:4 [INFO] [stdout] | [INFO] [stdout] 217 | fn createAppFolderIfNeccessary() -> std::io::Result<()>{ [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: convert the identifier to snake case: `create_app_folder_if_neccessary` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/main.rs:231:5 [INFO] [stdout] | [INFO] [stdout] 231 | createAppFolderIfNeccessary(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `toUpdate` should have a snake case name [INFO] [stdout] --> src/main.rs:241:17 [INFO] [stdout] | [INFO] [stdout] 241 | let toUpdate = backend.getById(id)?; [INFO] [stdout] | ^^^^^^^^ help: convert the identifier to snake case: `to_update` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/main.rs:246:13 [INFO] [stdout] | [INFO] [stdout] 246 | backend.deleteById(id); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `filteredEntries` should have a snake case name [INFO] [stdout] --> src/main.rs:253:21 [INFO] [stdout] | [INFO] [stdout] 253 | let filteredEntries = entries.into_iter() [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: convert the identifier to snake case: `filtered_entries` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `Equal` should have a snake case name [INFO] [stdout] --> src/querylanguage.rs:26:9 [INFO] [stdout] | [INFO] [stdout] 26 | Equal => { [INFO] [stdout] | ^^^^^ help: convert the identifier to snake case: `equal` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `currentModifier` should have a snake case name [INFO] [stdout] --> src/querylanguage.rs:136:13 [INFO] [stdout] | [INFO] [stdout] 136 | let mut currentModifier: &mut Modifier = &mut root; [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: convert the identifier to snake case: `current_modifier` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `withId` should have a snake case name [INFO] [stdout] --> src/config.rs:4:9 [INFO] [stdout] | [INFO] [stdout] 4 | pub withId: bool, [INFO] [stdout] | ^^^^^^ help: convert the identifier to snake case: `with_id` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 18 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 36 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] For more information about this error, try `rustc --explain E0170`. [INFO] [stdout] [INFO] [stderr] Finished test [unoptimized + debuginfo] target(s) in 2.83s [INFO] running `Command { std: "docker" "inspect" "1482fa2454b53ae1dc2095819e5e4b0752bad24721e3e2b9373200aad2751f25", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "1482fa2454b53ae1dc2095819e5e4b0752bad24721e3e2b9373200aad2751f25", kill_on_drop: false }` [INFO] [stdout] 1482fa2454b53ae1dc2095819e5e4b0752bad24721e3e2b9373200aad2751f25 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:20528e8c29e4536546f0102ce88568b16ea7538393a33fcca951030f7af10457" "/opt/rustwide/cargo-home/bin/cargo" "+ce59db7a1b1b012fb2793c4641c1bdecad7a128b" "test" "--frozen", kill_on_drop: false }` [INFO] [stdout] 8ca3fb8cfbecd3b06fe1546f668cf8200086df89d28b6e7c0afd3b7ef19db154 [INFO] [stderr] WARNING: Your kernel does not support swap limit capabilities or the cgroup is not mounted. Memory limited without swap. [INFO] running `Command { std: "docker" "start" "-a" "8ca3fb8cfbecd3b06fe1546f668cf8200086df89d28b6e7c0afd3b7ef19db154", kill_on_drop: false }` [INFO] [stdout] [INFO] [stderr] warning: unused import: `MappedRows` [INFO] [stdout] running 0 tests [INFO] [stderr] --> src/lib.rs:2:27 [INFO] [stdout] [INFO] [stderr] | [INFO] [stdout] test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s [INFO] [stderr] 2 | use rusqlite::{NO_PARAMS, MappedRows, types::FromSql, types::FromSqlResult, types::ValueRef}; [INFO] [stdout] [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stderr] | [INFO] [stdout] running 4 tests [INFO] [stderr] = note: `#[warn(unused_imports)]` on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `s` [INFO] [stderr] --> src/lib.rs:24:16 [INFO] [stderr] | [INFO] [stderr] 24 | Ok(s) => { [INFO] [stderr] | ^ help: if this is intentional, prefix it with an underscore: `_s` [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(unused_variables)]` on by default [INFO] [stderr] [INFO] [stderr] warning: function `stringToFormatEnum` should have a snake case name [INFO] [stderr] --> src/lib.rs:32:8 [INFO] [stderr] | [INFO] [stderr] 32 | pub fn stringToFormatEnum(toConvert: &str) -> Format { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: convert the identifier to snake case: `string_to_format_enum` [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(non_snake_case)]` on by default [INFO] [stderr] [INFO] [stderr] warning: variable `toConvert` should have a snake case name [INFO] [stderr] --> src/lib.rs:32:27 [INFO] [stderr] | [INFO] [stderr] 32 | pub fn stringToFormatEnum(toConvert: &str) -> Format { [INFO] [stderr] | ^^^^^^^^^ help: convert the identifier to snake case: `to_convert` [INFO] [stderr] [INFO] [stderr] warning: function `formatEnumToString` should have a snake case name [INFO] [stderr] --> src/lib.rs:43:8 [INFO] [stderr] | [INFO] [stderr] 43 | pub fn formatEnumToString(f: &Format) -> String { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: convert the identifier to snake case: `format_enum_to_string` [INFO] [stderr] [INFO] [stderr] warning: trait method `getById` should have a snake case name [INFO] [stderr] --> src/lib.rs:51:8 [INFO] [stderr] | [INFO] [stderr] 51 | fn getById(&self, id: i64) -> Result; [INFO] [stderr] | ^^^^^^^ help: convert the identifier to snake case: `get_by_id` [INFO] [stderr] [INFO] [stderr] warning: trait method `deleteById` should have a snake case name [INFO] [stderr] --> src/lib.rs:52:8 [INFO] [stderr] | [INFO] [stderr] 52 | fn deleteById(&self, id: i64) -> Result; [INFO] [stderr] | ^^^^^^^^^^ help: convert the identifier to snake case: `delete_by_id` [INFO] [stderr] [INFO] [stderr] warning: trait method `updateEntry` should have a snake case name [INFO] [stderr] --> src/lib.rs:53:8 [INFO] [stderr] | [INFO] [stderr] 53 | fn updateEntry(&self, toUpdate: &ReadingEntry); [INFO] [stderr] | ^^^^^^^^^^^ help: convert the identifier to snake case: `update_entry` [INFO] [stderr] [INFO] [stderr] warning: variable `toUpdate` should have a snake case name [INFO] [stderr] --> src/lib.rs:53:27 [INFO] [stderr] | [INFO] [stderr] 53 | fn updateEntry(&self, toUpdate: &ReadingEntry); [INFO] [stderr] | ^^^^^^^^ help: convert the identifier to snake case: `to_update` [INFO] [stderr] [INFO] [stderr] warning: trait method `addEntry` should have a snake case name [INFO] [stderr] --> src/lib.rs:54:8 [INFO] [stderr] | [INFO] [stderr] 54 | fn addEntry(&self, e: &ReadingEntry); [INFO] [stderr] | ^^^^^^^^ help: convert the identifier to snake case: `add_entry` [INFO] [stderr] [INFO] [stderr] warning: trait method `getAllEntries` should have a snake case name [INFO] [stderr] --> src/lib.rs:55:8 [INFO] [stderr] | [INFO] [stderr] 55 | fn getAllEntries(&self) -> Result>; [INFO] [stderr] | ^^^^^^^^^^^^^ help: convert the identifier to snake case: `get_all_entries` [INFO] [stderr] [INFO] [stderr] warning: variable `entryToDelete` should have a snake case name [INFO] [stderr] --> src/lib.rs:114:13 [INFO] [stderr] | [INFO] [stderr] 114 | let entryToDelete = self.getById(id)?; [INFO] [stderr] | ^^^^^^^^^^^^^ help: convert the identifier to snake case: `entry_to_delete` [INFO] [stderr] [INFO] [stderr] warning: variable `toUpdate` should have a snake case name [INFO] [stderr] --> src/lib.rs:122:27 [INFO] [stderr] | [INFO] [stderr] 122 | fn updateEntry(&self, toUpdate: &ReadingEntry) { [INFO] [stderr] | ^^^^^^^^ help: convert the identifier to snake case: `to_update` [INFO] [stderr] [INFO] [stderr] warning: variable `insertString` should have a snake case name [INFO] [stderr] --> src/lib.rs:123:13 [INFO] [stderr] | [INFO] [stderr] 123 | ... let insertString = "update reading_entries set title = ?1, author = ?2, genre = ?3, format = ?4, tags = ?5, status = ?6 where id = ... [INFO] [stderr] | ^^^^^^^^^^^^ help: convert the identifier to snake case: `insert_string` [INFO] [stderr] [INFO] [stderr] warning: unused `Result` that must be used [INFO] [stderr] --> src/lib.rs:124:9 [INFO] [stderr] | [INFO] [stderr] 124 | / ... self.conn.execute(insertString, [INFO] [stderr] 125 | | ... &[&toUpdate.title, &toUpdate.author, &toUpdate.genre, &formatEnumToString(&toUpdate.format), &toUpdate.tags.join(" "), &toUpdate.status, &toUpdate.id.to_string()]); [INFO] [stderr] | |____________________________________________________________________________________________________________________________________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(unused_must_use)]` on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: variable `insertString` should have a snake case name [INFO] [stderr] --> src/lib.rs:129:13 [INFO] [stderr] | [INFO] [stderr] 129 | let insertString = "insert into reading_entries (title, author, genre, format, tags, status) values (?1, ?2, ?3, ?4, ?5, ?6);"; [INFO] [stderr] | ^^^^^^^^^^^^ help: convert the identifier to snake case: `insert_string` [INFO] [stderr] [INFO] [stderr] warning: unused `Result` that must be used [INFO] [stderr] --> src/lib.rs:130:9 [INFO] [stderr] | [INFO] [stderr] 130 | ... self.conn.execute(insertString, &[&re.title, &re.author, &re.genre, &formatEnumToString(&re.format), &re.tags.join(" "), &re.status]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: variable `entryList` should have a snake case name [INFO] [stderr] --> src/lib.rs:158:17 [INFO] [stderr] | [INFO] [stderr] 158 | let mut entryList = Vec::new(); [INFO] [stderr] | ^^^^^^^^^ help: convert the identifier to snake case: `entry_list` [INFO] [stderr] [INFO] [stderr] warning: 18 warnings emitted [INFO] [stderr] [INFO] [stderr] warning: unused import: `MappedRows` [INFO] [stderr] --> src/lib.rs:2:27 [INFO] [stderr] | [INFO] [stderr] 2 | use rusqlite::{NO_PARAMS, MappedRows, types::FromSql, types::FromSqlResult, types::ValueRef}; [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(unused_imports)]` on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `s` [INFO] [stderr] --> src/lib.rs:24:16 [INFO] [stderr] | [INFO] [stderr] 24 | Ok(s) => { [INFO] [stderr] | ^ help: if this is intentional, prefix it with an underscore: `_s` [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(unused_variables)]` on by default [INFO] [stderr] [INFO] [stderr] warning: function `stringToFormatEnum` should have a snake case name [INFO] [stderr] --> src/lib.rs:32:8 [INFO] [stderr] | [INFO] [stderr] 32 | pub fn stringToFormatEnum(toConvert: &str) -> Format { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: convert the identifier to snake case: `string_to_format_enum` [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(non_snake_case)]` on by default [INFO] [stderr] [INFO] [stderr] warning: variable `toConvert` should have a snake case name [INFO] [stderr] --> src/lib.rs:32:27 [INFO] [stderr] | [INFO] [stderr] 32 | pub fn stringToFormatEnum(toConvert: &str) -> Format { [INFO] [stderr] | ^^^^^^^^^ help: convert the identifier to snake case: `to_convert` [INFO] [stderr] [INFO] [stderr] warning: function `formatEnumToString` should have a snake case name [INFO] [stderr] --> src/lib.rs:43:8 [INFO] [stderr] | [INFO] [stderr] 43 | pub fn formatEnumToString(f: &Format) -> String { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: convert the identifier to snake case: `format_enum_to_string` [INFO] [stderr] [INFO] [stderr] warning: trait method `getById` should have a snake case name [INFO] [stderr] --> src/lib.rs:51:8 [INFO] [stderr] | [INFO] [stderr] 51 | fn getById(&self, id: i64) -> Result; [INFO] [stderr] | ^^^^^^^ help: convert the identifier to snake case: `get_by_id` [INFO] [stderr] [INFO] [stderr] warning: trait method `deleteById` should have a snake case name [INFO] [stderr] --> src/lib.rs:52:8 [INFO] [stderr] | [INFO] [stderr] 52 | fn deleteById(&self, id: i64) -> Result; [INFO] [stderr] | ^^^^^^^^^^ help: convert the identifier to snake case: `delete_by_id` [INFO] [stderr] [INFO] [stderr] warning: trait method `updateEntry` should have a snake case name [INFO] [stderr] --> src/lib.rs:53:8 [INFO] [stderr] | [INFO] [stderr] 53 | fn updateEntry(&self, toUpdate: &ReadingEntry); [INFO] [stderr] | ^^^^^^^^^^^ help: convert the identifier to snake case: `update_entry` [INFO] [stderr] [INFO] [stderr] warning: variable `toUpdate` should have a snake case name [INFO] [stderr] --> src/lib.rs:53:27 [INFO] [stderr] | [INFO] [stderr] 53 | fn updateEntry(&self, toUpdate: &ReadingEntry); [INFO] [stderr] | ^^^^^^^^ help: convert the identifier to snake case: `to_update` [INFO] [stderr] [INFO] [stderr] warning: trait method `addEntry` should have a snake case name [INFO] [stderr] --> src/lib.rs:54:8 [INFO] [stderr] | [INFO] [stderr] 54 | fn addEntry(&self, e: &ReadingEntry); [INFO] [stderr] | ^^^^^^^^ help: convert the identifier to snake case: `add_entry` [INFO] [stderr] [INFO] [stderr] warning: trait method `getAllEntries` should have a snake case name [INFO] [stderr] --> src/lib.rs:55:8 [INFO] [stderr] | [INFO] [stderr] 55 | fn getAllEntries(&self) -> Result>; [INFO] [stderr] | ^^^^^^^^^^^^^ help: convert the identifier to snake case: `get_all_entries` [INFO] [stderr] [INFO] [stderr] warning: variable `entryToDelete` should have a snake case name [INFO] [stderr] --> src/lib.rs:114:13 [INFO] [stderr] | [INFO] [stderr] 114 | let entryToDelete = self.getById(id)?; [INFO] [stderr] | ^^^^^^^^^^^^^ help: convert the identifier to snake case: `entry_to_delete` [INFO] [stderr] [INFO] [stderr] warning: variable `toUpdate` should have a snake case name [INFO] [stderr] --> src/lib.rs:122:27 [INFO] [stderr] | [INFO] [stderr] 122 | fn updateEntry(&self, toUpdate: &ReadingEntry) { [INFO] [stderr] | ^^^^^^^^ help: convert the identifier to snake case: `to_update` [INFO] [stderr] [INFO] [stderr] warning: variable `insertString` should have a snake case name [INFO] [stderr] --> src/lib.rs:123:13 [INFO] [stderr] | [INFO] [stderr] 123 | ... let insertString = "update reading_entries set title = ?1, author = ?2, genre = ?3, format = ?4, tags = ?5, status = ?6 where id = ... [INFO] [stderr] | ^^^^^^^^^^^^ help: convert the identifier to snake case: `insert_string` [INFO] [stderr] [INFO] [stderr] warning: unused `Result` that must be used [INFO] [stderr] --> src/lib.rs:124:9 [INFO] [stderr] | [INFO] [stderr] 124 | / ... self.conn.execute(insertString, [INFO] [stderr] 125 | | ... &[&toUpdate.title, &toUpdate.author, &toUpdate.genre, &formatEnumToString(&toUpdate.format), &toUpdate.tags.join(" "), &toUpdate.status, &toUpdate.id.to_string()]); [INFO] [stderr] | |____________________________________________________________________________________________________________________________________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(unused_must_use)]` on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: variable `insertString` should have a snake case name [INFO] [stderr] --> src/lib.rs:129:13 [INFO] [stderr] | [INFO] [stderr] 129 | let insertString = "insert into reading_entries (title, author, genre, format, tags, status) values (?1, ?2, ?3, ?4, ?5, ?6);"; [INFO] [stderr] | ^^^^^^^^^^^^ help: convert the identifier to snake case: `insert_string` [INFO] [stderr] [INFO] [stderr] warning: unused `Result` that must be used [INFO] [stderr] --> src/lib.rs:130:9 [INFO] [stderr] | [INFO] [stderr] 130 | ... self.conn.execute(insertString, &[&re.title, &re.author, &re.genre, &formatEnumToString(&re.format), &re.tags.join(" "), &re.status]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: variable `entryList` should have a snake case name [INFO] [stderr] --> src/lib.rs:158:17 [INFO] [stderr] | [INFO] [stderr] 158 | let mut entryList = Vec::new(); [INFO] [stderr] | ^^^^^^^^^ help: convert the identifier to snake case: `entry_list` [INFO] [stderr] [INFO] [stderr] warning: 18 warnings emitted [INFO] [stderr] [INFO] [stderr] warning: unused import: `super::CONFIG` [INFO] [stderr] --> src/querylanguage.rs:1:5 [INFO] [stderr] | [INFO] [stderr] 1 | use super::CONFIG; [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(unused_imports)]` on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::result` [INFO] [stderr] --> src/querylanguage.rs:4:5 [INFO] [stderr] | [INFO] [stderr] 4 | use std::result; [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `Connection` [INFO] [stderr] --> src/main.rs:10:16 [INFO] [stderr] | [INFO] [stderr] 10 | use rusqlite::{Connection, Result}; [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `if` condition [INFO] [stderr] --> src/main.rs:206:12 [INFO] [stderr] | [INFO] [stderr] 206 | if (dir.len() == 1) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(unused_parens)]` on by default [INFO] [stderr] [INFO] [stderr] warning[E0170]: pattern binding `Equal` is named the same as one of the variants of the type `CompType` [INFO] [stderr] --> src/querylanguage.rs:26:9 [INFO] [stderr] | [INFO] [stderr] 26 | Equal => { [INFO] [stderr] | ^^^^^ help: to match on the variant, qualify the path: `CompType::Equal` [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(bindings_with_variant_name)]` on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `splits` [INFO] [stderr] --> src/main.rs:101:9 [INFO] [stderr] | [INFO] [stderr] 101 | let splits = tags.split(" "); [INFO] [stderr] | ^^^^^^ help: if this is intentional, prefix it with an underscore: `_splits` [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(unused_variables)]` on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `Equal` [INFO] [stderr] --> src/querylanguage.rs:26:9 [INFO] [stderr] | [INFO] [stderr] 26 | Equal => { [INFO] [stderr] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_Equal` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/querylanguage.rs:129:9 [INFO] [stderr] | [INFO] [stderr] 129 | let mut comp: Comparison = Comparison::default(); [INFO] [stderr] | ----^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(unused_mut)]` on by default [INFO] [stderr] [INFO] [stderr] warning: struct is never constructed: `Table` [INFO] [stderr] --> src/querylanguage.rs:76:12 [INFO] [stderr] | [INFO] [stderr] 76 | pub struct Table { [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(dead_code)]` on by default [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Col` [INFO] [stderr] --> src/querylanguage.rs:91:5 [INFO] [stderr] | [INFO] [stderr] 91 | Col, [INFO] [stderr] | ^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Contains` [INFO] [stderr] --> src/querylanguage.rs:244:5 [INFO] [stderr] | [INFO] [stderr] 244 | Contains, [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Or` [INFO] [stderr] --> src/querylanguage.rs:251:5 [INFO] [stderr] | [INFO] [stderr] 251 | Or [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: associated function is never used: `new` [INFO] [stderr] --> src/querylanguage.rs:274:8 [INFO] [stderr] | [INFO] [stderr] 274 | fn new(left: Comparison, right: Option, t: ModType) -> Modifier { [INFO] [stderr] | ^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `info` [INFO] [stderr] --> src/log.rs:3:8 [INFO] [stderr] | [INFO] [stderr] 3 | pub fn info(msg: &String) { [INFO] [stderr] | ^^^^ [INFO] [stderr] [INFO] [stderr] warning: panic message is not a string literal [INFO] [stderr] --> src/querylanguage.rs:176:28 [INFO] [stderr] | [INFO] [stderr] 176 | panic!(String::from("Expected a col ident")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(non_fmt_panic)]` on by default [INFO] [stderr] = note: this is no longer accepted in Rust 2021 [INFO] [stderr] help: add a "{}" format string to Display the message [INFO] [stderr] | [INFO] [stderr] 176 | panic!("{}", String::from("Expected a col ident")); [INFO] [stderr] | ^^^^^ [INFO] [stderr] help: or use std::panic::panic_any instead [INFO] [stderr] | [INFO] [stderr] 176 | std::panic::panic_any(String::from("Expected a col ident")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: panic message is not a string literal [INFO] [stderr] --> src/querylanguage.rs:231:16 [INFO] [stderr] | [INFO] [stderr] 231 | panic!(String::from("Wrong state")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this is no longer accepted in Rust 2021 [INFO] [stderr] help: add a "{}" format string to Display the message [INFO] [stderr] | [INFO] [stderr] 231 | panic!("{}", String::from("Wrong state")); [INFO] [stderr] | ^^^^^ [INFO] [stderr] help: or use std::panic::panic_any instead [INFO] [stderr] | [INFO] [stderr] 231 | std::panic::panic_any(String::from("Wrong state")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: structure field `withId` should have a snake case name [INFO] [stderr] --> src/main.rs:37:5 [INFO] [stderr] | [INFO] [stderr] 37 | withId: bool, [INFO] [stderr] | ^^^^^^ help: convert the identifier to snake case: `with_id` [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(non_snake_case)]` on by default [INFO] [stderr] [INFO] [stderr] warning: function `promptForUpdate` should have a snake case name [INFO] [stderr] --> src/main.rs:70:4 [INFO] [stderr] | [INFO] [stderr] 70 | fn promptForUpdate(toUpdate: &ReadingEntry) -> ReadingEntry { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: convert the identifier to snake case: `prompt_for_update` [INFO] [stderr] [INFO] [stderr] warning: variable `toUpdate` should have a snake case name [INFO] [stderr] --> src/main.rs:70:20 [INFO] [stderr] | [INFO] [stderr] 70 | fn promptForUpdate(toUpdate: &ReadingEntry) -> ReadingEntry { [INFO] [stderr] | ^^^^^^^^ help: convert the identifier to snake case: `to_update` [INFO] [stderr] [INFO] [stderr] warning: variable `splittedTags` should have a snake case name [INFO] [stderr] --> src/main.rs:78:9 [INFO] [stderr] | [INFO] [stderr] 78 | let splittedTags = tags.split(" ").map(|x| String::from(x)).collect(); [INFO] [stderr] | ^^^^^^^^^^^^ help: convert the identifier to snake case: `splitted_tags` [INFO] [stderr] [INFO] [stderr] warning: variable `splittedTags` should have a snake case name [INFO] [stderr] --> src/main.rs:103:9 [INFO] [stderr] | [INFO] [stderr] 103 | let splittedTags = tags.split(" ").map(|x| String::from(x)).collect(); [INFO] [stderr] | ^^^^^^^^^^^^ help: convert the identifier to snake case: `splitted_tags` [INFO] [stderr] [INFO] [stderr] warning: variable `withId` should have a snake case name [INFO] [stderr] --> src/main.rs:126:45 [INFO] [stderr] | [INFO] [stderr] 126 | fn print_table(entries: &Vec, withId: bool) -> Table { [INFO] [stderr] | ^^^^^^ help: convert the identifier to snake case: `with_id` [INFO] [stderr] [INFO] [stderr] warning: variable `formatString` should have a snake case name [INFO] [stderr] --> src/main.rs:139:13 [INFO] [stderr] | [INFO] [stderr] 139 | let formatString = formatEnumToString(&e.format); [INFO] [stderr] | ^^^^^^^^^^^^ help: convert the identifier to snake case: `format_string` [INFO] [stderr] [INFO] [stderr] warning: variable `idString` should have a snake case name [INFO] [stderr] --> src/main.rs:149:13 [INFO] [stderr] | [INFO] [stderr] 149 | let idString = &e.id.to_string(); [INFO] [stderr] | ^^^^^^^^ help: convert the identifier to snake case: `id_string` [INFO] [stderr] [INFO] [stderr] warning: function `createHeaderVec` should have a snake case name [INFO] [stderr] --> src/main.rs:160:4 [INFO] [stderr] | [INFO] [stderr] 160 | fn createHeaderVec() -> Vec { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: convert the identifier to snake case: `create_header_vec` [INFO] [stderr] [INFO] [stderr] warning: function `createTableRowFromReadingEntry` should have a snake case name [INFO] [stderr] --> src/main.rs:170:4 [INFO] [stderr] | [INFO] [stderr] 170 | fn createTableRowFromReadingEntry(re: &ReadingEntry) -> TableRow { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: convert the identifier to snake case: `create_table_row_from_reading_entry` [INFO] [stderr] [INFO] [stderr] warning: function `initConfig` should have a snake case name [INFO] [stderr] --> src/main.rs:181:4 [INFO] [stderr] | [INFO] [stderr] 181 | fn initConfig() -> Config { [INFO] [stderr] | ^^^^^^^^^^ help: convert the identifier to snake case: `init_config` [INFO] [stderr] [INFO] [stderr] warning: function `expandTilde` should have a snake case name [INFO] [stderr] --> src/main.rs:199:4 [INFO] [stderr] | [INFO] [stderr] 199 | fn expandTilde(dir: &String) -> String { [INFO] [stderr] | ^^^^^^^^^^^ help: convert the identifier to snake case: `expand_tilde` [INFO] [stderr] [INFO] [stderr] warning: function `createAppFolderIfNeccessary` should have a snake case name [INFO] [stderr] --> src/main.rs:217:4 [INFO] [stderr] | [INFO] [stderr] 217 | fn createAppFolderIfNeccessary() -> std::io::Result<()>{ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: convert the identifier to snake case: `create_app_folder_if_neccessary` [INFO] [stderr] [INFO] [stderr] warning: unused `Result` that must be used [INFO] [stderr] --> src/main.rs:231:5 [INFO] [stderr] | [INFO] [stderr] 231 | createAppFolderIfNeccessary(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(unused_must_use)]` on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: variable `toUpdate` should have a snake case name [INFO] [stderr] --> src/main.rs:241:17 [INFO] [stderr] | [INFO] [stderr] 241 | let toUpdate = backend.getById(id)?; [INFO] [stderr] | ^^^^^^^^ help: convert the identifier to snake case: `to_update` [INFO] [stderr] [INFO] [stderr] warning: unused `Result` that must be used [INFO] [stderr] --> src/main.rs:246:13 [INFO] [stderr] | [INFO] [stderr] 246 | backend.deleteById(id); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: variable `filteredEntries` should have a snake case name [INFO] [stderr] --> src/main.rs:253:21 [INFO] [stderr] | [INFO] [stderr] 253 | let filteredEntries = entries.into_iter() [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: convert the identifier to snake case: `filtered_entries` [INFO] [stderr] [INFO] [stderr] warning: variable `Equal` should have a snake case name [INFO] [stderr] --> src/querylanguage.rs:26:9 [INFO] [stderr] | [INFO] [stderr] 26 | Equal => { [INFO] [stderr] | ^^^^^ help: convert the identifier to snake case: `equal` [INFO] [stderr] [INFO] [stderr] warning: variable `currentModifier` should have a snake case name [INFO] [stderr] --> src/querylanguage.rs:136:13 [INFO] [stderr] | [INFO] [stderr] 136 | let mut currentModifier: &mut Modifier = &mut root; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: convert the identifier to snake case: `current_modifier` [INFO] [stderr] [INFO] [stderr] warning: structure field `withId` should have a snake case name [INFO] [stderr] --> src/config.rs:4:9 [INFO] [stderr] | [INFO] [stderr] 4 | pub withId: bool, [INFO] [stderr] | ^^^^^^ help: convert the identifier to snake case: `with_id` [INFO] [stderr] [INFO] [stderr] warning: 36 warnings emitted [INFO] [stderr] [INFO] [stderr] For more information about this error, try `rustc --explain E0170`. [INFO] [stderr] Finished test [unoptimized + debuginfo] target(s) in 0.07s [INFO] [stderr] Running unittests (/opt/rustwide/target/debug/deps/readinglist-d64763e350326d46) [INFO] [stderr] Running unittests (/opt/rustwide/target/debug/deps/readinglist-98ce3527493cf4f3) [INFO] [stdout] test querylanguage::equal_comparison_works ... ok [INFO] [stdout] test querylanguage::test_query_parsing_multivalue ... ok [INFO] [stdout] test querylanguage::test_query_parsing_single_value ... ok [INFO] [stdout] test test_expand_tilde ... FAILED [INFO] [stdout] [INFO] [stdout] failures: [INFO] [stdout] [INFO] [stdout] ---- test_expand_tilde stdout ---- [INFO] [stdout] thread 'test_expand_tilde' panicked at 'assertion failed: `(left == right)` [INFO] [stdout] left: `"/root/foo"`, [INFO] [stdout] right: `"/Users/tlongo/foo"`', src/main.rs:195:5 [INFO] [stdout] stack backtrace: [INFO] [stdout] 0: 0x55c44d619e30 - std[77c0456e0eb29f0c]::backtrace_rs::backtrace::libunwind::trace [INFO] [stdout] at /rustc/ce59db7a1b1b012fb2793c4641c1bdecad7a128b/library/std/src/../../backtrace/src/backtrace/libunwind.rs:90:5 [INFO] [stdout] 1: 0x55c44d619e30 - std[77c0456e0eb29f0c]::backtrace_rs::backtrace::trace_unsynchronized:: [INFO] [stdout] at /rustc/ce59db7a1b1b012fb2793c4641c1bdecad7a128b/library/std/src/../../backtrace/src/backtrace/mod.rs:66:5 [INFO] [stdout] 2: 0x55c44d619e30 - std[77c0456e0eb29f0c]::sys_common::backtrace::_print_fmt [INFO] [stdout] at /rustc/ce59db7a1b1b012fb2793c4641c1bdecad7a128b/library/std/src/sys_common/backtrace.rs:67:5 [INFO] [stdout] 3: 0x55c44d619e30 - ::fmt [INFO] [stdout] at /rustc/ce59db7a1b1b012fb2793c4641c1bdecad7a128b/library/std/src/sys_common/backtrace.rs:46:22 [INFO] [stdout] 4: 0x55c44d63d9fc - core[ee1ca6415511a9c4]::fmt::write [INFO] [stdout] at /rustc/ce59db7a1b1b012fb2793c4641c1bdecad7a128b/library/core/src/fmt/mod.rs:1110:17 [INFO] [stdout] 5: 0x55c44d616945 - as std[77c0456e0eb29f0c]::io::Write>::write_fmt [INFO] [stdout] at /rustc/ce59db7a1b1b012fb2793c4641c1bdecad7a128b/library/std/src/io/mod.rs:1584:15 [INFO] [stdout] 6: 0x55c44d61bfcb - std[77c0456e0eb29f0c]::sys_common::backtrace::_print [INFO] [stdout] at /rustc/ce59db7a1b1b012fb2793c4641c1bdecad7a128b/library/std/src/sys_common/backtrace.rs:49:5 [INFO] [stdout] 7: 0x55c44d61bfcb - std[77c0456e0eb29f0c]::sys_common::backtrace::print [INFO] [stdout] at /rustc/ce59db7a1b1b012fb2793c4641c1bdecad7a128b/library/std/src/sys_common/backtrace.rs:36:9 [INFO] [stdout] 8: 0x55c44d61bfcb - std[77c0456e0eb29f0c]::panicking::default_hook::{closure#1} [INFO] [stdout] at /rustc/ce59db7a1b1b012fb2793c4641c1bdecad7a128b/library/std/src/panicking.rs:208:50 [INFO] [stdout] 9: 0x55c44d61badc - std[77c0456e0eb29f0c]::panicking::default_hook [INFO] [stdout] at /rustc/ce59db7a1b1b012fb2793c4641c1bdecad7a128b/library/std/src/panicking.rs:222:9 [INFO] [stdout] 10: 0x55c44d61c671 - std[77c0456e0eb29f0c]::panicking::rust_panic_with_hook [INFO] [stdout] at /rustc/ce59db7a1b1b012fb2793c4641c1bdecad7a128b/library/std/src/panicking.rs:622:17 [INFO] [stdout] 11: 0x55c44d61c177 - std[77c0456e0eb29f0c]::panicking::begin_panic_handler::{closure#0} [INFO] [stdout] at /rustc/ce59db7a1b1b012fb2793c4641c1bdecad7a128b/library/std/src/panicking.rs:519:13 [INFO] [stdout] 12: 0x55c44d61a32c - std[77c0456e0eb29f0c]::sys_common::backtrace::__rust_end_short_backtrace:: [INFO] [stdout] at /rustc/ce59db7a1b1b012fb2793c4641c1bdecad7a128b/library/std/src/sys_common/backtrace.rs:141:18 [INFO] [stdout] 13: 0x55c44d61c0d9 - rust_begin_unwind [INFO] [stdout] at /rustc/ce59db7a1b1b012fb2793c4641c1bdecad7a128b/library/std/src/panicking.rs:515:5 [INFO] [stdout] 14: 0x55c44d48a621 - core[ee1ca6415511a9c4]::panicking::panic_fmt [INFO] [stdout] at /rustc/ce59db7a1b1b012fb2793c4641c1bdecad7a128b/library/core/src/panicking.rs:92:14 [INFO] [stdout] 15: 0x55c44d63c318 - core[ee1ca6415511a9c4]::panicking::assert_failed_inner [INFO] [stdout] 16: 0x55c44d4903fa - core[ee1ca6415511a9c4]::panicking::assert_failed:: [INFO] [stdout] at /rustc/ce59db7a1b1b012fb2793c4641c1bdecad7a128b/library/core/src/panicking.rs:117:5 [INFO] [stdout] 17: 0x55c44d4961be - readinglist[3fe4fa2b2dcb7411]::test_expand_tilde [INFO] [stdout] at /opt/rustwide/workdir/src/main.rs:195:5 [INFO] [stdout] 18: 0x55c44d495cfa - readinglist[3fe4fa2b2dcb7411]::test_expand_tilde::{closure#0} [INFO] [stdout] at /opt/rustwide/workdir/src/main.rs:192:1 [INFO] [stdout] 19: 0x55c44d4919ee - >::call_once [INFO] [stdout] at /rustc/ce59db7a1b1b012fb2793c4641c1bdecad7a128b/library/core/src/ops/function.rs:227:5 [INFO] [stdout] 20: 0x55c44d4bee53 - >::call_once [INFO] [stdout] at /rustc/ce59db7a1b1b012fb2793c4641c1bdecad7a128b/library/core/src/ops/function.rs:227:5 [INFO] [stdout] 21: 0x55c44d4bee53 - test[eeb9024d9ac7bc83]::__rust_begin_short_backtrace:: [INFO] [stdout] at /rustc/ce59db7a1b1b012fb2793c4641c1bdecad7a128b/library/test/src/lib.rs:577:5 [INFO] [stdout] 22: 0x55c44d4bd91c - + core[ee1ca6415511a9c4]::marker::Send> as core[ee1ca6415511a9c4]::ops::function::FnOnce<()>>::call_once [INFO] [stdout] at /rustc/ce59db7a1b1b012fb2793c4641c1bdecad7a128b/library/alloc/src/boxed.rs:1575:9 [INFO] [stdout] 23: 0x55c44d4bd91c - + core[ee1ca6415511a9c4]::marker::Send>> as core[ee1ca6415511a9c4]::ops::function::FnOnce<()>>::call_once [INFO] [stdout] at /rustc/ce59db7a1b1b012fb2793c4641c1bdecad7a128b/library/std/src/panic.rs:346:9 [INFO] [stdout] 24: 0x55c44d4bd91c - std[77c0456e0eb29f0c]::panicking::try::do_call:: + core[ee1ca6415511a9c4]::marker::Send>>, ()> [INFO] [stdout] at /rustc/ce59db7a1b1b012fb2793c4641c1bdecad7a128b/library/std/src/panicking.rs:401:40 [INFO] [stdout] 25: 0x55c44d4bd91c - std[77c0456e0eb29f0c]::panicking::try::<(), std[77c0456e0eb29f0c]::panic::AssertUnwindSafe + core[ee1ca6415511a9c4]::marker::Send>>> [INFO] [stdout] at /rustc/ce59db7a1b1b012fb2793c4641c1bdecad7a128b/library/std/src/panicking.rs:365:19 [INFO] [stdout] 26: 0x55c44d4bd91c - std[77c0456e0eb29f0c]::panic::catch_unwind:: + core[ee1ca6415511a9c4]::marker::Send>>, ()> [INFO] [stdout] at /rustc/ce59db7a1b1b012fb2793c4641c1bdecad7a128b/library/std/src/panic.rs:433:14 [INFO] [stdout] 27: 0x55c44d4bd91c - test[eeb9024d9ac7bc83]::run_test_in_process [INFO] [stdout] at /rustc/ce59db7a1b1b012fb2793c4641c1bdecad7a128b/library/test/src/lib.rs:600:18 [INFO] [stdout] 28: 0x55c44d4bd91c - test[eeb9024d9ac7bc83]::run_test::run_test_inner::{closure#0} [INFO] [stdout] at /rustc/ce59db7a1b1b012fb2793c4641c1bdecad7a128b/library/test/src/lib.rs:492:39 [INFO] [stdout] 29: 0x55c44d49d5e2 - test[eeb9024d9ac7bc83]::run_test::run_test_inner::{closure#1} [INFO] [stdout] at /rustc/ce59db7a1b1b012fb2793c4641c1bdecad7a128b/library/test/src/lib.rs:519:37 [INFO] [stdout] 30: 0x55c44d49d5e2 - std[77c0456e0eb29f0c]::sys_common::backtrace::__rust_begin_short_backtrace:: [INFO] [stdout] at /rustc/ce59db7a1b1b012fb2793c4641c1bdecad7a128b/library/std/src/sys_common/backtrace.rs:125:18 [INFO] [stdout] 31: 0x55c44d49dec8 - ::spawn_unchecked::::{closure#0}::{closure#0} [INFO] [stdout] at /rustc/ce59db7a1b1b012fb2793c4641c1bdecad7a128b/library/std/src/thread/mod.rs:481:17 [INFO] [stdout] 32: 0x55c44d49dec8 - ::spawn_unchecked::{closure#0}::{closure#0}> as core[ee1ca6415511a9c4]::ops::function::FnOnce<()>>::call_once [INFO] [stdout] at /rustc/ce59db7a1b1b012fb2793c4641c1bdecad7a128b/library/std/src/panic.rs:346:9 [INFO] [stdout] 33: 0x55c44d49dec8 - std[77c0456e0eb29f0c]::panicking::try::do_call::::spawn_unchecked::{closure#0}::{closure#0}>, ()> [INFO] [stdout] at /rustc/ce59db7a1b1b012fb2793c4641c1bdecad7a128b/library/std/src/panicking.rs:401:40 [INFO] [stdout] 34: 0x55c44d49dec8 - std[77c0456e0eb29f0c]::panicking::try::<(), std[77c0456e0eb29f0c]::panic::AssertUnwindSafe<::spawn_unchecked::{closure#0}::{closure#0}>> [INFO] [stdout] at /rustc/ce59db7a1b1b012fb2793c4641c1bdecad7a128b/library/std/src/panicking.rs:365:19 [INFO] [stdout] 35: 0x55c44d49dec8 - std[77c0456e0eb29f0c]::panic::catch_unwind::::spawn_unchecked::{closure#0}::{closure#0}>, ()> [INFO] [stdout] at /rustc/ce59db7a1b1b012fb2793c4641c1bdecad7a128b/library/std/src/panic.rs:433:14 [INFO] [stdout] 36: 0x55c44d49dec8 - ::spawn_unchecked::::{closure#0} [INFO] [stdout] at /rustc/ce59db7a1b1b012fb2793c4641c1bdecad7a128b/library/std/src/thread/mod.rs:480:30 [INFO] [stdout] 37: 0x55c44d49dec8 - <::spawn_unchecked::{closure#0} as core[ee1ca6415511a9c4]::ops::function::FnOnce<()>>::call_once::{shim:vtable#0} [INFO] [stdout] at /rustc/ce59db7a1b1b012fb2793c4641c1bdecad7a128b/library/core/src/ops/function.rs:227:5 [INFO] [stdout] 38: 0x55c44d6211b7 - > as core[ee1ca6415511a9c4]::ops::function::FnOnce<()>>::call_once [INFO] [stdout] at /rustc/ce59db7a1b1b012fb2793c4641c1bdecad7a128b/library/alloc/src/boxed.rs:1575:9 [INFO] [stdout] 39: 0x55c44d6211b7 - >> as core[ee1ca6415511a9c4]::ops::function::FnOnce<()>>::call_once [INFO] [stdout] at /rustc/ce59db7a1b1b012fb2793c4641c1bdecad7a128b/library/alloc/src/boxed.rs:1575:9 [INFO] [stdout] 40: 0x55c44d6211b7 - ::new::thread_start [INFO] [stdout] at /rustc/ce59db7a1b1b012fb2793c4641c1bdecad7a128b/library/std/src/sys/unix/thread.rs:71:17 [INFO] [stdout] 41: 0x7fa2fef63609 - start_thread [INFO] [stdout] 42: 0x7fa2fed33293 - clone [INFO] [stdout] 43: 0x0 - [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] failures: [INFO] [stdout] test_expand_tilde [INFO] [stdout] [INFO] [stdout] test result: FAILED. 3 passed; 1 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.03s [INFO] [stdout] [INFO] [stderr] error: test failed, to rerun pass '--bin readinglist' [INFO] running `Command { std: "docker" "inspect" "8ca3fb8cfbecd3b06fe1546f668cf8200086df89d28b6e7c0afd3b7ef19db154", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "8ca3fb8cfbecd3b06fe1546f668cf8200086df89d28b6e7c0afd3b7ef19db154", kill_on_drop: false }` [INFO] [stdout] 8ca3fb8cfbecd3b06fe1546f668cf8200086df89d28b6e7c0afd3b7ef19db154