[INFO] cloning repository https://github.com/r1cebank/rgb [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/r1cebank/rgb" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fr1cebank%2Frgb", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fr1cebank%2Frgb'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] e4dc4148c5acca4bdaa48c391f72f0a983eb67b1 [INFO] testing r1cebank/rgb against master#99e3aef02079e9c10583638520cd0c134dc3a01d for pr-85530 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fr1cebank%2Frgb" "/workspace/builds/worker-2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/r1cebank/rgb on toolchain 99e3aef02079e9c10583638520cd0c134dc3a01d [INFO] running `Command { std: "/workspace/cargo-home/bin/cargo" "+99e3aef02079e9c10583638520cd0c134dc3a01d" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/r1cebank/rgb [INFO] finished tweaking git repo https://github.com/r1cebank/rgb [INFO] tweaked toml for git repo https://github.com/r1cebank/rgb written to /workspace/builds/worker-2/source/Cargo.toml [INFO] crate git repo https://github.com/r1cebank/rgb already has a lockfile, it will not be regenerated [INFO] running `Command { std: "/workspace/cargo-home/bin/cargo" "+99e3aef02079e9c10583638520cd0c134dc3a01d" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:20528e8c29e4536546f0102ce88568b16ea7538393a33fcca951030f7af10457" "/opt/rustwide/cargo-home/bin/cargo" "+99e3aef02079e9c10583638520cd0c134dc3a01d" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] f17e6227fa2113fc3e7e5333fee69270f560468e18e925d417fbe139b1db5606 [INFO] running `Command { std: "docker" "start" "-a" "f17e6227fa2113fc3e7e5333fee69270f560468e18e925d417fbe139b1db5606", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "f17e6227fa2113fc3e7e5333fee69270f560468e18e925d417fbe139b1db5606", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "f17e6227fa2113fc3e7e5333fee69270f560468e18e925d417fbe139b1db5606", kill_on_drop: false }` [INFO] [stdout] f17e6227fa2113fc3e7e5333fee69270f560468e18e925d417fbe139b1db5606 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:20528e8c29e4536546f0102ce88568b16ea7538393a33fcca951030f7af10457" "/opt/rustwide/cargo-home/bin/cargo" "+99e3aef02079e9c10583638520cd0c134dc3a01d" "build" "--frozen" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] a4d6b26c1c1e2a3501d079f927911ba3adbe039e75ace8eb4948aa717957fa9a [INFO] running `Command { std: "docker" "start" "-a" "a4d6b26c1c1e2a3501d079f927911ba3adbe039e75ace8eb4948aa717957fa9a", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Compiling libc v0.2.80 [INFO] [stderr] Compiling const_fn v0.4.3 [INFO] [stderr] Compiling syn v1.0.48 [INFO] [stderr] Compiling unicode-xid v0.1.0 [INFO] [stderr] Compiling semver-parser v0.7.0 [INFO] [stderr] Compiling piston-float v1.0.0 [INFO] [stderr] Compiling serde_derive v1.0.117 [INFO] [stderr] Compiling serde v1.0.117 [INFO] [stderr] Compiling piston-graphics_api_version v1.0.0 [INFO] [stderr] Compiling getrandom v0.1.15 [INFO] [stderr] Compiling weezl v0.1.2 [INFO] [stderr] Compiling cc v1.0.61 [INFO] [stderr] Compiling ttf-parser v0.6.2 [INFO] [stderr] Compiling proc-macro-hack v0.5.19 [INFO] [stderr] Compiling ab_glyph_rasterizer v0.1.4 [INFO] [stderr] Compiling piston-texture v0.8.0 [INFO] [stderr] Compiling read_color v1.0.0 [INFO] [stderr] Compiling fnv v1.0.7 [INFO] [stderr] Compiling interpolation v0.2.0 [INFO] [stderr] Compiling unicode-width v0.1.8 [INFO] [stderr] Compiling piston-shaders_graphics2d v0.4.0 [INFO] [stderr] Compiling unicode-segmentation v1.6.0 [INFO] [stderr] Compiling vec_map v0.8.2 [INFO] [stderr] Compiling futures-sink v0.3.7 [INFO] [stderr] Compiling strsim v0.8.0 [INFO] [stderr] Compiling futures-core v0.3.7 [INFO] [stderr] Compiling ansi_term v0.11.0 [INFO] [stderr] Compiling find_folder v0.3.0 [INFO] [stderr] Compiling strum v0.19.5 [INFO] [stderr] Compiling num-traits v0.2.14 [INFO] [stderr] Compiling crossbeam-utils v0.8.0 [INFO] [stderr] Compiling memoffset v0.5.6 [INFO] [stderr] Compiling libloading v0.6.5 [INFO] [stderr] Compiling standback v0.2.11 [INFO] [stderr] Compiling alsa-sys v0.1.2 [INFO] [stderr] Compiling lock_api v0.4.1 [INFO] [stderr] Compiling time v0.2.22 [INFO] [stderr] Compiling piston-viewport v1.0.0 [INFO] [stderr] Compiling vecmath v1.0.0 [INFO] [stderr] Compiling log v0.4.11 [INFO] [stderr] Compiling proc-macro2 v0.4.30 [INFO] [stderr] Compiling shader_version v0.7.0 [INFO] [stderr] Compiling semver v0.9.0 [INFO] [stderr] Compiling textwrap v0.11.0 [INFO] [stderr] Compiling gif v0.11.1 [INFO] [stderr] Compiling draw_state v0.8.0 [INFO] [stderr] Compiling quote v1.0.7 [INFO] [stderr] Compiling smallvec v0.6.13 [INFO] [stderr] Compiling spinning_top v0.2.2 [INFO] [stderr] Compiling dlib v0.4.2 [INFO] [stderr] Compiling png v0.16.7 [INFO] [stderr] Compiling quote v0.6.13 [INFO] [stderr] Compiling wayland-sys v0.21.13 [INFO] [stderr] Compiling rustc_version v0.2.3 [INFO] [stderr] Compiling heck v0.3.1 [INFO] [stderr] Compiling gl_generator v0.14.0 [INFO] [stderr] Compiling gl_generator v0.10.0 [INFO] [stderr] Compiling wayland-scanner v0.21.13 [INFO] [stderr] Compiling gfx_core v0.9.2 [INFO] [stderr] Compiling owned_ttf_parser v0.6.0 [INFO] [stderr] Compiling parking_lot_core v0.6.2 [INFO] [stderr] Compiling parking_lot v0.9.0 [INFO] [stderr] Compiling rusttype v0.9.2 [INFO] [stderr] Compiling libloading v0.5.2 [INFO] [stderr] Compiling piston2d-graphics v0.39.0 [INFO] [stderr] Compiling gl v0.11.0 [INFO] [stderr] Compiling crossbeam-epoch v0.9.0 [INFO] [stderr] Compiling crossbeam-channel v0.5.0 [INFO] [stderr] Compiling nix v0.14.1 [INFO] [stderr] Compiling num_cpus v1.13.0 [INFO] [stderr] Compiling memmap v0.7.0 [INFO] [stderr] Compiling x11-dl v2.18.5 [INFO] [stderr] Compiling raw-window-handle v0.3.3 [INFO] [stderr] Compiling shared_library v0.1.9 [INFO] [stderr] Compiling dirs-sys v0.3.5 [INFO] [stderr] Compiling time v0.1.44 [INFO] [stderr] Compiling atty v0.2.14 [INFO] [stderr] Compiling wayland-client v0.21.13 [INFO] [stderr] Compiling wayland-protocols v0.21.13 [INFO] [stderr] Compiling clap v2.33.3 [INFO] [stderr] Compiling osmesa-sys v0.1.2 [INFO] [stderr] Compiling dirs v2.0.2 [INFO] [stderr] Compiling term v0.6.1 [INFO] [stderr] Compiling rand_core v0.5.1 [INFO] [stderr] Compiling ordered-float v1.1.0 [INFO] [stderr] Compiling num-integer v0.1.44 [INFO] [stderr] Compiling approx v0.3.2 [INFO] [stderr] Compiling line_drawing v0.7.0 [INFO] [stderr] Compiling crossbeam-deque v0.8.0 [INFO] [stderr] Compiling cpal v0.8.2 [INFO] [stderr] Compiling glutin_glx_sys v0.1.7 [INFO] [stderr] Compiling glutin_egl_sys v0.1.5 [INFO] [stderr] Compiling gfx_gl v0.6.1 [INFO] [stderr] Compiling rusttype v0.8.3 [INFO] [stderr] Compiling rand_chacha v0.2.2 [INFO] [stderr] Compiling rayon-core v1.9.0 [INFO] [stderr] Compiling gfx v0.18.2 [INFO] [stderr] Compiling rand v0.7.3 [INFO] [stderr] Compiling num-iter v0.1.42 [INFO] [stderr] Compiling num-rational v0.3.2 [INFO] [stderr] Compiling chrono v0.4.19 [INFO] [stderr] Compiling rusttype v0.7.9 [INFO] [stderr] Compiling andrew v0.2.1 [INFO] [stderr] Compiling rayon v1.5.0 [INFO] [stderr] Compiling flume v0.9.1 [INFO] [stderr] Compiling simplelog v0.7.6 [INFO] [stderr] Compiling wayland-commons v0.21.13 [INFO] [stderr] Compiling jpeg-decoder v0.1.20 [INFO] [stderr] Compiling tiff v0.6.0 [INFO] [stderr] Compiling time-macros-impl v0.1.1 [INFO] [stderr] Compiling strum_macros v0.19.4 [INFO] [stderr] Compiling image v0.23.11 [INFO] [stderr] Compiling time-macros v0.1.1 [INFO] [stderr] Compiling gfx_device_gl v0.16.2 [INFO] [stderr] Compiling smithay-client-toolkit v0.4.6 [INFO] [stderr] Compiling piston-gfx_texture v0.41.0 [INFO] [stderr] Compiling piston2d-gfx_graphics v0.72.0 [INFO] [stderr] Compiling winit v0.19.5 [INFO] [stderr] Compiling glutin v0.21.2 [INFO] [stderr] Compiling pistoncore-input v1.0.0 [INFO] [stderr] Compiling pistoncore-window v0.47.0 [INFO] [stderr] Compiling pistoncore-event_loop v0.52.0 [INFO] [stderr] Compiling pistoncore-glutin_window v0.67.1 [INFO] [stderr] Compiling piston v0.52.0 [INFO] [stderr] Compiling piston_window v0.116.0 [INFO] [stderr] Compiling rgb v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `Error` [INFO] [stdout] --> src/cartridge/mbc3.rs:6:15 [INFO] [stdout] | [INFO] [stdout] 6 | use std::io::{Error, Read, Write}; [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Error` [INFO] [stdout] --> src/cartridge/rtc.rs:6:15 [INFO] [stdout] | [INFO] [stdout] 6 | use std::io::{Error, Write}; [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `crate::debug::message::DebugMessage` [INFO] [stdout] --> src/debug.rs:7:5 [INFO] [stdout] | [INFO] [stdout] 7 | use crate::debug::message::DebugMessage; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `crate::emulator::Emulator` [INFO] [stdout] --> src/debug.rs:8:5 [INFO] [stdout] | [INFO] [stdout] 8 | use crate::emulator::Emulator; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `Receiver`, `TryRecvError` [INFO] [stdout] --> src/debug.rs:19:13 [INFO] [stdout] | [INFO] [stdout] 19 | use flume::{Receiver, TryRecvError}; [INFO] [stdout] | ^^^^^^^^ ^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `Builder`, `JoinHandle` [INFO] [stdout] --> src/debug.rs:20:19 [INFO] [stdout] | [INFO] [stdout] 20 | use std::thread::{Builder, JoinHandle}; [INFO] [stdout] | ^^^^^^^ ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `crate::cartridge::load_cartridge` [INFO] [stdout] --> src/emulator.rs:4:5 [INFO] [stdout] | [INFO] [stdout] 4 | use crate::cartridge::load_cartridge; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `crate::cpu::instruction::InstructionSet` [INFO] [stdout] --> src/emulator.rs:5:5 [INFO] [stdout] | [INFO] [stdout] 5 | use crate::cpu::instruction::InstructionSet; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `random_framebuffer` [INFO] [stdout] --> src/emulator.rs:10:18 [INFO] [stdout] | [INFO] [stdout] 10 | use crate::ppu::{random_framebuffer, Mode, PPUFramebuffer}; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::io` [INFO] [stdout] --> src/memory/mmu.rs:9:5 [INFO] [stdout] | [INFO] [stdout] 9 | use std::io; [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::io::Write` [INFO] [stdout] --> src/memory/mmu.rs:10:5 [INFO] [stdout] | [INFO] [stdout] 10 | use std::io::Write; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `...` range patterns are deprecated [INFO] [stdout] --> src/memory/mmu.rs:122:19 [INFO] [stdout] | [INFO] [stdout] 122 | 0x0000...0x7fff => { [INFO] [stdout] | ^^^ help: use `..=` for an inclusive range [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(ellipsis_inclusive_range_patterns)]` on by default [INFO] [stdout] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in the 2021 edition! [INFO] [stdout] = note: for more information, see issue #80165 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `...` range patterns are deprecated [INFO] [stdout] --> src/memory/mmu.rs:155:18 [INFO] [stdout] | [INFO] [stdout] 155 | 0xf40...0xff4b => self.ppu.borrow().get(address), [INFO] [stdout] | ^^^ help: use `..=` for an inclusive range [INFO] [stdout] | [INFO] [stdout] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in the 2021 edition! [INFO] [stdout] = note: for more information, see issue #80165 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `...` range patterns are deprecated [INFO] [stdout] --> src/memory/mmu.rs:208:19 [INFO] [stdout] | [INFO] [stdout] 208 | 0xff80...0xfffe => self.high_ram[address as usize - 0xff80] = value, [INFO] [stdout] | ^^^ help: use `..=` for an inclusive range [INFO] [stdout] | [INFO] [stdout] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in the 2021 edition! [INFO] [stdout] = note: for more information, see issue #80165 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `...` range patterns are deprecated [INFO] [stdout] --> src/ppu.rs:492:19 [INFO] [stdout] | [INFO] [stdout] 492 | 0xfe00...0xfe9f => self.oam[address as usize - 0xfe00], [INFO] [stdout] | ^^^ help: use `..=` for an inclusive range [INFO] [stdout] | [INFO] [stdout] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in the 2021 edition! [INFO] [stdout] = note: for more information, see issue #80165 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Path` [INFO] [stdout] --> src/save.rs:1:17 [INFO] [stdout] | [INFO] [stdout] 1 | use std::path::{Path, PathBuf}; [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `address` [INFO] [stdout] --> src/cartridge/rom.rs:21:23 [INFO] [stdout] | [INFO] [stdout] 21 | fn set(&mut self, address: u16, value: u8) { [INFO] [stdout] | ^^^^^^^ help: if this is intentional, prefix it with an underscore: `_address` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `value` [INFO] [stdout] --> src/cartridge/rom.rs:21:37 [INFO] [stdout] | [INFO] [stdout] 21 | fn set(&mut self, address: u16, value: u8) { [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_value` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `config` [INFO] [stdout] --> src/debug/debug_logger.rs:34:31 [INFO] [stdout] | [INFO] [stdout] 34 | pub fn should_skip(&self, config: &Config, record: &Record<'_>) -> bool { [INFO] [stdout] | ^^^^^^ help: if this is intentional, prefix it with an underscore: `_config` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant is never used: `INTERRUPT_ENABLE_REG` [INFO] [stdout] --> src/cpu.rs:22:1 [INFO] [stdout] | [INFO] [stdout] 22 | const INTERRUPT_ENABLE_REG: u16 = 0xFFFF; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant is never used: `INTERRUPT_FLAG_REG` [INFO] [stdout] --> src/cpu.rs:23:1 [INFO] [stdout] | [INFO] [stdout] 23 | const INTERRUPT_FLAG_REG: u16 = 0xFF0F; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant is never used: `V_BLANK` [INFO] [stdout] --> src/cpu.rs:25:1 [INFO] [stdout] | [INFO] [stdout] 25 | const V_BLANK: u8 = 0x01; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant is never used: `LCD_STAT` [INFO] [stdout] --> src/cpu.rs:26:1 [INFO] [stdout] | [INFO] [stdout] 26 | const LCD_STAT: u8 = 0x02; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant is never used: `TIMER` [INFO] [stdout] --> src/cpu.rs:27:1 [INFO] [stdout] | [INFO] [stdout] 27 | const TIMER: u8 = 0x04; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant is never used: `SERIAL` [INFO] [stdout] --> src/cpu.rs:28:1 [INFO] [stdout] | [INFO] [stdout] 28 | const SERIAL: u8 = 0x08; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant is never used: `D_PAD` [INFO] [stdout] --> src/cpu.rs:29:1 [INFO] [stdout] | [INFO] [stdout] 29 | const D_PAD: u8 = 0x10; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field is never read: `last_serial` [INFO] [stdout] --> src/memory/mmu.rs:21:5 [INFO] [stdout] | [INFO] [stdout] 21 | last_serial: u8, [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field is never read: `horiz_blanking` [INFO] [stdout] --> src/ppu.rs:147:5 [INFO] [stdout] | [INFO] [stdout] 147 | horiz_blanking: bool, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `S` should have a snake case name [INFO] [stdout] --> src/cartridge/rtc.rs:22:5 [INFO] [stdout] | [INFO] [stdout] 22 | S: u8, [INFO] [stdout] | ^ help: convert the identifier to snake case (notice the capitalization): `s` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_snake_case)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `M` should have a snake case name [INFO] [stdout] --> src/cartridge/rtc.rs:23:5 [INFO] [stdout] | [INFO] [stdout] 23 | M: u8, [INFO] [stdout] | ^ help: convert the identifier to snake case: `m` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `H` should have a snake case name [INFO] [stdout] --> src/cartridge/rtc.rs:24:5 [INFO] [stdout] | [INFO] [stdout] 24 | H: u8, [INFO] [stdout] | ^ help: convert the identifier to snake case: `h` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `DL` should have a snake case name [INFO] [stdout] --> src/cartridge/rtc.rs:25:5 [INFO] [stdout] | [INFO] [stdout] 25 | DL: u8, [INFO] [stdout] | ^^ help: convert the identifier to snake case: `dl` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `DH` should have a snake case name [INFO] [stdout] --> src/cartridge/rtc.rs:26:5 [INFO] [stdout] | [INFO] [stdout] 26 | DH: u8, [INFO] [stdout] | ^^ help: convert the identifier to snake case: `dh` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 33 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Error` [INFO] [stdout] --> src/cartridge/mbc3.rs:6:15 [INFO] [stdout] | [INFO] [stdout] 6 | use std::io::{Error, Read, Write}; [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Error` [INFO] [stdout] --> src/cartridge/rtc.rs:6:15 [INFO] [stdout] | [INFO] [stdout] 6 | use std::io::{Error, Write}; [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `crate::debug::message::DebugMessage` [INFO] [stdout] --> src/debug.rs:7:5 [INFO] [stdout] | [INFO] [stdout] 7 | use crate::debug::message::DebugMessage; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `crate::emulator::Emulator` [INFO] [stdout] --> src/debug.rs:8:5 [INFO] [stdout] | [INFO] [stdout] 8 | use crate::emulator::Emulator; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `Receiver`, `TryRecvError` [INFO] [stdout] --> src/debug.rs:19:13 [INFO] [stdout] | [INFO] [stdout] 19 | use flume::{Receiver, TryRecvError}; [INFO] [stdout] | ^^^^^^^^ ^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `Builder`, `JoinHandle` [INFO] [stdout] --> src/debug.rs:20:19 [INFO] [stdout] | [INFO] [stdout] 20 | use std::thread::{Builder, JoinHandle}; [INFO] [stdout] | ^^^^^^^ ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `crate::cpu::interrupt::Flag::Joypad` [INFO] [stdout] --> src/display.rs:1:5 [INFO] [stdout] | [INFO] [stdout] 1 | use crate::cpu::interrupt::Flag::Joypad; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `crate::cpu::registers::Flag` [INFO] [stdout] --> src/display/debug_canvas.rs:1:5 [INFO] [stdout] | [INFO] [stdout] 1 | use crate::cpu::registers::Flag; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `FB_H`, `FB_W` [INFO] [stdout] --> src/display/game_canvas.rs:1:34 [INFO] [stdout] | [INFO] [stdout] 1 | use crate::ppu::{PPUFramebuffer, FB_H, FB_W}; [INFO] [stdout] | ^^^^ ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `piston_window::*` [INFO] [stdout] --> src/display/game_canvas.rs:2:5 [INFO] [stdout] | [INFO] [stdout] 2 | use piston_window::*; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `crate::cartridge::load_cartridge` [INFO] [stdout] --> src/emulator.rs:4:5 [INFO] [stdout] | [INFO] [stdout] 4 | use crate::cartridge::load_cartridge; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `crate::cpu::instruction::InstructionSet` [INFO] [stdout] --> src/emulator.rs:5:5 [INFO] [stdout] | [INFO] [stdout] 5 | use crate::cpu::instruction::InstructionSet; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `random_framebuffer` [INFO] [stdout] --> src/emulator.rs:10:18 [INFO] [stdout] | [INFO] [stdout] 10 | use crate::ppu::{random_framebuffer, Mode, PPUFramebuffer}; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::io` [INFO] [stdout] --> src/memory/mmu.rs:9:5 [INFO] [stdout] | [INFO] [stdout] 9 | use std::io; [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::io::Write` [INFO] [stdout] --> src/memory/mmu.rs:10:5 [INFO] [stdout] | [INFO] [stdout] 10 | use std::io::Write; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `...` range patterns are deprecated [INFO] [stdout] --> src/memory/mmu.rs:122:19 [INFO] [stdout] | [INFO] [stdout] 122 | 0x0000...0x7fff => { [INFO] [stdout] | ^^^ help: use `..=` for an inclusive range [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(ellipsis_inclusive_range_patterns)]` on by default [INFO] [stdout] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in the 2021 edition! [INFO] [stdout] = note: for more information, see issue #80165 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `...` range patterns are deprecated [INFO] [stdout] --> src/memory/mmu.rs:155:18 [INFO] [stdout] | [INFO] [stdout] 155 | 0xf40...0xff4b => self.ppu.borrow().get(address), [INFO] [stdout] | ^^^ help: use `..=` for an inclusive range [INFO] [stdout] | [INFO] [stdout] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in the 2021 edition! [INFO] [stdout] = note: for more information, see issue #80165 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `...` range patterns are deprecated [INFO] [stdout] --> src/memory/mmu.rs:208:19 [INFO] [stdout] | [INFO] [stdout] 208 | 0xff80...0xfffe => self.high_ram[address as usize - 0xff80] = value, [INFO] [stdout] | ^^^ help: use `..=` for an inclusive range [INFO] [stdout] | [INFO] [stdout] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in the 2021 edition! [INFO] [stdout] = note: for more information, see issue #80165 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `...` range patterns are deprecated [INFO] [stdout] --> src/ppu.rs:492:19 [INFO] [stdout] | [INFO] [stdout] 492 | 0xfe00...0xfe9f => self.oam[address as usize - 0xfe00], [INFO] [stdout] | ^^^ help: use `..=` for an inclusive range [INFO] [stdout] | [INFO] [stdout] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in the 2021 edition! [INFO] [stdout] = note: for more information, see issue #80165 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Path` [INFO] [stdout] --> src/save.rs:1:17 [INFO] [stdout] | [INFO] [stdout] 1 | use std::path::{Path, PathBuf}; [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `format` [INFO] [stdout] --> src/apu.rs:11:17 [INFO] [stdout] | [INFO] [stdout] 11 | let format = cpal::Format { [INFO] [stdout] | ^^^^^^ help: if this is intentional, prefix it with an underscore: `_format` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `address` [INFO] [stdout] --> src/cartridge/rom.rs:21:23 [INFO] [stdout] | [INFO] [stdout] 21 | fn set(&mut self, address: u16, value: u8) { [INFO] [stdout] | ^^^^^^^ help: if this is intentional, prefix it with an underscore: `_address` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `value` [INFO] [stdout] --> src/cartridge/rom.rs:21:37 [INFO] [stdout] | [INFO] [stdout] 21 | fn set(&mut self, address: u16, value: u8) { [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_value` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `config` [INFO] [stdout] --> src/debug/debug_logger.rs:34:31 [INFO] [stdout] | [INFO] [stdout] 34 | pub fn should_skip(&self, config: &Config, record: &Record<'_>) -> bool { [INFO] [stdout] | ^^^^^^ help: if this is intentional, prefix it with an underscore: `_config` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/display.rs:90:25 [INFO] [stdout] | [INFO] [stdout] 90 | let mut key_pressed = match key { [INFO] [stdout] | ----^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/display.rs:130:33 [INFO] [stdout] | [INFO] [stdout] 130 | ... let mut key_pressed = match key { [INFO] [stdout] | ----^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant is never constructed: `Serial` [INFO] [stdout] --> src/cpu/interrupt.rs:7:5 [INFO] [stdout] | [INFO] [stdout] 7 | Serial = 3, [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant is never used: `INTERRUPT_ENABLE_REG` [INFO] [stdout] --> src/cpu.rs:22:1 [INFO] [stdout] | [INFO] [stdout] 22 | const INTERRUPT_ENABLE_REG: u16 = 0xFFFF; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant is never used: `INTERRUPT_FLAG_REG` [INFO] [stdout] --> src/cpu.rs:23:1 [INFO] [stdout] | [INFO] [stdout] 23 | const INTERRUPT_FLAG_REG: u16 = 0xFF0F; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant is never used: `V_BLANK` [INFO] [stdout] --> src/cpu.rs:25:1 [INFO] [stdout] | [INFO] [stdout] 25 | const V_BLANK: u8 = 0x01; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant is never used: `LCD_STAT` [INFO] [stdout] --> src/cpu.rs:26:1 [INFO] [stdout] | [INFO] [stdout] 26 | const LCD_STAT: u8 = 0x02; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant is never used: `TIMER` [INFO] [stdout] --> src/cpu.rs:27:1 [INFO] [stdout] | [INFO] [stdout] 27 | const TIMER: u8 = 0x04; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant is never used: `SERIAL` [INFO] [stdout] --> src/cpu.rs:28:1 [INFO] [stdout] | [INFO] [stdout] 28 | const SERIAL: u8 = 0x08; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant is never used: `D_PAD` [INFO] [stdout] --> src/cpu.rs:29:1 [INFO] [stdout] | [INFO] [stdout] 29 | const D_PAD: u8 = 0x10; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field is never read: `step_flip` [INFO] [stdout] --> src/cpu.rs:91:5 [INFO] [stdout] | [INFO] [stdout] 91 | step_flip: bool, // When this is set to true, we want to handle events [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated function is never used: `flip` [INFO] [stdout] --> src/cpu.rs:249:12 [INFO] [stdout] | [INFO] [stdout] 249 | pub fn flip(&mut self) -> bool { [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant is never constructed: `PeekValue` [INFO] [stdout] --> src/debug/command.rs:3:5 [INFO] [stdout] | [INFO] [stdout] 3 | PeekValue(u16), [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant is never constructed: `DebugCommand` [INFO] [stdout] --> src/debug/message.rs:8:5 [INFO] [stdout] | [INFO] [stdout] 8 | DebugCommand(DebugCommand), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant is never used: `FB_W` [INFO] [stdout] --> src/debug.rs:22:1 [INFO] [stdout] | [INFO] [stdout] 22 | pub const FB_W: usize = 160; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant is never used: `FB_H` [INFO] [stdout] --> src/debug.rs:23:1 [INFO] [stdout] | [INFO] [stdout] 23 | pub const FB_H: usize = 144; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function is never used: `update_tile_canvas` [INFO] [stdout] --> src/display/debug_canvas.rs:161:8 [INFO] [stdout] | [INFO] [stdout] 161 | pub fn update_tile_canvas( [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant is never used: `PIXEL_COLOUR_STRIDE` [INFO] [stdout] --> src/display/debug_canvas.rs:189:5 [INFO] [stdout] | [INFO] [stdout] 189 | const PIXEL_COLOUR_STRIDE: usize = 4; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field is never read: `last_serial` [INFO] [stdout] --> src/memory/mmu.rs:21:5 [INFO] [stdout] | [INFO] [stdout] 21 | last_serial: u8, [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field is never read: `horiz_blanking` [INFO] [stdout] --> src/ppu.rs:147:5 [INFO] [stdout] | [INFO] [stdout] 147 | horiz_blanking: bool, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function is never used: `random_framebuffer` [INFO] [stdout] --> src/ppu.rs:624:8 [INFO] [stdout] | [INFO] [stdout] 624 | pub fn random_framebuffer() -> PPUFramebuffer { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `S` should have a snake case name [INFO] [stdout] --> src/cartridge/rtc.rs:22:5 [INFO] [stdout] | [INFO] [stdout] 22 | S: u8, [INFO] [stdout] | ^ help: convert the identifier to snake case (notice the capitalization): `s` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_snake_case)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `M` should have a snake case name [INFO] [stdout] --> src/cartridge/rtc.rs:23:5 [INFO] [stdout] | [INFO] [stdout] 23 | M: u8, [INFO] [stdout] | ^ help: convert the identifier to snake case: `m` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `H` should have a snake case name [INFO] [stdout] --> src/cartridge/rtc.rs:24:5 [INFO] [stdout] | [INFO] [stdout] 24 | H: u8, [INFO] [stdout] | ^ help: convert the identifier to snake case: `h` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `DL` should have a snake case name [INFO] [stdout] --> src/cartridge/rtc.rs:25:5 [INFO] [stdout] | [INFO] [stdout] 25 | DL: u8, [INFO] [stdout] | ^^ help: convert the identifier to snake case: `dl` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `DH` should have a snake case name [INFO] [stdout] --> src/cartridge/rtc.rs:26:5 [INFO] [stdout] | [INFO] [stdout] 26 | DH: u8, [INFO] [stdout] | ^^ help: convert the identifier to snake case: `dh` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 50 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1m 16s [INFO] running `Command { std: "docker" "inspect" "a4d6b26c1c1e2a3501d079f927911ba3adbe039e75ace8eb4948aa717957fa9a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a4d6b26c1c1e2a3501d079f927911ba3adbe039e75ace8eb4948aa717957fa9a", kill_on_drop: false }` [INFO] [stdout] a4d6b26c1c1e2a3501d079f927911ba3adbe039e75ace8eb4948aa717957fa9a [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:20528e8c29e4536546f0102ce88568b16ea7538393a33fcca951030f7af10457" "/opt/rustwide/cargo-home/bin/cargo" "+99e3aef02079e9c10583638520cd0c134dc3a01d" "test" "--frozen" "--no-run" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 5b4fefe9cfc5ef0e1f6cff0626d19c88fd591290904a0293ffb8f8c77dcf51be [INFO] running `Command { std: "docker" "start" "-a" "5b4fefe9cfc5ef0e1f6cff0626d19c88fd591290904a0293ffb8f8c77dcf51be", kill_on_drop: false }` [INFO] [stderr] Compiling serde_json v1.0.59 [INFO] [stdout] warning: unused import: `Error` [INFO] [stdout] --> src/cartridge/mbc3.rs:6:15 [INFO] [stdout] | [INFO] [stdout] 6 | use std::io::{Error, Read, Write}; [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Error` [INFO] [stdout] --> src/cartridge/rtc.rs:6:15 [INFO] [stdout] | [INFO] [stdout] 6 | use std::io::{Error, Write}; [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `crate::debug::message::DebugMessage` [INFO] [stdout] --> src/debug.rs:7:5 [INFO] [stdout] | [INFO] [stdout] 7 | use crate::debug::message::DebugMessage; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `crate::emulator::Emulator` [INFO] [stdout] --> src/debug.rs:8:5 [INFO] [stdout] | [INFO] [stdout] 8 | use crate::emulator::Emulator; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `Receiver`, `TryRecvError` [INFO] [stdout] --> src/debug.rs:19:13 [INFO] [stdout] | [INFO] [stdout] 19 | use flume::{Receiver, TryRecvError}; [INFO] [stdout] | ^^^^^^^^ ^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `Builder`, `JoinHandle` [INFO] [stdout] --> src/debug.rs:20:19 [INFO] [stdout] | [INFO] [stdout] 20 | use std::thread::{Builder, JoinHandle}; [INFO] [stdout] | ^^^^^^^ ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `crate::cartridge::load_cartridge` [INFO] [stdout] --> src/emulator.rs:4:5 [INFO] [stdout] | [INFO] [stdout] 4 | use crate::cartridge::load_cartridge; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `crate::cpu::instruction::InstructionSet` [INFO] [stdout] --> src/emulator.rs:5:5 [INFO] [stdout] | [INFO] [stdout] 5 | use crate::cpu::instruction::InstructionSet; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `random_framebuffer` [INFO] [stdout] --> src/emulator.rs:10:18 [INFO] [stdout] | [INFO] [stdout] 10 | use crate::ppu::{random_framebuffer, Mode, PPUFramebuffer}; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::io` [INFO] [stdout] --> src/memory/mmu.rs:9:5 [INFO] [stdout] | [INFO] [stdout] 9 | use std::io; [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::io::Write` [INFO] [stdout] --> src/memory/mmu.rs:10:5 [INFO] [stdout] | [INFO] [stdout] 10 | use std::io::Write; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `...` range patterns are deprecated [INFO] [stdout] --> src/memory/mmu.rs:122:19 [INFO] [stdout] | [INFO] [stdout] 122 | 0x0000...0x7fff => { [INFO] [stdout] | ^^^ help: use `..=` for an inclusive range [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(ellipsis_inclusive_range_patterns)]` on by default [INFO] [stdout] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in the 2021 edition! [INFO] [stdout] = note: for more information, see issue #80165 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `...` range patterns are deprecated [INFO] [stdout] --> src/memory/mmu.rs:155:18 [INFO] [stdout] | [INFO] [stdout] 155 | 0xf40...0xff4b => self.ppu.borrow().get(address), [INFO] [stdout] | ^^^ help: use `..=` for an inclusive range [INFO] [stdout] | [INFO] [stdout] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in the 2021 edition! [INFO] [stdout] = note: for more information, see issue #80165 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `...` range patterns are deprecated [INFO] [stdout] --> src/memory/mmu.rs:208:19 [INFO] [stdout] | [INFO] [stdout] 208 | 0xff80...0xfffe => self.high_ram[address as usize - 0xff80] = value, [INFO] [stdout] | ^^^ help: use `..=` for an inclusive range [INFO] [stdout] | [INFO] [stdout] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in the 2021 edition! [INFO] [stdout] = note: for more information, see issue #80165 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `...` range patterns are deprecated [INFO] [stdout] --> src/ppu.rs:492:19 [INFO] [stdout] | [INFO] [stdout] 492 | 0xfe00...0xfe9f => self.oam[address as usize - 0xfe00], [INFO] [stdout] | ^^^ help: use `..=` for an inclusive range [INFO] [stdout] | [INFO] [stdout] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in the 2021 edition! [INFO] [stdout] = note: for more information, see issue #80165 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Path` [INFO] [stdout] --> src/save.rs:1:17 [INFO] [stdout] | [INFO] [stdout] 1 | use std::path::{Path, PathBuf}; [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `address` [INFO] [stdout] --> src/cartridge/rom.rs:21:23 [INFO] [stdout] | [INFO] [stdout] 21 | fn set(&mut self, address: u16, value: u8) { [INFO] [stdout] | ^^^^^^^ help: if this is intentional, prefix it with an underscore: `_address` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `value` [INFO] [stdout] --> src/cartridge/rom.rs:21:37 [INFO] [stdout] | [INFO] [stdout] 21 | fn set(&mut self, address: u16, value: u8) { [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_value` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `config` [INFO] [stdout] --> src/debug/debug_logger.rs:34:31 [INFO] [stdout] | [INFO] [stdout] 34 | pub fn should_skip(&self, config: &Config, record: &Record<'_>) -> bool { [INFO] [stdout] | ^^^^^^ help: if this is intentional, prefix it with an underscore: `_config` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant is never used: `INTERRUPT_ENABLE_REG` [INFO] [stdout] --> src/cpu.rs:22:1 [INFO] [stdout] | [INFO] [stdout] 22 | const INTERRUPT_ENABLE_REG: u16 = 0xFFFF; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant is never used: `INTERRUPT_FLAG_REG` [INFO] [stdout] --> src/cpu.rs:23:1 [INFO] [stdout] | [INFO] [stdout] 23 | const INTERRUPT_FLAG_REG: u16 = 0xFF0F; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant is never used: `V_BLANK` [INFO] [stdout] --> src/cpu.rs:25:1 [INFO] [stdout] | [INFO] [stdout] 25 | const V_BLANK: u8 = 0x01; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant is never used: `LCD_STAT` [INFO] [stdout] --> src/cpu.rs:26:1 [INFO] [stdout] | [INFO] [stdout] 26 | const LCD_STAT: u8 = 0x02; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant is never used: `TIMER` [INFO] [stdout] --> src/cpu.rs:27:1 [INFO] [stdout] | [INFO] [stdout] 27 | const TIMER: u8 = 0x04; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant is never used: `SERIAL` [INFO] [stdout] --> src/cpu.rs:28:1 [INFO] [stdout] | [INFO] [stdout] 28 | const SERIAL: u8 = 0x08; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant is never used: `D_PAD` [INFO] [stdout] --> src/cpu.rs:29:1 [INFO] [stdout] | [INFO] [stdout] 29 | const D_PAD: u8 = 0x10; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field is never read: `last_serial` [INFO] [stdout] --> src/memory/mmu.rs:21:5 [INFO] [stdout] | [INFO] [stdout] 21 | last_serial: u8, [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field is never read: `horiz_blanking` [INFO] [stdout] --> src/ppu.rs:147:5 [INFO] [stdout] | [INFO] [stdout] 147 | horiz_blanking: bool, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `S` should have a snake case name [INFO] [stdout] --> src/cartridge/rtc.rs:22:5 [INFO] [stdout] | [INFO] [stdout] 22 | S: u8, [INFO] [stdout] | ^ help: convert the identifier to snake case (notice the capitalization): `s` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_snake_case)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `M` should have a snake case name [INFO] [stdout] --> src/cartridge/rtc.rs:23:5 [INFO] [stdout] | [INFO] [stdout] 23 | M: u8, [INFO] [stdout] | ^ help: convert the identifier to snake case: `m` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `H` should have a snake case name [INFO] [stdout] --> src/cartridge/rtc.rs:24:5 [INFO] [stdout] | [INFO] [stdout] 24 | H: u8, [INFO] [stdout] | ^ help: convert the identifier to snake case: `h` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `DL` should have a snake case name [INFO] [stdout] --> src/cartridge/rtc.rs:25:5 [INFO] [stdout] | [INFO] [stdout] 25 | DL: u8, [INFO] [stdout] | ^^ help: convert the identifier to snake case: `dl` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `DH` should have a snake case name [INFO] [stdout] --> src/cartridge/rtc.rs:26:5 [INFO] [stdout] | [INFO] [stdout] 26 | DH: u8, [INFO] [stdout] | ^^ help: convert the identifier to snake case: `dh` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 33 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Error` [INFO] [stdout] --> src/cartridge/mbc3.rs:6:15 [INFO] [stdout] | [INFO] [stdout] 6 | use std::io::{Error, Read, Write}; [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Error` [INFO] [stdout] --> src/cartridge/rtc.rs:6:15 [INFO] [stdout] | [INFO] [stdout] 6 | use std::io::{Error, Write}; [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `crate::debug::message::DebugMessage` [INFO] [stdout] --> src/debug.rs:7:5 [INFO] [stdout] | [INFO] [stdout] 7 | use crate::debug::message::DebugMessage; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `crate::emulator::Emulator` [INFO] [stdout] --> src/debug.rs:8:5 [INFO] [stdout] | [INFO] [stdout] 8 | use crate::emulator::Emulator; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `Receiver`, `TryRecvError` [INFO] [stdout] --> src/debug.rs:19:13 [INFO] [stdout] | [INFO] [stdout] 19 | use flume::{Receiver, TryRecvError}; [INFO] [stdout] | ^^^^^^^^ ^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `Builder`, `JoinHandle` [INFO] [stdout] --> src/debug.rs:20:19 [INFO] [stdout] | [INFO] [stdout] 20 | use std::thread::{Builder, JoinHandle}; [INFO] [stdout] | ^^^^^^^ ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `crate::cpu::interrupt::Flag::Joypad` [INFO] [stdout] --> src/display.rs:1:5 [INFO] [stdout] | [INFO] [stdout] 1 | use crate::cpu::interrupt::Flag::Joypad; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `crate::cpu::registers::Flag` [INFO] [stdout] --> src/display/debug_canvas.rs:1:5 [INFO] [stdout] | [INFO] [stdout] 1 | use crate::cpu::registers::Flag; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `FB_H`, `FB_W` [INFO] [stdout] --> src/display/game_canvas.rs:1:34 [INFO] [stdout] | [INFO] [stdout] 1 | use crate::ppu::{PPUFramebuffer, FB_H, FB_W}; [INFO] [stdout] | ^^^^ ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `piston_window::*` [INFO] [stdout] --> src/display/game_canvas.rs:2:5 [INFO] [stdout] | [INFO] [stdout] 2 | use piston_window::*; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `crate::cartridge::load_cartridge` [INFO] [stdout] --> src/emulator.rs:4:5 [INFO] [stdout] | [INFO] [stdout] 4 | use crate::cartridge::load_cartridge; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `crate::cpu::instruction::InstructionSet` [INFO] [stdout] --> src/emulator.rs:5:5 [INFO] [stdout] | [INFO] [stdout] 5 | use crate::cpu::instruction::InstructionSet; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `random_framebuffer` [INFO] [stdout] --> src/emulator.rs:10:18 [INFO] [stdout] | [INFO] [stdout] 10 | use crate::ppu::{random_framebuffer, Mode, PPUFramebuffer}; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::io` [INFO] [stdout] --> src/memory/mmu.rs:9:5 [INFO] [stdout] | [INFO] [stdout] 9 | use std::io; [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::io::Write` [INFO] [stdout] --> src/memory/mmu.rs:10:5 [INFO] [stdout] | [INFO] [stdout] 10 | use std::io::Write; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `...` range patterns are deprecated [INFO] [stdout] --> src/memory/mmu.rs:122:19 [INFO] [stdout] | [INFO] [stdout] 122 | 0x0000...0x7fff => { [INFO] [stdout] | ^^^ help: use `..=` for an inclusive range [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(ellipsis_inclusive_range_patterns)]` on by default [INFO] [stdout] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in the 2021 edition! [INFO] [stdout] = note: for more information, see issue #80165 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `...` range patterns are deprecated [INFO] [stdout] --> src/memory/mmu.rs:155:18 [INFO] [stdout] | [INFO] [stdout] 155 | 0xf40...0xff4b => self.ppu.borrow().get(address), [INFO] [stdout] | ^^^ help: use `..=` for an inclusive range [INFO] [stdout] | [INFO] [stdout] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in the 2021 edition! [INFO] [stdout] = note: for more information, see issue #80165 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `...` range patterns are deprecated [INFO] [stdout] --> src/memory/mmu.rs:208:19 [INFO] [stdout] | [INFO] [stdout] 208 | 0xff80...0xfffe => self.high_ram[address as usize - 0xff80] = value, [INFO] [stdout] | ^^^ help: use `..=` for an inclusive range [INFO] [stdout] | [INFO] [stdout] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in the 2021 edition! [INFO] [stdout] = note: for more information, see issue #80165 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `...` range patterns are deprecated [INFO] [stdout] --> src/ppu.rs:492:19 [INFO] [stdout] | [INFO] [stdout] 492 | 0xfe00...0xfe9f => self.oam[address as usize - 0xfe00], [INFO] [stdout] | ^^^ help: use `..=` for an inclusive range [INFO] [stdout] | [INFO] [stdout] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in the 2021 edition! [INFO] [stdout] = note: for more information, see issue #80165 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Path` [INFO] [stdout] --> src/save.rs:1:17 [INFO] [stdout] | [INFO] [stdout] 1 | use std::path::{Path, PathBuf}; [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `format` [INFO] [stdout] --> src/apu.rs:11:17 [INFO] [stdout] | [INFO] [stdout] 11 | let format = cpal::Format { [INFO] [stdout] | ^^^^^^ help: if this is intentional, prefix it with an underscore: `_format` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `address` [INFO] [stdout] --> src/cartridge/rom.rs:21:23 [INFO] [stdout] | [INFO] [stdout] 21 | fn set(&mut self, address: u16, value: u8) { [INFO] [stdout] | ^^^^^^^ help: if this is intentional, prefix it with an underscore: `_address` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `value` [INFO] [stdout] --> src/cartridge/rom.rs:21:37 [INFO] [stdout] | [INFO] [stdout] 21 | fn set(&mut self, address: u16, value: u8) { [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_value` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `config` [INFO] [stdout] --> src/debug/debug_logger.rs:34:31 [INFO] [stdout] | [INFO] [stdout] 34 | pub fn should_skip(&self, config: &Config, record: &Record<'_>) -> bool { [INFO] [stdout] | ^^^^^^ help: if this is intentional, prefix it with an underscore: `_config` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/display.rs:90:25 [INFO] [stdout] | [INFO] [stdout] 90 | let mut key_pressed = match key { [INFO] [stdout] | ----^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/display.rs:130:33 [INFO] [stdout] | [INFO] [stdout] 130 | ... let mut key_pressed = match key { [INFO] [stdout] | ----^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant is never constructed: `Serial` [INFO] [stdout] --> src/cpu/interrupt.rs:7:5 [INFO] [stdout] | [INFO] [stdout] 7 | Serial = 3, [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant is never used: `INTERRUPT_ENABLE_REG` [INFO] [stdout] --> src/cpu.rs:22:1 [INFO] [stdout] | [INFO] [stdout] 22 | const INTERRUPT_ENABLE_REG: u16 = 0xFFFF; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant is never used: `INTERRUPT_FLAG_REG` [INFO] [stdout] --> src/cpu.rs:23:1 [INFO] [stdout] | [INFO] [stdout] 23 | const INTERRUPT_FLAG_REG: u16 = 0xFF0F; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant is never used: `V_BLANK` [INFO] [stdout] --> src/cpu.rs:25:1 [INFO] [stdout] | [INFO] [stdout] 25 | const V_BLANK: u8 = 0x01; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant is never used: `LCD_STAT` [INFO] [stdout] --> src/cpu.rs:26:1 [INFO] [stdout] | [INFO] [stdout] 26 | const LCD_STAT: u8 = 0x02; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant is never used: `TIMER` [INFO] [stdout] --> src/cpu.rs:27:1 [INFO] [stdout] | [INFO] [stdout] 27 | const TIMER: u8 = 0x04; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant is never used: `SERIAL` [INFO] [stdout] --> src/cpu.rs:28:1 [INFO] [stdout] | [INFO] [stdout] 28 | const SERIAL: u8 = 0x08; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant is never used: `D_PAD` [INFO] [stdout] --> src/cpu.rs:29:1 [INFO] [stdout] | [INFO] [stdout] 29 | const D_PAD: u8 = 0x10; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field is never read: `step_flip` [INFO] [stdout] --> src/cpu.rs:91:5 [INFO] [stdout] | [INFO] [stdout] 91 | step_flip: bool, // When this is set to true, we want to handle events [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated function is never used: `flip` [INFO] [stdout] --> src/cpu.rs:249:12 [INFO] [stdout] | [INFO] [stdout] 249 | pub fn flip(&mut self) -> bool { [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant is never constructed: `PeekValue` [INFO] [stdout] --> src/debug/command.rs:3:5 [INFO] [stdout] | [INFO] [stdout] 3 | PeekValue(u16), [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant is never constructed: `DebugCommand` [INFO] [stdout] --> src/debug/message.rs:8:5 [INFO] [stdout] | [INFO] [stdout] 8 | DebugCommand(DebugCommand), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant is never used: `FB_W` [INFO] [stdout] --> src/debug.rs:22:1 [INFO] [stdout] | [INFO] [stdout] 22 | pub const FB_W: usize = 160; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant is never used: `FB_H` [INFO] [stdout] --> src/debug.rs:23:1 [INFO] [stdout] | [INFO] [stdout] 23 | pub const FB_H: usize = 144; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function is never used: `update_tile_canvas` [INFO] [stdout] --> src/display/debug_canvas.rs:161:8 [INFO] [stdout] | [INFO] [stdout] 161 | pub fn update_tile_canvas( [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant is never used: `PIXEL_COLOUR_STRIDE` [INFO] [stdout] --> src/display/debug_canvas.rs:189:5 [INFO] [stdout] | [INFO] [stdout] 189 | const PIXEL_COLOUR_STRIDE: usize = 4; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field is never read: `last_serial` [INFO] [stdout] --> src/memory/mmu.rs:21:5 [INFO] [stdout] | [INFO] [stdout] 21 | last_serial: u8, [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field is never read: `horiz_blanking` [INFO] [stdout] --> src/ppu.rs:147:5 [INFO] [stdout] | [INFO] [stdout] 147 | horiz_blanking: bool, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function is never used: `random_framebuffer` [INFO] [stdout] --> src/ppu.rs:624:8 [INFO] [stdout] | [INFO] [stdout] 624 | pub fn random_framebuffer() -> PPUFramebuffer { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `S` should have a snake case name [INFO] [stdout] --> src/cartridge/rtc.rs:22:5 [INFO] [stdout] | [INFO] [stdout] 22 | S: u8, [INFO] [stdout] | ^ help: convert the identifier to snake case (notice the capitalization): `s` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_snake_case)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `M` should have a snake case name [INFO] [stdout] --> src/cartridge/rtc.rs:23:5 [INFO] [stdout] | [INFO] [stdout] 23 | M: u8, [INFO] [stdout] | ^ help: convert the identifier to snake case: `m` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `H` should have a snake case name [INFO] [stdout] --> src/cartridge/rtc.rs:24:5 [INFO] [stdout] | [INFO] [stdout] 24 | H: u8, [INFO] [stdout] | ^ help: convert the identifier to snake case: `h` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `DL` should have a snake case name [INFO] [stdout] --> src/cartridge/rtc.rs:25:5 [INFO] [stdout] | [INFO] [stdout] 25 | DL: u8, [INFO] [stdout] | ^^ help: convert the identifier to snake case: `dl` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `DH` should have a snake case name [INFO] [stdout] --> src/cartridge/rtc.rs:26:5 [INFO] [stdout] | [INFO] [stdout] 26 | DH: u8, [INFO] [stdout] | ^^ help: convert the identifier to snake case: `dh` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 50 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Compiling rgb v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `rgb::emulator::Emulator` [INFO] [stdout] --> tests/cpu_test.rs:3:5 [INFO] [stdout] | [INFO] [stdout] 3 | use rgb::emulator::Emulator; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Error` [INFO] [stdout] --> src/cartridge/mbc3.rs:6:15 [INFO] [stdout] | [INFO] [stdout] 6 | use std::io::{Error, Read, Write}; [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Error` [INFO] [stdout] --> src/cartridge/rtc.rs:6:15 [INFO] [stdout] | [INFO] [stdout] 6 | use std::io::{Error, Write}; [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `crate::debug::message::DebugMessage` [INFO] [stdout] --> src/debug.rs:7:5 [INFO] [stdout] | [INFO] [stdout] 7 | use crate::debug::message::DebugMessage; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `crate::emulator::Emulator` [INFO] [stdout] --> src/debug.rs:8:5 [INFO] [stdout] | [INFO] [stdout] 8 | use crate::emulator::Emulator; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `Receiver`, `TryRecvError` [INFO] [stdout] --> src/debug.rs:19:13 [INFO] [stdout] | [INFO] [stdout] 19 | use flume::{Receiver, TryRecvError}; [INFO] [stdout] | ^^^^^^^^ ^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `Builder`, `JoinHandle` [INFO] [stdout] --> src/debug.rs:20:19 [INFO] [stdout] | [INFO] [stdout] 20 | use std::thread::{Builder, JoinHandle}; [INFO] [stdout] | ^^^^^^^ ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `crate::cartridge::load_cartridge` [INFO] [stdout] --> src/emulator.rs:4:5 [INFO] [stdout] | [INFO] [stdout] 4 | use crate::cartridge::load_cartridge; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `crate::cpu::instruction::InstructionSet` [INFO] [stdout] --> src/emulator.rs:5:5 [INFO] [stdout] | [INFO] [stdout] 5 | use crate::cpu::instruction::InstructionSet; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `random_framebuffer` [INFO] [stdout] --> src/emulator.rs:10:18 [INFO] [stdout] | [INFO] [stdout] 10 | use crate::ppu::{random_framebuffer, Mode, PPUFramebuffer}; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::io` [INFO] [stdout] --> src/memory/mmu.rs:9:5 [INFO] [stdout] | [INFO] [stdout] 9 | use std::io; [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::io::Write` [INFO] [stdout] --> src/memory/mmu.rs:10:5 [INFO] [stdout] | [INFO] [stdout] 10 | use std::io::Write; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `...` range patterns are deprecated [INFO] [stdout] --> src/memory/mmu.rs:122:19 [INFO] [stdout] | [INFO] [stdout] 122 | 0x0000...0x7fff => { [INFO] [stdout] | ^^^ help: use `..=` for an inclusive range [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(ellipsis_inclusive_range_patterns)]` on by default [INFO] [stdout] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in the 2021 edition! [INFO] [stdout] = note: for more information, see issue #80165 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `...` range patterns are deprecated [INFO] [stdout] --> src/memory/mmu.rs:155:18 [INFO] [stdout] | [INFO] [stdout] 155 | 0xf40...0xff4b => self.ppu.borrow().get(address), [INFO] [stdout] | ^^^ help: use `..=` for an inclusive range [INFO] [stdout] | [INFO] [stdout] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in the 2021 edition! [INFO] [stdout] = note: for more information, see issue #80165 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `...` range patterns are deprecated [INFO] [stdout] --> src/memory/mmu.rs:208:19 [INFO] [stdout] | [INFO] [stdout] 208 | 0xff80...0xfffe => self.high_ram[address as usize - 0xff80] = value, [INFO] [stdout] | ^^^ help: use `..=` for an inclusive range [INFO] [stdout] | [INFO] [stdout] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in the 2021 edition! [INFO] [stdout] = note: for more information, see issue #80165 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `...` range patterns are deprecated [INFO] [stdout] --> src/ppu.rs:492:19 [INFO] [stdout] | [INFO] [stdout] 492 | 0xfe00...0xfe9f => self.oam[address as usize - 0xfe00], [INFO] [stdout] | ^^^ help: use `..=` for an inclusive range [INFO] [stdout] | [INFO] [stdout] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in the 2021 edition! [INFO] [stdout] = note: for more information, see issue #80165 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Path` [INFO] [stdout] --> src/save.rs:1:17 [INFO] [stdout] | [INFO] [stdout] 1 | use std::path::{Path, PathBuf}; [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Error` [INFO] [stdout] --> src/cartridge/mbc3.rs:6:15 [INFO] [stdout] | [INFO] [stdout] 6 | use std::io::{Error, Read, Write}; [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Error` [INFO] [stdout] --> src/cartridge/rtc.rs:6:15 [INFO] [stdout] | [INFO] [stdout] 6 | use std::io::{Error, Write}; [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `crate::debug::message::DebugMessage` [INFO] [stdout] --> src/debug.rs:7:5 [INFO] [stdout] | [INFO] [stdout] 7 | use crate::debug::message::DebugMessage; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `crate::emulator::Emulator` [INFO] [stdout] --> src/debug.rs:8:5 [INFO] [stdout] | [INFO] [stdout] 8 | use crate::emulator::Emulator; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `Receiver`, `TryRecvError` [INFO] [stdout] --> src/debug.rs:19:13 [INFO] [stdout] | [INFO] [stdout] 19 | use flume::{Receiver, TryRecvError}; [INFO] [stdout] | ^^^^^^^^ ^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `Builder`, `JoinHandle` [INFO] [stdout] --> src/debug.rs:20:19 [INFO] [stdout] | [INFO] [stdout] 20 | use std::thread::{Builder, JoinHandle}; [INFO] [stdout] | ^^^^^^^ ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `crate::cpu::interrupt::Flag::Joypad` [INFO] [stdout] --> src/display.rs:1:5 [INFO] [stdout] | [INFO] [stdout] 1 | use crate::cpu::interrupt::Flag::Joypad; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `crate::cpu::registers::Flag` [INFO] [stdout] --> src/display/debug_canvas.rs:1:5 [INFO] [stdout] | [INFO] [stdout] 1 | use crate::cpu::registers::Flag; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `FB_H`, `FB_W` [INFO] [stdout] --> src/display/game_canvas.rs:1:34 [INFO] [stdout] | [INFO] [stdout] 1 | use crate::ppu::{PPUFramebuffer, FB_H, FB_W}; [INFO] [stdout] | ^^^^ ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `piston_window::*` [INFO] [stdout] --> src/display/game_canvas.rs:2:5 [INFO] [stdout] | [INFO] [stdout] 2 | use piston_window::*; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `crate::cartridge::load_cartridge` [INFO] [stdout] --> src/emulator.rs:4:5 [INFO] [stdout] | [INFO] [stdout] 4 | use crate::cartridge::load_cartridge; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `crate::cpu::instruction::InstructionSet` [INFO] [stdout] --> src/emulator.rs:5:5 [INFO] [stdout] | [INFO] [stdout] 5 | use crate::cpu::instruction::InstructionSet; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `random_framebuffer` [INFO] [stdout] --> src/emulator.rs:10:18 [INFO] [stdout] | [INFO] [stdout] 10 | use crate::ppu::{random_framebuffer, Mode, PPUFramebuffer}; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::io` [INFO] [stdout] --> src/memory/mmu.rs:9:5 [INFO] [stdout] | [INFO] [stdout] 9 | use std::io; [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::io::Write` [INFO] [stdout] --> src/memory/mmu.rs:10:5 [INFO] [stdout] | [INFO] [stdout] 10 | use std::io::Write; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `...` range patterns are deprecated [INFO] [stdout] --> src/memory/mmu.rs:122:19 [INFO] [stdout] | [INFO] [stdout] 122 | 0x0000...0x7fff => { [INFO] [stdout] | ^^^ help: use `..=` for an inclusive range [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(ellipsis_inclusive_range_patterns)]` on by default [INFO] [stdout] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in the 2021 edition! [INFO] [stdout] = note: for more information, see issue #80165 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `...` range patterns are deprecated [INFO] [stdout] --> src/memory/mmu.rs:155:18 [INFO] [stdout] | [INFO] [stdout] 155 | 0xf40...0xff4b => self.ppu.borrow().get(address), [INFO] [stdout] | ^^^ help: use `..=` for an inclusive range [INFO] [stdout] | [INFO] [stdout] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in the 2021 edition! [INFO] [stdout] = note: for more information, see issue #80165 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `...` range patterns are deprecated [INFO] [stdout] --> src/memory/mmu.rs:208:19 [INFO] [stdout] | [INFO] [stdout] 208 | 0xff80...0xfffe => self.high_ram[address as usize - 0xff80] = value, [INFO] [stdout] | ^^^ help: use `..=` for an inclusive range [INFO] [stdout] | [INFO] [stdout] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in the 2021 edition! [INFO] [stdout] = note: for more information, see issue #80165 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `...` range patterns are deprecated [INFO] [stdout] --> src/ppu.rs:492:19 [INFO] [stdout] | [INFO] [stdout] 492 | 0xfe00...0xfe9f => self.oam[address as usize - 0xfe00], [INFO] [stdout] | ^^^ help: use `..=` for an inclusive range [INFO] [stdout] | [INFO] [stdout] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in the 2021 edition! [INFO] [stdout] = note: for more information, see issue #80165 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Path` [INFO] [stdout] --> src/save.rs:1:17 [INFO] [stdout] | [INFO] [stdout] 1 | use std::path::{Path, PathBuf}; [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `address` [INFO] [stdout] --> src/cartridge/rom.rs:21:23 [INFO] [stdout] | [INFO] [stdout] 21 | fn set(&mut self, address: u16, value: u8) { [INFO] [stdout] | ^^^^^^^ help: if this is intentional, prefix it with an underscore: `_address` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `value` [INFO] [stdout] --> src/cartridge/rom.rs:21:37 [INFO] [stdout] | [INFO] [stdout] 21 | fn set(&mut self, address: u16, value: u8) { [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_value` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `config` [INFO] [stdout] --> src/debug/debug_logger.rs:34:31 [INFO] [stdout] | [INFO] [stdout] 34 | pub fn should_skip(&self, config: &Config, record: &Record<'_>) -> bool { [INFO] [stdout] | ^^^^^^ help: if this is intentional, prefix it with an underscore: `_config` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `format` [INFO] [stdout] --> src/apu.rs:11:17 [INFO] [stdout] | [INFO] [stdout] 11 | let format = cpal::Format { [INFO] [stdout] | ^^^^^^ help: if this is intentional, prefix it with an underscore: `_format` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `address` [INFO] [stdout] --> src/cartridge/rom.rs:21:23 [INFO] [stdout] | [INFO] [stdout] 21 | fn set(&mut self, address: u16, value: u8) { [INFO] [stdout] | ^^^^^^^ help: if this is intentional, prefix it with an underscore: `_address` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `value` [INFO] [stdout] --> src/cartridge/rom.rs:21:37 [INFO] [stdout] | [INFO] [stdout] 21 | fn set(&mut self, address: u16, value: u8) { [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_value` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `config` [INFO] [stdout] --> src/debug/debug_logger.rs:34:31 [INFO] [stdout] | [INFO] [stdout] 34 | pub fn should_skip(&self, config: &Config, record: &Record<'_>) -> bool { [INFO] [stdout] | ^^^^^^ help: if this is intentional, prefix it with an underscore: `_config` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant is never used: `INTERRUPT_ENABLE_REG` [INFO] [stdout] --> src/cpu.rs:22:1 [INFO] [stdout] | [INFO] [stdout] 22 | const INTERRUPT_ENABLE_REG: u16 = 0xFFFF; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant is never used: `INTERRUPT_FLAG_REG` [INFO] [stdout] --> src/cpu.rs:23:1 [INFO] [stdout] | [INFO] [stdout] 23 | const INTERRUPT_FLAG_REG: u16 = 0xFF0F; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant is never used: `V_BLANK` [INFO] [stdout] --> src/cpu.rs:25:1 [INFO] [stdout] | [INFO] [stdout] 25 | const V_BLANK: u8 = 0x01; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant is never used: `LCD_STAT` [INFO] [stdout] --> src/cpu.rs:26:1 [INFO] [stdout] | [INFO] [stdout] 26 | const LCD_STAT: u8 = 0x02; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant is never used: `TIMER` [INFO] [stdout] --> src/cpu.rs:27:1 [INFO] [stdout] | [INFO] [stdout] 27 | const TIMER: u8 = 0x04; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant is never used: `SERIAL` [INFO] [stdout] --> src/cpu.rs:28:1 [INFO] [stdout] | [INFO] [stdout] 28 | const SERIAL: u8 = 0x08; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant is never used: `D_PAD` [INFO] [stdout] --> src/cpu.rs:29:1 [INFO] [stdout] | [INFO] [stdout] 29 | const D_PAD: u8 = 0x10; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field is never read: `last_serial` [INFO] [stdout] --> src/memory/mmu.rs:21:5 [INFO] [stdout] | [INFO] [stdout] 21 | last_serial: u8, [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field is never read: `horiz_blanking` [INFO] [stdout] --> src/ppu.rs:147:5 [INFO] [stdout] | [INFO] [stdout] 147 | horiz_blanking: bool, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `S` should have a snake case name [INFO] [stdout] --> src/cartridge/rtc.rs:22:5 [INFO] [stdout] | [INFO] [stdout] 22 | S: u8, [INFO] [stdout] | ^ help: convert the identifier to snake case (notice the capitalization): `s` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_snake_case)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `M` should have a snake case name [INFO] [stdout] --> src/cartridge/rtc.rs:23:5 [INFO] [stdout] | [INFO] [stdout] 23 | M: u8, [INFO] [stdout] | ^ help: convert the identifier to snake case: `m` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `H` should have a snake case name [INFO] [stdout] --> src/cartridge/rtc.rs:24:5 [INFO] [stdout] | [INFO] [stdout] 24 | H: u8, [INFO] [stdout] | ^ help: convert the identifier to snake case: `h` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `DL` should have a snake case name [INFO] [stdout] --> src/cartridge/rtc.rs:25:5 [INFO] [stdout] | [INFO] [stdout] 25 | DL: u8, [INFO] [stdout] | ^^ help: convert the identifier to snake case: `dl` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `DH` should have a snake case name [INFO] [stdout] --> src/cartridge/rtc.rs:26:5 [INFO] [stdout] | [INFO] [stdout] 26 | DH: u8, [INFO] [stdout] | ^^ help: convert the identifier to snake case: `dh` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/display.rs:90:25 [INFO] [stdout] | [INFO] [stdout] 90 | let mut key_pressed = match key { [INFO] [stdout] | ----^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/display.rs:130:33 [INFO] [stdout] | [INFO] [stdout] 130 | ... let mut key_pressed = match key { [INFO] [stdout] | ----^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant is never constructed: `Serial` [INFO] [stdout] --> src/cpu/interrupt.rs:7:5 [INFO] [stdout] | [INFO] [stdout] 7 | Serial = 3, [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant is never used: `INTERRUPT_ENABLE_REG` [INFO] [stdout] --> src/cpu.rs:22:1 [INFO] [stdout] | [INFO] [stdout] 22 | const INTERRUPT_ENABLE_REG: u16 = 0xFFFF; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant is never used: `INTERRUPT_FLAG_REG` [INFO] [stdout] --> src/cpu.rs:23:1 [INFO] [stdout] | [INFO] [stdout] 23 | const INTERRUPT_FLAG_REG: u16 = 0xFF0F; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant is never used: `V_BLANK` [INFO] [stdout] --> src/cpu.rs:25:1 [INFO] [stdout] | [INFO] [stdout] 25 | const V_BLANK: u8 = 0x01; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant is never used: `LCD_STAT` [INFO] [stdout] --> src/cpu.rs:26:1 [INFO] [stdout] | [INFO] [stdout] 26 | const LCD_STAT: u8 = 0x02; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant is never used: `TIMER` [INFO] [stdout] --> src/cpu.rs:27:1 [INFO] [stdout] | [INFO] [stdout] 27 | const TIMER: u8 = 0x04; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant is never used: `SERIAL` [INFO] [stdout] --> src/cpu.rs:28:1 [INFO] [stdout] | [INFO] [stdout] 28 | const SERIAL: u8 = 0x08; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant is never used: `D_PAD` [INFO] [stdout] --> src/cpu.rs:29:1 [INFO] [stdout] | [INFO] [stdout] 29 | const D_PAD: u8 = 0x10; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field is never read: `step_flip` [INFO] [stdout] --> src/cpu.rs:91:5 [INFO] [stdout] | [INFO] [stdout] 91 | step_flip: bool, // When this is set to true, we want to handle events [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated function is never used: `flip` [INFO] [stdout] --> src/cpu.rs:249:12 [INFO] [stdout] | [INFO] [stdout] 249 | pub fn flip(&mut self) -> bool { [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant is never constructed: `PeekValue` [INFO] [stdout] --> src/debug/command.rs:3:5 [INFO] [stdout] | [INFO] [stdout] 3 | PeekValue(u16), [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant is never constructed: `DebugCommand` [INFO] [stdout] --> src/debug/message.rs:8:5 [INFO] [stdout] | [INFO] [stdout] 8 | DebugCommand(DebugCommand), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant is never used: `FB_W` [INFO] [stdout] --> src/debug.rs:22:1 [INFO] [stdout] | [INFO] [stdout] 22 | pub const FB_W: usize = 160; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant is never used: `FB_H` [INFO] [stdout] --> src/debug.rs:23:1 [INFO] [stdout] | [INFO] [stdout] 23 | pub const FB_H: usize = 144; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function is never used: `update_tile_canvas` [INFO] [stdout] --> src/display/debug_canvas.rs:161:8 [INFO] [stdout] | [INFO] [stdout] 161 | pub fn update_tile_canvas( [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant is never used: `PIXEL_COLOUR_STRIDE` [INFO] [stdout] --> src/display/debug_canvas.rs:189:5 [INFO] [stdout] | [INFO] [stdout] 189 | const PIXEL_COLOUR_STRIDE: usize = 4; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field is never read: `last_serial` [INFO] [stdout] --> src/memory/mmu.rs:21:5 [INFO] [stdout] | [INFO] [stdout] 21 | last_serial: u8, [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field is never read: `horiz_blanking` [INFO] [stdout] --> src/ppu.rs:147:5 [INFO] [stdout] | [INFO] [stdout] 147 | horiz_blanking: bool, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function is never used: `random_framebuffer` [INFO] [stdout] --> src/ppu.rs:624:8 [INFO] [stdout] | [INFO] [stdout] 624 | pub fn random_framebuffer() -> PPUFramebuffer { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `S` should have a snake case name [INFO] [stdout] --> src/cartridge/rtc.rs:22:5 [INFO] [stdout] | [INFO] [stdout] 22 | S: u8, [INFO] [stdout] | ^ help: convert the identifier to snake case (notice the capitalization): `s` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_snake_case)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `M` should have a snake case name [INFO] [stdout] --> src/cartridge/rtc.rs:23:5 [INFO] [stdout] | [INFO] [stdout] 23 | M: u8, [INFO] [stdout] | ^ help: convert the identifier to snake case: `m` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `H` should have a snake case name [INFO] [stdout] --> src/cartridge/rtc.rs:24:5 [INFO] [stdout] | [INFO] [stdout] 24 | H: u8, [INFO] [stdout] | ^ help: convert the identifier to snake case: `h` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `DL` should have a snake case name [INFO] [stdout] --> src/cartridge/rtc.rs:25:5 [INFO] [stdout] | [INFO] [stdout] 25 | DL: u8, [INFO] [stdout] | ^^ help: convert the identifier to snake case: `dl` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `DH` should have a snake case name [INFO] [stdout] --> src/cartridge/rtc.rs:26:5 [INFO] [stdout] | [INFO] [stdout] 26 | DH: u8, [INFO] [stdout] | ^^ help: convert the identifier to snake case: `dh` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 33 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 50 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished test [unoptimized + debuginfo] target(s) in 5.24s [INFO] running `Command { std: "docker" "inspect" "5b4fefe9cfc5ef0e1f6cff0626d19c88fd591290904a0293ffb8f8c77dcf51be", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "5b4fefe9cfc5ef0e1f6cff0626d19c88fd591290904a0293ffb8f8c77dcf51be", kill_on_drop: false }` [INFO] [stdout] 5b4fefe9cfc5ef0e1f6cff0626d19c88fd591290904a0293ffb8f8c77dcf51be [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:20528e8c29e4536546f0102ce88568b16ea7538393a33fcca951030f7af10457" "/opt/rustwide/cargo-home/bin/cargo" "+99e3aef02079e9c10583638520cd0c134dc3a01d" "test" "--frozen", kill_on_drop: false }` [INFO] [stdout] b4b5adb42ccf08465df647b86a4f7cfbcd3451e8d333e70c398ba09a7eb3ef42 [INFO] running `Command { std: "docker" "start" "-a" "b4b5adb42ccf08465df647b86a4f7cfbcd3451e8d333e70c398ba09a7eb3ef42", kill_on_drop: false }` [INFO] [stderr] warning: unused import: `Error` [INFO] [stderr] --> src/cartridge/mbc3.rs:6:15 [INFO] [stderr] | [INFO] [stderr] 6 | use std::io::{Error, Read, Write}; [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(unused_imports)]` on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `Error` [INFO] [stderr] --> src/cartridge/rtc.rs:6:15 [INFO] [stderr] | [INFO] [stderr] 6 | use std::io::{Error, Write}; [INFO] [stderr] | ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `crate::debug::message::DebugMessage` [INFO] [stderr] --> src/debug.rs:7:5 [INFO] [stderr] | [INFO] [stderr] 7 | use crate::debug::message::DebugMessage; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `crate::emulator::Emulator` [INFO] [stderr] --> src/debug.rs:8:5 [INFO] [stderr] | [INFO] [stderr] 8 | use crate::emulator::Emulator; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused imports: `Receiver`, `TryRecvError` [INFO] [stderr] --> src/debug.rs:19:13 [INFO] [stderr] | [INFO] [stderr] 19 | use flume::{Receiver, TryRecvError}; [INFO] [stderr] | ^^^^^^^^ ^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused imports: `Builder`, `JoinHandle` [INFO] [stderr] --> src/debug.rs:20:19 [INFO] [stderr] | [INFO] [stderr] 20 | use std::thread::{Builder, JoinHandle}; [INFO] [stderr] | ^^^^^^^ ^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `crate::cartridge::load_cartridge` [INFO] [stderr] --> src/emulator.rs:4:5 [INFO] [stderr] | [INFO] [stderr] 4 | use crate::cartridge::load_cartridge; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `crate::cpu::instruction::InstructionSet` [INFO] [stderr] --> src/emulator.rs:5:5 [INFO] [stderr] | [INFO] [stderr] 5 | use crate::cpu::instruction::InstructionSet; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `random_framebuffer` [INFO] [stderr] --> src/emulator.rs:10:18 [INFO] [stderr] | [INFO] [stderr] 10 | use crate::ppu::{random_framebuffer, Mode, PPUFramebuffer}; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::io` [INFO] [stderr] --> src/memory/mmu.rs:9:5 [INFO] [stderr] | [INFO] [stderr] 9 | use std::io; [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::io::Write` [INFO] [stderr] --> src/memory/mmu.rs:10:5 [INFO] [stderr] | [INFO] [stderr] 10 | use std::io::Write; [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/memory/mmu.rs:122:19 [INFO] [stderr] | [INFO] [stderr] 122 | 0x0000...0x7fff => { [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(ellipsis_inclusive_range_patterns)]` on by default [INFO] [stderr] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in the 2021 edition! [INFO] [stderr] = note: for more information, see issue #80165 [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/memory/mmu.rs:155:18 [INFO] [stderr] | [INFO] [stderr] 155 | 0xf40...0xff4b => self.ppu.borrow().get(address), [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] | [INFO] [stderr] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in the 2021 edition! [INFO] [stderr] = note: for more information, see issue #80165 [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/memory/mmu.rs:208:19 [INFO] [stderr] | [INFO] [stderr] 208 | 0xff80...0xfffe => self.high_ram[address as usize - 0xff80] = value, [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] | [INFO] [stderr] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in the 2021 edition! [INFO] [stderr] = note: for more information, see issue #80165 [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/ppu.rs:492:19 [INFO] [stderr] | [INFO] [stderr] 492 | 0xfe00...0xfe9f => self.oam[address as usize - 0xfe00], [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] | [INFO] [stderr] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in the 2021 edition! [INFO] [stderr] = note: for more information, see issue #80165 [INFO] [stderr] [INFO] [stderr] warning: unused import: `Path` [INFO] [stderr] --> src/save.rs:1:17 [INFO] [stderr] | [INFO] [stderr] 1 | use std::path::{Path, PathBuf}; [INFO] [stderr] | ^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused variable: `address` [INFO] [stderr] --> src/cartridge/rom.rs:21:23 [INFO] [stderr] | [INFO] [stderr] 21 | fn set(&mut self, address: u16, value: u8) { [INFO] [stderr] | ^^^^^^^ help: if this is intentional, prefix it with an underscore: `_address` [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(unused_variables)]` on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `value` [INFO] [stderr] --> src/cartridge/rom.rs:21:37 [INFO] [stderr] | [INFO] [stderr] 21 | fn set(&mut self, address: u16, value: u8) { [INFO] [stderr] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_value` [INFO] [stderr] [INFO] [stderr] warning: unused variable: `config` [INFO] [stderr] --> src/debug/debug_logger.rs:34:31 [INFO] [stderr] | [INFO] [stderr] 34 | pub fn should_skip(&self, config: &Config, record: &Record<'_>) -> bool { [INFO] [stderr] | ^^^^^^ help: if this is intentional, prefix it with an underscore: `_config` [INFO] [stderr] [INFO] [stderr] warning: constant is never used: `INTERRUPT_ENABLE_REG` [INFO] [stderr] --> src/cpu.rs:22:1 [INFO] [stderr] | [INFO] [stderr] 22 | const INTERRUPT_ENABLE_REG: u16 = 0xFFFF; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(dead_code)]` on by default [INFO] [stderr] [INFO] [stderr] warning: constant is never used: `INTERRUPT_FLAG_REG` [INFO] [stderr] --> src/cpu.rs:23:1 [INFO] [stderr] | [INFO] [stderr] 23 | const INTERRUPT_FLAG_REG: u16 = 0xFF0F; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: constant is never used: `V_BLANK` [INFO] [stderr] --> src/cpu.rs:25:1 [INFO] [stderr] | [INFO] [stderr] 25 | const V_BLANK: u8 = 0x01; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: constant is never used: `LCD_STAT` [INFO] [stderr] --> src/cpu.rs:26:1 [INFO] [stderr] | [INFO] [stderr] 26 | const LCD_STAT: u8 = 0x02; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: constant is never used: `TIMER` [INFO] [stderr] --> src/cpu.rs:27:1 [INFO] [stderr] | [INFO] [stderr] 27 | const TIMER: u8 = 0x04; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: constant is never used: `SERIAL` [INFO] [stderr] --> src/cpu.rs:28:1 [INFO] [stderr] | [INFO] [stderr] 28 | const SERIAL: u8 = 0x08; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: constant is never used: `D_PAD` [INFO] [stderr] --> src/cpu.rs:29:1 [INFO] [stderr] | [INFO] [stderr] 29 | const D_PAD: u8 = 0x10; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never read: `last_serial` [INFO] [stderr] --> src/memory/mmu.rs:21:5 [INFO] [stderr] | [INFO] [stderr] 21 | last_serial: u8, [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never read: `horiz_blanking` [INFO] [stderr] --> src/ppu.rs:147:5 [INFO] [stderr] | [INFO] [stderr] 147 | horiz_blanking: bool, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: structure field `S` should have a snake case name [INFO] [stderr] --> src/cartridge/rtc.rs:22:5 [INFO] [stderr] | [INFO] [stderr] 22 | S: u8, [INFO] [stderr] | ^ help: convert the identifier to snake case (notice the capitalization): `s` [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(non_snake_case)]` on by default [INFO] [stderr] [INFO] [stderr] warning: structure field `M` should have a snake case name [INFO] [stderr] --> src/cartridge/rtc.rs:23:5 [INFO] [stderr] | [INFO] [stderr] 23 | M: u8, [INFO] [stderr] | ^ help: convert the identifier to snake case: `m` [INFO] [stderr] [INFO] [stderr] warning: structure field `H` should have a snake case name [INFO] [stderr] --> src/cartridge/rtc.rs:24:5 [INFO] [stderr] | [INFO] [stderr] 24 | H: u8, [INFO] [stderr] | ^ help: convert the identifier to snake case: `h` [INFO] [stderr] [INFO] [stderr] warning: structure field `DL` should have a snake case name [INFO] [stderr] --> src/cartridge/rtc.rs:25:5 [INFO] [stderr] | [INFO] [stderr] 25 | DL: u8, [INFO] [stderr] | ^^ help: convert the identifier to snake case: `dl` [INFO] [stderr] [INFO] [stderr] warning: structure field `DH` should have a snake case name [INFO] [stderr] --> src/cartridge/rtc.rs:26:5 [INFO] [stderr] | [INFO] [stderr] 26 | DH: u8, [INFO] [stderr] | ^^ help: convert the identifier to snake case: `dh` [INFO] [stderr] [INFO] [stderr] warning: 33 warnings emitted [INFO] [stderr] [INFO] [stderr] warning: unused import: `Error` [INFO] [stderr] --> src/cartridge/mbc3.rs:6:15 [INFO] [stderr] | [INFO] [stderr] 6 | use std::io::{Error, Read, Write}; [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(unused_imports)]` on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `Error` [INFO] [stderr] --> src/cartridge/rtc.rs:6:15 [INFO] [stderr] | [INFO] [stderr] 6 | use std::io::{Error, Write}; [INFO] [stderr] | ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `crate::debug::message::DebugMessage` [INFO] [stderr] --> src/debug.rs:7:5 [INFO] [stderr] | [INFO] [stderr] 7 | use crate::debug::message::DebugMessage; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `crate::emulator::Emulator` [INFO] [stderr] --> src/debug.rs:8:5 [INFO] [stderr] | [INFO] [stderr] 8 | use crate::emulator::Emulator; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused imports: `Receiver`, `TryRecvError` [INFO] [stderr] --> src/debug.rs:19:13 [INFO] [stderr] | [INFO] [stderr] 19 | use flume::{Receiver, TryRecvError}; [INFO] [stderr] | ^^^^^^^^ ^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused imports: `Builder`, `JoinHandle` [INFO] [stderr] --> src/debug.rs:20:19 [INFO] [stderr] | [INFO] [stderr] 20 | use std::thread::{Builder, JoinHandle}; [INFO] [stderr] | ^^^^^^^ ^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `crate::cartridge::load_cartridge` [INFO] [stderr] --> src/emulator.rs:4:5 [INFO] [stderr] | [INFO] [stderr] 4 | use crate::cartridge::load_cartridge; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `crate::cpu::instruction::InstructionSet` [INFO] [stderr] --> src/emulator.rs:5:5 [INFO] [stderr] | [INFO] [stderr] 5 | use crate::cpu::instruction::InstructionSet; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `random_framebuffer` [INFO] [stderr] --> src/emulator.rs:10:18 [INFO] [stderr] | [INFO] [stderr] 10 | use crate::ppu::{random_framebuffer, Mode, PPUFramebuffer}; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::io` [INFO] [stderr] --> src/memory/mmu.rs:9:5 [INFO] [stderr] | [INFO] [stderr] 9 | use std::io; [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::io::Write` [INFO] [stderr] --> src/memory/mmu.rs:10:5 [INFO] [stderr] | [INFO] [stderr] 10 | use std::io::Write; [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/memory/mmu.rs:122:19 [INFO] [stderr] | [INFO] [stderr] 122 | 0x0000...0x7fff => { [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(ellipsis_inclusive_range_patterns)]` on by default [INFO] [stderr] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in the 2021 edition! [INFO] [stderr] = note: for more information, see issue #80165 [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/memory/mmu.rs:155:18 [INFO] [stderr] | [INFO] [stderr] 155 | 0xf40...0xff4b => self.ppu.borrow().get(address), [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] | [INFO] [stderr] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in the 2021 edition! [INFO] [stderr] = note: for more information, see issue #80165 [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/memory/mmu.rs:208:19 [INFO] [stderr] | [INFO] [stderr] 208 | 0xff80...0xfffe => self.high_ram[address as usize - 0xff80] = value, [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] | [INFO] [stderr] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in the 2021 edition! [INFO] [stderr] = note: for more information, see issue #80165 [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/ppu.rs:492:19 [INFO] [stderr] | [INFO] [stderr] 492 | 0xfe00...0xfe9f => self.oam[address as usize - 0xfe00], [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] | [INFO] [stderr] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in the 2021 edition! [INFO] [stderr] = note: for more information, see issue #80165 [INFO] [stderr] [INFO] [stderr] warning: unused import: `Path` [INFO] [stderr] --> src/save.rs:1:17 [INFO] [stderr] | [INFO] [stderr] 1 | use std::path::{Path, PathBuf}; [INFO] [stderr] | ^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused variable: `address` [INFO] [stderr] --> src/cartridge/rom.rs:21:23 [INFO] [stderr] | [INFO] [stderr] 21 | fn set(&mut self, address: u16, value: u8) { [INFO] [stderr] | ^^^^^^^ help: if this is intentional, prefix it with an underscore: `_address` [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(unused_variables)]` on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `value` [INFO] [stderr] --> src/cartridge/rom.rs:21:37 [INFO] [stderr] | [INFO] [stderr] 21 | fn set(&mut self, address: u16, value: u8) { [INFO] [stderr] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_value` [INFO] [stderr] [INFO] [stderr] warning: unused variable: `config` [INFO] [stderr] --> src/debug/debug_logger.rs:34:31 [INFO] [stderr] | [INFO] [stderr] 34 | pub fn should_skip(&self, config: &Config, record: &Record<'_>) -> bool { [INFO] [stderr] | ^^^^^^ help: if this is intentional, prefix it with an underscore: `_config` [INFO] [stderr] [INFO] [stderr] warning: constant is never used: `INTERRUPT_ENABLE_REG` [INFO] [stderr] --> src/cpu.rs:22:1 [INFO] [stderr] | [INFO] [stderr] 22 | const INTERRUPT_ENABLE_REG: u16 = 0xFFFF; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(dead_code)]` on by default [INFO] [stderr] [INFO] [stderr] warning: constant is never used: `INTERRUPT_FLAG_REG` [INFO] [stderr] --> src/cpu.rs:23:1 [INFO] [stderr] | [INFO] [stderr] 23 | const INTERRUPT_FLAG_REG: u16 = 0xFF0F; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: constant is never used: `V_BLANK` [INFO] [stderr] --> src/cpu.rs:25:1 [INFO] [stderr] | [INFO] [stderr] 25 | const V_BLANK: u8 = 0x01; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: constant is never used: `LCD_STAT` [INFO] [stderr] --> src/cpu.rs:26:1 [INFO] [stderr] | [INFO] [stderr] 26 | const LCD_STAT: u8 = 0x02; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: constant is never used: `TIMER` [INFO] [stderr] --> src/cpu.rs:27:1 [INFO] [stderr] | [INFO] [stderr] 27 | const TIMER: u8 = 0x04; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: constant is never used: `SERIAL` [INFO] [stderr] --> src/cpu.rs:28:1 [INFO] [stderr] | [INFO] [stderr] 28 | const SERIAL: u8 = 0x08; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: constant is never used: `D_PAD` [INFO] [stderr] --> src/cpu.rs:29:1 [INFO] [stderr] | [INFO] [stderr] 29 | const D_PAD: u8 = 0x10; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never read: `last_serial` [INFO] [stderr] --> src/memory/mmu.rs:21:5 [INFO] [stderr] | [INFO] [stderr] 21 | last_serial: u8, [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never read: `horiz_blanking` [INFO] [stderr] --> src/ppu.rs:147:5 [INFO] [stderr] | [INFO] [stderr] 147 | horiz_blanking: bool, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: structure field `S` should have a snake case name [INFO] [stderr] --> src/cartridge/rtc.rs:22:5 [INFO] [stderr] | [INFO] [stderr] 22 | S: u8, [INFO] [stderr] | ^ help: convert the identifier to snake case (notice the capitalization): `s` [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(non_snake_case)]` on by default [INFO] [stderr] [INFO] [stderr] warning: structure field `M` should have a snake case name [INFO] [stderr] --> src/cartridge/rtc.rs:23:5 [INFO] [stderr] | [INFO] [stderr] 23 | M: u8, [INFO] [stderr] | ^ help: convert the identifier to snake case: `m` [INFO] [stderr] [INFO] [stderr] warning: structure field `H` should have a snake case name [INFO] [stderr] --> src/cartridge/rtc.rs:24:5 [INFO] [stderr] | [INFO] [stderr] 24 | H: u8, [INFO] [stderr] | ^ help: convert the identifier to snake case: `h` [INFO] [stderr] [INFO] [stderr] warning: structure field `DL` should have a snake case name [INFO] [stderr] --> src/cartridge/rtc.rs:25:5 [INFO] [stderr] | [INFO] [stderr] 25 | DL: u8, [INFO] [stderr] | ^^ help: convert the identifier to snake case: `dl` [INFO] [stderr] [INFO] [stderr] warning: structure field `DH` should have a snake case name [INFO] [stderr] --> src/cartridge/rtc.rs:26:5 [INFO] [stderr] | [INFO] [stderr] 26 | DH: u8, [INFO] [stderr] | ^^ help: convert the identifier to snake case: `dh` [INFO] [stderr] [INFO] [stderr] warning: 33 warnings emitted [INFO] [stderr] [INFO] [stderr] warning: unused import: `Error` [INFO] [stderr] --> src/cartridge/mbc3.rs:6:15 [INFO] [stderr] | [INFO] [stderr] 6 | use std::io::{Error, Read, Write}; [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(unused_imports)]` on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `Error` [INFO] [stderr] --> src/cartridge/rtc.rs:6:15 [INFO] [stderr] | [INFO] [stderr] 6 | use std::io::{Error, Write}; [INFO] [stderr] | ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `crate::debug::message::DebugMessage` [INFO] [stderr] --> src/debug.rs:7:5 [INFO] [stderr] | [INFO] [stderr] 7 | use crate::debug::message::DebugMessage; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `crate::emulator::Emulator` [INFO] [stderr] --> src/debug.rs:8:5 [INFO] [stderr] | [INFO] [stderr] 8 | use crate::emulator::Emulator; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused imports: `Receiver`, `TryRecvError` [INFO] [stderr] --> src/debug.rs:19:13 [INFO] [stderr] | [INFO] [stderr] 19 | use flume::{Receiver, TryRecvError}; [INFO] [stderr] | ^^^^^^^^ ^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused imports: `Builder`, `JoinHandle` [INFO] [stderr] --> src/debug.rs:20:19 [INFO] [stderr] | [INFO] [stderr] 20 | use std::thread::{Builder, JoinHandle}; [INFO] [stderr] | ^^^^^^^ ^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `crate::cpu::interrupt::Flag::Joypad` [INFO] [stderr] --> src/display.rs:1:5 [INFO] [stderr] | [INFO] [stderr] 1 | use crate::cpu::interrupt::Flag::Joypad; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `crate::cpu::registers::Flag` [INFO] [stderr] --> src/display/debug_canvas.rs:1:5 [INFO] [stderr] | [INFO] [stderr] 1 | use crate::cpu::registers::Flag; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused imports: `FB_H`, `FB_W` [INFO] [stderr] --> src/display/game_canvas.rs:1:34 [INFO] [stderr] | [INFO] [stderr] 1 | use crate::ppu::{PPUFramebuffer, FB_H, FB_W}; [INFO] [stderr] | ^^^^ ^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `piston_window::*` [INFO] [stderr] --> src/display/game_canvas.rs:2:5 [INFO] [stderr] | [INFO] [stderr] 2 | use piston_window::*; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `crate::cartridge::load_cartridge` [INFO] [stderr] --> src/emulator.rs:4:5 [INFO] [stderr] | [INFO] [stderr] 4 | use crate::cartridge::load_cartridge; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `crate::cpu::instruction::InstructionSet` [INFO] [stderr] --> src/emulator.rs:5:5 [INFO] [stderr] | [INFO] [stderr] 5 | use crate::cpu::instruction::InstructionSet; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `random_framebuffer` [INFO] [stderr] --> src/emulator.rs:10:18 [INFO] [stderr] | [INFO] [stderr] 10 | use crate::ppu::{random_framebuffer, Mode, PPUFramebuffer}; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::io` [INFO] [stderr] --> src/memory/mmu.rs:9:5 [INFO] [stderr] | [INFO] [stderr] 9 | use std::io; [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::io::Write` [INFO] [stderr] --> src/memory/mmu.rs:10:5 [INFO] [stderr] | [INFO] [stderr] 10 | use std::io::Write; [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/memory/mmu.rs:122:19 [INFO] [stderr] | [INFO] [stderr] 122 | 0x0000...0x7fff => { [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(ellipsis_inclusive_range_patterns)]` on by default [INFO] [stderr] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in the 2021 edition! [INFO] [stderr] = note: for more information, see issue #80165 [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/memory/mmu.rs:155:18 [INFO] [stderr] | [INFO] [stderr] 155 | 0xf40...0xff4b => self.ppu.borrow().get(address), [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] | [INFO] [stderr] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in the 2021 edition! [INFO] [stderr] = note: for more information, see issue #80165 [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/memory/mmu.rs:208:19 [INFO] [stderr] | [INFO] [stderr] 208 | 0xff80...0xfffe => self.high_ram[address as usize - 0xff80] = value, [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] | [INFO] [stderr] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in the 2021 edition! [INFO] [stderr] = note: for more information, see issue #80165 [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/ppu.rs:492:19 [INFO] [stderr] | [INFO] [stderr] 492 | 0xfe00...0xfe9f => self.oam[address as usize - 0xfe00], [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] | [INFO] [stderr] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in the 2021 edition! [INFO] [stderr] = note: for more information, see issue #80165 [INFO] [stderr] [INFO] [stderr] warning: unused import: `Path` [INFO] [stderr] --> src/save.rs:1:17 [INFO] [stderr] | [INFO] [stderr] 1 | use std::path::{Path, PathBuf}; [INFO] [stderr] | ^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused variable: `format` [INFO] [stderr] --> src/apu.rs:11:17 [INFO] [stderr] | [INFO] [stderr] 11 | let format = cpal::Format { [INFO] [stderr] | ^^^^^^ help: if this is intentional, prefix it with an underscore: `_format` [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(unused_variables)]` on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `address` [INFO] [stderr] --> src/cartridge/rom.rs:21:23 [INFO] [stderr] | [INFO] [stderr] 21 | fn set(&mut self, address: u16, value: u8) { [INFO] [stderr] | ^^^^^^^ help: if this is intentional, prefix it with an underscore: `_address` [INFO] [stderr] [INFO] [stderr] warning: unused variable: `value` [INFO] [stderr] --> src/cartridge/rom.rs:21:37 [INFO] [stderr] | [INFO] [stderr] 21 | fn set(&mut self, address: u16, value: u8) { [INFO] [stderr] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_value` [INFO] [stderr] [INFO] [stderr] warning: unused variable: `config` [INFO] [stderr] --> src/debug/debug_logger.rs:34:31 [INFO] [stderr] | [INFO] [stderr] 34 | pub fn should_skip(&self, config: &Config, record: &Record<'_>) -> bool { [INFO] [stderr] | ^^^^^^ help: if this is intentional, prefix it with an underscore: `_config` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/display.rs:90:25 [INFO] [stderr] | [INFO] [stderr] 90 | let mut key_pressed = match key { [INFO] [stderr] | ----^^^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(unused_mut)]` on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/display.rs:130:33 [INFO] [stderr] | [INFO] [stderr] 130 | ... let mut key_pressed = match key { [INFO] [stderr] | ----^^^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Serial` [INFO] [stderr] --> src/cpu/interrupt.rs:7:5 [INFO] [stderr] | [INFO] [stderr] 7 | Serial = 3, [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(dead_code)]` on by default [INFO] [stderr] [INFO] [stderr] warning: constant is never used: `INTERRUPT_ENABLE_REG` [INFO] [stderr] --> src/cpu.rs:22:1 [INFO] [stderr] | [INFO] [stderr] 22 | const INTERRUPT_ENABLE_REG: u16 = 0xFFFF; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: constant is never used: `INTERRUPT_FLAG_REG` [INFO] [stderr] --> src/cpu.rs:23:1 [INFO] [stderr] | [INFO] [stderr] 23 | const INTERRUPT_FLAG_REG: u16 = 0xFF0F; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: constant is never used: `V_BLANK` [INFO] [stderr] --> src/cpu.rs:25:1 [INFO] [stderr] | [INFO] [stderr] 25 | const V_BLANK: u8 = 0x01; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: constant is never used: `LCD_STAT` [INFO] [stderr] --> src/cpu.rs:26:1 [INFO] [stderr] | [INFO] [stderr] 26 | const LCD_STAT: u8 = 0x02; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: constant is never used: `TIMER` [INFO] [stderr] --> src/cpu.rs:27:1 [INFO] [stderr] | [INFO] [stderr] 27 | const TIMER: u8 = 0x04; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: constant is never used: `SERIAL` [INFO] [stderr] --> src/cpu.rs:28:1 [INFO] [stderr] | [INFO] [stderr] 28 | const SERIAL: u8 = 0x08; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: constant is never used: `D_PAD` [INFO] [stderr] --> src/cpu.rs:29:1 [INFO] [stderr] | [INFO] [stderr] 29 | const D_PAD: u8 = 0x10; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never read: `step_flip` [INFO] [stderr] --> src/cpu.rs:91:5 [INFO] [stderr] | [INFO] [stderr] 91 | step_flip: bool, // When this is set to true, we want to handle events [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: associated function is never used: `flip` [INFO] [stderr] --> src/cpu.rs:249:12 [INFO] [stderr] | [INFO] [stderr] 249 | pub fn flip(&mut self) -> bool { [INFO] [stderr] | ^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `PeekValue` [INFO] [stderr] --> src/debug/command.rs:3:5 [INFO] [stderr] | [INFO] [stderr] 3 | PeekValue(u16), [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `DebugCommand` [INFO] [stderr] --> src/debug/message.rs:8:5 [INFO] [stderr] | [INFO] [stderr] 8 | DebugCommand(DebugCommand), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: constant is never used: `FB_W` [INFO] [stderr] --> src/debug.rs:22:1 [INFO] [stderr] | [INFO] [stderr] 22 | pub const FB_W: usize = 160; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: constant is never used: `FB_H` [INFO] [stderr] --> src/debug.rs:23:1 [INFO] [stderr] | [INFO] [stderr] 23 | pub const FB_H: usize = 144; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `update_tile_canvas` [INFO] [stderr] --> src/display/debug_canvas.rs:161:8 [INFO] [stderr] | [INFO] [stderr] 161 | pub fn update_tile_canvas( [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: constant is never used: `PIXEL_COLOUR_STRIDE` [INFO] [stderr] --> src/display/debug_canvas.rs:189:5 [INFO] [stderr] | [INFO] [stderr] 189 | const PIXEL_COLOUR_STRIDE: usize = 4; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never read: `last_serial` [INFO] [stderr] --> src/memory/mmu.rs:21:5 [INFO] [stderr] | [INFO] [stderr] 21 | last_serial: u8, [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never read: `horiz_blanking` [INFO] [stderr] --> src/ppu.rs:147:5 [INFO] [stderr] | [INFO] [stderr] 147 | horiz_blanking: bool, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `random_framebuffer` [INFO] [stderr] --> src/ppu.rs:624:8 [INFO] [stderr] | [INFO] [stderr] 624 | pub fn random_framebuffer() -> PPUFramebuffer { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: structure field `S` should have a snake case name [INFO] [stderr] --> src/cartridge/rtc.rs:22:5 [INFO] [stderr] | [INFO] [stderr] 22 | S: u8, [INFO] [stderr] | ^ help: convert the identifier to snake case (notice the capitalization): `s` [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(non_snake_case)]` on by default [INFO] [stderr] [INFO] [stderr] warning: structure field `M` should have a snake case name [INFO] [stderr] --> src/cartridge/rtc.rs:23:5 [INFO] [stderr] | [INFO] [stderr] 23 | M: u8, [INFO] [stderr] | ^ help: convert the identifier to snake case: `m` [INFO] [stderr] [INFO] [stderr] warning: structure field `H` should have a snake case name [INFO] [stderr] --> src/cartridge/rtc.rs:24:5 [INFO] [stderr] | [INFO] [stderr] 24 | H: u8, [INFO] [stderr] | ^ help: convert the identifier to snake case: `h` [INFO] [stderr] [INFO] [stderr] warning: structure field `DL` should have a snake case name [INFO] [stderr] --> src/cartridge/rtc.rs:25:5 [INFO] [stderr] | [INFO] [stderr] 25 | DL: u8, [INFO] [stderr] | ^^ help: convert the identifier to snake case: `dl` [INFO] [stderr] [INFO] [stderr] warning: structure field `DH` should have a snake case name [INFO] [stderr] --> src/cartridge/rtc.rs:26:5 [INFO] [stderr] | [INFO] [stderr] 26 | DH: u8, [INFO] [stderr] | ^^ help: convert the identifier to snake case: `dh` [INFO] [stderr] [INFO] [stderr] warning: 50 warnings emitted [INFO] [stderr] [INFO] [stderr] warning: unused import: `Error` [INFO] [stderr] --> src/cartridge/mbc3.rs:6:15 [INFO] [stderr] | [INFO] [stderr] 6 | use std::io::{Error, Read, Write}; [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(unused_imports)]` on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `Error` [INFO] [stderr] --> src/cartridge/rtc.rs:6:15 [INFO] [stderr] | [INFO] [stderr] 6 | use std::io::{Error, Write}; [INFO] [stderr] | ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `crate::debug::message::DebugMessage` [INFO] [stderr] --> src/debug.rs:7:5 [INFO] [stderr] | [INFO] [stderr] 7 | use crate::debug::message::DebugMessage; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `crate::emulator::Emulator` [INFO] [stderr] --> src/debug.rs:8:5 [INFO] [stderr] | [INFO] [stderr] 8 | use crate::emulator::Emulator; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused imports: `Receiver`, `TryRecvError` [INFO] [stderr] --> src/debug.rs:19:13 [INFO] [stderr] | [INFO] [stderr] 19 | use flume::{Receiver, TryRecvError}; [INFO] [stderr] | ^^^^^^^^ ^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused imports: `Builder`, `JoinHandle` [INFO] [stderr] --> src/debug.rs:20:19 [INFO] [stderr] | [INFO] [stderr] 20 | use std::thread::{Builder, JoinHandle}; [INFO] [stderr] | ^^^^^^^ ^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `crate::cpu::interrupt::Flag::Joypad` [INFO] [stderr] --> src/display.rs:1:5 [INFO] [stderr] | [INFO] [stderr] 1 | use crate::cpu::interrupt::Flag::Joypad; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `crate::cpu::registers::Flag` [INFO] [stderr] --> src/display/debug_canvas.rs:1:5 [INFO] [stderr] | [INFO] [stderr] 1 | use crate::cpu::registers::Flag; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused imports: `FB_H`, `FB_W` [INFO] [stderr] --> src/display/game_canvas.rs:1:34 [INFO] [stderr] | [INFO] [stderr] 1 | use crate::ppu::{PPUFramebuffer, FB_H, FB_W}; [INFO] [stderr] | ^^^^ ^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `piston_window::*` [INFO] [stderr] --> src/display/game_canvas.rs:2:5 [INFO] [stderr] | [INFO] [stderr] 2 | use piston_window::*; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `crate::cartridge::load_cartridge` [INFO] [stderr] --> src/emulator.rs:4:5 [INFO] [stderr] | [INFO] [stderr] 4 | use crate::cartridge::load_cartridge; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `crate::cpu::instruction::InstructionSet` [INFO] [stderr] --> src/emulator.rs:5:5 [INFO] [stderr] | [INFO] [stderr] 5 | use crate::cpu::instruction::InstructionSet; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `random_framebuffer` [INFO] [stderr] --> src/emulator.rs:10:18 [INFO] [stderr] | [INFO] [stderr] 10 | use crate::ppu::{random_framebuffer, Mode, PPUFramebuffer}; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::io` [INFO] [stderr] --> src/memory/mmu.rs:9:5 [INFO] [stderr] | [INFO] [stderr] 9 | use std::io; [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::io::Write` [INFO] [stderr] --> src/memory/mmu.rs:10:5 [INFO] [stderr] | [INFO] [stderr] 10 | use std::io::Write; [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/memory/mmu.rs:122:19 [INFO] [stderr] | [INFO] [stderr] 122 | 0x0000...0x7fff => { [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(ellipsis_inclusive_range_patterns)]` on by default [INFO] [stderr] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in the 2021 edition! [INFO] [stderr] = note: for more information, see issue #80165 [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/memory/mmu.rs:155:18 [INFO] [stderr] | [INFO] [stderr] 155 | 0xf40...0xff4b => self.ppu.borrow().get(address), [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] | [INFO] [stderr] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in the 2021 edition! [INFO] [stderr] = note: for more information, see issue #80165 [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/memory/mmu.rs:208:19 [INFO] [stderr] | [INFO] [stderr] 208 | 0xff80...0xfffe => self.high_ram[address as usize - 0xff80] = value, [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] | [INFO] [stderr] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in the 2021 edition! [INFO] [stderr] = note: for more information, see issue #80165 [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/ppu.rs:492:19 [INFO] [stderr] | [INFO] [stderr] 492 | 0xfe00...0xfe9f => self.oam[address as usize - 0xfe00], [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] | [INFO] [stderr] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in the 2021 edition! [INFO] [stderr] = note: for more information, see issue #80165 [INFO] [stderr] [INFO] [stderr] warning: unused import: `Path` [INFO] [stderr] --> src/save.rs:1:17 [INFO] [stderr] | [INFO] [stderr] 1 | use std::path::{Path, PathBuf}; [INFO] [stderr] | ^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused variable: `format` [INFO] [stderr] --> src/apu.rs:11:17 [INFO] [stderr] | [INFO] [stderr] 11 | let format = cpal::Format { [INFO] [stderr] | ^^^^^^ help: if this is intentional, prefix it with an underscore: `_format` [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(unused_variables)]` on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `address` [INFO] [stderr] --> src/cartridge/rom.rs:21:23 [INFO] [stderr] | [INFO] [stderr] 21 | fn set(&mut self, address: u16, value: u8) { [INFO] [stderr] | ^^^^^^^ help: if this is intentional, prefix it with an underscore: `_address` [INFO] [stderr] [INFO] [stderr] warning: unused variable: `value` [INFO] [stderr] --> src/cartridge/rom.rs:21:37 [INFO] [stderr] | [INFO] [stderr] 21 | fn set(&mut self, address: u16, value: u8) { [INFO] [stderr] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_value` [INFO] [stderr] [INFO] [stderr] warning: unused variable: `config` [INFO] [stderr] --> src/debug/debug_logger.rs:34:31 [INFO] [stderr] | [INFO] [stderr] 34 | pub fn should_skip(&self, config: &Config, record: &Record<'_>) -> bool { [INFO] [stderr] | ^^^^^^ help: if this is intentional, prefix it with an underscore: `_config` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/display.rs:90:25 [INFO] [stderr] | [INFO] [stderr] 90 | let mut key_pressed = match key { [INFO] [stderr] | ----^^^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(unused_mut)]` on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/display.rs:130:33 [INFO] [stderr] | [INFO] [stderr] 130 | ... let mut key_pressed = match key { [INFO] [stderr] | ----^^^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Serial` [INFO] [stderr] --> src/cpu/interrupt.rs:7:5 [INFO] [stderr] | [INFO] [stderr] 7 | Serial = 3, [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(dead_code)]` on by default [INFO] [stderr] [INFO] [stderr] warning: constant is never used: `INTERRUPT_ENABLE_REG` [INFO] [stderr] --> src/cpu.rs:22:1 [INFO] [stderr] | [INFO] [stderr] 22 | const INTERRUPT_ENABLE_REG: u16 = 0xFFFF; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: constant is never used: `INTERRUPT_FLAG_REG` [INFO] [stderr] --> src/cpu.rs:23:1 [INFO] [stderr] | [INFO] [stderr] 23 | const INTERRUPT_FLAG_REG: u16 = 0xFF0F; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: constant is never used: `V_BLANK` [INFO] [stderr] --> src/cpu.rs:25:1 [INFO] [stderr] | [INFO] [stderr] 25 | const V_BLANK: u8 = 0x01; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: constant is never used: `LCD_STAT` [INFO] [stderr] --> src/cpu.rs:26:1 [INFO] [stderr] | [INFO] [stderr] 26 | const LCD_STAT: u8 = 0x02; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: constant is never used: `TIMER` [INFO] [stderr] --> src/cpu.rs:27:1 [INFO] [stderr] | [INFO] [stderr] 27 | const TIMER: u8 = 0x04; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: constant is never used: `SERIAL` [INFO] [stderr] --> src/cpu.rs:28:1 [INFO] [stderr] | [INFO] [stderr] 28 | const SERIAL: u8 = 0x08; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: constant is never used: `D_PAD` [INFO] [stderr] --> src/cpu.rs:29:1 [INFO] [stderr] | [INFO] [stderr] 29 | const D_PAD: u8 = 0x10; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never read: `step_flip` [INFO] [stderr] --> src/cpu.rs:91:5 [INFO] [stderr] | [INFO] [stderr] 91 | step_flip: bool, // When this is set to true, we want to handle events [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: associated function is never used: `flip` [INFO] [stderr] --> src/cpu.rs:249:12 [INFO] [stderr] | [INFO] [stderr] 249 | pub fn flip(&mut self) -> bool { [INFO] [stderr] | ^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `PeekValue` [INFO] [stderr] --> src/debug/command.rs:3:5 [INFO] [stderr] | [INFO] [stderr] 3 | PeekValue(u16), [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `DebugCommand` [INFO] [stderr] --> src/debug/message.rs:8:5 [INFO] [stderr] | [INFO] [stderr] 8 | DebugCommand(DebugCommand), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: constant is never used: `FB_W` [INFO] [stderr] --> src/debug.rs:22:1 [INFO] [stderr] | [INFO] [stderr] 22 | pub const FB_W: usize = 160; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: constant is never used: `FB_H` [INFO] [stderr] --> src/debug.rs:23:1 [INFO] [stderr] | [INFO] [stderr] 23 | pub const FB_H: usize = 144; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `update_tile_canvas` [INFO] [stderr] --> src/display/debug_canvas.rs:161:8 [INFO] [stderr] | [INFO] [stderr] 161 | pub fn update_tile_canvas( [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: constant is never used: `PIXEL_COLOUR_STRIDE` [INFO] [stderr] --> src/display/debug_canvas.rs:189:5 [INFO] [stderr] | [INFO] [stderr] 189 | const PIXEL_COLOUR_STRIDE: usize = 4; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never read: `last_serial` [INFO] [stderr] --> src/memory/mmu.rs:21:5 [INFO] [stderr] | [INFO] [stderr] 21 | last_serial: u8, [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never read: `horiz_blanking` [INFO] [stderr] --> src/ppu.rs:147:5 [INFO] [stderr] | [INFO] [stderr] 147 | horiz_blanking: bool, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `random_framebuffer` [INFO] [stderr] --> src/ppu.rs:624:8 [INFO] [stderr] | [INFO] [stderr] 624 | pub fn random_framebuffer() -> PPUFramebuffer { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: structure field `S` should have a snake case name [INFO] [stderr] --> src/cartridge/rtc.rs:22:5 [INFO] [stderr] | [INFO] [stderr] 22 | S: u8, [INFO] [stderr] | ^ help: convert the identifier to snake case (notice the capitalization): `s` [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(non_snake_case)]` on by default [INFO] [stderr] [INFO] [stderr] warning: structure field `M` should have a snake case name [INFO] [stderr] --> src/cartridge/rtc.rs:23:5 [INFO] [stderr] | [INFO] [stderr] 23 | M: u8, [INFO] [stderr] | ^ help: convert the identifier to snake case: `m` [INFO] [stderr] [INFO] [stderr] warning: structure field `H` should have a snake case name [INFO] [stderr] --> src/cartridge/rtc.rs:24:5 [INFO] [stderr] | [INFO] [stderr] 24 | H: u8, [INFO] [stderr] | ^ help: convert the identifier to snake case: `h` [INFO] [stderr] [INFO] [stderr] warning: structure field `DL` should have a snake case name [INFO] [stderr] --> src/cartridge/rtc.rs:25:5 [INFO] [stderr] | [INFO] [stderr] 25 | DL: u8, [INFO] [stderr] | ^^ help: convert the identifier to snake case: `dl` [INFO] [stderr] [INFO] [stderr] warning: structure field `DH` should have a snake case name [INFO] [stderr] --> src/cartridge/rtc.rs:26:5 [INFO] [stderr] | [INFO] [stderr] 26 | DH: u8, [INFO] [stderr] | ^^ help: convert the identifier to snake case: `dh` [INFO] [stderr] [INFO] [stderr] warning: 50 warnings emitted [INFO] [stderr] [INFO] [stderr] warning: unused import: `rgb::emulator::Emulator` [INFO] [stderr] --> tests/cpu_test.rs:3:5 [INFO] [stderr] | [INFO] [stderr] 3 | use rgb::emulator::Emulator; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(unused_imports)]` on by default [INFO] [stderr] [INFO] [stderr] warning: 1 warning emitted [INFO] [stderr] [INFO] [stderr] Finished test [unoptimized + debuginfo] target(s) in 0.17s [INFO] [stderr] Running unittests (/opt/rustwide/target/debug/deps/rgb-8af6cc43d8960c04) [INFO] [stderr] Running unittests (/opt/rustwide/target/debug/deps/rgb-dc1ebfcc113135ea) [INFO] [stdout] [INFO] [stdout] running 0 tests [INFO] [stdout] [INFO] [stdout] test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s [INFO] [stdout] [INFO] [stderr] Running tests/cpu_test.rs (/opt/rustwide/target/debug/deps/cpu_test-bb1a4ae6cfbe7c8a) [INFO] [stdout] [INFO] [stdout] running 0 tests [INFO] [stdout] [INFO] [stdout] test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] running 1 test [INFO] [stderr] error: test failed, to rerun pass '--test cpu_test' [INFO] [stdout] test run_cpu_tests ... FAILED [INFO] [stdout] [INFO] [stdout] failures: [INFO] [stdout] [INFO] [stdout] ---- run_cpu_tests stdout ---- [INFO] [stdout] thread 'run_cpu_tests' panicked at 'File not there: Os { code: 2, kind: NotFound, message: "No such file or directory" }', src/util/file.rs:4:46 [INFO] [stdout] stack backtrace: [INFO] [stdout] 0: 0x558603cffc10 - std::backtrace_rs::backtrace::libunwind::trace::h1037ca7e6eeef65c [INFO] [stdout] at /rustc/99e3aef02079e9c10583638520cd0c134dc3a01d/library/std/src/../../backtrace/src/backtrace/libunwind.rs:90:5 [INFO] [stdout] 1: 0x558603cffc10 - std::backtrace_rs::backtrace::trace_unsynchronized::haaefac1bc3669450 [INFO] [stdout] at /rustc/99e3aef02079e9c10583638520cd0c134dc3a01d/library/std/src/../../backtrace/src/backtrace/mod.rs:66:5 [INFO] [stdout] 2: 0x558603cffc10 - std::sys_common::backtrace::_print_fmt::h863a6f5e6d995885 [INFO] [stdout] at /rustc/99e3aef02079e9c10583638520cd0c134dc3a01d/library/std/src/sys_common/backtrace.rs:67:5 [INFO] [stdout] 3: 0x558603cffc10 - ::fmt::h767e17e1aa7df6a8 [INFO] [stdout] at /rustc/99e3aef02079e9c10583638520cd0c134dc3a01d/library/std/src/sys_common/backtrace.rs:46:22 [INFO] [stdout] 4: 0x558603d223cc - core::fmt::write::h7aa6cd0067dca82a [INFO] [stdout] at /rustc/99e3aef02079e9c10583638520cd0c134dc3a01d/library/core/src/fmt/mod.rs:1110:17 [INFO] [stdout] 5: 0x558603cfcbe5 - std::io::Write::write_fmt::h6f1a9b91376a1376 [INFO] [stdout] at /rustc/99e3aef02079e9c10583638520cd0c134dc3a01d/library/std/src/io/mod.rs:1584:15 [INFO] [stdout] 6: 0x558603d01d7b - std::sys_common::backtrace::_print::h2769edb26a7eb606 [INFO] [stdout] at /rustc/99e3aef02079e9c10583638520cd0c134dc3a01d/library/std/src/sys_common/backtrace.rs:49:5 [INFO] [stdout] 7: 0x558603d01d7b - std::sys_common::backtrace::print::ha71f3549862b4cb6 [INFO] [stdout] at /rustc/99e3aef02079e9c10583638520cd0c134dc3a01d/library/std/src/sys_common/backtrace.rs:36:9 [INFO] [stdout] 8: 0x558603d01d7b - std::panicking::default_hook::{{closure}}::h95488a3bade217f6 [INFO] [stdout] at /rustc/99e3aef02079e9c10583638520cd0c134dc3a01d/library/std/src/panicking.rs:208:50 [INFO] [stdout] 9: 0x558603d0188c - std::panicking::default_hook::h290aa602c0fb11df [INFO] [stdout] at /rustc/99e3aef02079e9c10583638520cd0c134dc3a01d/library/std/src/panicking.rs:222:9 [INFO] [stdout] 10: 0x558603d02421 - std::panicking::rust_panic_with_hook::hf32c4fa635e215f2 [INFO] [stdout] at /rustc/99e3aef02079e9c10583638520cd0c134dc3a01d/library/std/src/panicking.rs:622:17 [INFO] [stdout] 11: 0x558603d01f27 - std::panicking::begin_panic_handler::{{closure}}::h95197ccd88846f7a [INFO] [stdout] at /rustc/99e3aef02079e9c10583638520cd0c134dc3a01d/library/std/src/panicking.rs:519:13 [INFO] [stdout] 12: 0x558603d000ec - std::sys_common::backtrace::__rust_end_short_backtrace::h7641df9566f7b7d0 [INFO] [stdout] at /rustc/99e3aef02079e9c10583638520cd0c134dc3a01d/library/std/src/sys_common/backtrace.rs:141:18 [INFO] [stdout] 13: 0x558603d01e89 - rust_begin_unwind [INFO] [stdout] at /rustc/99e3aef02079e9c10583638520cd0c134dc3a01d/library/std/src/panicking.rs:515:5 [INFO] [stdout] 14: 0x558603c424b1 - core::panicking::panic_fmt::hbe99dddd3092ba3c [INFO] [stdout] at /rustc/99e3aef02079e9c10583638520cd0c134dc3a01d/library/core/src/panicking.rs:92:14 [INFO] [stdout] 15: 0x558603c425a3 - core::result::unwrap_failed::hf79563fef9d11ab8 [INFO] [stdout] at /rustc/99e3aef02079e9c10583638520cd0c134dc3a01d/library/core/src/result.rs:1355:5 [INFO] [stdout] 16: 0x558603cb25d0 - core::result::Result::expect::hb8443141186e033f [INFO] [stdout] at /rustc/99e3aef02079e9c10583638520cd0c134dc3a01d/library/core/src/result.rs:997:23 [INFO] [stdout] 17: 0x558603cb1670 - rgb::util::file::buffer_from_file::ha25b68e182f81958 [INFO] [stdout] at /opt/rustwide/workdir/src/util/file.rs:4:20 [INFO] [stdout] 18: 0x558603cb174a - rgb::util::get_rom::h56fed9edcd4c41ed [INFO] [stdout] at /opt/rustwide/workdir/src/util.rs:16:22 [INFO] [stdout] 19: 0x558603c443c4 - cpu_test::run_cpu_tests::h4ff5fcda5182d3a1 [INFO] [stdout] at /opt/rustwide/workdir/tests/cpu_test.rs:78:15 [INFO] [stdout] 20: 0x558603c4438a - cpu_test::run_cpu_tests::{{closure}}::h2e87f6f5dee582ed [INFO] [stdout] at /opt/rustwide/workdir/tests/cpu_test.rs:77:1 [INFO] [stdout] 21: 0x558603c4388e - core::ops::function::FnOnce::call_once::hb0192075bffff294 [INFO] [stdout] at /rustc/99e3aef02079e9c10583638520cd0c134dc3a01d/library/core/src/ops/function.rs:227:5 [INFO] [stdout] 22: 0x558603c6b213 - core::ops::function::FnOnce::call_once::h673fbe3f96486fd2 [INFO] [stdout] at /rustc/99e3aef02079e9c10583638520cd0c134dc3a01d/library/core/src/ops/function.rs:227:5 [INFO] [stdout] 23: 0x558603c6b213 - test::__rust_begin_short_backtrace::h8eedc24e104ef6a0 [INFO] [stdout] at /rustc/99e3aef02079e9c10583638520cd0c134dc3a01d/library/test/src/lib.rs:577:5 [INFO] [stdout] 24: 0x558603c69cc0 - as core::ops::function::FnOnce>::call_once::h028d0969d3f94d78 [INFO] [stdout] at /rustc/99e3aef02079e9c10583638520cd0c134dc3a01d/library/alloc/src/boxed.rs:1575:9 [INFO] [stdout] 25: 0x558603c69cc0 - as core::ops::function::FnOnce<()>>::call_once::h7634b01590b1722b [INFO] [stdout] at /rustc/99e3aef02079e9c10583638520cd0c134dc3a01d/library/std/src/panic.rs:346:9 [INFO] [stdout] 26: 0x558603c69cc0 - std::panicking::try::do_call::hf74f869706dec63b [INFO] [stdout] at /rustc/99e3aef02079e9c10583638520cd0c134dc3a01d/library/std/src/panicking.rs:401:40 [INFO] [stdout] 27: 0x558603c69cc0 - std::panicking::try::hd0b7346ebfaaae44 [INFO] [stdout] at /rustc/99e3aef02079e9c10583638520cd0c134dc3a01d/library/std/src/panicking.rs:365:19 [INFO] [stdout] 28: 0x558603c69cc0 - std::panic::catch_unwind::hdbf6904f7c253080 [INFO] [stdout] at /rustc/99e3aef02079e9c10583638520cd0c134dc3a01d/library/std/src/panic.rs:433:14 [INFO] [stdout] 29: 0x558603c69cc0 - test::run_test_in_process::h87e95a014ac91067 [INFO] [stdout] at /rustc/99e3aef02079e9c10583638520cd0c134dc3a01d/library/test/src/lib.rs:600:18 [INFO] [stdout] 30: 0x558603c69cc0 - test::run_test::run_test_inner::{{closure}}::hdd69ae44aaab3470 [INFO] [stdout] at /rustc/99e3aef02079e9c10583638520cd0c134dc3a01d/library/test/src/lib.rs:492:39 [INFO] [stdout] 31: 0x558603c44f92 - test::run_test::run_test_inner::{{closure}}::hc159305704d5b68a [INFO] [stdout] at /rustc/99e3aef02079e9c10583638520cd0c134dc3a01d/library/test/src/lib.rs:519:37 [INFO] [stdout] 32: 0x558603c44f92 - std::sys_common::backtrace::__rust_begin_short_backtrace::h33d8a8ad5f788fcc [INFO] [stdout] at /rustc/99e3aef02079e9c10583638520cd0c134dc3a01d/library/std/src/sys_common/backtrace.rs:125:18 [INFO] [stdout] 33: 0x558603c48d08 - std::thread::Builder::spawn_unchecked::{{closure}}::{{closure}}::h6181011ddf4b8353 [INFO] [stdout] at /rustc/99e3aef02079e9c10583638520cd0c134dc3a01d/library/std/src/thread/mod.rs:481:17 [INFO] [stdout] 34: 0x558603c48d08 - as core::ops::function::FnOnce<()>>::call_once::hf924ea0a0f25a1c0 [INFO] [stdout] at /rustc/99e3aef02079e9c10583638520cd0c134dc3a01d/library/std/src/panic.rs:346:9 [INFO] [stdout] 35: 0x558603c48d08 - std::panicking::try::do_call::hd58061792d05fa5c [INFO] [stdout] at /rustc/99e3aef02079e9c10583638520cd0c134dc3a01d/library/std/src/panicking.rs:401:40 [INFO] [stdout] 36: 0x558603c48d08 - std::panicking::try::h3080747417e5af37 [INFO] [stdout] at /rustc/99e3aef02079e9c10583638520cd0c134dc3a01d/library/std/src/panicking.rs:365:19 [INFO] [stdout] 37: 0x558603c48d08 - std::panic::catch_unwind::hfeba515dcf36cb66 [INFO] [stdout] at /rustc/99e3aef02079e9c10583638520cd0c134dc3a01d/library/std/src/panic.rs:433:14 [INFO] [stdout] 38: 0x558603c48d08 - std::thread::Builder::spawn_unchecked::{{closure}}::h29d57a62faff749b [INFO] [stdout] at /rustc/99e3aef02079e9c10583638520cd0c134dc3a01d/library/std/src/thread/mod.rs:480:30 [INFO] [stdout] 39: 0x558603c48d08 - core::ops::function::FnOnce::call_once{{vtable.shim}}::h44709d312d2a9c59 [INFO] [stdout] at /rustc/99e3aef02079e9c10583638520cd0c134dc3a01d/library/core/src/ops/function.rs:227:5 [INFO] [stdout] 40: 0x558603d06ed7 - as core::ops::function::FnOnce>::call_once::h902e2cf6655e1b0c [INFO] [stdout] at /rustc/99e3aef02079e9c10583638520cd0c134dc3a01d/library/alloc/src/boxed.rs:1575:9 [INFO] [stdout] 41: 0x558603d06ed7 - as core::ops::function::FnOnce>::call_once::h893a5452154309d1 [INFO] [stdout] at /rustc/99e3aef02079e9c10583638520cd0c134dc3a01d/library/alloc/src/boxed.rs:1575:9 [INFO] [stdout] 42: 0x558603d06ed7 - std::sys::unix::thread::Thread::new::thread_start::hdedcb57c96ab37cd [INFO] [stdout] at /rustc/99e3aef02079e9c10583638520cd0c134dc3a01d/library/std/src/sys/unix/thread.rs:71:17 [INFO] [stdout] 43: 0x7fa7bece6609 - start_thread [INFO] [stdout] 44: 0x7fa7beab8293 - clone [INFO] [stdout] 45: 0x0 - [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] failures: [INFO] [stdout] run_cpu_tests [INFO] [stdout] [INFO] [stdout] test result: FAILED. 0 passed; 1 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.02s [INFO] [stdout] [INFO] running `Command { std: "docker" "inspect" "b4b5adb42ccf08465df647b86a4f7cfbcd3451e8d333e70c398ba09a7eb3ef42", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "b4b5adb42ccf08465df647b86a4f7cfbcd3451e8d333e70c398ba09a7eb3ef42", kill_on_drop: false }` [INFO] [stdout] b4b5adb42ccf08465df647b86a4f7cfbcd3451e8d333e70c398ba09a7eb3ef42