[INFO] cloning repository https://github.com/christopherjmedlin/hackman [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/christopherjmedlin/hackman" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fchristopherjmedlin%2Fhackman", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fchristopherjmedlin%2Fhackman'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 116a625552d35f2f8a7bd06f69005ef7283238b0 [INFO] testing christopherjmedlin/hackman against master#99e3aef02079e9c10583638520cd0c134dc3a01d for pr-85530 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fchristopherjmedlin%2Fhackman" "/workspace/builds/worker-7/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-7/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/christopherjmedlin/hackman on toolchain 99e3aef02079e9c10583638520cd0c134dc3a01d [INFO] running `Command { std: "/workspace/cargo-home/bin/cargo" "+99e3aef02079e9c10583638520cd0c134dc3a01d" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/christopherjmedlin/hackman [INFO] finished tweaking git repo https://github.com/christopherjmedlin/hackman [INFO] tweaked toml for git repo https://github.com/christopherjmedlin/hackman written to /workspace/builds/worker-7/source/Cargo.toml [INFO] crate git repo https://github.com/christopherjmedlin/hackman already has a lockfile, it will not be regenerated [INFO] running `Command { std: "/workspace/cargo-home/bin/cargo" "+99e3aef02079e9c10583638520cd0c134dc3a01d" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:20528e8c29e4536546f0102ce88568b16ea7538393a33fcca951030f7af10457" "/opt/rustwide/cargo-home/bin/cargo" "+99e3aef02079e9c10583638520cd0c134dc3a01d" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 0b5f5381d338663a29ee58570eee7caa1e560d4920de19b8ab5c71e5e25d4df7 [INFO] running `Command { std: "docker" "start" "-a" "0b5f5381d338663a29ee58570eee7caa1e560d4920de19b8ab5c71e5e25d4df7", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "0b5f5381d338663a29ee58570eee7caa1e560d4920de19b8ab5c71e5e25d4df7", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "0b5f5381d338663a29ee58570eee7caa1e560d4920de19b8ab5c71e5e25d4df7", kill_on_drop: false }` [INFO] [stdout] 0b5f5381d338663a29ee58570eee7caa1e560d4920de19b8ab5c71e5e25d4df7 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:20528e8c29e4536546f0102ce88568b16ea7538393a33fcca951030f7af10457" "/opt/rustwide/cargo-home/bin/cargo" "+99e3aef02079e9c10583638520cd0c134dc3a01d" "build" "--frozen" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] c6fa350f10a816924f39d3277d0cdf0abcf96f918a0675699c4007a9ac97df66 [INFO] running `Command { std: "docker" "start" "-a" "c6fa350f10a816924f39d3277d0cdf0abcf96f918a0675699c4007a9ac97df66", kill_on_drop: false }` [INFO] [stderr] Compiling num-traits v0.2.6 [INFO] [stderr] Compiling libc v0.2.48 [INFO] [stderr] Compiling cfg-if v0.1.6 [INFO] [stderr] Compiling bitflags v0.7.0 [INFO] [stderr] Compiling sdl2-sys v0.31.0 [INFO] [stderr] Compiling rand v0.4.6 [INFO] [stderr] Compiling num-integer v0.1.39 [INFO] [stderr] Compiling rand v0.3.23 [INFO] [stderr] Compiling num-iter v0.1.37 [INFO] [stderr] Compiling num v0.1.42 [INFO] [stderr] Compiling sdl2 v0.31.0 [INFO] [stderr] Compiling pacman v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/cpu/mod.rs:49:22 [INFO] [stdout] | [INFO] [stdout] 49 | memory: &mut Memory, [INFO] [stdout] | ^^^^^^ help: use `dyn`: `dyn Memory` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(bare_trait_objects)]` on by default [INFO] [stdout] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in the 2021 edition! [INFO] [stdout] = note: for more information, see issue #80165 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/cpu/mod.rs:50:18 [INFO] [stdout] | [INFO] [stdout] 50 | io: &mut InputOutput, [INFO] [stdout] | ^^^^^^^^^^^ help: use `dyn`: `dyn InputOutput` [INFO] [stdout] | [INFO] [stdout] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in the 2021 edition! [INFO] [stdout] = note: for more information, see issue #80165 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/cpu/mod.rs:73:22 [INFO] [stdout] | [INFO] [stdout] 73 | memory: &mut Memory, [INFO] [stdout] | ^^^^^^ help: use `dyn`: `dyn Memory` [INFO] [stdout] | [INFO] [stdout] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in the 2021 edition! [INFO] [stdout] = note: for more information, see issue #80165 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/cpu/mod.rs:74:18 [INFO] [stdout] | [INFO] [stdout] 74 | io: &mut InputOutput, [INFO] [stdout] | ^^^^^^^^^^^ help: use `dyn`: `dyn InputOutput` [INFO] [stdout] | [INFO] [stdout] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in the 2021 edition! [INFO] [stdout] = note: for more information, see issue #80165 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `...` range patterns are deprecated [INFO] [stdout] --> src/cpu/mod.rs:134:18 [INFO] [stdout] | [INFO] [stdout] 134 | (0, 4...7, 0) => { [INFO] [stdout] | ^^^ help: use `..=` for an inclusive range [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(ellipsis_inclusive_range_patterns)]` on by default [INFO] [stdout] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in the 2021 edition! [INFO] [stdout] = note: for more information, see issue #80165 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/cpu/mod.rs:539:46 [INFO] [stdout] | [INFO] [stdout] 539 | fn run_cb_opcode(&mut self, memory: &mut Memory, io: &mut InputOutput, ext: bool) -> usize { [INFO] [stdout] | ^^^^^^ help: use `dyn`: `dyn Memory` [INFO] [stdout] | [INFO] [stdout] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in the 2021 edition! [INFO] [stdout] = note: for more information, see issue #80165 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/cpu/mod.rs:539:63 [INFO] [stdout] | [INFO] [stdout] 539 | fn run_cb_opcode(&mut self, memory: &mut Memory, io: &mut InputOutput, ext: bool) -> usize { [INFO] [stdout] | ^^^^^^^^^^^ help: use `dyn`: `dyn InputOutput` [INFO] [stdout] | [INFO] [stdout] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in the 2021 edition! [INFO] [stdout] = note: for more information, see issue #80165 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/cpu/mod.rs:626:58 [INFO] [stdout] | [INFO] [stdout] 626 | fn run_ed_opcode(&mut self, opcode: u8, memory: &mut Memory, io: &mut InputOutput) -> usize { [INFO] [stdout] | ^^^^^^ help: use `dyn`: `dyn Memory` [INFO] [stdout] | [INFO] [stdout] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in the 2021 edition! [INFO] [stdout] = note: for more information, see issue #80165 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/cpu/mod.rs:626:75 [INFO] [stdout] | [INFO] [stdout] 626 | fn run_ed_opcode(&mut self, opcode: u8, memory: &mut Memory, io: &mut InputOutput) -> usize { [INFO] [stdout] | ^^^^^^^^^^^ help: use `dyn`: `dyn InputOutput` [INFO] [stdout] | [INFO] [stdout] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in the 2021 edition! [INFO] [stdout] = note: for more information, see issue #80165 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `...` range patterns are deprecated [INFO] [stdout] --> src/cpu/mod.rs:782:21 [INFO] [stdout] | [INFO] [stdout] 782 | (2, _, 0...3) => { [INFO] [stdout] | ^^^ help: use `..=` for an inclusive range [INFO] [stdout] | [INFO] [stdout] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in the 2021 edition! [INFO] [stdout] = note: for more information, see issue #80165 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/cpu/mod.rs:792:42 [INFO] [stdout] | [INFO] [stdout] 792 | fn r(&mut self, index: u8, mem: &mut Memory) -> u8 { [INFO] [stdout] | ^^^^^^ help: use `dyn`: `dyn Memory` [INFO] [stdout] | [INFO] [stdout] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in the 2021 edition! [INFO] [stdout] = note: for more information, see issue #80165 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/cpu/mod.rs:800:58 [INFO] [stdout] | [INFO] [stdout] 800 | fn write_r(&mut self, index: u8, byte: u8, mem: &mut Memory) { [INFO] [stdout] | ^^^^^^ help: use `dyn`: `dyn Memory` [INFO] [stdout] | [INFO] [stdout] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in the 2021 edition! [INFO] [stdout] = note: for more information, see issue #80165 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/cpu/mod.rs:808:47 [INFO] [stdout] | [INFO] [stdout] 808 | fn bli(&mut self, a: u8, b: u8, mem: &mut Memory, io: &mut InputOutput) { [INFO] [stdout] | ^^^^^^ help: use `dyn`: `dyn Memory` [INFO] [stdout] | [INFO] [stdout] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in the 2021 edition! [INFO] [stdout] = note: for more information, see issue #80165 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/cpu/mod.rs:808:64 [INFO] [stdout] | [INFO] [stdout] 808 | fn bli(&mut self, a: u8, b: u8, mem: &mut Memory, io: &mut InputOutput) { [INFO] [stdout] | ^^^^^^^^^^^ help: use `dyn`: `dyn InputOutput` [INFO] [stdout] | [INFO] [stdout] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in the 2021 edition! [INFO] [stdout] = note: for more information, see issue #80165 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/cpu/mod.rs:952:42 [INFO] [stdout] | [INFO] [stdout] 952 | fn load_inc_dec(&mut self, mem: &mut Memory, inc: bool) { [INFO] [stdout] | ^^^^^^ help: use `dyn`: `dyn Memory` [INFO] [stdout] | [INFO] [stdout] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in the 2021 edition! [INFO] [stdout] = note: for more information, see issue #80165 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/cpu/mod.rs:974:42 [INFO] [stdout] | [INFO] [stdout] 974 | fn comp_inc_dec(&mut self, mem: &mut Memory, inc: bool) { [INFO] [stdout] | ^^^^^^ help: use `dyn`: `dyn Memory` [INFO] [stdout] | [INFO] [stdout] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in the 2021 edition! [INFO] [stdout] = note: for more information, see issue #80165 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/cpu/mod.rs:1274:42 [INFO] [stdout] | [INFO] [stdout] 1274 | fn dec_8(&mut self, y: u8, mem: &mut Memory) { [INFO] [stdout] | ^^^^^^ help: use `dyn`: `dyn Memory` [INFO] [stdout] | [INFO] [stdout] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in the 2021 edition! [INFO] [stdout] = note: for more information, see issue #80165 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/cpu/mod.rs:1288:42 [INFO] [stdout] | [INFO] [stdout] 1288 | fn inc_8(&mut self, y: u8, mem: &mut Memory) { [INFO] [stdout] | ^^^^^^ help: use `dyn`: `dyn Memory` [INFO] [stdout] | [INFO] [stdout] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in the 2021 edition! [INFO] [stdout] = note: for more information, see issue #80165 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/cpu/mod.rs:1303:34 [INFO] [stdout] | [INFO] [stdout] 1303 | fn call(&mut self, mem: &mut Memory, addr: u16) { [INFO] [stdout] | ^^^^^^ help: use `dyn`: `dyn Memory` [INFO] [stdout] | [INFO] [stdout] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in the 2021 edition! [INFO] [stdout] = note: for more information, see issue #80165 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/cpu/mod.rs:1310:33 [INFO] [stdout] | [INFO] [stdout] 1310 | fn ret(&mut self, mem: &mut Memory) { [INFO] [stdout] | ^^^^^^ help: use `dyn`: `dyn Memory` [INFO] [stdout] | [INFO] [stdout] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in the 2021 edition! [INFO] [stdout] = note: for more information, see issue #80165 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/cpu/mod.rs:1316:39 [INFO] [stdout] | [INFO] [stdout] 1316 | fn pop_stack(&mut self, mem: &mut Memory) -> u8 { [INFO] [stdout] | ^^^^^^ help: use `dyn`: `dyn Memory` [INFO] [stdout] | [INFO] [stdout] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in the 2021 edition! [INFO] [stdout] = note: for more information, see issue #80165 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/cpu/mod.rs:1324:40 [INFO] [stdout] | [INFO] [stdout] 1324 | fn push_stack(&mut self, mem: &mut Memory, byte: u8) { [INFO] [stdout] | ^^^^^^ help: use `dyn`: `dyn Memory` [INFO] [stdout] | [INFO] [stdout] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in the 2021 edition! [INFO] [stdout] = note: for more information, see issue #80165 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/cpu/mod.rs:1333:43 [INFO] [stdout] | [INFO] [stdout] 1333 | fn push_stack_16(&mut self, mem: &mut Memory, word: u16) { [INFO] [stdout] | ^^^^^^ help: use `dyn`: `dyn Memory` [INFO] [stdout] | [INFO] [stdout] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in the 2021 edition! [INFO] [stdout] = note: for more information, see issue #80165 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/cpu/mod.rs:1338:42 [INFO] [stdout] | [INFO] [stdout] 1338 | fn pop_stack_16(&mut self, mem: &mut Memory) -> u16 { [INFO] [stdout] | ^^^^^^ help: use `dyn`: `dyn Memory` [INFO] [stdout] | [INFO] [stdout] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in the 2021 edition! [INFO] [stdout] = note: for more information, see issue #80165 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `...` range patterns are deprecated [INFO] [stdout] --> src/memory_map.rs:74:24 [INFO] [stdout] | [INFO] [stdout] 74 | (GAME_ROM_START...GAME_ROM_END, false) => { [INFO] [stdout] | ^^^ help: use `..=` for an inclusive range [INFO] [stdout] | [INFO] [stdout] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in the 2021 edition! [INFO] [stdout] = note: for more information, see issue #80165 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `...` range patterns are deprecated [INFO] [stdout] --> src/memory_map.rs:78:24 [INFO] [stdout] | [INFO] [stdout] 78 | (GAME_ROM_START...GAME_ROM_END, true) => Err("Cannot write to ROM."), [INFO] [stdout] | ^^^ help: use `..=` for an inclusive range [INFO] [stdout] | [INFO] [stdout] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in the 2021 edition! [INFO] [stdout] = note: for more information, see issue #80165 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `...` range patterns are deprecated [INFO] [stdout] --> src/memory_map.rs:80:26 [INFO] [stdout] | [INFO] [stdout] 80 | (VRAM_TILES_START...VRAM_TILES_END, _) => { [INFO] [stdout] | ^^^ help: use `..=` for an inclusive range [INFO] [stdout] | [INFO] [stdout] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in the 2021 edition! [INFO] [stdout] = note: for more information, see issue #80165 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `...` range patterns are deprecated [INFO] [stdout] --> src/memory_map.rs:84:29 [INFO] [stdout] | [INFO] [stdout] 84 | (VRAM_PALETTES_START...VRAM_PALETTES_END, _) => { [INFO] [stdout] | ^^^ help: use `..=` for an inclusive range [INFO] [stdout] | [INFO] [stdout] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in the 2021 edition! [INFO] [stdout] = note: for more information, see issue #80165 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `...` range patterns are deprecated [INFO] [stdout] --> src/memory_map.rs:88:19 [INFO] [stdout] | [INFO] [stdout] 88 | (RAM_START...RAM_END, _) => Ok(Address::Ram((addr - RAM_START) as usize)), [INFO] [stdout] | ^^^ help: use `..=` for an inclusive range [INFO] [stdout] | [INFO] [stdout] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in the 2021 edition! [INFO] [stdout] = note: for more information, see issue #80165 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `...` range patterns are deprecated [INFO] [stdout] --> src/memory_map.rs:90:28 [INFO] [stdout] | [INFO] [stdout] 90 | (VRAM_SPRITES_START...VRAM_SPRITES_END, _) => { [INFO] [stdout] | ^^^ help: use `..=` for an inclusive range [INFO] [stdout] | [INFO] [stdout] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in the 2021 edition! [INFO] [stdout] = note: for more information, see issue #80165 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `...` range patterns are deprecated [INFO] [stdout] --> src/memory_map.rs:94:28 [INFO] [stdout] | [INFO] [stdout] 94 | (IN0_REGISTER_START...IN0_REGISTER_END, false) => Ok(Address::IN0Register), [INFO] [stdout] | ^^^ help: use `..=` for an inclusive range [INFO] [stdout] | [INFO] [stdout] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in the 2021 edition! [INFO] [stdout] = note: for more information, see issue #80165 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `...` range patterns are deprecated [INFO] [stdout] --> src/memory_map.rs:105:28 [INFO] [stdout] | [INFO] [stdout] 105 | (IN1_REGISTER_START...IN1_REGISTER_END, false) => Ok(Address::IN1Register), [INFO] [stdout] | ^^^ help: use `..=` for an inclusive range [INFO] [stdout] | [INFO] [stdout] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in the 2021 edition! [INFO] [stdout] = note: for more information, see issue #80165 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `...` range patterns are deprecated [INFO] [stdout] --> src/memory_map.rs:107:21 [INFO] [stdout] | [INFO] [stdout] 107 | (SOUND_START...SOUND_END, true) => Ok(Address::Sound((addr - SOUND_START) as usize)), [INFO] [stdout] | ^^^ help: use `..=` for an inclusive range [INFO] [stdout] | [INFO] [stdout] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in the 2021 edition! [INFO] [stdout] = note: for more information, see issue #80165 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `...` range patterns are deprecated [INFO] [stdout] --> src/memory_map.rs:109:25 [INFO] [stdout] | [INFO] [stdout] 109 | (SPRITE_XY_START...SPRITE_XY_END, true) => { [INFO] [stdout] | ^^^ help: use `..=` for an inclusive range [INFO] [stdout] | [INFO] [stdout] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in the 2021 edition! [INFO] [stdout] = note: for more information, see issue #80165 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `...` range patterns are deprecated [INFO] [stdout] --> src/memory_map.rs:113:26 [INFO] [stdout] | [INFO] [stdout] 113 | (DIP_SWITCH_START...DIP_SWITCH_END, _) => Ok(Address::DipSwitchRegister), [INFO] [stdout] | ^^^ help: use `..=` for an inclusive range [INFO] [stdout] | [INFO] [stdout] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in the 2021 edition! [INFO] [stdout] = note: for more information, see issue #80165 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `...` range patterns are deprecated [INFO] [stdout] --> src/memory_map.rs:115:24 [INFO] [stdout] | [INFO] [stdout] 115 | (WATCHDOG_START...WATCHDOG_END, _) => Ok(Address::WatchdogTimerReset), [INFO] [stdout] | ^^^ help: use `..=` for an inclusive range [INFO] [stdout] | [INFO] [stdout] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in the 2021 edition! [INFO] [stdout] = note: for more information, see issue #80165 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `super::*` [INFO] [stdout] --> src/memory_mapper.rs:68:9 [INFO] [stdout] | [INFO] [stdout] 68 | use super::*; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::boxed::Box` [INFO] [stdout] --> src/memory_mapper.rs:69:9 [INFO] [stdout] | [INFO] [stdout] 69 | use std::boxed::Box; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: denote infinite loops with `loop { ... }` [INFO] [stdout] --> src/pacman.rs:79:9 [INFO] [stdout] | [INFO] [stdout] 79 | while true { [INFO] [stdout] | ^^^^^^^^^^ help: use `loop` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(while_true)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `#[macro_use]` import [INFO] [stdout] --> src/main.rs:9:13 [INFO] [stdout] | [INFO] [stdout] 9 | #[macro_use(matches)] [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unreachable pattern [INFO] [stdout] --> src/cpu/mod.rs:912:13 [INFO] [stdout] | [INFO] [stdout] 912 | (5, 2) => { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unreachable_patterns)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unreachable pattern [INFO] [stdout] --> src/cpu/mod.rs:919:13 [INFO] [stdout] | [INFO] [stdout] 919 | (6, 2) => { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unreachable pattern [INFO] [stdout] --> src/cpu/mod.rs:933:13 [INFO] [stdout] | [INFO] [stdout] 933 | (7, 2) => { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `i` [INFO] [stdout] --> src/cpu/mod.rs:57:13 [INFO] [stdout] | [INFO] [stdout] 57 | for i in 0..iters { [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_i` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `io` [INFO] [stdout] --> src/cpu/mod.rs:539:54 [INFO] [stdout] | [INFO] [stdout] 539 | fn run_cb_opcode(&mut self, memory: &mut Memory, io: &mut InputOutput, ext: bool) -> usize { [INFO] [stdout] | ^^ help: if this is intentional, prefix it with an underscore: `_io` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `number_of_ones` is assigned to, but never used [INFO] [stdout] --> src/cpu/mod.rs:1381:17 [INFO] [stdout] | [INFO] [stdout] 1381 | let mut number_of_ones = 0; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: consider using `_number_of_ones` instead [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `port` [INFO] [stdout] --> src/cpu/io.rs:21:21 [INFO] [stdout] | [INFO] [stdout] 21 | fn input(&self, port: u8) -> u8 { [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_port` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `port` [INFO] [stdout] --> src/cpu/io.rs:25:26 [INFO] [stdout] | [INFO] [stdout] 25 | fn output(&mut self, port: u8, byte: u8) { [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_port` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `result` [INFO] [stdout] --> src/display.rs:49:21 [INFO] [stdout] | [INFO] [stdout] 49 | let result = canvas.fill_rect(Rect::new(x_coord, y_coord, 2, 2)); [INFO] [stdout] | ^^^^^^ help: if this is intentional, prefix it with an underscore: `_result` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `x_flip` [INFO] [stdout] --> src/display.rs:62:9 [INFO] [stdout] | [INFO] [stdout] 62 | x_flip: bool, [INFO] [stdout] | ^^^^^^ help: if this is intentional, prefix it with an underscore: `_x_flip` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `y_flip` [INFO] [stdout] --> src/display.rs:63:9 [INFO] [stdout] | [INFO] [stdout] 63 | y_flip: bool, [INFO] [stdout] | ^^^^^^ help: if this is intentional, prefix it with an underscore: `_y_flip` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `port` [INFO] [stdout] --> src/interrupt_vector.rs:14:21 [INFO] [stdout] | [INFO] [stdout] 14 | fn input(&self, port: u8) -> u8 { [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_port` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `port` [INFO] [stdout] --> src/interrupt_vector.rs:18:26 [INFO] [stdout] | [INFO] [stdout] 18 | fn output(&mut self, port: u8, byte: u8) { [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_port` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `color` [INFO] [stdout] --> src/rom.rs:104:17 [INFO] [stdout] | [INFO] [stdout] 104 | let color = self.color_rom[*byte as usize]; [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_color` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `why` [INFO] [stdout] --> src/rom.rs:137:17 [INFO] [stdout] | [INFO] [stdout] 137 | Err(why) => panic!("Missing ROMs"), [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_why` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `why` [INFO] [stdout] --> src/rom.rs:142:17 [INFO] [stdout] | [INFO] [stdout] 142 | Err(why) => panic!("Error reading ROM"), [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_why` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/cpu/mod.rs:1145:13 [INFO] [stdout] | [INFO] [stdout] 1145 | let mut result = left.wrapping_sub(right); [INFO] [stdout] | ----^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/cpu/mod.rs:1347:13 [INFO] [stdout] | [INFO] [stdout] 1347 | let mut left = left + (carry as u8); [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/cpu/mod.rs:1354:13 [INFO] [stdout] | [INFO] [stdout] 1354 | let mut left = left - (carry as u8); [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated function is never used: `new` [INFO] [stdout] --> src/cpu/io.rs:15:12 [INFO] [stdout] | [INFO] [stdout] 15 | pub fn new() -> Self { [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated function is never used: `new` [INFO] [stdout] --> src/cpu/mem.rs:26:12 [INFO] [stdout] | [INFO] [stdout] 26 | pub fn new() -> Self { [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated function is never used: `draw_sprite` [INFO] [stdout] --> src/display.rs:30:12 [INFO] [stdout] | [INFO] [stdout] 30 | pub fn draw_sprite(&mut self, x: usize, y: usize, sprite: usize, palette: usize) { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant is never constructed: `VramPalettes` [INFO] [stdout] --> src/memory_map.rs:46:5 [INFO] [stdout] | [INFO] [stdout] 46 | VramPalettes(usize), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field is never read: `roms` [INFO] [stdout] --> src/pacman.rs:13:5 [INFO] [stdout] | [INFO] [stdout] 13 | roms: &'a Box, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 64 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 7.50s [INFO] running `Command { std: "docker" "inspect" "c6fa350f10a816924f39d3277d0cdf0abcf96f918a0675699c4007a9ac97df66", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "c6fa350f10a816924f39d3277d0cdf0abcf96f918a0675699c4007a9ac97df66", kill_on_drop: false }` [INFO] [stdout] c6fa350f10a816924f39d3277d0cdf0abcf96f918a0675699c4007a9ac97df66 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:20528e8c29e4536546f0102ce88568b16ea7538393a33fcca951030f7af10457" "/opt/rustwide/cargo-home/bin/cargo" "+99e3aef02079e9c10583638520cd0c134dc3a01d" "test" "--frozen" "--no-run" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 0cba89fe8d2849acde882925e8452640d66148b567429b53aee4708d9a803ca0 [INFO] running `Command { std: "docker" "start" "-a" "0cba89fe8d2849acde882925e8452640d66148b567429b53aee4708d9a803ca0", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Compiling pacman v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/cpu/mod.rs:49:22 [INFO] [stdout] | [INFO] [stdout] 49 | memory: &mut Memory, [INFO] [stdout] | ^^^^^^ help: use `dyn`: `dyn Memory` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(bare_trait_objects)]` on by default [INFO] [stdout] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in the 2021 edition! [INFO] [stdout] = note: for more information, see issue #80165 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/cpu/mod.rs:50:18 [INFO] [stdout] | [INFO] [stdout] 50 | io: &mut InputOutput, [INFO] [stdout] | ^^^^^^^^^^^ help: use `dyn`: `dyn InputOutput` [INFO] [stdout] | [INFO] [stdout] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in the 2021 edition! [INFO] [stdout] = note: for more information, see issue #80165 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/cpu/mod.rs:73:22 [INFO] [stdout] | [INFO] [stdout] 73 | memory: &mut Memory, [INFO] [stdout] | ^^^^^^ help: use `dyn`: `dyn Memory` [INFO] [stdout] | [INFO] [stdout] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in the 2021 edition! [INFO] [stdout] = note: for more information, see issue #80165 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/cpu/mod.rs:74:18 [INFO] [stdout] | [INFO] [stdout] 74 | io: &mut InputOutput, [INFO] [stdout] | ^^^^^^^^^^^ help: use `dyn`: `dyn InputOutput` [INFO] [stdout] | [INFO] [stdout] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in the 2021 edition! [INFO] [stdout] = note: for more information, see issue #80165 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `...` range patterns are deprecated [INFO] [stdout] --> src/cpu/mod.rs:134:18 [INFO] [stdout] | [INFO] [stdout] 134 | (0, 4...7, 0) => { [INFO] [stdout] | ^^^ help: use `..=` for an inclusive range [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(ellipsis_inclusive_range_patterns)]` on by default [INFO] [stdout] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in the 2021 edition! [INFO] [stdout] = note: for more information, see issue #80165 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/cpu/mod.rs:539:46 [INFO] [stdout] | [INFO] [stdout] 539 | fn run_cb_opcode(&mut self, memory: &mut Memory, io: &mut InputOutput, ext: bool) -> usize { [INFO] [stdout] | ^^^^^^ help: use `dyn`: `dyn Memory` [INFO] [stdout] | [INFO] [stdout] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in the 2021 edition! [INFO] [stdout] = note: for more information, see issue #80165 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/cpu/mod.rs:539:63 [INFO] [stdout] | [INFO] [stdout] 539 | fn run_cb_opcode(&mut self, memory: &mut Memory, io: &mut InputOutput, ext: bool) -> usize { [INFO] [stdout] | ^^^^^^^^^^^ help: use `dyn`: `dyn InputOutput` [INFO] [stdout] | [INFO] [stdout] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in the 2021 edition! [INFO] [stdout] = note: for more information, see issue #80165 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/cpu/mod.rs:626:58 [INFO] [stdout] | [INFO] [stdout] 626 | fn run_ed_opcode(&mut self, opcode: u8, memory: &mut Memory, io: &mut InputOutput) -> usize { [INFO] [stdout] | ^^^^^^ help: use `dyn`: `dyn Memory` [INFO] [stdout] | [INFO] [stdout] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in the 2021 edition! [INFO] [stdout] = note: for more information, see issue #80165 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/cpu/mod.rs:626:75 [INFO] [stdout] | [INFO] [stdout] 626 | fn run_ed_opcode(&mut self, opcode: u8, memory: &mut Memory, io: &mut InputOutput) -> usize { [INFO] [stdout] | ^^^^^^^^^^^ help: use `dyn`: `dyn InputOutput` [INFO] [stdout] | [INFO] [stdout] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in the 2021 edition! [INFO] [stdout] = note: for more information, see issue #80165 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `...` range patterns are deprecated [INFO] [stdout] --> src/cpu/mod.rs:782:21 [INFO] [stdout] | [INFO] [stdout] 782 | (2, _, 0...3) => { [INFO] [stdout] | ^^^ help: use `..=` for an inclusive range [INFO] [stdout] | [INFO] [stdout] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in the 2021 edition! [INFO] [stdout] = note: for more information, see issue #80165 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/cpu/mod.rs:792:42 [INFO] [stdout] | [INFO] [stdout] 792 | fn r(&mut self, index: u8, mem: &mut Memory) -> u8 { [INFO] [stdout] | ^^^^^^ help: use `dyn`: `dyn Memory` [INFO] [stdout] | [INFO] [stdout] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in the 2021 edition! [INFO] [stdout] = note: for more information, see issue #80165 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/cpu/mod.rs:800:58 [INFO] [stdout] | [INFO] [stdout] 800 | fn write_r(&mut self, index: u8, byte: u8, mem: &mut Memory) { [INFO] [stdout] | ^^^^^^ help: use `dyn`: `dyn Memory` [INFO] [stdout] | [INFO] [stdout] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in the 2021 edition! [INFO] [stdout] = note: for more information, see issue #80165 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/cpu/mod.rs:808:47 [INFO] [stdout] | [INFO] [stdout] 808 | fn bli(&mut self, a: u8, b: u8, mem: &mut Memory, io: &mut InputOutput) { [INFO] [stdout] | ^^^^^^ help: use `dyn`: `dyn Memory` [INFO] [stdout] | [INFO] [stdout] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in the 2021 edition! [INFO] [stdout] = note: for more information, see issue #80165 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/cpu/mod.rs:808:64 [INFO] [stdout] | [INFO] [stdout] 808 | fn bli(&mut self, a: u8, b: u8, mem: &mut Memory, io: &mut InputOutput) { [INFO] [stdout] | ^^^^^^^^^^^ help: use `dyn`: `dyn InputOutput` [INFO] [stdout] | [INFO] [stdout] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in the 2021 edition! [INFO] [stdout] = note: for more information, see issue #80165 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/cpu/mod.rs:952:42 [INFO] [stdout] | [INFO] [stdout] 952 | fn load_inc_dec(&mut self, mem: &mut Memory, inc: bool) { [INFO] [stdout] | ^^^^^^ help: use `dyn`: `dyn Memory` [INFO] [stdout] | [INFO] [stdout] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in the 2021 edition! [INFO] [stdout] = note: for more information, see issue #80165 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/cpu/mod.rs:974:42 [INFO] [stdout] | [INFO] [stdout] 974 | fn comp_inc_dec(&mut self, mem: &mut Memory, inc: bool) { [INFO] [stdout] | ^^^^^^ help: use `dyn`: `dyn Memory` [INFO] [stdout] | [INFO] [stdout] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in the 2021 edition! [INFO] [stdout] = note: for more information, see issue #80165 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/cpu/mod.rs:1274:42 [INFO] [stdout] | [INFO] [stdout] 1274 | fn dec_8(&mut self, y: u8, mem: &mut Memory) { [INFO] [stdout] | ^^^^^^ help: use `dyn`: `dyn Memory` [INFO] [stdout] | [INFO] [stdout] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in the 2021 edition! [INFO] [stdout] = note: for more information, see issue #80165 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/cpu/mod.rs:1288:42 [INFO] [stdout] | [INFO] [stdout] 1288 | fn inc_8(&mut self, y: u8, mem: &mut Memory) { [INFO] [stdout] | ^^^^^^ help: use `dyn`: `dyn Memory` [INFO] [stdout] | [INFO] [stdout] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in the 2021 edition! [INFO] [stdout] = note: for more information, see issue #80165 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/cpu/mod.rs:1303:34 [INFO] [stdout] | [INFO] [stdout] 1303 | fn call(&mut self, mem: &mut Memory, addr: u16) { [INFO] [stdout] | ^^^^^^ help: use `dyn`: `dyn Memory` [INFO] [stdout] | [INFO] [stdout] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in the 2021 edition! [INFO] [stdout] = note: for more information, see issue #80165 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/cpu/mod.rs:1310:33 [INFO] [stdout] | [INFO] [stdout] 1310 | fn ret(&mut self, mem: &mut Memory) { [INFO] [stdout] | ^^^^^^ help: use `dyn`: `dyn Memory` [INFO] [stdout] | [INFO] [stdout] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in the 2021 edition! [INFO] [stdout] = note: for more information, see issue #80165 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/cpu/mod.rs:1316:39 [INFO] [stdout] | [INFO] [stdout] 1316 | fn pop_stack(&mut self, mem: &mut Memory) -> u8 { [INFO] [stdout] | ^^^^^^ help: use `dyn`: `dyn Memory` [INFO] [stdout] | [INFO] [stdout] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in the 2021 edition! [INFO] [stdout] = note: for more information, see issue #80165 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/cpu/mod.rs:1324:40 [INFO] [stdout] | [INFO] [stdout] 1324 | fn push_stack(&mut self, mem: &mut Memory, byte: u8) { [INFO] [stdout] | ^^^^^^ help: use `dyn`: `dyn Memory` [INFO] [stdout] | [INFO] [stdout] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in the 2021 edition! [INFO] [stdout] = note: for more information, see issue #80165 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/cpu/mod.rs:1333:43 [INFO] [stdout] | [INFO] [stdout] 1333 | fn push_stack_16(&mut self, mem: &mut Memory, word: u16) { [INFO] [stdout] | ^^^^^^ help: use `dyn`: `dyn Memory` [INFO] [stdout] | [INFO] [stdout] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in the 2021 edition! [INFO] [stdout] = note: for more information, see issue #80165 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/cpu/mod.rs:1338:42 [INFO] [stdout] | [INFO] [stdout] 1338 | fn pop_stack_16(&mut self, mem: &mut Memory) -> u16 { [INFO] [stdout] | ^^^^^^ help: use `dyn`: `dyn Memory` [INFO] [stdout] | [INFO] [stdout] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in the 2021 edition! [INFO] [stdout] = note: for more information, see issue #80165 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary trailing semicolon [INFO] [stdout] --> src/cpu/tests.rs:258:22 [INFO] [stdout] | [INFO] [stdout] 258 | cpu.reg.sp = 100;; [INFO] [stdout] | ^ help: remove this semicolon [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(redundant_semicolons)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `...` range patterns are deprecated [INFO] [stdout] --> src/memory_map.rs:74:24 [INFO] [stdout] | [INFO] [stdout] 74 | (GAME_ROM_START...GAME_ROM_END, false) => { [INFO] [stdout] | ^^^ help: use `..=` for an inclusive range [INFO] [stdout] | [INFO] [stdout] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in the 2021 edition! [INFO] [stdout] = note: for more information, see issue #80165 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `...` range patterns are deprecated [INFO] [stdout] --> src/memory_map.rs:78:24 [INFO] [stdout] | [INFO] [stdout] 78 | (GAME_ROM_START...GAME_ROM_END, true) => Err("Cannot write to ROM."), [INFO] [stdout] | ^^^ help: use `..=` for an inclusive range [INFO] [stdout] | [INFO] [stdout] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in the 2021 edition! [INFO] [stdout] = note: for more information, see issue #80165 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `...` range patterns are deprecated [INFO] [stdout] --> src/memory_map.rs:80:26 [INFO] [stdout] | [INFO] [stdout] 80 | (VRAM_TILES_START...VRAM_TILES_END, _) => { [INFO] [stdout] | ^^^ help: use `..=` for an inclusive range [INFO] [stdout] | [INFO] [stdout] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in the 2021 edition! [INFO] [stdout] = note: for more information, see issue #80165 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `...` range patterns are deprecated [INFO] [stdout] --> src/memory_map.rs:84:29 [INFO] [stdout] | [INFO] [stdout] 84 | (VRAM_PALETTES_START...VRAM_PALETTES_END, _) => { [INFO] [stdout] | ^^^ help: use `..=` for an inclusive range [INFO] [stdout] | [INFO] [stdout] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in the 2021 edition! [INFO] [stdout] = note: for more information, see issue #80165 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `...` range patterns are deprecated [INFO] [stdout] --> src/memory_map.rs:88:19 [INFO] [stdout] | [INFO] [stdout] 88 | (RAM_START...RAM_END, _) => Ok(Address::Ram((addr - RAM_START) as usize)), [INFO] [stdout] | ^^^ help: use `..=` for an inclusive range [INFO] [stdout] | [INFO] [stdout] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in the 2021 edition! [INFO] [stdout] = note: for more information, see issue #80165 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `...` range patterns are deprecated [INFO] [stdout] --> src/memory_map.rs:90:28 [INFO] [stdout] | [INFO] [stdout] 90 | (VRAM_SPRITES_START...VRAM_SPRITES_END, _) => { [INFO] [stdout] | ^^^ help: use `..=` for an inclusive range [INFO] [stdout] | [INFO] [stdout] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in the 2021 edition! [INFO] [stdout] = note: for more information, see issue #80165 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `...` range patterns are deprecated [INFO] [stdout] --> src/memory_map.rs:94:28 [INFO] [stdout] | [INFO] [stdout] 94 | (IN0_REGISTER_START...IN0_REGISTER_END, false) => Ok(Address::IN0Register), [INFO] [stdout] | ^^^ help: use `..=` for an inclusive range [INFO] [stdout] | [INFO] [stdout] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in the 2021 edition! [INFO] [stdout] = note: for more information, see issue #80165 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `...` range patterns are deprecated [INFO] [stdout] --> src/memory_map.rs:105:28 [INFO] [stdout] | [INFO] [stdout] 105 | (IN1_REGISTER_START...IN1_REGISTER_END, false) => Ok(Address::IN1Register), [INFO] [stdout] | ^^^ help: use `..=` for an inclusive range [INFO] [stdout] | [INFO] [stdout] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in the 2021 edition! [INFO] [stdout] = note: for more information, see issue #80165 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `...` range patterns are deprecated [INFO] [stdout] --> src/memory_map.rs:107:21 [INFO] [stdout] | [INFO] [stdout] 107 | (SOUND_START...SOUND_END, true) => Ok(Address::Sound((addr - SOUND_START) as usize)), [INFO] [stdout] | ^^^ help: use `..=` for an inclusive range [INFO] [stdout] | [INFO] [stdout] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in the 2021 edition! [INFO] [stdout] = note: for more information, see issue #80165 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `...` range patterns are deprecated [INFO] [stdout] --> src/memory_map.rs:109:25 [INFO] [stdout] | [INFO] [stdout] 109 | (SPRITE_XY_START...SPRITE_XY_END, true) => { [INFO] [stdout] | ^^^ help: use `..=` for an inclusive range [INFO] [stdout] | [INFO] [stdout] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in the 2021 edition! [INFO] [stdout] = note: for more information, see issue #80165 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `...` range patterns are deprecated [INFO] [stdout] --> src/memory_map.rs:113:26 [INFO] [stdout] | [INFO] [stdout] 113 | (DIP_SWITCH_START...DIP_SWITCH_END, _) => Ok(Address::DipSwitchRegister), [INFO] [stdout] | ^^^ help: use `..=` for an inclusive range [INFO] [stdout] | [INFO] [stdout] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in the 2021 edition! [INFO] [stdout] = note: for more information, see issue #80165 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `...` range patterns are deprecated [INFO] [stdout] --> src/memory_map.rs:115:24 [INFO] [stdout] | [INFO] [stdout] 115 | (WATCHDOG_START...WATCHDOG_END, _) => Ok(Address::WatchdogTimerReset), [INFO] [stdout] | ^^^ help: use `..=` for an inclusive range [INFO] [stdout] | [INFO] [stdout] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in the 2021 edition! [INFO] [stdout] = note: for more information, see issue #80165 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: denote infinite loops with `loop { ... }` [INFO] [stdout] --> src/pacman.rs:79:9 [INFO] [stdout] | [INFO] [stdout] 79 | while true { [INFO] [stdout] | ^^^^^^^^^^ help: use `loop` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(while_true)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unreachable pattern [INFO] [stdout] --> src/cpu/mod.rs:912:13 [INFO] [stdout] | [INFO] [stdout] 912 | (5, 2) => { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unreachable_patterns)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unreachable pattern [INFO] [stdout] --> src/cpu/mod.rs:919:13 [INFO] [stdout] | [INFO] [stdout] 919 | (6, 2) => { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unreachable pattern [INFO] [stdout] --> src/cpu/mod.rs:933:13 [INFO] [stdout] | [INFO] [stdout] 933 | (7, 2) => { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `i` [INFO] [stdout] --> src/cpu/mod.rs:57:13 [INFO] [stdout] | [INFO] [stdout] 57 | for i in 0..iters { [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_i` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `io` [INFO] [stdout] --> src/cpu/mod.rs:539:54 [INFO] [stdout] | [INFO] [stdout] 539 | fn run_cb_opcode(&mut self, memory: &mut Memory, io: &mut InputOutput, ext: bool) -> usize { [INFO] [stdout] | ^^ help: if this is intentional, prefix it with an underscore: `_io` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `number_of_ones` is assigned to, but never used [INFO] [stdout] --> src/cpu/mod.rs:1381:17 [INFO] [stdout] | [INFO] [stdout] 1381 | let mut number_of_ones = 0; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: consider using `_number_of_ones` instead [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `port` [INFO] [stdout] --> src/cpu/io.rs:21:21 [INFO] [stdout] | [INFO] [stdout] 21 | fn input(&self, port: u8) -> u8 { [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_port` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `port` [INFO] [stdout] --> src/cpu/io.rs:25:26 [INFO] [stdout] | [INFO] [stdout] 25 | fn output(&mut self, port: u8, byte: u8) { [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_port` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `mem` [INFO] [stdout] --> src/cpu/tests.rs:85:13 [INFO] [stdout] | [INFO] [stdout] 85 | let mut mem = &mut TestMemory::new(); [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_mem` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `result` [INFO] [stdout] --> src/display.rs:49:21 [INFO] [stdout] | [INFO] [stdout] 49 | let result = canvas.fill_rect(Rect::new(x_coord, y_coord, 2, 2)); [INFO] [stdout] | ^^^^^^ help: if this is intentional, prefix it with an underscore: `_result` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `x_flip` [INFO] [stdout] --> src/display.rs:62:9 [INFO] [stdout] | [INFO] [stdout] 62 | x_flip: bool, [INFO] [stdout] | ^^^^^^ help: if this is intentional, prefix it with an underscore: `_x_flip` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `y_flip` [INFO] [stdout] --> src/display.rs:63:9 [INFO] [stdout] | [INFO] [stdout] 63 | y_flip: bool, [INFO] [stdout] | ^^^^^^ help: if this is intentional, prefix it with an underscore: `_y_flip` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `port` [INFO] [stdout] --> src/interrupt_vector.rs:14:21 [INFO] [stdout] | [INFO] [stdout] 14 | fn input(&self, port: u8) -> u8 { [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_port` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `port` [INFO] [stdout] --> src/interrupt_vector.rs:18:26 [INFO] [stdout] | [INFO] [stdout] 18 | fn output(&mut self, port: u8, byte: u8) { [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_port` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `color` [INFO] [stdout] --> src/rom.rs:104:17 [INFO] [stdout] | [INFO] [stdout] 104 | let color = self.color_rom[*byte as usize]; [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_color` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `why` [INFO] [stdout] --> src/rom.rs:137:17 [INFO] [stdout] | [INFO] [stdout] 137 | Err(why) => panic!("Missing ROMs"), [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_why` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `why` [INFO] [stdout] --> src/rom.rs:142:17 [INFO] [stdout] | [INFO] [stdout] 142 | Err(why) => panic!("Error reading ROM"), [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_why` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/cpu/mod.rs:1145:13 [INFO] [stdout] | [INFO] [stdout] 1145 | let mut result = left.wrapping_sub(right); [INFO] [stdout] | ----^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/cpu/mod.rs:1347:13 [INFO] [stdout] | [INFO] [stdout] 1347 | let mut left = left + (carry as u8); [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/cpu/mod.rs:1354:13 [INFO] [stdout] | [INFO] [stdout] 1354 | let mut left = left - (carry as u8); [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/cpu/tests.rs:85:9 [INFO] [stdout] | [INFO] [stdout] 85 | let mut mem = &mut TestMemory::new(); [INFO] [stdout] | ----^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated function is never used: `draw_sprite` [INFO] [stdout] --> src/display.rs:30:12 [INFO] [stdout] | [INFO] [stdout] 30 | pub fn draw_sprite(&mut self, x: usize, y: usize, sprite: usize, palette: usize) { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant is never constructed: `VramPalettes` [INFO] [stdout] --> src/memory_map.rs:46:5 [INFO] [stdout] | [INFO] [stdout] 46 | VramPalettes(usize), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field is never read: `roms` [INFO] [stdout] --> src/pacman.rs:13:5 [INFO] [stdout] | [INFO] [stdout] 13 | roms: &'a Box, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 62 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished test [unoptimized + debuginfo] target(s) in 1.55s [INFO] running `Command { std: "docker" "inspect" "0cba89fe8d2849acde882925e8452640d66148b567429b53aee4708d9a803ca0", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "0cba89fe8d2849acde882925e8452640d66148b567429b53aee4708d9a803ca0", kill_on_drop: false }` [INFO] [stdout] 0cba89fe8d2849acde882925e8452640d66148b567429b53aee4708d9a803ca0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:20528e8c29e4536546f0102ce88568b16ea7538393a33fcca951030f7af10457" "/opt/rustwide/cargo-home/bin/cargo" "+99e3aef02079e9c10583638520cd0c134dc3a01d" "test" "--frozen", kill_on_drop: false }` [INFO] [stdout] 1db219e90d38af762f81d6d668804d2451c9015f6514c5d25fc72a55bf1a7832 [INFO] running `Command { std: "docker" "start" "-a" "1db219e90d38af762f81d6d668804d2451c9015f6514c5d25fc72a55bf1a7832", kill_on_drop: false }` [INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stderr] --> src/cpu/mod.rs:49:22 [INFO] [stderr] | [INFO] [stderr] 49 | memory: &mut Memory, [INFO] [stderr] | ^^^^^^ help: use `dyn`: `dyn Memory` [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(bare_trait_objects)]` on by default [INFO] [stderr] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in the 2021 edition! [INFO] [stderr] = note: for more information, see issue #80165 [INFO] [stderr] [INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stderr] --> src/cpu/mod.rs:50:18 [INFO] [stderr] | [INFO] [stderr] 50 | io: &mut InputOutput, [INFO] [stderr] | ^^^^^^^^^^^ help: use `dyn`: `dyn InputOutput` [INFO] [stderr] | [INFO] [stderr] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in the 2021 edition! [INFO] [stderr] = note: for more information, see issue #80165 [INFO] [stderr] [INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stderr] --> src/cpu/mod.rs:73:22 [INFO] [stderr] | [INFO] [stderr] 73 | memory: &mut Memory, [INFO] [stderr] | ^^^^^^ help: use `dyn`: `dyn Memory` [INFO] [stderr] | [INFO] [stderr] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in the 2021 edition! [INFO] [stderr] = note: for more information, see issue #80165 [INFO] [stderr] [INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stderr] --> src/cpu/mod.rs:74:18 [INFO] [stderr] | [INFO] [stderr] 74 | io: &mut InputOutput, [INFO] [stderr] | ^^^^^^^^^^^ help: use `dyn`: `dyn InputOutput` [INFO] [stderr] | [INFO] [stderr] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in the 2021 edition! [INFO] [stderr] = note: for more information, see issue #80165 [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/cpu/mod.rs:134:18 [INFO] [stderr] | [INFO] [stderr] 134 | (0, 4...7, 0) => { [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(ellipsis_inclusive_range_patterns)]` on by default [INFO] [stderr] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in the 2021 edition! [INFO] [stderr] = note: for more information, see issue #80165 [INFO] [stderr] [INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stderr] --> src/cpu/mod.rs:539:46 [INFO] [stderr] | [INFO] [stderr] 539 | fn run_cb_opcode(&mut self, memory: &mut Memory, io: &mut InputOutput, ext: bool) -> usize { [INFO] [stderr] | ^^^^^^ help: use `dyn`: `dyn Memory` [INFO] [stderr] | [INFO] [stderr] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in the 2021 edition! [INFO] [stderr] = note: for more information, see issue #80165 [INFO] [stderr] [INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stderr] --> src/cpu/mod.rs:539:63 [INFO] [stderr] | [INFO] [stderr] 539 | fn run_cb_opcode(&mut self, memory: &mut Memory, io: &mut InputOutput, ext: bool) -> usize { [INFO] [stderr] | ^^^^^^^^^^^ help: use `dyn`: `dyn InputOutput` [INFO] [stderr] | [INFO] [stderr] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in the 2021 edition! [INFO] [stderr] = note: for more information, see issue #80165 [INFO] [stderr] [INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stderr] --> src/cpu/mod.rs:626:58 [INFO] [stderr] | [INFO] [stderr] 626 | fn run_ed_opcode(&mut self, opcode: u8, memory: &mut Memory, io: &mut InputOutput) -> usize { [INFO] [stderr] | ^^^^^^ help: use `dyn`: `dyn Memory` [INFO] [stderr] | [INFO] [stderr] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in the 2021 edition! [INFO] [stderr] = note: for more information, see issue #80165 [INFO] [stderr] [INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stderr] --> src/cpu/mod.rs:626:75 [INFO] [stderr] | [INFO] [stderr] 626 | fn run_ed_opcode(&mut self, opcode: u8, memory: &mut Memory, io: &mut InputOutput) -> usize { [INFO] [stderr] | ^^^^^^^^^^^ help: use `dyn`: `dyn InputOutput` [INFO] [stderr] | [INFO] [stderr] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in the 2021 edition! [INFO] [stderr] = note: for more information, see issue #80165 [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/cpu/mod.rs:782:21 [INFO] [stderr] | [INFO] [stderr] 782 | (2, _, 0...3) => { [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] | [INFO] [stderr] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in the 2021 edition! [INFO] [stderr] = note: for more information, see issue #80165 [INFO] [stderr] [INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stderr] --> src/cpu/mod.rs:792:42 [INFO] [stderr] | [INFO] [stderr] 792 | fn r(&mut self, index: u8, mem: &mut Memory) -> u8 { [INFO] [stderr] | ^^^^^^ help: use `dyn`: `dyn Memory` [INFO] [stderr] | [INFO] [stderr] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in the 2021 edition! [INFO] [stderr] = note: for more information, see issue #80165 [INFO] [stderr] [INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stderr] --> src/cpu/mod.rs:800:58 [INFO] [stderr] | [INFO] [stderr] 800 | fn write_r(&mut self, index: u8, byte: u8, mem: &mut Memory) { [INFO] [stderr] | ^^^^^^ help: use `dyn`: `dyn Memory` [INFO] [stderr] | [INFO] [stderr] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in the 2021 edition! [INFO] [stderr] = note: for more information, see issue #80165 [INFO] [stderr] [INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stderr] --> src/cpu/mod.rs:808:47 [INFO] [stderr] | [INFO] [stderr] 808 | fn bli(&mut self, a: u8, b: u8, mem: &mut Memory, io: &mut InputOutput) { [INFO] [stderr] | ^^^^^^ help: use `dyn`: `dyn Memory` [INFO] [stderr] | [INFO] [stderr] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in the 2021 edition! [INFO] [stderr] = note: for more information, see issue #80165 [INFO] [stderr] [INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stderr] --> src/cpu/mod.rs:808:64 [INFO] [stderr] | [INFO] [stderr] 808 | fn bli(&mut self, a: u8, b: u8, mem: &mut Memory, io: &mut InputOutput) { [INFO] [stderr] | ^^^^^^^^^^^ help: use `dyn`: `dyn InputOutput` [INFO] [stderr] | [INFO] [stderr] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in the 2021 edition! [INFO] [stderr] = note: for more information, see issue #80165 [INFO] [stderr] [INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stderr] --> src/cpu/mod.rs:952:42 [INFO] [stderr] | [INFO] [stderr] 952 | fn load_inc_dec(&mut self, mem: &mut Memory, inc: bool) { [INFO] [stderr] | ^^^^^^ help: use `dyn`: `dyn Memory` [INFO] [stderr] | [INFO] [stderr] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in the 2021 edition! [INFO] [stderr] = note: for more information, see issue #80165 [INFO] [stderr] [INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stderr] --> src/cpu/mod.rs:974:42 [INFO] [stderr] | [INFO] [stderr] 974 | fn comp_inc_dec(&mut self, mem: &mut Memory, inc: bool) { [INFO] [stderr] | ^^^^^^ help: use `dyn`: `dyn Memory` [INFO] [stderr] | [INFO] [stderr] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in the 2021 edition! [INFO] [stderr] = note: for more information, see issue #80165 [INFO] [stderr] [INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stderr] --> src/cpu/mod.rs:1274:42 [INFO] [stderr] | [INFO] [stderr] 1274 | fn dec_8(&mut self, y: u8, mem: &mut Memory) { [INFO] [stderr] | ^^^^^^ help: use `dyn`: `dyn Memory` [INFO] [stderr] | [INFO] [stderr] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in the 2021 edition! [INFO] [stderr] = note: for more information, see issue #80165 [INFO] [stderr] [INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stderr] --> src/cpu/mod.rs:1288:42 [INFO] [stderr] | [INFO] [stderr] 1288 | fn inc_8(&mut self, y: u8, mem: &mut Memory) { [INFO] [stderr] | ^^^^^^ help: use `dyn`: `dyn Memory` [INFO] [stderr] | [INFO] [stderr] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in the 2021 edition! [INFO] [stderr] = note: for more information, see issue #80165 [INFO] [stderr] [INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stderr] --> src/cpu/mod.rs:1303:34 [INFO] [stderr] | [INFO] [stderr] 1303 | fn call(&mut self, mem: &mut Memory, addr: u16) { [INFO] [stderr] | ^^^^^^ help: use `dyn`: `dyn Memory` [INFO] [stderr] | [INFO] [stderr] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in the 2021 edition! [INFO] [stderr] = note: for more information, see issue #80165 [INFO] [stderr] [INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stderr] --> src/cpu/mod.rs:1310:33 [INFO] [stderr] | [INFO] [stderr] 1310 | fn ret(&mut self, mem: &mut Memory) { [INFO] [stderr] | ^^^^^^ help: use `dyn`: `dyn Memory` [INFO] [stderr] | [INFO] [stderr] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in the 2021 edition! [INFO] [stderr] = note: for more information, see issue #80165 [INFO] [stderr] [INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stderr] --> src/cpu/mod.rs:1316:39 [INFO] [stderr] | [INFO] [stderr] 1316 | fn pop_stack(&mut self, mem: &mut Memory) -> u8 { [INFO] [stderr] | ^^^^^^ help: use `dyn`: `dyn Memory` [INFO] [stderr] | [INFO] [stderr] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in the 2021 edition! [INFO] [stderr] = note: for more information, see issue #80165 [INFO] [stderr] [INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stderr] --> src/cpu/mod.rs:1324:40 [INFO] [stderr] | [INFO] [stderr] 1324 | fn push_stack(&mut self, mem: &mut Memory, byte: u8) { [INFO] [stderr] | ^^^^^^ help: use `dyn`: `dyn Memory` [INFO] [stderr] | [INFO] [stderr] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in the 2021 edition! [INFO] [stderr] = note: for more information, see issue #80165 [INFO] [stderr] [INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stderr] --> src/cpu/mod.rs:1333:43 [INFO] [stderr] | [INFO] [stderr] 1333 | fn push_stack_16(&mut self, mem: &mut Memory, word: u16) { [INFO] [stderr] | ^^^^^^ help: use `dyn`: `dyn Memory` [INFO] [stderr] | [INFO] [stderr] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in the 2021 edition! [INFO] [stderr] = note: for more information, see issue #80165 [INFO] [stderr] [INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stderr] --> src/cpu/mod.rs:1338:42 [INFO] [stderr] | [INFO] [stderr] 1338 | fn pop_stack_16(&mut self, mem: &mut Memory) -> u16 { [INFO] [stderr] | ^^^^^^ help: use `dyn`: `dyn Memory` [INFO] [stderr] | [INFO] [stderr] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in the 2021 edition! [INFO] [stderr] = note: for more information, see issue #80165 [INFO] [stderr] [INFO] [stderr] warning: unnecessary trailing semicolon [INFO] [stderr] --> src/cpu/tests.rs:258:22 [INFO] [stderr] | [INFO] [stderr] 258 | cpu.reg.sp = 100;; [INFO] [stderr] | ^ help: remove this semicolon [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(redundant_semicolons)]` on by default [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/memory_map.rs:74:24 [INFO] [stderr] | [INFO] [stderr] 74 | (GAME_ROM_START...GAME_ROM_END, false) => { [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] | [INFO] [stderr] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in the 2021 edition! [INFO] [stderr] = note: for more information, see issue #80165 [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/memory_map.rs:78:24 [INFO] [stderr] | [INFO] [stderr] 78 | (GAME_ROM_START...GAME_ROM_END, true) => Err("Cannot write to ROM."), [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] | [INFO] [stderr] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in the 2021 edition! [INFO] [stderr] = note: for more information, see issue #80165 [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/memory_map.rs:80:26 [INFO] [stderr] | [INFO] [stderr] 80 | (VRAM_TILES_START...VRAM_TILES_END, _) => { [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] | [INFO] [stderr] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in the 2021 edition! [INFO] [stderr] = note: for more information, see issue #80165 [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/memory_map.rs:84:29 [INFO] [stderr] | [INFO] [stderr] 84 | (VRAM_PALETTES_START...VRAM_PALETTES_END, _) => { [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] | [INFO] [stderr] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in the 2021 edition! [INFO] [stderr] = note: for more information, see issue #80165 [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/memory_map.rs:88:19 [INFO] [stderr] | [INFO] [stderr] 88 | (RAM_START...RAM_END, _) => Ok(Address::Ram((addr - RAM_START) as usize)), [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] | [INFO] [stderr] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in the 2021 edition! [INFO] [stderr] = note: for more information, see issue #80165 [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/memory_map.rs:90:28 [INFO] [stderr] | [INFO] [stderr] 90 | (VRAM_SPRITES_START...VRAM_SPRITES_END, _) => { [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] | [INFO] [stderr] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in the 2021 edition! [INFO] [stderr] = note: for more information, see issue #80165 [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/memory_map.rs:94:28 [INFO] [stderr] | [INFO] [stderr] 94 | (IN0_REGISTER_START...IN0_REGISTER_END, false) => Ok(Address::IN0Register), [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] | [INFO] [stderr] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in the 2021 edition! [INFO] [stderr] = note: for more information, see issue #80165 [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/memory_map.rs:105:28 [INFO] [stderr] | [INFO] [stderr] 105 | (IN1_REGISTER_START...IN1_REGISTER_END, false) => Ok(Address::IN1Register), [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] | [INFO] [stderr] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in the 2021 edition! [INFO] [stderr] = note: for more information, see issue #80165 [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/memory_map.rs:107:21 [INFO] [stderr] | [INFO] [stderr] 107 | (SOUND_START...SOUND_END, true) => Ok(Address::Sound((addr - SOUND_START) as usize)), [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] | [INFO] [stderr] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in the 2021 edition! [INFO] [stderr] = note: for more information, see issue #80165 [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/memory_map.rs:109:25 [INFO] [stderr] | [INFO] [stderr] 109 | (SPRITE_XY_START...SPRITE_XY_END, true) => { [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] | [INFO] [stderr] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in the 2021 edition! [INFO] [stderr] = note: for more information, see issue #80165 [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/memory_map.rs:113:26 [INFO] [stderr] | [INFO] [stderr] 113 | (DIP_SWITCH_START...DIP_SWITCH_END, _) => Ok(Address::DipSwitchRegister), [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] | [INFO] [stderr] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in the 2021 edition! [INFO] [stderr] = note: for more information, see issue #80165 [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/memory_map.rs:115:24 [INFO] [stderr] | [INFO] [stderr] 115 | (WATCHDOG_START...WATCHDOG_END, _) => Ok(Address::WatchdogTimerReset), [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] | [INFO] [stderr] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in the 2021 edition! [INFO] [stderr] = note: for more information, see issue #80165 [INFO] [stderr] [INFO] [stderr] warning: denote infinite loops with `loop { ... }` [INFO] [stderr] --> src/pacman.rs:79:9 [INFO] [stderr] | [INFO] [stderr] 79 | while true { [INFO] [stderr] | ^^^^^^^^^^ help: use `loop` [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(while_true)]` on by default [INFO] [stderr] [INFO] [stderr] warning: unreachable pattern [INFO] [stderr] --> src/cpu/mod.rs:912:13 [INFO] [stderr] | [INFO] [stderr] 912 | (5, 2) => { [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(unreachable_patterns)]` on by default [INFO] [stderr] [INFO] [stderr] warning: unreachable pattern [INFO] [stderr] --> src/cpu/mod.rs:919:13 [INFO] [stderr] | [INFO] [stderr] 919 | (6, 2) => { [INFO] [stderr] | ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unreachable pattern [INFO] [stderr] --> src/cpu/mod.rs:933:13 [INFO] [stderr] | [INFO] [stderr] 933 | (7, 2) => { [INFO] [stderr] | ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused variable: `i` [INFO] [stderr] --> src/cpu/mod.rs:57:13 [INFO] [stderr] | [INFO] [stderr] 57 | for i in 0..iters { [INFO] [stderr] | ^ help: if this is intentional, prefix it with an underscore: `_i` [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(unused_variables)]` on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `io` [INFO] [stderr] --> src/cpu/mod.rs:539:54 [INFO] [stderr] | [INFO] [stderr] 539 | fn run_cb_opcode(&mut self, memory: &mut Memory, io: &mut InputOutput, ext: bool) -> usize { [INFO] [stderr] | ^^ help: if this is intentional, prefix it with an underscore: `_io` [INFO] [stderr] [INFO] [stderr] warning: variable `number_of_ones` is assigned to, but never used [INFO] [stderr] --> src/cpu/mod.rs:1381:17 [INFO] [stderr] | [INFO] [stderr] 1381 | let mut number_of_ones = 0; [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: consider using `_number_of_ones` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `port` [INFO] [stderr] --> src/cpu/io.rs:21:21 [INFO] [stderr] | [INFO] [stderr] 21 | fn input(&self, port: u8) -> u8 { [INFO] [stderr] | ^^^^ help: if this is intentional, prefix it with an underscore: `_port` [INFO] [stderr] [INFO] [stderr] warning: unused variable: `port` [INFO] [stderr] --> src/cpu/io.rs:25:26 [INFO] [stderr] | [INFO] [stderr] 25 | fn output(&mut self, port: u8, byte: u8) { [INFO] [stderr] | ^^^^ help: if this is intentional, prefix it with an underscore: `_port` [INFO] [stderr] [INFO] [stderr] warning: unused variable: `mem` [INFO] [stderr] --> src/cpu/tests.rs:85:13 [INFO] [stderr] | [INFO] [stderr] 85 | let mut mem = &mut TestMemory::new(); [INFO] [stderr] | ^^^ help: if this is intentional, prefix it with an underscore: `_mem` [INFO] [stderr] [INFO] [stderr] warning: unused variable: `result` [INFO] [stderr] --> src/display.rs:49:21 [INFO] [stderr] | [INFO] [stderr] 49 | let result = canvas.fill_rect(Rect::new(x_coord, y_coord, 2, 2)); [INFO] [stderr] | ^^^^^^ help: if this is intentional, prefix it with an underscore: `_result` [INFO] [stderr] [INFO] [stderr] warning: unused variable: `x_flip` [INFO] [stderr] --> src/display.rs:62:9 [INFO] [stderr] | [INFO] [stderr] 62 | x_flip: bool, [INFO] [stderr] | ^^^^^^ help: if this is intentional, prefix it with an underscore: `_x_flip` [INFO] [stderr] [INFO] [stderr] warning: unused variable: `y_flip` [INFO] [stderr] --> src/display.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | y_flip: bool, [INFO] [stderr] | ^^^^^^ help: if this is intentional, prefix it with an underscore: `_y_flip` [INFO] [stderr] [INFO] [stderr] warning: unused variable: `port` [INFO] [stderr] --> src/interrupt_vector.rs:14:21 [INFO] [stderr] | [INFO] [stderr] 14 | fn input(&self, port: u8) -> u8 { [INFO] [stderr] | ^^^^ help: if this is intentional, prefix it with an underscore: `_port` [INFO] [stderr] [INFO] [stderr] warning: unused variable: `port` [INFO] [stderr] --> src/interrupt_vector.rs:18:26 [INFO] [stderr] | [INFO] [stderr] 18 | fn output(&mut self, port: u8, byte: u8) { [INFO] [stderr] | ^^^^ help: if this is intentional, prefix it with an underscore: `_port` [INFO] [stderr] [INFO] [stderr] warning: unused variable: `color` [INFO] [stderr] --> src/rom.rs:104:17 [INFO] [stderr] | [INFO] [stderr] 104 | let color = self.color_rom[*byte as usize]; [INFO] [stderr] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_color` [INFO] [stderr] [INFO] [stderr] warning: unused variable: `why` [INFO] [stderr] --> src/rom.rs:137:17 [INFO] [stderr] | [INFO] [stderr] 137 | Err(why) => panic!("Missing ROMs"), [INFO] [stderr] | ^^^ help: if this is intentional, prefix it with an underscore: `_why` [INFO] [stderr] [INFO] [stderr] warning: unused variable: `why` [INFO] [stderr] --> src/rom.rs:142:17 [INFO] [stderr] | [INFO] [stderr] 142 | Err(why) => panic!("Error reading ROM"), [INFO] [stderr] | ^^^ help: if this is intentional, prefix it with an underscore: `_why` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/cpu/mod.rs:1145:13 [INFO] [stderr] | [INFO] [stderr] 1145 | let mut result = left.wrapping_sub(right); [INFO] [stderr] | ----^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(unused_mut)]` on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/cpu/mod.rs:1347:13 [INFO] [stderr] | [INFO] [stderr] 1347 | let mut left = left + (carry as u8); [INFO] [stderr] | ----^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/cpu/mod.rs:1354:13 [INFO] [stderr] | [INFO] [stderr] 1354 | let mut left = left - (carry as u8); [INFO] [stderr] | ----^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/cpu/tests.rs:85:9 [INFO] [stderr] | [INFO] [stderr] 85 | let mut mem = &mut TestMemory::new(); [INFO] [stderr] | ----^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: associated function is never used: `draw_sprite` [INFO] [stderr] --> src/display.rs:30:12 [INFO] [stderr] | [INFO] [stderr] 30 | pub fn draw_sprite(&mut self, x: usize, y: usize, sprite: usize, palette: usize) { [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(dead_code)]` on by default [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `VramPalettes` [INFO] [stderr] --> src/memory_map.rs:46:5 [INFO] [stderr] | [INFO] [stderr] 46 | VramPalettes(usize), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never read: `roms` [INFO] [stderr] --> src/pacman.rs:13:5 [INFO] [stderr] | [INFO] [stderr] 13 | roms: &'a Box, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: 62 warnings emitted [INFO] [stderr] [INFO] [stderr] Finished test [unoptimized + debuginfo] target(s) in 0.03s [INFO] [stdout] [INFO] [stderr] Running unittests (/opt/rustwide/target/debug/deps/pacman-415098e4516f73cd) [INFO] [stdout] running 28 tests [INFO] [stdout] test cpu::reg::tests::test_16bit_registers ... ok [INFO] [stdout] test cpu::reg::tests::test_cc ... ok [INFO] [stdout] test cpu::tests::test_8bit_loading ... ok [INFO] [stdout] test cpu::tests::test_add ... ok [INFO] [stdout] test cpu::tests::test_detect_overflow ... ok [INFO] [stdout] test cpu::tests::test_indirect_loads ... ok [INFO] [stdout] test cpu::reg::tests::test_write_16bit_r ... ok [INFO] [stdout] test cpu::tests::test_jr ... ok [INFO] [stdout] test cpu::tests::test_io ... ok [INFO] [stdout] test cpu::tests::test_run_opcodes ... ok [INFO] [stdout] test memory_mapper::tests::test_read ... ok [INFO] [stdout] test cpu::tests::test_16bit_inc_dec ... ok [INFO] [stdout] test cpu::tests::test_8bit_inc_dec ... ok [INFO] [stdout] test cpu::tests::test_neg ... ok [INFO] [stdout] test cpu::tests::test_shift ... ok [INFO] [stdout] test cpu::tests::test_sub ... ok [INFO] [stdout] test memory_map::tests::test_memory_map ... ok [INFO] [stdout] test cpu::tests::test_return ... ok [INFO] [stdout] test cpu::tests::test_stack ... ok [INFO] [stdout] test memory_mapper::tests::test_inital_state ... ok [INFO] [stdout] test cpu::tests::test_halt ... FAILED [INFO] [stdout] test memory_mapper::tests::test_invalid_write ... ok [INFO] [stdout] test cpu::tests::test_interrupt ... ok [INFO] [stdout] test cpu::tests::test_ix_iy_bit_operations ... ok [INFO] [stdout] test cpu::tests::test_bit_test ... ok [INFO] [stdout] test memory_mapper::tests::test_valid_write ... ok [INFO] [stdout] test cpu::tests::test_ix_operations ... ok [INFO] [stdout] test cpu::tests::test_16bit_ld ... ok [INFO] [stdout] [INFO] [stdout] failures: [INFO] [stdout] [INFO] [stdout] ---- cpu::tests::test_halt stdout ---- [INFO] [stdout] thread 'cpu::tests::test_halt' panicked at 'assertion failed: `(left == right)` [INFO] [stdout] left: `4`, [INFO] [stdout] right: `0`', src/cpu/tests.rs:123:5 [INFO] [stdout] stack backtrace: [INFO] [stdout] 0: 0x557a9a5cb210 - std::backtrace_rs::backtrace::libunwind::trace::h1037ca7e6eeef65c [INFO] [stdout] at /rustc/99e3aef02079e9c10583638520cd0c134dc3a01d/library/std/src/../../backtrace/src/backtrace/libunwind.rs:90:5 [INFO] [stdout] 1: 0x557a9a5cb210 - std::backtrace_rs::backtrace::trace_unsynchronized::haaefac1bc3669450 [INFO] [stdout] at /rustc/99e3aef02079e9c10583638520cd0c134dc3a01d/library/std/src/../../backtrace/src/backtrace/mod.rs:66:5 [INFO] [stdout] 2: 0x557a9a5cb210 - std::sys_common::backtrace::_print_fmt::h863a6f5e6d995885 [INFO] [stdout] at /rustc/99e3aef02079e9c10583638520cd0c134dc3a01d/library/std/src/sys_common/backtrace.rs:67:5 [INFO] [stdout] 3: 0x557a9a5cb210 - ::fmt::h767e17e1aa7df6a8 [INFO] [stdout] at /rustc/99e3aef02079e9c10583638520cd0c134dc3a01d/library/std/src/sys_common/backtrace.rs:46:22 [INFO] [stdout] 4: 0x557a9a5ed9cc - core::fmt::write::h7aa6cd0067dca82a [INFO] [stdout] at /rustc/99e3aef02079e9c10583638520cd0c134dc3a01d/library/core/src/fmt/mod.rs:1110:17 [INFO] [stdout] 5: 0x557a9a5c8285 - std::io::Write::write_fmt::h6f1a9b91376a1376 [INFO] [stdout] at /rustc/99e3aef02079e9c10583638520cd0c134dc3a01d/library/std/src/io/mod.rs:1584:15 [INFO] [stdout] 6: 0x557a9a5cd37b - std::sys_common::backtrace::_print::h2769edb26a7eb606 [INFO] [stdout] at /rustc/99e3aef02079e9c10583638520cd0c134dc3a01d/library/std/src/sys_common/backtrace.rs:49:5 [INFO] [stdout] 7: 0x557a9a5cd37b - std::sys_common::backtrace::print::ha71f3549862b4cb6 [INFO] [stdout] at /rustc/99e3aef02079e9c10583638520cd0c134dc3a01d/library/std/src/sys_common/backtrace.rs:36:9 [INFO] [stdout] 8: 0x557a9a5cd37b - std::panicking::default_hook::{{closure}}::h95488a3bade217f6 [INFO] [stdout] at /rustc/99e3aef02079e9c10583638520cd0c134dc3a01d/library/std/src/panicking.rs:208:50 [INFO] [stdout] 9: 0x557a9a5cce8c - std::panicking::default_hook::h290aa602c0fb11df [INFO] [stdout] at /rustc/99e3aef02079e9c10583638520cd0c134dc3a01d/library/std/src/panicking.rs:222:9 [INFO] [stdout] 10: 0x557a9a5cda21 - std::panicking::rust_panic_with_hook::hf32c4fa635e215f2 [INFO] [stdout] at /rustc/99e3aef02079e9c10583638520cd0c134dc3a01d/library/std/src/panicking.rs:622:17 [INFO] [stdout] 11: 0x557a9a5cd527 - std::panicking::begin_panic_handler::{{closure}}::h95197ccd88846f7a [INFO] [stdout] at /rustc/99e3aef02079e9c10583638520cd0c134dc3a01d/library/std/src/panicking.rs:519:13 [INFO] [stdout] 12: 0x557a9a5cb6ec - std::sys_common::backtrace::__rust_end_short_backtrace::h7641df9566f7b7d0 [INFO] [stdout] at /rustc/99e3aef02079e9c10583638520cd0c134dc3a01d/library/std/src/sys_common/backtrace.rs:141:18 [INFO] [stdout] 13: 0x557a9a5cd489 - rust_begin_unwind [INFO] [stdout] at /rustc/99e3aef02079e9c10583638520cd0c134dc3a01d/library/std/src/panicking.rs:515:5 [INFO] [stdout] 14: 0x557a9a56d4b1 - core::panicking::panic_fmt::hbe99dddd3092ba3c [INFO] [stdout] at /rustc/99e3aef02079e9c10583638520cd0c134dc3a01d/library/core/src/panicking.rs:92:14 [INFO] [stdout] 15: 0x557a9a5ec2e8 - core::panicking::assert_failed_inner::h4fdb1013d187f202 [INFO] [stdout] 16: 0x557a9a57aa2a - core::panicking::assert_failed::hae875ab821d2e0e0 [INFO] [stdout] at /rustc/99e3aef02079e9c10583638520cd0c134dc3a01d/library/core/src/panicking.rs:117:5 [INFO] [stdout] 17: 0x557a9a575674 - pacman::cpu::tests::test_halt::hc1e3f66fffbd8b81 [INFO] [stdout] at /opt/rustwide/workdir/src/cpu/tests.rs:123:5 [INFO] [stdout] 18: 0x557a9a57553a - pacman::cpu::tests::test_halt::{{closure}}::he622a437a3ec09f7 [INFO] [stdout] at /opt/rustwide/workdir/src/cpu/tests.rs:117:1 [INFO] [stdout] 19: 0x557a9a577efe - core::ops::function::FnOnce::call_once::h351ca4bd45eb65d7 [INFO] [stdout] at /rustc/99e3aef02079e9c10583638520cd0c134dc3a01d/library/core/src/ops/function.rs:227:5 [INFO] [stdout] 20: 0x557a9a5a1bc3 - core::ops::function::FnOnce::call_once::h673fbe3f96486fd2 [INFO] [stdout] at /rustc/99e3aef02079e9c10583638520cd0c134dc3a01d/library/core/src/ops/function.rs:227:5 [INFO] [stdout] 21: 0x557a9a5a1bc3 - test::__rust_begin_short_backtrace::h8eedc24e104ef6a0 [INFO] [stdout] at /rustc/99e3aef02079e9c10583638520cd0c134dc3a01d/library/test/src/lib.rs:577:5 [INFO] [stdout] 22: 0x557a9a5a0670 - as core::ops::function::FnOnce>::call_once::h028d0969d3f94d78 [INFO] [stdout] at /rustc/99e3aef02079e9c10583638520cd0c134dc3a01d/library/alloc/src/boxed.rs:1575:9 [INFO] [stdout] 23: 0x557a9a5a0670 - as core::ops::function::FnOnce<()>>::call_once::h7634b01590b1722b [INFO] [stdout] at /rustc/99e3aef02079e9c10583638520cd0c134dc3a01d/library/std/src/panic.rs:346:9 [INFO] [stdout] 24: 0x557a9a5a0670 - std::panicking::try::do_call::hf74f869706dec63b [INFO] [stdout] at /rustc/99e3aef02079e9c10583638520cd0c134dc3a01d/library/std/src/panicking.rs:401:40 [INFO] [stdout] 25: 0x557a9a5a0670 - std::panicking::try::hd0b7346ebfaaae44 [INFO] [stdout] at /rustc/99e3aef02079e9c10583638520cd0c134dc3a01d/library/std/src/panicking.rs:365:19 [INFO] [stdout] 26: 0x557a9a5a0670 - std::panic::catch_unwind::hdbf6904f7c253080 [INFO] [stdout] at /rustc/99e3aef02079e9c10583638520cd0c134dc3a01d/library/std/src/panic.rs:433:14 [INFO] [stdout] 27: 0x557a9a5a0670 - test::run_test_in_process::h87e95a014ac91067 [INFO] [stdout] at /rustc/99e3aef02079e9c10583638520cd0c134dc3a01d/library/test/src/lib.rs:600:18 [INFO] [stdout] 28: 0x557a9a5a0670 - test::run_test::run_test_inner::{{closure}}::hdd69ae44aaab3470 [INFO] [stdout] at /rustc/99e3aef02079e9c10583638520cd0c134dc3a01d/library/test/src/lib.rs:492:39 [INFO] [stdout] 29: 0x557a9a57b942 - test::run_test::run_test_inner::{{closure}}::hc159305704d5b68a [INFO] [stdout] at /rustc/99e3aef02079e9c10583638520cd0c134dc3a01d/library/test/src/lib.rs:519:37 [INFO] [stdout] 30: 0x557a9a57b942 - std::sys_common::backtrace::__rust_begin_short_backtrace::h33d8a8ad5f788fcc [INFO] [stdout] at /rustc/99e3aef02079e9c10583638520cd0c134dc3a01d/library/std/src/sys_common/backtrace.rs:125:18 [INFO] [stdout] 31: 0x557a9a57f6b8 - std::thread::Builder::spawn_unchecked::{{closure}}::{{closure}}::h6181011ddf4b8353 [INFO] [stdout] at /rustc/99e3aef02079e9c10583638520cd0c134dc3a01d/library/std/src/thread/mod.rs:481:17 [INFO] [stdout] 32: 0x557a9a57f6b8 - as core::ops::function::FnOnce<()>>::call_once::hf924ea0a0f25a1c0 [INFO] [stdout] at /rustc/99e3aef02079e9c10583638520cd0c134dc3a01d/library/std/src/panic.rs:346:9 [INFO] [stdout] 33: 0x557a9a57f6b8 - std::panicking::try::do_call::hd58061792d05fa5c [INFO] [stdout] at /rustc/99e3aef02079e9c10583638520cd0c134dc3a01d/library/std/src/panicking.rs:401:40 [INFO] [stdout] 34: 0x557a9a57f6b8 - std::panicking::try::h3080747417e5af37 [INFO] [stdout] at /rustc/99e3aef02079e9c10583638520cd0c134dc3a01d/library/std/src/panicking.rs:365:19 [INFO] [stdout] 35: 0x557a9a57f6b8 - std::panic::catch_unwind::hfeba515dcf36cb66 [INFO] [stdout] at /rustc/99e3aef02079e9c10583638520cd0c134dc3a01d/library/std/src/panic.rs:433:14 [INFO] [stdout] 36: 0x557a9a57f6b8 - std::thread::Builder::spawn_unchecked::{{closure}}::h29d57a62faff749b [INFO] [stdout] at /rustc/99e3aef02079e9c10583638520cd0c134dc3a01d/library/std/src/thread/mod.rs:480:30 [INFO] [stdout] 37: 0x557a9a57f6b8 - core::ops::function::FnOnce::call_once{{vtable.shim}}::h44709d312d2a9c59 [INFO] [stdout] at /rustc/99e3aef02079e9c10583638520cd0c134dc3a01d/library/core/src/ops/function.rs:227:5 [INFO] [stdout] 38: 0x557a9a5d24d7 - as core::ops::function::FnOnce>::call_once::h902e2cf6655e1b0c [INFO] [stdout] at /rustc/99e3aef02079e9c10583638520cd0c134dc3a01d/library/alloc/src/boxed.rs:1575:9 [INFO] [stdout] 39: 0x557a9a5d24d7 - as core::ops::function::FnOnce>::call_once::h893a5452154309d1 [INFO] [stdout] at /rustc/99e3aef02079e9c10583638520cd0c134dc3a01d/library/alloc/src/boxed.rs:1575:9 [INFO] [stdout] 40: 0x557a9a5d24d7 - std::sys::unix::thread::Thread::new::thread_start::hdedcb57c96ab37cd [INFO] [stdout] at /rustc/99e3aef02079e9c10583638520cd0c134dc3a01d/library/std/src/sys/unix/thread.rs:71:17 [INFO] [stdout] 41: 0x7f67d7478609 - start_thread [INFO] [stdout] 42: 0x7f67d724a293 - clone [INFO] [stdout] 43: 0x0 - [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] failures: [INFO] [stdout] cpu::tests::test_halt [INFO] [stdout] [INFO] [stdout] test result: FAILED. 27 passed; 1 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.05s [INFO] [stdout] [INFO] [stderr] error: test failed, to rerun pass '--bin pacman' [INFO] running `Command { std: "docker" "inspect" "1db219e90d38af762f81d6d668804d2451c9015f6514c5d25fc72a55bf1a7832", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "1db219e90d38af762f81d6d668804d2451c9015f6514c5d25fc72a55bf1a7832", kill_on_drop: false }` [INFO] [stdout] 1db219e90d38af762f81d6d668804d2451c9015f6514c5d25fc72a55bf1a7832