[INFO] cloning repository https://github.com/Gisleburt/Skitty [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/Gisleburt/Skitty" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FGisleburt%2FSkitty", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FGisleburt%2FSkitty'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] a9a1b8a8fcd99473697944e74e99bf2702ccb525 [INFO] checking Gisleburt/Skitty against master#1ab98933fa75d72e882b86feac1a0be3a5b02cb0 for pr-83850 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FGisleburt%2FSkitty" "/workspace/builds/worker-1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-1/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/Gisleburt/Skitty on toolchain 1ab98933fa75d72e882b86feac1a0be3a5b02cb0 [INFO] running `Command { std: "/workspace/cargo-home/bin/cargo" "+1ab98933fa75d72e882b86feac1a0be3a5b02cb0" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/Gisleburt/Skitty [INFO] finished tweaking git repo https://github.com/Gisleburt/Skitty [INFO] tweaked toml for git repo https://github.com/Gisleburt/Skitty written to /workspace/builds/worker-1/source/Cargo.toml [INFO] crate git repo https://github.com/Gisleburt/Skitty already has a lockfile, it will not be regenerated [INFO] running `Command { std: "/workspace/cargo-home/bin/cargo" "+1ab98933fa75d72e882b86feac1a0be3a5b02cb0" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded miniz_oxide v0.1.3 [INFO] [stderr] Downloaded serde_json v1.0.26 [INFO] [stderr] Downloaded miniz_oxide_c_api v0.1.3 [INFO] [stderr] Downloaded lazycell v1.0.0 [INFO] [stderr] Downloaded filetime v0.2.1 [INFO] [stderr] Downloaded zip v0.4.2 [INFO] [stderr] Downloaded parking_lot_core v0.3.0 [INFO] [stderr] Downloaded log v0.4.4 [INFO] [stderr] Downloaded cc v1.0.23 [INFO] [stderr] Downloaded flate2 v1.0.2 [INFO] [stderr] Downloaded bzip2-sys v0.1.6 [INFO] [stderr] Downloaded proc-macro2 v0.4.16 [INFO] [stderr] Downloaded serde v1.0.76 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ac0d0aa6ec8ed129e241004a6179c99fa0d2616f50ba759c5b60bd26d0fafa02" "/opt/rustwide/cargo-home/bin/cargo" "+1ab98933fa75d72e882b86feac1a0be3a5b02cb0" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 6c6745fb5815b63526e73615999ad6f1f53acde9081d194408a0e861cdd1918a [INFO] running `Command { std: "docker" "start" "-a" "6c6745fb5815b63526e73615999ad6f1f53acde9081d194408a0e861cdd1918a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "6c6745fb5815b63526e73615999ad6f1f53acde9081d194408a0e861cdd1918a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "6c6745fb5815b63526e73615999ad6f1f53acde9081d194408a0e861cdd1918a", kill_on_drop: false }` [INFO] [stdout] 6c6745fb5815b63526e73615999ad6f1f53acde9081d194408a0e861cdd1918a [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ac0d0aa6ec8ed129e241004a6179c99fa0d2616f50ba759c5b60bd26d0fafa02" "/opt/rustwide/cargo-home/bin/cargo" "+1ab98933fa75d72e882b86feac1a0be3a5b02cb0" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 4d8b52bfedbb80a13a3c339f1a9f28fea24c7d7028cf92a0850f3433e0fcac33 [INFO] running `Command { std: "docker" "start" "-a" "4d8b52bfedbb80a13a3c339f1a9f28fea24c7d7028cf92a0850f3433e0fcac33", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Checking libc v0.2.43 [INFO] [stderr] Compiling cc v1.0.23 [INFO] [stderr] Checking cfg-if v0.1.5 [INFO] [stderr] Checking void v1.0.2 [INFO] [stderr] Compiling proc-macro2 v0.4.16 [INFO] [stderr] Compiling version_check v0.1.4 [INFO] [stderr] Compiling unicode-xid v0.1.0 [INFO] [stderr] Checking rand_core v0.2.1 [INFO] [stderr] Compiling build_const v0.2.1 [INFO] [stderr] Checking stable_deref_trait v1.1.1 [INFO] [stderr] Checking lazycell v0.6.0 [INFO] [stderr] Checking byteorder v1.2.6 [INFO] [stderr] Checking slab v0.4.1 [INFO] [stderr] Checking futures v0.1.23 [INFO] [stderr] Checking scopeguard v0.3.3 [INFO] [stderr] Checking adler32 v1.0.3 [INFO] [stderr] Checking bitflags v1.0.4 [INFO] [stderr] Compiling ryu v0.2.6 [INFO] [stderr] Checking crossbeam-utils v0.5.0 [INFO] [stderr] Compiling failure_derive v0.1.2 [INFO] [stderr] Compiling serde v1.0.76 [INFO] [stderr] Checking same-file v1.0.3 [INFO] [stderr] Checking unicode-width v0.1.5 [INFO] [stderr] Checking rustc-demangle v0.1.9 [INFO] [stderr] Checking lazycell v1.0.0 [INFO] [stderr] Checking ansi_term v0.11.0 [INFO] [stderr] Checking itoa v0.4.2 [INFO] [stderr] Checking yaml-rust v0.3.5 [INFO] [stderr] Checking vec_map v0.8.1 [INFO] [stderr] Checking strsim v0.7.0 [INFO] [stderr] Checking podio v0.1.6 [INFO] [stderr] Checking log v0.4.4 [INFO] [stderr] Checking unreachable v1.0.0 [INFO] [stderr] Checking owning_ref v0.3.3 [INFO] [stderr] Checking walkdir v2.2.5 [INFO] [stderr] Checking textwrap v0.10.0 [INFO] [stderr] Compiling crc v1.8.1 [INFO] [stderr] Checking smallvec v0.6.5 [INFO] [stderr] Checking lock_api v0.1.3 [INFO] [stderr] Compiling lazy_static v1.1.0 [INFO] [stderr] Checking iovec v0.1.2 [INFO] [stderr] Checking rand v0.5.5 [INFO] [stderr] Checking net2 v0.2.33 [INFO] [stderr] Checking num_cpus v1.8.0 [INFO] [stderr] Checking miniz_oxide v0.1.3 [INFO] [stderr] Checking time v0.1.40 [INFO] [stderr] Checking inotify-sys v0.1.3 [INFO] [stderr] Checking filetime v0.2.1 [INFO] [stderr] Checking atty v0.2.11 [INFO] [stderr] Checking bytes v0.4.9 [INFO] [stderr] Checking mio v0.6.15 [INFO] [stderr] Checking clap v2.32.0 [INFO] [stderr] Checking msdos_time v0.1.6 [INFO] [stderr] Compiling miniz_oxide_c_api v0.1.3 [INFO] [stderr] Compiling bzip2-sys v0.1.6 [INFO] [stderr] Compiling backtrace-sys v0.1.24 [INFO] [stderr] Compiling quote v0.6.8 [INFO] [stderr] Compiling syn v0.14.9 [INFO] [stderr] Checking tokio-executor v0.1.4 [INFO] [stderr] Checking tokio-io v0.1.8 [INFO] [stderr] Checking mio-extras v2.0.5 [INFO] [stderr] Checking flate2 v1.0.2 [INFO] [stderr] Checking parking_lot_core v0.3.0 [INFO] [stderr] Checking parking_lot v0.6.4 [INFO] [stderr] Checking tokio-reactor v0.1.5 [INFO] [stderr] Checking inotify v0.6.1 [INFO] [stderr] Checking notify v4.0.6 [INFO] [stderr] Checking bzip2 v0.3.3 [INFO] [stderr] Checking zip v0.4.2 [INFO] [stderr] Checking backtrace v0.3.9 [INFO] [stderr] Compiling synstructure v0.9.0 [INFO] [stderr] Checking serde_json v1.0.26 [INFO] [stderr] Checking failure v0.1.2 [INFO] [stderr] Checking skitty v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/lib.rs:18:23 [INFO] [stdout] | [INFO] [stdout] 18 | pub fn extract(path: &AsRef) -> SkittyResult<()> [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(bare_trait_objects)]` on by default [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: use `dyn` [INFO] [stdout] | [INFO] [stdout] 18 - pub fn extract(path: &AsRef) -> SkittyResult<()> [INFO] [stdout] 18 + pub fn extract(path: &dyn AsRef) -> SkittyResult<()> [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/lib.rs:18:23 [INFO] [stdout] | [INFO] [stdout] 18 | pub fn extract(path: &AsRef) -> SkittyResult<()> [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(bare_trait_objects)]` on by default [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: use `dyn` [INFO] [stdout] | [INFO] [stdout] 18 - pub fn extract(path: &AsRef) -> SkittyResult<()> [INFO] [stdout] 18 + pub fn extract(path: &dyn AsRef) -> SkittyResult<()> [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/lib.rs:24:23 [INFO] [stdout] | [INFO] [stdout] 24 | pub fn combine(path: &AsRef) -> SkittyResult<()> [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: use `dyn` [INFO] [stdout] | [INFO] [stdout] 24 - pub fn combine(path: &AsRef) -> SkittyResult<()> [INFO] [stdout] 24 + pub fn combine(path: &dyn AsRef) -> SkittyResult<()> [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/lib.rs:24:23 [INFO] [stdout] | [INFO] [stdout] 24 | pub fn combine(path: &AsRef) -> SkittyResult<()> [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: use `dyn` [INFO] [stdout] | [INFO] [stdout] 24 - pub fn combine(path: &AsRef) -> SkittyResult<()> [INFO] [stdout] 24 + pub fn combine(path: &dyn AsRef) -> SkittyResult<()> [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/lib.rs:30:21 [INFO] [stdout] | [INFO] [stdout] 30 | pub fn watch(path: &AsRef) -> SkittyResult<()> [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: use `dyn` [INFO] [stdout] | [INFO] [stdout] 30 - pub fn watch(path: &AsRef) -> SkittyResult<()> [INFO] [stdout] 30 + pub fn watch(path: &dyn AsRef) -> SkittyResult<()> [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/lib.rs:30:21 [INFO] [stdout] | [INFO] [stdout] 30 | pub fn watch(path: &AsRef) -> SkittyResult<()> [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: use `dyn` [INFO] [stdout] | [INFO] [stdout] 30 - pub fn watch(path: &AsRef) -> SkittyResult<()> [INFO] [stdout] 30 + pub fn watch(path: &dyn AsRef) -> SkittyResult<()> [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/project/fs_tools.rs:10:36 [INFO] [stdout] | [INFO] [stdout] 10 | pub fn make_absolute<'a>(path: &'a AsRef) -> SkittyResult> [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: use `dyn` [INFO] [stdout] | [INFO] [stdout] 10 - pub fn make_absolute<'a>(path: &'a AsRef) -> SkittyResult> [INFO] [stdout] 10 + pub fn make_absolute<'a>(path: &'a dyn AsRef) -> SkittyResult> [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/project/fs_tools.rs:10:36 [INFO] [stdout] | [INFO] [stdout] 10 | pub fn make_absolute<'a>(path: &'a AsRef) -> SkittyResult> [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: use `dyn` [INFO] [stdout] | [INFO] [stdout] 10 - pub fn make_absolute<'a>(path: &'a AsRef) -> SkittyResult> [INFO] [stdout] 10 + pub fn make_absolute<'a>(path: &'a dyn AsRef) -> SkittyResult> [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/project/json_tools.rs:12:35 [INFO] [stdout] | [INFO] [stdout] 12 | pub fn prettify_json_in_dir(dir: &AsRef) -> SkittyResult<()> { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: use `dyn` [INFO] [stdout] | [INFO] [stdout] 12 - pub fn prettify_json_in_dir(dir: &AsRef) -> SkittyResult<()> { [INFO] [stdout] 12 + pub fn prettify_json_in_dir(dir: &dyn AsRef) -> SkittyResult<()> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/project/json_tools.rs:30:30 [INFO] [stdout] | [INFO] [stdout] 30 | fn prettify_json_file(file: &AsRef) -> SkittyResult<()> { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: use `dyn` [INFO] [stdout] | [INFO] [stdout] 30 - fn prettify_json_file(file: &AsRef) -> SkittyResult<()> { [INFO] [stdout] 30 + fn prettify_json_file(file: &dyn AsRef) -> SkittyResult<()> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/project/json_tools.rs:12:35 [INFO] [stdout] | [INFO] [stdout] 12 | pub fn prettify_json_in_dir(dir: &AsRef) -> SkittyResult<()> { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: use `dyn` [INFO] [stdout] | [INFO] [stdout] 12 - pub fn prettify_json_in_dir(dir: &AsRef) -> SkittyResult<()> { [INFO] [stdout] 12 + pub fn prettify_json_in_dir(dir: &dyn AsRef) -> SkittyResult<()> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/project/json_tools.rs:30:30 [INFO] [stdout] | [INFO] [stdout] 30 | fn prettify_json_file(file: &AsRef) -> SkittyResult<()> { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: use `dyn` [INFO] [stdout] | [INFO] [stdout] 30 - fn prettify_json_file(file: &AsRef) -> SkittyResult<()> { [INFO] [stdout] 30 + fn prettify_json_file(file: &dyn AsRef) -> SkittyResult<()> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/project/zip_tools.rs:25:13 [INFO] [stdout] | [INFO] [stdout] 25 | let mut file = zip.by_index(i)?; [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/project/zip_tools.rs:25:13 [INFO] [stdout] | [INFO] [stdout] 25 | let mut file = zip.by_index(i)?; [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 7 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 7 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 8.38s [INFO] running `Command { std: "docker" "inspect" "4d8b52bfedbb80a13a3c339f1a9f28fea24c7d7028cf92a0850f3433e0fcac33", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "4d8b52bfedbb80a13a3c339f1a9f28fea24c7d7028cf92a0850f3433e0fcac33", kill_on_drop: false }` [INFO] [stdout] 4d8b52bfedbb80a13a3c339f1a9f28fea24c7d7028cf92a0850f3433e0fcac33