[INFO] cloning repository https://github.com/elauffenburger/nes [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/elauffenburger/nes" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Felauffenburger%2Fnes", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Felauffenburger%2Fnes'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 292d8d2944794d21d9630c764e23796d718624af [INFO] checking elauffenburger/nes against try#45d8b6e68beee1c9c1ce92ae258a7e02f8f13aa4 for pr-83744 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Felauffenburger%2Fnes" "/workspace/builds/worker-2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/elauffenburger/nes on toolchain 45d8b6e68beee1c9c1ce92ae258a7e02f8f13aa4 [INFO] running `Command { std: "/workspace/cargo-home/bin/cargo" "+45d8b6e68beee1c9c1ce92ae258a7e02f8f13aa4" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/elauffenburger/nes [INFO] finished tweaking git repo https://github.com/elauffenburger/nes [INFO] tweaked toml for git repo https://github.com/elauffenburger/nes written to /workspace/builds/worker-2/source/Cargo.toml [INFO] crate git repo https://github.com/elauffenburger/nes already has a lockfile, it will not be regenerated [INFO] running `Command { std: "/workspace/cargo-home/bin/cargo" "+45d8b6e68beee1c9c1ce92ae258a7e02f8f13aa4" "fetch" "--locked" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded serde v1.0.88 [INFO] [stderr] Downloaded wayland-commons v0.21.12 [INFO] [stderr] Downloaded wayland-client v0.21.12 [INFO] [stderr] Downloaded gleam v0.6.17 [INFO] [stderr] Downloaded reqwest v0.9.9 [INFO] [stderr] Downloaded image v0.21.1 [INFO] [stderr] Downloaded piston2d-graphics v0.30.0 [INFO] [stderr] Downloaded piston2d-opengl_graphics v0.59.0 [INFO] [stderr] Downloaded pistoncore-window v0.37.0 [INFO] [stderr] Downloaded pistoncore-glutin_window v0.54.0 [INFO] [stderr] Downloaded hyper v0.12.24 [INFO] [stderr] Downloaded rusttype v0.7.6 [INFO] [stderr] Downloaded piston v0.42.0 [INFO] [stderr] Downloaded wayland-sys v0.21.12 [INFO] [stderr] Downloaded pistoncore-event_loop v0.42.0 [INFO] [stderr] Downloaded nix v0.13.0 [INFO] [stderr] Downloaded encoding_rs v0.8.16 [INFO] [stderr] Downloaded wayland-protocols v0.21.12 [INFO] [stderr] Downloaded wayland-scanner v0.21.12 [INFO] [stderr] Downloaded smithay-client-toolkit v0.4.5 [INFO] [stderr] Downloaded proc-macro2 v0.4.28 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:20528e8c29e4536546f0102ce88568b16ea7538393a33fcca951030f7af10457" "/opt/rustwide/cargo-home/bin/cargo" "+45d8b6e68beee1c9c1ce92ae258a7e02f8f13aa4" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stderr] WARNING: Your kernel does not support swap limit capabilities or the cgroup is not mounted. Memory limited without swap. [INFO] [stdout] 1a19ca32809d29dbfdf423960ff6c9b0b41c677f25e91933f04147574d00304b [INFO] running `Command { std: "docker" "start" "-a" "1a19ca32809d29dbfdf423960ff6c9b0b41c677f25e91933f04147574d00304b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "1a19ca32809d29dbfdf423960ff6c9b0b41c677f25e91933f04147574d00304b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "1a19ca32809d29dbfdf423960ff6c9b0b41c677f25e91933f04147574d00304b", kill_on_drop: false }` [INFO] [stdout] 1a19ca32809d29dbfdf423960ff6c9b0b41c677f25e91933f04147574d00304b [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:20528e8c29e4536546f0102ce88568b16ea7538393a33fcca951030f7af10457" "/opt/rustwide/cargo-home/bin/cargo" "+45d8b6e68beee1c9c1ce92ae258a7e02f8f13aa4" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stderr] WARNING: Your kernel does not support swap limit capabilities or the cgroup is not mounted. Memory limited without swap. [INFO] [stdout] 88d16fca2aa6158f24d5f0629ef810b1ad02092d7006ecd7612b5d4d48ea3042 [INFO] running `Command { std: "docker" "start" "-a" "88d16fca2aa6158f24d5f0629ef810b1ad02092d7006ecd7612b5d4d48ea3042", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.48 [INFO] [stderr] Compiling autocfg v0.1.2 [INFO] [stderr] Compiling byteorder v1.3.1 [INFO] [stderr] Compiling cc v1.0.29 [INFO] [stderr] Compiling proc-macro2 v0.4.28 [INFO] [stderr] Compiling smallvec v0.6.9 [INFO] [stderr] Checking cfg-if v0.1.6 [INFO] [stderr] Compiling serde v1.0.88 [INFO] [stderr] Checking rand_core v0.4.0 [INFO] [stderr] Compiling slab v0.4.2 [INFO] [stderr] Compiling syn v0.15.33 [INFO] [stderr] Compiling siphasher v0.2.3 [INFO] [stderr] Compiling khronos_api v3.1.0 [INFO] [stderr] Compiling lazycell v1.2.1 [INFO] [stderr] Compiling nix v0.13.0 [INFO] [stderr] Compiling openssl v0.10.16 [INFO] [stderr] Compiling httparse v1.3.3 [INFO] [stderr] Compiling ryu v0.2.7 [INFO] [stderr] Compiling crc32fast v1.1.2 [INFO] [stderr] Compiling string v0.1.3 [INFO] [stderr] Compiling encoding_rs v0.8.16 [INFO] [stderr] Checking either v1.5.1 [INFO] [stderr] Compiling rayon-core v1.4.1 [INFO] [stderr] Checking stable_deref_trait v1.1.1 [INFO] [stderr] Checking same-file v1.0.4 [INFO] [stderr] Checking downcast-rs v1.0.4 [INFO] [stderr] Compiling num-derive v0.2.5 [INFO] [stderr] Checking xdg v2.2.0 [INFO] [stderr] Compiling rayon v1.0.3 [INFO] [stderr] Checking fnv v1.0.6 [INFO] [stderr] Checking unicode-width v0.1.5 [INFO] [stderr] Checking strsim v0.8.0 [INFO] [stderr] Checking ansi_term v0.11.0 [INFO] [stderr] Compiling rand_jitter v0.1.3 [INFO] [stderr] Compiling crossbeam-utils v0.6.5 [INFO] [stderr] Compiling unicase v2.2.0 [INFO] [stderr] Compiling x11-dl v2.18.3 [INFO] [stderr] Checking crossbeam-utils v0.2.2 [INFO] [stderr] Checking log v0.4.6 [INFO] [stderr] Compiling unicode-normalization v0.1.8 [INFO] [stderr] Checking rand_core v0.3.1 [INFO] [stderr] Checking owning_ref v0.4.0 [INFO] [stderr] Checking itertools v0.8.0 [INFO] [stderr] Checking inflate v0.4.5 [INFO] [stderr] Checking walkdir v2.2.7 [INFO] [stderr] Compiling arrayvec v0.4.10 [INFO] [stderr] Checking textwrap v0.11.0 [INFO] [stderr] Compiling rand_chacha v0.1.1 [INFO] [stderr] Compiling rand v0.6.5 [INFO] [stderr] Checking rand_xorshift v0.1.1 [INFO] [stderr] Checking rand_isaac v0.1.1 [INFO] [stderr] Checking rand_hc v0.1.0 [INFO] [stderr] Compiling rand_pcg v0.1.1 [INFO] [stderr] Compiling parking_lot_core v0.4.0 [INFO] [stderr] Checking crossbeam-epoch v0.3.1 [INFO] [stderr] Checking lock_api v0.1.5 [INFO] [stderr] Checking approx v0.3.2 [INFO] [stderr] Checking ordered-float v1.0.2 [INFO] [stderr] Checking num-integer v0.1.39 [INFO] [stderr] Checking line_drawing v0.7.0 [INFO] [stderr] Compiling tokio-executor v0.1.6 [INFO] [stderr] Compiling crossbeam-channel v0.3.8 [INFO] [stderr] Compiling phf_shared v0.7.24 [INFO] [stderr] Compiling gl_generator v0.10.0 [INFO] [stderr] Compiling crossbeam-epoch v0.7.1 [INFO] [stderr] Checking crossbeam-deque v0.2.0 [INFO] [stderr] Checking num-iter v0.1.37 [INFO] [stderr] Checking num-rational v0.2.1 [INFO] [stderr] Checking rand_os v0.1.2 [INFO] [stderr] Checking num_cpus v1.10.0 [INFO] [stderr] Checking memmap v0.7.0 [INFO] [stderr] Checking shared_library v0.1.9 [INFO] [stderr] Checking atty v0.2.11 [INFO] [stderr] Compiling tokio-timer v0.2.10 [INFO] [stderr] Compiling tokio-current-thread v0.1.4 [INFO] [stderr] Compiling phf v0.7.24 [INFO] [stderr] Compiling quote v0.6.12 [INFO] [stderr] Compiling base64 v0.10.1 [INFO] [stderr] Compiling libflate v0.1.19 [INFO] [stderr] Checking stb_truetype v0.2.6 [INFO] [stderr] Checking deflate v0.7.19 [INFO] [stderr] Compiling iovec v0.1.2 [INFO] [stderr] Compiling net2 v0.2.33 [INFO] [stderr] Compiling time v0.1.42 [INFO] [stderr] Compiling mime v0.3.13 [INFO] [stderr] Compiling crossbeam-deque v0.6.3 [INFO] [stderr] Compiling idna v0.1.5 [INFO] [stderr] Compiling openssl-sys v0.9.40 [INFO] [stderr] Compiling libloading v0.5.0 [INFO] [stderr] Checking osmesa-sys v0.1.2 [INFO] [stderr] Checking clap v2.33.0 [INFO] [stderr] Compiling wayland-scanner v0.21.12 [INFO] [stderr] Compiling bytes v0.4.11 [INFO] [stderr] Compiling futures-cpupool v0.1.8 [INFO] [stderr] Checking rusttype v0.7.6 [INFO] [stderr] Compiling mio v0.6.16 [INFO] [stderr] Checking png v0.14.1 [INFO] [stderr] Compiling tokio-io v0.1.11 [INFO] [stderr] Compiling http v0.1.15 [INFO] [stderr] Compiling gl v0.11.0 [INFO] [stderr] Compiling glutin v0.19.0 [INFO] [stderr] Checking andrew v0.2.1 [INFO] [stderr] Checking piston2d-graphics v0.30.0 [INFO] [stderr] Compiling url v1.7.2 [INFO] [stderr] Compiling phf_generator v0.7.24 [INFO] [stderr] Compiling uuid v0.7.2 [INFO] [stderr] Compiling native-tls v0.2.2 [INFO] [stderr] Checking dlib v0.4.1 [INFO] [stderr] Compiling phf_codegen v0.7.24 [INFO] [stderr] Compiling parking_lot v0.7.1 [INFO] [stderr] Checking jpeg-decoder v0.1.15 [INFO] [stderr] Checking wayland-sys v0.21.12 [INFO] [stderr] Compiling mime_guess v2.0.0-alpha.6 [INFO] [stderr] Checking wayland-commons v0.21.12 [INFO] [stderr] Compiling tokio-reactor v0.1.8 [INFO] [stderr] Compiling crossbeam v0.6.0 [INFO] [stderr] Compiling wayland-client v0.21.12 [INFO] [stderr] Compiling wayland-protocols v0.21.12 [INFO] [stderr] Compiling tokio-threadpool v0.1.11 [INFO] [stderr] Compiling tokio-tcp v0.1.3 [INFO] [stderr] Compiling serde_json v1.0.38 [INFO] [stderr] Compiling serde_urlencoded v0.5.4 [INFO] [stderr] Compiling tokio v0.1.15 [INFO] [stderr] Compiling h2 v0.1.16 [INFO] [stderr] Compiling serde_derive v1.0.90 [INFO] [stderr] Compiling hyper v0.12.24 [INFO] [stderr] Checking tiff v0.2.2 [INFO] [stderr] Checking image v0.21.1 [INFO] [stderr] Compiling hyper-tls v0.3.1 [INFO] [stderr] Compiling reqwest v0.9.9 [INFO] [stderr] Checking piston2d-opengl_graphics v0.59.0 [INFO] [stderr] Checking pistoncore-input v0.24.0 [INFO] [stderr] Checking smithay-client-toolkit v0.4.5 [INFO] [stderr] Checking pistoncore-window v0.37.0 [INFO] [stderr] Checking pistoncore-event_loop v0.42.0 [INFO] [stderr] Checking piston v0.42.0 [INFO] [stderr] Checking winit v0.18.1 [INFO] [stderr] Compiling libnes v0.1.0 (/opt/rustwide/workdir/libnes) [INFO] [stdout] warning: unused import: `self` [INFO] [stdout] --> libnes/build.rs:3:33 [INFO] [stdout] | [INFO] [stdout] 3 | use std::fs::{File, DirBuilder, self}; [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::io::Write` [INFO] [stdout] --> libnes/build.rs:4:5 [INFO] [stdout] | [INFO] [stdout] 4 | use std::io::Write; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `klaus_functional_tests_url` should have an upper case name [INFO] [stdout] --> libnes/build.rs:7:7 [INFO] [stdout] | [INFO] [stdout] 7 | const klaus_functional_tests_url: &'static str = "https://github.com/Klaus2m5/6502_65C02_functional_tests/blob/master/bin_files/6502_func... [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: convert the identifier to upper case: `KLAUS_FUNCTIONAL_TESTS_URL` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_upper_case_globals)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `nestest_url` should have an upper case name [INFO] [stdout] --> libnes/build.rs:8:7 [INFO] [stdout] | [INFO] [stdout] 8 | const nestest_url: &'static str = "http://nickmass.com/images/nestest.nes"; [INFO] [stdout] | ^^^^^^^^^^^ help: convert the identifier to upper case: `NESTEST_URL` [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking pistoncore-glutin_window v0.54.0 [INFO] [stdout] warning: 4 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `#[macro_use]` import [INFO] [stdout] --> libnes/src/lib.rs:3:1 [INFO] [stdout] | [INFO] [stdout] 3 | #[macro_use] [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: type `iNESLoader` should have an upper camel case name [INFO] [stdout] --> libnes/src/cart/ines.rs:16:12 [INFO] [stdout] | [INFO] [stdout] 16 | pub struct iNESLoader {} [INFO] [stdout] | ^^^^^^^^^^ help: convert the identifier to upper camel case: `INesloader` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_camel_case_types)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: type `iNESHeader` should have an upper camel case name [INFO] [stdout] --> libnes/src/cart/ines.rs:127:8 [INFO] [stdout] | [INFO] [stdout] 127 | struct iNESHeader { [INFO] [stdout] | ^^^^^^^^^^ help: convert the identifier to upper camel case: `INesheader` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> libnes/src/cart/mappers/nrom.rs:16:35 [INFO] [stdout] | [INFO] [stdout] 16 | fn map(&self, nes: Rc>, options: MapperOptions) -> Result<(), String> { [INFO] [stdout] | ^^^ help: use `dyn`: `dyn Nes` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(bare_trait_objects)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> libnes/src/cart/mappers/mod.rs:11:35 [INFO] [stdout] | [INFO] [stdout] 11 | fn map(&self, nes: Rc>, options: MapperOptions) -> Result<(), String>; [INFO] [stdout] | ^^^ help: use `dyn`: `dyn Nes` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `iNes` should have an upper camel case name [INFO] [stdout] --> libnes/src/cart/mod.rs:28:5 [INFO] [stdout] | [INFO] [stdout] 28 | iNes, [INFO] [stdout] | ^^^^ help: convert the identifier to upper camel case (notice the capitalization): `INes` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Observer` [INFO] [stdout] --> libnes/src/cpu/cpu.rs:9:29 [INFO] [stdout] | [INFO] [stdout] 9 | use crate::ev::{Observable, Observer}; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> libnes/src/cpu/cpu.rs:30:37 [INFO] [stdout] | [INFO] [stdout] 30 | fn load_mem(&mut self, mem: Box); [INFO] [stdout] | ^^^^^^^^^^^^ help: use `dyn`: `dyn CpuMemoryMap` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> libnes/src/cpu/cpu.rs:31:46 [INFO] [stdout] | [INFO] [stdout] 31 | fn subscribe_mem(&mut self, handler: Box); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `dyn`: `dyn FnMut(&CpuMemoryAccessEvent)` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> libnes/src/cpu/cpu.rs:50:16 [INFO] [stdout] | [INFO] [stdout] 50 | impl Debug for Cpu { [INFO] [stdout] | ^^^ help: use `dyn`: `dyn Cpu` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> libnes/src/cpu/cpu.rs:63:21 [INFO] [stdout] | [INFO] [stdout] 63 | pub memory: Box, [INFO] [stdout] | ^^^^^^^^^^^^ help: use `dyn`: `dyn CpuMemoryMap` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> libnes/src/cpu/cpu.rs:72:19 [INFO] [stdout] | [INFO] [stdout] 72 | (self as &Cpu).fmt(f) [INFO] [stdout] | ^^^ help: use `dyn`: `dyn Cpu` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> libnes/src/cpu/cpu.rs:204:52 [INFO] [stdout] | [INFO] [stdout] 204 | println!("cpu pre: {:?}", self as &mut Cpu); [INFO] [stdout] | ^^^ help: use `dyn`: `dyn Cpu` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> libnes/src/cpu/cpu.rs:216:53 [INFO] [stdout] | [INFO] [stdout] 216 | println!("cpu post: {:?}", self as &mut Cpu); [INFO] [stdout] | ^^^ help: use `dyn`: `dyn Cpu` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> libnes/src/cpu/cpu.rs:224:37 [INFO] [stdout] | [INFO] [stdout] 224 | fn load_mem(&mut self, mem: Box) { [INFO] [stdout] | ^^^^^^^^^^^^ help: use `dyn`: `dyn CpuMemoryMap` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> libnes/src/cpu/cpu.rs:228:46 [INFO] [stdout] | [INFO] [stdout] 228 | fn subscribe_mem(&mut self, handler: Box) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `dyn`: `dyn FnMut(&CpuMemoryAccessEvent)` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> libnes/src/cpu/instr/instructions/helpers.rs:19:42 [INFO] [stdout] | [INFO] [stdout] 19 | pub fn resolve_value(self, cpu: &mut Cpu) -> i8 { [INFO] [stdout] | ^^^ help: use `dyn`: `dyn Cpu` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> libnes/src/cpu/instr/instructions/helpers.rs:34:30 [INFO] [stdout] | [INFO] [stdout] 34 | pub fn get_operand(cpu: &mut Cpu, addr_mode: &AddressingMode) -> GetOperandResult { [INFO] [stdout] | ^^^ help: use `dyn`: `dyn Cpu` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> libnes/src/cpu/instr/instructions/mod.rs:16:18 [INFO] [stdout] | [INFO] [stdout] 16 | do_run: &'op Fn(&'cpu mut T, AddressingMode), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `dyn`: `dyn Fn(&'cpu mut T, AddressingMode)` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> libnes/src/cpu/instr/instructions/mod.rs:37:22 [INFO] [stdout] | [INFO] [stdout] 37 | do_run: &'op Fn(&'cpu mut T, AddressingMode), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `dyn`: `dyn Fn(&'cpu mut T, AddressingMode)` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `...` range patterns are deprecated [INFO] [stdout] --> libnes/src/cpu/mem/address.rs:17:19 [INFO] [stdout] | [INFO] [stdout] 17 | 0x0000...0x07ff => Address::Address(addr), [INFO] [stdout] | ^^^ help: use `..=` for an inclusive range [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(ellipsis_inclusive_range_patterns)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `...` range patterns are deprecated [INFO] [stdout] --> libnes/src/cpu/mem/address.rs:18:19 [INFO] [stdout] | [INFO] [stdout] 18 | 0x0800...0x1fff => Address::Mirror { [INFO] [stdout] | ^^^ help: use `..=` for an inclusive range [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `...` range patterns are deprecated [INFO] [stdout] --> libnes/src/cpu/mem/address.rs:23:19 [INFO] [stdout] | [INFO] [stdout] 23 | 0x2000...0x2007 => Address::Address(addr), [INFO] [stdout] | ^^^ help: use `..=` for an inclusive range [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `...` range patterns are deprecated [INFO] [stdout] --> libnes/src/cpu/mem/address.rs:24:19 [INFO] [stdout] | [INFO] [stdout] 24 | 0x2008...0x3fff => Address::Mirror { [INFO] [stdout] | ^^^ help: use `..=` for an inclusive range [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `...` range patterns are deprecated [INFO] [stdout] --> libnes/src/cpu/mem/address.rs:29:19 [INFO] [stdout] | [INFO] [stdout] 29 | 0x4000...0xffff => Address::Address(addr), [INFO] [stdout] | ^^^ help: use `..=` for an inclusive range [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Observer` [INFO] [stdout] --> libnes/src/cpu/mem/mod.rs:3:29 [INFO] [stdout] | [INFO] [stdout] 3 | use crate::ev::{Observable, Observer, Subject}; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> libnes/src/cpu/mem/mod.rs:10:42 [INFO] [stdout] | [INFO] [stdout] 10 | fn subscribe(&mut self, handler: Box); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `dyn`: `dyn FnMut(&CpuMemoryAccessEvent)` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> libnes/src/cpu/mem/mod.rs:55:42 [INFO] [stdout] | [INFO] [stdout] 55 | fn subscribe(&mut self, handler: Box) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `dyn`: `dyn FnMut(&CpuMemoryAccessEvent)` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> libnes/src/nes/mod.rs:13:41 [INFO] [stdout] | [INFO] [stdout] 13 | fn get_cpu(&mut self) -> Rc>; [INFO] [stdout] | ^^^ help: use `dyn`: `dyn Cpu` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> libnes/src/nes/mod.rs:14:41 [INFO] [stdout] | [INFO] [stdout] 14 | fn get_ppu(&mut self) -> Rc>; [INFO] [stdout] | ^^^ help: use `dyn`: `dyn Ppu` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> libnes/src/nes/mod.rs:18:21 [INFO] [stdout] | [INFO] [stdout] 18 | cpu: Rc>, [INFO] [stdout] | ^^^ help: use `dyn`: `dyn Cpu` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> libnes/src/nes/mod.rs:19:21 [INFO] [stdout] | [INFO] [stdout] 19 | ppu: Rc>, [INFO] [stdout] | ^^^ help: use `dyn`: `dyn Ppu` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> libnes/src/nes/mod.rs:38:41 [INFO] [stdout] | [INFO] [stdout] 38 | fn get_cpu(&mut self) -> Rc> { [INFO] [stdout] | ^^^ help: use `dyn`: `dyn Cpu` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> libnes/src/nes/mod.rs:42:41 [INFO] [stdout] | [INFO] [stdout] 42 | fn get_ppu(&mut self) -> Rc> { [INFO] [stdout] | ^^^ help: use `dyn`: `dyn Ppu` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> libnes/src/nes/mod.rs:48:32 [INFO] [stdout] | [INFO] [stdout] 48 | pub fn new(cpu: Rc>, ppu: Rc>) -> Self { [INFO] [stdout] | ^^^ help: use `dyn`: `dyn Cpu` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> libnes/src/nes/mod.rs:48:55 [INFO] [stdout] | [INFO] [stdout] 48 | pub fn new(cpu: Rc>, ppu: Rc>) -> Self { [INFO] [stdout] | ^^^ help: use `dyn`: `dyn Ppu` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `...` range patterns are deprecated [INFO] [stdout] --> libnes/src/ppu/attr_table.rs:73:14 [INFO] [stdout] | [INFO] [stdout] 73 | i @ 0...3 => ATTRIBUTE_TABLE_ADDRESSES[i as usize], [INFO] [stdout] | ^^^ help: use `..=` for an inclusive range [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `...` range patterns are deprecated [INFO] [stdout] --> libnes/src/ppu/mem/mod.rs:18:19 [INFO] [stdout] | [INFO] [stdout] 18 | 0x0000...0x2fff => Address::Address(addr), [INFO] [stdout] | ^^^ help: use `..=` for an inclusive range [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `...` range patterns are deprecated [INFO] [stdout] --> libnes/src/ppu/mem/mod.rs:19:19 [INFO] [stdout] | [INFO] [stdout] 19 | 0x3000...0x3eff => Address::Mirror { [INFO] [stdout] | ^^^ help: use `..=` for an inclusive range [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `...` range patterns are deprecated [INFO] [stdout] --> libnes/src/ppu/mem/mod.rs:24:19 [INFO] [stdout] | [INFO] [stdout] 24 | 0x3f00...0x3f1f => Address::Address(addr), [INFO] [stdout] | ^^^ help: use `..=` for an inclusive range [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `...` range patterns are deprecated [INFO] [stdout] --> libnes/src/ppu/mem/mod.rs:25:19 [INFO] [stdout] | [INFO] [stdout] 25 | 0x3f20...0x3fff => Address::Mirror { [INFO] [stdout] | ^^^ help: use `..=` for an inclusive range [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `...` range patterns are deprecated [INFO] [stdout] --> libnes/src/ppu/mem/mod.rs:30:19 [INFO] [stdout] | [INFO] [stdout] 30 | 0x4000...0x9fff => Address::Mirror { [INFO] [stdout] | ^^^ help: use `..=` for an inclusive range [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `...` range patterns are deprecated [INFO] [stdout] --> libnes/src/ppu/nametable.rs:105:14 [INFO] [stdout] | [INFO] [stdout] 105 | i @ 0...3 => NAMETABLE_ADDRESSES[i as usize], [INFO] [stdout] | ^^^ help: use `..=` for an inclusive range [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `...` range patterns are deprecated [INFO] [stdout] --> libnes/src/ppu/pattern_table.rs:103:22 [INFO] [stdout] | [INFO] [stdout] 103 | 0...3 => color_val, [INFO] [stdout] | ^^^ help: use `..=` for an inclusive range [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> libnes/src/ppu/mod.rs:55:14 [INFO] [stdout] | [INFO] [stdout] 55 | mem: Box, [INFO] [stdout] | ^^^^^^^^^^^^ help: use `dyn`: `dyn PpuMemoryMap` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> libnes/src/ev/mod.rs:7:42 [INFO] [stdout] | [INFO] [stdout] 7 | fn subscribe(&mut self, handler: Box) -> Rc>>; [INFO] [stdout] | ^^^^^^^^^^^^^^ help: use `dyn`: `dyn FnMut(&TEvent)` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> libnes/src/ev/mod.rs:14:20 [INFO] [stdout] | [INFO] [stdout] 14 | cb: Option>, [INFO] [stdout] | ^^^^^^^^^^^^^^ help: use `dyn`: `dyn FnMut(&TEvent)` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> libnes/src/ev/mod.rs:20:42 [INFO] [stdout] | [INFO] [stdout] 20 | fn subscribe(&mut self, handler: Box) -> Rc>> { [INFO] [stdout] | ^^^^^^^^^^^^^^ help: use `dyn`: `dyn FnMut(&TEvent)` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `#[macro_use]` import [INFO] [stdout] --> libnes/src/lib.rs:3:1 [INFO] [stdout] | [INFO] [stdout] 3 | #[macro_use] [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: type `iNESLoader` should have an upper camel case name [INFO] [stdout] --> libnes/src/cart/ines.rs:16:12 [INFO] [stdout] | [INFO] [stdout] 16 | pub struct iNESLoader {} [INFO] [stdout] | ^^^^^^^^^^ help: convert the identifier to upper camel case: `INesloader` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_camel_case_types)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: type `iNESHeader` should have an upper camel case name [INFO] [stdout] --> libnes/src/cart/ines.rs:127:8 [INFO] [stdout] | [INFO] [stdout] 127 | struct iNESHeader { [INFO] [stdout] | ^^^^^^^^^^ help: convert the identifier to upper camel case: `INesheader` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> libnes/src/cart/mappers/nrom.rs:16:35 [INFO] [stdout] | [INFO] [stdout] 16 | fn map(&self, nes: Rc>, options: MapperOptions) -> Result<(), String> { [INFO] [stdout] | ^^^ help: use `dyn`: `dyn Nes` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(bare_trait_objects)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> libnes/src/cart/mappers/mod.rs:11:35 [INFO] [stdout] | [INFO] [stdout] 11 | fn map(&self, nes: Rc>, options: MapperOptions) -> Result<(), String>; [INFO] [stdout] | ^^^ help: use `dyn`: `dyn Nes` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `iNes` should have an upper camel case name [INFO] [stdout] --> libnes/src/cart/mod.rs:28:5 [INFO] [stdout] | [INFO] [stdout] 28 | iNes, [INFO] [stdout] | ^^^^ help: convert the identifier to upper camel case (notice the capitalization): `INes` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Observer` [INFO] [stdout] --> libnes/src/cpu/cpu.rs:9:29 [INFO] [stdout] | [INFO] [stdout] 9 | use crate::ev::{Observable, Observer}; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> libnes/src/cpu/cpu.rs:30:37 [INFO] [stdout] | [INFO] [stdout] 30 | fn load_mem(&mut self, mem: Box); [INFO] [stdout] | ^^^^^^^^^^^^ help: use `dyn`: `dyn CpuMemoryMap` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> libnes/src/cpu/cpu.rs:31:46 [INFO] [stdout] | [INFO] [stdout] 31 | fn subscribe_mem(&mut self, handler: Box); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `dyn`: `dyn FnMut(&CpuMemoryAccessEvent)` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> libnes/src/cpu/cpu.rs:50:16 [INFO] [stdout] | [INFO] [stdout] 50 | impl Debug for Cpu { [INFO] [stdout] | ^^^ help: use `dyn`: `dyn Cpu` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> libnes/src/cpu/cpu.rs:63:21 [INFO] [stdout] | [INFO] [stdout] 63 | pub memory: Box, [INFO] [stdout] | ^^^^^^^^^^^^ help: use `dyn`: `dyn CpuMemoryMap` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> libnes/src/cpu/cpu.rs:72:19 [INFO] [stdout] | [INFO] [stdout] 72 | (self as &Cpu).fmt(f) [INFO] [stdout] | ^^^ help: use `dyn`: `dyn Cpu` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> libnes/src/cpu/cpu.rs:204:52 [INFO] [stdout] | [INFO] [stdout] 204 | println!("cpu pre: {:?}", self as &mut Cpu); [INFO] [stdout] | ^^^ help: use `dyn`: `dyn Cpu` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> libnes/src/cpu/cpu.rs:216:53 [INFO] [stdout] | [INFO] [stdout] 216 | println!("cpu post: {:?}", self as &mut Cpu); [INFO] [stdout] | ^^^ help: use `dyn`: `dyn Cpu` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> libnes/src/cpu/cpu.rs:224:37 [INFO] [stdout] | [INFO] [stdout] 224 | fn load_mem(&mut self, mem: Box) { [INFO] [stdout] | ^^^^^^^^^^^^ help: use `dyn`: `dyn CpuMemoryMap` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> libnes/src/cpu/cpu.rs:228:46 [INFO] [stdout] | [INFO] [stdout] 228 | fn subscribe_mem(&mut self, handler: Box) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `dyn`: `dyn FnMut(&CpuMemoryAccessEvent)` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> libnes/src/cpu/instr/instructions/helpers.rs:19:42 [INFO] [stdout] | [INFO] [stdout] 19 | pub fn resolve_value(self, cpu: &mut Cpu) -> i8 { [INFO] [stdout] | ^^^ help: use `dyn`: `dyn Cpu` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> libnes/src/cpu/instr/instructions/helpers.rs:34:30 [INFO] [stdout] | [INFO] [stdout] 34 | pub fn get_operand(cpu: &mut Cpu, addr_mode: &AddressingMode) -> GetOperandResult { [INFO] [stdout] | ^^^ help: use `dyn`: `dyn Cpu` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> libnes/src/cpu/instr/instructions/mod.rs:16:18 [INFO] [stdout] | [INFO] [stdout] 16 | do_run: &'op Fn(&'cpu mut T, AddressingMode), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `dyn`: `dyn Fn(&'cpu mut T, AddressingMode)` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> libnes/src/cpu/instr/instructions/mod.rs:37:22 [INFO] [stdout] | [INFO] [stdout] 37 | do_run: &'op Fn(&'cpu mut T, AddressingMode), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `dyn`: `dyn Fn(&'cpu mut T, AddressingMode)` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `...` range patterns are deprecated [INFO] [stdout] --> libnes/src/cpu/mem/address.rs:17:19 [INFO] [stdout] | [INFO] [stdout] 17 | 0x0000...0x07ff => Address::Address(addr), [INFO] [stdout] | ^^^ help: use `..=` for an inclusive range [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(ellipsis_inclusive_range_patterns)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `...` range patterns are deprecated [INFO] [stdout] --> libnes/src/cpu/mem/address.rs:18:19 [INFO] [stdout] | [INFO] [stdout] 18 | 0x0800...0x1fff => Address::Mirror { [INFO] [stdout] | ^^^ help: use `..=` for an inclusive range [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `...` range patterns are deprecated [INFO] [stdout] --> libnes/src/cpu/mem/address.rs:23:19 [INFO] [stdout] | [INFO] [stdout] 23 | 0x2000...0x2007 => Address::Address(addr), [INFO] [stdout] | ^^^ help: use `..=` for an inclusive range [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `...` range patterns are deprecated [INFO] [stdout] --> libnes/src/cpu/mem/address.rs:24:19 [INFO] [stdout] | [INFO] [stdout] 24 | 0x2008...0x3fff => Address::Mirror { [INFO] [stdout] | ^^^ help: use `..=` for an inclusive range [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `...` range patterns are deprecated [INFO] [stdout] --> libnes/src/cpu/mem/address.rs:29:19 [INFO] [stdout] | [INFO] [stdout] 29 | 0x4000...0xffff => Address::Address(addr), [INFO] [stdout] | ^^^ help: use `..=` for an inclusive range [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Observer` [INFO] [stdout] --> libnes/src/cpu/mem/mod.rs:3:29 [INFO] [stdout] | [INFO] [stdout] 3 | use crate::ev::{Observable, Observer, Subject}; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> libnes/src/cpu/mem/mod.rs:10:42 [INFO] [stdout] | [INFO] [stdout] 10 | fn subscribe(&mut self, handler: Box); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `dyn`: `dyn FnMut(&CpuMemoryAccessEvent)` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> libnes/src/cpu/mem/mod.rs:55:42 [INFO] [stdout] | [INFO] [stdout] 55 | fn subscribe(&mut self, handler: Box) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `dyn`: `dyn FnMut(&CpuMemoryAccessEvent)` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> libnes/src/nes/mod.rs:13:41 [INFO] [stdout] | [INFO] [stdout] 13 | fn get_cpu(&mut self) -> Rc>; [INFO] [stdout] | ^^^ help: use `dyn`: `dyn Cpu` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> libnes/src/nes/mod.rs:14:41 [INFO] [stdout] | [INFO] [stdout] 14 | fn get_ppu(&mut self) -> Rc>; [INFO] [stdout] | ^^^ help: use `dyn`: `dyn Ppu` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> libnes/src/nes/mod.rs:18:21 [INFO] [stdout] | [INFO] [stdout] 18 | cpu: Rc>, [INFO] [stdout] | ^^^ help: use `dyn`: `dyn Cpu` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> libnes/src/nes/mod.rs:19:21 [INFO] [stdout] | [INFO] [stdout] 19 | ppu: Rc>, [INFO] [stdout] | ^^^ help: use `dyn`: `dyn Ppu` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> libnes/src/nes/mod.rs:38:41 [INFO] [stdout] | [INFO] [stdout] 38 | fn get_cpu(&mut self) -> Rc> { [INFO] [stdout] | ^^^ help: use `dyn`: `dyn Cpu` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> libnes/src/nes/mod.rs:42:41 [INFO] [stdout] | [INFO] [stdout] 42 | fn get_ppu(&mut self) -> Rc> { [INFO] [stdout] | ^^^ help: use `dyn`: `dyn Ppu` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> libnes/src/nes/mod.rs:48:32 [INFO] [stdout] | [INFO] [stdout] 48 | pub fn new(cpu: Rc>, ppu: Rc>) -> Self { [INFO] [stdout] | ^^^ help: use `dyn`: `dyn Cpu` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> libnes/src/nes/mod.rs:48:55 [INFO] [stdout] | [INFO] [stdout] 48 | pub fn new(cpu: Rc>, ppu: Rc>) -> Self { [INFO] [stdout] | ^^^ help: use `dyn`: `dyn Ppu` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `...` range patterns are deprecated [INFO] [stdout] --> libnes/src/ppu/attr_table.rs:73:14 [INFO] [stdout] | [INFO] [stdout] 73 | i @ 0...3 => ATTRIBUTE_TABLE_ADDRESSES[i as usize], [INFO] [stdout] | ^^^ help: use `..=` for an inclusive range [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `...` range patterns are deprecated [INFO] [stdout] --> libnes/src/ppu/mem/mod.rs:18:19 [INFO] [stdout] | [INFO] [stdout] 18 | 0x0000...0x2fff => Address::Address(addr), [INFO] [stdout] | ^^^ help: use `..=` for an inclusive range [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `...` range patterns are deprecated [INFO] [stdout] --> libnes/src/ppu/mem/mod.rs:19:19 [INFO] [stdout] | [INFO] [stdout] 19 | 0x3000...0x3eff => Address::Mirror { [INFO] [stdout] | ^^^ help: use `..=` for an inclusive range [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `...` range patterns are deprecated [INFO] [stdout] --> libnes/src/ppu/mem/mod.rs:24:19 [INFO] [stdout] | [INFO] [stdout] 24 | 0x3f00...0x3f1f => Address::Address(addr), [INFO] [stdout] | ^^^ help: use `..=` for an inclusive range [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `...` range patterns are deprecated [INFO] [stdout] --> libnes/src/ppu/mem/mod.rs:25:19 [INFO] [stdout] | [INFO] [stdout] 25 | 0x3f20...0x3fff => Address::Mirror { [INFO] [stdout] | ^^^ help: use `..=` for an inclusive range [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `...` range patterns are deprecated [INFO] [stdout] --> libnes/src/ppu/mem/mod.rs:30:19 [INFO] [stdout] | [INFO] [stdout] 30 | 0x4000...0x9fff => Address::Mirror { [INFO] [stdout] | ^^^ help: use `..=` for an inclusive range [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `...` range patterns are deprecated [INFO] [stdout] --> libnes/src/ppu/nametable.rs:105:14 [INFO] [stdout] | [INFO] [stdout] 105 | i @ 0...3 => NAMETABLE_ADDRESSES[i as usize], [INFO] [stdout] | ^^^ help: use `..=` for an inclusive range [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `...` range patterns are deprecated [INFO] [stdout] --> libnes/src/ppu/pattern_table.rs:103:22 [INFO] [stdout] | [INFO] [stdout] 103 | 0...3 => color_val, [INFO] [stdout] | ^^^ help: use `..=` for an inclusive range [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> libnes/src/ppu/mod.rs:55:14 [INFO] [stdout] | [INFO] [stdout] 55 | mem: Box, [INFO] [stdout] | ^^^^^^^^^^^^ help: use `dyn`: `dyn PpuMemoryMap` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> libnes/src/ev/mod.rs:7:42 [INFO] [stdout] | [INFO] [stdout] 7 | fn subscribe(&mut self, handler: Box) -> Rc>>; [INFO] [stdout] | ^^^^^^^^^^^^^^ help: use `dyn`: `dyn FnMut(&TEvent)` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> libnes/src/ev/mod.rs:14:20 [INFO] [stdout] | [INFO] [stdout] 14 | cb: Option>, [INFO] [stdout] | ^^^^^^^^^^^^^^ help: use `dyn`: `dyn FnMut(&TEvent)` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> libnes/src/ev/mod.rs:20:42 [INFO] [stdout] | [INFO] [stdout] 20 | fn subscribe(&mut self, handler: Box) -> Rc>> { [INFO] [stdout] | ^^^^^^^^^^^^^^ help: use `dyn`: `dyn FnMut(&TEvent)` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `crate::cpu::Cpu` [INFO] [stdout] --> libnes/src/cart/ines.rs:7:5 [INFO] [stdout] | [INFO] [stdout] 7 | use crate::cpu::Cpu; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Observable` [INFO] [stdout] --> libnes/src/cpu/cpu.rs:9:17 [INFO] [stdout] | [INFO] [stdout] 9 | use crate::ev::{Observable, Observer}; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unreachable pattern [INFO] [stdout] --> libnes/src/cart/ines.rs:79:9 [INFO] [stdout] | [INFO] [stdout] 79 | _ => return Err(format!("Unexpected non-ASCII sequence in header ID")), [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unreachable_patterns)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unreachable pattern [INFO] [stdout] --> libnes/src/cpu/mem/address.rs:30:13 [INFO] [stdout] | [INFO] [stdout] 30 | _ => panic!(format!( [INFO] [stdout] | ^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `num_ram_banks` [INFO] [stdout] --> libnes/src/cart/ines.rs:102:9 [INFO] [stdout] | [INFO] [stdout] 102 | let num_ram_banks = match take_elems(cart_data, 8, 1) { [INFO] [stdout] | ^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_num_ram_banks` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `crate::cpu::Cpu` [INFO] [stdout] --> libnes/src/cart/ines.rs:7:5 [INFO] [stdout] | [INFO] [stdout] 7 | use crate::cpu::Cpu; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `data` [INFO] [stdout] --> libnes/src/cart/ines.rs:110:9 [INFO] [stdout] | [INFO] [stdout] 110 | data @ _ => {} [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_data` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Observable` [INFO] [stdout] --> libnes/src/cpu/cpu.rs:9:17 [INFO] [stdout] | [INFO] [stdout] 9 | use crate::ev::{Observable, Observer}; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unreachable pattern [INFO] [stdout] --> libnes/src/cart/ines.rs:79:9 [INFO] [stdout] | [INFO] [stdout] 79 | _ => return Err(format!("Unexpected non-ASCII sequence in header ID")), [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unreachable_patterns)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `cpu` [INFO] [stdout] --> libnes/src/cpu/instr/instructions/instrs.rs:426:12 [INFO] [stdout] | [INFO] [stdout] 426 | pub fn nop(cpu: &mut impl Cpu, addr_mode: AddressingMode) { [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_cpu` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `addr_mode` [INFO] [stdout] --> libnes/src/cpu/instr/instructions/instrs.rs:426:32 [INFO] [stdout] | [INFO] [stdout] 426 | pub fn nop(cpu: &mut impl Cpu, addr_mode: AddressingMode) { [INFO] [stdout] | ^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_addr_mode` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `addr_mode` [INFO] [stdout] --> libnes/src/cpu/instr/instructions/instrs.rs:442:32 [INFO] [stdout] | [INFO] [stdout] 442 | pub fn pha(cpu: &mut impl Cpu, addr_mode: AddressingMode) { [INFO] [stdout] | ^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_addr_mode` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `addr_mode` [INFO] [stdout] --> libnes/src/cpu/instr/instructions/instrs.rs:448:32 [INFO] [stdout] | [INFO] [stdout] 448 | pub fn php(cpu: &mut impl Cpu, addr_mode: AddressingMode) { [INFO] [stdout] | ^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_addr_mode` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `addr_mode` [INFO] [stdout] --> libnes/src/cpu/instr/instructions/instrs.rs:454:32 [INFO] [stdout] | [INFO] [stdout] 454 | pub fn pla(cpu: &mut impl Cpu, addr_mode: AddressingMode) { [INFO] [stdout] | ^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_addr_mode` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `addr_mode` [INFO] [stdout] --> libnes/src/cpu/instr/instructions/instrs.rs:465:32 [INFO] [stdout] | [INFO] [stdout] 465 | pub fn plp(cpu: &mut impl Cpu, addr_mode: AddressingMode) { [INFO] [stdout] | ^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_addr_mode` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `addr_mode` [INFO] [stdout] --> libnes/src/cpu/instr/instructions/instrs.rs:543:32 [INFO] [stdout] | [INFO] [stdout] 543 | pub fn rts(cpu: &mut impl Cpu, addr_mode: AddressingMode) { [INFO] [stdout] | ^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_addr_mode` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unreachable pattern [INFO] [stdout] --> libnes/src/cpu/mem/address.rs:30:13 [INFO] [stdout] | [INFO] [stdout] 30 | _ => panic!(format!( [INFO] [stdout] | ^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `num_ram_banks` [INFO] [stdout] --> libnes/src/cart/ines.rs:102:9 [INFO] [stdout] | [INFO] [stdout] 102 | let num_ram_banks = match take_elems(cart_data, 8, 1) { [INFO] [stdout] | ^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_num_ram_banks` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `data` [INFO] [stdout] --> libnes/src/cart/ines.rs:110:9 [INFO] [stdout] | [INFO] [stdout] 110 | data @ _ => {} [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_data` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `cpu` [INFO] [stdout] --> libnes/src/cpu/instr/instructions/instrs.rs:426:12 [INFO] [stdout] | [INFO] [stdout] 426 | pub fn nop(cpu: &mut impl Cpu, addr_mode: AddressingMode) { [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_cpu` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `addr_mode` [INFO] [stdout] --> libnes/src/cpu/instr/instructions/instrs.rs:426:32 [INFO] [stdout] | [INFO] [stdout] 426 | pub fn nop(cpu: &mut impl Cpu, addr_mode: AddressingMode) { [INFO] [stdout] | ^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_addr_mode` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `addr_mode` [INFO] [stdout] --> libnes/src/cpu/instr/instructions/instrs.rs:442:32 [INFO] [stdout] | [INFO] [stdout] 442 | pub fn pha(cpu: &mut impl Cpu, addr_mode: AddressingMode) { [INFO] [stdout] | ^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_addr_mode` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `addr_mode` [INFO] [stdout] --> libnes/src/cpu/instr/instructions/instrs.rs:448:32 [INFO] [stdout] | [INFO] [stdout] 448 | pub fn php(cpu: &mut impl Cpu, addr_mode: AddressingMode) { [INFO] [stdout] | ^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_addr_mode` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `addr_mode` [INFO] [stdout] --> libnes/src/cpu/instr/instructions/instrs.rs:454:32 [INFO] [stdout] | [INFO] [stdout] 454 | pub fn pla(cpu: &mut impl Cpu, addr_mode: AddressingMode) { [INFO] [stdout] | ^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_addr_mode` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `addr_mode` [INFO] [stdout] --> libnes/src/cpu/instr/instructions/instrs.rs:465:32 [INFO] [stdout] | [INFO] [stdout] 465 | pub fn plp(cpu: &mut impl Cpu, addr_mode: AddressingMode) { [INFO] [stdout] | ^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_addr_mode` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `addr_mode` [INFO] [stdout] --> libnes/src/cpu/instr/instructions/instrs.rs:543:32 [INFO] [stdout] | [INFO] [stdout] 543 | pub fn rts(cpu: &mut impl Cpu, addr_mode: AddressingMode) { [INFO] [stdout] | ^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_addr_mode` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field is never read: `oamaddr` [INFO] [stdout] --> libnes/src/ppu/mod.rs:52:5 [INFO] [stdout] | [INFO] [stdout] 52 | oamaddr: u16, [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: panic message is not a string literal [INFO] [stdout] --> libnes/src/cpu/cpu.rs:124:28 [INFO] [stdout] | [INFO] [stdout] 124 | panic!(err); [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_fmt_panic)]` on by default [INFO] [stdout] = note: this is no longer accepted in Rust 2021 [INFO] [stdout] help: add a "{}" format string to Display the message [INFO] [stdout] | [INFO] [stdout] 124 | panic!("{}", err); [INFO] [stdout] | ^^^^^ [INFO] [stdout] help: or use std::panic::panic_any instead [INFO] [stdout] | [INFO] [stdout] 124 | std::panic::panic_any(err); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: panic message is not a string literal [INFO] [stdout] --> libnes/src/cpu/mem/address.rs:30:25 [INFO] [stdout] | [INFO] [stdout] 30 | _ => panic!(format!( [INFO] [stdout] | _________________________^ [INFO] [stdout] 31 | | "Bad address '{:#06x}' while converting from u16 to Address", [INFO] [stdout] 32 | | addr [INFO] [stdout] 33 | | )), [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = note: this is no longer accepted in Rust 2021 [INFO] [stdout] = note: the panic!() macro supports formatting, so there's no need for the format!() macro here [INFO] [stdout] help: remove the `format!(..)` macro call [INFO] [stdout] | [INFO] [stdout] 30 | _ => panic!( [INFO] [stdout] 31 | "Bad address '{:#06x}' while converting from u16 to Address", [INFO] [stdout] 32 | addr [INFO] [stdout] 33 | ), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: panic message is not a string literal [INFO] [stdout] --> libnes/src/ppu/mem/mod.rs:35:25 [INFO] [stdout] | [INFO] [stdout] 35 | _ => panic!(format!( [INFO] [stdout] | _________________________^ [INFO] [stdout] 36 | | "Bad address '{:#06x}' while converting from u16 to Address", [INFO] [stdout] 37 | | addr [INFO] [stdout] 38 | | )), [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = note: this is no longer accepted in Rust 2021 [INFO] [stdout] = note: the panic!() macro supports formatting, so there's no need for the format!() macro here [INFO] [stdout] help: remove the `format!(..)` macro call [INFO] [stdout] | [INFO] [stdout] 35 | _ => panic!( [INFO] [stdout] 36 | "Bad address '{:#06x}' while converting from u16 to Address", [INFO] [stdout] 37 | addr [INFO] [stdout] 38 | ), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this method call currently resolves to `<&[T; N] as IntoIterator>::into_iter` (due to autoref coercions), but that might change in the future when `IntoIterator` impls for arrays are added. [INFO] [stdout] --> libnes/src/ppu/nametable.rs:42:14 [INFO] [stdout] | [INFO] [stdout] 42 | .into_iter() [INFO] [stdout] | ^^^^^^^^^ help: use `.iter()` instead of `.into_iter()` to avoid ambiguity: `iter` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(array_into_iter)]` on by default [INFO] [stdout] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release! [INFO] [stdout] = note: for more information, see issue #66145 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison is useless due to type limits [INFO] [stdout] --> libnes/src/bits/mod.rs:76:8 [INFO] [stdout] | [INFO] [stdout] 76 | if bit_num < 0 || bit_num > 7 { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_comparisons)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 67 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field is never read: `oamaddr` [INFO] [stdout] --> libnes/src/ppu/mod.rs:52:5 [INFO] [stdout] | [INFO] [stdout] 52 | oamaddr: u16, [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking nes v0.1.0 (/opt/rustwide/workdir/nes) [INFO] [stdout] warning: panic message is not a string literal [INFO] [stdout] --> libnes/src/cpu/cpu.rs:124:28 [INFO] [stdout] | [INFO] [stdout] 124 | panic!(err); [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_fmt_panic)]` on by default [INFO] [stdout] = note: this is no longer accepted in Rust 2021 [INFO] [stdout] help: add a "{}" format string to Display the message [INFO] [stdout] | [INFO] [stdout] 124 | panic!("{}", err); [INFO] [stdout] | ^^^^^ [INFO] [stdout] help: or use std::panic::panic_any instead [INFO] [stdout] | [INFO] [stdout] 124 | std::panic::panic_any(err); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: panic message is not a string literal [INFO] [stdout] --> libnes/src/cpu/mem/address.rs:30:25 [INFO] [stdout] | [INFO] [stdout] 30 | _ => panic!(format!( [INFO] [stdout] | _________________________^ [INFO] [stdout] 31 | | "Bad address '{:#06x}' while converting from u16 to Address", [INFO] [stdout] 32 | | addr [INFO] [stdout] 33 | | )), [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = note: this is no longer accepted in Rust 2021 [INFO] [stdout] = note: the panic!() macro supports formatting, so there's no need for the format!() macro here [INFO] [stdout] help: remove the `format!(..)` macro call [INFO] [stdout] | [INFO] [stdout] 30 | _ => panic!( [INFO] [stdout] 31 | "Bad address '{:#06x}' while converting from u16 to Address", [INFO] [stdout] 32 | addr [INFO] [stdout] 33 | ), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: panic message is not a string literal [INFO] [stdout] --> libnes/src/ppu/mem/mod.rs:35:25 [INFO] [stdout] | [INFO] [stdout] 35 | _ => panic!(format!( [INFO] [stdout] | _________________________^ [INFO] [stdout] 36 | | "Bad address '{:#06x}' while converting from u16 to Address", [INFO] [stdout] 37 | | addr [INFO] [stdout] 38 | | )), [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = note: this is no longer accepted in Rust 2021 [INFO] [stdout] = note: the panic!() macro supports formatting, so there's no need for the format!() macro here [INFO] [stdout] help: remove the `format!(..)` macro call [INFO] [stdout] | [INFO] [stdout] 35 | _ => panic!( [INFO] [stdout] 36 | "Bad address '{:#06x}' while converting from u16 to Address", [INFO] [stdout] 37 | addr [INFO] [stdout] 38 | ), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this method call currently resolves to `<&[T; N] as IntoIterator>::into_iter` (due to autoref coercions), but that might change in the future when `IntoIterator` impls for arrays are added. [INFO] [stdout] --> libnes/src/ppu/nametable.rs:42:14 [INFO] [stdout] | [INFO] [stdout] 42 | .into_iter() [INFO] [stdout] | ^^^^^^^^^ help: use `.iter()` instead of `.into_iter()` to avoid ambiguity: `iter` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(array_into_iter)]` on by default [INFO] [stdout] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release! [INFO] [stdout] = note: for more information, see issue #66145 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison is useless due to type limits [INFO] [stdout] --> libnes/src/bits/mod.rs:76:8 [INFO] [stdout] | [INFO] [stdout] 76 | if bit_num < 0 || bit_num > 7 { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_comparisons)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 67 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> nes/bin/debugger.rs:9:47 [INFO] [stdout] | [INFO] [stdout] 9 | pub fn start_debugger<'a>(cpu_ref: Rc>) [INFO] [stdout] | ^^^ help: use `dyn`: `dyn Cpu` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(bare_trait_objects)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> nes/bin/gui.rs:20:21 [INFO] [stdout] | [INFO] [stdout] 20 | nes: Rc>, [INFO] [stdout] | ^^^ help: use `dyn`: `dyn Nes` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> nes/bin/gui.rs:93:34 [INFO] [stdout] | [INFO] [stdout] 93 | pub fn start_gui(nes: Rc>) { [INFO] [stdout] | ^^^ help: use `dyn`: `dyn Nes` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `libnes::cpu::mem::CpuMemoryAccessEvent` [INFO] [stdout] --> nes/bin/mod.rs:12:5 [INFO] [stdout] | [INFO] [stdout] 12 | use libnes::cpu::mem::CpuMemoryAccessEvent; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> nes/bin/mod.rs:102:25 [INFO] [stdout] | [INFO] [stdout] 102 | let cpu: Rc> = nes.clone().borrow_mut().get_cpu().clone(); [INFO] [stdout] | ^^^ help: use `dyn`: `dyn Cpu` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> nes/bin/debugger.rs:9:47 [INFO] [stdout] | [INFO] [stdout] 9 | pub fn start_debugger<'a>(cpu_ref: Rc>) [INFO] [stdout] | ^^^ help: use `dyn`: `dyn Cpu` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(bare_trait_objects)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> nes/bin/gui.rs:20:21 [INFO] [stdout] | [INFO] [stdout] 20 | nes: Rc>, [INFO] [stdout] | ^^^ help: use `dyn`: `dyn Nes` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> nes/bin/gui.rs:93:34 [INFO] [stdout] | [INFO] [stdout] 93 | pub fn start_gui(nes: Rc>) { [INFO] [stdout] | ^^^ help: use `dyn`: `dyn Nes` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `libnes::cpu::mem::CpuMemoryAccessEvent` [INFO] [stdout] --> nes/bin/mod.rs:12:5 [INFO] [stdout] | [INFO] [stdout] 12 | use libnes::cpu::mem::CpuMemoryAccessEvent; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> nes/bin/mod.rs:102:25 [INFO] [stdout] | [INFO] [stdout] 102 | let cpu: Rc> = nes.clone().borrow_mut().get_cpu().clone(); [INFO] [stdout] | ^^^ help: use `dyn`: `dyn Cpu` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Ppu` [INFO] [stdout] --> nes/bin/mod.rs:23:31 [INFO] [stdout] | [INFO] [stdout] 23 | use libnes::ppu::{DefaultPpu, Ppu}; [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `index` is assigned to, but never used [INFO] [stdout] --> nes/bin/gui.rs:48:21 [INFO] [stdout] | [INFO] [stdout] 48 | let mut index = 0; [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] = note: consider using `_index` instead [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `nametable_draw_tile_index` [INFO] [stdout] --> nes/bin/gui.rs:35:13 [INFO] [stdout] | [INFO] [stdout] 35 | let nametable_draw_tile_index = self.debug.nametable_tile_index; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_nametable_draw_tile_index` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `args` [INFO] [stdout] --> nes/bin/gui.rs:87:26 [INFO] [stdout] | [INFO] [stdout] 87 | fn update(&mut self, args: &UpdateArgs) { [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_args` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Ppu` [INFO] [stdout] --> nes/bin/mod.rs:23:31 [INFO] [stdout] | [INFO] [stdout] 23 | use libnes::ppu::{DefaultPpu, Ppu}; [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `index` is assigned to, but never used [INFO] [stdout] --> nes/bin/gui.rs:48:21 [INFO] [stdout] | [INFO] [stdout] 48 | let mut index = 0; [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] = note: consider using `_index` instead [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `nametable_draw_tile_index` [INFO] [stdout] --> nes/bin/gui.rs:35:13 [INFO] [stdout] | [INFO] [stdout] 35 | let nametable_draw_tile_index = self.debug.nametable_tile_index; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_nametable_draw_tile_index` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `args` [INFO] [stdout] --> nes/bin/gui.rs:87:26 [INFO] [stdout] | [INFO] [stdout] 87 | fn update(&mut self, args: &UpdateArgs) { [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_args` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> nes/bin/gui.rs:33:13 [INFO] [stdout] | [INFO] [stdout] 33 | let mut ppu = nes.get_ppu(); [INFO] [stdout] | ----^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: panic message is not a string literal [INFO] [stdout] --> nes/bin/mod.rs:79:21 [INFO] [stdout] | [INFO] [stdout] 79 | _ => panic!(format!("Unsupported rom format '{}'", rom_format_str)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_fmt_panic)]` on by default [INFO] [stdout] = note: this is no longer accepted in Rust 2021 [INFO] [stdout] = note: the panic!() macro supports formatting, so there's no need for the format!() macro here [INFO] [stdout] help: remove the `format!(..)` macro call [INFO] [stdout] | [INFO] [stdout] 79 | _ => panic!("Unsupported rom format '{}'", rom_format_str), [INFO] [stdout] | -- -- [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> nes/bin/gui.rs:33:13 [INFO] [stdout] | [INFO] [stdout] 33 | let mut ppu = nes.get_ppu(); [INFO] [stdout] | ----^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: panic message is not a string literal [INFO] [stdout] --> nes/bin/mod.rs:79:21 [INFO] [stdout] | [INFO] [stdout] 79 | _ => panic!(format!("Unsupported rom format '{}'", rom_format_str)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_fmt_panic)]` on by default [INFO] [stdout] = note: this is no longer accepted in Rust 2021 [INFO] [stdout] = note: the panic!() macro supports formatting, so there's no need for the format!() macro here [INFO] [stdout] help: remove the `format!(..)` macro call [INFO] [stdout] | [INFO] [stdout] 79 | _ => panic!("Unsupported rom format '{}'", rom_format_str), [INFO] [stdout] | -- -- [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 11 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 11 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 2m 59s [INFO] running `Command { std: "docker" "inspect" "88d16fca2aa6158f24d5f0629ef810b1ad02092d7006ecd7612b5d4d48ea3042", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "88d16fca2aa6158f24d5f0629ef810b1ad02092d7006ecd7612b5d4d48ea3042", kill_on_drop: false }` [INFO] [stdout] 88d16fca2aa6158f24d5f0629ef810b1ad02092d7006ecd7612b5d4d48ea3042