[INFO] cloning repository https://github.com/saterus/gilded-rose-rust [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/saterus/gilded-rose-rust" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fsaterus%2Fgilded-rose-rust", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fsaterus%2Fgilded-rose-rust'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 8a8ec0b54b71eb6cfc764dda770b60843d95b73e [INFO] checking saterus/gilded-rose-rust against master#90442458ac46b1d5eed752c316da25450f67285b for pr-81477 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fsaterus%2Fgilded-rose-rust" "/workspace/builds/worker-8/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-8/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/saterus/gilded-rose-rust on toolchain 90442458ac46b1d5eed752c316da25450f67285b [INFO] running `Command { std: "/workspace/cargo-home/bin/cargo" "+90442458ac46b1d5eed752c316da25450f67285b" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/saterus/gilded-rose-rust [INFO] finished tweaking git repo https://github.com/saterus/gilded-rose-rust [INFO] tweaked toml for git repo https://github.com/saterus/gilded-rose-rust written to /workspace/builds/worker-8/source/Cargo.toml [INFO] crate git repo https://github.com/saterus/gilded-rose-rust already has a lockfile, it will not be regenerated [INFO] running `Command { std: "/workspace/cargo-home/bin/cargo" "+90442458ac46b1d5eed752c316da25450f67285b" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-8/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-8/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:34b6a614d2c27851fe6cbf88fbd1137609cefab8b10d0615aaeb6fd47975d74e" "/opt/rustwide/cargo-home/bin/cargo" "+90442458ac46b1d5eed752c316da25450f67285b" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] b5d987d0d1543ed9da228404746ff071529de00932afb081103b68d72c936fc7 [INFO] running `Command { std: "docker" "start" "-a" "b5d987d0d1543ed9da228404746ff071529de00932afb081103b68d72c936fc7", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "b5d987d0d1543ed9da228404746ff071529de00932afb081103b68d72c936fc7", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "b5d987d0d1543ed9da228404746ff071529de00932afb081103b68d72c936fc7", kill_on_drop: false }` [INFO] [stdout] b5d987d0d1543ed9da228404746ff071529de00932afb081103b68d72c936fc7 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-8/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-8/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:34b6a614d2c27851fe6cbf88fbd1137609cefab8b10d0615aaeb6fd47975d74e" "/opt/rustwide/cargo-home/bin/cargo" "+90442458ac46b1d5eed752c316da25450f67285b" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 8bec7708317314f93cad027e9a61beac641533e9d9191b19e0f8fb99fd61040f [INFO] running `Command { std: "docker" "start" "-a" "8bec7708317314f93cad027e9a61beac641533e9d9191b19e0f8fb99fd61040f", kill_on_drop: false }` [INFO] [stderr] Checking gilded_rose v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/main.rs:32:12 [INFO] [stdout] | [INFO] [stdout] 32 | if (items[i].name != "Aged Brie" && items[i].name != "Backstage passes to a TAFKAL80ETC concert") [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/main.rs:34:16 [INFO] [stdout] | [INFO] [stdout] 34 | if (items[i].quality > 0) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/main.rs:36:20 [INFO] [stdout] | [INFO] [stdout] 36 | if (items[i].name != "Sulfuras, Hand of Ragnaros") [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/main.rs:44:16 [INFO] [stdout] | [INFO] [stdout] 44 | if (items[i].quality < 50) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/main.rs:48:20 [INFO] [stdout] | [INFO] [stdout] 48 | if (items[i].name == "Backstage passes to a TAFKAL80ETC concert") [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/main.rs:50:24 [INFO] [stdout] | [INFO] [stdout] 50 | if (items[i].sell_in < 11) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/main.rs:52:28 [INFO] [stdout] | [INFO] [stdout] 52 | if (items[i].quality < 50) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/main.rs:58:24 [INFO] [stdout] | [INFO] [stdout] 58 | if (items[i].sell_in < 6) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/main.rs:60:28 [INFO] [stdout] | [INFO] [stdout] 60 | if (items[i].quality < 50) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/main.rs:69:12 [INFO] [stdout] | [INFO] [stdout] 69 | if (items[i].name != "Sulfuras, Hand of Ragnaros") [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/main.rs:74:12 [INFO] [stdout] | [INFO] [stdout] 74 | if (items[i].sell_in < 0) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/main.rs:76:16 [INFO] [stdout] | [INFO] [stdout] 76 | if (items[i].name != "Aged Brie") [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/main.rs:78:20 [INFO] [stdout] | [INFO] [stdout] 78 | if (items[i].name != "Backstage passes to a TAFKAL80ETC concert") [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/main.rs:80:24 [INFO] [stdout] | [INFO] [stdout] 80 | if (items[i].quality > 0) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/main.rs:82:28 [INFO] [stdout] | [INFO] [stdout] 82 | if (items[i].name != "Sulfuras, Hand of Ragnaros") [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/main.rs:95:20 [INFO] [stdout] | [INFO] [stdout] 95 | if (items[i].quality < 50) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `UpdateQuality` should have a snake case name [INFO] [stdout] --> src/main.rs:28:4 [INFO] [stdout] | [INFO] [stdout] 28 | fn UpdateQuality(items: &mut [Item]) [INFO] [stdout] | ^^^^^^^^^^^^^ help: convert the identifier to snake case: `update_quality` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_snake_case)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/main.rs:32:12 [INFO] [stdout] | [INFO] [stdout] 32 | if (items[i].name != "Aged Brie" && items[i].name != "Backstage passes to a TAFKAL80ETC concert") [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 17 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/main.rs:34:16 [INFO] [stdout] | [INFO] [stdout] 34 | if (items[i].quality > 0) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/main.rs:36:20 [INFO] [stdout] | [INFO] [stdout] 36 | if (items[i].name != "Sulfuras, Hand of Ragnaros") [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/main.rs:44:16 [INFO] [stdout] | [INFO] [stdout] 44 | if (items[i].quality < 50) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/main.rs:48:20 [INFO] [stdout] | [INFO] [stdout] 48 | if (items[i].name == "Backstage passes to a TAFKAL80ETC concert") [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/main.rs:50:24 [INFO] [stdout] | [INFO] [stdout] 50 | if (items[i].sell_in < 11) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/main.rs:52:28 [INFO] [stdout] | [INFO] [stdout] 52 | if (items[i].quality < 50) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/main.rs:58:24 [INFO] [stdout] | [INFO] [stdout] 58 | if (items[i].sell_in < 6) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/main.rs:60:28 [INFO] [stdout] | [INFO] [stdout] 60 | if (items[i].quality < 50) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/main.rs:69:12 [INFO] [stdout] | [INFO] [stdout] 69 | if (items[i].name != "Sulfuras, Hand of Ragnaros") [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/main.rs:74:12 [INFO] [stdout] | [INFO] [stdout] 74 | if (items[i].sell_in < 0) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/main.rs:76:16 [INFO] [stdout] | [INFO] [stdout] 76 | if (items[i].name != "Aged Brie") [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/main.rs:78:20 [INFO] [stdout] | [INFO] [stdout] 78 | if (items[i].name != "Backstage passes to a TAFKAL80ETC concert") [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/main.rs:80:24 [INFO] [stdout] | [INFO] [stdout] 80 | if (items[i].quality > 0) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/main.rs:82:28 [INFO] [stdout] | [INFO] [stdout] 82 | if (items[i].name != "Sulfuras, Hand of Ragnaros") [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/main.rs:95:20 [INFO] [stdout] | [INFO] [stdout] 95 | if (items[i].quality < 50) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `UpdateQuality` should have a snake case name [INFO] [stdout] --> src/main.rs:28:4 [INFO] [stdout] | [INFO] [stdout] 28 | fn UpdateQuality(items: &mut [Item]) [INFO] [stdout] | ^^^^^^^^^^^^^ help: convert the identifier to snake case: `update_quality` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_snake_case)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 17 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.49s [INFO] running `Command { std: "docker" "inspect" "8bec7708317314f93cad027e9a61beac641533e9d9191b19e0f8fb99fd61040f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "8bec7708317314f93cad027e9a61beac641533e9d9191b19e0f8fb99fd61040f", kill_on_drop: false }` [INFO] [stdout] 8bec7708317314f93cad027e9a61beac641533e9d9191b19e0f8fb99fd61040f