[INFO] fetching crate schnorr 0.0.20... [INFO] checking schnorr-0.0.20 against master#5e3f1b148db5bfa27fee52464ae1f5d34c49d77b for pr-75502 [INFO] extracting crate schnorr 0.0.20 into /workspace/builds/worker-8/source [INFO] validating manifest of crates.io crate schnorr 0.0.20 on toolchain 5e3f1b148db5bfa27fee52464ae1f5d34c49d77b [INFO] running `Command { std: "/workspace/cargo-home/bin/cargo" "+5e3f1b148db5bfa27fee52464ae1f5d34c49d77b" "read-manifest" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] started tweaking crates.io crate schnorr 0.0.20 [INFO] finished tweaking crates.io crate schnorr 0.0.20 [INFO] tweaked toml for crates.io crate schnorr 0.0.20 written to /workspace/builds/worker-8/source/Cargo.toml [INFO] running `Command { std: "/workspace/cargo-home/bin/cargo" "+5e3f1b148db5bfa27fee52464ae1f5d34c49d77b" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "/workspace/cargo-home/bin/cargo" "+5e3f1b148db5bfa27fee52464ae1f5d34c49d77b" "fetch" "--locked" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-8/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-8/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "rustops/crates-build-env@sha256:a636fd89d022f18117e1dc8fb37a0a009933cdbbe082814857f0e2024962d47c" "/opt/rustwide/cargo-home/bin/cargo" "+5e3f1b148db5bfa27fee52464ae1f5d34c49d77b" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 75df78cdba30fe46075eca5035c221091054cca6bc45b2afd58979d35a0353d0 [INFO] [stderr] WARNING: Your kernel does not support swap limit capabilities or the cgroup is not mounted. Memory limited without swap. [INFO] running `Command { std: "docker" "start" "-a" "75df78cdba30fe46075eca5035c221091054cca6bc45b2afd58979d35a0353d0", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "75df78cdba30fe46075eca5035c221091054cca6bc45b2afd58979d35a0353d0", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "75df78cdba30fe46075eca5035c221091054cca6bc45b2afd58979d35a0353d0", kill_on_drop: false }` [INFO] [stdout] 75df78cdba30fe46075eca5035c221091054cca6bc45b2afd58979d35a0353d0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-8/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-8/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "rustops/crates-build-env@sha256:a636fd89d022f18117e1dc8fb37a0a009933cdbbe082814857f0e2024962d47c" "/opt/rustwide/cargo-home/bin/cargo" "+5e3f1b148db5bfa27fee52464ae1f5d34c49d77b" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 59409d5d9f016eeea995de7c61dc9012ed2001600e743c3ace21ff5f71fb4940 [INFO] [stderr] WARNING: Your kernel does not support swap limit capabilities or the cgroup is not mounted. Memory limited without swap. [INFO] running `Command { std: "docker" "start" "-a" "59409d5d9f016eeea995de7c61dc9012ed2001600e743c3ace21ff5f71fb4940", kill_on_drop: false }` [INFO] [stderr] Compiling autocfg v1.0.1 [INFO] [stderr] Compiling proc-macro2 v1.0.19 [INFO] [stderr] Compiling unicode-xid v0.2.1 [INFO] [stderr] Compiling syn v1.0.39 [INFO] [stderr] Checking cfg-if v0.1.10 [INFO] [stderr] Compiling libc v0.2.76 [INFO] [stderr] Compiling serde_derive v1.0.115 [INFO] [stderr] Compiling serde v1.0.115 [INFO] [stderr] Compiling byteorder v1.3.4 [INFO] [stderr] Checking lazy_static v1.4.0 [INFO] [stderr] Compiling getrandom v0.1.14 [INFO] [stderr] Checking either v1.6.0 [INFO] [stderr] Compiling ryu v1.0.5 [INFO] [stderr] Compiling memchr v2.3.3 [INFO] [stderr] Compiling crunchy v0.2.2 [INFO] [stderr] Checking fixedbitset v0.2.0 [INFO] [stderr] Compiling packed_simd v0.3.3 [INFO] [stderr] Checking smallvec v1.4.2 [INFO] [stderr] Checking static_assertions v1.1.0 [INFO] [stderr] Checking arrayref v0.3.6 [INFO] [stderr] Checking rustc-hex v2.1.0 [INFO] [stderr] Checking subtle v2.2.3 [INFO] [stderr] Checking constant_time_eq v0.1.5 [INFO] [stderr] Compiling bitflags v1.2.1 [INFO] [stderr] Compiling serde_json v1.0.57 [INFO] [stderr] Checking arrayvec v0.5.1 [INFO] [stderr] Checking itoa v0.4.6 [INFO] [stderr] Checking unicode-width v0.1.8 [INFO] [stderr] Checking subtle v1.0.0 [INFO] [stderr] Checking regex-syntax v0.6.18 [INFO] [stderr] Checking same-file v1.0.6 [INFO] [stderr] Checking oorandom v11.1.2 [INFO] [stderr] Checking hex v0.4.2 [INFO] [stderr] Compiling rayon-core v1.8.0 [INFO] [stderr] Checking itertools v0.9.0 [INFO] [stderr] Checking textwrap v0.11.0 [INFO] [stderr] Compiling cast v0.2.3 [INFO] [stderr] Checking walkdir v2.3.1 [INFO] [stderr] Checking crypto-mac v0.7.0 [INFO] [stderr] Checking blake2b_simd v0.5.10 [INFO] [stderr] Checking blake2 v0.8.1 [INFO] [stderr] Compiling crossbeam-utils v0.7.2 [INFO] [stderr] Compiling memoffset v0.5.5 [INFO] [stderr] Compiling hashbrown v0.8.2 [INFO] [stderr] Compiling crossbeam-epoch v0.8.2 [INFO] [stderr] Compiling indexmap v1.5.1 [INFO] [stderr] Compiling rayon v1.4.0 [INFO] [stderr] Compiling num-traits v0.2.12 [INFO] [stderr] Checking csv-core v0.1.10 [INFO] [stderr] Checking uint v0.8.5 [INFO] [stderr] Checking regex-automata v0.1.9 [INFO] [stderr] Checking clap v2.33.3 [INFO] [stderr] Compiling quote v1.0.7 [INFO] [stderr] Checking num_cpus v1.13.0 [INFO] [stderr] Checking thread-id v3.3.0 [INFO] [stderr] Checking backtrace v0.3.50 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking rand_core v0.5.1 [INFO] [stderr] Checking crossbeam-channel v0.4.3 [INFO] [stderr] Checking rand_chacha v0.2.2 [INFO] [stderr] Checking criterion-plot v0.4.3 [INFO] [stderr] Checking rand v0.7.3 [INFO] [stderr] Checking crossbeam-deque v0.7.3 [INFO] [stderr] Checking petgraph v0.5.1 [INFO] [stderr] Checking regex v1.3.9 [INFO] [stderr] Checking plotters v0.2.15 [INFO] [stderr] Checking parking_lot_core v0.7.2 [INFO] [stderr] Checking parking_lot v0.10.2 [INFO] [stderr] Compiling synstructure v0.12.4 [INFO] [stderr] Compiling zeroize_derive v1.0.0 [INFO] [stderr] Compiling thiserror-impl v1.0.20 [INFO] [stderr] Checking zeroize v1.1.0 [INFO] [stderr] Checking thiserror v1.0.20 [INFO] [stderr] Checking curve25519-dalek v2.1.0 [INFO] [stderr] Checking bytes v0.5.6 [INFO] [stderr] Checking bstr v0.2.13 [INFO] [stderr] Checking serde_cbor v0.11.1 [INFO] [stderr] Checking bincode v1.3.1 [INFO] [stderr] Checking mohan v0.0.53 [INFO] [stderr] Checking csv v1.1.3 [INFO] [stderr] Checking tinytemplate v1.1.0 [INFO] [stderr] Checking criterion v0.3.3 [INFO] [stderr] Checking bacteria v0.0.8 [INFO] [stderr] Checking schnorr v0.0.20 (/opt/rustwide/workdir) [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/threshold.rs:211:17 [INFO] [stdout] | [INFO] [stdout] 211 | ) -> Result<(VerifiableSS), SchnorrError> { [INFO] [stdout] | ^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function cannot return without recursing [INFO] [stdout] --> src/keys/public.rs:173:5 [INFO] [stdout] | [INFO] [stdout] 173 | fn partial_cmp(&self, other: &PublicKey) -> Option { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ cannot return without recursing [INFO] [stdout] 174 | self.partial_cmp(&other) [INFO] [stdout] | ------------------------ recursive call site [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unconditional_recursion)]` on by default [INFO] [stdout] = help: a `loop` may express intention better if this is on purpose [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function cannot return without recursing [INFO] [stdout] --> src/keys/public.rs:179:5 [INFO] [stdout] | [INFO] [stdout] 179 | fn cmp(&self, other: &Self) -> std::cmp::Ordering { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ cannot return without recursing [INFO] [stdout] 180 | self.cmp(&other) [INFO] [stdout] | ---------------- recursive call site [INFO] [stdout] | [INFO] [stdout] = help: a `loop` may express intention better if this is on purpose [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/feldman_vss.rs:101:13 [INFO] [stdout] | [INFO] [stdout] 101 | let mut transcript = Transcript::new(b"VSS"); [INFO] [stdout] | ----^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `X` should have a snake case name [INFO] [stdout] --> src/keys/multikey.rs:43:13 [INFO] [stdout] | [INFO] [stdout] 43 | for X in &pubkeys { [INFO] [stdout] | ^ help: convert the identifier to snake case (notice the capitalization): `x` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_snake_case)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `X` should have a snake case name [INFO] [stdout] --> src/keys/multikey.rs:50:17 [INFO] [stdout] | [INFO] [stdout] 50 | for (i, X) in pubkeys.iter().enumerate() { [INFO] [stdout] | ^ help: convert the identifier to snake case (notice the capitalization): `x` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `X` should have a snake case name [INFO] [stdout] --> src/keys/multikey.rs:52:17 [INFO] [stdout] | [INFO] [stdout] 52 | let X = X.into_point(); [INFO] [stdout] | ^ help: convert the identifier to snake case (notice the capitalization): `x` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `R` should have a snake case name [INFO] [stdout] --> src/multisignature.rs:75:13 [INFO] [stdout] | [INFO] [stdout] 75 | let R = (RISTRETTO_BASEPOINT_POINT * r).compress(); [INFO] [stdout] | ^ help: convert the identifier to snake case: `r` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `R_i` should have a snake case name [INFO] [stdout] --> src/counterparty.rs:33:33 [INFO] [stdout] | [INFO] [stdout] 33 | commitments.iter().map(|R_i| R_i.0).sum() [INFO] [stdout] | ^^^ help: convert the identifier to snake case: `r_i` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `S_i` should have a snake case name [INFO] [stdout] --> src/counterparty.rs:103:13 [INFO] [stdout] | [INFO] [stdout] 103 | let S_i = share * RISTRETTO_BASEPOINT_POINT; [INFO] [stdout] | ^^^ help: convert the identifier to snake case (notice the capitalization): `s_i` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `X_i` should have a snake case name [INFO] [stdout] --> src/counterparty.rs:105:13 [INFO] [stdout] | [INFO] [stdout] 105 | let X_i = self.pubkey.into_point(); [INFO] [stdout] | ^^^ help: convert the identifier to snake case (notice the capitalization): `x_i` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `R` should have a snake case name [INFO] [stdout] --> src/signer.rs:42:5 [INFO] [stdout] | [INFO] [stdout] 42 | R: RistrettoPoint, [INFO] [stdout] | ^ help: convert the identifier to snake case: `r` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `R_i` should have a snake case name [INFO] [stdout] --> src/signer.rs:63:13 [INFO] [stdout] | [INFO] [stdout] 63 | let R_i = NonceCommitment::new(RISTRETTO_BASEPOINT_POINT * r_i); [INFO] [stdout] | ^^^ help: convert the identifier to snake case: `r_i` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `R` should have a snake case name [INFO] [stdout] --> src/signer.rs:122:13 [INFO] [stdout] | [INFO] [stdout] 122 | let R = NonceCommitment::sum(&nonce_commitments); [INFO] [stdout] | ^ help: convert the identifier to snake case: `r` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 14 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `CompressedRistretto`, `IsIdentity`, `RISTRETTO_BASEPOINT_TABLE`, `RistrettoPoint`, `VartimeMultiscalarMul`, `scalar::Scalar` [INFO] [stdout] --> src/signature.rs:390:21 [INFO] [stdout] | [INFO] [stdout] 390 | constants::{RISTRETTO_BASEPOINT_TABLE}, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] 391 | ristretto::{CompressedRistretto, RistrettoPoint}, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^ [INFO] [stdout] 392 | scalar::Scalar, [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] 393 | traits::{IsIdentity, VartimeMultiscalarMul}, [INFO] [stdout] | ^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `BatchVerification`, `SecretKey` [INFO] [stdout] --> src/signature.rs:397:32 [INFO] [stdout] | [INFO] [stdout] 397 | tools::SigningContext, BatchVerification, BatchVerifier, Keypair, PublicKey, SecretKey, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/threshold.rs:211:17 [INFO] [stdout] | [INFO] [stdout] 211 | ) -> Result<(VerifiableSS), SchnorrError> { [INFO] [stdout] | ^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `CompressedRistretto`, `H256`, `IsIdentity`, `RISTRETTO_BASEPOINT_POINT`, `RISTRETTO_BASEPOINT_TABLE`, `VartimeMultiscalarMul`, `blake256`, `mohan_rand` [INFO] [stdout] --> src/threshold_test.rs:14:5 [INFO] [stdout] | [INFO] [stdout] 14 | mohan_rand, [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] 15 | hash::{ [INFO] [stdout] 16 | blake256, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] 17 | H256 [INFO] [stdout] | ^^^^ [INFO] [stdout] ... [INFO] [stdout] 20 | constants::{RISTRETTO_BASEPOINT_POINT, RISTRETTO_BASEPOINT_TABLE}, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] 21 | ristretto::{CompressedRistretto, RistrettoPoint}, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 24 | IsIdentity, [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] 25 | VartimeMultiscalarMul [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `ristretto::CompressedRistretto` [INFO] [stdout] --> src/musig_test.rs:4:20 [INFO] [stdout] | [INFO] [stdout] 4 | use mohan::dalek::{ristretto::CompressedRistretto, scalar::Scalar}; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `child2_prv` [INFO] [stdout] --> src/keys/extended.rs:415:13 [INFO] [stdout] | [INFO] [stdout] 415 | let child2_prv = child_prv.derive_intermediate_key(|prf| prf.append_u64(b"index", 1)); [INFO] [stdout] | ^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_child2_prv` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `child2_pub` [INFO] [stdout] --> src/keys/extended.rs:416:13 [INFO] [stdout] | [INFO] [stdout] 416 | let child2_pub = child_pub.derive_intermediate_key(|prf| prf.append_u64(b"index", 1)); [INFO] [stdout] | ^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_child2_pub` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `leaf_prv` [INFO] [stdout] --> src/keys/extended.rs:419:13 [INFO] [stdout] | [INFO] [stdout] 419 | let leaf_prv = child_prv.derive_key(|prf| prf.append_u64(b"index", 1)); [INFO] [stdout] | ^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_leaf_prv` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `leaf_pub` [INFO] [stdout] --> src/keys/extended.rs:420:13 [INFO] [stdout] | [INFO] [stdout] 420 | let leaf_pub = child_pub.derive_key(|prf| prf.append_u64(b"index", 1)); [INFO] [stdout] | ^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_leaf_pub` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `seed` [INFO] [stdout] --> src/keys/extended.rs:455:13 [INFO] [stdout] | [INFO] [stdout] 455 | let seed = [0u8; 32]; [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_seed` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `xprv` [INFO] [stdout] --> src/keys/extended.rs:456:13 [INFO] [stdout] | [INFO] [stdout] 456 | let xprv = XSecretKey::generate(&mut mohan::mohan_rand()); [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_xprv` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `xprv` [INFO] [stdout] --> src/keys/extended.rs:473:13 [INFO] [stdout] | [INFO] [stdout] 473 | let xprv = XSecretKey::generate(&mut rng).derive_intermediate_key(|t| { [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_xprv` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `xprv` [INFO] [stdout] --> src/keys/extended.rs:495:13 [INFO] [stdout] | [INFO] [stdout] 495 | let xprv = XSecretKey::generate(&mut rng).derive_key(|t| { [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_xprv` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `xpub` [INFO] [stdout] --> src/keys/extended.rs:586:13 [INFO] [stdout] | [INFO] [stdout] 586 | let xpub = xprv.to_public().derive_intermediate_key(|t| { [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_xpub` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `xpub` [INFO] [stdout] --> src/keys/extended.rs:607:13 [INFO] [stdout] | [INFO] [stdout] 607 | let xpub = xprv.to_public().derive_key(|t| { [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_xpub` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `transcripts` [INFO] [stdout] --> src/signature.rs:583:13 [INFO] [stdout] | [INFO] [stdout] 583 | let mut transcripts: Vec = messages.iter().map(|m| ctx.bytes(m)).collect(); [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_transcripts` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function cannot return without recursing [INFO] [stdout] --> src/keys/public.rs:173:5 [INFO] [stdout] | [INFO] [stdout] 173 | fn partial_cmp(&self, other: &PublicKey) -> Option { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ cannot return without recursing [INFO] [stdout] 174 | self.partial_cmp(&other) [INFO] [stdout] | ------------------------ recursive call site [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unconditional_recursion)]` on by default [INFO] [stdout] = help: a `loop` may express intention better if this is on purpose [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function cannot return without recursing [INFO] [stdout] --> src/keys/public.rs:179:5 [INFO] [stdout] | [INFO] [stdout] 179 | fn cmp(&self, other: &Self) -> std::cmp::Ordering { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ cannot return without recursing [INFO] [stdout] 180 | self.cmp(&other) [INFO] [stdout] | ---------------- recursive call site [INFO] [stdout] | [INFO] [stdout] = help: a `loop` may express intention better if this is on purpose [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/signature.rs:583:13 [INFO] [stdout] | [INFO] [stdout] 583 | let mut transcripts: Vec = messages.iter().map(|m| ctx.bytes(m)).collect(); [INFO] [stdout] | ----^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/feldman_vss.rs:101:13 [INFO] [stdout] | [INFO] [stdout] 101 | let mut transcript = Transcript::new(b"VSS"); [INFO] [stdout] | ----^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/feldman_vss.rs:264:13 [INFO] [stdout] | [INFO] [stdout] 264 | let mut transcript = Transcript::new(b"VSS"); [INFO] [stdout] | ----^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/feldman_vss.rs:287:13 [INFO] [stdout] | [INFO] [stdout] 287 | let mut transcript = Transcript::new(b"VSS"); [INFO] [stdout] | ----^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/feldman_vss.rs:335:14 [INFO] [stdout] | [INFO] [stdout] 335 | let mut transcript = Transcript::new(b"VSS"); [INFO] [stdout] | ----^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/feldman_vss.rs:378:14 [INFO] [stdout] | [INFO] [stdout] 378 | let mut transcript = Transcript::new(b"VSS"); [INFO] [stdout] | ----^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/feldman_vss.rs:413:13 [INFO] [stdout] | [INFO] [stdout] 413 | let mut transcript = Transcript::new(b"VSS"); [INFO] [stdout] | ----^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `X` should have a snake case name [INFO] [stdout] --> src/keys/multikey.rs:43:13 [INFO] [stdout] | [INFO] [stdout] 43 | for X in &pubkeys { [INFO] [stdout] | ^ help: convert the identifier to snake case (notice the capitalization): `x` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_snake_case)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `X` should have a snake case name [INFO] [stdout] --> src/keys/multikey.rs:50:17 [INFO] [stdout] | [INFO] [stdout] 50 | for (i, X) in pubkeys.iter().enumerate() { [INFO] [stdout] | ^ help: convert the identifier to snake case (notice the capitalization): `x` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `X` should have a snake case name [INFO] [stdout] --> src/keys/multikey.rs:52:17 [INFO] [stdout] | [INFO] [stdout] 52 | let X = X.into_point(); [INFO] [stdout] | ^ help: convert the identifier to snake case (notice the capitalization): `x` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `R` should have a snake case name [INFO] [stdout] --> src/multisignature.rs:75:13 [INFO] [stdout] | [INFO] [stdout] 75 | let R = (RISTRETTO_BASEPOINT_POINT * r).compress(); [INFO] [stdout] | ^ help: convert the identifier to snake case: `r` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `R_i` should have a snake case name [INFO] [stdout] --> src/counterparty.rs:33:33 [INFO] [stdout] | [INFO] [stdout] 33 | commitments.iter().map(|R_i| R_i.0).sum() [INFO] [stdout] | ^^^ help: convert the identifier to snake case: `r_i` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `S_i` should have a snake case name [INFO] [stdout] --> src/counterparty.rs:103:13 [INFO] [stdout] | [INFO] [stdout] 103 | let S_i = share * RISTRETTO_BASEPOINT_POINT; [INFO] [stdout] | ^^^ help: convert the identifier to snake case (notice the capitalization): `s_i` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `X_i` should have a snake case name [INFO] [stdout] --> src/counterparty.rs:105:13 [INFO] [stdout] | [INFO] [stdout] 105 | let X_i = self.pubkey.into_point(); [INFO] [stdout] | ^^^ help: convert the identifier to snake case (notice the capitalization): `x_i` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `R` should have a snake case name [INFO] [stdout] --> src/signer.rs:42:5 [INFO] [stdout] | [INFO] [stdout] 42 | R: RistrettoPoint, [INFO] [stdout] | ^ help: convert the identifier to snake case: `r` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `R_i` should have a snake case name [INFO] [stdout] --> src/signer.rs:63:13 [INFO] [stdout] | [INFO] [stdout] 63 | let R_i = NonceCommitment::new(RISTRETTO_BASEPOINT_POINT * r_i); [INFO] [stdout] | ^^^ help: convert the identifier to snake case: `r_i` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `R` should have a snake case name [INFO] [stdout] --> src/signer.rs:122:13 [INFO] [stdout] | [INFO] [stdout] 122 | let R = NonceCommitment::sum(&nonce_commitments); [INFO] [stdout] | ^ help: convert the identifier to snake case: `r` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 35 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1m 37s [INFO] running `Command { std: "docker" "inspect" "59409d5d9f016eeea995de7c61dc9012ed2001600e743c3ace21ff5f71fb4940", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "59409d5d9f016eeea995de7c61dc9012ed2001600e743c3ace21ff5f71fb4940", kill_on_drop: false }` [INFO] [stdout] 59409d5d9f016eeea995de7c61dc9012ed2001600e743c3ace21ff5f71fb4940