[INFO] cloning repository https://github.com/jomag/rustboy [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/jomag/rustboy" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fjomag%2Frustboy", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fjomag%2Frustboy'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 5f6d18123a60001bf8675f6e09712cb21cba691b [INFO] checking jomag/rustboy against master#5e3f1b148db5bfa27fee52464ae1f5d34c49d77b for pr-75502 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fjomag%2Frustboy" "/workspace/builds/worker-6/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-6/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/jomag/rustboy on toolchain 5e3f1b148db5bfa27fee52464ae1f5d34c49d77b [INFO] running `Command { std: "/workspace/cargo-home/bin/cargo" "+5e3f1b148db5bfa27fee52464ae1f5d34c49d77b" "read-manifest" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/jomag/rustboy [INFO] finished tweaking git repo https://github.com/jomag/rustboy [INFO] tweaked toml for git repo https://github.com/jomag/rustboy written to /workspace/builds/worker-6/source/Cargo.toml [INFO] crate git repo https://github.com/jomag/rustboy already has a lockfile, it will not be regenerated [INFO] running `Command { std: "/workspace/cargo-home/bin/cargo" "+5e3f1b148db5bfa27fee52464ae1f5d34c49d77b" "fetch" "--locked" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "rustops/crates-build-env@sha256:e18d859f9e32a1da89bc7b2d7d51e13b57342044d1295d9fc0dd0068c58eb3d1" "/opt/rustwide/cargo-home/bin/cargo" "+5e3f1b148db5bfa27fee52464ae1f5d34c49d77b" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 7e3cd844da55770dc8c7c10194a75106ab1e00aabac557b4bd776f81eccf68e3 [INFO] [stderr] WARNING: Your kernel does not support swap limit capabilities or the cgroup is not mounted. Memory limited without swap. [INFO] running `Command { std: "docker" "start" "-a" "7e3cd844da55770dc8c7c10194a75106ab1e00aabac557b4bd776f81eccf68e3", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "7e3cd844da55770dc8c7c10194a75106ab1e00aabac557b4bd776f81eccf68e3", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "7e3cd844da55770dc8c7c10194a75106ab1e00aabac557b4bd776f81eccf68e3", kill_on_drop: false }` [INFO] [stdout] 7e3cd844da55770dc8c7c10194a75106ab1e00aabac557b4bd776f81eccf68e3 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "rustops/crates-build-env@sha256:e18d859f9e32a1da89bc7b2d7d51e13b57342044d1295d9fc0dd0068c58eb3d1" "/opt/rustwide/cargo-home/bin/cargo" "+5e3f1b148db5bfa27fee52464ae1f5d34c49d77b" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 5d3bf1746cad86847d09b2d3f1f25eeeed58fb491c69b72434838f0413da8867 [INFO] [stderr] WARNING: Your kernel does not support swap limit capabilities or the cgroup is not mounted. Memory limited without swap. [INFO] running `Command { std: "docker" "start" "-a" "5d3bf1746cad86847d09b2d3f1f25eeeed58fb491c69b72434838f0413da8867", kill_on_drop: false }` [INFO] [stderr] Compiling autocfg v1.0.0 [INFO] [stderr] Compiling libc v0.2.74 [INFO] [stderr] Compiling bitflags v1.2.1 [INFO] [stderr] Compiling version-compare v0.0.10 [INFO] [stderr] Compiling cfg-if v0.1.10 [INFO] [stderr] Compiling byteorder v1.3.4 [INFO] [stderr] Compiling nix v0.17.0 [INFO] [stderr] Checking adler32 v1.2.0 [INFO] [stderr] Checking void v1.0.2 [INFO] [stderr] Compiling serde v1.0.115 [INFO] [stderr] Compiling sdl2 v0.34.2 [INFO] [stderr] Checking unicode-width v0.1.8 [INFO] [stderr] Checking ansi_term v0.11.0 [INFO] [stderr] Checking strsim v0.8.0 [INFO] [stderr] Checking lazy_static v1.4.0 [INFO] [stderr] Checking vec_map v0.8.2 [INFO] [stderr] Checking ansi_term v0.12.1 [INFO] [stderr] Checking textwrap v0.11.0 [INFO] [stderr] Checking inflate v0.4.5 [INFO] [stderr] Compiling sdl2-sys v0.34.2 [INFO] [stderr] Compiling num-traits v0.2.12 [INFO] [stderr] Compiling num-integer v0.1.43 [INFO] [stderr] Compiling num-iter v0.1.41 [INFO] [stderr] Checking deflate v0.7.20 [INFO] [stderr] Checking png v0.14.1 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking clap v2.33.3 [INFO] [stderr] Checking ctrlc v3.1.6 [INFO] [stderr] Checking rustboy v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: `#[macro_escape]` is a deprecated synonym for `#[macro_use]` [INFO] [stdout] --> src/main.rs:23:1 [INFO] [stdout] | [INFO] [stdout] 23 | #[macro_escape] [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::env` [INFO] [stdout] --> src/main.rs:8:5 [INFO] [stdout] | [INFO] [stdout] 8 | use std::env; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::str::FromStr` [INFO] [stdout] --> src/main.rs:12:5 [INFO] [stdout] | [INFO] [stdout] 12 | use std::str::FromStr; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `AudioQueue` [INFO] [stdout] --> src/main.rs:16:34 [INFO] [stdout] | [INFO] [stdout] 16 | use sdl2::audio::{AudioCallback, AudioQueue, AudioSpecDesired}; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `debug::print_registers` [INFO] [stdout] --> src/macros.rs:1:5 [INFO] [stdout] | [INFO] [stdout] 1 | use debug::print_registers; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `AudioCallback`, `AudioQueue`, `AudioSpecDesired` [INFO] [stdout] --> src/apu.rs:10:19 [INFO] [stdout] | [INFO] [stdout] 10 | use sdl2::audio::{AudioCallback, AudioQueue, AudioSpecDesired}; [INFO] [stdout] | ^^^^^^^^^^^^^ ^^^^^^^^^^ ^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `sdl2::init` [INFO] [stdout] --> src/apu.rs:11:5 [INFO] [stdout] | [INFO] [stdout] 11 | use sdl2::init; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::collections::VecDeque` [INFO] [stdout] --> src/apu.rs:12:5 [INFO] [stdout] | [INFO] [stdout] 12 | use std::collections::VecDeque; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::thread::sleep` [INFO] [stdout] --> src/apu.rs:13:5 [INFO] [stdout] | [INFO] [stdout] 13 | use std::thread::sleep; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::time::Duration` [INFO] [stdout] --> src/apu.rs:14:5 [INFO] [stdout] | [INFO] [stdout] 14 | use std::time::Duration; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `...` range patterns are deprecated [INFO] [stdout] --> src/apu.rs:239:19 [INFO] [stdout] | [INFO] [stdout] 239 | 0xFF10...0xFF14 => self.s1.read_reg(address), [INFO] [stdout] | ^^^ help: use `..=` for an inclusive range [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(ellipsis_inclusive_range_patterns)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `...` range patterns are deprecated [INFO] [stdout] --> src/apu.rs:240:19 [INFO] [stdout] | [INFO] [stdout] 240 | 0xFF15...0xFF19 => self.s2.read_reg(address), [INFO] [stdout] | ^^^ help: use `..=` for an inclusive range [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `...` range patterns are deprecated [INFO] [stdout] --> src/apu.rs:251:19 [INFO] [stdout] | [INFO] [stdout] 251 | 0xFF10...0xFF14 => self.s1.write_reg(address - 0xFF10, value), [INFO] [stdout] | ^^^ help: use `..=` for an inclusive range [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `...` range patterns are deprecated [INFO] [stdout] --> src/apu.rs:252:19 [INFO] [stdout] | [INFO] [stdout] 252 | 0xFF15...0xFF19 => self.s2.write_reg(address - 0xFF15, value), [INFO] [stdout] | ^^^ help: use `..=` for an inclusive range [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `...` range patterns are deprecated [INFO] [stdout] --> src/cartridge.rs:43:19 [INFO] [stdout] | [INFO] [stdout] 43 | 0x2000...0x3FFF => self.rom_offset = (value as usize) * 0x4000, [INFO] [stdout] | ^^^ help: use `..=` for an inclusive range [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/cartridge.rs:80:46 [INFO] [stdout] | [INFO] [stdout] 80 | pub fn load_cartridge(filename: &str) -> Box { [INFO] [stdout] | ^^^^^^^^^ help: use `dyn`: `dyn Cartridge` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(bare_trait_objects)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/cartridge.rs:92:61 [INFO] [stdout] | [INFO] [stdout] 92 | 0 => return Box::new(Cartridge32k::new(rom)) as Box, [INFO] [stdout] | ^^^^^^^^^ help: use `dyn`: `dyn Cartridge` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/cartridge.rs:93:62 [INFO] [stdout] | [INFO] [stdout] 93 | 1 => return Box::new(CartridgeMBC1::new(rom)) as Box, [INFO] [stdout] | ^^^^^^^^^ help: use `dyn`: `dyn Cartridge` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `#[macro_escape]` is a deprecated synonym for `#[macro_use]` [INFO] [stdout] --> src/main.rs:23:1 [INFO] [stdout] | [INFO] [stdout] 23 | #[macro_escape] [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `sdl2::render::Texture` [INFO] [stdout] --> src/lcd.rs:2:5 [INFO] [stdout] | [INFO] [stdout] 2 | use sdl2::render::Texture; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `mmu::ansi_term::Colour::Blue` [INFO] [stdout] --> src/mmu.rs:3:5 [INFO] [stdout] | [INFO] [stdout] 3 | use mmu::ansi_term::Colour::Blue; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `debug::print_registers` [INFO] [stdout] --> src/mmu.rs:19:5 [INFO] [stdout] | [INFO] [stdout] 19 | use debug::print_registers; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/mmu.rs:81:24 [INFO] [stdout] | [INFO] [stdout] 81 | pub cartridge: Box, [INFO] [stdout] | ^^^^^^^^^ help: use `dyn`: `dyn Cartridge` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `...` range patterns are deprecated [INFO] [stdout] --> src/mmu.rs:230:19 [INFO] [stdout] | [INFO] [stdout] 230 | 0x0000...0x00FF => { [INFO] [stdout] | ^^^ help: use `..=` for an inclusive range [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `...` range patterns are deprecated [INFO] [stdout] --> src/mmu.rs:237:19 [INFO] [stdout] | [INFO] [stdout] 237 | 0x0100...0x3FFF => self.cartridge.read(addr), [INFO] [stdout] | ^^^ help: use `..=` for an inclusive range [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `...` range patterns are deprecated [INFO] [stdout] --> src/mmu.rs:238:19 [INFO] [stdout] | [INFO] [stdout] 238 | 0x4000...0x7FFF => self.cartridge.read(addr), // self.romx[(addr - 0x4000) as usize], [INFO] [stdout] | ^^^ help: use `..=` for an inclusive range [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `...` range patterns are deprecated [INFO] [stdout] --> src/mmu.rs:239:19 [INFO] [stdout] | [INFO] [stdout] 239 | 0x8000...0x9FFF => self.lcd.read_display_ram(addr), [INFO] [stdout] | ^^^ help: use `..=` for an inclusive range [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `...` range patterns are deprecated [INFO] [stdout] --> src/mmu.rs:240:19 [INFO] [stdout] | [INFO] [stdout] 240 | 0xA000...0xBFFF => self.external_ram[(addr - 0xA000) as usize], [INFO] [stdout] | ^^^ help: use `..=` for an inclusive range [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `...` range patterns are deprecated [INFO] [stdout] --> src/mmu.rs:241:19 [INFO] [stdout] | [INFO] [stdout] 241 | 0xC000...0xCFFF => self.ram[(addr - 0xC000) as usize], // RAM [INFO] [stdout] | ^^^ help: use `..=` for an inclusive range [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `...` range patterns are deprecated [INFO] [stdout] --> src/mmu.rs:242:19 [INFO] [stdout] | [INFO] [stdout] 242 | 0xD000...0xDFFF => self.ram[(addr - 0xC000) as usize], // RAM (switchable on GBC) [INFO] [stdout] | ^^^ help: use `..=` for an inclusive range [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `...` range patterns are deprecated [INFO] [stdout] --> src/mmu.rs:243:19 [INFO] [stdout] | [INFO] [stdout] 243 | 0xE000...0xFDFF => self.ram[(addr - 0xE000) as usize], // RAM echo [INFO] [stdout] | ^^^ help: use `..=` for an inclusive range [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `...` range patterns are deprecated [INFO] [stdout] --> src/mmu.rs:244:19 [INFO] [stdout] | [INFO] [stdout] 244 | 0xFE00...0xFE9F => { [INFO] [stdout] | ^^^ help: use `..=` for an inclusive range [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `...` range patterns are deprecated [INFO] [stdout] --> src/mmu.rs:252:19 [INFO] [stdout] | [INFO] [stdout] 252 | 0xFEA0...0xFEFF => { [INFO] [stdout] | ^^^ help: use `..=` for an inclusive range [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `...` range patterns are deprecated [INFO] [stdout] --> src/mmu.rs:276:19 [INFO] [stdout] | [INFO] [stdout] 276 | 0xFF10...0xFF26 => self.apu.read_reg(addr), [INFO] [stdout] | ^^^ help: use `..=` for an inclusive range [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `...` range patterns are deprecated [INFO] [stdout] --> src/mmu.rs:279:19 [INFO] [stdout] | [INFO] [stdout] 279 | 0xFF00...0xFF7F => self.io_reg[(addr - 0xFF00) as usize], [INFO] [stdout] | ^^^ help: use `..=` for an inclusive range [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `...` range patterns are deprecated [INFO] [stdout] --> src/mmu.rs:281:19 [INFO] [stdout] | [INFO] [stdout] 281 | 0xFF80...0xFFFE => self.internal_ram[(addr - 0xFF80) as usize], [INFO] [stdout] | ^^^ help: use `..=` for an inclusive range [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `...` range patterns are deprecated [INFO] [stdout] --> src/mmu.rs:321:19 [INFO] [stdout] | [INFO] [stdout] 321 | 0x0000...0x3FFF => self.cartridge.write(addr, value), [INFO] [stdout] | ^^^ help: use `..=` for an inclusive range [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `...` range patterns are deprecated [INFO] [stdout] --> src/mmu.rs:322:19 [INFO] [stdout] | [INFO] [stdout] 322 | 0x4000...0x7FFF => self.cartridge.write(addr, value), [INFO] [stdout] | ^^^ help: use `..=` for an inclusive range [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `...` range patterns are deprecated [INFO] [stdout] --> src/mmu.rs:323:19 [INFO] [stdout] | [INFO] [stdout] 323 | 0x8000...0x9FFF => self.lcd.write_display_ram(addr, value), [INFO] [stdout] | ^^^ help: use `..=` for an inclusive range [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `...` range patterns are deprecated [INFO] [stdout] --> src/mmu.rs:324:19 [INFO] [stdout] | [INFO] [stdout] 324 | 0xA000...0xBFFF => self.external_ram[(addr - 0xA000) as usize] = value, [INFO] [stdout] | ^^^ help: use `..=` for an inclusive range [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `...` range patterns are deprecated [INFO] [stdout] --> src/mmu.rs:325:19 [INFO] [stdout] | [INFO] [stdout] 325 | 0xC000...0xCFFF => self.ram[(addr - 0xC000) as usize] = value, [INFO] [stdout] | ^^^ help: use `..=` for an inclusive range [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `...` range patterns are deprecated [INFO] [stdout] --> src/mmu.rs:326:19 [INFO] [stdout] | [INFO] [stdout] 326 | 0xD000...0xDFFF => self.ram[(addr - 0xC000) as usize] = value, [INFO] [stdout] | ^^^ help: use `..=` for an inclusive range [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `...` range patterns are deprecated [INFO] [stdout] --> src/mmu.rs:327:19 [INFO] [stdout] | [INFO] [stdout] 327 | 0xE000...0xFDFF => self.ram[(addr - 0xE000) as usize] = value, [INFO] [stdout] | ^^^ help: use `..=` for an inclusive range [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `...` range patterns are deprecated [INFO] [stdout] --> src/mmu.rs:328:19 [INFO] [stdout] | [INFO] [stdout] 328 | 0xFE00...0xFE9F => { [INFO] [stdout] | ^^^ help: use `..=` for an inclusive range [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `...` range patterns are deprecated [INFO] [stdout] --> src/mmu.rs:334:19 [INFO] [stdout] | [INFO] [stdout] 334 | 0xFEA0...0xFEFF => {} [INFO] [stdout] | ^^^ help: use `..=` for an inclusive range [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `...` range patterns are deprecated [INFO] [stdout] --> src/mmu.rs:337:19 [INFO] [stdout] | [INFO] [stdout] 337 | 0xFF10...0xFF26 => self.apu.write_reg(addr, value), [INFO] [stdout] | ^^^ help: use `..=` for an inclusive range [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `...` range patterns are deprecated [INFO] [stdout] --> src/mmu.rs:343:19 [INFO] [stdout] | [INFO] [stdout] 343 | 0xFF30...0xFF3F => {} [INFO] [stdout] | ^^^ help: use `..=` for an inclusive range [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `...` range patterns are deprecated [INFO] [stdout] --> src/mmu.rs:383:19 [INFO] [stdout] | [INFO] [stdout] 383 | 0xFF00...0xFF7F => self.io_reg[(addr - 0xFF00) as usize] = value, [INFO] [stdout] | ^^^ help: use `..=` for an inclusive range [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `...` range patterns are deprecated [INFO] [stdout] --> src/mmu.rs:384:19 [INFO] [stdout] | [INFO] [stdout] 384 | 0xFF80...0xFFFE => self.internal_ram[(addr - 0xFF80) as usize] = value, [INFO] [stdout] | ^^^ help: use `..=` for an inclusive range [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::env` [INFO] [stdout] --> src/main.rs:8:5 [INFO] [stdout] | [INFO] [stdout] 8 | use std::env; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::str::FromStr` [INFO] [stdout] --> src/main.rs:12:5 [INFO] [stdout] | [INFO] [stdout] 12 | use std::str::FromStr; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `AudioQueue` [INFO] [stdout] --> src/main.rs:16:34 [INFO] [stdout] | [INFO] [stdout] 16 | use sdl2::audio::{AudioCallback, AudioQueue, AudioSpecDesired}; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `debug::print_registers` [INFO] [stdout] --> src/macros.rs:1:5 [INFO] [stdout] | [INFO] [stdout] 1 | use debug::print_registers; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `AudioCallback`, `AudioQueue`, `AudioSpecDesired` [INFO] [stdout] --> src/apu.rs:10:19 [INFO] [stdout] | [INFO] [stdout] 10 | use sdl2::audio::{AudioCallback, AudioQueue, AudioSpecDesired}; [INFO] [stdout] | ^^^^^^^^^^^^^ ^^^^^^^^^^ ^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `sdl2::init` [INFO] [stdout] --> src/apu.rs:11:5 [INFO] [stdout] | [INFO] [stdout] 11 | use sdl2::init; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::collections::VecDeque` [INFO] [stdout] --> src/apu.rs:12:5 [INFO] [stdout] | [INFO] [stdout] 12 | use std::collections::VecDeque; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::thread::sleep` [INFO] [stdout] --> src/apu.rs:13:5 [INFO] [stdout] | [INFO] [stdout] 13 | use std::thread::sleep; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::time::Duration` [INFO] [stdout] --> src/apu.rs:14:5 [INFO] [stdout] | [INFO] [stdout] 14 | use std::time::Duration; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `...` range patterns are deprecated [INFO] [stdout] --> src/apu.rs:239:19 [INFO] [stdout] | [INFO] [stdout] 239 | 0xFF10...0xFF14 => self.s1.read_reg(address), [INFO] [stdout] | ^^^ help: use `..=` for an inclusive range [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(ellipsis_inclusive_range_patterns)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `...` range patterns are deprecated [INFO] [stdout] --> src/apu.rs:240:19 [INFO] [stdout] | [INFO] [stdout] 240 | 0xFF15...0xFF19 => self.s2.read_reg(address), [INFO] [stdout] | ^^^ help: use `..=` for an inclusive range [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `...` range patterns are deprecated [INFO] [stdout] --> src/apu.rs:251:19 [INFO] [stdout] | [INFO] [stdout] 251 | 0xFF10...0xFF14 => self.s1.write_reg(address - 0xFF10, value), [INFO] [stdout] | ^^^ help: use `..=` for an inclusive range [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `...` range patterns are deprecated [INFO] [stdout] --> src/apu.rs:252:19 [INFO] [stdout] | [INFO] [stdout] 252 | 0xFF15...0xFF19 => self.s2.write_reg(address - 0xFF15, value), [INFO] [stdout] | ^^^ help: use `..=` for an inclusive range [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `...` range patterns are deprecated [INFO] [stdout] --> src/cartridge.rs:43:19 [INFO] [stdout] | [INFO] [stdout] 43 | 0x2000...0x3FFF => self.rom_offset = (value as usize) * 0x4000, [INFO] [stdout] | ^^^ help: use `..=` for an inclusive range [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/cartridge.rs:80:46 [INFO] [stdout] | [INFO] [stdout] 80 | pub fn load_cartridge(filename: &str) -> Box { [INFO] [stdout] | ^^^^^^^^^ help: use `dyn`: `dyn Cartridge` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(bare_trait_objects)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/cartridge.rs:92:61 [INFO] [stdout] | [INFO] [stdout] 92 | 0 => return Box::new(Cartridge32k::new(rom)) as Box, [INFO] [stdout] | ^^^^^^^^^ help: use `dyn`: `dyn Cartridge` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/cartridge.rs:93:62 [INFO] [stdout] | [INFO] [stdout] 93 | 1 => return Box::new(CartridgeMBC1::new(rom)) as Box, [INFO] [stdout] | ^^^^^^^^^ help: use `dyn`: `dyn Cartridge` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `sdl2::render::Texture` [INFO] [stdout] --> src/lcd.rs:2:5 [INFO] [stdout] | [INFO] [stdout] 2 | use sdl2::render::Texture; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `mmu::ansi_term::Colour::Blue` [INFO] [stdout] --> src/mmu.rs:3:5 [INFO] [stdout] | [INFO] [stdout] 3 | use mmu::ansi_term::Colour::Blue; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `debug::print_registers` [INFO] [stdout] --> src/mmu.rs:19:5 [INFO] [stdout] | [INFO] [stdout] 19 | use debug::print_registers; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/mmu.rs:81:24 [INFO] [stdout] | [INFO] [stdout] 81 | pub cartridge: Box, [INFO] [stdout] | ^^^^^^^^^ help: use `dyn`: `dyn Cartridge` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `...` range patterns are deprecated [INFO] [stdout] --> src/mmu.rs:230:19 [INFO] [stdout] | [INFO] [stdout] 230 | 0x0000...0x00FF => { [INFO] [stdout] | ^^^ help: use `..=` for an inclusive range [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `...` range patterns are deprecated [INFO] [stdout] --> src/mmu.rs:237:19 [INFO] [stdout] | [INFO] [stdout] 237 | 0x0100...0x3FFF => self.cartridge.read(addr), [INFO] [stdout] | ^^^ help: use `..=` for an inclusive range [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `...` range patterns are deprecated [INFO] [stdout] --> src/mmu.rs:238:19 [INFO] [stdout] | [INFO] [stdout] 238 | 0x4000...0x7FFF => self.cartridge.read(addr), // self.romx[(addr - 0x4000) as usize], [INFO] [stdout] | ^^^ help: use `..=` for an inclusive range [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `...` range patterns are deprecated [INFO] [stdout] --> src/mmu.rs:239:19 [INFO] [stdout] | [INFO] [stdout] 239 | 0x8000...0x9FFF => self.lcd.read_display_ram(addr), [INFO] [stdout] | ^^^ help: use `..=` for an inclusive range [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `...` range patterns are deprecated [INFO] [stdout] --> src/mmu.rs:240:19 [INFO] [stdout] | [INFO] [stdout] 240 | 0xA000...0xBFFF => self.external_ram[(addr - 0xA000) as usize], [INFO] [stdout] | ^^^ help: use `..=` for an inclusive range [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `...` range patterns are deprecated [INFO] [stdout] --> src/mmu.rs:241:19 [INFO] [stdout] | [INFO] [stdout] 241 | 0xC000...0xCFFF => self.ram[(addr - 0xC000) as usize], // RAM [INFO] [stdout] | ^^^ help: use `..=` for an inclusive range [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `...` range patterns are deprecated [INFO] [stdout] --> src/mmu.rs:242:19 [INFO] [stdout] | [INFO] [stdout] 242 | 0xD000...0xDFFF => self.ram[(addr - 0xC000) as usize], // RAM (switchable on GBC) [INFO] [stdout] | ^^^ help: use `..=` for an inclusive range [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `...` range patterns are deprecated [INFO] [stdout] --> src/mmu.rs:243:19 [INFO] [stdout] | [INFO] [stdout] 243 | 0xE000...0xFDFF => self.ram[(addr - 0xE000) as usize], // RAM echo [INFO] [stdout] | ^^^ help: use `..=` for an inclusive range [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `...` range patterns are deprecated [INFO] [stdout] --> src/mmu.rs:244:19 [INFO] [stdout] | [INFO] [stdout] 244 | 0xFE00...0xFE9F => { [INFO] [stdout] | ^^^ help: use `..=` for an inclusive range [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `...` range patterns are deprecated [INFO] [stdout] --> src/mmu.rs:252:19 [INFO] [stdout] | [INFO] [stdout] 252 | 0xFEA0...0xFEFF => { [INFO] [stdout] | ^^^ help: use `..=` for an inclusive range [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `...` range patterns are deprecated [INFO] [stdout] --> src/mmu.rs:276:19 [INFO] [stdout] | [INFO] [stdout] 276 | 0xFF10...0xFF26 => self.apu.read_reg(addr), [INFO] [stdout] | ^^^ help: use `..=` for an inclusive range [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `...` range patterns are deprecated [INFO] [stdout] --> src/mmu.rs:279:19 [INFO] [stdout] | [INFO] [stdout] 279 | 0xFF00...0xFF7F => self.io_reg[(addr - 0xFF00) as usize], [INFO] [stdout] | ^^^ help: use `..=` for an inclusive range [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `...` range patterns are deprecated [INFO] [stdout] --> src/mmu.rs:281:19 [INFO] [stdout] | [INFO] [stdout] 281 | 0xFF80...0xFFFE => self.internal_ram[(addr - 0xFF80) as usize], [INFO] [stdout] | ^^^ help: use `..=` for an inclusive range [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `...` range patterns are deprecated [INFO] [stdout] --> src/mmu.rs:321:19 [INFO] [stdout] | [INFO] [stdout] 321 | 0x0000...0x3FFF => self.cartridge.write(addr, value), [INFO] [stdout] | ^^^ help: use `..=` for an inclusive range [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `...` range patterns are deprecated [INFO] [stdout] --> src/mmu.rs:322:19 [INFO] [stdout] | [INFO] [stdout] 322 | 0x4000...0x7FFF => self.cartridge.write(addr, value), [INFO] [stdout] | ^^^ help: use `..=` for an inclusive range [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `...` range patterns are deprecated [INFO] [stdout] --> src/mmu.rs:323:19 [INFO] [stdout] | [INFO] [stdout] 323 | 0x8000...0x9FFF => self.lcd.write_display_ram(addr, value), [INFO] [stdout] | ^^^ help: use `..=` for an inclusive range [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `...` range patterns are deprecated [INFO] [stdout] --> src/mmu.rs:324:19 [INFO] [stdout] | [INFO] [stdout] 324 | 0xA000...0xBFFF => self.external_ram[(addr - 0xA000) as usize] = value, [INFO] [stdout] | ^^^ help: use `..=` for an inclusive range [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `...` range patterns are deprecated [INFO] [stdout] --> src/mmu.rs:325:19 [INFO] [stdout] | [INFO] [stdout] 325 | 0xC000...0xCFFF => self.ram[(addr - 0xC000) as usize] = value, [INFO] [stdout] | ^^^ help: use `..=` for an inclusive range [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `...` range patterns are deprecated [INFO] [stdout] --> src/mmu.rs:326:19 [INFO] [stdout] | [INFO] [stdout] 326 | 0xD000...0xDFFF => self.ram[(addr - 0xC000) as usize] = value, [INFO] [stdout] | ^^^ help: use `..=` for an inclusive range [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `...` range patterns are deprecated [INFO] [stdout] --> src/mmu.rs:327:19 [INFO] [stdout] | [INFO] [stdout] 327 | 0xE000...0xFDFF => self.ram[(addr - 0xE000) as usize] = value, [INFO] [stdout] | ^^^ help: use `..=` for an inclusive range [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `...` range patterns are deprecated [INFO] [stdout] --> src/mmu.rs:328:19 [INFO] [stdout] | [INFO] [stdout] 328 | 0xFE00...0xFE9F => { [INFO] [stdout] | ^^^ help: use `..=` for an inclusive range [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `...` range patterns are deprecated [INFO] [stdout] --> src/mmu.rs:334:19 [INFO] [stdout] | [INFO] [stdout] 334 | 0xFEA0...0xFEFF => {} [INFO] [stdout] | ^^^ help: use `..=` for an inclusive range [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `...` range patterns are deprecated [INFO] [stdout] --> src/mmu.rs:337:19 [INFO] [stdout] | [INFO] [stdout] 337 | 0xFF10...0xFF26 => self.apu.write_reg(addr, value), [INFO] [stdout] | ^^^ help: use `..=` for an inclusive range [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `...` range patterns are deprecated [INFO] [stdout] --> src/mmu.rs:343:19 [INFO] [stdout] | [INFO] [stdout] 343 | 0xFF30...0xFF3F => {} [INFO] [stdout] | ^^^ help: use `..=` for an inclusive range [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `...` range patterns are deprecated [INFO] [stdout] --> src/mmu.rs:383:19 [INFO] [stdout] | [INFO] [stdout] 383 | 0xFF00...0xFF7F => self.io_reg[(addr - 0xFF00) as usize] = value, [INFO] [stdout] | ^^^ help: use `..=` for an inclusive range [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `...` range patterns are deprecated [INFO] [stdout] --> src/mmu.rs:384:19 [INFO] [stdout] | [INFO] [stdout] 384 | 0xFF80...0xFFFE => self.internal_ram[(addr - 0xFF80) as usize] = value, [INFO] [stdout] | ^^^ help: use `..=` for an inclusive range [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unreachable pattern [INFO] [stdout] --> src/instructions.rs:2717:17 [INFO] [stdout] | [INFO] [stdout] 2717 | _ => { [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unreachable_patterns)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: multiple patterns covering the same range [INFO] [stdout] --> src/mmu.rs:279:13 [INFO] [stdout] | [INFO] [stdout] 258 | P1_REG => self.buttons.read_p1(), [INFO] [stdout] | ------ this range overlaps on `65280_u16` [INFO] [stdout] ... [INFO] [stdout] 279 | 0xFF00...0xFF7F => self.io_reg[(addr - 0xFF00) as usize], [INFO] [stdout] | ^^^^^^^^^^^^^^^ overlapping patterns [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(overlapping_patterns)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: multiple patterns covering the same range [INFO] [stdout] --> src/mmu.rs:383:13 [INFO] [stdout] | [INFO] [stdout] 348 | P1_REG => self.buttons.write_p1(value), [INFO] [stdout] | ------ this range overlaps on `65280_u16` [INFO] [stdout] ... [INFO] [stdout] 381 | 0xFF7F => {} [INFO] [stdout] | ------ this range overlaps on `65407_u16` [INFO] [stdout] 382 | [INFO] [stdout] 383 | 0xFF00...0xFF7F => self.io_reg[(addr - 0xFF00) as usize] = value, [INFO] [stdout] | ^^^^^^^^^^^^^^^ overlapping patterns [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `spec` [INFO] [stdout] --> src/main.rs:223:52 [INFO] [stdout] | [INFO] [stdout] 223 | .open_playback(None, &desired_audio_spec, |spec| AudioBuffer { [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_spec` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `pitch` [INFO] [stdout] --> src/main.rs:462:54 [INFO] [stdout] | [INFO] [stdout] 462 | .with_lock(None, |buffer: &mut [u8], pitch: usize| { [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_pitch` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `headless` [INFO] [stdout] --> src/main.rs:181:9 [INFO] [stdout] | [INFO] [stdout] 181 | let headless: bool = matches.is_present("headless"); [INFO] [stdout] | ^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_headless` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `record` [INFO] [stdout] --> src/main.rs:182:9 [INFO] [stdout] | [INFO] [stdout] 182 | let record: Option<&str> = matches.value_of("record"); [INFO] [stdout] | ^^^^^^ help: if this is intentional, prefix it with an underscore: `_record` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `record_frame_skip` [INFO] [stdout] --> src/main.rs:183:9 [INFO] [stdout] | [INFO] [stdout] 183 | let record_frame_skip: u32 = parse(matches.value_of("skip"), 3); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_record_frame_skip` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `break_at_frame` [INFO] [stdout] --> src/main.rs:186:9 [INFO] [stdout] | [INFO] [stdout] 186 | let break_at_frame: Option = parse_optional(matches.value_of("break-frame")); [INFO] [stdout] | ^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_break_at_frame` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `exit_at_cycle` [INFO] [stdout] --> src/main.rs:187:9 [INFO] [stdout] | [INFO] [stdout] 187 | let exit_at_cycle: Option = parse_optional(matches.value_of("exit-cycle")); [INFO] [stdout] | ^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_exit_at_cycle` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `lock` [INFO] [stdout] --> src/main.rs:143:15 [INFO] [stdout] | [INFO] [stdout] 143 | let &(ref lock, ref cvar) = &*self.pair; [INFO] [stdout] | ^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_lock` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `address` [INFO] [stdout] --> src/cartridge.rs:67:25 [INFO] [stdout] | [INFO] [stdout] 67 | fn write(&mut self, address: u16, value: u8) {} [INFO] [stdout] | ^^^^^^^ help: if this is intentional, prefix it with an underscore: `_address` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `value` [INFO] [stdout] --> src/cartridge.rs:67:39 [INFO] [stdout] | [INFO] [stdout] 67 | fn write(&mut self, address: u16, value: u8) {} [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_value` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `address` [INFO] [stdout] --> src/cartridge.rs:73:20 [INFO] [stdout] | [INFO] [stdout] 73 | fn read(&self, address: u16) -> u8 { [INFO] [stdout] | ^^^^^^^ help: if this is intentional, prefix it with an underscore: `_address` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `address` [INFO] [stdout] --> src/cartridge.rs:77:25 [INFO] [stdout] | [INFO] [stdout] 77 | fn write(&mut self, address: u16, value: u8) {} [INFO] [stdout] | ^^^^^^^ help: if this is intentional, prefix it with an underscore: `_address` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `value` [INFO] [stdout] --> src/cartridge.rs:77:39 [INFO] [stdout] | [INFO] [stdout] 77 | fn write(&mut self, address: u16, value: u8) {} [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_value` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: value assigned to `tile_data_offset` is never read [INFO] [stdout] --> src/lcd.rs:212:13 [INFO] [stdout] | [INFO] [stdout] 212 | let mut tile_data_offset: u16 = 0; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_assignments)]` on by default [INFO] [stdout] = help: maybe it is overwritten before being read? [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `mmu` [INFO] [stdout] --> src/lcd.rs:378:47 [INFO] [stdout] | [INFO] [stdout] 378 | pub fn old_update(&mut self, cycles: u32, mmu: &mut [u8; 0x10000]) -> bool { [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_mmu` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `value` [INFO] [stdout] --> src/timer.rs:72:33 [INFO] [stdout] | [INFO] [stdout] 72 | pub fn write_div(&mut self, value: u8) { [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_value` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unreachable pattern [INFO] [stdout] --> src/instructions.rs:2717:17 [INFO] [stdout] | [INFO] [stdout] 2717 | _ => { [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unreachable_patterns)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: multiple patterns covering the same range [INFO] [stdout] --> src/mmu.rs:279:13 [INFO] [stdout] | [INFO] [stdout] 258 | P1_REG => self.buttons.read_p1(), [INFO] [stdout] | ------ this range overlaps on `65280_u16` [INFO] [stdout] ... [INFO] [stdout] 279 | 0xFF00...0xFF7F => self.io_reg[(addr - 0xFF00) as usize], [INFO] [stdout] | ^^^^^^^^^^^^^^^ overlapping patterns [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(overlapping_patterns)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: multiple patterns covering the same range [INFO] [stdout] --> src/mmu.rs:383:13 [INFO] [stdout] | [INFO] [stdout] 348 | P1_REG => self.buttons.write_p1(value), [INFO] [stdout] | ------ this range overlaps on `65280_u16` [INFO] [stdout] ... [INFO] [stdout] 381 | 0xFF7F => {} [INFO] [stdout] | ------ this range overlaps on `65407_u16` [INFO] [stdout] 382 | [INFO] [stdout] 383 | 0xFF00...0xFF7F => self.io_reg[(addr - 0xFF00) as usize] = value, [INFO] [stdout] | ^^^^^^^^^^^^^^^ overlapping patterns [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `spec` [INFO] [stdout] --> src/main.rs:223:52 [INFO] [stdout] | [INFO] [stdout] 223 | .open_playback(None, &desired_audio_spec, |spec| AudioBuffer { [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_spec` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `pitch` [INFO] [stdout] --> src/main.rs:462:54 [INFO] [stdout] | [INFO] [stdout] 462 | .with_lock(None, |buffer: &mut [u8], pitch: usize| { [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_pitch` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `headless` [INFO] [stdout] --> src/main.rs:181:9 [INFO] [stdout] | [INFO] [stdout] 181 | let headless: bool = matches.is_present("headless"); [INFO] [stdout] | ^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_headless` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `record` [INFO] [stdout] --> src/main.rs:182:9 [INFO] [stdout] | [INFO] [stdout] 182 | let record: Option<&str> = matches.value_of("record"); [INFO] [stdout] | ^^^^^^ help: if this is intentional, prefix it with an underscore: `_record` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `record_frame_skip` [INFO] [stdout] --> src/main.rs:183:9 [INFO] [stdout] | [INFO] [stdout] 183 | let record_frame_skip: u32 = parse(matches.value_of("skip"), 3); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_record_frame_skip` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `break_at_frame` [INFO] [stdout] --> src/main.rs:186:9 [INFO] [stdout] | [INFO] [stdout] 186 | let break_at_frame: Option = parse_optional(matches.value_of("break-frame")); [INFO] [stdout] | ^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_break_at_frame` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `exit_at_cycle` [INFO] [stdout] --> src/main.rs:187:9 [INFO] [stdout] | [INFO] [stdout] 187 | let exit_at_cycle: Option = parse_optional(matches.value_of("exit-cycle")); [INFO] [stdout] | ^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_exit_at_cycle` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `lock` [INFO] [stdout] --> src/main.rs:143:15 [INFO] [stdout] | [INFO] [stdout] 143 | let &(ref lock, ref cvar) = &*self.pair; [INFO] [stdout] | ^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_lock` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `address` [INFO] [stdout] --> src/cartridge.rs:67:25 [INFO] [stdout] | [INFO] [stdout] 67 | fn write(&mut self, address: u16, value: u8) {} [INFO] [stdout] | ^^^^^^^ help: if this is intentional, prefix it with an underscore: `_address` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `value` [INFO] [stdout] --> src/cartridge.rs:67:39 [INFO] [stdout] | [INFO] [stdout] 67 | fn write(&mut self, address: u16, value: u8) {} [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_value` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `address` [INFO] [stdout] --> src/cartridge.rs:73:20 [INFO] [stdout] | [INFO] [stdout] 73 | fn read(&self, address: u16) -> u8 { [INFO] [stdout] | ^^^^^^^ help: if this is intentional, prefix it with an underscore: `_address` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `address` [INFO] [stdout] --> src/cartridge.rs:77:25 [INFO] [stdout] | [INFO] [stdout] 77 | fn write(&mut self, address: u16, value: u8) {} [INFO] [stdout] | ^^^^^^^ help: if this is intentional, prefix it with an underscore: `_address` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `value` [INFO] [stdout] --> src/cartridge.rs:77:39 [INFO] [stdout] | [INFO] [stdout] 77 | fn write(&mut self, address: u16, value: u8) {} [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_value` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: value assigned to `tile_data_offset` is never read [INFO] [stdout] --> src/lcd.rs:212:13 [INFO] [stdout] | [INFO] [stdout] 212 | let mut tile_data_offset: u16 = 0; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_assignments)]` on by default [INFO] [stdout] = help: maybe it is overwritten before being read? [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `mmu` [INFO] [stdout] --> src/lcd.rs:378:47 [INFO] [stdout] | [INFO] [stdout] 378 | pub fn old_update(&mut self, cycles: u32, mmu: &mut [u8; 0x10000]) -> bool { [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_mmu` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `value` [INFO] [stdout] --> src/timer.rs:72:33 [INFO] [stdout] | [INFO] [stdout] 72 | pub fn write_div(&mut self, value: u8) { [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_value` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/lcd.rs:141:13 [INFO] [stdout] | [INFO] [stdout] 141 | let mut buf_offs = scanline as usize * pitch; [INFO] [stdout] | ----^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/lcd.rs:379:13 [INFO] [stdout] | [INFO] [stdout] 379 | let mut display_update = false; [INFO] [stdout] | ----^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field is never read: `period` [INFO] [stdout] --> src/apu.rs:21:5 [INFO] [stdout] | [INFO] [stdout] 21 | period: u32, [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field is never read: `ctr` [INFO] [stdout] --> src/apu.rs:22:5 [INFO] [stdout] | [INFO] [stdout] 22 | ctr: u32, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field is never read: `volume` [INFO] [stdout] --> src/apu.rs:23:5 [INFO] [stdout] | [INFO] [stdout] 23 | volume: i16, [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field is never read: `nr11` [INFO] [stdout] --> src/apu.rs:26:5 [INFO] [stdout] | [INFO] [stdout] 26 | nr11: u8, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant is never used: `a_or_right_mask` [INFO] [stdout] --> src/buttons.rs:67:5 [INFO] [stdout] | [INFO] [stdout] 67 | const a_or_right_mask: u8 = 1; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant is never used: `b_or_left_mask` [INFO] [stdout] --> src/buttons.rs:68:5 [INFO] [stdout] | [INFO] [stdout] 68 | const b_or_left_mask: u8 = 2; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant is never used: `start_or_down_mask` [INFO] [stdout] --> src/buttons.rs:70:5 [INFO] [stdout] | [INFO] [stdout] 70 | const start_or_down_mask: u8 = 8; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct is never constructed: `Cpu` [INFO] [stdout] --> src/cpu.rs:3:12 [INFO] [stdout] | [INFO] [stdout] 3 | pub struct Cpu { [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated function is never used: `new` [INFO] [stdout] --> src/cpu.rs:8:12 [INFO] [stdout] | [INFO] [stdout] 8 | pub fn new() -> Self { [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function is never used: `log_state` [INFO] [stdout] --> src/debug.rs:18:8 [INFO] [stdout] | [INFO] [stdout] 18 | pub fn log_state(file: &mut File, mmu: &MMU) { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function is never used: `print_ppu_registers` [INFO] [stdout] --> src/debug.rs:140:8 [INFO] [stdout] | [INFO] [stdout] 140 | pub fn print_ppu_registers(mmu: &MMU) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function is never used: `address_type` [INFO] [stdout] --> src/debug.rs:630:8 [INFO] [stdout] | [INFO] [stdout] 630 | pub fn address_type(addr: u16) -> String { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated function is never used: `serialize` [INFO] [stdout] --> src/emu.rs:26:12 [INFO] [stdout] | [INFO] [stdout] 26 | pub fn serialize(&mut self) {} [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function is never used: `op_cycles` [INFO] [stdout] --> src/instructions.rs:4:8 [INFO] [stdout] | [INFO] [stdout] 4 | pub fn op_cycles(op: u8) -> u32 { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated function is never used: `old_update` [INFO] [stdout] --> src/lcd.rs:378:12 [INFO] [stdout] | [INFO] [stdout] 378 | pub fn old_update(&mut self, cycles: u32, mmu: &mut [u8; 0x10000]) -> bool { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant is never used: `NR21_REG` [INFO] [stdout] --> src/mmu.rs:56:1 [INFO] [stdout] | [INFO] [stdout] 56 | pub const NR21_REG: u16 = 0xFF16; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant is never used: `NR22_REG` [INFO] [stdout] --> src/mmu.rs:57:1 [INFO] [stdout] | [INFO] [stdout] 57 | pub const NR22_REG: u16 = 0xFF17; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant is never used: `NR23_REG` [INFO] [stdout] --> src/mmu.rs:58:1 [INFO] [stdout] | [INFO] [stdout] 58 | pub const NR23_REG: u16 = 0xFF18; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant is never used: `NR24_REG` [INFO] [stdout] --> src/mmu.rs:59:1 [INFO] [stdout] | [INFO] [stdout] 59 | pub const NR24_REG: u16 = 0xFF19; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant is never used: `NR30_REG` [INFO] [stdout] --> src/mmu.rs:61:1 [INFO] [stdout] | [INFO] [stdout] 61 | pub const NR30_REG: u16 = 0xFF1A; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant is never used: `NR31_REG` [INFO] [stdout] --> src/mmu.rs:62:1 [INFO] [stdout] | [INFO] [stdout] 62 | pub const NR31_REG: u16 = 0xFF1B; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant is never used: `NR32_REG` [INFO] [stdout] --> src/mmu.rs:63:1 [INFO] [stdout] | [INFO] [stdout] 63 | pub const NR32_REG: u16 = 0xFF1C; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant is never used: `NR33_REG` [INFO] [stdout] --> src/mmu.rs:64:1 [INFO] [stdout] | [INFO] [stdout] 64 | pub const NR33_REG: u16 = 0xFF1D; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant is never used: `NR34_REG` [INFO] [stdout] --> src/mmu.rs:65:1 [INFO] [stdout] | [INFO] [stdout] 65 | pub const NR34_REG: u16 = 0xFF1E; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant is never used: `NR41_REG` [INFO] [stdout] --> src/mmu.rs:67:1 [INFO] [stdout] | [INFO] [stdout] 67 | pub const NR41_REG: u16 = 0xFF20; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant is never used: `NR42_REG` [INFO] [stdout] --> src/mmu.rs:68:1 [INFO] [stdout] | [INFO] [stdout] 68 | pub const NR42_REG: u16 = 0xFF21; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant is never used: `NR43_REG` [INFO] [stdout] --> src/mmu.rs:69:1 [INFO] [stdout] | [INFO] [stdout] 69 | pub const NR43_REG: u16 = 0xFF22; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant is never used: `NR44_REG` [INFO] [stdout] --> src/mmu.rs:70:1 [INFO] [stdout] | [INFO] [stdout] 70 | pub const NR44_REG: u16 = 0xFF23; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant is never used: `OAM_OFFSET` [INFO] [stdout] --> src/mmu.rs:77:1 [INFO] [stdout] | [INFO] [stdout] 77 | pub const OAM_OFFSET: u16 = 0xFE00; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated function is never used: `read_i8` [INFO] [stdout] --> src/mmu.rs:287:12 [INFO] [stdout] | [INFO] [stdout] 287 | pub fn read_i8(&mut self, addr: u16) -> i8 { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated function is never used: `read_u16` [INFO] [stdout] --> src/mmu.rs:297:12 [INFO] [stdout] | [INFO] [stdout] 297 | pub fn read_u16(&mut self, addr: u16) -> u16 { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated function is never used: `pop` [INFO] [stdout] --> src/mmu.rs:393:12 [INFO] [stdout] | [INFO] [stdout] 393 | pub fn pop(&mut self) -> u16 { [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated function is never used: `x_one_cycle` [INFO] [stdout] --> src/timer.rs:88:8 [INFO] [stdout] | [INFO] [stdout] 88 | fn x_one_cycle(&mut self) { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `fps` should have an upper case name [INFO] [stdout] --> src/main.rs:206:11 [INFO] [stdout] | [INFO] [stdout] 206 | const fps: f64 = 60.0; [INFO] [stdout] | ^^^ help: convert the identifier to upper case: `FPS` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_upper_case_globals)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `sample_rate` should have an upper case name [INFO] [stdout] --> src/main.rs:207:11 [INFO] [stdout] | [INFO] [stdout] 207 | const sample_rate: u32 = 48_000; [INFO] [stdout] | ^^^^^^^^^^^ help: convert the identifier to upper case: `SAMPLE_RATE` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `std::sync::MutexGuard` that must be used [INFO] [stdout] --> src/main.rs:446:17 [INFO] [stdout] | [INFO] [stdout] 446 | cvar.wait(consumed).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] = note: if unused the Mutex will immediately unlock [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `p14_mask` should have an upper case name [INFO] [stdout] --> src/buttons.rs:65:11 [INFO] [stdout] | [INFO] [stdout] 65 | const p14_mask: u8 = 1 << 4; [INFO] [stdout] | ^^^^^^^^ help: convert the identifier to upper case: `P14_MASK` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `p15_mask` should have an upper case name [INFO] [stdout] --> src/buttons.rs:66:11 [INFO] [stdout] | [INFO] [stdout] 66 | const p15_mask: u8 = 1 << 5; [INFO] [stdout] | ^^^^^^^^ help: convert the identifier to upper case: `P15_MASK` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `a_or_right_mask` should have an upper case name [INFO] [stdout] --> src/buttons.rs:67:11 [INFO] [stdout] | [INFO] [stdout] 67 | const a_or_right_mask: u8 = 1; [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: convert the identifier to upper case: `A_OR_RIGHT_MASK` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `b_or_left_mask` should have an upper case name [INFO] [stdout] --> src/buttons.rs:68:11 [INFO] [stdout] | [INFO] [stdout] 68 | const b_or_left_mask: u8 = 2; [INFO] [stdout] | ^^^^^^^^^^^^^^ help: convert the identifier to upper case: `B_OR_LEFT_MASK` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `select_or_up_mask` should have an upper case name [INFO] [stdout] --> src/buttons.rs:69:11 [INFO] [stdout] | [INFO] [stdout] 69 | const select_or_up_mask: u8 = 4; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: convert the identifier to upper case: `SELECT_OR_UP_MASK` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `start_or_down_mask` should have an upper case name [INFO] [stdout] --> src/buttons.rs:70:11 [INFO] [stdout] | [INFO] [stdout] 70 | const start_or_down_mask: u8 = 8; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: convert the identifier to upper case: `START_OR_DOWN_MASK` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `std::result::Result` that must be used [INFO] [stdout] --> src/debug.rs:20:5 [INFO] [stdout] | [INFO] [stdout] 20 | / file.write_fmt(format_args!( [INFO] [stdout] 21 | | "A:{:02X} B:{:02X} C:{:02X} D:{:02X} E:{:02X} F:{:02X} H:{:02X} L:{:02X} SP:{:04X} PC:{:04X} Op: {:02x} {:02x} DIV: {:02x}\n", [INFO] [stdout] 22 | | mmu.reg.a, mmu.reg.b, mmu.reg.c, mmu.reg.d, [INFO] [stdout] 23 | | mmu.reg.e, f, mmu.reg.h, mmu.reg.l, [INFO] [stdout] 24 | | mmu.reg.sp, mmu.reg.pc, mmu.direct_read(mmu.reg.pc), mmu.direct_read(mmu.reg.pc + 1), [INFO] [stdout] 25 | | mmu.timer.read_div() [INFO] [stdout] 26 | | )); [INFO] [stdout] | |_______^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 112 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/lcd.rs:141:13 [INFO] [stdout] | [INFO] [stdout] 141 | let mut buf_offs = scanline as usize * pitch; [INFO] [stdout] | ----^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/lcd.rs:379:13 [INFO] [stdout] | [INFO] [stdout] 379 | let mut display_update = false; [INFO] [stdout] | ----^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field is never read: `period` [INFO] [stdout] --> src/apu.rs:21:5 [INFO] [stdout] | [INFO] [stdout] 21 | period: u32, [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field is never read: `ctr` [INFO] [stdout] --> src/apu.rs:22:5 [INFO] [stdout] | [INFO] [stdout] 22 | ctr: u32, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field is never read: `volume` [INFO] [stdout] --> src/apu.rs:23:5 [INFO] [stdout] | [INFO] [stdout] 23 | volume: i16, [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field is never read: `nr11` [INFO] [stdout] --> src/apu.rs:26:5 [INFO] [stdout] | [INFO] [stdout] 26 | nr11: u8, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct is never constructed: `Cpu` [INFO] [stdout] --> src/cpu.rs:3:12 [INFO] [stdout] | [INFO] [stdout] 3 | pub struct Cpu { [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated function is never used: `new` [INFO] [stdout] --> src/cpu.rs:8:12 [INFO] [stdout] | [INFO] [stdout] 8 | pub fn new() -> Self { [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function is never used: `log_state` [INFO] [stdout] --> src/debug.rs:18:8 [INFO] [stdout] | [INFO] [stdout] 18 | pub fn log_state(file: &mut File, mmu: &MMU) { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function is never used: `print_ppu_registers` [INFO] [stdout] --> src/debug.rs:140:8 [INFO] [stdout] | [INFO] [stdout] 140 | pub fn print_ppu_registers(mmu: &MMU) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function is never used: `address_type` [INFO] [stdout] --> src/debug.rs:630:8 [INFO] [stdout] | [INFO] [stdout] 630 | pub fn address_type(addr: u16) -> String { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated function is never used: `serialize` [INFO] [stdout] --> src/emu.rs:26:12 [INFO] [stdout] | [INFO] [stdout] 26 | pub fn serialize(&mut self) {} [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function is never used: `op_cycles` [INFO] [stdout] --> src/instructions.rs:4:8 [INFO] [stdout] | [INFO] [stdout] 4 | pub fn op_cycles(op: u8) -> u32 { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated function is never used: `old_update` [INFO] [stdout] --> src/lcd.rs:378:12 [INFO] [stdout] | [INFO] [stdout] 378 | pub fn old_update(&mut self, cycles: u32, mmu: &mut [u8; 0x10000]) -> bool { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant is never used: `NR21_REG` [INFO] [stdout] --> src/mmu.rs:56:1 [INFO] [stdout] | [INFO] [stdout] 56 | pub const NR21_REG: u16 = 0xFF16; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant is never used: `NR22_REG` [INFO] [stdout] --> src/mmu.rs:57:1 [INFO] [stdout] | [INFO] [stdout] 57 | pub const NR22_REG: u16 = 0xFF17; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant is never used: `NR23_REG` [INFO] [stdout] --> src/mmu.rs:58:1 [INFO] [stdout] | [INFO] [stdout] 58 | pub const NR23_REG: u16 = 0xFF18; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant is never used: `NR24_REG` [INFO] [stdout] --> src/mmu.rs:59:1 [INFO] [stdout] | [INFO] [stdout] 59 | pub const NR24_REG: u16 = 0xFF19; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant is never used: `NR30_REG` [INFO] [stdout] --> src/mmu.rs:61:1 [INFO] [stdout] | [INFO] [stdout] 61 | pub const NR30_REG: u16 = 0xFF1A; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant is never used: `NR31_REG` [INFO] [stdout] --> src/mmu.rs:62:1 [INFO] [stdout] | [INFO] [stdout] 62 | pub const NR31_REG: u16 = 0xFF1B; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant is never used: `NR32_REG` [INFO] [stdout] --> src/mmu.rs:63:1 [INFO] [stdout] | [INFO] [stdout] 63 | pub const NR32_REG: u16 = 0xFF1C; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant is never used: `NR33_REG` [INFO] [stdout] --> src/mmu.rs:64:1 [INFO] [stdout] | [INFO] [stdout] 64 | pub const NR33_REG: u16 = 0xFF1D; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant is never used: `NR34_REG` [INFO] [stdout] --> src/mmu.rs:65:1 [INFO] [stdout] | [INFO] [stdout] 65 | pub const NR34_REG: u16 = 0xFF1E; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant is never used: `NR41_REG` [INFO] [stdout] --> src/mmu.rs:67:1 [INFO] [stdout] | [INFO] [stdout] 67 | pub const NR41_REG: u16 = 0xFF20; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant is never used: `NR42_REG` [INFO] [stdout] --> src/mmu.rs:68:1 [INFO] [stdout] | [INFO] [stdout] 68 | pub const NR42_REG: u16 = 0xFF21; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant is never used: `NR43_REG` [INFO] [stdout] --> src/mmu.rs:69:1 [INFO] [stdout] | [INFO] [stdout] 69 | pub const NR43_REG: u16 = 0xFF22; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant is never used: `NR44_REG` [INFO] [stdout] --> src/mmu.rs:70:1 [INFO] [stdout] | [INFO] [stdout] 70 | pub const NR44_REG: u16 = 0xFF23; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant is never used: `OAM_OFFSET` [INFO] [stdout] --> src/mmu.rs:77:1 [INFO] [stdout] | [INFO] [stdout] 77 | pub const OAM_OFFSET: u16 = 0xFE00; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated function is never used: `read_i8` [INFO] [stdout] --> src/mmu.rs:287:12 [INFO] [stdout] | [INFO] [stdout] 287 | pub fn read_i8(&mut self, addr: u16) -> i8 { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated function is never used: `read_u16` [INFO] [stdout] --> src/mmu.rs:297:12 [INFO] [stdout] | [INFO] [stdout] 297 | pub fn read_u16(&mut self, addr: u16) -> u16 { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated function is never used: `pop` [INFO] [stdout] --> src/mmu.rs:393:12 [INFO] [stdout] | [INFO] [stdout] 393 | pub fn pop(&mut self) -> u16 { [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated function is never used: `x_one_cycle` [INFO] [stdout] --> src/timer.rs:88:8 [INFO] [stdout] | [INFO] [stdout] 88 | fn x_one_cycle(&mut self) { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `fps` should have an upper case name [INFO] [stdout] --> src/main.rs:206:11 [INFO] [stdout] | [INFO] [stdout] 206 | const fps: f64 = 60.0; [INFO] [stdout] | ^^^ help: convert the identifier to upper case: `FPS` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_upper_case_globals)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `sample_rate` should have an upper case name [INFO] [stdout] --> src/main.rs:207:11 [INFO] [stdout] | [INFO] [stdout] 207 | const sample_rate: u32 = 48_000; [INFO] [stdout] | ^^^^^^^^^^^ help: convert the identifier to upper case: `SAMPLE_RATE` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `std::sync::MutexGuard` that must be used [INFO] [stdout] --> src/main.rs:446:17 [INFO] [stdout] | [INFO] [stdout] 446 | cvar.wait(consumed).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] = note: if unused the Mutex will immediately unlock [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `std::result::Result` that must be used [INFO] [stdout] --> src/debug.rs:20:5 [INFO] [stdout] | [INFO] [stdout] 20 | / file.write_fmt(format_args!( [INFO] [stdout] 21 | | "A:{:02X} B:{:02X} C:{:02X} D:{:02X} E:{:02X} F:{:02X} H:{:02X} L:{:02X} SP:{:04X} PC:{:04X} Op: {:02x} {:02x} DIV: {:02x}\n", [INFO] [stdout] 22 | | mmu.reg.a, mmu.reg.b, mmu.reg.c, mmu.reg.d, [INFO] [stdout] 23 | | mmu.reg.e, f, mmu.reg.h, mmu.reg.l, [INFO] [stdout] 24 | | mmu.reg.sp, mmu.reg.pc, mmu.direct_read(mmu.reg.pc), mmu.direct_read(mmu.reg.pc + 1), [INFO] [stdout] 25 | | mmu.timer.read_div() [INFO] [stdout] 26 | | )); [INFO] [stdout] | |_______^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 103 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 28.00s [INFO] running `Command { std: "docker" "inspect" "5d3bf1746cad86847d09b2d3f1f25eeeed58fb491c69b72434838f0413da8867", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "5d3bf1746cad86847d09b2d3f1f25eeeed58fb491c69b72434838f0413da8867", kill_on_drop: false }` [INFO] [stdout] 5d3bf1746cad86847d09b2d3f1f25eeeed58fb491c69b72434838f0413da8867