[INFO] crate redshift 1.0.3 is already in cache [INFO] checking redshift-1.0.3 against try#c8bdaa84ec1b37f18f30375e196a65b7602f3790 for pr-73345 [INFO] extracting crate redshift 1.0.3 into /workspace/builds/worker-13/source [INFO] validating manifest of crates.io crate redshift 1.0.3 on toolchain c8bdaa84ec1b37f18f30375e196a65b7602f3790 [INFO] running `Command { std: "/workspace/cargo-home/bin/cargo" "+c8bdaa84ec1b37f18f30375e196a65b7602f3790" "read-manifest" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] started tweaking crates.io crate redshift 1.0.3 [INFO] finished tweaking crates.io crate redshift 1.0.3 [INFO] tweaked toml for crates.io crate redshift 1.0.3 written to /workspace/builds/worker-13/source/Cargo.toml [INFO] running `Command { std: "/workspace/cargo-home/bin/cargo" "+c8bdaa84ec1b37f18f30375e196a65b7602f3790" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update", kill_on_drop: false }` [INFO] running `Command { std: "/workspace/cargo-home/bin/cargo" "+c8bdaa84ec1b37f18f30375e196a65b7602f3790" "fetch" "--locked" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-13/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-13/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "MAP_USER_ID=0" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--network" "none" "rustops/crates-build-env@sha256:6c9ffe128752d56c8d75334ed354142a5229917ed99767f56566dd8e857ad726" "/opt/rustwide/cargo-home/bin/cargo" "+c8bdaa84ec1b37f18f30375e196a65b7602f3790" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] b864c51722ddb770d29e4c0593e49b6bf91d229938754cf0eefff39e6faeae33 [INFO] [stderr] WARNING: Your kernel does not support swap limit capabilities or the cgroup is not mounted. Memory limited without swap. [INFO] running `Command { std: "docker" "start" "-a" "b864c51722ddb770d29e4c0593e49b6bf91d229938754cf0eefff39e6faeae33", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "b864c51722ddb770d29e4c0593e49b6bf91d229938754cf0eefff39e6faeae33", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "b864c51722ddb770d29e4c0593e49b6bf91d229938754cf0eefff39e6faeae33", kill_on_drop: false }` [INFO] [stdout] b864c51722ddb770d29e4c0593e49b6bf91d229938754cf0eefff39e6faeae33 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-13/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-13/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "MAP_USER_ID=0" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--network" "none" "rustops/crates-build-env@sha256:6c9ffe128752d56c8d75334ed354142a5229917ed99767f56566dd8e857ad726" "/opt/rustwide/cargo-home/bin/cargo" "+c8bdaa84ec1b37f18f30375e196a65b7602f3790" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] d77ab5ed7efb8326766d4d634de6a8e638da014884725a147b62e207a7bbc819 [INFO] [stderr] WARNING: Your kernel does not support swap limit capabilities or the cgroup is not mounted. Memory limited without swap. [INFO] running `Command { std: "docker" "start" "-a" "d77ab5ed7efb8326766d4d634de6a8e638da014884725a147b62e207a7bbc819", kill_on_drop: false }` [INFO] [stderr] sudo: setrlimit(RLIMIT_CORE): Operation not permitted [INFO] [stderr] Checking rustc-serialize v0.3.24 [INFO] [stderr] Checking csv v0.14.7 [INFO] [stderr] Checking redshift v1.0.3 (/opt/rustwide/workdir) [INFO] [stdout] warning: use of deprecated item 'try': use the `?` operator instead [INFO] [stdout] --> src/reader.rs:83:19 [INFO] [stdout] | [INFO] [stdout] 83 | match try!(self.get_next_item()) { [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated item 'try': use the `?` operator instead [INFO] [stdout] --> src/reader.rs:116:30 [INFO] [stdout] | [INFO] [stdout] 116 | if let Some(c) = try!(self.get_next_char(true)) { [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated item 'try': use the `?` operator instead [INFO] [stdout] --> src/reader.rs:129:45 [INFO] [stdout] | [INFO] [stdout] 129 | ... let next_next = try!(self.get_next_char(false)); [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated item 'try': use the `?` operator instead [INFO] [stdout] --> src/reader.rs:189:27 [INFO] [stdout] | [INFO] [stdout] 189 | self.length = try!(self.reader.read(&mut self.buffer)); [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated item 'try': use the `?` operator instead [INFO] [stdout] --> src/writer.rs:132:17 [INFO] [stdout] | [INFO] [stdout] 132 | try!(writer.write(escaped.as_bytes())); [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated item 'try': use the `?` operator instead [INFO] [stdout] --> src/writer.rs:134:21 [INFO] [stdout] | [INFO] [stdout] 134 | try!(writer.write(b"|")); [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated item 'try': use the `?` operator instead [INFO] [stdout] --> src/writer.rs:137:13 [INFO] [stdout] | [INFO] [stdout] 137 | try!(writer.write(b"\n")); [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated item 'try': use the `?` operator instead [INFO] [stdout] --> src/writer.rs:146:17 [INFO] [stdout] | [INFO] [stdout] 146 | try!(writer.write(escaped.as_bytes())); [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated item 'try': use the `?` operator instead [INFO] [stdout] --> src/writer.rs:148:21 [INFO] [stdout] | [INFO] [stdout] 148 | try!(writer.write(b"|")); [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated item 'try': use the `?` operator instead [INFO] [stdout] --> src/writer.rs:151:13 [INFO] [stdout] | [INFO] [stdout] 151 | try!(writer.write(b"\n")); [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated item 'try': use the `?` operator instead [INFO] [stdout] --> src/writer.rs:152:13 [INFO] [stdout] | [INFO] [stdout] 152 | try!(writer.flush()); [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/reader.rs:80:71 [INFO] [stdout] | [INFO] [stdout] 80 | pub fn get_next_row(&mut self) -> Result, Box> { [INFO] [stdout] | ^^^^^ help: use `dyn`: `dyn Error` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(bare_trait_objects)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/reader.rs:102:63 [INFO] [stdout] | [INFO] [stdout] 102 | fn get_next_item(&mut self) -> Result> { [INFO] [stdout] | ^^^^^ help: use `dyn`: `dyn Error` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/reader.rs:187:72 [INFO] [stdout] | [INFO] [stdout] 187 | fn get_next_char(&mut self, eat: bool) -> Result, Box> { [INFO] [stdout] | ^^^^^ help: use `dyn`: `dyn Error` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/writer.rs:40:29 [INFO] [stdout] | [INFO] [stdout] 40 | pub extract_column: Box<(Fn (&T) -> String)>, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/writer.rs:40:30 [INFO] [stdout] | [INFO] [stdout] 40 | pub extract_column: Box<(Fn (&T) -> String)>, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: use `dyn`: `dyn Fn (&T) -> String` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/writer.rs:126:140 [INFO] [stdout] | [INFO] [stdout] 126 | pub fn write_columns(&self, mut writer: W, column_definitions: Vec>, items: Vec) -> Result<(), Box> { [INFO] [stdout] | ^^^^^ help: use `dyn`: `dyn Error` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated item 'try': use the `?` operator instead [INFO] [stdout] --> src/reader.rs:83:19 [INFO] [stdout] | [INFO] [stdout] 83 | match try!(self.get_next_item()) { [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated item 'try': use the `?` operator instead [INFO] [stdout] --> src/reader.rs:116:30 [INFO] [stdout] | [INFO] [stdout] 116 | if let Some(c) = try!(self.get_next_char(true)) { [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated item 'try': use the `?` operator instead [INFO] [stdout] --> src/reader.rs:129:45 [INFO] [stdout] | [INFO] [stdout] 129 | ... let next_next = try!(self.get_next_char(false)); [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated item 'try': use the `?` operator instead [INFO] [stdout] --> src/reader.rs:189:27 [INFO] [stdout] | [INFO] [stdout] 189 | self.length = try!(self.reader.read(&mut self.buffer)); [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated item 'try': use the `?` operator instead [INFO] [stdout] --> src/writer.rs:132:17 [INFO] [stdout] | [INFO] [stdout] 132 | try!(writer.write(escaped.as_bytes())); [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated item 'try': use the `?` operator instead [INFO] [stdout] --> src/writer.rs:134:21 [INFO] [stdout] | [INFO] [stdout] 134 | try!(writer.write(b"|")); [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated item 'try': use the `?` operator instead [INFO] [stdout] --> src/writer.rs:137:13 [INFO] [stdout] | [INFO] [stdout] 137 | try!(writer.write(b"\n")); [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated item 'try': use the `?` operator instead [INFO] [stdout] --> src/writer.rs:146:17 [INFO] [stdout] | [INFO] [stdout] 146 | try!(writer.write(escaped.as_bytes())); [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated item 'try': use the `?` operator instead [INFO] [stdout] --> src/writer.rs:148:21 [INFO] [stdout] | [INFO] [stdout] 148 | try!(writer.write(b"|")); [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated item 'try': use the `?` operator instead [INFO] [stdout] --> src/writer.rs:151:13 [INFO] [stdout] | [INFO] [stdout] 151 | try!(writer.write(b"\n")); [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated item 'try': use the `?` operator instead [INFO] [stdout] --> src/writer.rs:152:13 [INFO] [stdout] | [INFO] [stdout] 152 | try!(writer.flush()); [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/reader.rs:80:71 [INFO] [stdout] | [INFO] [stdout] 80 | pub fn get_next_row(&mut self) -> Result, Box> { [INFO] [stdout] | ^^^^^ help: use `dyn`: `dyn Error` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(bare_trait_objects)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/reader.rs:102:63 [INFO] [stdout] | [INFO] [stdout] 102 | fn get_next_item(&mut self) -> Result> { [INFO] [stdout] | ^^^^^ help: use `dyn`: `dyn Error` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/reader.rs:187:72 [INFO] [stdout] | [INFO] [stdout] 187 | fn get_next_char(&mut self, eat: bool) -> Result, Box> { [INFO] [stdout] | ^^^^^ help: use `dyn`: `dyn Error` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated item 'std::error::Error::description': use the Display impl or to_string() [INFO] [stdout] --> src/reader.rs:55:45 [INFO] [stdout] | [INFO] [stdout] 55 | Err(e) => panic!(String::from(e.description())), [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/writer.rs:40:29 [INFO] [stdout] | [INFO] [stdout] 40 | pub extract_column: Box<(Fn (&T) -> String)>, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/writer.rs:40:30 [INFO] [stdout] | [INFO] [stdout] 40 | pub extract_column: Box<(Fn (&T) -> String)>, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: use `dyn`: `dyn Fn (&T) -> String` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/writer.rs:126:140 [INFO] [stdout] | [INFO] [stdout] 126 | pub fn write_columns(&self, mut writer: W, column_definitions: Vec>, items: Vec) -> Result<(), Box> { [INFO] [stdout] | ^^^^^ help: use `dyn`: `dyn Error` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated item 'std::error::Error::description': use the Display impl or to_string() [INFO] [stdout] --> src/reader.rs:55:45 [INFO] [stdout] | [INFO] [stdout] 55 | Err(e) => panic!(String::from(e.description())), [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `std::result::Result` that must be used [INFO] [stdout] --> src/reader.rs:131:33 [INFO] [stdout] | [INFO] [stdout] 131 | ... self.get_next_char(true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 19 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `std::result::Result` that must be used [INFO] [stdout] --> src/reader.rs:131:33 [INFO] [stdout] | [INFO] [stdout] 131 | ... self.get_next_char(true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 19 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> tests/writer_tests.rs:41:13 [INFO] [stdout] | [INFO] [stdout] 41 | let mut writer = redshift::writer::Writer::new(); [INFO] [stdout] | ----^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `A` should have a snake case name [INFO] [stdout] --> tests/writer_tests.rs:9:13 [INFO] [stdout] | [INFO] [stdout] 9 | pub A: &'a str, [INFO] [stdout] | ^ help: convert the identifier to snake case: `a` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_snake_case)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `B` should have a snake case name [INFO] [stdout] --> tests/writer_tests.rs:10:13 [INFO] [stdout] | [INFO] [stdout] 10 | pub B: &'a str, [INFO] [stdout] | ^ help: convert the identifier to snake case: `b` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `C` should have a snake case name [INFO] [stdout] --> tests/writer_tests.rs:11:13 [INFO] [stdout] | [INFO] [stdout] 11 | pub C: &'a str, [INFO] [stdout] | ^ help: convert the identifier to snake case (notice the capitalization): `c` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 4 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 5.46s [INFO] running `Command { std: "docker" "inspect" "d77ab5ed7efb8326766d4d634de6a8e638da014884725a147b62e207a7bbc819", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "d77ab5ed7efb8326766d4d634de6a8e638da014884725a147b62e207a7bbc819", kill_on_drop: false }` [INFO] [stdout] d77ab5ed7efb8326766d4d634de6a8e638da014884725a147b62e207a7bbc819