[INFO] updating cached repository https://github.com/RoidoChan/nes_emu [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "-c" "remote.origin.fetch=refs/heads/*:refs/heads/*" "fetch" "origin" "--force" "--prune", kill_on_drop: false }` [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 1529638cc99176719994267b30517c2095da680a [INFO] checking RoidoChan/nes_emu against try#c8bdaa84ec1b37f18f30375e196a65b7602f3790 for pr-73345 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FRoidoChan%2Fnes_emu" "/workspace/builds/worker-6/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-6/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/RoidoChan/nes_emu on toolchain c8bdaa84ec1b37f18f30375e196a65b7602f3790 [INFO] running `Command { std: "/workspace/cargo-home/bin/cargo" "+c8bdaa84ec1b37f18f30375e196a65b7602f3790" "read-manifest" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/RoidoChan/nes_emu [INFO] finished tweaking git repo https://github.com/RoidoChan/nes_emu [INFO] tweaked toml for git repo https://github.com/RoidoChan/nes_emu written to /workspace/builds/worker-6/source/Cargo.toml [INFO] crate git repo https://github.com/RoidoChan/nes_emu already has a lockfile, it will not be regenerated [INFO] running `Command { std: "/workspace/cargo-home/bin/cargo" "+c8bdaa84ec1b37f18f30375e196a65b7602f3790" "fetch" "--locked" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "MAP_USER_ID=0" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--network" "none" "rustops/crates-build-env@sha256:6c9ffe128752d56c8d75334ed354142a5229917ed99767f56566dd8e857ad726" "/opt/rustwide/cargo-home/bin/cargo" "+c8bdaa84ec1b37f18f30375e196a65b7602f3790" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stderr] WARNING: Your kernel does not support swap limit capabilities or the cgroup is not mounted. Memory limited without swap. [INFO] [stdout] 8638edbd234f047703966df6b1ebfd7d904e9c70d541c7db32c96a8a84da1cd0 [INFO] running `Command { std: "docker" "start" "-a" "8638edbd234f047703966df6b1ebfd7d904e9c70d541c7db32c96a8a84da1cd0", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "8638edbd234f047703966df6b1ebfd7d904e9c70d541c7db32c96a8a84da1cd0", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "8638edbd234f047703966df6b1ebfd7d904e9c70d541c7db32c96a8a84da1cd0", kill_on_drop: false }` [INFO] [stdout] 8638edbd234f047703966df6b1ebfd7d904e9c70d541c7db32c96a8a84da1cd0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "MAP_USER_ID=0" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--network" "none" "rustops/crates-build-env@sha256:6c9ffe128752d56c8d75334ed354142a5229917ed99767f56566dd8e857ad726" "/opt/rustwide/cargo-home/bin/cargo" "+c8bdaa84ec1b37f18f30375e196a65b7602f3790" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stderr] WARNING: Your kernel does not support swap limit capabilities or the cgroup is not mounted. Memory limited without swap. [INFO] [stdout] 0ce9e9aff641e92b913a348eb9cb86a0b442c25452fdcb92bfef189dbab1a13e [INFO] running `Command { std: "docker" "start" "-a" "0ce9e9aff641e92b913a348eb9cb86a0b442c25452fdcb92bfef189dbab1a13e", kill_on_drop: false }` [INFO] [stderr] sudo: setrlimit(RLIMIT_CORE): Operation not permitted [INFO] [stderr] Checking nes-emu v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `*` [INFO] [stdout] --> src/cpu/adc.rs:4:26 [INFO] [stdout] | [INFO] [stdout] 4 | use crate::memory::{RAM, *}; [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `super::flags` [INFO] [stdout] --> src/cpu/and.rs:5:5 [INFO] [stdout] | [INFO] [stdout] 5 | use super::flags; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `*` [INFO] [stdout] --> src/cpu/misc_instructions.rs:2:26 [INFO] [stdout] | [INFO] [stdout] 2 | use crate::memory::{RAM, *}; [INFO] [stdout] | ^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `crate::mem_map` [INFO] [stdout] --> src/cpu/misc_instructions.rs:4:5 [INFO] [stdout] | [INFO] [stdout] 4 | use crate::mem_map; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `*` [INFO] [stdout] --> src/cpu/jumps.rs:2:26 [INFO] [stdout] | [INFO] [stdout] 2 | use crate::memory::{RAM, *}; [INFO] [stdout] | ^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `crate::mem_map` [INFO] [stdout] --> src/cpu/jumps.rs:3:5 [INFO] [stdout] | [INFO] [stdout] 3 | use crate::mem_map; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `*` [INFO] [stdout] --> src/cpu/increment_decrement.rs:3:21 [INFO] [stdout] | [INFO] [stdout] 3 | use crate::memory::{*, RAM}; [INFO] [stdout] | ^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `*` [INFO] [stdout] --> src/cpu/compare.rs:3:26 [INFO] [stdout] | [INFO] [stdout] 3 | use crate::memory::{RAM, *}; [INFO] [stdout] | ^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `*` [INFO] [stdout] --> src/cpu/or.rs:4:26 [INFO] [stdout] | [INFO] [stdout] 4 | use crate::memory::{RAM, *}; [INFO] [stdout] | ^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `*` [INFO] [stdout] --> src/cpu/sub.rs:3:26 [INFO] [stdout] | [INFO] [stdout] 3 | use crate::memory::{RAM, *}; [INFO] [stdout] | ^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around assigned value [INFO] [stdout] --> src/ppu/ppu.rs:150:37 [INFO] [stdout] | [INFO] [stdout] 150 | self.PPUADDR.address |= ((byte_val as u16) as usize); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: type `ppuCtrl` should have an upper camel case name [INFO] [stdout] --> src/ppu/ppu.rs:163:8 [INFO] [stdout] | [INFO] [stdout] 163 | struct ppuCtrl { [INFO] [stdout] | ^^^^^^^ help: convert the identifier to upper camel case: `PpuCtrl` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_camel_case_types)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: type `ppuMask` should have an upper camel case name [INFO] [stdout] --> src/ppu/ppu.rs:186:8 [INFO] [stdout] | [INFO] [stdout] 186 | struct ppuMask { [INFO] [stdout] | ^^^^^^^ help: convert the identifier to upper camel case: `PpuMask` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: type `ppuStatus` should have an upper camel case name [INFO] [stdout] --> src/ppu/ppu.rs:198:8 [INFO] [stdout] | [INFO] [stdout] 198 | struct ppuStatus { [INFO] [stdout] | ^^^^^^^^^ help: convert the identifier to upper camel case: `PpuStatus` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: type `ppuScroll` should have an upper camel case name [INFO] [stdout] --> src/ppu/ppu.rs:205:8 [INFO] [stdout] | [INFO] [stdout] 205 | struct ppuScroll{ [INFO] [stdout] | ^^^^^^^^^ help: convert the identifier to upper camel case: `PpuScroll` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: type `ppuAddr` should have an upper camel case name [INFO] [stdout] --> src/ppu/ppu.rs:212:8 [INFO] [stdout] | [INFO] [stdout] 212 | struct ppuAddr { [INFO] [stdout] | ^^^^^^^ help: convert the identifier to upper camel case: `PpuAddr` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `*` [INFO] [stdout] --> src/cpu/adc.rs:4:26 [INFO] [stdout] | [INFO] [stdout] 4 | use crate::memory::{RAM, *}; [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `super::flags` [INFO] [stdout] --> src/cpu/and.rs:5:5 [INFO] [stdout] | [INFO] [stdout] 5 | use super::flags; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `*` [INFO] [stdout] --> src/cpu/misc_instructions.rs:2:26 [INFO] [stdout] | [INFO] [stdout] 2 | use crate::memory::{RAM, *}; [INFO] [stdout] | ^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `crate::mem_map` [INFO] [stdout] --> src/cpu/misc_instructions.rs:4:5 [INFO] [stdout] | [INFO] [stdout] 4 | use crate::mem_map; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `*` [INFO] [stdout] --> src/cpu/increment_decrement.rs:3:21 [INFO] [stdout] | [INFO] [stdout] 3 | use crate::memory::{*, RAM}; [INFO] [stdout] | ^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `*` [INFO] [stdout] --> src/cpu/compare.rs:3:26 [INFO] [stdout] | [INFO] [stdout] 3 | use crate::memory::{RAM, *}; [INFO] [stdout] | ^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `*` [INFO] [stdout] --> src/cpu/or.rs:4:26 [INFO] [stdout] | [INFO] [stdout] 4 | use crate::memory::{RAM, *}; [INFO] [stdout] | ^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `*` [INFO] [stdout] --> src/cpu/sub.rs:3:26 [INFO] [stdout] | [INFO] [stdout] 3 | use crate::memory::{RAM, *}; [INFO] [stdout] | ^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `crate::cpu::flags` [INFO] [stdout] --> src/cpu/sub.rs:51:9 [INFO] [stdout] | [INFO] [stdout] 51 | use crate::cpu::flags; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `super::*` [INFO] [stdout] --> src/memory.rs:254:13 [INFO] [stdout] | [INFO] [stdout] 254 | use super::*; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around assigned value [INFO] [stdout] --> src/ppu/ppu.rs:150:37 [INFO] [stdout] | [INFO] [stdout] 150 | self.PPUADDR.address |= ((byte_val as u16) as usize); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: type `ppuCtrl` should have an upper camel case name [INFO] [stdout] --> src/ppu/ppu.rs:163:8 [INFO] [stdout] | [INFO] [stdout] 163 | struct ppuCtrl { [INFO] [stdout] | ^^^^^^^ help: convert the identifier to upper camel case: `PpuCtrl` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_camel_case_types)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: type `ppuMask` should have an upper camel case name [INFO] [stdout] --> src/ppu/ppu.rs:186:8 [INFO] [stdout] | [INFO] [stdout] 186 | struct ppuMask { [INFO] [stdout] | ^^^^^^^ help: convert the identifier to upper camel case: `PpuMask` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: type `ppuStatus` should have an upper camel case name [INFO] [stdout] --> src/ppu/ppu.rs:198:8 [INFO] [stdout] | [INFO] [stdout] 198 | struct ppuStatus { [INFO] [stdout] | ^^^^^^^^^ help: convert the identifier to upper camel case: `PpuStatus` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: type `ppuScroll` should have an upper camel case name [INFO] [stdout] --> src/ppu/ppu.rs:205:8 [INFO] [stdout] | [INFO] [stdout] 205 | struct ppuScroll{ [INFO] [stdout] | ^^^^^^^^^ help: convert the identifier to upper camel case: `PpuScroll` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: type `ppuAddr` should have an upper camel case name [INFO] [stdout] --> src/ppu/ppu.rs:212:8 [INFO] [stdout] | [INFO] [stdout] 212 | struct ppuAddr { [INFO] [stdout] | ^^^^^^^ help: convert the identifier to upper camel case: `PpuAddr` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unreachable pattern [INFO] [stdout] --> src/cpu/nes_6502.rs:789:62 [INFO] [stdout] | [INFO] [stdout] 789 | 0xEA | 0xFA | 0x1A | 0x5A | 0x7A | 0xDA | 0x3A | 0xFA => { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unreachable_patterns)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unreachable pattern [INFO] [stdout] --> src/cpu/nes_6502.rs:803:13 [INFO] [stdout] | [INFO] [stdout] 803 | 0xD8 | 0xB8 | 0xF8 => { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unreachable pattern [INFO] [stdout] --> src/cpu/increment_decrement.rs:32:9 [INFO] [stdout] | [INFO] [stdout] 32 | _=> panic!() [INFO] [stdout] | ^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `old_bit_1` [INFO] [stdout] --> src/cpu/ror.rs:9:9 [INFO] [stdout] | [INFO] [stdout] 9 | let old_bit_1 = *accumulator & 0x1; [INFO] [stdout] | ^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_old_bit_1` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `OAMdata` [INFO] [stdout] --> src/ppu/ppu.rs:58:17 [INFO] [stdout] | [INFO] [stdout] 58 | let OAMdata = mem.read_mem_value(reg as u16); [INFO] [stdout] | ^^^^^^^ help: if this is intentional, prefix it with an underscore: `_OAMdata` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: value assigned to `reg` is never read [INFO] [stdout] --> src/ppu/ppu.rs:76:9 [INFO] [stdout] | [INFO] [stdout] 76 | reg += 1; [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_assignments)]` on by default [INFO] [stdout] = help: maybe it is overwritten before being read? [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `byte_val` [INFO] [stdout] --> src/ppu/ppu.rs:154:37 [INFO] [stdout] | [INFO] [stdout] 154 | pub fn updateOAMAddr(&mut self, byte_val : u8){ [INFO] [stdout] | ^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_byte_val` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `byte_val` [INFO] [stdout] --> src/ppu/ppu.rs:158:37 [INFO] [stdout] | [INFO] [stdout] 158 | pub fn updateOAMData(&mut self, byte_val : u8){ [INFO] [stdout] | ^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_byte_val` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/cpu/shift_addr.rs:5:9 [INFO] [stdout] | [INFO] [stdout] 5 | let mut mem_value = memory.read_mem_value(operand as u16); [INFO] [stdout] | ----^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/cpu/shift_addr.rs:11:9 [INFO] [stdout] | [INFO] [stdout] 11 | let mut mem_value = memory.read_mem_value(addr as u16); [INFO] [stdout] | ----^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/cpu/shift_addr.rs:19:9 [INFO] [stdout] | [INFO] [stdout] 19 | let mut mem_value = memory.read_mem_value(addr as u16); [INFO] [stdout] | ----^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/cpu/shift_addr.rs:27:9 [INFO] [stdout] | [INFO] [stdout] 27 | let mut mem_value = memory.read_mem_value(addr + reg as u16); [INFO] [stdout] | ----^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/cpu/flags.rs:17:18 [INFO] [stdout] | [INFO] [stdout] 17 | pub fn set_carry(mut flags: &mut u8){ [INFO] [stdout] | ----^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/cpu/flags.rs:21:17 [INFO] [stdout] | [INFO] [stdout] 21 | pub fn set_zero(mut flags: &mut u8){ [INFO] [stdout] | ----^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/cpu/flags.rs:25:21 [INFO] [stdout] | [INFO] [stdout] 25 | pub fn set_negative(mut flags: &mut u8){ [INFO] [stdout] | ----^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/cpu/flags.rs:29:20 [INFO] [stdout] | [INFO] [stdout] 29 | pub fn set_decimal(mut flags: &mut u8){ [INFO] [stdout] | ----^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/cpu/flags.rs:33:21 [INFO] [stdout] | [INFO] [stdout] 33 | pub fn set_overflow(mut flags: &mut u8){ [INFO] [stdout] | ----^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/cpu/flags.rs:37:30 [INFO] [stdout] | [INFO] [stdout] 37 | pub fn set_interrupt_disable(mut flags: &mut u8){ [INFO] [stdout] | ----^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field is never read: `chr_ram` [INFO] [stdout] --> src/memory.rs:14:5 [INFO] [stdout] | [INFO] [stdout] 14 | chr_ram : [u8; CHR_SIZE], [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field is never read: `PPUSTATUS` [INFO] [stdout] --> src/ppu/ppu.rs:12:5 [INFO] [stdout] | [INFO] [stdout] 12 | PPUSTATUS : ppuStatus, // read ONLY [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field is never read: `OAMDATA` [INFO] [stdout] --> src/ppu/ppu.rs:14:5 [INFO] [stdout] | [INFO] [stdout] 14 | OAMDATA : u8, [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field is never read: `overflow` [INFO] [stdout] --> src/ppu/ppu.rs:199:5 [INFO] [stdout] | [INFO] [stdout] 199 | overflow : u8, [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field is never read: `sprite_hit` [INFO] [stdout] --> src/ppu/ppu.rs:200:5 [INFO] [stdout] | [INFO] [stdout] 200 | sprite_hit : u8, [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field is never read: `vert_blank_started` [INFO] [stdout] --> src/ppu/ppu.rs:201:5 [INFO] [stdout] | [INFO] [stdout] 201 | vert_blank_started : u8 [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `NOP` should have a snake case name [INFO] [stdout] --> src/cpu/misc_instructions.rs:58:8 [INFO] [stdout] | [INFO] [stdout] 58 | pub fn NOP(pc_reg: &mut u16, cycles : &mut u8){ [INFO] [stdout] | ^^^ help: convert the identifier to snake case: `nop` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_snake_case)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `OAM` should have a snake case name [INFO] [stdout] --> src/memory.rs:18:5 [INFO] [stdout] | [INFO] [stdout] 18 | OAM : [u8; 256] [INFO] [stdout] | ^^^ help: convert the identifier to snake case: `oam` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `PPUCTRL` should have a snake case name [INFO] [stdout] --> src/ppu/ppu.rs:10:5 [INFO] [stdout] | [INFO] [stdout] 10 | PPUCTRL : ppuCtrl, [INFO] [stdout] | ^^^^^^^ help: convert the identifier to snake case: `ppuctrl` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `PPUMASK` should have a snake case name [INFO] [stdout] --> src/ppu/ppu.rs:11:5 [INFO] [stdout] | [INFO] [stdout] 11 | PPUMASK : ppuMask, [INFO] [stdout] | ^^^^^^^ help: convert the identifier to snake case: `ppumask` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `PPUSTATUS` should have a snake case name [INFO] [stdout] --> src/ppu/ppu.rs:12:5 [INFO] [stdout] | [INFO] [stdout] 12 | PPUSTATUS : ppuStatus, // read ONLY [INFO] [stdout] | ^^^^^^^^^ help: convert the identifier to snake case: `ppustatus` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `OAMADDR` should have a snake case name [INFO] [stdout] --> src/ppu/ppu.rs:13:5 [INFO] [stdout] | [INFO] [stdout] 13 | OAMADDR : u8, [INFO] [stdout] | ^^^^^^^ help: convert the identifier to snake case: `oamaddr` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `OAMDATA` should have a snake case name [INFO] [stdout] --> src/ppu/ppu.rs:14:5 [INFO] [stdout] | [INFO] [stdout] 14 | OAMDATA : u8, [INFO] [stdout] | ^^^^^^^ help: convert the identifier to snake case: `oamdata` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `PPUSCROLL` should have a snake case name [INFO] [stdout] --> src/ppu/ppu.rs:15:5 [INFO] [stdout] | [INFO] [stdout] 15 | PPUSCROLL : ppuScroll, [INFO] [stdout] | ^^^^^^^^^ help: convert the identifier to snake case: `ppuscroll` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `PPUADDR` should have a snake case name [INFO] [stdout] --> src/ppu/ppu.rs:16:5 [INFO] [stdout] | [INFO] [stdout] 16 | PPUADDR : ppuAddr, [INFO] [stdout] | ^^^^^^^ help: convert the identifier to snake case: `ppuaddr` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `ppuCtrlVal` should have a snake case name [INFO] [stdout] --> src/ppu/ppu.rs:30:17 [INFO] [stdout] | [INFO] [stdout] 30 | let ppuCtrlVal = mem.read_mem_value(reg as u16); [INFO] [stdout] | ^^^^^^^^^^ help: convert the identifier to snake case: `ppu_ctrl_val` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `ppuMaskVal` should have a snake case name [INFO] [stdout] --> src/ppu/ppu.rs:37:17 [INFO] [stdout] | [INFO] [stdout] 37 | let ppuMaskVal = mem.read_mem_value(reg as u16); [INFO] [stdout] | ^^^^^^^^^^ help: convert the identifier to snake case: `ppu_mask_val` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `OAMaddr` should have a snake case name [INFO] [stdout] --> src/ppu/ppu.rs:51:17 [INFO] [stdout] | [INFO] [stdout] 51 | let OAMaddr = mem.read_mem_value(reg as u16); [INFO] [stdout] | ^^^^^^^ help: convert the identifier to snake case: `oamaddr` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `OAMdata` should have a snake case name [INFO] [stdout] --> src/ppu/ppu.rs:58:17 [INFO] [stdout] | [INFO] [stdout] 58 | let OAMdata = mem.read_mem_value(reg as u16); [INFO] [stdout] | ^^^^^^^ help: convert the identifier to snake case: `oamdata` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `updatePpuCtrl` should have a snake case name [INFO] [stdout] --> src/ppu/ppu.rs:98:12 [INFO] [stdout] | [INFO] [stdout] 98 | pub fn updatePpuCtrl(&mut self, byte_val : u8){ [INFO] [stdout] | ^^^^^^^^^^^^^ help: convert the identifier to snake case: `update_ppu_ctrl` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `updatePpuMask` should have a snake case name [INFO] [stdout] --> src/ppu/ppu.rs:116:12 [INFO] [stdout] | [INFO] [stdout] 116 | pub fn updatePpuMask(&mut self, byte_val : u8){ [INFO] [stdout] | ^^^^^^^^^^^^^ help: convert the identifier to snake case: `update_ppu_mask` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `readPpuStatus` should have a snake case name [INFO] [stdout] --> src/ppu/ppu.rs:127:12 [INFO] [stdout] | [INFO] [stdout] 127 | pub fn readPpuStatus(&mut self){ [INFO] [stdout] | ^^^^^^^^^^^^^ help: convert the identifier to snake case: `read_ppu_status` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `updatePpuScroll` should have a snake case name [INFO] [stdout] --> src/ppu/ppu.rs:132:12 [INFO] [stdout] | [INFO] [stdout] 132 | pub fn updatePpuScroll(&mut self, byte_val : u8){ [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: convert the identifier to snake case: `update_ppu_scroll` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `updatePpuAddr` should have a snake case name [INFO] [stdout] --> src/ppu/ppu.rs:142:12 [INFO] [stdout] | [INFO] [stdout] 142 | pub fn updatePpuAddr(&mut self, byte_val : u8){ [INFO] [stdout] | ^^^^^^^^^^^^^ help: convert the identifier to snake case: `update_ppu_addr` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `updateOAMAddr` should have a snake case name [INFO] [stdout] --> src/ppu/ppu.rs:154:12 [INFO] [stdout] | [INFO] [stdout] 154 | pub fn updateOAMAddr(&mut self, byte_val : u8){ [INFO] [stdout] | ^^^^^^^^^^^^^ help: convert the identifier to snake case: `update_oamaddr` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `updateOAMData` should have a snake case name [INFO] [stdout] --> src/ppu/ppu.rs:158:12 [INFO] [stdout] | [INFO] [stdout] 158 | pub fn updateOAMData(&mut self, byte_val : u8){ [INFO] [stdout] | ^^^^^^^^^^^^^ help: convert the identifier to snake case: `update_oamdata` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `nametableAddress` should have a snake case name [INFO] [stdout] --> src/ppu/ppu.rs:164:5 [INFO] [stdout] | [INFO] [stdout] 164 | nametableAddress : usize, [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: convert the identifier to snake case: `nametable_address` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `VRAM_address_increment` should have a snake case name [INFO] [stdout] --> src/ppu/ppu.rs:165:5 [INFO] [stdout] | [INFO] [stdout] 165 | VRAM_address_increment : usize, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: convert the identifier to snake case: `vram_address_increment` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `greyScale` should have a snake case name [INFO] [stdout] --> src/ppu/ppu.rs:187:5 [INFO] [stdout] | [INFO] [stdout] 187 | greyScale : u8, [INFO] [stdout] | ^^^^^^^^^ help: convert the identifier to snake case: `grey_scale` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 63 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `std::result::Result` that must be used [INFO] [stdout] --> src/main.rs:36:5 [INFO] [stdout] | [INFO] [stdout] 36 | file.read_to_end(&mut file_buf); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `std::result::Result` that must be used [INFO] [stdout] --> src/main.rs:36:5 [INFO] [stdout] | [INFO] [stdout] 36 | file.read_to_end(&mut file_buf); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unreachable pattern [INFO] [stdout] --> src/cpu/nes_6502.rs:789:62 [INFO] [stdout] | [INFO] [stdout] 789 | 0xEA | 0xFA | 0x1A | 0x5A | 0x7A | 0xDA | 0x3A | 0xFA => { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unreachable_patterns)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unreachable pattern [INFO] [stdout] --> src/cpu/nes_6502.rs:803:13 [INFO] [stdout] | [INFO] [stdout] 803 | 0xD8 | 0xB8 | 0xF8 => { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unreachable pattern [INFO] [stdout] --> src/cpu/increment_decrement.rs:32:9 [INFO] [stdout] | [INFO] [stdout] 32 | _=> panic!() [INFO] [stdout] | ^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `operand` [INFO] [stdout] --> src/cpu/and.rs:56:13 [INFO] [stdout] | [INFO] [stdout] 56 | let operand = 7; [INFO] [stdout] | ^^^^^^^ help: if this is intentional, prefix it with an underscore: `_operand` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `operand` [INFO] [stdout] --> src/cpu/asl.rs:159:13 [INFO] [stdout] | [INFO] [stdout] 159 | let operand = 7; [INFO] [stdout] | ^^^^^^^ help: if this is intentional, prefix it with an underscore: `_operand` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `old_bit_1` [INFO] [stdout] --> src/cpu/ror.rs:9:9 [INFO] [stdout] | [INFO] [stdout] 9 | let old_bit_1 = *accumulator & 0x1; [INFO] [stdout] | ^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_old_bit_1` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `operand` [INFO] [stdout] --> src/cpu/misc_instructions.rs:156:13 [INFO] [stdout] | [INFO] [stdout] 156 | let operand = 7; [INFO] [stdout] | ^^^^^^^ help: if this is intentional, prefix it with an underscore: `_operand` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `operand` [INFO] [stdout] --> src/cpu/jumps.rs:55:13 [INFO] [stdout] | [INFO] [stdout] 55 | let operand = 7; [INFO] [stdout] | ^^^^^^^ help: if this is intentional, prefix it with an underscore: `_operand` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `accumulator` [INFO] [stdout] --> src/cpu/jumps.rs:57:13 [INFO] [stdout] | [INFO] [stdout] 57 | let mut accumulator = 15; [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_accumulator` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `status` [INFO] [stdout] --> src/cpu/jumps.rs:58:13 [INFO] [stdout] | [INFO] [stdout] 58 | let mut status : u8 = 0; [INFO] [stdout] | ^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_status` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `stack_ptr` [INFO] [stdout] --> src/cpu/increment_decrement.rs:102:13 [INFO] [stdout] | [INFO] [stdout] 102 | let mut stack_ptr = 0; [INFO] [stdout] | ^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_stack_ptr` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `val` [INFO] [stdout] --> src/cpu/compare.rs:94:13 [INFO] [stdout] | [INFO] [stdout] 94 | let mut val = 0; [INFO] [stdout] | ^^^^^^^ help: if this is intentional, prefix it with an underscore: `_val` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `stack_ptr` [INFO] [stdout] --> src/cpu/compare.rs:95:13 [INFO] [stdout] | [INFO] [stdout] 95 | let mut stack_ptr = 0; [INFO] [stdout] | ^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_stack_ptr` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `operand` [INFO] [stdout] --> src/cpu/or.rs:98:13 [INFO] [stdout] | [INFO] [stdout] 98 | let operand = 7; [INFO] [stdout] | ^^^^^^^ help: if this is intentional, prefix it with an underscore: `_operand` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `operand` [INFO] [stdout] --> src/cpu/sub.rs:55:13 [INFO] [stdout] | [INFO] [stdout] 55 | let operand = 12; [INFO] [stdout] | ^^^^^^^ help: if this is intentional, prefix it with an underscore: `_operand` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `operand` [INFO] [stdout] --> src/cpu/load_store.rs:116:13 [INFO] [stdout] | [INFO] [stdout] 116 | let operand = 7; [INFO] [stdout] | ^^^^^^^ help: if this is intentional, prefix it with an underscore: `_operand` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: value assigned to `accumulator` is never read [INFO] [stdout] --> src/cpu/load_store.rs:118:13 [INFO] [stdout] | [INFO] [stdout] 118 | let mut accumulator = 25; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_assignments)]` on by default [INFO] [stdout] = help: maybe it is overwritten before being read? [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `OAMdata` [INFO] [stdout] --> src/ppu/ppu.rs:58:17 [INFO] [stdout] | [INFO] [stdout] 58 | let OAMdata = mem.read_mem_value(reg as u16); [INFO] [stdout] | ^^^^^^^ help: if this is intentional, prefix it with an underscore: `_OAMdata` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: value assigned to `reg` is never read [INFO] [stdout] --> src/ppu/ppu.rs:76:9 [INFO] [stdout] | [INFO] [stdout] 76 | reg += 1; [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = help: maybe it is overwritten before being read? [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `byte_val` [INFO] [stdout] --> src/ppu/ppu.rs:154:37 [INFO] [stdout] | [INFO] [stdout] 154 | pub fn updateOAMAddr(&mut self, byte_val : u8){ [INFO] [stdout] | ^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_byte_val` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `byte_val` [INFO] [stdout] --> src/ppu/ppu.rs:158:37 [INFO] [stdout] | [INFO] [stdout] 158 | pub fn updateOAMData(&mut self, byte_val : u8){ [INFO] [stdout] | ^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_byte_val` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/cpu/shift_addr.rs:5:9 [INFO] [stdout] | [INFO] [stdout] 5 | let mut mem_value = memory.read_mem_value(operand as u16); [INFO] [stdout] | ----^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/cpu/shift_addr.rs:11:9 [INFO] [stdout] | [INFO] [stdout] 11 | let mut mem_value = memory.read_mem_value(addr as u16); [INFO] [stdout] | ----^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/cpu/shift_addr.rs:19:9 [INFO] [stdout] | [INFO] [stdout] 19 | let mut mem_value = memory.read_mem_value(addr as u16); [INFO] [stdout] | ----^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/cpu/shift_addr.rs:27:9 [INFO] [stdout] | [INFO] [stdout] 27 | let mut mem_value = memory.read_mem_value(addr + reg as u16); [INFO] [stdout] | ----^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/cpu/flags.rs:17:18 [INFO] [stdout] | [INFO] [stdout] 17 | pub fn set_carry(mut flags: &mut u8){ [INFO] [stdout] | ----^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/cpu/flags.rs:21:17 [INFO] [stdout] | [INFO] [stdout] 21 | pub fn set_zero(mut flags: &mut u8){ [INFO] [stdout] | ----^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/cpu/flags.rs:25:21 [INFO] [stdout] | [INFO] [stdout] 25 | pub fn set_negative(mut flags: &mut u8){ [INFO] [stdout] | ----^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/cpu/flags.rs:29:20 [INFO] [stdout] | [INFO] [stdout] 29 | pub fn set_decimal(mut flags: &mut u8){ [INFO] [stdout] | ----^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/cpu/flags.rs:33:21 [INFO] [stdout] | [INFO] [stdout] 33 | pub fn set_overflow(mut flags: &mut u8){ [INFO] [stdout] | ----^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/cpu/flags.rs:37:30 [INFO] [stdout] | [INFO] [stdout] 37 | pub fn set_interrupt_disable(mut flags: &mut u8){ [INFO] [stdout] | ----^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/cpu/jumps.rs:57:13 [INFO] [stdout] | [INFO] [stdout] 57 | let mut accumulator = 15; [INFO] [stdout] | ----^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/cpu/jumps.rs:58:13 [INFO] [stdout] | [INFO] [stdout] 58 | let mut status : u8 = 0; [INFO] [stdout] | ----^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/cpu/increment_decrement.rs:102:13 [INFO] [stdout] | [INFO] [stdout] 102 | let mut stack_ptr = 0; [INFO] [stdout] | ----^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/cpu/compare.rs:94:13 [INFO] [stdout] | [INFO] [stdout] 94 | let mut val = 0; [INFO] [stdout] | ----^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/cpu/compare.rs:95:13 [INFO] [stdout] | [INFO] [stdout] 95 | let mut stack_ptr = 0; [INFO] [stdout] | ----^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field is never read: `chr_ram` [INFO] [stdout] --> src/memory.rs:14:5 [INFO] [stdout] | [INFO] [stdout] 14 | chr_ram : [u8; CHR_SIZE], [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field is never read: `PPUSTATUS` [INFO] [stdout] --> src/ppu/ppu.rs:12:5 [INFO] [stdout] | [INFO] [stdout] 12 | PPUSTATUS : ppuStatus, // read ONLY [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field is never read: `OAMDATA` [INFO] [stdout] --> src/ppu/ppu.rs:14:5 [INFO] [stdout] | [INFO] [stdout] 14 | OAMDATA : u8, [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field is never read: `overflow` [INFO] [stdout] --> src/ppu/ppu.rs:199:5 [INFO] [stdout] | [INFO] [stdout] 199 | overflow : u8, [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field is never read: `sprite_hit` [INFO] [stdout] --> src/ppu/ppu.rs:200:5 [INFO] [stdout] | [INFO] [stdout] 200 | sprite_hit : u8, [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field is never read: `vert_blank_started` [INFO] [stdout] --> src/ppu/ppu.rs:201:5 [INFO] [stdout] | [INFO] [stdout] 201 | vert_blank_started : u8 [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `NOP` should have a snake case name [INFO] [stdout] --> src/cpu/misc_instructions.rs:58:8 [INFO] [stdout] | [INFO] [stdout] 58 | pub fn NOP(pc_reg: &mut u16, cycles : &mut u8){ [INFO] [stdout] | ^^^ help: convert the identifier to snake case: `nop` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_snake_case)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `OAM` should have a snake case name [INFO] [stdout] --> src/memory.rs:18:5 [INFO] [stdout] | [INFO] [stdout] 18 | OAM : [u8; 256] [INFO] [stdout] | ^^^ help: convert the identifier to snake case: `oam` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `PPUCTRL` should have a snake case name [INFO] [stdout] --> src/ppu/ppu.rs:10:5 [INFO] [stdout] | [INFO] [stdout] 10 | PPUCTRL : ppuCtrl, [INFO] [stdout] | ^^^^^^^ help: convert the identifier to snake case: `ppuctrl` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `PPUMASK` should have a snake case name [INFO] [stdout] --> src/ppu/ppu.rs:11:5 [INFO] [stdout] | [INFO] [stdout] 11 | PPUMASK : ppuMask, [INFO] [stdout] | ^^^^^^^ help: convert the identifier to snake case: `ppumask` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `PPUSTATUS` should have a snake case name [INFO] [stdout] --> src/ppu/ppu.rs:12:5 [INFO] [stdout] | [INFO] [stdout] 12 | PPUSTATUS : ppuStatus, // read ONLY [INFO] [stdout] | ^^^^^^^^^ help: convert the identifier to snake case: `ppustatus` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `OAMADDR` should have a snake case name [INFO] [stdout] --> src/ppu/ppu.rs:13:5 [INFO] [stdout] | [INFO] [stdout] 13 | OAMADDR : u8, [INFO] [stdout] | ^^^^^^^ help: convert the identifier to snake case: `oamaddr` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `OAMDATA` should have a snake case name [INFO] [stdout] --> src/ppu/ppu.rs:14:5 [INFO] [stdout] | [INFO] [stdout] 14 | OAMDATA : u8, [INFO] [stdout] | ^^^^^^^ help: convert the identifier to snake case: `oamdata` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `PPUSCROLL` should have a snake case name [INFO] [stdout] --> src/ppu/ppu.rs:15:5 [INFO] [stdout] | [INFO] [stdout] 15 | PPUSCROLL : ppuScroll, [INFO] [stdout] | ^^^^^^^^^ help: convert the identifier to snake case: `ppuscroll` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `PPUADDR` should have a snake case name [INFO] [stdout] --> src/ppu/ppu.rs:16:5 [INFO] [stdout] | [INFO] [stdout] 16 | PPUADDR : ppuAddr, [INFO] [stdout] | ^^^^^^^ help: convert the identifier to snake case: `ppuaddr` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `ppuCtrlVal` should have a snake case name [INFO] [stdout] --> src/ppu/ppu.rs:30:17 [INFO] [stdout] | [INFO] [stdout] 30 | let ppuCtrlVal = mem.read_mem_value(reg as u16); [INFO] [stdout] | ^^^^^^^^^^ help: convert the identifier to snake case: `ppu_ctrl_val` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `ppuMaskVal` should have a snake case name [INFO] [stdout] --> src/ppu/ppu.rs:37:17 [INFO] [stdout] | [INFO] [stdout] 37 | let ppuMaskVal = mem.read_mem_value(reg as u16); [INFO] [stdout] | ^^^^^^^^^^ help: convert the identifier to snake case: `ppu_mask_val` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `OAMaddr` should have a snake case name [INFO] [stdout] --> src/ppu/ppu.rs:51:17 [INFO] [stdout] | [INFO] [stdout] 51 | let OAMaddr = mem.read_mem_value(reg as u16); [INFO] [stdout] | ^^^^^^^ help: convert the identifier to snake case: `oamaddr` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `OAMdata` should have a snake case name [INFO] [stdout] --> src/ppu/ppu.rs:58:17 [INFO] [stdout] | [INFO] [stdout] 58 | let OAMdata = mem.read_mem_value(reg as u16); [INFO] [stdout] | ^^^^^^^ help: convert the identifier to snake case: `oamdata` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `updatePpuCtrl` should have a snake case name [INFO] [stdout] --> src/ppu/ppu.rs:98:12 [INFO] [stdout] | [INFO] [stdout] 98 | pub fn updatePpuCtrl(&mut self, byte_val : u8){ [INFO] [stdout] | ^^^^^^^^^^^^^ help: convert the identifier to snake case: `update_ppu_ctrl` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `updatePpuMask` should have a snake case name [INFO] [stdout] --> src/ppu/ppu.rs:116:12 [INFO] [stdout] | [INFO] [stdout] 116 | pub fn updatePpuMask(&mut self, byte_val : u8){ [INFO] [stdout] | ^^^^^^^^^^^^^ help: convert the identifier to snake case: `update_ppu_mask` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `readPpuStatus` should have a snake case name [INFO] [stdout] --> src/ppu/ppu.rs:127:12 [INFO] [stdout] | [INFO] [stdout] 127 | pub fn readPpuStatus(&mut self){ [INFO] [stdout] | ^^^^^^^^^^^^^ help: convert the identifier to snake case: `read_ppu_status` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `updatePpuScroll` should have a snake case name [INFO] [stdout] --> src/ppu/ppu.rs:132:12 [INFO] [stdout] | [INFO] [stdout] 132 | pub fn updatePpuScroll(&mut self, byte_val : u8){ [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: convert the identifier to snake case: `update_ppu_scroll` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `updatePpuAddr` should have a snake case name [INFO] [stdout] --> src/ppu/ppu.rs:142:12 [INFO] [stdout] | [INFO] [stdout] 142 | pub fn updatePpuAddr(&mut self, byte_val : u8){ [INFO] [stdout] | ^^^^^^^^^^^^^ help: convert the identifier to snake case: `update_ppu_addr` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `updateOAMAddr` should have a snake case name [INFO] [stdout] --> src/ppu/ppu.rs:154:12 [INFO] [stdout] | [INFO] [stdout] 154 | pub fn updateOAMAddr(&mut self, byte_val : u8){ [INFO] [stdout] | ^^^^^^^^^^^^^ help: convert the identifier to snake case: `update_oamaddr` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `updateOAMData` should have a snake case name [INFO] [stdout] --> src/ppu/ppu.rs:158:12 [INFO] [stdout] | [INFO] [stdout] 158 | pub fn updateOAMData(&mut self, byte_val : u8){ [INFO] [stdout] | ^^^^^^^^^^^^^ help: convert the identifier to snake case: `update_oamdata` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `nametableAddress` should have a snake case name [INFO] [stdout] --> src/ppu/ppu.rs:164:5 [INFO] [stdout] | [INFO] [stdout] 164 | nametableAddress : usize, [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: convert the identifier to snake case: `nametable_address` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `VRAM_address_increment` should have a snake case name [INFO] [stdout] --> src/ppu/ppu.rs:165:5 [INFO] [stdout] | [INFO] [stdout] 165 | VRAM_address_increment : usize, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: convert the identifier to snake case: `vram_address_increment` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `greyScale` should have a snake case name [INFO] [stdout] --> src/ppu/ppu.rs:187:5 [INFO] [stdout] | [INFO] [stdout] 187 | greyScale : u8, [INFO] [stdout] | ^^^^^^^^^ help: convert the identifier to snake case: `grey_scale` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: module `Test` should have a snake case name [INFO] [stdout] --> src/ppu/ppu.rs:218:9 [INFO] [stdout] | [INFO] [stdout] 218 | pub mod Test{ [INFO] [stdout] | ^^^^ help: convert the identifier to snake case: `test` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 82 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 2.32s [INFO] running `Command { std: "docker" "inspect" "0ce9e9aff641e92b913a348eb9cb86a0b442c25452fdcb92bfef189dbab1a13e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "0ce9e9aff641e92b913a348eb9cb86a0b442c25452fdcb92bfef189dbab1a13e", kill_on_drop: false }` [INFO] [stdout] 0ce9e9aff641e92b913a348eb9cb86a0b442c25452fdcb92bfef189dbab1a13e