[INFO] updating cached repository https://github.com/droidkid/rust-tetris [INFO] running `"git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "-c" "remote.origin.fetch=refs/heads/*:refs/heads/*" "fetch" "origin" "--force" "--prune"` [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] d7739277f8489ba9f6b2ba7f772f909813828b03 [INFO] checking droidkid/rust-tetris against master#45d050cde277b22a755847338f2acc2c7b834141 for pr-71393 [INFO] running `"git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fdroidkid%2Frust-tetris" "/workspace/builds/worker-2/source"` [INFO] [stderr] Cloning into '/workspace/builds/worker-2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/droidkid/rust-tetris on toolchain 45d050cde277b22a755847338f2acc2c7b834141 [INFO] running `"/workspace/cargo-home/bin/cargo" "+45d050cde277b22a755847338f2acc2c7b834141" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started tweaking git repo https://github.com/droidkid/rust-tetris [INFO] finished tweaking git repo https://github.com/droidkid/rust-tetris [INFO] tweaked toml for git repo https://github.com/droidkid/rust-tetris written to /workspace/builds/worker-2/source/Cargo.toml [INFO] crate git repo https://github.com/droidkid/rust-tetris already has a lockfile, it will not be regenerated [INFO] running `"/workspace/cargo-home/bin/cargo" "+45d050cde277b22a755847338f2acc2c7b834141" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "MAP_USER_ID=0" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--network" "none" "rustops/crates-build-env" "/opt/rustwide/cargo-home/bin/cargo" "+45d050cde277b22a755847338f2acc2c7b834141" "check" "--frozen" "--all" "--all-targets"` [INFO] [stdout] eddf21de936120c2a331f3bf0e45f056e4a1638104b43a5e3bfec45e94e359cd [INFO] [stderr] WARNING: Your kernel does not support swap limit capabilities or the cgroup is not mounted. Memory limited without swap. [INFO] running `"docker" "start" "-a" "eddf21de936120c2a331f3bf0e45f056e4a1638104b43a5e3bfec45e94e359cd"` [INFO] [stderr] Compiling num-traits v0.2.6 [INFO] [stderr] Compiling num-integer v0.1.39 [INFO] [stderr] Compiling num-iter v0.1.37 [INFO] [stderr] Compiling cfg-if v0.1.5 [INFO] [stderr] Checking libc v0.2.43 [INFO] [stderr] Checking bitflags v0.7.0 [INFO] [stderr] Checking lazy_static v0.2.11 [INFO] [stderr] Compiling sdl2-sys v0.31.0 [INFO] [stderr] Checking rand v0.4.3 [INFO] [stderr] Checking rand v0.3.22 [INFO] [stderr] Checking num v0.1.42 [INFO] [stderr] Checking sdl2 v0.31.0 [INFO] [stderr] Checking rust-tetris v0.1.0 (/opt/rustwide/workdir) [INFO] [stderr] warning: unused import: `std::thread` [INFO] [stderr] --> src/main.rs:17:5 [INFO] [stderr] | [INFO] [stderr] 17 | use std::thread; [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(unused_imports)]` on by default [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `for` iterator expression [INFO] [stderr] --> src/main.rs:422:22 [INFO] [stderr] | [INFO] [stderr] 422 | for j in (1..self.width-1) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(unused_parens)]` on by default [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `if` condition [INFO] [stderr] --> src/main.rs:473:16 [INFO] [stderr] | [INFO] [stderr] 473 | if (self.game_over_countdown > 0) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `if` condition [INFO] [stderr] --> src/main.rs:483:12 [INFO] [stderr] | [INFO] [stderr] 483 | if (input.left_key_pressed) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `if` condition [INFO] [stderr] --> src/main.rs:486:12 [INFO] [stderr] | [INFO] [stderr] 486 | if (input.right_key_pressed) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `if` condition [INFO] [stderr] --> src/main.rs:489:12 [INFO] [stderr] | [INFO] [stderr] 489 | if (input.up_key_pressed) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `if` condition [INFO] [stderr] --> src/main.rs:493:12 [INFO] [stderr] | [INFO] [stderr] 493 | if (input.down_key_pressed) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `if` condition [INFO] [stderr] --> src/main.rs:500:12 [INFO] [stderr] | [INFO] [stderr] 500 | if (self.gravity_countdown > 0) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `if` condition [INFO] [stderr] --> src/main.rs:503:12 [INFO] [stderr] | [INFO] [stderr] 503 | if (self.lock_delay_countdown > 0 && self.locking_state) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `if` condition [INFO] [stderr] --> src/main.rs:539:12 [INFO] [stderr] | [INFO] [stderr] 539 | if (self.level >= 10) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `if` condition [INFO] [stderr] --> src/main.rs:646:12 [INFO] [stderr] | [INFO] [stderr] 646 | if (event_pump.keyboard_state().is_scancode_pressed(Scancode::Down)) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::thread` [INFO] [stderr] --> src/main.rs:17:5 [INFO] [stderr] | [INFO] [stderr] 17 | use std::thread; [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(unused_imports)]` on by default [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `for` iterator expression [INFO] [stderr] --> src/main.rs:422:22 [INFO] [stderr] | [INFO] [stderr] 422 | for j in (1..self.width-1) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(unused_parens)]` on by default [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `if` condition [INFO] [stderr] --> src/main.rs:473:16 [INFO] [stderr] | [INFO] [stderr] 473 | if (self.game_over_countdown > 0) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `if` condition [INFO] [stderr] --> src/main.rs:483:12 [INFO] [stderr] | [INFO] [stderr] 483 | if (input.left_key_pressed) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `if` condition [INFO] [stderr] --> src/main.rs:486:12 [INFO] [stderr] | [INFO] [stderr] 486 | if (input.right_key_pressed) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `if` condition [INFO] [stderr] --> src/main.rs:489:12 [INFO] [stderr] | [INFO] [stderr] 489 | if (input.up_key_pressed) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `if` condition [INFO] [stderr] --> src/main.rs:493:12 [INFO] [stderr] | [INFO] [stderr] 493 | if (input.down_key_pressed) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `if` condition [INFO] [stderr] --> src/main.rs:500:12 [INFO] [stderr] | [INFO] [stderr] 500 | if (self.gravity_countdown > 0) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `if` condition [INFO] [stderr] --> src/main.rs:503:12 [INFO] [stderr] | [INFO] [stderr] 503 | if (self.lock_delay_countdown > 0 && self.locking_state) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `if` condition [INFO] [stderr] --> src/main.rs:539:12 [INFO] [stderr] | [INFO] [stderr] 539 | if (self.level >= 10) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `if` condition [INFO] [stderr] --> src/main.rs:646:12 [INFO] [stderr] | [INFO] [stderr] 646 | if (event_pump.keyboard_state().is_scancode_pressed(Scancode::Down)) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: value assigned to `move_down_success` is never read [INFO] [stderr] --> src/main.rs:508:13 [INFO] [stderr] | [INFO] [stderr] 508 | let mut move_down_success = true; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(unused_assignments)]` on by default [INFO] [stderr] = help: maybe it is overwritten before being read? [INFO] [stderr] [INFO] [stderr] warning: value assigned to `move_down_success` is never read [INFO] [stderr] --> src/main.rs:508:13 [INFO] [stderr] | [INFO] [stderr] 508 | let mut move_down_success = true; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(unused_assignments)]` on by default [INFO] [stderr] = help: maybe it is overwritten before being read? [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:613:9 [INFO] [stderr] | [INFO] [stderr] 613 | let mut font = ttf_context.load_font(font_path, 28).unwrap(); [INFO] [stderr] | ----^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(unused_mut)]` on by default [INFO] [stderr] [INFO] [stderr] warning: method is never used: `is_row_empty` [INFO] [stderr] --> src/main.rs:411:5 [INFO] [stderr] | [INFO] [stderr] 411 | fn is_row_empty(&self, row:usize) -> bool { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(dead_code)]` on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:613:9 [INFO] [stderr] | [INFO] [stderr] 613 | let mut font = ttf_context.load_font(font_path, 28).unwrap(); [INFO] [stderr] | ----^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(unused_mut)]` on by default [INFO] [stderr] [INFO] [stderr] warning: static variable `start_pos` should have an upper case name [INFO] [stderr] --> src/main.rs:20:8 [INFO] [stderr] | [INFO] [stderr] 20 | static start_pos: Pos2D = Pos2D { [INFO] [stderr] | ^^^^^^^^^ help: convert the identifier to upper case: `START_POS` [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(non_upper_case_globals)]` on by default [INFO] [stderr] [INFO] [stderr] warning: method is never used: `is_row_empty` [INFO] [stderr] --> src/main.rs:411:5 [INFO] [stderr] | [INFO] [stderr] 411 | fn is_row_empty(&self, row:usize) -> bool { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(dead_code)]` on by default [INFO] [stderr] [INFO] [stderr] warning: static variable `start_pos` should have an upper case name [INFO] [stderr] --> src/main.rs:20:8 [INFO] [stderr] | [INFO] [stderr] 20 | static start_pos: Pos2D = Pos2D { [INFO] [stderr] | ^^^^^^^^^ help: convert the identifier to upper case: `START_POS` [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(non_upper_case_globals)]` on by default [INFO] [stderr] [INFO] [stderr] warning: static variable `tetris_board_width` should have an upper case name [INFO] [stderr] --> src/main.rs:24:8 [INFO] [stderr] | [INFO] [stderr] 24 | static tetris_board_width : usize = 12; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: convert the identifier to upper case: `TETRIS_BOARD_WIDTH` [INFO] [stderr] [INFO] [stderr] warning: static variable `tetris_board_height` should have an upper case name [INFO] [stderr] --> src/main.rs:25:8 [INFO] [stderr] | [INFO] [stderr] 25 | static tetris_board_height : usize = 24; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: convert the identifier to upper case: `TETRIS_BOARD_HEIGHT` [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:273:13 [INFO] [stderr] | [INFO] [stderr] 273 | canvas.fill_rect(rect); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(unused_must_use)]` on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: variable `randomTetrisPieceGenerator` should have a snake case name [INFO] [stderr] --> src/main.rs:342:17 [INFO] [stderr] | [INFO] [stderr] 342 | let mut randomTetrisPieceGenerator = RandomTetrisPieceGenerator::new(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: convert the identifier to snake case: `random_tetris_piece_generator` [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(non_snake_case)]` on by default [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:556:9 [INFO] [stderr] | [INFO] [stderr] 556 | canvas.fill_rect(rect); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:661:13 [INFO] [stderr] | [INFO] [stderr] 661 | canvas.fill_rect(Rect::new(0,0,width,height)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: static variable `tetris_board_width` should have an upper case name [INFO] [stderr] --> src/main.rs:24:8 [INFO] [stderr] | [INFO] [stderr] 24 | static tetris_board_width : usize = 12; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: convert the identifier to upper case: `TETRIS_BOARD_WIDTH` [INFO] [stderr] [INFO] [stderr] warning: static variable `tetris_board_height` should have an upper case name [INFO] [stderr] --> src/main.rs:25:8 [INFO] [stderr] | [INFO] [stderr] 25 | static tetris_board_height : usize = 24; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: convert the identifier to upper case: `TETRIS_BOARD_HEIGHT` [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:273:13 [INFO] [stderr] | [INFO] [stderr] 273 | canvas.fill_rect(rect); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(unused_must_use)]` on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: variable `randomTetrisPieceGenerator` should have a snake case name [INFO] [stderr] --> src/main.rs:342:17 [INFO] [stderr] | [INFO] [stderr] 342 | let mut randomTetrisPieceGenerator = RandomTetrisPieceGenerator::new(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: convert the identifier to snake case: `random_tetris_piece_generator` [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(non_snake_case)]` on by default [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:556:9 [INFO] [stderr] | [INFO] [stderr] 556 | canvas.fill_rect(rect); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:661:13 [INFO] [stderr] | [INFO] [stderr] 661 | canvas.fill_rect(Rect::new(0,0,width,height)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: 21 warnings emitted [INFO] [stderr] [INFO] [stderr] warning: 21 warnings emitted [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 13.62s [INFO] running `"docker" "inspect" "eddf21de936120c2a331f3bf0e45f056e4a1638104b43a5e3bfec45e94e359cd"` [INFO] running `"docker" "rm" "-f" "eddf21de936120c2a331f3bf0e45f056e4a1638104b43a5e3bfec45e94e359cd"` [INFO] [stdout] eddf21de936120c2a331f3bf0e45f056e4a1638104b43a5e3bfec45e94e359cd