[INFO] updating cached repository https://github.com/christopherjmedlin/hackman [INFO] running `"git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "-c" "remote.origin.fetch=refs/heads/*:refs/heads/*" "fetch" "origin" "--force" "--prune"` [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 116a625552d35f2f8a7bd06f69005ef7283238b0 [INFO] checking christopherjmedlin/hackman against master#45d050cde277b22a755847338f2acc2c7b834141 for pr-71393 [INFO] running `"git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fchristopherjmedlin%2Fhackman" "/workspace/builds/worker-1/source"` [INFO] [stderr] Cloning into '/workspace/builds/worker-1/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/christopherjmedlin/hackman on toolchain 45d050cde277b22a755847338f2acc2c7b834141 [INFO] running `"/workspace/cargo-home/bin/cargo" "+45d050cde277b22a755847338f2acc2c7b834141" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started tweaking git repo https://github.com/christopherjmedlin/hackman [INFO] finished tweaking git repo https://github.com/christopherjmedlin/hackman [INFO] tweaked toml for git repo https://github.com/christopherjmedlin/hackman written to /workspace/builds/worker-1/source/Cargo.toml [INFO] crate git repo https://github.com/christopherjmedlin/hackman already has a lockfile, it will not be regenerated [INFO] running `"/workspace/cargo-home/bin/cargo" "+45d050cde277b22a755847338f2acc2c7b834141" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "MAP_USER_ID=0" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--network" "none" "rustops/crates-build-env" "/opt/rustwide/cargo-home/bin/cargo" "+45d050cde277b22a755847338f2acc2c7b834141" "check" "--frozen" "--all" "--all-targets"` [INFO] [stderr] WARNING: Your kernel does not support swap limit capabilities or the cgroup is not mounted. Memory limited without swap. [INFO] [stdout] 6d6ea1292c7bbe75840394922891f6212272409c9105cae13a8a172b73dd2181 [INFO] running `"docker" "start" "-a" "6d6ea1292c7bbe75840394922891f6212272409c9105cae13a8a172b73dd2181"` [INFO] [stderr] Compiling cfg-if v0.1.6 [INFO] [stderr] Checking matches v0.1.8 [INFO] [stderr] Checking num-integer v0.1.39 [INFO] [stderr] Checking rand v0.4.6 [INFO] [stderr] Compiling sdl2-sys v0.31.0 [INFO] [stderr] Checking num-iter v0.1.37 [INFO] [stderr] Checking num v0.1.42 [INFO] [stderr] Checking rand v0.3.23 [INFO] [stderr] Checking sdl2 v0.31.0 [INFO] [stderr] Checking pacman v0.1.0 (/opt/rustwide/workdir) [INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stderr] --> src/cpu/mod.rs:49:22 [INFO] [stderr] | [INFO] [stderr] 49 | memory: &mut Memory, [INFO] [stderr] | ^^^^^^ help: use `dyn`: `dyn Memory` [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(bare_trait_objects)]` on by default [INFO] [stderr] [INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stderr] --> src/cpu/mod.rs:50:18 [INFO] [stderr] | [INFO] [stderr] 50 | io: &mut InputOutput, [INFO] [stderr] | ^^^^^^^^^^^ help: use `dyn`: `dyn InputOutput` [INFO] [stderr] [INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stderr] --> src/cpu/mod.rs:73:22 [INFO] [stderr] | [INFO] [stderr] 73 | memory: &mut Memory, [INFO] [stderr] | ^^^^^^ help: use `dyn`: `dyn Memory` [INFO] [stderr] [INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stderr] --> src/cpu/mod.rs:74:18 [INFO] [stderr] | [INFO] [stderr] 74 | io: &mut InputOutput, [INFO] [stderr] | ^^^^^^^^^^^ help: use `dyn`: `dyn InputOutput` [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/cpu/mod.rs:134:18 [INFO] [stderr] | [INFO] [stderr] 134 | (0, 4...7, 0) => { [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(ellipsis_inclusive_range_patterns)]` on by default [INFO] [stderr] [INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stderr] --> src/cpu/mod.rs:539:46 [INFO] [stderr] | [INFO] [stderr] 539 | fn run_cb_opcode(&mut self, memory: &mut Memory, io: &mut InputOutput, ext: bool) -> usize { [INFO] [stderr] | ^^^^^^ help: use `dyn`: `dyn Memory` [INFO] [stderr] [INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stderr] --> src/cpu/mod.rs:539:63 [INFO] [stderr] | [INFO] [stderr] 539 | fn run_cb_opcode(&mut self, memory: &mut Memory, io: &mut InputOutput, ext: bool) -> usize { [INFO] [stderr] | ^^^^^^^^^^^ help: use `dyn`: `dyn InputOutput` [INFO] [stderr] [INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stderr] --> src/cpu/mod.rs:626:58 [INFO] [stderr] | [INFO] [stderr] 626 | fn run_ed_opcode(&mut self, opcode: u8, memory: &mut Memory, io: &mut InputOutput) -> usize { [INFO] [stderr] | ^^^^^^ help: use `dyn`: `dyn Memory` [INFO] [stderr] [INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stderr] --> src/cpu/mod.rs:626:75 [INFO] [stderr] | [INFO] [stderr] 626 | fn run_ed_opcode(&mut self, opcode: u8, memory: &mut Memory, io: &mut InputOutput) -> usize { [INFO] [stderr] | ^^^^^^^^^^^ help: use `dyn`: `dyn InputOutput` [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/cpu/mod.rs:782:21 [INFO] [stderr] | [INFO] [stderr] 782 | (2, _, 0...3) => { [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stderr] --> src/cpu/mod.rs:792:42 [INFO] [stderr] | [INFO] [stderr] 792 | fn r(&mut self, index: u8, mem: &mut Memory) -> u8 { [INFO] [stderr] | ^^^^^^ help: use `dyn`: `dyn Memory` [INFO] [stderr] [INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stderr] --> src/cpu/mod.rs:800:58 [INFO] [stderr] | [INFO] [stderr] 800 | fn write_r(&mut self, index: u8, byte: u8, mem: &mut Memory) { [INFO] [stderr] | ^^^^^^ help: use `dyn`: `dyn Memory` [INFO] [stderr] [INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stderr] --> src/cpu/mod.rs:808:47 [INFO] [stderr] | [INFO] [stderr] 808 | fn bli(&mut self, a: u8, b: u8, mem: &mut Memory, io: &mut InputOutput) { [INFO] [stderr] | ^^^^^^ help: use `dyn`: `dyn Memory` [INFO] [stderr] [INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stderr] --> src/cpu/mod.rs:49:22 [INFO] [stderr] | [INFO] [stderr] 49 | memory: &mut Memory, [INFO] [stderr] | ^^^^^^ help: use `dyn`: `dyn Memory` [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(bare_trait_objects)]` on by default [INFO] [stderr] [INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stderr] --> src/cpu/mod.rs:50:18 [INFO] [stderr] | [INFO] [stderr] 50 | io: &mut InputOutput, [INFO] [stderr] | ^^^^^^^^^^^ help: use `dyn`: `dyn InputOutput` [INFO] [stderr] [INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stderr] --> src/cpu/mod.rs:73:22 [INFO] [stderr] | [INFO] [stderr] 73 | memory: &mut Memory, [INFO] [stderr] | ^^^^^^ help: use `dyn`: `dyn Memory` [INFO] [stderr] [INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stderr] --> src/cpu/mod.rs:74:18 [INFO] [stderr] | [INFO] [stderr] 74 | io: &mut InputOutput, [INFO] [stderr] | ^^^^^^^^^^^ help: use `dyn`: `dyn InputOutput` [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/cpu/mod.rs:134:18 [INFO] [stderr] | [INFO] [stderr] 134 | (0, 4...7, 0) => { [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(ellipsis_inclusive_range_patterns)]` on by default [INFO] [stderr] [INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stderr] --> src/cpu/mod.rs:539:46 [INFO] [stderr] | [INFO] [stderr] 539 | fn run_cb_opcode(&mut self, memory: &mut Memory, io: &mut InputOutput, ext: bool) -> usize { [INFO] [stderr] | ^^^^^^ help: use `dyn`: `dyn Memory` [INFO] [stderr] [INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stderr] --> src/cpu/mod.rs:539:63 [INFO] [stderr] | [INFO] [stderr] 539 | fn run_cb_opcode(&mut self, memory: &mut Memory, io: &mut InputOutput, ext: bool) -> usize { [INFO] [stderr] | ^^^^^^^^^^^ help: use `dyn`: `dyn InputOutput` [INFO] [stderr] [INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stderr] --> src/cpu/mod.rs:626:58 [INFO] [stderr] | [INFO] [stderr] 626 | fn run_ed_opcode(&mut self, opcode: u8, memory: &mut Memory, io: &mut InputOutput) -> usize { [INFO] [stderr] | ^^^^^^ help: use `dyn`: `dyn Memory` [INFO] [stderr] [INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stderr] --> src/cpu/mod.rs:626:75 [INFO] [stderr] | [INFO] [stderr] 626 | fn run_ed_opcode(&mut self, opcode: u8, memory: &mut Memory, io: &mut InputOutput) -> usize { [INFO] [stderr] | ^^^^^^^^^^^ help: use `dyn`: `dyn InputOutput` [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/cpu/mod.rs:782:21 [INFO] [stderr] | [INFO] [stderr] 782 | (2, _, 0...3) => { [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stderr] --> src/cpu/mod.rs:792:42 [INFO] [stderr] | [INFO] [stderr] 792 | fn r(&mut self, index: u8, mem: &mut Memory) -> u8 { [INFO] [stderr] | ^^^^^^ help: use `dyn`: `dyn Memory` [INFO] [stderr] [INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stderr] --> src/cpu/mod.rs:800:58 [INFO] [stderr] | [INFO] [stderr] 800 | fn write_r(&mut self, index: u8, byte: u8, mem: &mut Memory) { [INFO] [stderr] | ^^^^^^ help: use `dyn`: `dyn Memory` [INFO] [stderr] [INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stderr] --> src/cpu/mod.rs:808:47 [INFO] [stderr] | [INFO] [stderr] 808 | fn bli(&mut self, a: u8, b: u8, mem: &mut Memory, io: &mut InputOutput) { [INFO] [stderr] | ^^^^^^ help: use `dyn`: `dyn Memory` [INFO] [stderr] [INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stderr] --> src/cpu/mod.rs:808:64 [INFO] [stderr] | [INFO] [stderr] 808 | fn bli(&mut self, a: u8, b: u8, mem: &mut Memory, io: &mut InputOutput) { [INFO] [stderr] | ^^^^^^^^^^^ help: use `dyn`: `dyn InputOutput` [INFO] [stderr] [INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stderr] --> src/cpu/mod.rs:952:42 [INFO] [stderr] | [INFO] [stderr] 952 | fn load_inc_dec(&mut self, mem: &mut Memory, inc: bool) { [INFO] [stderr] | ^^^^^^ help: use `dyn`: `dyn Memory` [INFO] [stderr] [INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stderr] --> src/cpu/mod.rs:974:42 [INFO] [stderr] | [INFO] [stderr] 974 | fn comp_inc_dec(&mut self, mem: &mut Memory, inc: bool) { [INFO] [stderr] | ^^^^^^ help: use `dyn`: `dyn Memory` [INFO] [stderr] [INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stderr] --> src/cpu/mod.rs:1274:42 [INFO] [stderr] | [INFO] [stderr] 1274 | fn dec_8(&mut self, y: u8, mem: &mut Memory) { [INFO] [stderr] | ^^^^^^ help: use `dyn`: `dyn Memory` [INFO] [stderr] [INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stderr] --> src/cpu/mod.rs:1288:42 [INFO] [stderr] | [INFO] [stderr] 1288 | fn inc_8(&mut self, y: u8, mem: &mut Memory) { [INFO] [stderr] | ^^^^^^ help: use `dyn`: `dyn Memory` [INFO] [stderr] [INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stderr] --> src/cpu/mod.rs:1303:34 [INFO] [stderr] | [INFO] [stderr] 1303 | fn call(&mut self, mem: &mut Memory, addr: u16) { [INFO] [stderr] | ^^^^^^ help: use `dyn`: `dyn Memory` [INFO] [stderr] [INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stderr] --> src/cpu/mod.rs:1310:33 [INFO] [stderr] | [INFO] [stderr] 1310 | fn ret(&mut self, mem: &mut Memory) { [INFO] [stderr] | ^^^^^^ help: use `dyn`: `dyn Memory` [INFO] [stderr] [INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stderr] --> src/cpu/mod.rs:1316:39 [INFO] [stderr] | [INFO] [stderr] 1316 | fn pop_stack(&mut self, mem: &mut Memory) -> u8 { [INFO] [stderr] | ^^^^^^ help: use `dyn`: `dyn Memory` [INFO] [stderr] [INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stderr] --> src/cpu/mod.rs:1324:40 [INFO] [stderr] | [INFO] [stderr] 1324 | fn push_stack(&mut self, mem: &mut Memory, byte: u8) { [INFO] [stderr] | ^^^^^^ help: use `dyn`: `dyn Memory` [INFO] [stderr] [INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stderr] --> src/cpu/mod.rs:1333:43 [INFO] [stderr] | [INFO] [stderr] 1333 | fn push_stack_16(&mut self, mem: &mut Memory, word: u16) { [INFO] [stderr] | ^^^^^^ help: use `dyn`: `dyn Memory` [INFO] [stderr] [INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stderr] --> src/cpu/mod.rs:1338:42 [INFO] [stderr] | [INFO] [stderr] 1338 | fn pop_stack_16(&mut self, mem: &mut Memory) -> u16 { [INFO] [stderr] | ^^^^^^ help: use `dyn`: `dyn Memory` [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/memory_map.rs:74:24 [INFO] [stderr] | [INFO] [stderr] 74 | (GAME_ROM_START...GAME_ROM_END, false) => { [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/memory_map.rs:78:24 [INFO] [stderr] | [INFO] [stderr] 78 | (GAME_ROM_START...GAME_ROM_END, true) => Err("Cannot write to ROM."), [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/memory_map.rs:80:26 [INFO] [stderr] | [INFO] [stderr] 80 | (VRAM_TILES_START...VRAM_TILES_END, _) => { [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/memory_map.rs:84:29 [INFO] [stderr] | [INFO] [stderr] 84 | (VRAM_PALETTES_START...VRAM_PALETTES_END, _) => { [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/memory_map.rs:88:19 [INFO] [stderr] | [INFO] [stderr] 88 | (RAM_START...RAM_END, _) => Ok(Address::Ram((addr - RAM_START) as usize)), [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/memory_map.rs:90:28 [INFO] [stderr] | [INFO] [stderr] 90 | (VRAM_SPRITES_START...VRAM_SPRITES_END, _) => { [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/memory_map.rs:94:28 [INFO] [stderr] | [INFO] [stderr] 94 | (IN0_REGISTER_START...IN0_REGISTER_END, false) => Ok(Address::IN0Register), [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/memory_map.rs:105:28 [INFO] [stderr] | [INFO] [stderr] 105 | (IN1_REGISTER_START...IN1_REGISTER_END, false) => Ok(Address::IN1Register), [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/memory_map.rs:107:21 [INFO] [stderr] | [INFO] [stderr] 107 | (SOUND_START...SOUND_END, true) => Ok(Address::Sound((addr - SOUND_START) as usize)), [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/memory_map.rs:109:25 [INFO] [stderr] | [INFO] [stderr] 109 | (SPRITE_XY_START...SPRITE_XY_END, true) => { [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/memory_map.rs:113:26 [INFO] [stderr] | [INFO] [stderr] 113 | (DIP_SWITCH_START...DIP_SWITCH_END, _) => Ok(Address::DipSwitchRegister), [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/memory_map.rs:115:24 [INFO] [stderr] | [INFO] [stderr] 115 | (WATCHDOG_START...WATCHDOG_END, _) => Ok(Address::WatchdogTimerReset), [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: unused import: `super::*` [INFO] [stderr] --> src/memory_mapper.rs:68:9 [INFO] [stderr] | [INFO] [stderr] 68 | use super::*; [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(unused_imports)]` on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::boxed::Box` [INFO] [stderr] --> src/memory_mapper.rs:69:9 [INFO] [stderr] | [INFO] [stderr] 69 | use std::boxed::Box; [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: denote infinite loops with `loop { ... }` [INFO] [stderr] --> src/pacman.rs:79:9 [INFO] [stderr] | [INFO] [stderr] 79 | while true { [INFO] [stderr] | ^^^^^^^^^^ help: use `loop` [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(while_true)]` on by default [INFO] [stderr] [INFO] [stderr] warning: unused `#[macro_use]` import [INFO] [stderr] --> src/main.rs:9:13 [INFO] [stderr] | [INFO] [stderr] 9 | #[macro_use(matches)] [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stderr] --> src/cpu/mod.rs:808:64 [INFO] [stderr] | [INFO] [stderr] 808 | fn bli(&mut self, a: u8, b: u8, mem: &mut Memory, io: &mut InputOutput) { [INFO] [stderr] | ^^^^^^^^^^^ help: use `dyn`: `dyn InputOutput` [INFO] [stderr] [INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stderr] --> src/cpu/mod.rs:952:42 [INFO] [stderr] | [INFO] [stderr] 952 | fn load_inc_dec(&mut self, mem: &mut Memory, inc: bool) { [INFO] [stderr] | ^^^^^^ help: use `dyn`: `dyn Memory` [INFO] [stderr] [INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stderr] --> src/cpu/mod.rs:974:42 [INFO] [stderr] | [INFO] [stderr] 974 | fn comp_inc_dec(&mut self, mem: &mut Memory, inc: bool) { [INFO] [stderr] | ^^^^^^ help: use `dyn`: `dyn Memory` [INFO] [stderr] [INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stderr] --> src/cpu/mod.rs:1274:42 [INFO] [stderr] | [INFO] [stderr] 1274 | fn dec_8(&mut self, y: u8, mem: &mut Memory) { [INFO] [stderr] | ^^^^^^ help: use `dyn`: `dyn Memory` [INFO] [stderr] [INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stderr] --> src/cpu/mod.rs:1288:42 [INFO] [stderr] | [INFO] [stderr] 1288 | fn inc_8(&mut self, y: u8, mem: &mut Memory) { [INFO] [stderr] | ^^^^^^ help: use `dyn`: `dyn Memory` [INFO] [stderr] [INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stderr] --> src/cpu/mod.rs:1303:34 [INFO] [stderr] | [INFO] [stderr] 1303 | fn call(&mut self, mem: &mut Memory, addr: u16) { [INFO] [stderr] | ^^^^^^ help: use `dyn`: `dyn Memory` [INFO] [stderr] [INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stderr] --> src/cpu/mod.rs:1310:33 [INFO] [stderr] | [INFO] [stderr] 1310 | fn ret(&mut self, mem: &mut Memory) { [INFO] [stderr] | ^^^^^^ help: use `dyn`: `dyn Memory` [INFO] [stderr] [INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stderr] --> src/cpu/mod.rs:1316:39 [INFO] [stderr] | [INFO] [stderr] 1316 | fn pop_stack(&mut self, mem: &mut Memory) -> u8 { [INFO] [stderr] | ^^^^^^ help: use `dyn`: `dyn Memory` [INFO] [stderr] [INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stderr] --> src/cpu/mod.rs:1324:40 [INFO] [stderr] | [INFO] [stderr] 1324 | fn push_stack(&mut self, mem: &mut Memory, byte: u8) { [INFO] [stderr] | ^^^^^^ help: use `dyn`: `dyn Memory` [INFO] [stderr] [INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stderr] --> src/cpu/mod.rs:1333:43 [INFO] [stderr] | [INFO] [stderr] 1333 | fn push_stack_16(&mut self, mem: &mut Memory, word: u16) { [INFO] [stderr] | ^^^^^^ help: use `dyn`: `dyn Memory` [INFO] [stderr] [INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stderr] --> src/cpu/mod.rs:1338:42 [INFO] [stderr] | [INFO] [stderr] 1338 | fn pop_stack_16(&mut self, mem: &mut Memory) -> u16 { [INFO] [stderr] | ^^^^^^ help: use `dyn`: `dyn Memory` [INFO] [stderr] [INFO] [stderr] warning: unnecessary trailing semicolon [INFO] [stderr] --> src/cpu/tests.rs:258:22 [INFO] [stderr] | [INFO] [stderr] 258 | cpu.reg.sp = 100;; [INFO] [stderr] | ^ help: remove this semicolon [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(redundant_semicolons)]` on by default [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/memory_map.rs:74:24 [INFO] [stderr] | [INFO] [stderr] 74 | (GAME_ROM_START...GAME_ROM_END, false) => { [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/memory_map.rs:78:24 [INFO] [stderr] | [INFO] [stderr] 78 | (GAME_ROM_START...GAME_ROM_END, true) => Err("Cannot write to ROM."), [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/memory_map.rs:80:26 [INFO] [stderr] | [INFO] [stderr] 80 | (VRAM_TILES_START...VRAM_TILES_END, _) => { [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/memory_map.rs:84:29 [INFO] [stderr] | [INFO] [stderr] 84 | (VRAM_PALETTES_START...VRAM_PALETTES_END, _) => { [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/memory_map.rs:88:19 [INFO] [stderr] | [INFO] [stderr] 88 | (RAM_START...RAM_END, _) => Ok(Address::Ram((addr - RAM_START) as usize)), [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/memory_map.rs:90:28 [INFO] [stderr] | [INFO] [stderr] 90 | (VRAM_SPRITES_START...VRAM_SPRITES_END, _) => { [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/memory_map.rs:94:28 [INFO] [stderr] | [INFO] [stderr] 94 | (IN0_REGISTER_START...IN0_REGISTER_END, false) => Ok(Address::IN0Register), [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/memory_map.rs:105:28 [INFO] [stderr] | [INFO] [stderr] 105 | (IN1_REGISTER_START...IN1_REGISTER_END, false) => Ok(Address::IN1Register), [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/memory_map.rs:107:21 [INFO] [stderr] | [INFO] [stderr] 107 | (SOUND_START...SOUND_END, true) => Ok(Address::Sound((addr - SOUND_START) as usize)), [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/memory_map.rs:109:25 [INFO] [stderr] | [INFO] [stderr] 109 | (SPRITE_XY_START...SPRITE_XY_END, true) => { [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/memory_map.rs:113:26 [INFO] [stderr] | [INFO] [stderr] 113 | (DIP_SWITCH_START...DIP_SWITCH_END, _) => Ok(Address::DipSwitchRegister), [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: `...` range patterns are deprecated [INFO] [stderr] --> src/memory_map.rs:115:24 [INFO] [stderr] | [INFO] [stderr] 115 | (WATCHDOG_START...WATCHDOG_END, _) => Ok(Address::WatchdogTimerReset), [INFO] [stderr] | ^^^ help: use `..=` for an inclusive range [INFO] [stderr] [INFO] [stderr] warning: denote infinite loops with `loop { ... }` [INFO] [stderr] --> src/pacman.rs:79:9 [INFO] [stderr] | [INFO] [stderr] 79 | while true { [INFO] [stderr] | ^^^^^^^^^^ help: use `loop` [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(while_true)]` on by default [INFO] [stderr] [INFO] [stderr] warning: unreachable pattern [INFO] [stderr] --> src/cpu/mod.rs:912:13 [INFO] [stderr] | [INFO] [stderr] 912 | (5, 2) => { [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(unreachable_patterns)]` on by default [INFO] [stderr] [INFO] [stderr] warning: unreachable pattern [INFO] [stderr] --> src/cpu/mod.rs:919:13 [INFO] [stderr] | [INFO] [stderr] 919 | (6, 2) => { [INFO] [stderr] | ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unreachable pattern [INFO] [stderr] --> src/cpu/mod.rs:933:13 [INFO] [stderr] | [INFO] [stderr] 933 | (7, 2) => { [INFO] [stderr] | ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused variable: `i` [INFO] [stderr] --> src/cpu/mod.rs:57:13 [INFO] [stderr] | [INFO] [stderr] 57 | for i in 0..iters { [INFO] [stderr] | ^ help: if this is intentional, prefix it with an underscore: `_i` [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(unused_variables)]` on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `io` [INFO] [stderr] --> src/cpu/mod.rs:539:54 [INFO] [stderr] | [INFO] [stderr] 539 | fn run_cb_opcode(&mut self, memory: &mut Memory, io: &mut InputOutput, ext: bool) -> usize { [INFO] [stderr] | ^^ help: if this is intentional, prefix it with an underscore: `_io` [INFO] [stderr] [INFO] [stderr] warning: variable `number_of_ones` is assigned to, but never used [INFO] [stderr] --> src/cpu/mod.rs:1381:13 [INFO] [stderr] | [INFO] [stderr] 1381 | let mut number_of_ones = 0; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: consider using `_number_of_ones` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `port` [INFO] [stderr] --> src/cpu/io.rs:21:21 [INFO] [stderr] | [INFO] [stderr] 21 | fn input(&self, port: u8) -> u8 { [INFO] [stderr] | ^^^^ help: if this is intentional, prefix it with an underscore: `_port` [INFO] [stderr] [INFO] [stderr] warning: unused variable: `port` [INFO] [stderr] --> src/cpu/io.rs:25:26 [INFO] [stderr] | [INFO] [stderr] 25 | fn output(&mut self, port: u8, byte: u8) { [INFO] [stderr] | ^^^^ help: if this is intentional, prefix it with an underscore: `_port` [INFO] [stderr] [INFO] [stderr] warning: unused variable: `result` [INFO] [stderr] --> src/display.rs:49:21 [INFO] [stderr] | [INFO] [stderr] 49 | let result = canvas.fill_rect(Rect::new(x_coord, y_coord, 2, 2)); [INFO] [stderr] | ^^^^^^ help: if this is intentional, prefix it with an underscore: `_result` [INFO] [stderr] [INFO] [stderr] warning: unused variable: `x_flip` [INFO] [stderr] --> src/display.rs:62:9 [INFO] [stderr] | [INFO] [stderr] 62 | x_flip: bool, [INFO] [stderr] | ^^^^^^ help: if this is intentional, prefix it with an underscore: `_x_flip` [INFO] [stderr] [INFO] [stderr] warning: unused variable: `y_flip` [INFO] [stderr] --> src/display.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | y_flip: bool, [INFO] [stderr] | ^^^^^^ help: if this is intentional, prefix it with an underscore: `_y_flip` [INFO] [stderr] [INFO] [stderr] warning: unused variable: `port` [INFO] [stderr] --> src/interrupt_vector.rs:14:21 [INFO] [stderr] | [INFO] [stderr] 14 | fn input(&self, port: u8) -> u8 { [INFO] [stderr] | ^^^^ help: if this is intentional, prefix it with an underscore: `_port` [INFO] [stderr] [INFO] [stderr] warning: unused variable: `port` [INFO] [stderr] --> src/interrupt_vector.rs:18:26 [INFO] [stderr] | [INFO] [stderr] 18 | fn output(&mut self, port: u8, byte: u8) { [INFO] [stderr] | ^^^^ help: if this is intentional, prefix it with an underscore: `_port` [INFO] [stderr] [INFO] [stderr] warning: unused variable: `color` [INFO] [stderr] --> src/rom.rs:104:17 [INFO] [stderr] | [INFO] [stderr] 104 | let color = self.color_rom[*byte as usize]; [INFO] [stderr] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_color` [INFO] [stderr] [INFO] [stderr] warning: unused variable: `why` [INFO] [stderr] --> src/rom.rs:137:17 [INFO] [stderr] | [INFO] [stderr] 137 | Err(why) => panic!("Missing ROMs"), [INFO] [stderr] | ^^^ help: if this is intentional, prefix it with an underscore: `_why` [INFO] [stderr] [INFO] [stderr] warning: unused variable: `why` [INFO] [stderr] --> src/rom.rs:142:17 [INFO] [stderr] | [INFO] [stderr] 142 | Err(why) => panic!("Error reading ROM"), [INFO] [stderr] | ^^^ help: if this is intentional, prefix it with an underscore: `_why` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/cpu/mod.rs:1145:13 [INFO] [stderr] | [INFO] [stderr] 1145 | let mut result = left.wrapping_sub(right); [INFO] [stderr] | ----^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(unused_mut)]` on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/cpu/mod.rs:1347:13 [INFO] [stderr] | [INFO] [stderr] 1347 | let mut left = left + (carry as u8); [INFO] [stderr] | ----^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/cpu/mod.rs:1354:13 [INFO] [stderr] | [INFO] [stderr] 1354 | let mut left = left - (carry as u8); [INFO] [stderr] | ----^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: method is never used: `new` [INFO] [stderr] --> src/cpu/io.rs:15:5 [INFO] [stderr] | [INFO] [stderr] 15 | pub fn new() -> Self { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(dead_code)]` on by default [INFO] [stderr] [INFO] [stderr] warning: method is never used: `new` [INFO] [stderr] --> src/cpu/mem.rs:26:5 [INFO] [stderr] | [INFO] [stderr] 26 | pub fn new() -> Self { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `draw_sprite` [INFO] [stderr] --> src/display.rs:30:5 [INFO] [stderr] | [INFO] [stderr] 30 | pub fn draw_sprite(&mut self, x: usize, y: usize, sprite: usize, palette: usize) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `VramPalettes` [INFO] [stderr] --> src/memory_map.rs:46:5 [INFO] [stderr] | [INFO] [stderr] 46 | VramPalettes(usize), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never read: `roms` [INFO] [stderr] --> src/pacman.rs:13:5 [INFO] [stderr] | [INFO] [stderr] 13 | roms: &'a Box, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: 64 warnings emitted [INFO] [stderr] [INFO] [stderr] warning: unreachable pattern [INFO] [stderr] --> src/cpu/mod.rs:912:13 [INFO] [stderr] | [INFO] [stderr] 912 | (5, 2) => { [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(unreachable_patterns)]` on by default [INFO] [stderr] [INFO] [stderr] warning: unreachable pattern [INFO] [stderr] --> src/cpu/mod.rs:919:13 [INFO] [stderr] | [INFO] [stderr] 919 | (6, 2) => { [INFO] [stderr] | ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unreachable pattern [INFO] [stderr] --> src/cpu/mod.rs:933:13 [INFO] [stderr] | [INFO] [stderr] 933 | (7, 2) => { [INFO] [stderr] | ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused variable: `i` [INFO] [stderr] --> src/cpu/mod.rs:57:13 [INFO] [stderr] | [INFO] [stderr] 57 | for i in 0..iters { [INFO] [stderr] | ^ help: if this is intentional, prefix it with an underscore: `_i` [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(unused_variables)]` on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `io` [INFO] [stderr] --> src/cpu/mod.rs:539:54 [INFO] [stderr] | [INFO] [stderr] 539 | fn run_cb_opcode(&mut self, memory: &mut Memory, io: &mut InputOutput, ext: bool) -> usize { [INFO] [stderr] | ^^ help: if this is intentional, prefix it with an underscore: `_io` [INFO] [stderr] [INFO] [stderr] warning: variable `number_of_ones` is assigned to, but never used [INFO] [stderr] --> src/cpu/mod.rs:1381:13 [INFO] [stderr] | [INFO] [stderr] 1381 | let mut number_of_ones = 0; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: consider using `_number_of_ones` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `port` [INFO] [stderr] --> src/cpu/io.rs:21:21 [INFO] [stderr] | [INFO] [stderr] 21 | fn input(&self, port: u8) -> u8 { [INFO] [stderr] | ^^^^ help: if this is intentional, prefix it with an underscore: `_port` [INFO] [stderr] [INFO] [stderr] warning: unused variable: `port` [INFO] [stderr] --> src/cpu/io.rs:25:26 [INFO] [stderr] | [INFO] [stderr] 25 | fn output(&mut self, port: u8, byte: u8) { [INFO] [stderr] | ^^^^ help: if this is intentional, prefix it with an underscore: `_port` [INFO] [stderr] [INFO] [stderr] warning: unused variable: `mem` [INFO] [stderr] --> src/cpu/tests.rs:85:9 [INFO] [stderr] | [INFO] [stderr] 85 | let mut mem = &mut TestMemory::new(); [INFO] [stderr] | ^^^^^^^ help: if this is intentional, prefix it with an underscore: `_mem` [INFO] [stderr] [INFO] [stderr] warning: unused variable: `result` [INFO] [stderr] --> src/display.rs:49:21 [INFO] [stderr] | [INFO] [stderr] 49 | let result = canvas.fill_rect(Rect::new(x_coord, y_coord, 2, 2)); [INFO] [stderr] | ^^^^^^ help: if this is intentional, prefix it with an underscore: `_result` [INFO] [stderr] [INFO] [stderr] warning: unused variable: `x_flip` [INFO] [stderr] --> src/display.rs:62:9 [INFO] [stderr] | [INFO] [stderr] 62 | x_flip: bool, [INFO] [stderr] | ^^^^^^ help: if this is intentional, prefix it with an underscore: `_x_flip` [INFO] [stderr] [INFO] [stderr] warning: unused variable: `y_flip` [INFO] [stderr] --> src/display.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | y_flip: bool, [INFO] [stderr] | ^^^^^^ help: if this is intentional, prefix it with an underscore: `_y_flip` [INFO] [stderr] [INFO] [stderr] warning: unused variable: `port` [INFO] [stderr] --> src/interrupt_vector.rs:14:21 [INFO] [stderr] | [INFO] [stderr] 14 | fn input(&self, port: u8) -> u8 { [INFO] [stderr] | ^^^^ help: if this is intentional, prefix it with an underscore: `_port` [INFO] [stderr] [INFO] [stderr] warning: unused variable: `port` [INFO] [stderr] --> src/interrupt_vector.rs:18:26 [INFO] [stderr] | [INFO] [stderr] 18 | fn output(&mut self, port: u8, byte: u8) { [INFO] [stderr] | ^^^^ help: if this is intentional, prefix it with an underscore: `_port` [INFO] [stderr] [INFO] [stderr] warning: unused variable: `color` [INFO] [stderr] --> src/rom.rs:104:17 [INFO] [stderr] | [INFO] [stderr] 104 | let color = self.color_rom[*byte as usize]; [INFO] [stderr] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_color` [INFO] [stderr] [INFO] [stderr] warning: unused variable: `why` [INFO] [stderr] --> src/rom.rs:137:17 [INFO] [stderr] | [INFO] [stderr] 137 | Err(why) => panic!("Missing ROMs"), [INFO] [stderr] | ^^^ help: if this is intentional, prefix it with an underscore: `_why` [INFO] [stderr] [INFO] [stderr] warning: unused variable: `why` [INFO] [stderr] --> src/rom.rs:142:17 [INFO] [stderr] | [INFO] [stderr] 142 | Err(why) => panic!("Error reading ROM"), [INFO] [stderr] | ^^^ help: if this is intentional, prefix it with an underscore: `_why` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/cpu/mod.rs:1145:13 [INFO] [stderr] | [INFO] [stderr] 1145 | let mut result = left.wrapping_sub(right); [INFO] [stderr] | ----^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(unused_mut)]` on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/cpu/mod.rs:1347:13 [INFO] [stderr] | [INFO] [stderr] 1347 | let mut left = left + (carry as u8); [INFO] [stderr] | ----^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/cpu/mod.rs:1354:13 [INFO] [stderr] | [INFO] [stderr] 1354 | let mut left = left - (carry as u8); [INFO] [stderr] | ----^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/cpu/tests.rs:85:9 [INFO] [stderr] | [INFO] [stderr] 85 | let mut mem = &mut TestMemory::new(); [INFO] [stderr] | ----^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: method is never used: `draw_sprite` [INFO] [stderr] --> src/display.rs:30:5 [INFO] [stderr] | [INFO] [stderr] 30 | pub fn draw_sprite(&mut self, x: usize, y: usize, sprite: usize, palette: usize) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(dead_code)]` on by default [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `VramPalettes` [INFO] [stderr] --> src/memory_map.rs:46:5 [INFO] [stderr] | [INFO] [stderr] 46 | VramPalettes(usize), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never read: `roms` [INFO] [stderr] --> src/pacman.rs:13:5 [INFO] [stderr] | [INFO] [stderr] 13 | roms: &'a Box, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: 62 warnings emitted [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 7.01s [INFO] running `"docker" "inspect" "6d6ea1292c7bbe75840394922891f6212272409c9105cae13a8a172b73dd2181"` [INFO] running `"docker" "rm" "-f" "6d6ea1292c7bbe75840394922891f6212272409c9105cae13a8a172b73dd2181"` [INFO] [stdout] 6d6ea1292c7bbe75840394922891f6212272409c9105cae13a8a172b73dd2181