[INFO] updating cached repository Thomas-Neill/rsnes
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/Thomas-Neill/rsnes
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/Thomas-Neill/rsnes" "work/ex/pr-63376/sources/master#60960a260f7b5c695fd0717311d72ce62dd4eb43/gh/Thomas-Neill/rsnes"`
[INFO] [stderr] Cloning into 'work/ex/pr-63376/sources/master#60960a260f7b5c695fd0717311d72ce62dd4eb43/gh/Thomas-Neill/rsnes'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/Thomas-Neill/rsnes" "work/ex/pr-63376/sources/try#266783e4e09e4e9d5307c1c8e695659c58bbcac7/gh/Thomas-Neill/rsnes"`
[INFO] [stderr] Cloning into 'work/ex/pr-63376/sources/try#266783e4e09e4e9d5307c1c8e695659c58bbcac7/gh/Thomas-Neill/rsnes'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] 1787e217bd5d739a5bfe83e4b7c75d3bd5119a1f
[INFO] sha for GitHub repo Thomas-Neill/rsnes: 1787e217bd5d739a5bfe83e4b7c75d3bd5119a1f
[INFO] validating manifest of Thomas-Neill/rsnes on toolchain master#60960a260f7b5c695fd0717311d72ce62dd4eb43
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+60960a260f7b5c695fd0717311d72ce62dd4eb43-alt" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of Thomas-Neill/rsnes on toolchain try#266783e4e09e4e9d5307c1c8e695659c58bbcac7
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+266783e4e09e4e9d5307c1c8e695659c58bbcac7-alt" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing Thomas-Neill/rsnes
[INFO] finished frobbing Thomas-Neill/rsnes
[INFO] frobbed toml for Thomas-Neill/rsnes written to work/ex/pr-63376/sources/master#60960a260f7b5c695fd0717311d72ce62dd4eb43/gh/Thomas-Neill/rsnes/Cargo.toml
[INFO] started frobbing Thomas-Neill/rsnes
[INFO] finished frobbing Thomas-Neill/rsnes
[INFO] frobbed toml for Thomas-Neill/rsnes written to work/ex/pr-63376/sources/try#266783e4e09e4e9d5307c1c8e695659c58bbcac7/gh/Thomas-Neill/rsnes/Cargo.toml
[INFO] crate Thomas-Neill/rsnes already has a lockfile, it will not be regenerated
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+60960a260f7b5c695fd0717311d72ce62dd4eb43-alt" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+266783e4e09e4e9d5307c1c8e695659c58bbcac7-alt" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] checking Thomas-Neill/rsnes against try#266783e4e09e4e9d5307c1c8e695659c58bbcac7 for pr-63376
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/pr-63376/worker-1/try#266783e4e09e4e9d5307c1c8e695659c58bbcac7:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/pr-63376/sources/try#266783e4e09e4e9d5307c1c8e695659c58bbcac7/gh/Thomas-Neill/rsnes:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+266783e4e09e4e9d5307c1c8e695659c58bbcac7-alt" "check" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] ecb234403862750a83420514ed431dc6574862febee82b4117f9808278355dcb
[INFO] running `"docker" "start" "-a" "ecb234403862750a83420514ed431dc6574862febee82b4117f9808278355dcb"`
[INFO] [stderr]    Compiling rsnes v0.1.0 (/opt/crater/workdir)
[INFO] [stderr]     Checking c_vec v1.3.0
[INFO] [stderr]     Checking bincode v1.0.1
[INFO] [stderr]     Checking sdl2 v0.31.0
[INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated
[INFO] [stderr]   --> src/cpu.rs:57:24
[INFO] [stderr]    |
[INFO] [stderr] 57 |     mapper: Rc<RefCell<Mapper>>,
[INFO] [stderr]    |                        ^^^^^^ help: use `dyn`: `dyn Mapper`
[INFO] [stderr]    |
[INFO] [stderr]    = note: `#[warn(bare_trait_objects)]` on by default
[INFO] [stderr] 
[INFO] [stderr] warning: type `CPU_Serial` should have an upper camel case name
[INFO] [stderr]   --> src/cpu.rs:75:8
[INFO] [stderr]    |
[INFO] [stderr] 75 | struct CPU_Serial { //no refcells
[INFO] [stderr]    |        ^^^^^^^^^^ help: convert the identifier to upper camel case: `CpuSerial`
[INFO] [stderr]    |
[INFO] [stderr]    = note: `#[warn(non_camel_case_types)]` on by default
[INFO] [stderr] 
[INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated
[INFO] [stderr]    --> src/cpu.rs:137:35
[INFO] [stderr]     |
[INFO] [stderr] 137 |     pub fn new(mapper: Rc<RefCell<Mapper>>, ppu: Rc<RefCell<PPU>>) -> CPU {
[INFO] [stderr]     |                                   ^^^^^^ help: use `dyn`: `dyn Mapper`
[INFO] [stderr] 
[INFO] [stderr] warning: `...` range patterns are deprecated
[INFO] [stderr]    --> src/cpu.rs:184:14
[INFO] [stderr]     |
[INFO] [stderr] 184 |             0...0x1FFF => self.ram[location as usize& 0x7FF],
[INFO] [stderr]     |              ^^^ help: use `..=` for an inclusive range
[INFO] [stderr]     |
[INFO] [stderr]     = note: `#[warn(ellipsis_inclusive_range_patterns)]` on by default
[INFO] [stderr] 
[INFO] [stderr] warning: `...` range patterns are deprecated
[INFO] [stderr]    --> src/cpu.rs:193:19
[INFO] [stderr]     |
[INFO] [stderr] 193 |             0x2008...0x3FFF => self.contents(location & 0x2007),
[INFO] [stderr]     |                   ^^^ help: use `..=` for an inclusive range
[INFO] [stderr] 
[INFO] [stderr] warning: `...` range patterns are deprecated
[INFO] [stderr]    --> src/cpu.rs:194:19
[INFO] [stderr]     |
[INFO] [stderr] 194 |             0x4000...0x4014 => 0,
[INFO] [stderr]     |                   ^^^ help: use `..=` for an inclusive range
[INFO] [stderr] 
[INFO] [stderr] warning: `...` range patterns are deprecated
[INFO] [stderr]    --> src/cpu.rs:216:19
[INFO] [stderr]     |
[INFO] [stderr] 216 |             0x4016...0x401F => 0,
[INFO] [stderr]     |                   ^^^ help: use `..=` for an inclusive range
[INFO] [stderr] 
[INFO] [stderr] warning: `...` range patterns are deprecated
[INFO] [stderr]    --> src/cpu.rs:217:19
[INFO] [stderr]     |
[INFO] [stderr] 217 |             0x4020...0xFFFF => self.mapper.borrow_mut().contents(location),
[INFO] [stderr]     |                   ^^^ help: use `..=` for an inclusive range
[INFO] [stderr] 
[INFO] [stderr] warning: `...` range patterns are deprecated
[INFO] [stderr]    --> src/cpu.rs:223:14
[INFO] [stderr]     |
[INFO] [stderr] 223 |             0...0x1FFF => self.ram[location as usize & 0x7FF] = value,
[INFO] [stderr]     |              ^^^ help: use `..=` for an inclusive range
[INFO] [stderr] 
[INFO] [stderr] warning: `...` range patterns are deprecated
[INFO] [stderr]    --> src/cpu.rs:232:19
[INFO] [stderr]     |
[INFO] [stderr] 232 |             0x2008...0x3FFF => self.set_contents(location & 0x2007,value),
[INFO] [stderr]     |                   ^^^ help: use `..=` for an inclusive range
[INFO] [stderr] 
[INFO] [stderr] warning: `...` range patterns are deprecated
[INFO] [stderr]    --> src/cpu.rs:233:19
[INFO] [stderr]     |
[INFO] [stderr] 233 |             0x4000...0x4013 => apu_write(self.elapsed+self.cycles_delay as i32,location,value),
[INFO] [stderr]     |                   ^^^ help: use `..=` for an inclusive range
[INFO] [stderr] 
[INFO] [stderr] warning: `...` range patterns are deprecated
[INFO] [stderr]    --> src/cpu.rs:247:19
[INFO] [stderr]     |
[INFO] [stderr] 247 |             0x4018...0x401F => (),
[INFO] [stderr]     |                   ^^^ help: use `..=` for an inclusive range
[INFO] [stderr] 
[INFO] [stderr] warning: `...` range patterns are deprecated
[INFO] [stderr]    --> src/cpu.rs:248:19
[INFO] [stderr]     |
[INFO] [stderr] 248 |             0x4020...0xFFFF => self.mapper.borrow_mut().set_contents(location,value),
[INFO] [stderr]     |                   ^^^ help: use `..=` for an inclusive range
[INFO] [stderr] 
[INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated
[INFO] [stderr]   --> src/ppu.rs:26:24
[INFO] [stderr]    |
[INFO] [stderr] 26 |     mapper: Rc<RefCell<Mapper>>,
[INFO] [stderr]    |                        ^^^^^^ help: use `dyn`: `dyn Mapper`
[INFO] [stderr] 
[INFO] [stderr] warning: type `PPU_Serial` should have an upper camel case name
[INFO] [stderr]   --> src/ppu.rs:92:12
[INFO] [stderr]    |
[INFO] [stderr] 92 | pub struct PPU_Serial { //PPU w/o one reference.... kms
[INFO] [stderr]    |            ^^^^^^^^^^ help: convert the identifier to upper camel case: `PpuSerial`
[INFO] [stderr] 
[INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated
[INFO] [stderr]    --> src/ppu.rs:242:34
[INFO] [stderr]     |
[INFO] [stderr] 242 |     pub fn new(mapper:Rc<RefCell<Mapper>>) -> PPU {
[INFO] [stderr]     |                                  ^^^^^^ help: use `dyn`: `dyn Mapper`
[INFO] [stderr] 
[INFO] [stderr] warning: `...` range patterns are deprecated
[INFO] [stderr]    --> src/ppu.rs:373:20
[INFO] [stderr]     |
[INFO] [stderr] 373 |             0x3F00 ... 0x3FFF => {
[INFO] [stderr]     |                    ^^^ help: use `..=` for an inclusive range
[INFO] [stderr] 
[INFO] [stderr] warning: `...` range patterns are deprecated
[INFO] [stderr]    --> src/ppu.rs:392:20
[INFO] [stderr]     |
[INFO] [stderr] 392 |             0x3F00 ... 0x3FFF => {
[INFO] [stderr]     |                    ^^^ help: use `..=` for an inclusive range
[INFO] [stderr] 
[INFO] [stderr] warning: type `NROM_Serial` should have an upper camel case name
[INFO] [stderr]   --> src/mappers.rs:29:8
[INFO] [stderr]    |
[INFO] [stderr] 29 | struct NROM_Serial {
[INFO] [stderr]    |        ^^^^^^^^^^^ help: convert the identifier to upper camel case: `NromSerial`
[INFO] [stderr] 
[INFO] [stderr] warning: `...` range patterns are deprecated
[INFO] [stderr]   --> src/mappers.rs:52:19
[INFO] [stderr]    |
[INFO] [stderr] 52 |             0x6000...0x7FFF => self.prgram[location - 0x6000],
[INFO] [stderr]    |                   ^^^ help: use `..=` for an inclusive range
[INFO] [stderr] 
[INFO] [stderr] warning: `...` range patterns are deprecated
[INFO] [stderr]   --> src/mappers.rs:53:19
[INFO] [stderr]    |
[INFO] [stderr] 53 |             0x8000...0xFFFF => {
[INFO] [stderr]    |                   ^^^ help: use `..=` for an inclusive range
[INFO] [stderr] 
[INFO] [stderr] warning: `...` range patterns are deprecated
[INFO] [stderr]   --> src/mappers.rs:62:19
[INFO] [stderr]    |
[INFO] [stderr] 62 |             0x6000...0x7FFF => self.prgram[location as usize - 0x6000] = what,
[INFO] [stderr]    |                   ^^^ help: use `..=` for an inclusive range
[INFO] [stderr] 
[INFO] [stderr] warning: `...` range patterns are deprecated
[INFO] [stderr]   --> src/mappers.rs:69:14
[INFO] [stderr]    |
[INFO] [stderr] 69 |             0...0x1FFF => self.ines.chrrom[location],
[INFO] [stderr]    |              ^^^ help: use `..=` for an inclusive range
[INFO] [stderr] 
[INFO] [stderr] warning: `...` range patterns are deprecated
[INFO] [stderr]   --> src/mappers.rs:70:19
[INFO] [stderr]    |
[INFO] [stderr] 70 |             0x2000...0x3EFF => {
[INFO] [stderr]    |                   ^^^ help: use `..=` for an inclusive range
[INFO] [stderr] 
[INFO] [stderr] warning: `...` range patterns are deprecated
[INFO] [stderr]   --> src/mappers.rs:73:22
[INFO] [stderr]    |
[INFO] [stderr] 73 |                     0...0x3FF => 0,
[INFO] [stderr]    |                      ^^^ help: use `..=` for an inclusive range
[INFO] [stderr] 
[INFO] [stderr] warning: `...` range patterns are deprecated
[INFO] [stderr]   --> src/mappers.rs:74:26
[INFO] [stderr]    |
[INFO] [stderr] 74 |                     0x400...0x7FF => (self.ines.vertical_mirroring) as usize,
[INFO] [stderr]    |                          ^^^ help: use `..=` for an inclusive range
[INFO] [stderr] 
[INFO] [stderr] warning: `...` range patterns are deprecated
[INFO] [stderr]   --> src/mappers.rs:75:26
[INFO] [stderr]    |
[INFO] [stderr] 75 |                     0x800...0xBFF => (!self.ines.vertical_mirroring) as usize,
[INFO] [stderr]    |                          ^^^ help: use `..=` for an inclusive range
[INFO] [stderr] 
[INFO] [stderr] warning: `...` range patterns are deprecated
[INFO] [stderr]   --> src/mappers.rs:76:26
[INFO] [stderr]    |
[INFO] [stderr] 76 |                     0xC00...0xFFF => 1,
[INFO] [stderr]    |                          ^^^ help: use `..=` for an inclusive range
[INFO] [stderr] 
[INFO] [stderr] warning: `...` range patterns are deprecated
[INFO] [stderr]   --> src/mappers.rs:88:14
[INFO] [stderr]    |
[INFO] [stderr] 88 |             0...0x1FFF => {
[INFO] [stderr]    |              ^^^ help: use `..=` for an inclusive range
[INFO] [stderr] 
[INFO] [stderr] warning: `...` range patterns are deprecated
[INFO] [stderr]   --> src/mappers.rs:91:19
[INFO] [stderr]    |
[INFO] [stderr] 91 |             0x2000...0x3EFF => {
[INFO] [stderr]    |                   ^^^ help: use `..=` for an inclusive range
[INFO] [stderr] 
[INFO] [stderr] warning: `...` range patterns are deprecated
[INFO] [stderr]   --> src/mappers.rs:94:22
[INFO] [stderr]    |
[INFO] [stderr] 94 |                     0...0x3FF => 0,
[INFO] [stderr]    |                      ^^^ help: use `..=` for an inclusive range
[INFO] [stderr] 
[INFO] [stderr] warning: `...` range patterns are deprecated
[INFO] [stderr]   --> src/mappers.rs:95:26
[INFO] [stderr]    |
[INFO] [stderr] 95 |                     0x400...0x7FF => (self.ines.vertical_mirroring) as usize,
[INFO] [stderr]    |                          ^^^ help: use `..=` for an inclusive range
[INFO] [stderr] 
[INFO] [stderr] warning: `...` range patterns are deprecated
[INFO] [stderr]   --> src/mappers.rs:96:26
[INFO] [stderr]    |
[INFO] [stderr] 96 |                     0x800...0xBFF => (!self.ines.vertical_mirroring) as usize,
[INFO] [stderr]    |                          ^^^ help: use `..=` for an inclusive range
[INFO] [stderr] 
[INFO] [stderr] warning: `...` range patterns are deprecated
[INFO] [stderr]   --> src/mappers.rs:97:26
[INFO] [stderr]    |
[INFO] [stderr] 97 |                     0xC00...0xFFF => 1,
[INFO] [stderr]    |                          ^^^ help: use `..=` for an inclusive range
[INFO] [stderr] 
[INFO] [stderr] warning: type `MMC1_Serial` should have an upper camel case name
[INFO] [stderr]    --> src/mappers.rs:128:8
[INFO] [stderr]     |
[INFO] [stderr] 128 | struct MMC1_Serial {
[INFO] [stderr]     |        ^^^^^^^^^^^ help: convert the identifier to upper camel case: `Mmc1Serial`
[INFO] [stderr] 
[INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated
[INFO] [stderr]   --> src/cpu.rs:57:24
[INFO] [stderr]    |
[INFO] [stderr] 57 |     mapper: Rc<RefCell<Mapper>>,
[INFO] [stderr]    |                        ^^^^^^ help: use `dyn`: `dyn Mapper`
[INFO] [stderr] warning: `...` range patterns are deprecated
[INFO] [stderr]    --> src/mappers.rs:179:19
[INFO] [stderr]     |
[INFO] [stderr] 179 |             0x6000...0x7FFF =>
[INFO] [stderr]     |                   ^^^ help: use `..=` for an inclusive range
[INFO] [stderr] 
[INFO] [stderr] warning: `...` range patterns are deprecated
[INFO] [stderr]    --> src/mappers.rs:181:19
[INFO] [stderr]     |
[INFO] [stderr] 181 |             0x8000...0xFFFF => {
[INFO] [stderr]     |                   ^^^ help: use `..=` for an inclusive range
[INFO] [stderr] 
[INFO] [stderr] warning: `...` range patterns are deprecated
[INFO] [stderr]    --> src/mappers.rs:184:22
[INFO] [stderr]     |
[INFO] [stderr] 184 |                     0...1 => { //choose 32 kb bank
[INFO] [stderr]     |                      ^^^ help: use `..=` for an inclusive range
[INFO] [stderr] 
[INFO] [stderr] warning: `...` range patterns are deprecated
[INFO] [stderr]    --> src/mappers.rs:209:19
[INFO] [stderr]     |
[INFO] [stderr] 209 |             0x6000...0x7FFF => {
[INFO] [stderr]     |                   ^^^ help: use `..=` for an inclusive range
[INFO] [stderr] 
[INFO] [stderr] warning: `...` range patterns are deprecated
[INFO] [stderr]    --> src/mappers.rs:212:19
[INFO] [stderr]     |
[INFO] [stderr] 212 |             0x8000...0xFFFF => {
[INFO] [stderr]     |                   ^^^ help: use `..=` for an inclusive range
[INFO] [stderr] 
[INFO] [stderr] warning: `...` range patterns are deprecated
[INFO] [stderr]    --> src/mappers.rs:222:35
[INFO] [stderr]     |
[INFO] [stderr] 222 |                             0x8000...0x9FFF => {
[INFO] [stderr]     |                                   ^^^ help: use `..=` for an inclusive range
[INFO] [stderr] 
[INFO] [stderr] warning: `...` range patterns are deprecated
[INFO] [stderr]    --> src/mappers.rs:227:35
[INFO] [stderr]     |
[INFO] [stderr] 227 |                             0xA000...0xBFFF => {
[INFO] [stderr]     |                                   ^^^ help: use `..=` for an inclusive range
[INFO] [stderr] 
[INFO] [stderr] warning: `...` range patterns are deprecated
[INFO] [stderr]    --> src/mappers.rs:230:35
[INFO] [stderr]     |
[INFO] [stderr] 230 |                             0xC000...0xDFFF => {
[INFO] [stderr]     |                                   ^^^ help: use `..=` for an inclusive range
[INFO] [stderr] 
[INFO] [stderr] warning: `...` range patterns are deprecated
[INFO] [stderr]    --> src/mappers.rs:233:35
[INFO] [stderr]     |
[INFO] [stderr] 233 |                             0xE000...0xFFFF => {
[INFO] [stderr]     |                                   ^^^ help: use `..=` for an inclusive range
[INFO] [stderr] 
[INFO] [stderr] warning: `...` range patterns are deprecated
[INFO] [stderr]    --> src/mappers.rs:249:14
[INFO] [stderr]     |
[INFO] [stderr] 249 |             0...0x1FFF => {
[INFO] [stderr]     |              ^^^ help: use `..=` for an inclusive range
[INFO] [stderr] 
[INFO] [stderr] warning: `...` range patterns are deprecated
[INFO] [stderr]    --> src/mappers.rs:264:19
[INFO] [stderr]     |
[INFO] [stderr] 264 |             0x2000...0x3EFF => {
[INFO] [stderr]     |                   ^^^ help: use `..=` for an inclusive range
[INFO] [stderr] 
[INFO] [stderr] warning: `...` range patterns are deprecated
[INFO] [stderr]    --> src/mappers.rs:267:22
[INFO] [stderr]     |
[INFO] [stderr] 267 |                     0...0x3FF => (self.mirroringtype == 1) as usize,
[INFO] [stderr]     |                      ^^^ help: use `..=` for an inclusive range
[INFO] [stderr] 
[INFO] [stderr] warning: `...` range patterns are deprecated
[INFO] [stderr]    --> src/mappers.rs:268:26
[INFO] [stderr]     |
[INFO] [stderr] 268 |                     0x400...0x7FF => (self.mirroringtype == 2 || self.mirroringtype == 1) as usize,
[INFO] [stderr]     |                          ^^^ help: use `..=` for an inclusive range
[INFO] [stderr] 
[INFO] [stderr] warning: `...` range patterns are deprecated
[INFO] [stderr]    --> src/mappers.rs:269:26
[INFO] [stderr]     |
[INFO] [stderr] 269 |                     0x800...0xBFF => (self.mirroringtype == 1 || self.mirroringtype == 3) as usize,
[INFO] [stderr]     |                          ^^^ help: use `..=` for an inclusive range
[INFO] [stderr] 
[INFO] [stderr] warning: `...` range patterns are deprecated
[INFO] [stderr]    --> src/mappers.rs:270:26
[INFO] [stderr]     |
[INFO] [stderr] 270 |                     0xC00...0xFFF => (self.mirroringtype != 0) as usize,
[INFO] [stderr]     |                          ^^^ help: use `..=` for an inclusive range
[INFO] [stderr] 
[INFO] [stderr] warning: `...` range patterns are deprecated
[INFO] [stderr]    --> src/mappers.rs:282:14
[INFO] [stderr]     |
[INFO] [stderr] 282 |             0...0x1FFF if self.ines.chrrom_size == 0 => {
[INFO] [stderr]     |              ^^^ help: use `..=` for an inclusive range
[INFO] [stderr] 
[INFO] [stderr] warning: `...` range patterns are deprecated
[INFO] [stderr]    --> src/mappers.rs:297:19
[INFO] [stderr]     |
[INFO] [stderr] 297 |             0x2000...0x3EFF => {
[INFO] [stderr]     |                   ^^^ help: use `..=` for an inclusive range
[INFO] [stderr] 
[INFO] [stderr] warning: `...` range patterns are deprecated
[INFO] [stderr]    --> src/mappers.rs:300:22
[INFO] [stderr]     |
[INFO] [stderr] 300 |                     0...0x3FF => (self.mirroringtype == 1) as usize,
[INFO] [stderr]     |                      ^^^ help: use `..=` for an inclusive range
[INFO] [stderr] 
[INFO] [stderr] warning: `...` range patterns are deprecated
[INFO] [stderr]    --> src/mappers.rs:301:26
[INFO] [stderr]     |
[INFO] [stderr] 301 |                     0x400...0x7FF => (self.mirroringtype == 2 || self.mirroringtype == 1) as usize,
[INFO] [stderr]     |                          ^^^ help: use `..=` for an inclusive range
[INFO] [stderr] 
[INFO] [stderr] warning: `...` range patterns are deprecated
[INFO] [stderr]    --> src/mappers.rs:302:26
[INFO] [stderr]     |
[INFO] [stderr] 302 |                     0x800...0xBFF => (self.mirroringtype == 1 || self.mirroringtype == 3) as usize,
[INFO] [stderr]     |                          ^^^ help: use `..=` for an inclusive range
[INFO] [stderr] 
[INFO] [stderr] warning: `...` range patterns are deprecated
[INFO] [stderr]    --> src/mappers.rs:303:26
[INFO] [stderr]     |
[INFO] [stderr] 303 |                     0xC00...0xFFF => (self.mirroringtype != 0) as usize,
[INFO] [stderr]     |                          ^^^ help: use `..=` for an inclusive range
[INFO] [stderr] 
[INFO] [stderr] warning: type `MMC3_Serial` should have an upper camel case name
[INFO] [stderr]    --> src/mappers.rs:339:8
[INFO] [stderr]     |
[INFO] [stderr] 339 | struct MMC3_Serial {
[INFO] [stderr]     |        ^^^^^^^^^^^ help: convert the identifier to upper camel case: `Mmc3Serial`
[INFO] [stderr] 
[INFO] [stderr] warning: `...` range patterns are deprecated
[INFO] [stderr]    --> src/mappers.rs:415:19
[INFO] [stderr]     |
[INFO] [stderr] 415 |             0x6000...0x7FFF => self.prgram[location - 0x6000],
[INFO] [stderr]     |                   ^^^ help: use `..=` for an inclusive range
[INFO] [stderr] 
[INFO] [stderr] warning: `...` range patterns are deprecated
[INFO] [stderr]    --> src/mappers.rs:416:19
[INFO] [stderr]     |
[INFO] [stderr] 416 |             0x8000...0x9FFF => {
[INFO] [stderr]     |                   ^^^ help: use `..=` for an inclusive range
[INFO] [stderr] 
[INFO] [stderr] warning: `...` range patterns are deprecated
[INFO] [stderr]    --> src/mappers.rs:423:19
[INFO] [stderr]     |
[INFO] [stderr] 423 |             0xA000...0xBFFF => self.ines.prgrom[0x2000*self.prgbank1 + location - 0xA000],
[INFO] [stderr]     |                   ^^^ help: use `..=` for an inclusive range
[INFO] [stderr] 
[INFO] [stderr] warning: `...` range patterns are deprecated
[INFO] [stderr]    --> src/mappers.rs:424:19
[INFO] [stderr]     |
[INFO] [stderr] 424 |             0xC000...0xDFFF => {
[INFO] [stderr]     |                   ^^^ help: use `..=` for an inclusive range
[INFO] [stderr] 
[INFO] [stderr] warning: `...` range patterns are deprecated
[INFO] [stderr]    --> src/mappers.rs:431:19
[INFO] [stderr]     |
[INFO] [stderr] 431 |             0xE000...0xFFFF => self.ines.prgrom[0x2000*(prgrom_size - 1) + location - 0xE000],
[INFO] [stderr]     |                   ^^^ help: use `..=` for an inclusive range
[INFO] [stderr] 
[INFO] [stderr] warning: `...` range patterns are deprecated
[INFO] [stderr]    --> src/mappers.rs:437:19
[INFO] [stderr]     |
[INFO] [stderr] 437 |             0x6000...0x7FFF => self.prgram[location as usize - 0x6000] = what,
[INFO] [stderr]     |                   ^^^ help: use `..=` for an inclusive range
[INFO] [stderr] 
[INFO] [stderr] warning: `...` range patterns are deprecated
[INFO] [stderr]    --> src/mappers.rs:438:19
[INFO] [stderr]     |
[INFO] [stderr] 438 |             0x8000...0x9FFF => {
[INFO] [stderr]     |                   ^^^ help: use `..=` for an inclusive range
[INFO] [stderr] 
[INFO] [stderr] warning: `...` range patterns are deprecated
[INFO] [stderr]    --> src/mappers.rs:458:19
[INFO] [stderr]     |
[INFO] [stderr] 458 |             0xA000...0xBFFF => {
[INFO] [stderr]     |                   ^^^ help: use `..=` for an inclusive range
[INFO] [stderr] 
[INFO] [stderr] warning: `...` range patterns are deprecated
[INFO] [stderr]    --> src/mappers.rs:465:19
[INFO] [stderr]     |
[INFO] [stderr] 465 |             0xC000...0xDFFF => {
[INFO] [stderr]     |                   ^^^ help: use `..=` for an inclusive range
[INFO] [stderr] 
[INFO] [stderr] warning: `...` range patterns are deprecated
[INFO] [stderr]    --> src/mappers.rs:472:19
[INFO] [stderr]     |
[INFO] [stderr] 472 |             0xE000...0xEFFF => {
[INFO] [stderr]     |                   ^^^ help: use `..=` for an inclusive range
[INFO] [stderr] 
[INFO] [stderr] warning: `...` range patterns are deprecated
[INFO] [stderr]    --> src/mappers.rs:488:16
[INFO] [stderr]     |
[INFO] [stderr] 488 |             0x0...0x7FF => self.ines.chrrom[0x800*self.chrbank0 + location],
[INFO] [stderr]     |                ^^^ help: use `..=` for an inclusive range
[INFO] [stderr] 
[INFO] [stderr] warning: `...` range patterns are deprecated
[INFO] [stderr]    --> src/mappers.rs:489:18
[INFO] [stderr]     |
[INFO] [stderr] 489 |             0x800...0xFFF => self.ines.chrrom[0x800*self.chrbank1 + location - 0x800],
[INFO] [stderr]     |                  ^^^ help: use `..=` for an inclusive range
[INFO] [stderr] 
[INFO] [stderr] warning: `...` range patterns are deprecated
[INFO] [stderr]    --> src/mappers.rs:490:19
[INFO] [stderr]     |
[INFO] [stderr] 490 |             0x1000...0x13FF => self.ines.chrrom[0x400*self.chrbank2 + location - 0x1000],
[INFO] [stderr]     |                   ^^^ help: use `..=` for an inclusive range
[INFO] [stderr] 
[INFO] [stderr] warning: `...` range patterns are deprecated
[INFO] [stderr]    --> src/mappers.rs:491:19
[INFO] [stderr]     |
[INFO] [stderr] 491 |             0x1400...0x17FF => self.ines.chrrom[0x400*self.chrbank3 + location - 0x1400],
[INFO] [stderr]     |                   ^^^ help: use `..=` for an inclusive range
[INFO] [stderr] 
[INFO] [stderr] warning: `...` range patterns are deprecated
[INFO] [stderr]    --> src/mappers.rs:492:19
[INFO] [stderr]     |
[INFO] [stderr] 492 |             0x1800...0x1BFF => self.ines.chrrom[0x400*self.chrbank4 + location - 0x1800],
[INFO] [stderr]     |                   ^^^ help: use `..=` for an inclusive range
[INFO] [stderr] 
[INFO] [stderr] warning: `...` range patterns are deprecated
[INFO] [stderr]    --> src/mappers.rs:493:19
[INFO] [stderr]     |
[INFO] [stderr] 493 |             0x1C00...0x1FFF => self.ines.chrrom[0x400*self.chrbank5 + location - 0x1C00],
[INFO] [stderr]     |                   ^^^ help: use `..=` for an inclusive range
[INFO] [stderr] 
[INFO] [stderr] warning: `...` range patterns are deprecated
[INFO] [stderr]    --> src/mappers.rs:494:19
[INFO] [stderr]     |
[INFO] [stderr] 494 |             0x2000...0x3EFF => {
[INFO] [stderr]     |                   ^^^ help: use `..=` for an inclusive range
[INFO] [stderr] 
[INFO] [stderr] warning: `...` range patterns are deprecated
[INFO] [stderr]    --> src/mappers.rs:497:22
[INFO] [stderr]     |
[INFO] [stderr] 497 |                     0...0x3FF => 0,
[INFO] [stderr]     |                      ^^^ help: use `..=` for an inclusive range
[INFO] [stderr] 
[INFO] [stderr] warning: `...` range patterns are deprecated
[INFO] [stderr]    --> src/mappers.rs:498:26
[INFO] [stderr]     |
[INFO] [stderr] 498 |                     0x400...0x7FF => (!self.horizontalmirroring) as usize,
[INFO] [stderr]     |                          ^^^ help: use `..=` for an inclusive range
[INFO] [stderr] 
[INFO] [stderr] warning: `...` range patterns are deprecated
[INFO] [stderr]    --> src/mappers.rs:499:26
[INFO] [stderr]     |
[INFO] [stderr] 499 |                     0x800...0xBFF => self.horizontalmirroring as usize,
[INFO] [stderr]     |                          ^^^ help: use `..=` for an inclusive range
[INFO] [stderr] 
[INFO] [stderr] warning: `...` range patterns are deprecated
[INFO] [stderr]    --> src/mappers.rs:500:26
[INFO] [stderr]     |
[INFO] [stderr] 500 |                     0xC00...0xFFF => 1,
[INFO] [stderr]     |                          ^^^ help: use `..=` for an inclusive range
[INFO] [stderr] 
[INFO] [stderr] warning: `...` range patterns are deprecated
[INFO] [stderr]    --> src/mappers.rs:512:16
[INFO] [stderr]     |
[INFO] [stderr] 512 |             0x0...0x7FF => self.ines.chrrom[0x800*self.chrbank0 + location] = what,
[INFO] [stderr]     |                ^^^ help: use `..=` for an inclusive range
[INFO] [stderr] 
[INFO] [stderr] warning: `...` range patterns are deprecated
[INFO] [stderr]    --> src/mappers.rs:513:18
[INFO] [stderr]     |
[INFO] [stderr] 513 |             0x800...0xFFF => self.ines.chrrom[0x800*self.chrbank1 + location - 0x800] = what,
[INFO] [stderr]     |                  ^^^ help: use `..=` for an inclusive range
[INFO] [stderr] 
[INFO] [stderr] warning: `...` range patterns are deprecated
[INFO] [stderr]    --> src/mappers.rs:514:19
[INFO] [stderr]     |
[INFO] [stderr] 514 |             0x1000...0x13FF => self.ines.chrrom[0x400*self.chrbank2 + location - 0x1000] = what,
[INFO] [stderr]     |                   ^^^ help: use `..=` for an inclusive range
[INFO] [stderr] 
[INFO] [stderr] warning: `...` range patterns are deprecated
[INFO] [stderr]    --> src/mappers.rs:515:19
[INFO] [stderr]     |
[INFO] [stderr] 515 |             0x1400...0x17FF => self.ines.chrrom[0x400*self.chrbank3 + location - 0x1400] = what,
[INFO] [stderr]     |                   ^^^ help: use `..=` for an inclusive range
[INFO] [stderr] 
[INFO] [stderr] warning: `...` range patterns are deprecated
[INFO] [stderr]    --> src/mappers.rs:516:19
[INFO] [stderr]     |
[INFO] [stderr] 516 |             0x1800...0x1BFF => self.ines.chrrom[0x400*self.chrbank4 + location - 0x1800] = what,
[INFO] [stderr]     |                   ^^^ help: use `..=` for an inclusive range
[INFO] [stderr] 
[INFO] [stderr] warning: `...` range patterns are deprecated
[INFO] [stderr]    --> src/mappers.rs:517:19
[INFO] [stderr]     |
[INFO] [stderr] 517 |             0x1C00...0x1FFF => self.ines.chrrom[0x400*self.chrbank5 + location - 0x1C00] = what,
[INFO] [stderr]     |                   ^^^ help: use `..=` for an inclusive range
[INFO] [stderr] 
[INFO] [stderr] warning: `...` range patterns are deprecated
[INFO] [stderr]    --> src/mappers.rs:518:19
[INFO] [stderr]     |
[INFO] [stderr] 518 |             0x2000...0x3EFF => {
[INFO] [stderr]     |                   ^^^ help: use `..=` for an inclusive range
[INFO] [stderr] 
[INFO] [stderr] warning: `...` range patterns are deprecated
[INFO] [stderr]    --> src/mappers.rs:521:22
[INFO] [stderr]     |
[INFO] [stderr] 521 |                     0...0x3FF => 0,
[INFO] [stderr]     |                      ^^^ help: use `..=` for an inclusive range
[INFO] [stderr] 
[INFO] [stderr] warning: `...` range patterns are deprecated
[INFO] [stderr]    --> src/mappers.rs:522:26
[INFO] [stderr]     |
[INFO] [stderr] 522 |                     0x400...0x7FF => (!self.horizontalmirroring) as usize,
[INFO] [stderr]     |                          ^^^ help: use `..=` for an inclusive range
[INFO] [stderr] 
[INFO] [stderr] warning: `...` range patterns are deprecated
[INFO] [stderr]    --> src/mappers.rs:523:26
[INFO] [stderr]     |
[INFO] [stderr] 523 |                     0x800...0xBFF => self.horizontalmirroring as usize,
[INFO] [stderr]     |                          ^^^ help: use `..=` for an inclusive range
[INFO] [stderr] 
[INFO] [stderr] warning: `...` range patterns are deprecated
[INFO] [stderr]    --> src/mappers.rs:524:26
[INFO] [stderr]     |
[INFO] [stderr] 524 |                     0xC00...0xFFF => 1,
[INFO] [stderr]     |                          ^^^ help: use `..=` for an inclusive range
[INFO] [stderr] 
[INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated
[INFO] [stderr]    --> src/mappers.rs:553:48
[INFO] [stderr]     |
[INFO] [stderr] 553 | pub fn get_mapper(mut ines:INES) -> Rc<RefCell<Mapper>> {
[INFO] [stderr]     |                                                ^^^^^^ help: use `dyn`: `dyn Mapper`
[INFO] [stderr] 
[INFO] [stderr] warning: unused import: `sdl2::audio::*`
[INFO] [stderr]   --> src/nes.rs:31:5
[INFO] [stderr]    |
[INFO] [stderr] 31 | use sdl2::audio::*;
[INFO] [stderr]    |     ^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: `#[warn(unused_imports)]` on by default
[INFO] [stderr] 
[INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated
[INFO] [stderr]   --> src/nes.rs:38:24
[INFO] [stderr]    |
[INFO] [stderr] 38 |     mapper: Rc<RefCell<Mapper>>,
[INFO] [stderr]    |                        ^^^^^^ help: use `dyn`: `dyn Mapper`
[INFO] [stderr] 
[INFO] [stderr] warning: type `NES_State` should have an upper camel case name
[INFO] [stderr]   --> src/nes.rs:47:8
[INFO] [stderr]    |
[INFO] [stderr] 47 | struct NES_State {
[INFO] [stderr]    |        ^^^^^^^^^ help: convert the identifier to upper camel case: `NesState`
[INFO] [stderr] 
[INFO] [stderr]    |
[INFO] [stderr]    = note: `#[warn(bare_trait_objects)]` on by default
[INFO] [stderr] 
[INFO] [stderr] warning: type `CPU_Serial` should have an upper camel case name
[INFO] [stderr]   --> src/cpu.rs:75:8
[INFO] [stderr]    |
[INFO] [stderr] 75 | struct CPU_Serial { //no refcells
[INFO] [stderr]    |        ^^^^^^^^^^ help: convert the identifier to upper camel case: `CpuSerial`
[INFO] [stderr]    |
[INFO] [stderr]    = note: `#[warn(non_camel_case_types)]` on by default
[INFO] [stderr] 
[INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated
[INFO] [stderr]    --> src/cpu.rs:137:35
[INFO] [stderr]     |
[INFO] [stderr] 137 |     pub fn new(mapper: Rc<RefCell<Mapper>>, ppu: Rc<RefCell<PPU>>) -> CPU {
[INFO] [stderr]     |                                   ^^^^^^ help: use `dyn`: `dyn Mapper`
[INFO] [stderr] 
[INFO] [stderr] warning: `...` range patterns are deprecated
[INFO] [stderr]    --> src/cpu.rs:184:14
[INFO] [stderr]     |
[INFO] [stderr] 184 |             0...0x1FFF => self.ram[location as usize& 0x7FF],
[INFO] [stderr]     |              ^^^ help: use `..=` for an inclusive range
[INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated
[INFO] [stderr]    --> src/nes.rs:231:54
[INFO] [stderr]     |
[INFO] [stderr] 231 | fn serialize_nes(cpu:&CPU,ppu:&PPU,mapper:Rc<RefCell<Mapper>>) -> Vec<u8> {
[INFO] [stderr]     |                                                      ^^^^^^ help: use `dyn`: `dyn Mapper`
[INFO] [stderr] 
[INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated
[INFO] [stderr]    --> src/nes.rs:241:75
[INFO] [stderr]     |
[INFO] [stderr] 241 | fn deserialize_nes(data:&[u8],cpu:&mut CPU,ppu:&mut PPU,mapper:Rc<RefCell<Mapper>>) {
[INFO] [stderr]     |                                                                           ^^^^^^ help: use `dyn`: `dyn Mapper`
[INFO] [stderr] 
[INFO] [stderr]     |
[INFO] [stderr]     = note: `#[warn(ellipsis_inclusive_range_patterns)]` on by default
[INFO] [stderr] 
[INFO] [stderr] warning: `...` range patterns are deprecated
[INFO] [stderr]    --> src/cpu.rs:193:19
[INFO] [stderr]     |
[INFO] [stderr] 193 |             0x2008...0x3FFF => self.contents(location & 0x2007),
[INFO] [stderr]     |                   ^^^ help: use `..=` for an inclusive range
[INFO] [stderr] 
[INFO] [stderr] warning: `...` range patterns are deprecated
[INFO] [stderr]    --> src/cpu.rs:194:19
[INFO] [stderr]     |
[INFO] [stderr] 194 |             0x4000...0x4014 => 0,
[INFO] [stderr]     |                   ^^^ help: use `..=` for an inclusive range
[INFO] [stderr] 
[INFO] [stderr] warning: `...` range patterns are deprecated
[INFO] [stderr]    --> src/cpu.rs:216:19
[INFO] [stderr]     |
[INFO] [stderr] 216 |             0x4016...0x401F => 0,
[INFO] [stderr]     |                   ^^^ help: use `..=` for an inclusive range
[INFO] [stderr] 
[INFO] [stderr] warning: `...` range patterns are deprecated
[INFO] [stderr]    --> src/cpu.rs:217:19
[INFO] [stderr]     |
[INFO] [stderr] 217 |             0x4020...0xFFFF => self.mapper.borrow_mut().contents(location),
[INFO] [stderr]     |                   ^^^ help: use `..=` for an inclusive range
[INFO] [stderr] 
[INFO] [stderr] warning: `...` range patterns are deprecated
[INFO] [stderr]    --> src/cpu.rs:223:14
[INFO] [stderr]     |
[INFO] [stderr] 223 |             0...0x1FFF => self.ram[location as usize & 0x7FF] = value,
[INFO] [stderr]     |              ^^^ help: use `..=` for an inclusive range
[INFO] [stderr] 
[INFO] [stderr] warning: `...` range patterns are deprecated
[INFO] [stderr]    --> src/cpu.rs:232:19
[INFO] [stderr]     |
[INFO] [stderr] 232 |             0x2008...0x3FFF => self.set_contents(location & 0x2007,value),
[INFO] [stderr]     |                   ^^^ help: use `..=` for an inclusive range
[INFO] [stderr] 
[INFO] [stderr] warning: `...` range patterns are deprecated
[INFO] [stderr]    --> src/cpu.rs:233:19
[INFO] [stderr]     |
[INFO] [stderr] 233 |             0x4000...0x4013 => apu_write(self.elapsed+self.cycles_delay as i32,location,value),
[INFO] [stderr]     |                   ^^^ help: use `..=` for an inclusive range
[INFO] [stderr] 
[INFO] [stderr] warning: `...` range patterns are deprecated
[INFO] [stderr]    --> src/cpu.rs:247:19
[INFO] [stderr]     |
[INFO] [stderr] 247 |             0x4018...0x401F => (),
[INFO] [stderr]     |                   ^^^ help: use `..=` for an inclusive range
[INFO] [stderr] 
[INFO] [stderr] warning: `...` range patterns are deprecated
[INFO] [stderr]    --> src/cpu.rs:248:19
[INFO] [stderr]     |
[INFO] [stderr] 248 |             0x4020...0xFFFF => self.mapper.borrow_mut().set_contents(location,value),
[INFO] [stderr]     |                   ^^^ help: use `..=` for an inclusive range
[INFO] [stderr] 
[INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated
[INFO] [stderr]   --> src/ppu.rs:26:24
[INFO] [stderr]    |
[INFO] [stderr] 26 |     mapper: Rc<RefCell<Mapper>>,
[INFO] [stderr]    |                        ^^^^^^ help: use `dyn`: `dyn Mapper`
[INFO] [stderr] 
[INFO] [stderr] warning: type `PPU_Serial` should have an upper camel case name
[INFO] [stderr]   --> src/ppu.rs:92:12
[INFO] [stderr]    |
[INFO] [stderr] 92 | pub struct PPU_Serial { //PPU w/o one reference.... kms
[INFO] [stderr]    |            ^^^^^^^^^^ help: convert the identifier to upper camel case: `PpuSerial`
[INFO] [stderr] 
[INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated
[INFO] [stderr]    --> src/ppu.rs:242:34
[INFO] [stderr]     |
[INFO] [stderr] 242 |     pub fn new(mapper:Rc<RefCell<Mapper>>) -> PPU {
[INFO] [stderr]     |                                  ^^^^^^ help: use `dyn`: `dyn Mapper`
[INFO] [stderr] 
[INFO] [stderr] warning: `...` range patterns are deprecated
[INFO] [stderr]    --> src/ppu.rs:373:20
[INFO] [stderr]     |
[INFO] [stderr] 373 |             0x3F00 ... 0x3FFF => {
[INFO] [stderr]     |                    ^^^ help: use `..=` for an inclusive range
[INFO] [stderr] 
[INFO] [stderr] warning: `...` range patterns are deprecated
[INFO] [stderr]    --> src/ppu.rs:392:20
[INFO] [stderr]     |
[INFO] [stderr] 392 |             0x3F00 ... 0x3FFF => {
[INFO] [stderr]     |                    ^^^ help: use `..=` for an inclusive range
[INFO] [stderr] 
[INFO] [stderr] warning: type `NROM_Serial` should have an upper camel case name
[INFO] [stderr]   --> src/mappers.rs:29:8
[INFO] [stderr]    |
[INFO] [stderr] 29 | struct NROM_Serial {
[INFO] [stderr]    |        ^^^^^^^^^^^ help: convert the identifier to upper camel case: `NromSerial`
[INFO] [stderr] 
[INFO] [stderr] warning: `...` range patterns are deprecated
[INFO] [stderr]   --> src/mappers.rs:52:19
[INFO] [stderr]    |
[INFO] [stderr] 52 |             0x6000...0x7FFF => self.prgram[location - 0x6000],
[INFO] [stderr]    |                   ^^^ help: use `..=` for an inclusive range
[INFO] [stderr] 
[INFO] [stderr] warning: `...` range patterns are deprecated
[INFO] [stderr]   --> src/mappers.rs:53:19
[INFO] [stderr]    |
[INFO] [stderr] 53 |             0x8000...0xFFFF => {
[INFO] [stderr]    |                   ^^^ help: use `..=` for an inclusive range
[INFO] [stderr] 
[INFO] [stderr] warning: `...` range patterns are deprecated
[INFO] [stderr]   --> src/mappers.rs:62:19
[INFO] [stderr]    |
[INFO] [stderr] 62 |             0x6000...0x7FFF => self.prgram[location as usize - 0x6000] = what,
[INFO] [stderr]    |                   ^^^ help: use `..=` for an inclusive range
[INFO] [stderr] 
[INFO] [stderr] warning: `...` range patterns are deprecated
[INFO] [stderr]   --> src/mappers.rs:69:14
[INFO] [stderr]    |
[INFO] [stderr] 69 |             0...0x1FFF => self.ines.chrrom[location],
[INFO] [stderr]    |              ^^^ help: use `..=` for an inclusive range
[INFO] [stderr] 
[INFO] [stderr] warning: `...` range patterns are deprecated
[INFO] [stderr]   --> src/mappers.rs:70:19
[INFO] [stderr]    |
[INFO] [stderr] 70 |             0x2000...0x3EFF => {
[INFO] [stderr]    |                   ^^^ help: use `..=` for an inclusive range
[INFO] [stderr] 
[INFO] [stderr] warning: `...` range patterns are deprecated
[INFO] [stderr]   --> src/mappers.rs:73:22
[INFO] [stderr]    |
[INFO] [stderr] 73 |                     0...0x3FF => 0,
[INFO] [stderr]    |                      ^^^ help: use `..=` for an inclusive range
[INFO] [stderr] 
[INFO] [stderr] warning: `...` range patterns are deprecated
[INFO] [stderr]   --> src/mappers.rs:74:26
[INFO] [stderr]    |
[INFO] [stderr] 74 |                     0x400...0x7FF => (self.ines.vertical_mirroring) as usize,
[INFO] [stderr]    |                          ^^^ help: use `..=` for an inclusive range
[INFO] [stderr] 
[INFO] [stderr] warning: `...` range patterns are deprecated
[INFO] [stderr]   --> src/mappers.rs:75:26
[INFO] [stderr]    |
[INFO] [stderr] 75 |                     0x800...0xBFF => (!self.ines.vertical_mirroring) as usize,
[INFO] [stderr]    |                          ^^^ help: use `..=` for an inclusive range
[INFO] [stderr] 
[INFO] [stderr] warning: `...` range patterns are deprecated
[INFO] [stderr]   --> src/mappers.rs:76:26
[INFO] [stderr]    |
[INFO] [stderr] 76 |                     0xC00...0xFFF => 1,
[INFO] [stderr]    |                          ^^^ help: use `..=` for an inclusive range
[INFO] [stderr] 
[INFO] [stderr] warning: `...` range patterns are deprecated
[INFO] [stderr]   --> src/mappers.rs:88:14
[INFO] [stderr]    |
[INFO] [stderr] 88 |             0...0x1FFF => {
[INFO] [stderr]    |              ^^^ help: use `..=` for an inclusive range
[INFO] [stderr] 
[INFO] [stderr] warning: `...` range patterns are deprecated
[INFO] [stderr]   --> src/mappers.rs:91:19
[INFO] [stderr]    |
[INFO] [stderr] 91 |             0x2000...0x3EFF => {
[INFO] [stderr]    |                   ^^^ help: use `..=` for an inclusive range
[INFO] [stderr] 
[INFO] [stderr] warning: `...` range patterns are deprecated
[INFO] [stderr]   --> src/mappers.rs:94:22
[INFO] [stderr]    |
[INFO] [stderr] 94 |                     0...0x3FF => 0,
[INFO] [stderr]    |                      ^^^ help: use `..=` for an inclusive range
[INFO] [stderr] 
[INFO] [stderr] warning: `...` range patterns are deprecated
[INFO] [stderr]   --> src/mappers.rs:95:26
[INFO] [stderr]    |
[INFO] [stderr] 95 |                     0x400...0x7FF => (self.ines.vertical_mirroring) as usize,
[INFO] [stderr]    |                          ^^^ help: use `..=` for an inclusive range
[INFO] [stderr] 
[INFO] [stderr] warning: `...` range patterns are deprecated
[INFO] [stderr]   --> src/mappers.rs:96:26
[INFO] [stderr]    |
[INFO] [stderr] 96 |                     0x800...0xBFF => (!self.ines.vertical_mirroring) as usize,
[INFO] [stderr]    |                          ^^^ help: use `..=` for an inclusive range
[INFO] [stderr] 
[INFO] [stderr] warning: `...` range patterns are deprecated
[INFO] [stderr]   --> src/mappers.rs:97:26
[INFO] [stderr]    |
[INFO] [stderr] 97 |                     0xC00...0xFFF => 1,
[INFO] [stderr]    |                          ^^^ help: use `..=` for an inclusive range
[INFO] [stderr] 
[INFO] [stderr] warning: type `MMC1_Serial` should have an upper camel case name
[INFO] [stderr]    --> src/mappers.rs:128:8
[INFO] [stderr]     |
[INFO] [stderr] 128 | struct MMC1_Serial {
[INFO] [stderr]     |        ^^^^^^^^^^^ help: convert the identifier to upper camel case: `Mmc1Serial`
[INFO] [stderr] 
[INFO] [stderr] warning: `...` range patterns are deprecated
[INFO] [stderr]    --> src/mappers.rs:179:19
[INFO] [stderr]     |
[INFO] [stderr] 179 |             0x6000...0x7FFF =>
[INFO] [stderr]     |                   ^^^ help: use `..=` for an inclusive range
[INFO] [stderr] 
[INFO] [stderr] warning: `...` range patterns are deprecated
[INFO] [stderr]    --> src/mappers.rs:181:19
[INFO] [stderr]     |
[INFO] [stderr] 181 |             0x8000...0xFFFF => {
[INFO] [stderr]     |                   ^^^ help: use `..=` for an inclusive range
[INFO] [stderr] 
[INFO] [stderr] warning: `...` range patterns are deprecated
[INFO] [stderr]    --> src/mappers.rs:184:22
[INFO] [stderr]     |
[INFO] [stderr] 184 |                     0...1 => { //choose 32 kb bank
[INFO] [stderr]     |                      ^^^ help: use `..=` for an inclusive range
[INFO] [stderr] 
[INFO] [stderr] warning: `...` range patterns are deprecated
[INFO] [stderr]    --> src/mappers.rs:209:19
[INFO] [stderr]     |
[INFO] [stderr] 209 |             0x6000...0x7FFF => {
[INFO] [stderr]     |                   ^^^ help: use `..=` for an inclusive range
[INFO] [stderr] 
[INFO] [stderr] warning: `...` range patterns are deprecated
[INFO] [stderr]    --> src/mappers.rs:212:19
[INFO] [stderr]     |
[INFO] [stderr] 212 |             0x8000...0xFFFF => {
[INFO] [stderr]     |                   ^^^ help: use `..=` for an inclusive range
[INFO] [stderr] 
[INFO] [stderr] warning: `...` range patterns are deprecated
[INFO] [stderr]    --> src/mappers.rs:222:35
[INFO] [stderr]     |
[INFO] [stderr] 222 |                             0x8000...0x9FFF => {
[INFO] [stderr]     |                                   ^^^ help: use `..=` for an inclusive range
[INFO] [stderr] 
[INFO] [stderr] warning: `...` range patterns are deprecated
[INFO] [stderr]    --> src/mappers.rs:227:35
[INFO] [stderr]     |
[INFO] [stderr] 227 |                             0xA000...0xBFFF => {
[INFO] [stderr]     |                                   ^^^ help: use `..=` for an inclusive range
[INFO] [stderr] 
[INFO] [stderr] warning: `...` range patterns are deprecated
[INFO] [stderr]    --> src/mappers.rs:230:35
[INFO] [stderr]     |
[INFO] [stderr] 230 |                             0xC000...0xDFFF => {
[INFO] [stderr]     |                                   ^^^ help: use `..=` for an inclusive range
[INFO] [stderr] 
[INFO] [stderr] warning: `...` range patterns are deprecated
[INFO] [stderr]    --> src/mappers.rs:233:35
[INFO] [stderr]     |
[INFO] [stderr] 233 |                             0xE000...0xFFFF => {
[INFO] [stderr]     |                                   ^^^ help: use `..=` for an inclusive range
[INFO] [stderr] 
[INFO] [stderr] warning: `...` range patterns are deprecated
[INFO] [stderr]    --> src/mappers.rs:249:14
[INFO] [stderr]     |
[INFO] [stderr] 249 |             0...0x1FFF => {
[INFO] [stderr]     |              ^^^ help: use `..=` for an inclusive range
[INFO] [stderr] 
[INFO] [stderr] warning: `...` range patterns are deprecated
[INFO] [stderr]    --> src/mappers.rs:264:19
[INFO] [stderr]     |
[INFO] [stderr] 264 |             0x2000...0x3EFF => {
[INFO] [stderr]     |                   ^^^ help: use `..=` for an inclusive range
[INFO] [stderr] 
[INFO] [stderr] warning: `...` range patterns are deprecated
[INFO] [stderr]    --> src/mappers.rs:267:22
[INFO] [stderr]     |
[INFO] [stderr] 267 |                     0...0x3FF => (self.mirroringtype == 1) as usize,
[INFO] [stderr]     |                      ^^^ help: use `..=` for an inclusive range
[INFO] [stderr] 
[INFO] [stderr] warning: `...` range patterns are deprecated
[INFO] [stderr]    --> src/mappers.rs:268:26
[INFO] [stderr]     |
[INFO] [stderr] 268 |                     0x400...0x7FF => (self.mirroringtype == 2 || self.mirroringtype == 1) as usize,
[INFO] [stderr]     |                          ^^^ help: use `..=` for an inclusive range
[INFO] [stderr] 
[INFO] [stderr] warning: `...` range patterns are deprecated
[INFO] [stderr]    --> src/mappers.rs:269:26
[INFO] [stderr]     |
[INFO] [stderr] 269 |                     0x800...0xBFF => (self.mirroringtype == 1 || self.mirroringtype == 3) as usize,
[INFO] [stderr]     |                          ^^^ help: use `..=` for an inclusive range
[INFO] [stderr] 
[INFO] [stderr] warning: `...` range patterns are deprecated
[INFO] [stderr]    --> src/mappers.rs:270:26
[INFO] [stderr]     |
[INFO] [stderr] 270 |                     0xC00...0xFFF => (self.mirroringtype != 0) as usize,
[INFO] [stderr]     |                          ^^^ help: use `..=` for an inclusive range
[INFO] [stderr] 
[INFO] [stderr] warning: `...` range patterns are deprecated
[INFO] [stderr]    --> src/mappers.rs:282:14
[INFO] [stderr]     |
[INFO] [stderr] 282 |             0...0x1FFF if self.ines.chrrom_size == 0 => {
[INFO] [stderr]     |              ^^^ help: use `..=` for an inclusive range
[INFO] [stderr] 
[INFO] [stderr] warning: `...` range patterns are deprecated
[INFO] [stderr]    --> src/mappers.rs:297:19
[INFO] [stderr]     |
[INFO] [stderr] 297 |             0x2000...0x3EFF => {
[INFO] [stderr]     |                   ^^^ help: use `..=` for an inclusive range
[INFO] [stderr] 
[INFO] [stderr] warning: `...` range patterns are deprecated
[INFO] [stderr]    --> src/mappers.rs:300:22
[INFO] [stderr]     |
[INFO] [stderr] 300 |                     0...0x3FF => (self.mirroringtype == 1) as usize,
[INFO] [stderr]     |                      ^^^ help: use `..=` for an inclusive range
[INFO] [stderr] 
[INFO] [stderr] warning: `...` range patterns are deprecated
[INFO] [stderr]    --> src/mappers.rs:301:26
[INFO] [stderr]     |
[INFO] [stderr] 301 |                     0x400...0x7FF => (self.mirroringtype == 2 || self.mirroringtype == 1) as usize,
[INFO] [stderr]     |                          ^^^ help: use `..=` for an inclusive range
[INFO] [stderr] 
[INFO] [stderr] warning: `...` range patterns are deprecated
[INFO] [stderr]    --> src/mappers.rs:302:26
[INFO] [stderr]     |
[INFO] [stderr] 302 |                     0x800...0xBFF => (self.mirroringtype == 1 || self.mirroringtype == 3) as usize,
[INFO] [stderr]     |                          ^^^ help: use `..=` for an inclusive range
[INFO] [stderr] 
[INFO] [stderr] warning: `...` range patterns are deprecated
[INFO] [stderr]    --> src/mappers.rs:303:26
[INFO] [stderr]     |
[INFO] [stderr] 303 |                     0xC00...0xFFF => (self.mirroringtype != 0) as usize,
[INFO] [stderr]     |                          ^^^ help: use `..=` for an inclusive range
[INFO] [stderr] 
[INFO] [stderr] warning: type `MMC3_Serial` should have an upper camel case name
[INFO] [stderr]    --> src/mappers.rs:339:8
[INFO] [stderr]     |
[INFO] [stderr] 339 | struct MMC3_Serial {
[INFO] [stderr]     |        ^^^^^^^^^^^ help: convert the identifier to upper camel case: `Mmc3Serial`
[INFO] [stderr] 
[INFO] [stderr] warning: `...` range patterns are deprecated
[INFO] [stderr]    --> src/mappers.rs:415:19
[INFO] [stderr]     |
[INFO] [stderr] 415 |             0x6000...0x7FFF => self.prgram[location - 0x6000],
[INFO] [stderr]     |                   ^^^ help: use `..=` for an inclusive range
[INFO] [stderr] 
[INFO] [stderr] warning: `...` range patterns are deprecated
[INFO] [stderr]    --> src/mappers.rs:416:19
[INFO] [stderr]     |
[INFO] [stderr] 416 |             0x8000...0x9FFF => {
[INFO] [stderr]     |                   ^^^ help: use `..=` for an inclusive range
[INFO] [stderr] 
[INFO] [stderr] warning: `...` range patterns are deprecated
[INFO] [stderr]    --> src/mappers.rs:423:19
[INFO] [stderr]     |
[INFO] [stderr] 423 |             0xA000...0xBFFF => self.ines.prgrom[0x2000*self.prgbank1 + location - 0xA000],
[INFO] [stderr]     |                   ^^^ help: use `..=` for an inclusive range
[INFO] [stderr] 
[INFO] [stderr] warning: `...` range patterns are deprecated
[INFO] [stderr]    --> src/mappers.rs:424:19
[INFO] [stderr]     |
[INFO] [stderr] 424 |             0xC000...0xDFFF => {
[INFO] [stderr]     |                   ^^^ help: use `..=` for an inclusive range
[INFO] [stderr] 
[INFO] [stderr] warning: `...` range patterns are deprecated
[INFO] [stderr]    --> src/mappers.rs:431:19
[INFO] [stderr]     |
[INFO] [stderr] 431 |             0xE000...0xFFFF => self.ines.prgrom[0x2000*(prgrom_size - 1) + location - 0xE000],
[INFO] [stderr]     |                   ^^^ help: use `..=` for an inclusive range
[INFO] [stderr] 
[INFO] [stderr] warning: `...` range patterns are deprecated
[INFO] [stderr]    --> src/mappers.rs:437:19
[INFO] [stderr]     |
[INFO] [stderr] 437 |             0x6000...0x7FFF => self.prgram[location as usize - 0x6000] = what,
[INFO] [stderr]     |                   ^^^ help: use `..=` for an inclusive range
[INFO] [stderr] 
[INFO] [stderr] warning: `...` range patterns are deprecated
[INFO] [stderr]    --> src/mappers.rs:438:19
[INFO] [stderr]     |
[INFO] [stderr] 438 |             0x8000...0x9FFF => {
[INFO] [stderr]     |                   ^^^ help: use `..=` for an inclusive range
[INFO] [stderr] 
[INFO] [stderr] warning: `...` range patterns are deprecated
[INFO] [stderr]    --> src/mappers.rs:458:19
[INFO] [stderr]     |
[INFO] [stderr] 458 |             0xA000...0xBFFF => {
[INFO] [stderr]     |                   ^^^ help: use `..=` for an inclusive range
[INFO] [stderr] 
[INFO] [stderr] warning: `...` range patterns are deprecated
[INFO] [stderr]    --> src/mappers.rs:465:19
[INFO] [stderr]     |
[INFO] [stderr] 465 |             0xC000...0xDFFF => {
[INFO] [stderr]     |                   ^^^ help: use `..=` for an inclusive range
[INFO] [stderr] 
[INFO] [stderr] warning: `...` range patterns are deprecated
[INFO] [stderr]    --> src/mappers.rs:472:19
[INFO] [stderr]     |
[INFO] [stderr] 472 |             0xE000...0xEFFF => {
[INFO] [stderr]     |                   ^^^ help: use `..=` for an inclusive range
[INFO] [stderr] 
[INFO] [stderr] warning: `...` range patterns are deprecated
[INFO] [stderr]    --> src/mappers.rs:488:16
[INFO] [stderr]     |
[INFO] [stderr] 488 |             0x0...0x7FF => self.ines.chrrom[0x800*self.chrbank0 + location],
[INFO] [stderr]     |                ^^^ help: use `..=` for an inclusive range
[INFO] [stderr] 
[INFO] [stderr] warning: `...` range patterns are deprecated
[INFO] [stderr]    --> src/mappers.rs:489:18
[INFO] [stderr]     |
[INFO] [stderr] 489 |             0x800...0xFFF => self.ines.chrrom[0x800*self.chrbank1 + location - 0x800],
[INFO] [stderr]     |                  ^^^ help: use `..=` for an inclusive range
[INFO] [stderr] 
[INFO] [stderr] warning: `...` range patterns are deprecated
[INFO] [stderr]    --> src/mappers.rs:490:19
[INFO] [stderr]     |
[INFO] [stderr] 490 |             0x1000...0x13FF => self.ines.chrrom[0x400*self.chrbank2 + location - 0x1000],
[INFO] [stderr]     |                   ^^^ help: use `..=` for an inclusive range
[INFO] [stderr] 
[INFO] [stderr] warning: `...` range patterns are deprecated
[INFO] [stderr]    --> src/mappers.rs:491:19
[INFO] [stderr]     |
[INFO] [stderr] 491 |             0x1400...0x17FF => self.ines.chrrom[0x400*self.chrbank3 + location - 0x1400],
[INFO] [stderr]     |                   ^^^ help: use `..=` for an inclusive range
[INFO] [stderr] 
[INFO] [stderr] warning: `...` range patterns are deprecated
[INFO] [stderr]    --> src/mappers.rs:492:19
[INFO] [stderr]     |
[INFO] [stderr] 492 |             0x1800...0x1BFF => self.ines.chrrom[0x400*self.chrbank4 + location - 0x1800],
[INFO] [stderr]     |                   ^^^ help: use `..=` for an inclusive range
[INFO] [stderr] 
[INFO] [stderr] warning: `...` range patterns are deprecated
[INFO] [stderr]    --> src/mappers.rs:493:19
[INFO] [stderr]     |
[INFO] [stderr] 493 |             0x1C00...0x1FFF => self.ines.chrrom[0x400*self.chrbank5 + location - 0x1C00],
[INFO] [stderr]     |                   ^^^ help: use `..=` for an inclusive range
[INFO] [stderr] 
[INFO] [stderr] warning: `...` range patterns are deprecated
[INFO] [stderr]    --> src/mappers.rs:494:19
[INFO] [stderr]     |
[INFO] [stderr] 494 |             0x2000...0x3EFF => {
[INFO] [stderr]     |                   ^^^ help: use `..=` for an inclusive range
[INFO] [stderr] 
[INFO] [stderr] warning: `...` range patterns are deprecated
[INFO] [stderr]    --> src/mappers.rs:497:22
[INFO] [stderr]     |
[INFO] [stderr] 497 |                     0...0x3FF => 0,
[INFO] [stderr]     |                      ^^^ help: use `..=` for an inclusive range
[INFO] [stderr] 
[INFO] [stderr] warning: `...` range patterns are deprecated
[INFO] [stderr]    --> src/mappers.rs:498:26
[INFO] [stderr]     |
[INFO] [stderr] 498 |                     0x400...0x7FF => (!self.horizontalmirroring) as usize,
[INFO] [stderr]     |                          ^^^ help: use `..=` for an inclusive range
[INFO] [stderr] 
[INFO] [stderr] warning: `...` range patterns are deprecated
[INFO] [stderr]    --> src/mappers.rs:499:26
[INFO] [stderr]     |
[INFO] [stderr] 499 |                     0x800...0xBFF => self.horizontalmirroring as usize,
[INFO] [stderr]     |                          ^^^ help: use `..=` for an inclusive range
[INFO] [stderr] 
[INFO] [stderr] warning: `...` range patterns are deprecated
[INFO] [stderr]    --> src/mappers.rs:500:26
[INFO] [stderr]     |
[INFO] [stderr] 500 |                     0xC00...0xFFF => 1,
[INFO] [stderr]     |                          ^^^ help: use `..=` for an inclusive range
[INFO] [stderr] 
[INFO] [stderr] warning: `...` range patterns are deprecated
[INFO] [stderr]    --> src/mappers.rs:512:16
[INFO] [stderr]     |
[INFO] [stderr] 512 |             0x0...0x7FF => self.ines.chrrom[0x800*self.chrbank0 + location] = what,
[INFO] [stderr]     |                ^^^ help: use `..=` for an inclusive range
[INFO] [stderr] 
[INFO] [stderr] warning: `...` range patterns are deprecated
[INFO] [stderr]    --> src/mappers.rs:513:18
[INFO] [stderr]     |
[INFO] [stderr] 513 |             0x800...0xFFF => self.ines.chrrom[0x800*self.chrbank1 + location - 0x800] = what,
[INFO] [stderr]     |                  ^^^ help: use `..=` for an inclusive range
[INFO] [stderr] 
[INFO] [stderr] warning: `...` range patterns are deprecated
[INFO] [stderr]    --> src/mappers.rs:514:19
[INFO] [stderr]     |
[INFO] [stderr] 514 |             0x1000...0x13FF => self.ines.chrrom[0x400*self.chrbank2 + location - 0x1000] = what,
[INFO] [stderr]     |                   ^^^ help: use `..=` for an inclusive range
[INFO] [stderr] 
[INFO] [stderr] warning: `...` range patterns are deprecated
[INFO] [stderr]    --> src/mappers.rs:515:19
[INFO] [stderr]     |
[INFO] [stderr] 515 |             0x1400...0x17FF => self.ines.chrrom[0x400*self.chrbank3 + location - 0x1400] = what,
[INFO] [stderr]     |                   ^^^ help: use `..=` for an inclusive range
[INFO] [stderr] 
[INFO] [stderr] warning: `...` range patterns are deprecated
[INFO] [stderr]    --> src/mappers.rs:516:19
[INFO] [stderr]     |
[INFO] [stderr] 516 |             0x1800...0x1BFF => self.ines.chrrom[0x400*self.chrbank4 + location - 0x1800] = what,
[INFO] [stderr]     |                   ^^^ help: use `..=` for an inclusive range
[INFO] [stderr] 
[INFO] [stderr] warning: `...` range patterns are deprecated
[INFO] [stderr]    --> src/mappers.rs:517:19
[INFO] [stderr]     |
[INFO] [stderr] 517 |             0x1C00...0x1FFF => self.ines.chrrom[0x400*self.chrbank5 + location - 0x1C00] = what,
[INFO] [stderr]     |                   ^^^ help: use `..=` for an inclusive range
[INFO] [stderr] 
[INFO] [stderr] warning: `...` range patterns are deprecated
[INFO] [stderr]    --> src/mappers.rs:518:19
[INFO] [stderr]     |
[INFO] [stderr] 518 |             0x2000...0x3EFF => {
[INFO] [stderr]     |                   ^^^ help: use `..=` for an inclusive range
[INFO] [stderr] 
[INFO] [stderr] warning: `...` range patterns are deprecated
[INFO] [stderr]    --> src/mappers.rs:521:22
[INFO] [stderr]     |
[INFO] [stderr] 521 |                     0...0x3FF => 0,
[INFO] [stderr]     |                      ^^^ help: use `..=` for an inclusive range
[INFO] [stderr] 
[INFO] [stderr] warning: `...` range patterns are deprecated
[INFO] [stderr]    --> src/mappers.rs:522:26
[INFO] [stderr]     |
[INFO] [stderr] 522 |                     0x400...0x7FF => (!self.horizontalmirroring) as usize,
[INFO] [stderr]     |                          ^^^ help: use `..=` for an inclusive range
[INFO] [stderr] 
[INFO] [stderr] warning: `...` range patterns are deprecated
[INFO] [stderr]    --> src/mappers.rs:523:26
[INFO] [stderr]     |
[INFO] [stderr] 523 |                     0x800...0xBFF => self.horizontalmirroring as usize,
[INFO] [stderr]     |                          ^^^ help: use `..=` for an inclusive range
[INFO] [stderr] 
[INFO] [stderr] warning: `...` range patterns are deprecated
[INFO] [stderr]    --> src/mappers.rs:524:26
[INFO] [stderr]     |
[INFO] [stderr] 524 |                     0xC00...0xFFF => 1,
[INFO] [stderr]     |                          ^^^ help: use `..=` for an inclusive range
[INFO] [stderr] 
[INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated
[INFO] [stderr]    --> src/mappers.rs:553:48
[INFO] [stderr]     |
[INFO] [stderr] 553 | pub fn get_mapper(mut ines:INES) -> Rc<RefCell<Mapper>> {
[INFO] [stderr]     |                                                ^^^^^^ help: use `dyn`: `dyn Mapper`
[INFO] [stderr] 
[INFO] [stderr] warning: unused import: `sdl2::audio::*`
[INFO] [stderr]   --> src/nes.rs:31:5
[INFO] [stderr]    |
[INFO] [stderr] 31 | use sdl2::audio::*;
[INFO] [stderr]    |     ^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: `#[warn(unused_imports)]` on by default
[INFO] [stderr] 
[INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated
[INFO] [stderr]   --> src/nes.rs:38:24
[INFO] [stderr]    |
[INFO] [stderr] 38 |     mapper: Rc<RefCell<Mapper>>,
[INFO] [stderr]    |                        ^^^^^^ help: use `dyn`: `dyn Mapper`
[INFO] [stderr] 
[INFO] [stderr] warning: type `NES_State` should have an upper camel case name
[INFO] [stderr]   --> src/nes.rs:47:8
[INFO] [stderr]    |
[INFO] [stderr] 47 | struct NES_State {
[INFO] [stderr]    |        ^^^^^^^^^ help: convert the identifier to upper camel case: `NesState`
[INFO] [stderr] 
[INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated
[INFO] [stderr]    --> src/nes.rs:231:54
[INFO] [stderr]     |
[INFO] [stderr] 231 | fn serialize_nes(cpu:&CPU,ppu:&PPU,mapper:Rc<RefCell<Mapper>>) -> Vec<u8> {
[INFO] [stderr]     |                                                      ^^^^^^ help: use `dyn`: `dyn Mapper`
[INFO] [stderr] 
[INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated
[INFO] [stderr]    --> src/nes.rs:241:75
[INFO] [stderr]     |
[INFO] [stderr] 241 | fn deserialize_nes(data:&[u8],cpu:&mut CPU,ppu:&mut PPU,mapper:Rc<RefCell<Mapper>>) {
[INFO] [stderr]     |                                                                           ^^^^^^ help: use `dyn`: `dyn Mapper`
[INFO] [stderr] 
[INFO] [stderr] warning: unreachable pattern
[INFO] [stderr]     --> src/instruction.rs:1414:9
[INFO] [stderr]      |
[INFO] [stderr] 1414 |         _ => panic!("Should never happen..."),
[INFO] [stderr]      |         ^
[INFO] [stderr]      |
[INFO] [stderr]      = note: `#[warn(unreachable_patterns)]` on by default
[INFO] [stderr] 
[INFO] [stderr] warning: unreachable pattern
[INFO] [stderr]    --> src/cpu.rs:218:13
[INFO] [stderr]     |
[INFO] [stderr] 218 |             _ => panic!("DNE")
[INFO] [stderr]     |             ^
[INFO] [stderr] 
[INFO] [stderr] warning: unreachable pattern
[INFO] [stderr]    --> src/cpu.rs:249:13
[INFO] [stderr]     |
[INFO] [stderr] 249 |             _ => panic!("DNE")
[INFO] [stderr]     |             ^
[INFO] [stderr] 
[INFO] [stderr] warning: unreachable pattern
[INFO] [stderr]     --> src/instruction.rs:1414:9
[INFO] [stderr]      |
[INFO] [stderr] 1414 |         _ => panic!("Should never happen..."),
[INFO] [stderr]      |         ^
[INFO] [stderr]      |
[INFO] [stderr]      = note: `#[warn(unreachable_patterns)]` on by default
[INFO] [stderr] 
[INFO] [stderr] warning: unreachable pattern
[INFO] [stderr]    --> src/nes.rs:195:21
[INFO] [stderr]     |
[INFO] [stderr] 195 |                     Event::KeyDown {scancode:Some(Scancode::Num8),..} => {
[INFO] [stderr]     |                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: unreachable pattern
[INFO] [stderr]    --> src/nes.rs:198:21
[INFO] [stderr]     |
[INFO] [stderr] 198 |                     Event::KeyDown {scancode:Some(Scancode::F8),..} => {
[INFO] [stderr]     |                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: unreachable pattern
[INFO] [stderr]    --> src/cpu.rs:218:13
[INFO] [stderr]     |
[INFO] [stderr] 218 |             _ => panic!("DNE")
[INFO] [stderr]     |             ^
[INFO] [stderr] 
[INFO] [stderr] warning: unreachable pattern
[INFO] [stderr]    --> src/cpu.rs:249:13
[INFO] [stderr]     |
[INFO] [stderr] 249 |             _ => panic!("DNE")
[INFO] [stderr]     |             ^
[INFO] [stderr] 
[INFO] [stderr] warning: unreachable pattern
[INFO] [stderr]    --> src/nes.rs:195:21
[INFO] [stderr]     |
[INFO] [stderr] 195 |                     Event::KeyDown {scancode:Some(Scancode::Num8),..} => {
[INFO] [stderr]     |                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: unreachable pattern
[INFO] [stderr]    --> src/nes.rs:198:21
[INFO] [stderr]     |
[INFO] [stderr] 198 |                     Event::KeyDown {scancode:Some(Scancode::F8),..} => {
[INFO] [stderr]     |                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: variable does not need to be mutable
[INFO] [stderr]    --> src/mappers.rs:553:19
[INFO] [stderr]     |
[INFO] [stderr] 553 | pub fn get_mapper(mut ines:INES) -> Rc<RefCell<Mapper>> {
[INFO] [stderr]     |                   ----^^^^
[INFO] [stderr]     |                   |
[INFO] [stderr]     |                   help: remove this `mut`
[INFO] [stderr]     |
[INFO] [stderr]     = note: `#[warn(unused_mut)]` on by default
[INFO] [stderr] 
[INFO] [stderr] warning: variable does not need to be mutable
[INFO] [stderr]    --> src/mappers.rs:553:19
[INFO] [stderr]     |
[INFO] [stderr] 553 | pub fn get_mapper(mut ines:INES) -> Rc<RefCell<Mapper>> {
[INFO] [stderr]     |                   ----^^^^
[INFO] [stderr]     |                   |
[INFO] [stderr]     |                   help: remove this `mut`
[INFO] [stderr]     |
[INFO] [stderr]     = note: `#[warn(unused_mut)]` on by default
[INFO] [stderr] 
[INFO] [stderr] warning: foreign function is never used: `apureset`
[INFO] [stderr]  --> src/apu.rs:7:5
[INFO] [stderr]   |
[INFO] [stderr] 7 |     fn apureset();
[INFO] [stderr]   |     ^^^^^^^^^^^^^^
[INFO] [stderr]   |
[INFO] [stderr]   = note: `#[warn(dead_code)]` on by default
[INFO] [stderr] 
[INFO] [stderr] warning: function is never used: `apu_reset`
[INFO] [stderr]   --> src/apu.rs:20:1
[INFO] [stderr]    |
[INFO] [stderr] 20 | pub fn apu_reset() {
[INFO] [stderr]    | ^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: foreign function is never used: `apureset`
[INFO] [stderr]  --> src/apu.rs:7:5
[INFO] [stderr]   |
[INFO] [stderr] 7 |     fn apureset();
[INFO] [stderr]   |     ^^^^^^^^^^^^^^
[INFO] [stderr]   |
[INFO] [stderr]   = note: `#[warn(dead_code)]` on by default
[INFO] [stderr] 
[INFO] [stderr] warning: function is never used: `apu_reset`
[INFO] [stderr]   --> src/apu.rs:20:1
[INFO] [stderr]    |
[INFO] [stderr] 20 | pub fn apu_reset() {
[INFO] [stderr]    | ^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: `extern` block uses type `cpu::CPU` which is not FFI-safe: this struct has unspecified layout
[INFO] [stderr]  --> src/apu.rs:6:26
[INFO] [stderr]   |
[INFO] [stderr] 6 |     fn apuinit(read_mem: extern fn(cpu:*mut CPU,c: u32) -> i32,cpu:*mut CPU);
[INFO] [stderr]   |                          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]   |
[INFO] [stderr]   = note: `#[warn(improper_ctypes)]` on by default
[INFO] [stderr]   = help: consider adding a `#[repr(C)]` or `#[repr(transparent)]` attribute to this struct
[INFO] [stderr] note: type defined here
[INFO] [stderr]  --> src/cpu.rs:51:1
[INFO] [stderr]   |
[INFO] [stderr] 51| / pub struct CPU {
[INFO] [stderr] 52| |     SP: u8,
[INFO] [stderr] 53| |     P: u8,
[INFO] [stderr] 54| |     A: u8,
[INFO] [stderr] ... |
[INFO] [stderr] 69| |     pub elapsed: i32
[INFO] [stderr] 70| | }
[INFO] [stderr]   | |_^
[INFO] [stderr] 
[INFO] [stderr] warning: `extern` block uses type `cpu::CPU` which is not FFI-safe: this struct has unspecified layout
[INFO] [stderr]  --> src/apu.rs:6:68
[INFO] [stderr]   |
[INFO] [stderr] 6 |     fn apuinit(read_mem: extern fn(cpu:*mut CPU,c: u32) -> i32,cpu:*mut CPU);
[INFO] [stderr]   |                                                                    ^^^^^^^^
[INFO] [stderr]   |
[INFO] [stderr]   = help: consider adding a `#[repr(C)]` or `#[repr(transparent)]` attribute to this struct
[INFO] [stderr] note: type defined here
[INFO] [stderr]  --> src/cpu.rs:51:1
[INFO] [stderr]   |
[INFO] [stderr] 51| / pub struct CPU {
[INFO] [stderr] 52| |     SP: u8,
[INFO] [stderr] 53| |     P: u8,
[INFO] [stderr] 54| |     A: u8,
[INFO] [stderr] ... |
[INFO] [stderr] 69| |     pub elapsed: i32
[INFO] [stderr] 70| | }
[INFO] [stderr]   | |_^
[INFO] [stderr] 
[INFO] [stderr] warning: `extern` block uses type `cpu::CPU` which is not FFI-safe: this struct has unspecified layout
[INFO] [stderr]  --> src/apu.rs:6:26
[INFO] [stderr]   |
[INFO] [stderr] 6 |     fn apuinit(read_mem: extern fn(cpu:*mut CPU,c: u32) -> i32,cpu:*mut CPU);
[INFO] [stderr]   |                          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]   |
[INFO] [stderr]   = note: `#[warn(improper_ctypes)]` on by default
[INFO] [stderr]   = help: consider adding a `#[repr(C)]` or `#[repr(transparent)]` attribute to this struct
[INFO] [stderr] note: type defined here
[INFO] [stderr]  --> src/cpu.rs:51:1
[INFO] [stderr]   |
[INFO] [stderr] 51| / pub struct CPU {
[INFO] [stderr] 52| |     SP: u8,
[INFO] [stderr] 53| |     P: u8,
[INFO] [stderr] 54| |     A: u8,
[INFO] [stderr] ... |
[INFO] [stderr] 69| |     pub elapsed: i32
[INFO] [stderr] 70| | }
[INFO] [stderr]   | |_^
[INFO] [stderr] 
[INFO] [stderr] warning: `extern` block uses type `cpu::CPU` which is not FFI-safe: this struct has unspecified layout
[INFO] [stderr]  --> src/apu.rs:6:68
[INFO] [stderr]   |
[INFO] [stderr] 6 |     fn apuinit(read_mem: extern fn(cpu:*mut CPU,c: u32) -> i32,cpu:*mut CPU);
[INFO] [stderr]   |                                                                    ^^^^^^^^
[INFO] [stderr]   |
[INFO] [stderr]   = help: consider adding a `#[repr(C)]` or `#[repr(transparent)]` attribute to this struct
[INFO] [stderr] note: type defined here
[INFO] [stderr]  --> src/cpu.rs:51:1
[INFO] [stderr]   |
[INFO] [stderr] 51| / pub struct CPU {
[INFO] [stderr] 52| |     SP: u8,
[INFO] [stderr] 53| |     P: u8,
[INFO] [stderr] 54| |     A: u8,
[INFO] [stderr] ... |
[INFO] [stderr] 69| |     pub elapsed: i32
[INFO] [stderr] 70| | }
[INFO] [stderr]   | |_^
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 8.80s
[INFO] running `"docker" "inspect" "ecb234403862750a83420514ed431dc6574862febee82b4117f9808278355dcb"`
[INFO] running `"docker" "rm" "-f" "ecb234403862750a83420514ed431dc6574862febee82b4117f9808278355dcb"`
[INFO] [stdout] ecb234403862750a83420514ed431dc6574862febee82b4117f9808278355dcb