[INFO] updating cached repository https://github.com/rkday/photo-management [INFO] running `"git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "-c" "remote.origin.fetch=refs/heads/*:refs/heads/*" "fetch" "origin" "--force" "--prune"` [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 41bc922426ff0ffddf5ccaf976dfe1ebc1295919 [INFO] checking rkday/photo-management against master#2748a9fd93dd1a00a4521f4f16de5befbf77f6cd for pr-62262-1 [INFO] running `"git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Frkday%2Fphoto-management" "/workspace/builds/worker-3/source"` [INFO] [stderr] Cloning into '/workspace/builds/worker-3/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/rkday/photo-management on toolchain 2748a9fd93dd1a00a4521f4f16de5befbf77f6cd [INFO] running `"/workspace/cargo-home/bin/cargo" "+2748a9fd93dd1a00a4521f4f16de5befbf77f6cd" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started tweaking git repo https://github.com/rkday/photo-management [INFO] finished tweaking git repo https://github.com/rkday/photo-management [INFO] tweaked toml for git repo https://github.com/rkday/photo-management written to /workspace/builds/worker-3/source/Cargo.toml [INFO] crate git repo https://github.com/rkday/photo-management already has a lockfile, it will not be regenerated [INFO] running `"/workspace/cargo-home/bin/cargo" "+2748a9fd93dd1a00a4521f4f16de5befbf77f6cd" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "MAP_USER_ID=0" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--network" "none" "rustops/crates-build-env" "/opt/rustwide/cargo-home/bin/cargo" "+2748a9fd93dd1a00a4521f4f16de5befbf77f6cd" "check" "--frozen" "--all" "--all-targets"` [INFO] [stderr] WARNING: Your kernel does not support swap limit capabilities or the cgroup is not mounted. Memory limited without swap. [INFO] [stdout] a632929ec16641d48a724e1fa2d6244cdbcb7f3e91ca4d2b9c478e02c8d9a587 [INFO] running `"docker" "start" "-a" "a632929ec16641d48a724e1fa2d6244cdbcb7f3e91ca4d2b9c478e02c8d9a587"` [INFO] [stderr] Compiling proc-macro2 v0.4.25 [INFO] [stderr] Checking mustache v0.9.0 [INFO] [stderr] Checking serde_json v1.0.36 [INFO] [stderr] Checking hyper v0.10.15 [INFO] [stderr] Checking env_logger v0.6.0 [INFO] [stderr] Compiling quote v0.6.10 [INFO] [stderr] Compiling syn v0.15.26 [INFO] [stderr] Checking nickel v0.11.0 [INFO] [stderr] Compiling serde_derive v1.0.85 [INFO] [stderr] Checking pviewer v0.1.0 (/opt/rustwide/workdir) [INFO] [stderr] warning: unused import: `std::collections::HashMap` [INFO] [stderr] --> src/bin/pviewer.rs:10:5 [INFO] [stderr] | [INFO] [stderr] 10 | use std::collections::HashMap; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(unused_imports)]` on by default [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `if` condition [INFO] [stderr] --> src/bin/pviewer.rs:40:12 [INFO] [stderr] | [INFO] [stderr] 40 | if (p.is_dir()) { [INFO] [stderr] | ^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(unused_parens)]` on by default [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `if` condition [INFO] [stderr] --> src/bin/pviewer.rs:45:16 [INFO] [stderr] | [INFO] [stderr] 45 | if ((ext == "jpg") || (ext == "JPG")) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `if` condition [INFO] [stderr] --> src/bin/pviewer.rs:73:34 [INFO] [stderr] | [INFO] [stderr] 73 | Some(idx2) => if (idx2 == 0) { &picture } else { folder_contents.images.get(idx2 - 1).unwrap() } [INFO] [stderr] | ^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `if` condition [INFO] [stderr] --> src/bin/pviewer.rs:78:34 [INFO] [stderr] | [INFO] [stderr] 78 | Some(idx2) => if (idx2 == maxidx) { &picture } else { folder_contents.images.get(idx2 + 1).unwrap() } [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: unreachable expression [INFO] [stderr] --> src/bin/pviewer.rs:60:20 [INFO] [stderr] | [INFO] [stderr] 60 | server.utilize(router! { [INFO] [stderr] | ____________________^ [INFO] [stderr] 61 | | get "/picture" => |req, res| { [INFO] [stderr] 62 | | let picture = req.query().get("pic").unwrap().to_owned(); [INFO] [stderr] 63 | | let pic_path = Path::new(&picture).parent().unwrap().to_str().unwrap(); [INFO] [stderr] ... | [INFO] [stderr] 83 | | } [INFO] [stderr] 84 | | }); [INFO] [stderr] | |_____^ unreachable expression [INFO] [stderr] | [INFO] [stderr] ::: <::nickel::macros::middleware::as_block macros>:1:19 [INFO] [stderr] | [INFO] [stderr] 1 | ($ b : block) => ($ b) [INFO] [stderr] | --- any code following this expression is unreachable [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(unreachable_code)]` on by default [INFO] [stderr] = note: this warning originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: unreachable expression [INFO] [stderr] --> src/bin/pviewer.rs:85:20 [INFO] [stderr] | [INFO] [stderr] 85 | server.utilize(router! { [INFO] [stderr] | ____________________^ [INFO] [stderr] 86 | | get "/listdir" => |req, res| { [INFO] [stderr] 87 | | let subdir = req.query().get("dir").unwrap_or("./"); [INFO] [stderr] 88 | | let pd = get_dir_contents(subdir); [INFO] [stderr] 89 | | return res.render("assets/list.tpl", &pd); [INFO] [stderr] 90 | | } [INFO] [stderr] 91 | | }); [INFO] [stderr] | |_____^ unreachable expression [INFO] [stderr] | [INFO] [stderr] ::: <::nickel::macros::middleware::as_block macros>:1:19 [INFO] [stderr] | [INFO] [stderr] 1 | ($ b : block) => ($ b) [INFO] [stderr] | --- any code following this expression is unreachable [INFO] [stderr] | [INFO] [stderr] = note: this warning originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: static variable `dir_s` should have an upper case name [INFO] [stderr] --> src/bin/pviewer.rs:29:8 [INFO] [stderr] | [INFO] [stderr] 29 | static dir_s: &'static str = "/Volumes/Seagate Backup Plus Drive/Media/Pictures"; [INFO] [stderr] | ^^^^^ help: convert the identifier to upper case: `DIR_S` [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(non_upper_case_globals)]` on by default [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/bin/pviewer.rs:95:5 [INFO] [stderr] | [INFO] [stderr] 95 | server.listen("127.0.0.1:4080"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(unused_must_use)]` on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::collections::HashMap` [INFO] [stderr] --> src/bin/pviewer.rs:10:5 [INFO] [stderr] | [INFO] [stderr] 10 | use std::collections::HashMap; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(unused_imports)]` on by default [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `if` condition [INFO] [stderr] --> src/bin/pviewer.rs:40:12 [INFO] [stderr] | [INFO] [stderr] 40 | if (p.is_dir()) { [INFO] [stderr] | ^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(unused_parens)]` on by default [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `if` condition [INFO] [stderr] --> src/bin/pviewer.rs:45:16 [INFO] [stderr] | [INFO] [stderr] 45 | if ((ext == "jpg") || (ext == "JPG")) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `if` condition [INFO] [stderr] --> src/bin/pviewer.rs:73:34 [INFO] [stderr] | [INFO] [stderr] 73 | Some(idx2) => if (idx2 == 0) { &picture } else { folder_contents.images.get(idx2 - 1).unwrap() } [INFO] [stderr] | ^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `if` condition [INFO] [stderr] --> src/bin/pviewer.rs:78:34 [INFO] [stderr] | [INFO] [stderr] 78 | Some(idx2) => if (idx2 == maxidx) { &picture } else { folder_contents.images.get(idx2 + 1).unwrap() } [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: unreachable expression [INFO] [stderr] --> src/bin/pviewer.rs:60:20 [INFO] [stderr] | [INFO] [stderr] 60 | server.utilize(router! { [INFO] [stderr] | ____________________^ [INFO] [stderr] 61 | | get "/picture" => |req, res| { [INFO] [stderr] 62 | | let picture = req.query().get("pic").unwrap().to_owned(); [INFO] [stderr] 63 | | let pic_path = Path::new(&picture).parent().unwrap().to_str().unwrap(); [INFO] [stderr] ... | [INFO] [stderr] 83 | | } [INFO] [stderr] 84 | | }); [INFO] [stderr] | |_____^ unreachable expression [INFO] [stderr] | [INFO] [stderr] ::: <::nickel::macros::middleware::as_block macros>:1:19 [INFO] [stderr] | [INFO] [stderr] 1 | ($ b : block) => ($ b) [INFO] [stderr] | --- any code following this expression is unreachable [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(unreachable_code)]` on by default [INFO] [stderr] = note: this warning originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: unreachable expression [INFO] [stderr] --> src/bin/pviewer.rs:85:20 [INFO] [stderr] | [INFO] [stderr] 85 | server.utilize(router! { [INFO] [stderr] | ____________________^ [INFO] [stderr] 86 | | get "/listdir" => |req, res| { [INFO] [stderr] 87 | | let subdir = req.query().get("dir").unwrap_or("./"); [INFO] [stderr] 88 | | let pd = get_dir_contents(subdir); [INFO] [stderr] 89 | | return res.render("assets/list.tpl", &pd); [INFO] [stderr] 90 | | } [INFO] [stderr] 91 | | }); [INFO] [stderr] | |_____^ unreachable expression [INFO] [stderr] | [INFO] [stderr] ::: <::nickel::macros::middleware::as_block macros>:1:19 [INFO] [stderr] | [INFO] [stderr] 1 | ($ b : block) => ($ b) [INFO] [stderr] | --- any code following this expression is unreachable [INFO] [stderr] | [INFO] [stderr] = note: this warning originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: static variable `dir_s` should have an upper case name [INFO] [stderr] --> src/bin/pviewer.rs:29:8 [INFO] [stderr] | [INFO] [stderr] 29 | static dir_s: &'static str = "/Volumes/Seagate Backup Plus Drive/Media/Pictures"; [INFO] [stderr] | ^^^^^ help: convert the identifier to upper case: `DIR_S` [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(non_upper_case_globals)]` on by default [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/bin/pviewer.rs:95:5 [INFO] [stderr] | [INFO] [stderr] 95 | server.listen("127.0.0.1:4080"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(unused_must_use)]` on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 28.11s [INFO] running `"docker" "inspect" "a632929ec16641d48a724e1fa2d6244cdbcb7f3e91ca4d2b9c478e02c8d9a587"` [INFO] running `"docker" "rm" "-f" "a632929ec16641d48a724e1fa2d6244cdbcb7f3e91ca4d2b9c478e02c8d9a587"` [INFO] [stdout] a632929ec16641d48a724e1fa2d6244cdbcb7f3e91ca4d2b9c478e02c8d9a587