[INFO] fetching crate lightning 0.0.8... [INFO] extracting crate lightning 0.0.8 into work/ex/pr-61629/sources/master#c8865d8e195813ade6b84434ac9f8850e7112d1a/reg/lightning/0.0.8 [INFO] extracting crate lightning 0.0.8 into work/ex/pr-61629/sources/try#e212b7d492c96d3837691ba29d32d5f468933fb8/reg/lightning/0.0.8 [INFO] validating manifest of lightning-0.0.8 on toolchain master#c8865d8e195813ade6b84434ac9f8850e7112d1a [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+c8865d8e195813ade6b84434ac9f8850e7112d1a-alt" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of lightning-0.0.8 on toolchain try#e212b7d492c96d3837691ba29d32d5f468933fb8 [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+e212b7d492c96d3837691ba29d32d5f468933fb8-alt" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing lightning-0.0.8 [INFO] finished frobbing lightning-0.0.8 [INFO] frobbed toml for lightning-0.0.8 written to work/ex/pr-61629/sources/master#c8865d8e195813ade6b84434ac9f8850e7112d1a/reg/lightning/0.0.8/Cargo.toml [INFO] started frobbing lightning-0.0.8 [INFO] finished frobbing lightning-0.0.8 [INFO] frobbed toml for lightning-0.0.8 written to work/ex/pr-61629/sources/try#e212b7d492c96d3837691ba29d32d5f468933fb8/reg/lightning/0.0.8/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+c8865d8e195813ade6b84434ac9f8850e7112d1a-alt" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+e212b7d492c96d3837691ba29d32d5f468933fb8-alt" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+c8865d8e195813ade6b84434ac9f8850e7112d1a-alt" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+e212b7d492c96d3837691ba29d32d5f468933fb8-alt" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] testing lightning-0.0.8 against try#e212b7d492c96d3837691ba29d32d5f468933fb8 for pr-61629 [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/pr-61629/worker-1/try#e212b7d492c96d3837691ba29d32d5f468933fb8:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/pr-61629/sources/try#e212b7d492c96d3837691ba29d32d5f468933fb8/reg/lightning/0.0.8:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+e212b7d492c96d3837691ba29d32d5f468933fb8-alt" "build" "--frozen"` [INFO] [stdout] 15594b7f0c0003567415994825030499c86185475abe0d89cf37ec9f64220ce9 [INFO] running `"docker" "start" "-a" "15594b7f0c0003567415994825030499c86185475abe0d89cf37ec9f64220ce9"` [INFO] [stderr] Compiling libc v0.2.58 [INFO] [stderr] Compiling cc v1.0.26 [INFO] [stderr] Compiling gcc v0.3.55 [INFO] [stderr] Compiling byteorder v1.3.2 [INFO] [stderr] Compiling bech32 v0.5.0 [INFO] [stderr] Compiling rustc-serialize v0.3.24 [INFO] [stderr] Compiling hex v0.3.2 [INFO] [stderr] Compiling bitcoin-bech32 v0.8.1 [INFO] [stderr] Compiling rand v0.4.6 [INFO] [stderr] Compiling time v0.1.42 [INFO] [stderr] Compiling bitcoin_hashes v0.3.2 [INFO] [stderr] Compiling bitcoinconsensus v0.16.4 [INFO] [stderr] Compiling secp256k1 v0.12.2 [INFO] [stderr] Compiling rand v0.3.23 [INFO] [stderr] Compiling rust-crypto v0.2.36 [INFO] [stderr] Compiling bitcoin v0.16.0 [INFO] [stderr] Compiling lightning v0.0.8 (/opt/crater/workdir) [INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stderr] --> src/util/logger.rs:131:62 [INFO] [stderr] | [INFO] [stderr] 131 | pub(crate) struct LogHolder<'a> { pub(crate) logger: &'a Arc } [INFO] [stderr] | ^^^^^^ help: use `dyn`: `dyn Logger` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(bare_trait_objects)] on by default [INFO] [stderr] [INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stderr] --> src/chain/chaininterface.rs:49:45 [INFO] [stderr] | [INFO] [stderr] 49 | fn register_listener(&self, listener: Weak); [INFO] [stderr] | ^^^^^^^^^^^^^ help: use `dyn`: `dyn ChainListener` [INFO] [stderr] [INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stderr] --> src/chain/chaininterface.rs:205:28 [INFO] [stderr] | [INFO] [stderr] 205 | listeners: Mutex>>, [INFO] [stderr] | ^^^^^^^^^^^^^ help: use `dyn`: `dyn ChainListener` [INFO] [stderr] [INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stderr] --> src/chain/chaininterface.rs:207:14 [INFO] [stderr] | [INFO] [stderr] 207 | logger: Arc, [INFO] [stderr] | ^^^^^^ help: use `dyn`: `dyn Logger` [INFO] [stderr] [INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stderr] --> src/chain/chaininterface.rs:233:45 [INFO] [stderr] | [INFO] [stderr] 233 | fn register_listener(&self, listener: Weak) { [INFO] [stderr] | ^^^^^^^^^^^^^ help: use `dyn`: `dyn ChainListener` [INFO] [stderr] [INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stderr] --> src/chain/chaininterface.rs:248:43 [INFO] [stderr] | [INFO] [stderr] 248 | pub fn new(network: Network, logger: Arc) -> ChainWatchInterfaceUtil { [INFO] [stderr] | ^^^^^^ help: use `dyn`: `dyn Logger` [INFO] [stderr] [INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stderr] --> src/chain/keysinterface.rs:134:14 [INFO] [stderr] | [INFO] [stderr] 134 | logger: Arc, [INFO] [stderr] | ^^^^^^ help: use `dyn`: `dyn Logger` [INFO] [stderr] [INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stderr] --> src/chain/keysinterface.rs:140:60 [INFO] [stderr] | [INFO] [stderr] 140 | pub fn new(seed: &[u8; 32], network: Network, logger: Arc) -> KeysManager { [INFO] [stderr] | ^^^^^^ help: use `dyn`: `dyn Logger` [INFO] [stderr] [INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stderr] --> src/ln/channelmanager.rs:316:21 [INFO] [stderr] | [INFO] [stderr] 316 | fee_estimator: Arc, [INFO] [stderr] | ^^^^^^^^^^^^ help: use `dyn`: `dyn FeeEstimator` [INFO] [stderr] [INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stderr] --> src/ln/channelmanager.rs:317:15 [INFO] [stderr] | [INFO] [stderr] 317 | monitor: Arc, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: use `dyn`: `dyn ManyChannelMonitor` [INFO] [stderr] [INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stderr] --> src/ln/channelmanager.rs:318:21 [INFO] [stderr] | [INFO] [stderr] 318 | chain_monitor: Arc, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: use `dyn`: `dyn ChainWatchInterface` [INFO] [stderr] [INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stderr] --> src/ln/channelmanager.rs:319:22 [INFO] [stderr] | [INFO] [stderr] 319 | tx_broadcaster: Arc, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: use `dyn`: `dyn BroadcasterInterface` [INFO] [stderr] [INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stderr] --> src/ln/channelmanager.rs:340:20 [INFO] [stderr] | [INFO] [stderr] 340 | keys_manager: Arc, [INFO] [stderr] | ^^^^^^^^^^^^^ help: use `dyn`: `dyn KeysInterface` [INFO] [stderr] [INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stderr] --> src/ln/channelmanager.rs:342:14 [INFO] [stderr] | [INFO] [stderr] 342 | logger: Arc, [INFO] [stderr] | ^^^^^^ help: use `dyn`: `dyn Logger` [INFO] [stderr] [INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stderr] --> src/ln/channelmanager.rs:533:43 [INFO] [stderr] | [INFO] [stderr] 533 | pub fn new(network: Network, feeest: Arc, monitor: Arc, chain_monitor: Arc, tx_broadcaster: Arc, logger: Arc,keys_manager: Arc, config: UserConfig) -> Result, secp256k1::Error> { [INFO] [stderr] | ^^^^^^^^^^^^ help: use `dyn`: `dyn FeeEstimator` [INFO] [stderr] [INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stderr] --> src/ln/channelmanager.rs:533:71 [INFO] [stderr] | [INFO] [stderr] 533 | pub fn new(network: Network, feeest: Arc, monitor: Arc, chain_monitor: Arc, tx_broadcaster: Arc, logger: Arc,keys_manager: Arc, config: UserConfig) -> Result, secp256k1::Error> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: use `dyn`: `dyn ManyChannelMonitor` [INFO] [stderr] [INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stderr] --> src/ln/channelmanager.rs:533:111 [INFO] [stderr] | [INFO] [stderr] 533 | pub fn new(network: Network, feeest: Arc, monitor: Arc, chain_monitor: Arc, tx_broadcaster: Arc, logger: Arc,keys_manager: Arc, config: UserConfig) -> Result, secp256k1::Error> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: use `dyn`: `dyn ChainWatchInterface` [INFO] [stderr] [INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stderr] --> src/ln/channelmanager.rs:533:153 [INFO] [stderr] | [INFO] [stderr] 533 | pub fn new(network: Network, feeest: Arc, monitor: Arc, chain_monitor: Arc, tx_broadcaster: Arc, logger: Arc,keys_manager: Arc, config: UserConfig) -> Result, secp256k1::Error> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: use `dyn`: `dyn BroadcasterInterface` [INFO] [stderr] [INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stderr] --> src/ln/channelmanager.rs:533:188 [INFO] [stderr] | [INFO] [stderr] 533 | pub fn new(network: Network, feeest: Arc, monitor: Arc, chain_monitor: Arc, tx_broadcaster: Arc, logger: Arc,keys_manager: Arc, config: UserConfig) -> Result, secp256k1::Error> { [INFO] [stderr] | ^^^^^^ help: use `dyn`: `dyn Logger` [INFO] [stderr] [INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stderr] --> src/ln/channelmanager.rs:533:214 [INFO] [stderr] | [INFO] [stderr] 533 | pub fn new(network: Network, feeest: Arc, monitor: Arc, chain_monitor: Arc, tx_broadcaster: Arc, logger: Arc,keys_manager: Arc, config: UserConfig) -> Result, secp256k1::Error> { [INFO] [stderr] | ^^^^^^^^^^^^^ help: use `dyn`: `dyn KeysInterface` [INFO] [stderr] [INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stderr] --> src/ln/channelmanager.rs:2961:24 [INFO] [stderr] | [INFO] [stderr] 2961 | pub keys_manager: Arc, [INFO] [stderr] | ^^^^^^^^^^^^^ help: use `dyn`: `dyn KeysInterface` [INFO] [stderr] [INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stderr] --> src/ln/channelmanager.rs:2966:25 [INFO] [stderr] | [INFO] [stderr] 2966 | pub fee_estimator: Arc, [INFO] [stderr] | ^^^^^^^^^^^^ help: use `dyn`: `dyn FeeEstimator` [INFO] [stderr] [INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stderr] --> src/ln/channelmanager.rs:2972:19 [INFO] [stderr] | [INFO] [stderr] 2972 | pub monitor: Arc, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: use `dyn`: `dyn ManyChannelMonitor` [INFO] [stderr] [INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stderr] --> src/ln/channelmanager.rs:2976:25 [INFO] [stderr] | [INFO] [stderr] 2976 | pub chain_monitor: Arc, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: use `dyn`: `dyn ChainWatchInterface` [INFO] [stderr] [INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stderr] --> src/ln/channelmanager.rs:2980:26 [INFO] [stderr] | [INFO] [stderr] 2980 | pub tx_broadcaster: Arc, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: use `dyn`: `dyn BroadcasterInterface` [INFO] [stderr] [INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stderr] --> src/ln/channelmanager.rs:2983:18 [INFO] [stderr] | [INFO] [stderr] 2983 | pub logger: Arc, [INFO] [stderr] | ^^^^^^ help: use `dyn`: `dyn Logger` [INFO] [stderr] [INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stderr] --> src/ln/channelmonitor.rs:136:21 [INFO] [stderr] | [INFO] [stderr] 136 | chain_monitor: Arc, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: use `dyn`: `dyn ChainWatchInterface` [INFO] [stderr] [INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stderr] --> src/ln/channelmonitor.rs:137:19 [INFO] [stderr] | [INFO] [stderr] 137 | broadcaster: Arc, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: use `dyn`: `dyn BroadcasterInterface` [INFO] [stderr] [INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stderr] --> src/ln/channelmonitor.rs:140:14 [INFO] [stderr] | [INFO] [stderr] 140 | logger: Arc, [INFO] [stderr] | ^^^^^^ help: use `dyn`: `dyn Logger` [INFO] [stderr] [INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stderr] --> src/ln/channelmonitor.rs:208:32 [INFO] [stderr] | [INFO] [stderr] 208 | pub fn new(chain_monitor: Arc, broadcaster: Arc, logger: Arc) -> Arc> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: use `dyn`: `dyn ChainWatchInterface` [INFO] [stderr] [INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stderr] --> src/ln/channelmonitor.rs:208:71 [INFO] [stderr] | [INFO] [stderr] 208 | pub fn new(chain_monitor: Arc, broadcaster: Arc, logger: Arc) -> Arc> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: use `dyn`: `dyn BroadcasterInterface` [INFO] [stderr] [INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stderr] --> src/ln/channelmonitor.rs:208:106 [INFO] [stderr] | [INFO] [stderr] 208 | pub fn new(chain_monitor: Arc, broadcaster: Arc, logger: Arc) -> Arc> { [INFO] [stderr] | ^^^^^^ help: use `dyn`: `dyn Logger` [INFO] [stderr] [INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stderr] --> src/ln/channelmonitor.rs:395:14 [INFO] [stderr] | [INFO] [stderr] 395 | logger: Arc, [INFO] [stderr] | ^^^^^^ help: use `dyn`: `dyn Logger` [INFO] [stderr] [INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stderr] --> src/ln/channelmonitor.rs:432:241 [INFO] [stderr] | [INFO] [stderr] 432 | pub(super) fn new(revocation_base_key: &SecretKey, delayed_payment_base_key: &SecretKey, htlc_base_key: &SecretKey, payment_base_key: &SecretKey, shutdown_pubkey: &PublicKey, our_to_self_delay: u16, destination_script: Script, logger: Arc) -> ChannelMonitor { [INFO] [stderr] | ^^^^^^ help: use `dyn`: `dyn Logger` [INFO] [stderr] [INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stderr] --> src/ln/channelmonitor.rs:1696:115 [INFO] [stderr] | [INFO] [stderr] 1696 | fn block_connected(&mut self, txn_matched: &[&Transaction], height: u32, block_hash: &Sha256dHash, broadcaster: &BroadcasterInterface)-> (Vec<(Sha256dHash, Vec)>, Vec, Vec<(HTLCSource, Option, PaymentHash)>) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: use `dyn`: `dyn BroadcasterInterface` [INFO] [stderr] [INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stderr] --> src/ln/channelmonitor.rs:1952:46 [INFO] [stderr] | [INFO] [stderr] 1952 | impl ReadableArgs> for (Sha256dHash, ChannelMonitor) { [INFO] [stderr] | ^^^^^^ help: use `dyn`: `dyn Logger` [INFO] [stderr] [INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stderr] --> src/ln/channelmonitor.rs:1953:38 [INFO] [stderr] | [INFO] [stderr] 1953 | fn read(reader: &mut R, logger: Arc) -> Result { [INFO] [stderr] | ^^^^^^ help: use `dyn`: `dyn Logger` [INFO] [stderr] [INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stderr] --> src/ln/router.rs:353:21 [INFO] [stderr] | [INFO] [stderr] 353 | chain_monitor: Arc, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: use `dyn`: `dyn ChainWatchInterface` [INFO] [stderr] [INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stderr] --> src/ln/router.rs:354:14 [INFO] [stderr] | [INFO] [stderr] 354 | logger: Arc, [INFO] [stderr] | ^^^^^^ help: use `dyn`: `dyn Logger` [INFO] [stderr] [INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stderr] --> src/ln/router.rs:379:25 [INFO] [stderr] | [INFO] [stderr] 379 | pub chain_monitor: Arc, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: use `dyn`: `dyn ChainWatchInterface` [INFO] [stderr] [INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stderr] --> src/ln/router.rs:382:18 [INFO] [stderr] | [INFO] [stderr] 382 | pub logger: Arc, [INFO] [stderr] | ^^^^^^ help: use `dyn`: `dyn Logger` [INFO] [stderr] [INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stderr] --> src/ln/router.rs:744:55 [INFO] [stderr] | [INFO] [stderr] 744 | pub fn new(our_pubkey: PublicKey, chain_monitor: Arc, logger: Arc) -> Router { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: use `dyn`: `dyn ChainWatchInterface` [INFO] [stderr] [INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stderr] --> src/ln/router.rs:744:89 [INFO] [stderr] | [INFO] [stderr] 744 | pub fn new(our_pubkey: PublicKey, chain_monitor: Arc, logger: Arc) -> Router { [INFO] [stderr] | ^^^^^^ help: use `dyn`: `dyn Logger` [INFO] [stderr] [INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stderr] --> src/ln/peer_handler.rs:27:24 [INFO] [stderr] | [INFO] [stderr] 27 | pub chan_handler: Arc, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `dyn`: `dyn msgs::ChannelMessageHandler` [INFO] [stderr] [INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stderr] --> src/ln/peer_handler.rs:30:25 [INFO] [stderr] | [INFO] [stderr] 30 | pub route_handler: Arc, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `dyn`: `dyn msgs::RoutingMessageHandler` [INFO] [stderr] [INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stderr] --> src/ln/peer_handler.rs:161:14 [INFO] [stderr] | [INFO] [stderr] 161 | logger: Arc, [INFO] [stderr] | ^^^^^^ help: use `dyn`: `dyn Logger` [INFO] [stderr] [INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stderr] --> src/ln/peer_handler.rs:191:86 [INFO] [stderr] | [INFO] [stderr] 191 | pub fn new(message_handler: MessageHandler, our_node_secret: SecretKey, logger: Arc) -> PeerManager { [INFO] [stderr] | ^^^^^^ help: use `dyn`: `dyn Logger` [INFO] [stderr] [INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stderr] --> src/ln/channel.rs:343:14 [INFO] [stderr] | [INFO] [stderr] 343 | logger: Arc, [INFO] [stderr] | ^^^^^^ help: use `dyn`: `dyn Logger` [INFO] [stderr] [INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stderr] --> src/ln/channel.rs:422:38 [INFO] [stderr] | [INFO] [stderr] 422 | pub fn new_outbound(fee_estimator: &FeeEstimator, keys_provider: &Arc, their_node_id: PublicKey, channel_value_satoshis: u64, push_msat: u64, user_id: u64, logger: Arc, config: &UserConfig) -> Result { [INFO] [stderr] | ^^^^^^^^^^^^ help: use `dyn`: `dyn FeeEstimator` [INFO] [stderr] [INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stderr] --> src/ln/channel.rs:422:72 [INFO] [stderr] | [INFO] [stderr] 422 | pub fn new_outbound(fee_estimator: &FeeEstimator, keys_provider: &Arc, their_node_id: PublicKey, channel_value_satoshis: u64, push_msat: u64, user_id: u64, logger: Arc, config: &UserConfig) -> Result { [INFO] [stderr] | ^^^^^^^^^^^^^ help: use `dyn`: `dyn KeysInterface` [INFO] [stderr] [INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stderr] --> src/ln/channel.rs:422:185 [INFO] [stderr] | [INFO] [stderr] 422 | pub fn new_outbound(fee_estimator: &FeeEstimator, keys_provider: &Arc, their_node_id: PublicKey, channel_value_satoshis: u64, push_msat: u64, user_id: u64, logger: Arc, config: &UserConfig) -> Result { [INFO] [stderr] | ^^^^^^ help: use `dyn`: `dyn Logger` [INFO] [stderr] [INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stderr] --> src/ln/channel.rs:521:38 [INFO] [stderr] | [INFO] [stderr] 521 | fn check_remote_fee(fee_estimator: &FeeEstimator, feerate_per_kw: u32) -> Result<(), ChannelError> { [INFO] [stderr] | ^^^^^^^^^^^^ help: use `dyn`: `dyn FeeEstimator` [INFO] [stderr] [INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stderr] --> src/ln/channel.rs:533:38 [INFO] [stderr] | [INFO] [stderr] 533 | pub fn new_from_req(fee_estimator: &FeeEstimator, keys_provider: &Arc, their_node_id: PublicKey, msg: &msgs::OpenChannel, user_id: u64, logger: Arc, config: &UserConfig) -> Result { [INFO] [stderr] | ^^^^^^^^^^^^ help: use `dyn`: `dyn FeeEstimator` [INFO] [stderr] [INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stderr] --> src/ln/channel.rs:533:72 [INFO] [stderr] | [INFO] [stderr] 533 | pub fn new_from_req(fee_estimator: &FeeEstimator, keys_provider: &Arc, their_node_id: PublicKey, msg: &msgs::OpenChannel, user_id: u64, logger: Arc, config: &UserConfig) -> Result { [INFO] [stderr] | ^^^^^^^^^^^^^ help: use `dyn`: `dyn KeysInterface` [INFO] [stderr] [INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stderr] --> src/ln/channel.rs:533:165 [INFO] [stderr] | [INFO] [stderr] 533 | pub fn new_from_req(fee_estimator: &FeeEstimator, keys_provider: &Arc, their_node_id: PublicKey, msg: &msgs::OpenChannel, user_id: u64, logger: Arc, config: &UserConfig) -> Result { [INFO] [stderr] | ^^^^^^ help: use `dyn`: `dyn Logger` [INFO] [stderr] [INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stderr] --> src/ln/channel.rs:1695:84 [INFO] [stderr] | [INFO] [stderr] 1695 | pub fn commitment_signed(&mut self, msg: &msgs::CommitmentSigned, fee_estimator: &FeeEstimator) -> Result<(msgs::RevokeAndACK, Option, Option, ChannelMonitor), ChannelError> { [INFO] [stderr] | ^^^^^^^^^^^^ help: use `dyn`: `dyn FeeEstimator` [INFO] [stderr] [INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stderr] --> src/ln/channel.rs:1963:77 [INFO] [stderr] | [INFO] [stderr] 1963 | pub fn revoke_and_ack(&mut self, msg: &msgs::RevokeAndACK, fee_estimator: &FeeEstimator) -> Result<(Option, Vec<(PendingForwardHTLCInfo, u64)>, Vec<(HTLCSource, PaymentHash, HTLCFailReason)>, Option, ChannelMonitor), ChannelError> { [INFO] [stderr] | ^^^^^^^^^^^^ help: use `dyn`: `dyn FeeEstimator` [INFO] [stderr] [INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stderr] --> src/ln/channel.rs:2305:47 [INFO] [stderr] | [INFO] [stderr] 2305 | pub fn update_fee(&mut self, fee_estimator: &FeeEstimator, msg: &msgs::UpdateFee) -> Result<(), ChannelError> { [INFO] [stderr] | ^^^^^^^^^^^^ help: use `dyn`: `dyn FeeEstimator` [INFO] [stderr] [INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stderr] --> src/ln/channel.rs:2506:67 [INFO] [stderr] | [INFO] [stderr] 2506 | fn maybe_propose_first_closing_signed(&mut self, fee_estimator: &FeeEstimator) -> Option { [INFO] [stderr] | ^^^^^^^^^^^^ help: use `dyn`: `dyn FeeEstimator` [INFO] [stderr] [INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stderr] --> src/ln/channel.rs:2532:45 [INFO] [stderr] | [INFO] [stderr] 2532 | pub fn shutdown(&mut self, fee_estimator: &FeeEstimator, msg: &msgs::Shutdown) -> Result<(Option, Option, Vec<(HTLCSource, PaymentHash)>), ChannelError> { [INFO] [stderr] | ^^^^^^^^^^^^ help: use `dyn`: `dyn FeeEstimator` [INFO] [stderr] [INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stderr] --> src/ln/channel.rs:2605:51 [INFO] [stderr] | [INFO] [stderr] 2605 | pub fn closing_signed(&mut self, fee_estimator: &FeeEstimator, msg: &msgs::ClosingSigned) -> Result<(Option, Option), ChannelError> { [INFO] [stderr] | ^^^^^^^^^^^^ help: use `dyn`: `dyn FeeEstimator` [INFO] [stderr] [INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stderr] --> src/ln/channel.rs:2813:54 [INFO] [stderr] | [INFO] [stderr] 2813 | pub fn get_our_fee_base_msat(&self, fee_estimator: &FeeEstimator) -> u32 { [INFO] [stderr] | ^^^^^^^^^^^^ help: use `dyn`: `dyn FeeEstimator` [INFO] [stderr] [INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stderr] --> src/ln/channel.rs:2984:74 [INFO] [stderr] | [INFO] [stderr] 2984 | pub fn get_open_channel(&self, chain_hash: Sha256dHash, fee_estimator: &FeeEstimator) -> msgs::OpenChannel { [INFO] [stderr] | ^^^^^^^^^^^^ help: use `dyn`: `dyn FeeEstimator` [INFO] [stderr] [INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stderr] --> src/ln/channel.rs:3710:47 [INFO] [stderr] | [INFO] [stderr] 3710 | impl ReadableArgs> for Channel { [INFO] [stderr] | ^^^^^^ help: use `dyn`: `dyn Logger` [INFO] [stderr] [INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stderr] --> src/ln/channel.rs:3711:38 [INFO] [stderr] | [INFO] [stderr] 3711 | fn read(reader: &mut R, logger: Arc) -> Result { [INFO] [stderr] | ^^^^^^ help: use `dyn`: `dyn Logger` [INFO] [stderr] [INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stderr] --> src/ln/onion_utils.rs:271:98 [INFO] [stderr] | [INFO] [stderr] 271 | pub(super) fn process_onion_failure(secp_ctx: &Secp256k1, logger: &Arc, htlc_source: &HTLCSource, mut packet_decrypted: Vec) -> (Option, bool, Option) { [INFO] [stderr] | ^^^^^^ help: use `dyn`: `dyn Logger` [INFO] [stderr] [INFO] [stderr] warning: function is never used: `sort_inputs` [INFO] [stderr] --> src/util/transaction_utils.rs:21:1 [INFO] [stderr] | [INFO] [stderr] 21 | pub fn sort_inputs(inputs: &mut Vec<(TxIn, T)>) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: field is never used: `logger` [INFO] [stderr] --> src/chain/chaininterface.rs:207:2 [INFO] [stderr] | [INFO] [stderr] 207 | logger: Arc, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never used: `logger` [INFO] [stderr] --> src/chain/keysinterface.rs:134:2 [INFO] [stderr] | [INFO] [stderr] 134 | logger: Arc, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Watchtower` [INFO] [stderr] --> src/ln/channelmonitor.rs:319:2 [INFO] [stderr] | [INFO] [stderr] 319 | Watchtower { [INFO] [stderr] | _____^ [INFO] [stderr] 320 | | revocation_base_key: PublicKey, [INFO] [stderr] 321 | | htlc_base_key: PublicKey, [INFO] [stderr] 322 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] [INFO] [stderr] warning: field is never used: `time_created` [INFO] [stderr] --> src/ln/channel.rs:144:3 [INFO] [stderr] | [INFO] [stderr] 144 | time_created: Instant, //TODO: Some kind of timeout thing-a-majig [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] Finished dev [optimized + debuginfo] target(s) in 1m 49s [INFO] running `"docker" "inspect" "15594b7f0c0003567415994825030499c86185475abe0d89cf37ec9f64220ce9"` [INFO] running `"docker" "rm" "-f" "15594b7f0c0003567415994825030499c86185475abe0d89cf37ec9f64220ce9"` [INFO] [stdout] 15594b7f0c0003567415994825030499c86185475abe0d89cf37ec9f64220ce9 [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/pr-61629/worker-1/try#e212b7d492c96d3837691ba29d32d5f468933fb8:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/pr-61629/sources/try#e212b7d492c96d3837691ba29d32d5f468933fb8/reg/lightning/0.0.8:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+e212b7d492c96d3837691ba29d32d5f468933fb8-alt" "test" "--frozen" "--no-run"` [INFO] [stdout] 78fec100f8f567f12063ba1e7ec61c2bbf2549803278af861311fd8976f562cb [INFO] running `"docker" "start" "-a" "78fec100f8f567f12063ba1e7ec61c2bbf2549803278af861311fd8976f562cb"` [INFO] [stderr] Compiling lightning v0.0.8 (/opt/crater/workdir) [INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stderr] --> src/util/logger.rs:131:62 [INFO] [stderr] | [INFO] [stderr] 131 | pub(crate) struct LogHolder<'a> { pub(crate) logger: &'a Arc } [INFO] [stderr] | ^^^^^^ help: use `dyn`: `dyn Logger` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(bare_trait_objects)] on by default [INFO] [stderr] [INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stderr] --> src/util/logger.rs:147:15 [INFO] [stderr] | [INFO] [stderr] 147 | logger: Arc [INFO] [stderr] | ^^^^^^ help: use `dyn`: `dyn Logger` [INFO] [stderr] [INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stderr] --> src/util/logger.rs:151:22 [INFO] [stderr] | [INFO] [stderr] 151 | fn new(logger: Arc) -> WrapperLog { [INFO] [stderr] | ^^^^^^ help: use `dyn`: `dyn Logger` [INFO] [stderr] [INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stderr] --> src/util/logger.rs:170:20 [INFO] [stderr] | [INFO] [stderr] 170 | let logger : Arc = Arc::new(logger); [INFO] [stderr] | ^^^^^^ help: use `dyn`: `dyn Logger` [INFO] [stderr] [INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stderr] --> src/util/test_utils.rs:49:32 [INFO] [stderr] | [INFO] [stderr] 49 | pub fn new(chain_monitor: Arc, broadcaster: Arc, logger: Arc) -> Self { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `dyn`: `dyn chaininterface::ChainWatchInterface` [INFO] [stderr] [INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stderr] --> src/util/test_utils.rs:49:87 [INFO] [stderr] | [INFO] [stderr] 49 | pub fn new(chain_monitor: Arc, broadcaster: Arc, logger: Arc) -> Self { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `dyn`: `dyn chaininterface::BroadcasterInterface` [INFO] [stderr] [INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stderr] --> src/util/test_utils.rs:49:138 [INFO] [stderr] | [INFO] [stderr] 49 | pub fn new(chain_monitor: Arc, broadcaster: Arc, logger: Arc) -> Self { [INFO] [stderr] | ^^^^^^ help: use `dyn`: `dyn Logger` [INFO] [stderr] [INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stderr] --> src/util/test_utils.rs:243:60 [INFO] [stderr] | [INFO] [stderr] 243 | pub fn new(seed: &[u8; 32], network: Network, logger: Arc) -> Self { [INFO] [stderr] | ^^^^^^ help: use `dyn`: `dyn Logger` [INFO] [stderr] [INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stderr] --> src/chain/chaininterface.rs:49:45 [INFO] [stderr] | [INFO] [stderr] 49 | fn register_listener(&self, listener: Weak); [INFO] [stderr] | ^^^^^^^^^^^^^ help: use `dyn`: `dyn ChainListener` [INFO] [stderr] [INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stderr] --> src/chain/chaininterface.rs:205:28 [INFO] [stderr] | [INFO] [stderr] 205 | listeners: Mutex>>, [INFO] [stderr] | ^^^^^^^^^^^^^ help: use `dyn`: `dyn ChainListener` [INFO] [stderr] [INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stderr] --> src/chain/chaininterface.rs:207:14 [INFO] [stderr] | [INFO] [stderr] 207 | logger: Arc, [INFO] [stderr] | ^^^^^^ help: use `dyn`: `dyn Logger` [INFO] [stderr] [INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stderr] --> src/chain/chaininterface.rs:233:45 [INFO] [stderr] | [INFO] [stderr] 233 | fn register_listener(&self, listener: Weak) { [INFO] [stderr] | ^^^^^^^^^^^^^ help: use `dyn`: `dyn ChainListener` [INFO] [stderr] [INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stderr] --> src/chain/chaininterface.rs:248:43 [INFO] [stderr] | [INFO] [stderr] 248 | pub fn new(network: Network, logger: Arc) -> ChainWatchInterfaceUtil { [INFO] [stderr] | ^^^^^^ help: use `dyn`: `dyn Logger` [INFO] [stderr] [INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stderr] --> src/chain/keysinterface.rs:134:14 [INFO] [stderr] | [INFO] [stderr] 134 | logger: Arc, [INFO] [stderr] | ^^^^^^ help: use `dyn`: `dyn Logger` [INFO] [stderr] [INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stderr] --> src/chain/keysinterface.rs:140:60 [INFO] [stderr] | [INFO] [stderr] 140 | pub fn new(seed: &[u8; 32], network: Network, logger: Arc) -> KeysManager { [INFO] [stderr] | ^^^^^^ help: use `dyn`: `dyn Logger` [INFO] [stderr] [INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stderr] --> src/ln/channelmanager.rs:316:21 [INFO] [stderr] | [INFO] [stderr] 316 | fee_estimator: Arc, [INFO] [stderr] | ^^^^^^^^^^^^ help: use `dyn`: `dyn FeeEstimator` [INFO] [stderr] [INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stderr] --> src/ln/channelmanager.rs:317:15 [INFO] [stderr] | [INFO] [stderr] 317 | monitor: Arc, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: use `dyn`: `dyn ManyChannelMonitor` [INFO] [stderr] [INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stderr] --> src/ln/channelmanager.rs:318:21 [INFO] [stderr] | [INFO] [stderr] 318 | chain_monitor: Arc, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: use `dyn`: `dyn ChainWatchInterface` [INFO] [stderr] [INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stderr] --> src/ln/channelmanager.rs:319:22 [INFO] [stderr] | [INFO] [stderr] 319 | tx_broadcaster: Arc, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: use `dyn`: `dyn BroadcasterInterface` [INFO] [stderr] [INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stderr] --> src/ln/channelmanager.rs:340:20 [INFO] [stderr] | [INFO] [stderr] 340 | keys_manager: Arc, [INFO] [stderr] | ^^^^^^^^^^^^^ help: use `dyn`: `dyn KeysInterface` [INFO] [stderr] [INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stderr] --> src/ln/channelmanager.rs:342:14 [INFO] [stderr] | [INFO] [stderr] 342 | logger: Arc, [INFO] [stderr] | ^^^^^^ help: use `dyn`: `dyn Logger` [INFO] [stderr] [INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stderr] --> src/ln/channelmanager.rs:533:43 [INFO] [stderr] | [INFO] [stderr] 533 | pub fn new(network: Network, feeest: Arc, monitor: Arc, chain_monitor: Arc, tx_broadcaster: Arc, logger: Arc,keys_manager: Arc, config: UserConfig) -> Result, secp256k1::Error> { [INFO] [stderr] | ^^^^^^^^^^^^ help: use `dyn`: `dyn FeeEstimator` [INFO] [stderr] [INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stderr] --> src/ln/channelmanager.rs:533:71 [INFO] [stderr] | [INFO] [stderr] 533 | pub fn new(network: Network, feeest: Arc, monitor: Arc, chain_monitor: Arc, tx_broadcaster: Arc, logger: Arc,keys_manager: Arc, config: UserConfig) -> Result, secp256k1::Error> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: use `dyn`: `dyn ManyChannelMonitor` [INFO] [stderr] [INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stderr] --> src/ln/channelmanager.rs:533:111 [INFO] [stderr] | [INFO] [stderr] 533 | pub fn new(network: Network, feeest: Arc, monitor: Arc, chain_monitor: Arc, tx_broadcaster: Arc, logger: Arc,keys_manager: Arc, config: UserConfig) -> Result, secp256k1::Error> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: use `dyn`: `dyn ChainWatchInterface` [INFO] [stderr] [INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stderr] --> src/ln/channelmanager.rs:533:153 [INFO] [stderr] | [INFO] [stderr] 533 | pub fn new(network: Network, feeest: Arc, monitor: Arc, chain_monitor: Arc, tx_broadcaster: Arc, logger: Arc,keys_manager: Arc, config: UserConfig) -> Result, secp256k1::Error> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: use `dyn`: `dyn BroadcasterInterface` [INFO] [stderr] [INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stderr] --> src/ln/channelmanager.rs:533:188 [INFO] [stderr] | [INFO] [stderr] 533 | pub fn new(network: Network, feeest: Arc, monitor: Arc, chain_monitor: Arc, tx_broadcaster: Arc, logger: Arc,keys_manager: Arc, config: UserConfig) -> Result, secp256k1::Error> { [INFO] [stderr] | ^^^^^^ help: use `dyn`: `dyn Logger` [INFO] [stderr] [INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stderr] --> src/ln/channelmanager.rs:533:214 [INFO] [stderr] | [INFO] [stderr] 533 | pub fn new(network: Network, feeest: Arc, monitor: Arc, chain_monitor: Arc, tx_broadcaster: Arc, logger: Arc,keys_manager: Arc, config: UserConfig) -> Result, secp256k1::Error> { [INFO] [stderr] | ^^^^^^^^^^^^^ help: use `dyn`: `dyn KeysInterface` [INFO] [stderr] [INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stderr] --> src/ln/channelmanager.rs:2961:24 [INFO] [stderr] | [INFO] [stderr] 2961 | pub keys_manager: Arc, [INFO] [stderr] | ^^^^^^^^^^^^^ help: use `dyn`: `dyn KeysInterface` [INFO] [stderr] [INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stderr] --> src/ln/channelmanager.rs:2966:25 [INFO] [stderr] | [INFO] [stderr] 2966 | pub fee_estimator: Arc, [INFO] [stderr] | ^^^^^^^^^^^^ help: use `dyn`: `dyn FeeEstimator` [INFO] [stderr] [INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stderr] --> src/ln/channelmanager.rs:2972:19 [INFO] [stderr] | [INFO] [stderr] 2972 | pub monitor: Arc, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: use `dyn`: `dyn ManyChannelMonitor` [INFO] [stderr] [INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stderr] --> src/ln/channelmanager.rs:2976:25 [INFO] [stderr] | [INFO] [stderr] 2976 | pub chain_monitor: Arc, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: use `dyn`: `dyn ChainWatchInterface` [INFO] [stderr] [INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stderr] --> src/ln/channelmanager.rs:2980:26 [INFO] [stderr] | [INFO] [stderr] 2980 | pub tx_broadcaster: Arc, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: use `dyn`: `dyn BroadcasterInterface` [INFO] [stderr] [INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stderr] --> src/ln/channelmanager.rs:2983:18 [INFO] [stderr] | [INFO] [stderr] 2983 | pub logger: Arc, [INFO] [stderr] | ^^^^^^ help: use `dyn`: `dyn Logger` [INFO] [stderr] [INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stderr] --> src/ln/channelmonitor.rs:136:21 [INFO] [stderr] | [INFO] [stderr] 136 | chain_monitor: Arc, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: use `dyn`: `dyn ChainWatchInterface` [INFO] [stderr] [INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stderr] --> src/ln/channelmonitor.rs:137:19 [INFO] [stderr] | [INFO] [stderr] 137 | broadcaster: Arc, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: use `dyn`: `dyn BroadcasterInterface` [INFO] [stderr] [INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stderr] --> src/ln/channelmonitor.rs:140:14 [INFO] [stderr] | [INFO] [stderr] 140 | logger: Arc, [INFO] [stderr] | ^^^^^^ help: use `dyn`: `dyn Logger` [INFO] [stderr] [INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stderr] --> src/ln/channelmonitor.rs:208:32 [INFO] [stderr] | [INFO] [stderr] 208 | pub fn new(chain_monitor: Arc, broadcaster: Arc, logger: Arc) -> Arc> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: use `dyn`: `dyn ChainWatchInterface` [INFO] [stderr] [INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stderr] --> src/ln/channelmonitor.rs:208:71 [INFO] [stderr] | [INFO] [stderr] 208 | pub fn new(chain_monitor: Arc, broadcaster: Arc, logger: Arc) -> Arc> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: use `dyn`: `dyn BroadcasterInterface` [INFO] [stderr] [INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stderr] --> src/ln/channelmonitor.rs:208:106 [INFO] [stderr] | [INFO] [stderr] 208 | pub fn new(chain_monitor: Arc, broadcaster: Arc, logger: Arc) -> Arc> { [INFO] [stderr] | ^^^^^^ help: use `dyn`: `dyn Logger` [INFO] [stderr] [INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stderr] --> src/ln/channelmonitor.rs:395:14 [INFO] [stderr] | [INFO] [stderr] 395 | logger: Arc, [INFO] [stderr] | ^^^^^^ help: use `dyn`: `dyn Logger` [INFO] [stderr] [INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stderr] --> src/ln/channelmonitor.rs:432:241 [INFO] [stderr] | [INFO] [stderr] 432 | pub(super) fn new(revocation_base_key: &SecretKey, delayed_payment_base_key: &SecretKey, htlc_base_key: &SecretKey, payment_base_key: &SecretKey, shutdown_pubkey: &PublicKey, our_to_self_delay: u16, destination_script: Script, logger: Arc) -> ChannelMonitor { [INFO] [stderr] | ^^^^^^ help: use `dyn`: `dyn Logger` [INFO] [stderr] [INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stderr] --> src/ln/channelmonitor.rs:1696:115 [INFO] [stderr] | [INFO] [stderr] 1696 | fn block_connected(&mut self, txn_matched: &[&Transaction], height: u32, block_hash: &Sha256dHash, broadcaster: &BroadcasterInterface)-> (Vec<(Sha256dHash, Vec)>, Vec, Vec<(HTLCSource, Option, PaymentHash)>) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: use `dyn`: `dyn BroadcasterInterface` [INFO] [stderr] [INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stderr] --> src/ln/channelmonitor.rs:1952:46 [INFO] [stderr] | [INFO] [stderr] 1952 | impl ReadableArgs> for (Sha256dHash, ChannelMonitor) { [INFO] [stderr] | ^^^^^^ help: use `dyn`: `dyn Logger` [INFO] [stderr] [INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stderr] --> src/ln/channelmonitor.rs:1953:38 [INFO] [stderr] | [INFO] [stderr] 1953 | fn read(reader: &mut R, logger: Arc) -> Result { [INFO] [stderr] | ^^^^^^ help: use `dyn`: `dyn Logger` [INFO] [stderr] [INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stderr] --> src/ln/router.rs:353:21 [INFO] [stderr] | [INFO] [stderr] 353 | chain_monitor: Arc, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: use `dyn`: `dyn ChainWatchInterface` [INFO] [stderr] [INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stderr] --> src/ln/router.rs:354:14 [INFO] [stderr] | [INFO] [stderr] 354 | logger: Arc, [INFO] [stderr] | ^^^^^^ help: use `dyn`: `dyn Logger` [INFO] [stderr] [INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stderr] --> src/ln/router.rs:379:25 [INFO] [stderr] | [INFO] [stderr] 379 | pub chain_monitor: Arc, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: use `dyn`: `dyn ChainWatchInterface` [INFO] [stderr] [INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stderr] --> src/ln/router.rs:382:18 [INFO] [stderr] | [INFO] [stderr] 382 | pub logger: Arc, [INFO] [stderr] | ^^^^^^ help: use `dyn`: `dyn Logger` [INFO] [stderr] [INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stderr] --> src/ln/router.rs:744:55 [INFO] [stderr] | [INFO] [stderr] 744 | pub fn new(our_pubkey: PublicKey, chain_monitor: Arc, logger: Arc) -> Router { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: use `dyn`: `dyn ChainWatchInterface` [INFO] [stderr] [INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stderr] --> src/ln/router.rs:744:89 [INFO] [stderr] | [INFO] [stderr] 744 | pub fn new(our_pubkey: PublicKey, chain_monitor: Arc, logger: Arc) -> Router { [INFO] [stderr] | ^^^^^^ help: use `dyn`: `dyn Logger` [INFO] [stderr] [INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stderr] --> src/ln/router.rs:1037:19 [INFO] [stderr] | [INFO] [stderr] 1037 | let logger: Arc = Arc::new(test_utils::TestLogger::new()); [INFO] [stderr] | ^^^^^^ help: use `dyn`: `dyn Logger` [INFO] [stderr] [INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stderr] --> src/ln/peer_handler.rs:27:24 [INFO] [stderr] | [INFO] [stderr] 27 | pub chan_handler: Arc, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `dyn`: `dyn msgs::ChannelMessageHandler` [INFO] [stderr] [INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stderr] --> src/ln/peer_handler.rs:30:25 [INFO] [stderr] | [INFO] [stderr] 30 | pub route_handler: Arc, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `dyn`: `dyn msgs::RoutingMessageHandler` [INFO] [stderr] [INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stderr] --> src/ln/peer_handler.rs:161:14 [INFO] [stderr] | [INFO] [stderr] 161 | logger: Arc, [INFO] [stderr] | ^^^^^^ help: use `dyn`: `dyn Logger` [INFO] [stderr] [INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stderr] --> src/ln/peer_handler.rs:191:86 [INFO] [stderr] | [INFO] [stderr] 191 | pub fn new(message_handler: MessageHandler, our_node_secret: SecretKey, logger: Arc) -> PeerManager { [INFO] [stderr] | ^^^^^^ help: use `dyn`: `dyn Logger` [INFO] [stderr] [INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stderr] --> src/ln/peer_handler.rs:1102:20 [INFO] [stderr] | [INFO] [stderr] 1102 | let logger : Arc = Arc::new(test_utils::TestLogger::new()); [INFO] [stderr] | ^^^^^^ help: use `dyn`: `dyn Logger` [INFO] [stderr] [INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stderr] --> src/ln/channel.rs:343:14 [INFO] [stderr] | [INFO] [stderr] 343 | logger: Arc, [INFO] [stderr] | ^^^^^^ help: use `dyn`: `dyn Logger` [INFO] [stderr] [INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stderr] --> src/ln/channel.rs:422:38 [INFO] [stderr] | [INFO] [stderr] 422 | pub fn new_outbound(fee_estimator: &FeeEstimator, keys_provider: &Arc, their_node_id: PublicKey, channel_value_satoshis: u64, push_msat: u64, user_id: u64, logger: Arc, config: &UserConfig) -> Result { [INFO] [stderr] | ^^^^^^^^^^^^ help: use `dyn`: `dyn FeeEstimator` [INFO] [stderr] [INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stderr] --> src/ln/channel.rs:422:72 [INFO] [stderr] | [INFO] [stderr] 422 | pub fn new_outbound(fee_estimator: &FeeEstimator, keys_provider: &Arc, their_node_id: PublicKey, channel_value_satoshis: u64, push_msat: u64, user_id: u64, logger: Arc, config: &UserConfig) -> Result { [INFO] [stderr] | ^^^^^^^^^^^^^ help: use `dyn`: `dyn KeysInterface` [INFO] [stderr] [INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stderr] --> src/ln/channel.rs:422:185 [INFO] [stderr] | [INFO] [stderr] 422 | pub fn new_outbound(fee_estimator: &FeeEstimator, keys_provider: &Arc, their_node_id: PublicKey, channel_value_satoshis: u64, push_msat: u64, user_id: u64, logger: Arc, config: &UserConfig) -> Result { [INFO] [stderr] | ^^^^^^ help: use `dyn`: `dyn Logger` [INFO] [stderr] [INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stderr] --> src/ln/channel.rs:521:38 [INFO] [stderr] | [INFO] [stderr] 521 | fn check_remote_fee(fee_estimator: &FeeEstimator, feerate_per_kw: u32) -> Result<(), ChannelError> { [INFO] [stderr] | ^^^^^^^^^^^^ help: use `dyn`: `dyn FeeEstimator` [INFO] [stderr] [INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stderr] --> src/ln/channel.rs:533:38 [INFO] [stderr] | [INFO] [stderr] 533 | pub fn new_from_req(fee_estimator: &FeeEstimator, keys_provider: &Arc, their_node_id: PublicKey, msg: &msgs::OpenChannel, user_id: u64, logger: Arc, config: &UserConfig) -> Result { [INFO] [stderr] | ^^^^^^^^^^^^ help: use `dyn`: `dyn FeeEstimator` [INFO] [stderr] [INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stderr] --> src/ln/channel.rs:533:72 [INFO] [stderr] | [INFO] [stderr] 533 | pub fn new_from_req(fee_estimator: &FeeEstimator, keys_provider: &Arc, their_node_id: PublicKey, msg: &msgs::OpenChannel, user_id: u64, logger: Arc, config: &UserConfig) -> Result { [INFO] [stderr] | ^^^^^^^^^^^^^ help: use `dyn`: `dyn KeysInterface` [INFO] [stderr] [INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stderr] --> src/ln/channel.rs:533:165 [INFO] [stderr] | [INFO] [stderr] 533 | pub fn new_from_req(fee_estimator: &FeeEstimator, keys_provider: &Arc, their_node_id: PublicKey, msg: &msgs::OpenChannel, user_id: u64, logger: Arc, config: &UserConfig) -> Result { [INFO] [stderr] | ^^^^^^ help: use `dyn`: `dyn Logger` [INFO] [stderr] [INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stderr] --> src/ln/channel.rs:1695:84 [INFO] [stderr] | [INFO] [stderr] 1695 | pub fn commitment_signed(&mut self, msg: &msgs::CommitmentSigned, fee_estimator: &FeeEstimator) -> Result<(msgs::RevokeAndACK, Option, Option, ChannelMonitor), ChannelError> { [INFO] [stderr] | ^^^^^^^^^^^^ help: use `dyn`: `dyn FeeEstimator` [INFO] [stderr] [INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stderr] --> src/ln/channel.rs:1963:77 [INFO] [stderr] | [INFO] [stderr] 1963 | pub fn revoke_and_ack(&mut self, msg: &msgs::RevokeAndACK, fee_estimator: &FeeEstimator) -> Result<(Option, Vec<(PendingForwardHTLCInfo, u64)>, Vec<(HTLCSource, PaymentHash, HTLCFailReason)>, Option, ChannelMonitor), ChannelError> { [INFO] [stderr] | ^^^^^^^^^^^^ help: use `dyn`: `dyn FeeEstimator` [INFO] [stderr] [INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stderr] --> src/ln/channel.rs:2305:47 [INFO] [stderr] | [INFO] [stderr] 2305 | pub fn update_fee(&mut self, fee_estimator: &FeeEstimator, msg: &msgs::UpdateFee) -> Result<(), ChannelError> { [INFO] [stderr] | ^^^^^^^^^^^^ help: use `dyn`: `dyn FeeEstimator` [INFO] [stderr] [INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stderr] --> src/ln/channel.rs:2506:67 [INFO] [stderr] | [INFO] [stderr] 2506 | fn maybe_propose_first_closing_signed(&mut self, fee_estimator: &FeeEstimator) -> Option { [INFO] [stderr] | ^^^^^^^^^^^^ help: use `dyn`: `dyn FeeEstimator` [INFO] [stderr] [INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stderr] --> src/ln/channel.rs:2532:45 [INFO] [stderr] | [INFO] [stderr] 2532 | pub fn shutdown(&mut self, fee_estimator: &FeeEstimator, msg: &msgs::Shutdown) -> Result<(Option, Option, Vec<(HTLCSource, PaymentHash)>), ChannelError> { [INFO] [stderr] | ^^^^^^^^^^^^ help: use `dyn`: `dyn FeeEstimator` [INFO] [stderr] [INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stderr] --> src/ln/channel.rs:2605:51 [INFO] [stderr] | [INFO] [stderr] 2605 | pub fn closing_signed(&mut self, fee_estimator: &FeeEstimator, msg: &msgs::ClosingSigned) -> Result<(Option, Option), ChannelError> { [INFO] [stderr] | ^^^^^^^^^^^^ help: use `dyn`: `dyn FeeEstimator` [INFO] [stderr] [INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stderr] --> src/ln/channel.rs:2813:54 [INFO] [stderr] | [INFO] [stderr] 2813 | pub fn get_our_fee_base_msat(&self, fee_estimator: &FeeEstimator) -> u32 { [INFO] [stderr] | ^^^^^^^^^^^^ help: use `dyn`: `dyn FeeEstimator` [INFO] [stderr] [INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stderr] --> src/ln/channel.rs:2984:74 [INFO] [stderr] | [INFO] [stderr] 2984 | pub fn get_open_channel(&self, chain_hash: Sha256dHash, fee_estimator: &FeeEstimator) -> msgs::OpenChannel { [INFO] [stderr] | ^^^^^^^^^^^^ help: use `dyn`: `dyn FeeEstimator` [INFO] [stderr] [INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stderr] --> src/ln/channel.rs:3710:47 [INFO] [stderr] | [INFO] [stderr] 3710 | impl ReadableArgs> for Channel { [INFO] [stderr] | ^^^^^^ help: use `dyn`: `dyn Logger` [INFO] [stderr] [INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stderr] --> src/ln/channel.rs:3711:38 [INFO] [stderr] | [INFO] [stderr] 3711 | fn read(reader: &mut R, logger: Arc) -> Result { [INFO] [stderr] | ^^^^^^ help: use `dyn`: `dyn Logger` [INFO] [stderr] [INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stderr] --> src/ln/channel.rs:4022:20 [INFO] [stderr] | [INFO] [stderr] 4022 | let logger : Arc = Arc::new(test_utils::TestLogger::new()); [INFO] [stderr] | ^^^^^^ help: use `dyn`: `dyn Logger` [INFO] [stderr] [INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stderr] --> src/ln/channel.rs:4037:26 [INFO] [stderr] | [INFO] [stderr] 4037 | let keys_provider: Arc = Arc::new(Keys { chan_keys }); [INFO] [stderr] | ^^^^^^^^^^^^^ help: use `dyn`: `dyn KeysInterface` [INFO] [stderr] [INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stderr] --> src/ln/onion_utils.rs:271:98 [INFO] [stderr] | [INFO] [stderr] 271 | pub(super) fn process_onion_failure(secp_ctx: &Secp256k1, logger: &Arc, htlc_source: &HTLCSource, mut packet_decrypted: Vec) -> (Option, bool, Option) { [INFO] [stderr] | ^^^^^^ help: use `dyn`: `dyn Logger` [INFO] [stderr] [INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stderr] --> src/ln/functional_test_utils.rs:797:19 [INFO] [stderr] | [INFO] [stderr] 797 | let logger: Arc = Arc::new(test_utils::TestLogger::with_id(format!("node {}", i))); [INFO] [stderr] | ^^^^^^ help: use `dyn`: `dyn Logger` [INFO] [stderr] [INFO] [stderr] warning: the item `rng` is imported redundantly [INFO] [stderr] --> src/ln/functional_tests.rs:1195:6 [INFO] [stderr] | [INFO] [stderr] 22 | use util::rng; [INFO] [stderr] | --------- the item `rng` is already imported here [INFO] [stderr] ... [INFO] [stderr] 1195 | use util::rng; [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: the item `Ordering` is imported redundantly [INFO] [stderr] --> src/ln/functional_tests.rs:1196:6 [INFO] [stderr] | [INFO] [stderr] 44 | use std::sync::atomic::Ordering; [INFO] [stderr] | --------------------------- the item `Ordering` is already imported here [INFO] [stderr] ... [INFO] [stderr] 1196 | use std::sync::atomic::Ordering; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stderr] --> src/ln/functional_tests.rs:3091:31 [INFO] [stderr] | [INFO] [stderr] 3091 | let nodes_0_as_listener: Arc = nodes[0].node.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^ help: use `dyn`: `dyn ChainListener` [INFO] [stderr] [INFO] [stderr] warning: the item `HTLCFailChannelUpdate` is imported redundantly [INFO] [stderr] --> src/ln/functional_tests.rs:4296:6 [INFO] [stderr] | [INFO] [stderr] 16 | use ln::msgs::{ChannelMessageHandler,RoutingMessageHandler,HTLCFailChannelUpdate}; [INFO] [stderr] | --------------------- the item `HTLCFailChannelUpdate` is already imported here [INFO] [stderr] ... [INFO] [stderr] 4296 | use ln::msgs::HTLCFailChannelUpdate; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/ln/functional_tests.rs:4809:7 [INFO] [stderr] | [INFO] [stderr] 4809 | let mut payment_event = { [INFO] [stderr] | ----^^^^^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: field is never used: `logger` [INFO] [stderr] --> src/chain/chaininterface.rs:207:2 [INFO] [stderr] | [INFO] [stderr] 207 | logger: Arc, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: field is never used: `logger` [INFO] [stderr] --> src/chain/keysinterface.rs:134:2 [INFO] [stderr] | [INFO] [stderr] 134 | logger: Arc, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Watchtower` [INFO] [stderr] --> src/ln/channelmonitor.rs:319:2 [INFO] [stderr] | [INFO] [stderr] 319 | Watchtower { [INFO] [stderr] | _____^ [INFO] [stderr] 320 | | revocation_base_key: PublicKey, [INFO] [stderr] 321 | | htlc_base_key: PublicKey, [INFO] [stderr] 322 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] [INFO] [stderr] warning: field is never used: `time_created` [INFO] [stderr] --> src/ln/channel.rs:144:3 [INFO] [stderr] | [INFO] [stderr] 144 | time_created: Instant, //TODO: Some kind of timeout thing-a-majig [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] Finished dev [optimized + debuginfo] target(s) in 54.29s [INFO] running `"docker" "inspect" "78fec100f8f567f12063ba1e7ec61c2bbf2549803278af861311fd8976f562cb"` [INFO] running `"docker" "rm" "-f" "78fec100f8f567f12063ba1e7ec61c2bbf2549803278af861311fd8976f562cb"` [INFO] [stdout] 78fec100f8f567f12063ba1e7ec61c2bbf2549803278af861311fd8976f562cb [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/pr-61629/worker-1/try#e212b7d492c96d3837691ba29d32d5f468933fb8:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/pr-61629/sources/try#e212b7d492c96d3837691ba29d32d5f468933fb8/reg/lightning/0.0.8:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+e212b7d492c96d3837691ba29d32d5f468933fb8-alt" "test" "--frozen"` [INFO] [stdout] 7a96f092c4e1383656de6d27b887cfa13812601696281c65a6f3da3d2fab8d96 [INFO] running `"docker" "start" "-a" "7a96f092c4e1383656de6d27b887cfa13812601696281c65a6f3da3d2fab8d96"` [INFO] [stderr] Finished dev [optimized + debuginfo] target(s) in 0.04s [INFO] [stderr] Running /opt/crater/target/debug/deps/lightning-298daf6f8b476cd3 [INFO] [stdout] [INFO] [stdout] running 114 tests [INFO] [stdout] test chain::transaction::tests::test_channel_id_calculation ... ok [INFO] [stdout] test ln::chanmon_update_fail_tests::monitor_failed_no_reestablish_response ... ok [INFO] [stdout] test ln::chanmon_update_fail_tests::first_message_on_recv_ordering ... ok [INFO] [stdout] test ln::chanmon_update_fail_tests::raa_no_response_awaiting_raa_state ... ok [INFO] [stdout] test ln::chanmon_update_fail_tests::monitor_update_claim_fail_no_response ... ok [INFO] [stdout] test ln::chanmon_update_fail_tests::claim_while_disconnected_monitor_update_fail ... ok [INFO] [stdout] test ln::chanmon_update_fail_tests::test_monitor_update_fail_cs ... ok [INFO] [stdout] test ln::chanmon_update_fail_tests::test_monitor_update_fail_no_rebroadcast ... ok [INFO] [stdout] test ln::chanmon_update_fail_tests::test_monitor_update_raa_while_paused ... ok [INFO] [stdout] test ln::chanmon_update_fail_tests::test_monitor_update_fail_claim ... ok [INFO] [stdout] test ln::chanmon_update_fail_tests::test_monitor_update_fail_reestablish ... ok [INFO] [stdout] test ln::chanmon_update_fail_tests::test_simple_monitor_permanent_update_fail ... ok [INFO] [stdout] test ln::channel::tests::outbound_commitment_test ... ok [INFO] [stdout] test ln::channel::tests::test_max_funding_satoshis ... ok [INFO] [stdout] test ln::channel::tests::test_per_commitment_secret_gen ... ok [INFO] [stdout] test ln::channel::tests::test_key_derivation ... ok [INFO] [stdout] test ln::channelmonitor::tests::test_prune_preimages ... ok [INFO] [stdout] test ln::channelmonitor::tests::test_per_commitment_storage ... ok [INFO] [stdout] test ln::functional_tests::bolt2_open_channel_sending_node_checks_part2 ... ok [INFO] [stdout] test ln::functional_tests::bolt2_open_channel_sending_node_checks_part1 ... ok [INFO] [stdout] test ln::chanmon_update_fail_tests::test_simple_monitor_temporary_update_fail ... ok [INFO] [stdout] test ln::chanmon_update_fail_tests::test_monitor_temporary_update_fail_b ... ok [INFO] [stdout] test ln::chanmon_update_fail_tests::test_monitor_temporary_update_fail_c ... ok [INFO] [stdout] test ln::chanmon_update_fail_tests::test_monitor_update_on_pending_forwards ... ok [INFO] [stdout] test ln::functional_tests::claim_htlc_outputs_single_tx ... ok [INFO] [stdout] test ln::functional_tests::claim_htlc_outputs_shared_tx ... ok [INFO] [stdout] test ln::chanmon_update_fail_tests::test_monitor_temporary_update_fail_a ... ok [INFO] [stdout] test ln::chanmon_update_fail_tests::test_monitor_update_fail_raa ... ok [INFO] [stdout] test ln::functional_tests::htlc_claim_single_commitment_only_a ... ok [INFO] [stdout] test ln::functional_tests::pre_funding_lock_shutdown_test ... ok [INFO] [stdout] test ln::functional_tests::htlc_fail_async_shutdown ... ok [INFO] [stdout] test ln::functional_tests::htlc_claim_single_commitment_only_b ... ok [INFO] [stdout] test ln::functional_tests::revoked_output_claim ... ok [INFO] [stdout] test ln::functional_tests::test_claim_on_remote_sizeable_push_msat ... ok [INFO] [stdout] test ln::functional_tests::duplicate_htlc_test ... ok [INFO] [stdout] test ln::functional_tests::test_claim_on_remote_revoked_sizeable_push_msat ... ok [INFO] [stdout] test ln::functional_tests::test_claim_sizeable_push_msat ... ok [INFO] [stdout] test ln::functional_tests::channel_monitor_network_test ... ok [INFO] [stdout] test ln::functional_tests::test_async_inbound_update_fee ... ok [INFO] [stdout] test ln::functional_tests::test_drop_messages_peer_disconnect_dual_htlc ... ok [INFO] [stdout] test ln::functional_tests::channel_reserve_test ... ok [INFO] [stdout] test ln::functional_tests::test_dynamic_spendable_outputs_local_htlc_success_tx ... ok [INFO] [stdout] test ln::functional_tests::test_dynamic_spendable_outputs_local_htlc_timeout_tx ... ok [INFO] [stdout] test ln::functional_tests::test_duplicate_payment_hash_one_failure_one_success ... ok [INFO] [stdout] test ln::functional_tests::test_drop_messages_peer_disconnect_a ... ok [INFO] [stdout] test ln::functional_tests::test_drop_messages_peer_disconnect_b ... ok [INFO] [stdout] test ln::functional_tests::test_force_close_fail_back ... ok [INFO] [stdout] test ln::functional_tests::test_funding_peer_disconnect ... ok [INFO] [stdout] test ln::functional_tests::holding_cell_htlc_counting ... ok [INFO] [stdout] test ln::functional_tests::test_htlc_ignore_latest_remote_commitment ... ok [INFO] [stdout] test ln::functional_tests::fake_network_test ... ok [INFO] [stdout] test ln::functional_tests::test_htlc_on_chain_success ... ok [INFO] [stdout] test ln::functional_tests::test_invalid_channel_announcement ... ok [INFO] [stdout] test ln::functional_tests::test_htlc_on_chain_timeout ... ok [INFO] [stdout] test ln::functional_tests::test_commitment_revoked_fail_backward_exhaustive_a ... ok [INFO] [stdout] test ln::functional_tests::test_commitment_revoked_fail_backward_exhaustive_b ... ok [INFO] [stdout] test ln::functional_tests::test_multi_flight_update_fee ... ok [INFO] [stdout] test ln::functional_tests::test_justice_tx ... ok [INFO] [stdout] test ln::functional_tests::test_no_txn_manager_serialize_deserialize ... ok [INFO] [stdout] test ln::functional_tests::test_manager_serialize_deserialize_inconsistent_monitor ... ok [INFO] [stdout] test ln::functional_tests::test_fail_backwards_previous_remote_announce ... ok [INFO] [stdout] test ln::functional_tests::test_onchain_to_onchain_claim ... ok [INFO] [stdout] test ln::functional_tests::test_simple_commitment_revoked_fail_backward ... ok [INFO] [stdout] test ln::functional_tests::test_simple_manager_serialize_deserialize ... ok [INFO] [stdout] test ln::functional_tests::test_static_output_closing_tx ... ok [INFO] [stdout] test ln::functional_tests::test_fail_backwards_latest_remote_announce_a ... ok [INFO] [stdout] test ln::functional_tests::test_static_spendable_outputs_justice_tx_revoked_htlc_success_tx ... ok [INFO] [stdout] test ln::functional_tests::test_fail_backwards_latest_remote_announce_b ... ok [INFO] [stdout] test ln::functional_tests::test_static_spendable_outputs_justice_tx_revoked_commitment_tx ... ok [INFO] [stdout] test ln::functional_tests::test_shutdown_rebroadcast ... ok [INFO] [stdout] test ln::functional_tests::test_unconf_chan ... ok [INFO] [stdout] test ln::functional_tests::test_update_add_htlc_bolt2_receiver_check_cltv_expiry ... ok [INFO] [stdout] test ln::functional_tests::test_update_add_htlc_bolt2_receiver_check_max_htlc_limit ... ok [INFO] [stdout] test ln::functional_tests::test_update_add_htlc_bolt2_receiver_check_amount_received_more_than_min ... ok [INFO] [stdout] test ln::functional_tests::test_static_spendable_outputs_preimage_tx ... ok [INFO] [stdout] test ln::functional_tests::test_static_spendable_outputs_justice_tx_revoked_htlc_timeout_tx ... ok [INFO] [stdout] test ln::functional_tests::test_update_add_htlc_bolt2_receiver_check_max_in_flight_msat ... ok [INFO] [stdout] test ln::functional_tests::test_update_add_htlc_bolt2_receiver_check_repeated_id_ignore ... ok [INFO] [stdout] test ln::functional_tests::test_update_add_htlc_bolt2_receiver_sender_can_afford_amount_sent ... ok [INFO] [stdout] test ln::functional_tests::test_update_add_htlc_bolt2_sender_cltv_expiry_too_high ... ok [INFO] [stdout] test ln::functional_tests::test_update_add_htlc_bolt2_sender_value_below_minimum_msat ... ok [INFO] [stdout] test ln::functional_tests::test_update_fee_unordered_raa ... ok [INFO] [stdout] test ln::functional_tests::test_update_add_htlc_bolt2_sender_exceed_max_htlc_value_in_flight ... ok [INFO] [stdout] test ln::functional_tests::test_update_fee ... ok [INFO] [stdout] test ln::functional_tests::test_update_fee_that_funder_cannot_afford ... ok [INFO] [stdout] test ln::msgs::tests::encoding_channel_reestablish_no_secret ... ok [INFO] [stdout] test ln::msgs::tests::encoding_channel_reestablish_with_secret ... ok [INFO] [stdout] test ln::onion_utils::tests::onion_vectors ... ok [INFO] [stdout] test ln::onion_utils::tests::test_failure_packet_onion ... ok [INFO] [stdout] test ln::peer_channel_encryptor::tests::noise_initiator_test_vectors ... ok [INFO] [stdout] test ln::peer_channel_encryptor::tests::noise_responder_test_vectors ... ok [INFO] [stdout] test ln::peer_handler::tests::test_disconnect_peer ... ok [INFO] [stdout] test ln::peer_channel_encryptor::tests::message_encryption_decryption_test_vectors ... ok [INFO] [stdout] test util::chacha20::test::test_chacha20_256_tls_vectors ... ok [INFO] [stdout] test util::chacha20::test::test_chacha20_256_tls_vectors_96_nonce ... ok [INFO] [stdout] test util::logger::tests::test_level_show ... ok [INFO] [stdout] test util::logger::tests::test_logging_macros ... ok [INFO] [stdout] test util::poly1305::test::donna_self_test ... ok [INFO] [stdout] test util::poly1305::test::test_nacl_vector ... ok [INFO] [stdout] test ln::router::tests::route_test ... ok [INFO] [stdout] test util::poly1305::test::test_tls_vectors ... ok [INFO] [stdout] test util::transaction_utils::tests::bip69_txin_test_1 ... ok [INFO] [stdout] test util::transaction_utils::tests::bip69_txin_test_2 ... ok [INFO] [stdout] test util::transaction_utils::tests::bip69_txout_test_2 ... ok [INFO] [stdout] test util::transaction_utils::tests::bip69_txout_test_1 ... ok [INFO] [stdout] test util::transaction_utils::tests::sort_output_by_script_pubkey ... ok [INFO] [stdout] test util::transaction_utils::tests::sort_output_by_bip_test ... ok [INFO] [stdout] test util::transaction_utils::tests::sort_output_by_value ... ok [INFO] [stdout] test ln::functional_tests::test_update_fee_vanilla ... ok [INFO] [stdout] test ln::functional_tests::test_update_fee_with_fundee_update_add_htlc ... ok [INFO] [stdout] test ln::functional_tests::updates_shutdown_wait ... ok [INFO] [stdout] test ln::functional_tests::test_simple_peer_disconnect ... ok [INFO] [stdout] test ln::functional_tests::test_onion_failure ... ok [INFO] [stdout] test ln::functional_tests::test_update_add_htlc_bolt2_sender_exceed_max_htlc_num_and_htlc_id_increment ... ok [INFO] [stdout] [INFO] [stdout] test result: ok. 114 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out [INFO] [stdout] [INFO] [stderr] Doc-tests lightning [INFO] [stdout] [INFO] [stdout] running 0 tests [INFO] [stdout] [INFO] [stdout] test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out [INFO] [stdout] [INFO] running `"docker" "inspect" "7a96f092c4e1383656de6d27b887cfa13812601696281c65a6f3da3d2fab8d96"` [INFO] running `"docker" "rm" "-f" "7a96f092c4e1383656de6d27b887cfa13812601696281c65a6f3da3d2fab8d96"` [INFO] [stdout] 7a96f092c4e1383656de6d27b887cfa13812601696281c65a6f3da3d2fab8d96