[INFO] updating cached repository droidkid/rust-tetris [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/droidkid/rust-tetris [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/droidkid/rust-tetris" "work/ex/pr-59199/sources/master#bc44841ad2a2ad5f6c5e67b9e35ed8e7e71d4dc7/gh/droidkid/rust-tetris"` [INFO] [stderr] Cloning into 'work/ex/pr-59199/sources/master#bc44841ad2a2ad5f6c5e67b9e35ed8e7e71d4dc7/gh/droidkid/rust-tetris'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/droidkid/rust-tetris" "work/ex/pr-59199/sources/try#68fcf881bd1e4dbfc21e22f8c7a56b8a5d8e8f7b/gh/droidkid/rust-tetris"` [INFO] [stderr] Cloning into 'work/ex/pr-59199/sources/try#68fcf881bd1e4dbfc21e22f8c7a56b8a5d8e8f7b/gh/droidkid/rust-tetris'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] d7739277f8489ba9f6b2ba7f772f909813828b03 [INFO] sha for GitHub repo droidkid/rust-tetris: d7739277f8489ba9f6b2ba7f772f909813828b03 [INFO] validating manifest of droidkid/rust-tetris on toolchain master#bc44841ad2a2ad5f6c5e67b9e35ed8e7e71d4dc7 [INFO] running `"/mnt/crater-raid/crater/work/local/cargo-home/bin/cargo" "+bc44841ad2a2ad5f6c5e67b9e35ed8e7e71d4dc7-alt" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of droidkid/rust-tetris on toolchain try#68fcf881bd1e4dbfc21e22f8c7a56b8a5d8e8f7b [INFO] running `"/mnt/crater-raid/crater/work/local/cargo-home/bin/cargo" "+68fcf881bd1e4dbfc21e22f8c7a56b8a5d8e8f7b-alt" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing droidkid/rust-tetris [INFO] finished frobbing droidkid/rust-tetris [INFO] frobbed toml for droidkid/rust-tetris written to work/ex/pr-59199/sources/master#bc44841ad2a2ad5f6c5e67b9e35ed8e7e71d4dc7/gh/droidkid/rust-tetris/Cargo.toml [INFO] started frobbing droidkid/rust-tetris [INFO] finished frobbing droidkid/rust-tetris [INFO] frobbed toml for droidkid/rust-tetris written to work/ex/pr-59199/sources/try#68fcf881bd1e4dbfc21e22f8c7a56b8a5d8e8f7b/gh/droidkid/rust-tetris/Cargo.toml [INFO] crate droidkid/rust-tetris already has a lockfile, it will not be regenerated [INFO] running `"/mnt/crater-raid/crater/work/local/cargo-home/bin/cargo" "+bc44841ad2a2ad5f6c5e67b9e35ed8e7e71d4dc7-alt" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/crater-raid/crater/work/local/cargo-home/bin/cargo" "+68fcf881bd1e4dbfc21e22f8c7a56b8a5d8e8f7b-alt" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] checking droidkid/rust-tetris against try#68fcf881bd1e4dbfc21e22f8c7a56b8a5d8e8f7b for pr-59199 [INFO] running `"docker" "create" "-v" "/mnt/crater-raid/crater/work/local/target-dirs/pr-59199/worker-2/try#68fcf881bd1e4dbfc21e22f8c7a56b8a5d8e8f7b:/opt/crater/target:rw,Z" "-v" "/mnt/crater-raid/crater/work/ex/pr-59199/sources/try#68fcf881bd1e4dbfc21e22f8c7a56b8a5d8e8f7b/gh/droidkid/rust-tetris:/opt/crater/workdir:ro,Z" "-v" "/mnt/crater-raid/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/crater-raid/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+68fcf881bd1e4dbfc21e22f8c7a56b8a5d8e8f7b-alt" "check" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 9bb501687cac59c1b5f1e231fd4bd94567ffaa7d59b8205a81c3b466680f8f42 [INFO] running `"docker" "start" "-a" "9bb501687cac59c1b5f1e231fd4bd94567ffaa7d59b8205a81c3b466680f8f42"` [INFO] [stderr] Checking rust-tetris v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unused import: `std::thread` [INFO] [stderr] --> src/main.rs:17:5 [INFO] [stderr] | [INFO] [stderr] 17 | use std::thread; [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `for` head expression [INFO] [stderr] --> src/main.rs:422:22 [INFO] [stderr] | [INFO] [stderr] 422 | for j in (1..self.width-1) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_parens)] on by default [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `if` condition [INFO] [stderr] --> src/main.rs:473:16 [INFO] [stderr] | [INFO] [stderr] 473 | if (self.game_over_countdown > 0) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `if` condition [INFO] [stderr] --> src/main.rs:483:12 [INFO] [stderr] | [INFO] [stderr] 483 | if (input.left_key_pressed) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `if` condition [INFO] [stderr] --> src/main.rs:486:12 [INFO] [stderr] | [INFO] [stderr] 486 | if (input.right_key_pressed) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `if` condition [INFO] [stderr] --> src/main.rs:489:12 [INFO] [stderr] | [INFO] [stderr] 489 | if (input.up_key_pressed) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `if` condition [INFO] [stderr] --> src/main.rs:493:12 [INFO] [stderr] | [INFO] [stderr] 493 | if (input.down_key_pressed) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `if` condition [INFO] [stderr] --> src/main.rs:500:12 [INFO] [stderr] | [INFO] [stderr] 500 | if (self.gravity_countdown > 0) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `if` condition [INFO] [stderr] --> src/main.rs:503:12 [INFO] [stderr] | [INFO] [stderr] 503 | if (self.lock_delay_countdown > 0 && self.locking_state) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `if` condition [INFO] [stderr] --> src/main.rs:539:12 [INFO] [stderr] | [INFO] [stderr] 539 | if (self.level >= 10) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `if` condition [INFO] [stderr] --> src/main.rs:646:12 [INFO] [stderr] | [INFO] [stderr] 646 | if (event_pump.keyboard_state().is_scancode_pressed(Scancode::Down)) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::thread` [INFO] [stderr] --> src/main.rs:17:5 [INFO] [stderr] | [INFO] [stderr] 17 | use std::thread; [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `for` head expression [INFO] [stderr] --> src/main.rs:422:22 [INFO] [stderr] | [INFO] [stderr] 422 | for j in (1..self.width-1) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_parens)] on by default [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `if` condition [INFO] [stderr] --> src/main.rs:473:16 [INFO] [stderr] | [INFO] [stderr] 473 | if (self.game_over_countdown > 0) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `if` condition [INFO] [stderr] --> src/main.rs:483:12 [INFO] [stderr] | [INFO] [stderr] 483 | if (input.left_key_pressed) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `if` condition [INFO] [stderr] --> src/main.rs:486:12 [INFO] [stderr] | [INFO] [stderr] 486 | if (input.right_key_pressed) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `if` condition [INFO] [stderr] --> src/main.rs:489:12 [INFO] [stderr] | [INFO] [stderr] 489 | if (input.up_key_pressed) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `if` condition [INFO] [stderr] --> src/main.rs:493:12 [INFO] [stderr] | [INFO] [stderr] 493 | if (input.down_key_pressed) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `if` condition [INFO] [stderr] --> src/main.rs:500:12 [INFO] [stderr] | [INFO] [stderr] 500 | if (self.gravity_countdown > 0) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `if` condition [INFO] [stderr] --> src/main.rs:503:12 [INFO] [stderr] | [INFO] [stderr] 503 | if (self.lock_delay_countdown > 0 && self.locking_state) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `if` condition [INFO] [stderr] --> src/main.rs:539:12 [INFO] [stderr] | [INFO] [stderr] 539 | if (self.level >= 10) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `if` condition [INFO] [stderr] --> src/main.rs:646:12 [INFO] [stderr] | [INFO] [stderr] 646 | if (event_pump.keyboard_state().is_scancode_pressed(Scancode::Down)) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: value assigned to `move_down_success` is never read [INFO] [stderr] --> src/main.rs:508:17 [INFO] [stderr] | [INFO] [stderr] 508 | let mut move_down_success = true; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_assignments)] on by default [INFO] [stderr] = help: maybe it is overwritten before being read? [INFO] [stderr] [INFO] [stderr] warning: value assigned to `move_down_success` is never read [INFO] [stderr] --> src/main.rs:508:17 [INFO] [stderr] | [INFO] [stderr] 508 | let mut move_down_success = true; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_assignments)] on by default [INFO] [stderr] = help: maybe it is overwritten before being read? [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:613:9 [INFO] [stderr] | [INFO] [stderr] 613 | let mut font = ttf_context.load_font(font_path, 28).unwrap(); [INFO] [stderr] | ----^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: method is never used: `is_row_empty` [INFO] [stderr] --> src/main.rs:411:5 [INFO] [stderr] | [INFO] [stderr] 411 | fn is_row_empty(&self, row:usize) -> bool { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: static variable `start_pos` should have an upper case name [INFO] [stderr] --> src/main.rs:20:8 [INFO] [stderr] | [INFO] [stderr] 20 | static start_pos: Pos2D = Pos2D { [INFO] [stderr] | ^^^^^^^^^ help: convert the identifier to upper case: `START_POS` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(non_upper_case_globals)] on by default [INFO] [stderr] [INFO] [stderr] warning: static variable `tetris_board_width` should have an upper case name [INFO] [stderr] --> src/main.rs:24:8 [INFO] [stderr] | [INFO] [stderr] 24 | static tetris_board_width : usize = 12; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: convert the identifier to upper case: `TETRIS_BOARD_WIDTH` [INFO] [stderr] [INFO] [stderr] warning: static variable `tetris_board_height` should have an upper case name [INFO] [stderr] --> src/main.rs:25:8 [INFO] [stderr] | [INFO] [stderr] 25 | static tetris_board_height : usize = 24; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: convert the identifier to upper case: `TETRIS_BOARD_HEIGHT` [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:273:13 [INFO] [stderr] | [INFO] [stderr] 273 | canvas.fill_rect(rect); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: variable `randomTetrisPieceGenerator` should have a snake case name [INFO] [stderr] --> src/main.rs:342:17 [INFO] [stderr] | [INFO] [stderr] 342 | let mut randomTetrisPieceGenerator = RandomTetrisPieceGenerator::new(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: convert the identifier to snake case: `random_tetris_piece_generator` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(non_snake_case)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:556:9 [INFO] [stderr] | [INFO] [stderr] 556 | canvas.fill_rect(rect); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:661:13 [INFO] [stderr] | [INFO] [stderr] 661 | canvas.fill_rect(Rect::new(0,0,width,height)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:613:9 [INFO] [stderr] | [INFO] [stderr] 613 | let mut font = ttf_context.load_font(font_path, 28).unwrap(); [INFO] [stderr] | ----^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: method is never used: `is_row_empty` [INFO] [stderr] --> src/main.rs:411:5 [INFO] [stderr] | [INFO] [stderr] 411 | fn is_row_empty(&self, row:usize) -> bool { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: static variable `start_pos` should have an upper case name [INFO] [stderr] --> src/main.rs:20:8 [INFO] [stderr] | [INFO] [stderr] 20 | static start_pos: Pos2D = Pos2D { [INFO] [stderr] | ^^^^^^^^^ help: convert the identifier to upper case: `START_POS` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(non_upper_case_globals)] on by default [INFO] [stderr] [INFO] [stderr] warning: static variable `tetris_board_width` should have an upper case name [INFO] [stderr] --> src/main.rs:24:8 [INFO] [stderr] | [INFO] [stderr] 24 | static tetris_board_width : usize = 12; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: convert the identifier to upper case: `TETRIS_BOARD_WIDTH` [INFO] [stderr] [INFO] [stderr] warning: static variable `tetris_board_height` should have an upper case name [INFO] [stderr] --> src/main.rs:25:8 [INFO] [stderr] | [INFO] [stderr] 25 | static tetris_board_height : usize = 24; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: convert the identifier to upper case: `TETRIS_BOARD_HEIGHT` [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:273:13 [INFO] [stderr] | [INFO] [stderr] 273 | canvas.fill_rect(rect); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: variable `randomTetrisPieceGenerator` should have a snake case name [INFO] [stderr] --> src/main.rs:342:17 [INFO] [stderr] | [INFO] [stderr] 342 | let mut randomTetrisPieceGenerator = RandomTetrisPieceGenerator::new(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: convert the identifier to snake case: `random_tetris_piece_generator` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(non_snake_case)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:556:9 [INFO] [stderr] | [INFO] [stderr] 556 | canvas.fill_rect(rect); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:661:13 [INFO] [stderr] | [INFO] [stderr] 661 | canvas.fill_rect(Rect::new(0,0,width,height)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.93s [INFO] running `"docker" "inspect" "9bb501687cac59c1b5f1e231fd4bd94567ffaa7d59b8205a81c3b466680f8f42"` [INFO] running `"docker" "rm" "-f" "9bb501687cac59c1b5f1e231fd4bd94567ffaa7d59b8205a81c3b466680f8f42"` [INFO] [stdout] 9bb501687cac59c1b5f1e231fd4bd94567ffaa7d59b8205a81c3b466680f8f42