Dec 19 19:58:05.754 INFO checking benbrunton/les against master#d99a320cba42f661aebfa1293b7b2ec3603dda75 for pr-56955 Dec 19 19:58:05.754 INFO running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/pr-56955/worker-2/master#d99a320cba42f661aebfa1293b7b2ec3603dda75:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/pr-56955/sources/master#d99a320cba42f661aebfa1293b7b2ec3603dda75/gh/benbrunton/les:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+d99a320cba42f661aebfa1293b7b2ec3603dda75-alt" "check" "--frozen" "--all" "--all-targets"` Dec 19 19:58:06.008 INFO [stdout] 470db0f2a5cd0fe185a25a6da08fa653b2b622f61b0177197a7a69a497748c22 Dec 19 19:58:06.010 INFO running `"docker" "start" "-a" "470db0f2a5cd0fe185a25a6da08fa653b2b622f61b0177197a7a69a497748c22"` Dec 19 19:58:06.825 INFO [stderr] Checking les v0.2.1 (/opt/crater/workdir) Dec 19 19:58:07.260 INFO [stderr] warning: unused import: `std::io::stdout` Dec 19 19:58:07.260 INFO [stderr] --> src/main.rs:8:5 Dec 19 19:58:07.260 INFO [stderr] | Dec 19 19:58:07.260 INFO [stderr] 8 | use std::io::stdout; Dec 19 19:58:07.260 INFO [stderr] | ^^^^^^^^^^^^^^^ Dec 19 19:58:07.260 INFO [stderr] | Dec 19 19:58:07.260 INFO [stderr] = note: #[warn(unused_imports)] on by default Dec 19 19:58:07.260 INFO [stderr] Dec 19 19:58:07.260 INFO [stderr] warning: unused import: `std::io::Write` Dec 19 19:58:07.260 INFO [stderr] --> src/les/mod.rs:2:5 Dec 19 19:58:07.260 INFO [stderr] | Dec 19 19:58:07.260 INFO [stderr] 2 | use std::io::Write; Dec 19 19:58:07.260 INFO [stderr] | ^^^^^^^^^^^^^^ Dec 19 19:58:07.260 INFO [stderr] Dec 19 19:58:07.260 INFO [stderr] warning: unused import: `decorate::Decorate` Dec 19 19:58:07.260 INFO [stderr] --> src/les/mod.rs:4:5 Dec 19 19:58:07.260 INFO [stderr] | Dec 19 19:58:07.260 INFO [stderr] 4 | use decorate::Decorate; Dec 19 19:58:07.260 INFO [stderr] | ^^^^^^^^^^^^^^^^^^ Dec 19 19:58:07.260 INFO [stderr] Dec 19 19:58:07.260 INFO [stderr] warning: unused import: `paintitems::PaintItems` Dec 19 19:58:07.260 INFO [stderr] --> src/les/mod.rs:5:5 Dec 19 19:58:07.260 INFO [stderr] | Dec 19 19:58:07.260 INFO [stderr] 5 | use paintitems::PaintItems; Dec 19 19:58:07.260 INFO [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ Dec 19 19:58:07.260 INFO [stderr] Dec 19 19:58:07.260 INFO [stderr] warning: unused imports: `Stdout`, `stdout` Dec 19 19:58:07.260 INFO [stderr] --> src/io/mod.rs:1:15 Dec 19 19:58:07.260 INFO [stderr] | Dec 19 19:58:07.260 INFO [stderr] 1 | use std::io::{Stdout,stdout}; Dec 19 19:58:07.260 INFO [stderr] | ^^^^^^ ^^^^^^ Dec 19 19:58:07.260 INFO [stderr] Dec 19 19:58:07.260 INFO [stderr] warning: unused import: `min` Dec 19 19:58:07.260 INFO [stderr] --> src/io/mod.rs:2:16 Dec 19 19:58:07.260 INFO [stderr] | Dec 19 19:58:07.260 INFO [stderr] 2 | use std::cmp::{min,max}; Dec 19 19:58:07.260 INFO [stderr] | ^^^ Dec 19 19:58:07.260 INFO [stderr] Dec 19 19:58:07.260 INFO [stderr] warning: unused import: `std::str::FromStr` Dec 19 19:58:07.260 INFO [stderr] --> src/decorate/mod.rs:8:5 Dec 19 19:58:07.260 INFO [stderr] | Dec 19 19:58:07.260 INFO [stderr] 8 | use std::str::FromStr; Dec 19 19:58:07.260 INFO [stderr] | ^^^^^^^^^^^^^^^^^ Dec 19 19:58:07.260 INFO [stderr] Dec 19 19:58:07.272 INFO [stderr] warning: unused import: `std::io::stdout` Dec 19 19:58:07.272 INFO [stderr] --> src/main.rs:8:5 Dec 19 19:58:07.272 INFO [stderr] | Dec 19 19:58:07.272 INFO [stderr] 8 | use std::io::stdout; Dec 19 19:58:07.272 INFO [stderr] | ^^^^^^^^^^^^^^^ Dec 19 19:58:07.272 INFO [stderr] | Dec 19 19:58:07.272 INFO [stderr] = note: #[warn(unused_imports)] on by default Dec 19 19:58:07.272 INFO [stderr] Dec 19 19:58:07.272 INFO [stderr] warning: unused import: `std::io::Write` Dec 19 19:58:07.272 INFO [stderr] --> src/les/mod.rs:2:5 Dec 19 19:58:07.272 INFO [stderr] | Dec 19 19:58:07.272 INFO [stderr] 2 | use std::io::Write; Dec 19 19:58:07.272 INFO [stderr] | ^^^^^^^^^^^^^^ Dec 19 19:58:07.272 INFO [stderr] Dec 19 19:58:07.272 INFO [stderr] warning: unused import: `decorate::Decorate` Dec 19 19:58:07.272 INFO [stderr] --> src/les/mod.rs:4:5 Dec 19 19:58:07.272 INFO [stderr] | Dec 19 19:58:07.272 INFO [stderr] 4 | use decorate::Decorate; Dec 19 19:58:07.272 INFO [stderr] | ^^^^^^^^^^^^^^^^^^ Dec 19 19:58:07.272 INFO [stderr] Dec 19 19:58:07.272 INFO [stderr] warning: unused import: `paintitems::PaintItems` Dec 19 19:58:07.272 INFO [stderr] --> src/les/mod.rs:5:5 Dec 19 19:58:07.272 INFO [stderr] | Dec 19 19:58:07.272 INFO [stderr] 5 | use paintitems::PaintItems; Dec 19 19:58:07.272 INFO [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ Dec 19 19:58:07.272 INFO [stderr] Dec 19 19:58:07.272 INFO [stderr] warning: unused import: `std` Dec 19 19:58:07.272 INFO [stderr] --> src/les/mod.rs:43:9 Dec 19 19:58:07.272 INFO [stderr] | Dec 19 19:58:07.272 INFO [stderr] 43 | use std; Dec 19 19:58:07.272 INFO [stderr] | ^^^ Dec 19 19:58:07.272 INFO [stderr] Dec 19 19:58:07.272 INFO [stderr] warning: unused imports: `Stdout`, `stdout` Dec 19 19:58:07.272 INFO [stderr] --> src/io/mod.rs:1:15 Dec 19 19:58:07.272 INFO [stderr] | Dec 19 19:58:07.272 INFO [stderr] 1 | use std::io::{Stdout,stdout}; Dec 19 19:58:07.272 INFO [stderr] | ^^^^^^ ^^^^^^ Dec 19 19:58:07.272 INFO [stderr] Dec 19 19:58:07.272 INFO [stderr] warning: unused import: `min` Dec 19 19:58:07.272 INFO [stderr] --> src/io/mod.rs:2:16 Dec 19 19:58:07.272 INFO [stderr] | Dec 19 19:58:07.272 INFO [stderr] 2 | use std::cmp::{min,max}; Dec 19 19:58:07.272 INFO [stderr] | ^^^ Dec 19 19:58:07.272 INFO [stderr] Dec 19 19:58:07.272 INFO [stderr] warning: unused import: `std::str::FromStr` Dec 19 19:58:07.272 INFO [stderr] --> src/decorate/mod.rs:8:5 Dec 19 19:58:07.272 INFO [stderr] | Dec 19 19:58:07.273 INFO [stderr] 8 | use std::str::FromStr; Dec 19 19:58:07.273 INFO [stderr] | ^^^^^^^^^^^^^^^^^ Dec 19 19:58:07.273 INFO [stderr] Dec 19 19:58:07.496 INFO [stderr] warning: unused variable: `inodes_count` Dec 19 19:58:07.496 INFO [stderr] --> src/io/mod.rs:27:13 Dec 19 19:58:07.496 INFO [stderr] | Dec 19 19:58:07.496 INFO [stderr] 27 | let inodes_count = inodes.len(); Dec 19 19:58:07.496 INFO [stderr] | ^^^^^^^^^^^^ help: consider using `_inodes_count` instead Dec 19 19:58:07.496 INFO [stderr] | Dec 19 19:58:07.496 INFO [stderr] = note: #[warn(unused_variables)] on by default Dec 19 19:58:07.496 INFO [stderr] Dec 19 19:58:07.496 INFO [stderr] warning: value assigned to `prev_item_length` is never read Dec 19 19:58:07.496 INFO [stderr] --> src/io/mod.rs:73:21 Dec 19 19:58:07.496 INFO [stderr] | Dec 19 19:58:07.496 INFO [stderr] 73 | let mut prev_item_length = 0; Dec 19 19:58:07.496 INFO [stderr] | ^^^^^^^^^^^^^^^^ Dec 19 19:58:07.496 INFO [stderr] | Dec 19 19:58:07.496 INFO [stderr] = note: #[warn(unused_assignments)] on by default Dec 19 19:58:07.496 INFO [stderr] = help: maybe it is overwritten before being read? Dec 19 19:58:07.496 INFO [stderr] Dec 19 19:58:07.530 INFO [stderr] warning: variable does not need to be mutable Dec 19 19:58:07.530 INFO [stderr] --> src/io/mod.rs:120:13 Dec 19 19:58:07.530 INFO [stderr] | Dec 19 19:58:07.530 INFO [stderr] 120 | let mut visible_items = paint_items.get_visible(); Dec 19 19:58:07.530 INFO [stderr] | ----^^^^^^^^^^^^^ Dec 19 19:58:07.530 INFO [stderr] | | Dec 19 19:58:07.530 INFO [stderr] | help: remove this `mut` Dec 19 19:58:07.530 INFO [stderr] | Dec 19 19:58:07.530 INFO [stderr] = note: #[warn(unused_mut)] on by default Dec 19 19:58:07.530 INFO [stderr] Dec 19 19:58:07.536 INFO [stderr] warning: unused variable: `decorator` Dec 19 19:58:07.536 INFO [stderr] --> src/les/mod.rs:53:13 Dec 19 19:58:07.536 INFO [stderr] | Dec 19 19:58:07.536 INFO [stderr] 53 | let decorator = decorate::Decorate::new(None); Dec 19 19:58:07.536 INFO [stderr] | ^^^^^^^^^ help: consider using `_decorator` instead Dec 19 19:58:07.536 INFO [stderr] | Dec 19 19:58:07.536 INFO [stderr] = note: #[warn(unused_variables)] on by default Dec 19 19:58:07.536 INFO [stderr] Dec 19 19:58:07.536 INFO [stderr] warning: unused variable: `inodes_count` Dec 19 19:58:07.536 INFO [stderr] --> src/io/mod.rs:27:13 Dec 19 19:58:07.536 INFO [stderr] | Dec 19 19:58:07.536 INFO [stderr] 27 | let inodes_count = inodes.len(); Dec 19 19:58:07.536 INFO [stderr] | ^^^^^^^^^^^^ help: consider using `_inodes_count` instead Dec 19 19:58:07.537 INFO [stderr] Dec 19 19:58:07.537 INFO [stderr] warning: value assigned to `prev_item_length` is never read Dec 19 19:58:07.537 INFO [stderr] --> src/io/mod.rs:73:21 Dec 19 19:58:07.537 INFO [stderr] | Dec 19 19:58:07.537 INFO [stderr] 73 | let mut prev_item_length = 0; Dec 19 19:58:07.537 INFO [stderr] | ^^^^^^^^^^^^^^^^ Dec 19 19:58:07.537 INFO [stderr] | Dec 19 19:58:07.537 INFO [stderr] = note: #[warn(unused_assignments)] on by default Dec 19 19:58:07.537 INFO [stderr] = help: maybe it is overwritten before being read? Dec 19 19:58:07.537 INFO [stderr] Dec 19 19:58:07.552 INFO [stderr] warning: field is never used: `path` Dec 19 19:58:07.552 INFO [stderr] --> src/fs/mod.rs:92:5 Dec 19 19:58:07.552 INFO [stderr] | Dec 19 19:58:07.552 INFO [stderr] 92 | path: String Dec 19 19:58:07.552 INFO [stderr] | ^^^^^^^^^^^^ Dec 19 19:58:07.552 INFO [stderr] | Dec 19 19:58:07.552 INFO [stderr] = note: #[warn(dead_code)] on by default Dec 19 19:58:07.552 INFO [stderr] Dec 19 19:58:07.552 INFO [stderr] warning: method is never used: `get_path` Dec 19 19:58:07.552 INFO [stderr] --> src/fs/mod.rs:117:5 Dec 19 19:58:07.552 INFO [stderr] | Dec 19 19:58:07.552 INFO [stderr] 117 | pub fn get_path(&self) -> String { Dec 19 19:58:07.552 INFO [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Dec 19 19:58:07.552 INFO [stderr] Dec 19 19:58:07.552 INFO [stderr] warning: comparison is useless due to type limits Dec 19 19:58:07.552 INFO [stderr] --> src/paintitems/mod.rs:25:41 Dec 19 19:58:07.552 INFO [stderr] | Dec 19 19:58:07.552 INFO [stderr] 25 | if index >= self.items.len() || index < 0 { Dec 19 19:58:07.552 INFO [stderr] | ^^^^^^^^^ Dec 19 19:58:07.552 INFO [stderr] | Dec 19 19:58:07.552 INFO [stderr] = note: #[warn(unused_comparisons)] on by default Dec 19 19:58:07.552 INFO [stderr] Dec 19 19:58:07.565 INFO [stderr] warning: variable does not need to be mutable Dec 19 19:58:07.565 INFO [stderr] --> src/io/mod.rs:120:13 Dec 19 19:58:07.565 INFO [stderr] | Dec 19 19:58:07.565 INFO [stderr] 120 | let mut visible_items = paint_items.get_visible(); Dec 19 19:58:07.565 INFO [stderr] | ----^^^^^^^^^^^^^ Dec 19 19:58:07.565 INFO [stderr] | | Dec 19 19:58:07.565 INFO [stderr] | help: remove this `mut` Dec 19 19:58:07.572 INFO [stderr] | Dec 19 19:58:07.572 INFO [stderr] = note: #[warn(unused_mut)] on by default Dec 19 19:58:07.572 INFO [stderr] Dec 19 19:58:07.608 INFO [stderr] warning: field is never used: `path` Dec 19 19:58:07.608 INFO [stderr] --> src/fs/mod.rs:92:5 Dec 19 19:58:07.608 INFO [stderr] | Dec 19 19:58:07.608 INFO [stderr] 92 | path: String Dec 19 19:58:07.608 INFO [stderr] | ^^^^^^^^^^^^ Dec 19 19:58:07.608 INFO [stderr] | Dec 19 19:58:07.608 INFO [stderr] = note: #[warn(dead_code)] on by default Dec 19 19:58:07.608 INFO [stderr] Dec 19 19:58:07.609 INFO [stderr] warning: method is never used: `get_path` Dec 19 19:58:07.609 INFO [stderr] --> src/fs/mod.rs:117:5 Dec 19 19:58:07.609 INFO [stderr] | Dec 19 19:58:07.609 INFO [stderr] 117 | pub fn get_path(&self) -> String { Dec 19 19:58:07.609 INFO [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Dec 19 19:58:07.609 INFO [stderr] Dec 19 19:58:07.609 INFO [stderr] warning: variable `licenseItem` should have a snake case name such as `license_item` Dec 19 19:58:07.609 INFO [stderr] --> src/style/mod.rs:67:13 Dec 19 19:58:07.609 INFO [stderr] | Dec 19 19:58:07.609 INFO [stderr] 67 | let licenseItem = PaintItem{ Dec 19 19:58:07.609 INFO [stderr] | ^^^^^^^^^^^ Dec 19 19:58:07.609 INFO [stderr] | Dec 19 19:58:07.609 INFO [stderr] = note: #[warn(non_snake_case)] on by default Dec 19 19:58:07.609 INFO [stderr] Dec 19 19:58:07.609 INFO [stderr] warning: variable `licenseItem` should have a snake case name such as `license_item` Dec 19 19:58:07.609 INFO [stderr] --> src/style/mod.rs:83:13 Dec 19 19:58:07.609 INFO [stderr] | Dec 19 19:58:07.609 INFO [stderr] 83 | let licenseItem = PaintItem{ Dec 19 19:58:07.609 INFO [stderr] | ^^^^^^^^^^^ Dec 19 19:58:07.609 INFO [stderr] Dec 19 19:58:07.609 INFO [stderr] warning: function `it_returns_a_Paint_Item` should have a snake case name such as `it_returns_a_paint_item` Dec 19 19:58:07.609 INFO [stderr] --> src/decorate/mod.rs:201:5 Dec 19 19:58:07.609 INFO [stderr] | Dec 19 19:58:07.609 INFO [stderr] 201 | / fn it_returns_a_Paint_Item() { Dec 19 19:58:07.609 INFO [stderr] 202 | | Dec 19 19:58:07.609 INFO [stderr] 203 | | let file = File::new( Dec 19 19:58:07.609 INFO [stderr] 204 | | String::from("filename"), Dec 19 19:58:07.609 INFO [stderr] ... | Dec 19 19:58:07.609 INFO [stderr] 222 | | assert_eq!(paint_item, expected_result); Dec 19 19:58:07.609 INFO [stderr] 223 | | } Dec 19 19:58:07.609 INFO [stderr] | |_____^ Dec 19 19:58:07.609 INFO [stderr] Dec 19 19:58:07.611 INFO [stderr] warning: comparison is useless due to type limits Dec 19 19:58:07.611 INFO [stderr] --> src/paintitems/mod.rs:25:41 Dec 19 19:58:07.611 INFO [stderr] | Dec 19 19:58:07.611 INFO [stderr] 25 | if index >= self.items.len() || index < 0 { Dec 19 19:58:07.611 INFO [stderr] | ^^^^^^^^^ Dec 19 19:58:07.611 INFO [stderr] | Dec 19 19:58:07.611 INFO [stderr] = note: #[warn(unused_comparisons)] on by default Dec 19 19:58:07.611 INFO [stderr] Dec 19 19:58:07.636 INFO [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.90s Dec 19 19:58:08.108 INFO running `"docker" "inspect" "470db0f2a5cd0fe185a25a6da08fa653b2b622f61b0177197a7a69a497748c22"` Dec 19 19:58:08.336 INFO running `"docker" "rm" "-f" "470db0f2a5cd0fe185a25a6da08fa653b2b622f61b0177197a7a69a497748c22"` Dec 19 19:58:08.568 INFO [stdout] 470db0f2a5cd0fe185a25a6da08fa653b2b622f61b0177197a7a69a497748c22