Dec 11 10:07:52.390 INFO checking saterus/gilded-rose-rust against master#3a75e80557a103497cffbcab395a2f37061a77ea for pr-56677 Dec 11 10:07:52.390 INFO running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/pr-56677/worker-1/master#3a75e80557a103497cffbcab395a2f37061a77ea:/target:rw,Z" "-v" "/mnt/big/crater/work/local/test-source/worker-1/pr-56677/master#3a75e80557a103497cffbcab395a2f37061a77ea:/source:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/source" "-e" "USER_ID=1000" "-e" "CMD=cargo +3a75e80557a103497cffbcab395a2f37061a77ea-alt check --frozen --all --all-targets" "-e" "CARGO_TARGET_DIR=/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/cargo-home" "-e" "RUSTUP_HOME=/rustup-home" "-m" "1536M" "--network" "none" "crater"` Dec 11 10:07:52.773 INFO [stdout] a7ba8c70083e41d96447e2c626bbc7c230553a577218ee538ddcaf5e2ee8067c Dec 11 10:07:52.778 INFO running `"docker" "start" "-a" "a7ba8c70083e41d96447e2c626bbc7c230553a577218ee538ddcaf5e2ee8067c"` Dec 11 10:07:54.108 INFO [stderr] usermod: no changes Dec 11 10:07:54.184 INFO [stderr] Checking gilded_rose v0.1.0 (/source) Dec 11 10:07:55.008 INFO [stderr] warning: unnecessary parentheses around `if` condition Dec 11 10:07:55.009 INFO [stderr] --> src/main.rs:32:12 Dec 11 10:07:55.009 INFO [stderr] | Dec 11 10:07:55.009 INFO [stderr] 32 | if (items[i].name != "Aged Brie" && items[i].name != "Backstage passes to a TAFKAL80ETC concert") Dec 11 10:07:55.009 INFO [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Dec 11 10:07:55.009 INFO [stderr] | Dec 11 10:07:55.009 INFO [stderr] = note: #[warn(unused_parens)] on by default Dec 11 10:07:55.009 INFO [stderr] Dec 11 10:07:55.009 INFO [stderr] warning: unnecessary parentheses around `if` condition Dec 11 10:07:55.009 INFO [stderr] --> src/main.rs:34:16 Dec 11 10:07:55.009 INFO [stderr] | Dec 11 10:07:55.009 INFO [stderr] 34 | if (items[i].quality > 0) Dec 11 10:07:55.009 INFO [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Dec 11 10:07:55.009 INFO [stderr] Dec 11 10:07:55.009 INFO [stderr] warning: unnecessary parentheses around `if` condition Dec 11 10:07:55.009 INFO [stderr] --> src/main.rs:36:20 Dec 11 10:07:55.009 INFO [stderr] | Dec 11 10:07:55.009 INFO [stderr] 36 | if (items[i].name != "Sulfuras, Hand of Ragnaros") Dec 11 10:07:55.009 INFO [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Dec 11 10:07:55.009 INFO [stderr] Dec 11 10:07:55.009 INFO [stderr] warning: unnecessary parentheses around `if` condition Dec 11 10:07:55.009 INFO [stderr] --> src/main.rs:44:16 Dec 11 10:07:55.009 INFO [stderr] | Dec 11 10:07:55.009 INFO [stderr] 44 | if (items[i].quality < 50) Dec 11 10:07:55.009 INFO [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Dec 11 10:07:55.009 INFO [stderr] Dec 11 10:07:55.009 INFO [stderr] warning: unnecessary parentheses around `if` condition Dec 11 10:07:55.009 INFO [stderr] --> src/main.rs:48:20 Dec 11 10:07:55.009 INFO [stderr] | Dec 11 10:07:55.009 INFO [stderr] 48 | if (items[i].name == "Backstage passes to a TAFKAL80ETC concert") Dec 11 10:07:55.009 INFO [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Dec 11 10:07:55.009 INFO [stderr] Dec 11 10:07:55.009 INFO [stderr] warning: unnecessary parentheses around `if` condition Dec 11 10:07:55.009 INFO [stderr] --> src/main.rs:50:24 Dec 11 10:07:55.009 INFO [stderr] | Dec 11 10:07:55.009 INFO [stderr] 50 | if (items[i].sell_in < 11) Dec 11 10:07:55.009 INFO [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Dec 11 10:07:55.009 INFO [stderr] Dec 11 10:07:55.009 INFO [stderr] warning: unnecessary parentheses around `if` condition Dec 11 10:07:55.009 INFO [stderr] --> src/main.rs:52:28 Dec 11 10:07:55.009 INFO [stderr] | Dec 11 10:07:55.009 INFO [stderr] 52 | if (items[i].quality < 50) Dec 11 10:07:55.009 INFO [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Dec 11 10:07:55.009 INFO [stderr] Dec 11 10:07:55.009 INFO [stderr] warning: unnecessary parentheses around `if` condition Dec 11 10:07:55.009 INFO [stderr] --> src/main.rs:58:24 Dec 11 10:07:55.009 INFO [stderr] | Dec 11 10:07:55.009 INFO [stderr] 58 | if (items[i].sell_in < 6) Dec 11 10:07:55.009 INFO [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Dec 11 10:07:55.009 INFO [stderr] Dec 11 10:07:55.009 INFO [stderr] warning: unnecessary parentheses around `if` condition Dec 11 10:07:55.009 INFO [stderr] --> src/main.rs:60:28 Dec 11 10:07:55.009 INFO [stderr] | Dec 11 10:07:55.009 INFO [stderr] 60 | if (items[i].quality < 50) Dec 11 10:07:55.009 INFO [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Dec 11 10:07:55.009 INFO [stderr] Dec 11 10:07:55.009 INFO [stderr] warning: unnecessary parentheses around `if` condition Dec 11 10:07:55.009 INFO [stderr] --> src/main.rs:69:12 Dec 11 10:07:55.009 INFO [stderr] | Dec 11 10:07:55.009 INFO [stderr] 69 | if (items[i].name != "Sulfuras, Hand of Ragnaros") Dec 11 10:07:55.009 INFO [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Dec 11 10:07:55.009 INFO [stderr] Dec 11 10:07:55.009 INFO [stderr] warning: unnecessary parentheses around `if` condition Dec 11 10:07:55.009 INFO [stderr] --> src/main.rs:74:12 Dec 11 10:07:55.009 INFO [stderr] | Dec 11 10:07:55.009 INFO [stderr] 74 | if (items[i].sell_in < 0) Dec 11 10:07:55.009 INFO [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Dec 11 10:07:55.009 INFO [stderr] Dec 11 10:07:55.009 INFO [stderr] warning: unnecessary parentheses around `if` condition Dec 11 10:07:55.009 INFO [stderr] --> src/main.rs:76:16 Dec 11 10:07:55.009 INFO [stderr] | Dec 11 10:07:55.009 INFO [stderr] 76 | if (items[i].name != "Aged Brie") Dec 11 10:07:55.009 INFO [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Dec 11 10:07:55.009 INFO [stderr] Dec 11 10:07:55.009 INFO [stderr] warning: unnecessary parentheses around `if` condition Dec 11 10:07:55.009 INFO [stderr] --> src/main.rs:78:20 Dec 11 10:07:55.009 INFO [stderr] | Dec 11 10:07:55.009 INFO [stderr] 78 | if (items[i].name != "Backstage passes to a TAFKAL80ETC concert") Dec 11 10:07:55.009 INFO [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Dec 11 10:07:55.009 INFO [stderr] Dec 11 10:07:55.009 INFO [stderr] warning: unnecessary parentheses around `if` condition Dec 11 10:07:55.009 INFO [stderr] --> src/main.rs:80:24 Dec 11 10:07:55.009 INFO [stderr] | Dec 11 10:07:55.009 INFO [stderr] 80 | if (items[i].quality > 0) Dec 11 10:07:55.009 INFO [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Dec 11 10:07:55.010 INFO [stderr] Dec 11 10:07:55.010 INFO [stderr] warning: unnecessary parentheses around `if` condition Dec 11 10:07:55.010 INFO [stderr] --> src/main.rs:82:28 Dec 11 10:07:55.010 INFO [stderr] | Dec 11 10:07:55.010 INFO [stderr] 82 | if (items[i].name != "Sulfuras, Hand of Ragnaros") Dec 11 10:07:55.010 INFO [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Dec 11 10:07:55.010 INFO [stderr] Dec 11 10:07:55.010 INFO [stderr] warning: unnecessary parentheses around `if` condition Dec 11 10:07:55.010 INFO [stderr] --> src/main.rs:95:20 Dec 11 10:07:55.010 INFO [stderr] | Dec 11 10:07:55.010 INFO [stderr] 95 | if (items[i].quality < 50) Dec 11 10:07:55.010 INFO [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Dec 11 10:07:55.010 INFO [stderr] Dec 11 10:07:55.104 INFO [stderr] warning: function `UpdateQuality` should have a snake case name such as `update_quality` Dec 11 10:07:55.104 INFO [stderr] --> src/main.rs:28:1 Dec 11 10:07:55.104 INFO [stderr] | Dec 11 10:07:55.104 INFO [stderr] 28 | / fn UpdateQuality(items: &mut [Item]) Dec 11 10:07:55.104 INFO [stderr] 29 | | { Dec 11 10:07:55.104 INFO [stderr] 30 | | for i in 0..items.len() Dec 11 10:07:55.104 INFO [stderr] 31 | | { Dec 11 10:07:55.104 INFO [stderr] ... | Dec 11 10:07:55.104 INFO [stderr] 101 | | } Dec 11 10:07:55.104 INFO [stderr] 102 | | } Dec 11 10:07:55.104 INFO [stderr] | |_^ Dec 11 10:07:55.104 INFO [stderr] | Dec 11 10:07:55.104 INFO [stderr] = note: #[warn(non_snake_case)] on by default Dec 11 10:07:55.104 INFO [stderr] Dec 11 10:07:55.151 INFO [stderr] warning: unnecessary parentheses around `if` condition Dec 11 10:07:55.151 INFO [stderr] --> src/main.rs:32:12 Dec 11 10:07:55.151 INFO [stderr] | Dec 11 10:07:55.151 INFO [stderr] 32 | if (items[i].name != "Aged Brie" && items[i].name != "Backstage passes to a TAFKAL80ETC concert") Dec 11 10:07:55.151 INFO [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Dec 11 10:07:55.151 INFO [stderr] | Dec 11 10:07:55.151 INFO [stderr] = note: #[warn(unused_parens)] on by default Dec 11 10:07:55.151 INFO [stderr] Dec 11 10:07:55.151 INFO [stderr] warning: unnecessary parentheses around `if` condition Dec 11 10:07:55.151 INFO [stderr] --> src/main.rs:34:16 Dec 11 10:07:55.151 INFO [stderr] | Dec 11 10:07:55.151 INFO [stderr] 34 | if (items[i].quality > 0) Dec 11 10:07:55.152 INFO [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Dec 11 10:07:55.152 INFO [stderr] Dec 11 10:07:55.152 INFO [stderr] warning: unnecessary parentheses around `if` condition Dec 11 10:07:55.152 INFO [stderr] --> src/main.rs:36:20 Dec 11 10:07:55.152 INFO [stderr] | Dec 11 10:07:55.152 INFO [stderr] 36 | if (items[i].name != "Sulfuras, Hand of Ragnaros") Dec 11 10:07:55.152 INFO [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Dec 11 10:07:55.152 INFO [stderr] Dec 11 10:07:55.152 INFO [stderr] warning: unnecessary parentheses around `if` condition Dec 11 10:07:55.152 INFO [stderr] --> src/main.rs:44:16 Dec 11 10:07:55.152 INFO [stderr] | Dec 11 10:07:55.152 INFO [stderr] 44 | if (items[i].quality < 50) Dec 11 10:07:55.152 INFO [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Dec 11 10:07:55.152 INFO [stderr] Dec 11 10:07:55.152 INFO [stderr] warning: unnecessary parentheses around `if` condition Dec 11 10:07:55.152 INFO [stderr] --> src/main.rs:48:20 Dec 11 10:07:55.152 INFO [stderr] | Dec 11 10:07:55.152 INFO [stderr] 48 | if (items[i].name == "Backstage passes to a TAFKAL80ETC concert") Dec 11 10:07:55.152 INFO [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Dec 11 10:07:55.152 INFO [stderr] Dec 11 10:07:55.152 INFO [stderr] warning: unnecessary parentheses around `if` condition Dec 11 10:07:55.152 INFO [stderr] --> src/main.rs:50:24 Dec 11 10:07:55.152 INFO [stderr] | Dec 11 10:07:55.152 INFO [stderr] 50 | if (items[i].sell_in < 11) Dec 11 10:07:55.152 INFO [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Dec 11 10:07:55.152 INFO [stderr] Dec 11 10:07:55.152 INFO [stderr] warning: unnecessary parentheses around `if` condition Dec 11 10:07:55.152 INFO [stderr] --> src/main.rs:52:28 Dec 11 10:07:55.152 INFO [stderr] | Dec 11 10:07:55.152 INFO [stderr] 52 | if (items[i].quality < 50) Dec 11 10:07:55.152 INFO [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Dec 11 10:07:55.152 INFO [stderr] Dec 11 10:07:55.152 INFO [stderr] warning: unnecessary parentheses around `if` condition Dec 11 10:07:55.152 INFO [stderr] --> src/main.rs:58:24 Dec 11 10:07:55.152 INFO [stderr] | Dec 11 10:07:55.152 INFO [stderr] 58 | if (items[i].sell_in < 6) Dec 11 10:07:55.152 INFO [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Dec 11 10:07:55.152 INFO [stderr] Dec 11 10:07:55.152 INFO [stderr] warning: unnecessary parentheses around `if` condition Dec 11 10:07:55.152 INFO [stderr] --> src/main.rs:60:28 Dec 11 10:07:55.152 INFO [stderr] | Dec 11 10:07:55.152 INFO [stderr] 60 | if (items[i].quality < 50) Dec 11 10:07:55.152 INFO [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Dec 11 10:07:55.152 INFO [stderr] Dec 11 10:07:55.152 INFO [stderr] warning: unnecessary parentheses around `if` condition Dec 11 10:07:55.152 INFO [stderr] --> src/main.rs:69:12 Dec 11 10:07:55.152 INFO [stderr] | Dec 11 10:07:55.152 INFO [stderr] 69 | if (items[i].name != "Sulfuras, Hand of Ragnaros") Dec 11 10:07:55.152 INFO [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Dec 11 10:07:55.152 INFO [stderr] Dec 11 10:07:55.152 INFO [stderr] warning: unnecessary parentheses around `if` condition Dec 11 10:07:55.152 INFO [stderr] --> src/main.rs:74:12 Dec 11 10:07:55.152 INFO [stderr] | Dec 11 10:07:55.152 INFO [stderr] 74 | if (items[i].sell_in < 0) Dec 11 10:07:55.152 INFO [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Dec 11 10:07:55.152 INFO [stderr] Dec 11 10:07:55.152 INFO [stderr] warning: unnecessary parentheses around `if` condition Dec 11 10:07:55.152 INFO [stderr] --> src/main.rs:76:16 Dec 11 10:07:55.152 INFO [stderr] | Dec 11 10:07:55.152 INFO [stderr] 76 | if (items[i].name != "Aged Brie") Dec 11 10:07:55.152 INFO [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Dec 11 10:07:55.152 INFO [stderr] Dec 11 10:07:55.152 INFO [stderr] warning: unnecessary parentheses around `if` condition Dec 11 10:07:55.152 INFO [stderr] --> src/main.rs:78:20 Dec 11 10:07:55.156 INFO [stderr] | Dec 11 10:07:55.156 INFO [stderr] 78 | if (items[i].name != "Backstage passes to a TAFKAL80ETC concert") Dec 11 10:07:55.156 INFO [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Dec 11 10:07:55.156 INFO [stderr] Dec 11 10:07:55.156 INFO [stderr] warning: unnecessary parentheses around `if` condition Dec 11 10:07:55.156 INFO [stderr] --> src/main.rs:80:24 Dec 11 10:07:55.156 INFO [stderr] | Dec 11 10:07:55.156 INFO [stderr] 80 | if (items[i].quality > 0) Dec 11 10:07:55.156 INFO [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Dec 11 10:07:55.156 INFO [stderr] Dec 11 10:07:55.156 INFO [stderr] warning: unnecessary parentheses around `if` condition Dec 11 10:07:55.156 INFO [stderr] --> src/main.rs:82:28 Dec 11 10:07:55.156 INFO [stderr] | Dec 11 10:07:55.156 INFO [stderr] 82 | if (items[i].name != "Sulfuras, Hand of Ragnaros") Dec 11 10:07:55.156 INFO [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Dec 11 10:07:55.156 INFO [stderr] Dec 11 10:07:55.156 INFO [stderr] warning: unnecessary parentheses around `if` condition Dec 11 10:07:55.156 INFO [stderr] --> src/main.rs:95:20 Dec 11 10:07:55.156 INFO [stderr] | Dec 11 10:07:55.156 INFO [stderr] 95 | if (items[i].quality < 50) Dec 11 10:07:55.156 INFO [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Dec 11 10:07:55.156 INFO [stderr] Dec 11 10:07:55.228 INFO [stderr] warning: function `UpdateQuality` should have a snake case name such as `update_quality` Dec 11 10:07:55.228 INFO [stderr] --> src/main.rs:28:1 Dec 11 10:07:55.228 INFO [stderr] | Dec 11 10:07:55.228 INFO [stderr] 28 | / fn UpdateQuality(items: &mut [Item]) Dec 11 10:07:55.228 INFO [stderr] 29 | | { Dec 11 10:07:55.228 INFO [stderr] 30 | | for i in 0..items.len() Dec 11 10:07:55.228 INFO [stderr] 31 | | { Dec 11 10:07:55.228 INFO [stderr] ... | Dec 11 10:07:55.228 INFO [stderr] 101 | | } Dec 11 10:07:55.228 INFO [stderr] 102 | | } Dec 11 10:07:55.228 INFO [stderr] | |_^ Dec 11 10:07:55.228 INFO [stderr] | Dec 11 10:07:55.228 INFO [stderr] = note: #[warn(non_snake_case)] on by default Dec 11 10:07:55.228 INFO [stderr] Dec 11 10:07:55.256 INFO [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.12s Dec 11 10:07:55.259 INFO [stderr] su: No module specific data is present Dec 11 10:07:55.864 INFO running `"docker" "inspect" "a7ba8c70083e41d96447e2c626bbc7c230553a577218ee538ddcaf5e2ee8067c"` Dec 11 10:07:56.054 INFO running `"docker" "rm" "-f" "a7ba8c70083e41d96447e2c626bbc7c230553a577218ee538ddcaf5e2ee8067c"` Dec 11 10:07:56.274 INFO [stdout] a7ba8c70083e41d96447e2c626bbc7c230553a577218ee538ddcaf5e2ee8067c