Dec 04 10:47:15.336 INFO checking saterus/gilded-rose-rust against try#1df97983eb2057dc6a8f7eb364e263b51ae23230 for pr-56481 Dec 04 10:47:15.336 INFO running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/pr-56481/worker-2/try#1df97983eb2057dc6a8f7eb364e263b51ae23230:/target:rw,Z" "-v" "/mnt/big/crater/work/local/test-source/worker-2/pr-56481/try#1df97983eb2057dc6a8f7eb364e263b51ae23230:/source:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/source" "-e" "USER_ID=1000" "-e" "CMD=cargo +1df97983eb2057dc6a8f7eb364e263b51ae23230-alt check --frozen --all --all-targets" "-e" "CARGO_TARGET_DIR=/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/cargo-home" "-e" "RUSTUP_HOME=/rustup-home" "-m" "1536M" "--network" "none" "crater"` Dec 04 10:47:15.790 INFO [stdout] 3271ebb3953c778109463aa958ef95116265b21d2742f0a4af17c0993ccfd476 Dec 04 10:47:15.799 INFO running `"docker" "start" "-a" "3271ebb3953c778109463aa958ef95116265b21d2742f0a4af17c0993ccfd476"` Dec 04 10:47:17.347 INFO [stderr] usermod: no changes Dec 04 10:47:17.407 INFO [stderr] Checking gilded_rose v0.1.0 (/source) Dec 04 10:47:18.206 INFO [stderr] warning: unnecessary parentheses around `if` condition Dec 04 10:47:18.206 INFO [stderr] --> src/main.rs:32:12 Dec 04 10:47:18.206 INFO [stderr] | Dec 04 10:47:18.207 INFO [stderr] 32 | if (items[i].name != "Aged Brie" && items[i].name != "Backstage passes to a TAFKAL80ETC concert") Dec 04 10:47:18.207 INFO [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Dec 04 10:47:18.207 INFO [stderr] | Dec 04 10:47:18.208 INFO [stderr] = note: #[warn(unused_parens)] on by default Dec 04 10:47:18.208 INFO [stderr] Dec 04 10:47:18.208 INFO [stderr] warning: unnecessary parentheses around `if` condition Dec 04 10:47:18.209 INFO [stderr] --> src/main.rs:34:16 Dec 04 10:47:18.209 INFO [stderr] | Dec 04 10:47:18.209 INFO [stderr] 34 | if (items[i].quality > 0) Dec 04 10:47:18.209 INFO [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Dec 04 10:47:18.210 INFO [stderr] Dec 04 10:47:18.210 INFO [stderr] warning: unnecessary parentheses around `if` condition Dec 04 10:47:18.210 INFO [stderr] --> src/main.rs:36:20 Dec 04 10:47:18.211 INFO [stderr] | Dec 04 10:47:18.211 INFO [stderr] 36 | if (items[i].name != "Sulfuras, Hand of Ragnaros") Dec 04 10:47:18.211 INFO [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Dec 04 10:47:18.211 INFO [stderr] Dec 04 10:47:18.212 INFO [stderr] warning: unnecessary parentheses around `if` condition Dec 04 10:47:18.212 INFO [stderr] --> src/main.rs:44:16 Dec 04 10:47:18.212 INFO [stderr] | Dec 04 10:47:18.213 INFO [stderr] 44 | if (items[i].quality < 50) Dec 04 10:47:18.213 INFO [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Dec 04 10:47:18.213 INFO [stderr] Dec 04 10:47:18.213 INFO [stderr] warning: unnecessary parentheses around `if` condition Dec 04 10:47:18.213 INFO [stderr] --> src/main.rs:48:20 Dec 04 10:47:18.213 INFO [stderr] | Dec 04 10:47:18.213 INFO [stderr] 48 | if (items[i].name == "Backstage passes to a TAFKAL80ETC concert") Dec 04 10:47:18.213 INFO [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Dec 04 10:47:18.213 INFO [stderr] Dec 04 10:47:18.214 INFO [stderr] warning: unnecessary parentheses around `if` condition Dec 04 10:47:18.214 INFO [stderr] --> src/main.rs:50:24 Dec 04 10:47:18.214 INFO [stderr] | Dec 04 10:47:18.214 INFO [stderr] 50 | if (items[i].sell_in < 11) Dec 04 10:47:18.214 INFO [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Dec 04 10:47:18.214 INFO [stderr] Dec 04 10:47:18.214 INFO [stderr] warning: unnecessary parentheses around `if` condition Dec 04 10:47:18.215 INFO [stderr] --> src/main.rs:52:28 Dec 04 10:47:18.215 INFO [stderr] | Dec 04 10:47:18.215 INFO [stderr] 52 | if (items[i].quality < 50) Dec 04 10:47:18.215 INFO [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Dec 04 10:47:18.215 INFO [stderr] Dec 04 10:47:18.215 INFO [stderr] warning: unnecessary parentheses around `if` condition Dec 04 10:47:18.215 INFO [stderr] --> src/main.rs:58:24 Dec 04 10:47:18.215 INFO [stderr] | Dec 04 10:47:18.215 INFO [stderr] 58 | if (items[i].sell_in < 6) Dec 04 10:47:18.215 INFO [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Dec 04 10:47:18.215 INFO [stderr] Dec 04 10:47:18.216 INFO [stderr] warning: unnecessary parentheses around `if` condition Dec 04 10:47:18.216 INFO [stderr] --> src/main.rs:60:28 Dec 04 10:47:18.216 INFO [stderr] | Dec 04 10:47:18.216 INFO [stderr] 60 | if (items[i].quality < 50) Dec 04 10:47:18.216 INFO [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Dec 04 10:47:18.216 INFO [stderr] Dec 04 10:47:18.216 INFO [stderr] warning: unnecessary parentheses around `if` condition Dec 04 10:47:18.216 INFO [stderr] --> src/main.rs:69:12 Dec 04 10:47:18.216 INFO [stderr] | Dec 04 10:47:18.216 INFO [stderr] 69 | if (items[i].name != "Sulfuras, Hand of Ragnaros") Dec 04 10:47:18.216 INFO [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Dec 04 10:47:18.216 INFO [stderr] Dec 04 10:47:18.217 INFO [stderr] warning: unnecessary parentheses around `if` condition Dec 04 10:47:18.217 INFO [stderr] --> src/main.rs:74:12 Dec 04 10:47:18.217 INFO [stderr] | Dec 04 10:47:18.217 INFO [stderr] 74 | if (items[i].sell_in < 0) Dec 04 10:47:18.217 INFO [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Dec 04 10:47:18.217 INFO [stderr] Dec 04 10:47:18.217 INFO [stderr] warning: unnecessary parentheses around `if` condition Dec 04 10:47:18.217 INFO [stderr] --> src/main.rs:76:16 Dec 04 10:47:18.217 INFO [stderr] | Dec 04 10:47:18.217 INFO [stderr] 76 | if (items[i].name != "Aged Brie") Dec 04 10:47:18.217 INFO [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Dec 04 10:47:18.217 INFO [stderr] Dec 04 10:47:18.218 INFO [stderr] warning: unnecessary parentheses around `if` condition Dec 04 10:47:18.218 INFO [stderr] --> src/main.rs:78:20 Dec 04 10:47:18.218 INFO [stderr] | Dec 04 10:47:18.218 INFO [stderr] 78 | if (items[i].name != "Backstage passes to a TAFKAL80ETC concert") Dec 04 10:47:18.218 INFO [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Dec 04 10:47:18.218 INFO [stderr] Dec 04 10:47:18.218 INFO [stderr] warning: unnecessary parentheses around `if` condition Dec 04 10:47:18.218 INFO [stderr] --> src/main.rs:80:24 Dec 04 10:47:18.218 INFO [stderr] | Dec 04 10:47:18.219 INFO [stderr] 80 | if (items[i].quality > 0) Dec 04 10:47:18.219 INFO [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Dec 04 10:47:18.219 INFO [stderr] Dec 04 10:47:18.219 INFO [stderr] warning: unnecessary parentheses around `if` condition Dec 04 10:47:18.219 INFO [stderr] --> src/main.rs:82:28 Dec 04 10:47:18.219 INFO [stderr] | Dec 04 10:47:18.219 INFO [stderr] 82 | if (items[i].name != "Sulfuras, Hand of Ragnaros") Dec 04 10:47:18.219 INFO [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Dec 04 10:47:18.219 INFO [stderr] Dec 04 10:47:18.220 INFO [stderr] warning: unnecessary parentheses around `if` condition Dec 04 10:47:18.220 INFO [stderr] --> src/main.rs:95:20 Dec 04 10:47:18.220 INFO [stderr] | Dec 04 10:47:18.220 INFO [stderr] 95 | if (items[i].quality < 50) Dec 04 10:47:18.220 INFO [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Dec 04 10:47:18.220 INFO [stderr] Dec 04 10:47:18.257 INFO [stderr] warning: unnecessary parentheses around `if` condition Dec 04 10:47:18.257 INFO [stderr] --> src/main.rs:32:12 Dec 04 10:47:18.257 INFO [stderr] | Dec 04 10:47:18.258 INFO [stderr] 32 | if (items[i].name != "Aged Brie" && items[i].name != "Backstage passes to a TAFKAL80ETC concert") Dec 04 10:47:18.258 INFO [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Dec 04 10:47:18.258 INFO [stderr] | Dec 04 10:47:18.258 INFO [stderr] = note: #[warn(unused_parens)] on by default Dec 04 10:47:18.258 INFO [stderr] Dec 04 10:47:18.258 INFO [stderr] warning: unnecessary parentheses around `if` condition Dec 04 10:47:18.258 INFO [stderr] --> src/main.rs:34:16 Dec 04 10:47:18.258 INFO [stderr] | Dec 04 10:47:18.258 INFO [stderr] 34 | if (items[i].quality > 0) Dec 04 10:47:18.258 INFO [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Dec 04 10:47:18.258 INFO [stderr] Dec 04 10:47:18.258 INFO [stderr] warning: unnecessary parentheses around `if` condition Dec 04 10:47:18.258 INFO [stderr] --> src/main.rs:36:20 Dec 04 10:47:18.258 INFO [stderr] | Dec 04 10:47:18.258 INFO [stderr] 36 | if (items[i].name != "Sulfuras, Hand of Ragnaros") Dec 04 10:47:18.258 INFO [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Dec 04 10:47:18.258 INFO [stderr] Dec 04 10:47:18.258 INFO [stderr] warning: unnecessary parentheses around `if` condition Dec 04 10:47:18.258 INFO [stderr] --> src/main.rs:44:16 Dec 04 10:47:18.258 INFO [stderr] | Dec 04 10:47:18.258 INFO [stderr] 44 | if (items[i].quality < 50) Dec 04 10:47:18.258 INFO [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Dec 04 10:47:18.258 INFO [stderr] Dec 04 10:47:18.258 INFO [stderr] warning: unnecessary parentheses around `if` condition Dec 04 10:47:18.258 INFO [stderr] --> src/main.rs:48:20 Dec 04 10:47:18.258 INFO [stderr] | Dec 04 10:47:18.258 INFO [stderr] 48 | if (items[i].name == "Backstage passes to a TAFKAL80ETC concert") Dec 04 10:47:18.258 INFO [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Dec 04 10:47:18.258 INFO [stderr] Dec 04 10:47:18.259 INFO [stderr] warning: unnecessary parentheses around `if` condition Dec 04 10:47:18.259 INFO [stderr] --> src/main.rs:50:24 Dec 04 10:47:18.259 INFO [stderr] | Dec 04 10:47:18.259 INFO [stderr] 50 | if (items[i].sell_in < 11) Dec 04 10:47:18.260 INFO [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Dec 04 10:47:18.260 INFO [stderr] Dec 04 10:47:18.260 INFO [stderr] warning: unnecessary parentheses around `if` condition Dec 04 10:47:18.260 INFO [stderr] --> src/main.rs:52:28 Dec 04 10:47:18.260 INFO [stderr] | Dec 04 10:47:18.261 INFO [stderr] 52 | if (items[i].quality < 50) Dec 04 10:47:18.261 INFO [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Dec 04 10:47:18.261 INFO [stderr] Dec 04 10:47:18.261 INFO [stderr] warning: unnecessary parentheses around `if` condition Dec 04 10:47:18.262 INFO [stderr] --> src/main.rs:58:24 Dec 04 10:47:18.262 INFO [stderr] | Dec 04 10:47:18.262 INFO [stderr] 58 | if (items[i].sell_in < 6) Dec 04 10:47:18.262 INFO [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Dec 04 10:47:18.262 INFO [stderr] Dec 04 10:47:18.263 INFO [stderr] warning: unnecessary parentheses around `if` condition Dec 04 10:47:18.263 INFO [stderr] --> src/main.rs:60:28 Dec 04 10:47:18.263 INFO [stderr] | Dec 04 10:47:18.263 INFO [stderr] 60 | if (items[i].quality < 50) Dec 04 10:47:18.264 INFO [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Dec 04 10:47:18.264 INFO [stderr] Dec 04 10:47:18.264 INFO [stderr] warning: unnecessary parentheses around `if` condition Dec 04 10:47:18.264 INFO [stderr] --> src/main.rs:69:12 Dec 04 10:47:18.264 INFO [stderr] | Dec 04 10:47:18.265 INFO [stderr] 69 | if (items[i].name != "Sulfuras, Hand of Ragnaros") Dec 04 10:47:18.265 INFO [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Dec 04 10:47:18.265 INFO [stderr] Dec 04 10:47:18.265 INFO [stderr] warning: unnecessary parentheses around `if` condition Dec 04 10:47:18.266 INFO [stderr] --> src/main.rs:74:12 Dec 04 10:47:18.266 INFO [stderr] | Dec 04 10:47:18.266 INFO [stderr] 74 | if (items[i].sell_in < 0) Dec 04 10:47:18.266 INFO [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Dec 04 10:47:18.266 INFO [stderr] Dec 04 10:47:18.267 INFO [stderr] warning: unnecessary parentheses around `if` condition Dec 04 10:47:18.267 INFO [stderr] --> src/main.rs:76:16 Dec 04 10:47:18.267 INFO [stderr] | Dec 04 10:47:18.267 INFO [stderr] 76 | if (items[i].name != "Aged Brie") Dec 04 10:47:18.268 INFO [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Dec 04 10:47:18.268 INFO [stderr] Dec 04 10:47:18.268 INFO [stderr] warning: unnecessary parentheses around `if` condition Dec 04 10:47:18.268 INFO [stderr] --> src/main.rs:78:20 Dec 04 10:47:18.268 INFO [stderr] | Dec 04 10:47:18.269 INFO [stderr] 78 | if (items[i].name != "Backstage passes to a TAFKAL80ETC concert") Dec 04 10:47:18.269 INFO [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Dec 04 10:47:18.269 INFO [stderr] Dec 04 10:47:18.269 INFO [stderr] warning: unnecessary parentheses around `if` condition Dec 04 10:47:18.270 INFO [stderr] --> src/main.rs:80:24 Dec 04 10:47:18.270 INFO [stderr] | Dec 04 10:47:18.270 INFO [stderr] 80 | if (items[i].quality > 0) Dec 04 10:47:18.270 INFO [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Dec 04 10:47:18.270 INFO [stderr] Dec 04 10:47:18.270 INFO [stderr] warning: unnecessary parentheses around `if` condition Dec 04 10:47:18.270 INFO [stderr] --> src/main.rs:82:28 Dec 04 10:47:18.270 INFO [stderr] | Dec 04 10:47:18.270 INFO [stderr] 82 | if (items[i].name != "Sulfuras, Hand of Ragnaros") Dec 04 10:47:18.270 INFO [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Dec 04 10:47:18.270 INFO [stderr] Dec 04 10:47:18.270 INFO [stderr] warning: unnecessary parentheses around `if` condition Dec 04 10:47:18.270 INFO [stderr] --> src/main.rs:95:20 Dec 04 10:47:18.270 INFO [stderr] | Dec 04 10:47:18.270 INFO [stderr] 95 | if (items[i].quality < 50) Dec 04 10:47:18.270 INFO [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Dec 04 10:47:18.270 INFO [stderr] Dec 04 10:47:18.286 INFO [stderr] warning: function `UpdateQuality` should have a snake case name such as `update_quality` Dec 04 10:47:18.287 INFO [stderr] --> src/main.rs:28:1 Dec 04 10:47:18.287 INFO [stderr] | Dec 04 10:47:18.287 INFO [stderr] 28 | / fn UpdateQuality(items: &mut [Item]) Dec 04 10:47:18.287 INFO [stderr] 29 | | { Dec 04 10:47:18.288 INFO [stderr] 30 | | for i in 0..items.len() Dec 04 10:47:18.288 INFO [stderr] 31 | | { Dec 04 10:47:18.288 INFO [stderr] ... | Dec 04 10:47:18.288 INFO [stderr] 101 | | } Dec 04 10:47:18.289 INFO [stderr] 102 | | } Dec 04 10:47:18.289 INFO [stderr] | |_^ Dec 04 10:47:18.289 INFO [stderr] | Dec 04 10:47:18.290 INFO [stderr] = note: #[warn(non_snake_case)] on by default Dec 04 10:47:18.290 INFO [stderr] Dec 04 10:47:18.335 INFO [stderr] warning: function `UpdateQuality` should have a snake case name such as `update_quality` Dec 04 10:47:18.335 INFO [stderr] --> src/main.rs:28:1 Dec 04 10:47:18.335 INFO [stderr] | Dec 04 10:47:18.336 INFO [stderr] 28 | / fn UpdateQuality(items: &mut [Item]) Dec 04 10:47:18.336 INFO [stderr] 29 | | { Dec 04 10:47:18.336 INFO [stderr] 30 | | for i in 0..items.len() Dec 04 10:47:18.336 INFO [stderr] 31 | | { Dec 04 10:47:18.336 INFO [stderr] ... | Dec 04 10:47:18.337 INFO [stderr] 101 | | } Dec 04 10:47:18.337 INFO [stderr] 102 | | } Dec 04 10:47:18.337 INFO [stderr] | |_^ Dec 04 10:47:18.337 INFO [stderr] | Dec 04 10:47:18.337 INFO [stderr] = note: #[warn(non_snake_case)] on by default Dec 04 10:47:18.338 INFO [stderr] Dec 04 10:47:18.374 INFO [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.01s Dec 04 10:47:18.378 INFO [stderr] su: No module specific data is present Dec 04 10:47:19.196 INFO running `"docker" "inspect" "3271ebb3953c778109463aa958ef95116265b21d2742f0a4af17c0993ccfd476"` Dec 04 10:47:19.372 INFO running `"docker" "rm" "-f" "3271ebb3953c778109463aa958ef95116265b21d2742f0a4af17c0993ccfd476"` Dec 04 10:47:19.531 INFO [stdout] 3271ebb3953c778109463aa958ef95116265b21d2742f0a4af17c0993ccfd476