Dec 04 10:47:15.588 INFO checking saterus/gilded-rose-rust against master#c8ae2de8363be088604ffa2ccba84ff7ad7250bc for pr-56481 Dec 04 10:47:15.588 INFO running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/pr-56481/worker-5/master#c8ae2de8363be088604ffa2ccba84ff7ad7250bc:/target:rw,Z" "-v" "/mnt/big/crater/work/local/test-source/worker-5/pr-56481/master#c8ae2de8363be088604ffa2ccba84ff7ad7250bc:/source:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/source" "-e" "USER_ID=1000" "-e" "CMD=cargo +c8ae2de8363be088604ffa2ccba84ff7ad7250bc-alt check --frozen --all --all-targets" "-e" "CARGO_TARGET_DIR=/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/cargo-home" "-e" "RUSTUP_HOME=/rustup-home" "-m" "1536M" "--network" "none" "crater"` Dec 04 10:47:15.995 INFO [stdout] 185f27c43103f515cadd19a8b9c6329b8e59608744d60be12c98ae18d39c0796 Dec 04 10:47:15.997 INFO running `"docker" "start" "-a" "185f27c43103f515cadd19a8b9c6329b8e59608744d60be12c98ae18d39c0796"` Dec 04 10:47:17.663 INFO [stderr] usermod: no changes Dec 04 10:47:17.715 INFO [stderr] Checking gilded_rose v0.1.0 (/source) Dec 04 10:47:18.465 INFO [stderr] warning: unnecessary parentheses around `if` condition Dec 04 10:47:18.465 INFO [stderr] --> src/main.rs:32:12 Dec 04 10:47:18.465 INFO [stderr] | Dec 04 10:47:18.465 INFO [stderr] 32 | if (items[i].name != "Aged Brie" && items[i].name != "Backstage passes to a TAFKAL80ETC concert") Dec 04 10:47:18.465 INFO [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Dec 04 10:47:18.465 INFO [stderr] | Dec 04 10:47:18.465 INFO [stderr] = note: #[warn(unused_parens)] on by default Dec 04 10:47:18.465 INFO [stderr] Dec 04 10:47:18.465 INFO [stderr] warning: unnecessary parentheses around `if` condition Dec 04 10:47:18.465 INFO [stderr] --> src/main.rs:34:16 Dec 04 10:47:18.465 INFO [stderr] | Dec 04 10:47:18.465 INFO [stderr] 34 | if (items[i].quality > 0) Dec 04 10:47:18.465 INFO [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Dec 04 10:47:18.465 INFO [stderr] Dec 04 10:47:18.465 INFO [stderr] warning: unnecessary parentheses around `if` condition Dec 04 10:47:18.465 INFO [stderr] --> src/main.rs:36:20 Dec 04 10:47:18.465 INFO [stderr] | Dec 04 10:47:18.465 INFO [stderr] 36 | if (items[i].name != "Sulfuras, Hand of Ragnaros") Dec 04 10:47:18.465 INFO [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Dec 04 10:47:18.465 INFO [stderr] Dec 04 10:47:18.465 INFO [stderr] warning: unnecessary parentheses around `if` condition Dec 04 10:47:18.465 INFO [stderr] --> src/main.rs:44:16 Dec 04 10:47:18.465 INFO [stderr] | Dec 04 10:47:18.465 INFO [stderr] 44 | if (items[i].quality < 50) Dec 04 10:47:18.465 INFO [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Dec 04 10:47:18.465 INFO [stderr] Dec 04 10:47:18.465 INFO [stderr] warning: unnecessary parentheses around `if` condition Dec 04 10:47:18.465 INFO [stderr] --> src/main.rs:48:20 Dec 04 10:47:18.465 INFO [stderr] | Dec 04 10:47:18.465 INFO [stderr] 48 | if (items[i].name == "Backstage passes to a TAFKAL80ETC concert") Dec 04 10:47:18.465 INFO [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Dec 04 10:47:18.466 INFO [stderr] Dec 04 10:47:18.466 INFO [stderr] warning: unnecessary parentheses around `if` condition Dec 04 10:47:18.466 INFO [stderr] --> src/main.rs:50:24 Dec 04 10:47:18.466 INFO [stderr] | Dec 04 10:47:18.466 INFO [stderr] 50 | if (items[i].sell_in < 11) Dec 04 10:47:18.466 INFO [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Dec 04 10:47:18.466 INFO [stderr] Dec 04 10:47:18.466 INFO [stderr] warning: unnecessary parentheses around `if` condition Dec 04 10:47:18.466 INFO [stderr] --> src/main.rs:52:28 Dec 04 10:47:18.466 INFO [stderr] | Dec 04 10:47:18.466 INFO [stderr] 52 | if (items[i].quality < 50) Dec 04 10:47:18.466 INFO [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Dec 04 10:47:18.466 INFO [stderr] Dec 04 10:47:18.468 INFO [stderr] warning: unnecessary parentheses around `if` condition Dec 04 10:47:18.468 INFO [stderr] --> src/main.rs:58:24 Dec 04 10:47:18.468 INFO [stderr] | Dec 04 10:47:18.468 INFO [stderr] 58 | if (items[i].sell_in < 6) Dec 04 10:47:18.468 INFO [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Dec 04 10:47:18.468 INFO [stderr] Dec 04 10:47:18.468 INFO [stderr] warning: unnecessary parentheses around `if` condition Dec 04 10:47:18.468 INFO [stderr] --> src/main.rs:60:28 Dec 04 10:47:18.468 INFO [stderr] | Dec 04 10:47:18.469 INFO [stderr] 60 | if (items[i].quality < 50) Dec 04 10:47:18.469 INFO [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Dec 04 10:47:18.469 INFO [stderr] Dec 04 10:47:18.469 INFO [stderr] warning: unnecessary parentheses around `if` condition Dec 04 10:47:18.469 INFO [stderr] --> src/main.rs:69:12 Dec 04 10:47:18.469 INFO [stderr] | Dec 04 10:47:18.469 INFO [stderr] 69 | if (items[i].name != "Sulfuras, Hand of Ragnaros") Dec 04 10:47:18.469 INFO [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Dec 04 10:47:18.469 INFO [stderr] Dec 04 10:47:18.469 INFO [stderr] warning: unnecessary parentheses around `if` condition Dec 04 10:47:18.469 INFO [stderr] --> src/main.rs:74:12 Dec 04 10:47:18.469 INFO [stderr] | Dec 04 10:47:18.469 INFO [stderr] 74 | if (items[i].sell_in < 0) Dec 04 10:47:18.469 INFO [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Dec 04 10:47:18.469 INFO [stderr] Dec 04 10:47:18.469 INFO [stderr] warning: unnecessary parentheses around `if` condition Dec 04 10:47:18.469 INFO [stderr] --> src/main.rs:76:16 Dec 04 10:47:18.469 INFO [stderr] | Dec 04 10:47:18.470 INFO [stderr] 76 | if (items[i].name != "Aged Brie") Dec 04 10:47:18.470 INFO [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Dec 04 10:47:18.470 INFO [stderr] Dec 04 10:47:18.470 INFO [stderr] warning: unnecessary parentheses around `if` condition Dec 04 10:47:18.470 INFO [stderr] --> src/main.rs:78:20 Dec 04 10:47:18.470 INFO [stderr] | Dec 04 10:47:18.470 INFO [stderr] 78 | if (items[i].name != "Backstage passes to a TAFKAL80ETC concert") Dec 04 10:47:18.470 INFO [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Dec 04 10:47:18.470 INFO [stderr] Dec 04 10:47:18.470 INFO [stderr] warning: unnecessary parentheses around `if` condition Dec 04 10:47:18.470 INFO [stderr] --> src/main.rs:80:24 Dec 04 10:47:18.471 INFO [stderr] | Dec 04 10:47:18.471 INFO [stderr] 80 | if (items[i].quality > 0) Dec 04 10:47:18.471 INFO [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Dec 04 10:47:18.471 INFO [stderr] Dec 04 10:47:18.471 INFO [stderr] warning: unnecessary parentheses around `if` condition Dec 04 10:47:18.471 INFO [stderr] --> src/main.rs:82:28 Dec 04 10:47:18.471 INFO [stderr] | Dec 04 10:47:18.471 INFO [stderr] 82 | if (items[i].name != "Sulfuras, Hand of Ragnaros") Dec 04 10:47:18.471 INFO [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Dec 04 10:47:18.471 INFO [stderr] Dec 04 10:47:18.471 INFO [stderr] warning: unnecessary parentheses around `if` condition Dec 04 10:47:18.471 INFO [stderr] --> src/main.rs:95:20 Dec 04 10:47:18.471 INFO [stderr] | Dec 04 10:47:18.471 INFO [stderr] 95 | if (items[i].quality < 50) Dec 04 10:47:18.471 INFO [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Dec 04 10:47:18.471 INFO [stderr] Dec 04 10:47:18.495 INFO [stderr] warning: unnecessary parentheses around `if` condition Dec 04 10:47:18.495 INFO [stderr] --> src/main.rs:32:12 Dec 04 10:47:18.495 INFO [stderr] | Dec 04 10:47:18.495 INFO [stderr] 32 | if (items[i].name != "Aged Brie" && items[i].name != "Backstage passes to a TAFKAL80ETC concert") Dec 04 10:47:18.495 INFO [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Dec 04 10:47:18.495 INFO [stderr] | Dec 04 10:47:18.495 INFO [stderr] = note: #[warn(unused_parens)] on by default Dec 04 10:47:18.495 INFO [stderr] Dec 04 10:47:18.495 INFO [stderr] warning: unnecessary parentheses around `if` condition Dec 04 10:47:18.495 INFO [stderr] --> src/main.rs:34:16 Dec 04 10:47:18.495 INFO [stderr] | Dec 04 10:47:18.495 INFO [stderr] 34 | if (items[i].quality > 0) Dec 04 10:47:18.495 INFO [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Dec 04 10:47:18.495 INFO [stderr] Dec 04 10:47:18.495 INFO [stderr] warning: unnecessary parentheses around `if` condition Dec 04 10:47:18.495 INFO [stderr] --> src/main.rs:36:20 Dec 04 10:47:18.495 INFO [stderr] | Dec 04 10:47:18.495 INFO [stderr] 36 | if (items[i].name != "Sulfuras, Hand of Ragnaros") Dec 04 10:47:18.495 INFO [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Dec 04 10:47:18.495 INFO [stderr] Dec 04 10:47:18.495 INFO [stderr] warning: unnecessary parentheses around `if` condition Dec 04 10:47:18.495 INFO [stderr] --> src/main.rs:44:16 Dec 04 10:47:18.495 INFO [stderr] | Dec 04 10:47:18.495 INFO [stderr] 44 | if (items[i].quality < 50) Dec 04 10:47:18.495 INFO [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Dec 04 10:47:18.495 INFO [stderr] Dec 04 10:47:18.495 INFO [stderr] warning: unnecessary parentheses around `if` condition Dec 04 10:47:18.495 INFO [stderr] --> src/main.rs:48:20 Dec 04 10:47:18.495 INFO [stderr] | Dec 04 10:47:18.495 INFO [stderr] 48 | if (items[i].name == "Backstage passes to a TAFKAL80ETC concert") Dec 04 10:47:18.496 INFO [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Dec 04 10:47:18.496 INFO [stderr] Dec 04 10:47:18.496 INFO [stderr] warning: unnecessary parentheses around `if` condition Dec 04 10:47:18.496 INFO [stderr] --> src/main.rs:50:24 Dec 04 10:47:18.496 INFO [stderr] | Dec 04 10:47:18.496 INFO [stderr] 50 | if (items[i].sell_in < 11) Dec 04 10:47:18.496 INFO [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Dec 04 10:47:18.496 INFO [stderr] Dec 04 10:47:18.496 INFO [stderr] warning: unnecessary parentheses around `if` condition Dec 04 10:47:18.496 INFO [stderr] --> src/main.rs:52:28 Dec 04 10:47:18.496 INFO [stderr] | Dec 04 10:47:18.496 INFO [stderr] 52 | if (items[i].quality < 50) Dec 04 10:47:18.496 INFO [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Dec 04 10:47:18.496 INFO [stderr] Dec 04 10:47:18.496 INFO [stderr] warning: unnecessary parentheses around `if` condition Dec 04 10:47:18.496 INFO [stderr] --> src/main.rs:58:24 Dec 04 10:47:18.496 INFO [stderr] | Dec 04 10:47:18.496 INFO [stderr] 58 | if (items[i].sell_in < 6) Dec 04 10:47:18.496 INFO [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Dec 04 10:47:18.496 INFO [stderr] Dec 04 10:47:18.496 INFO [stderr] warning: unnecessary parentheses around `if` condition Dec 04 10:47:18.496 INFO [stderr] --> src/main.rs:60:28 Dec 04 10:47:18.496 INFO [stderr] | Dec 04 10:47:18.496 INFO [stderr] 60 | if (items[i].quality < 50) Dec 04 10:47:18.496 INFO [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Dec 04 10:47:18.496 INFO [stderr] Dec 04 10:47:18.496 INFO [stderr] warning: unnecessary parentheses around `if` condition Dec 04 10:47:18.496 INFO [stderr] --> src/main.rs:69:12 Dec 04 10:47:18.496 INFO [stderr] | Dec 04 10:47:18.496 INFO [stderr] 69 | if (items[i].name != "Sulfuras, Hand of Ragnaros") Dec 04 10:47:18.496 INFO [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Dec 04 10:47:18.496 INFO [stderr] Dec 04 10:47:18.496 INFO [stderr] warning: unnecessary parentheses around `if` condition Dec 04 10:47:18.496 INFO [stderr] --> src/main.rs:74:12 Dec 04 10:47:18.496 INFO [stderr] | Dec 04 10:47:18.496 INFO [stderr] 74 | if (items[i].sell_in < 0) Dec 04 10:47:18.496 INFO [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Dec 04 10:47:18.496 INFO [stderr] Dec 04 10:47:18.496 INFO [stderr] warning: unnecessary parentheses around `if` condition Dec 04 10:47:18.496 INFO [stderr] --> src/main.rs:76:16 Dec 04 10:47:18.496 INFO [stderr] | Dec 04 10:47:18.496 INFO [stderr] 76 | if (items[i].name != "Aged Brie") Dec 04 10:47:18.496 INFO [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Dec 04 10:47:18.496 INFO [stderr] Dec 04 10:47:18.496 INFO [stderr] warning: unnecessary parentheses around `if` condition Dec 04 10:47:18.496 INFO [stderr] --> src/main.rs:78:20 Dec 04 10:47:18.496 INFO [stderr] | Dec 04 10:47:18.496 INFO [stderr] 78 | if (items[i].name != "Backstage passes to a TAFKAL80ETC concert") Dec 04 10:47:18.496 INFO [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Dec 04 10:47:18.496 INFO [stderr] Dec 04 10:47:18.496 INFO [stderr] warning: unnecessary parentheses around `if` condition Dec 04 10:47:18.496 INFO [stderr] --> src/main.rs:80:24 Dec 04 10:47:18.496 INFO [stderr] | Dec 04 10:47:18.496 INFO [stderr] 80 | if (items[i].quality > 0) Dec 04 10:47:18.496 INFO [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Dec 04 10:47:18.496 INFO [stderr] Dec 04 10:47:18.496 INFO [stderr] warning: unnecessary parentheses around `if` condition Dec 04 10:47:18.496 INFO [stderr] --> src/main.rs:82:28 Dec 04 10:47:18.496 INFO [stderr] | Dec 04 10:47:18.496 INFO [stderr] 82 | if (items[i].name != "Sulfuras, Hand of Ragnaros") Dec 04 10:47:18.496 INFO [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Dec 04 10:47:18.496 INFO [stderr] Dec 04 10:47:18.496 INFO [stderr] warning: unnecessary parentheses around `if` condition Dec 04 10:47:18.496 INFO [stderr] --> src/main.rs:95:20 Dec 04 10:47:18.496 INFO [stderr] | Dec 04 10:47:18.496 INFO [stderr] 95 | if (items[i].quality < 50) Dec 04 10:47:18.496 INFO [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Dec 04 10:47:18.496 INFO [stderr] Dec 04 10:47:18.539 INFO [stderr] warning: function `UpdateQuality` should have a snake case name such as `update_quality` Dec 04 10:47:18.539 INFO [stderr] --> src/main.rs:28:1 Dec 04 10:47:18.539 INFO [stderr] | Dec 04 10:47:18.539 INFO [stderr] 28 | / fn UpdateQuality(items: &mut [Item]) Dec 04 10:47:18.539 INFO [stderr] 29 | | { Dec 04 10:47:18.539 INFO [stderr] 30 | | for i in 0..items.len() Dec 04 10:47:18.539 INFO [stderr] 31 | | { Dec 04 10:47:18.539 INFO [stderr] ... | Dec 04 10:47:18.539 INFO [stderr] 101 | | } Dec 04 10:47:18.539 INFO [stderr] 102 | | } Dec 04 10:47:18.539 INFO [stderr] | |_^ Dec 04 10:47:18.539 INFO [stderr] | Dec 04 10:47:18.539 INFO [stderr] = note: #[warn(non_snake_case)] on by default Dec 04 10:47:18.539 INFO [stderr] Dec 04 10:47:18.561 INFO [stderr] warning: function `UpdateQuality` should have a snake case name such as `update_quality` Dec 04 10:47:18.561 INFO [stderr] --> src/main.rs:28:1 Dec 04 10:47:18.561 INFO [stderr] | Dec 04 10:47:18.561 INFO [stderr] 28 | / fn UpdateQuality(items: &mut [Item]) Dec 04 10:47:18.561 INFO [stderr] 29 | | { Dec 04 10:47:18.561 INFO [stderr] 30 | | for i in 0..items.len() Dec 04 10:47:18.561 INFO [stderr] 31 | | { Dec 04 10:47:18.561 INFO [stderr] ... | Dec 04 10:47:18.561 INFO [stderr] 101 | | } Dec 04 10:47:18.561 INFO [stderr] 102 | | } Dec 04 10:47:18.561 INFO [stderr] | |_^ Dec 04 10:47:18.561 INFO [stderr] | Dec 04 10:47:18.561 INFO [stderr] = note: #[warn(non_snake_case)] on by default Dec 04 10:47:18.561 INFO [stderr] Dec 04 10:47:18.603 INFO [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.90s Dec 04 10:47:18.611 INFO [stderr] su: No module specific data is present Dec 04 10:47:19.196 INFO running `"docker" "inspect" "185f27c43103f515cadd19a8b9c6329b8e59608744d60be12c98ae18d39c0796"` Dec 04 10:47:19.374 INFO running `"docker" "rm" "-f" "185f27c43103f515cadd19a8b9c6329b8e59608744d60be12c98ae18d39c0796"` Dec 04 10:47:19.621 INFO [stdout] 185f27c43103f515cadd19a8b9c6329b8e59608744d60be12c98ae18d39c0796