Nov 29 18:51:23.459 INFO checking saterus/gilded-rose-rust against try#32252761328f59ccfadb1bafb8148c685bc830b3 for pr-56323 Nov 29 18:51:23.459 INFO running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/pr-56323/worker-6/try#32252761328f59ccfadb1bafb8148c685bc830b3:/target:rw,Z" "-v" "/mnt/big/crater/work/local/test-source/worker-6/pr-56323/try#32252761328f59ccfadb1bafb8148c685bc830b3:/source:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/source" "-e" "USER_ID=1000" "-e" "CMD=cargo +32252761328f59ccfadb1bafb8148c685bc830b3-alt check --frozen --all --all-targets" "-e" "CARGO_TARGET_DIR=/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/cargo-home" "-e" "RUSTUP_HOME=/rustup-home" "-m" "1536M" "--network" "none" "crater"` Nov 29 18:51:23.925 INFO [stdout] ce46f80189dc29e519d260c139e9678150cd5cc2441cffd38cd72b769f4f8738 Nov 29 18:51:23.928 INFO running `"docker" "start" "-a" "ce46f80189dc29e519d260c139e9678150cd5cc2441cffd38cd72b769f4f8738"` Nov 29 18:51:25.975 INFO [stderr] usermod: no changes Nov 29 18:51:26.068 INFO [stderr] Checking gilded_rose v0.1.0 (/source) Nov 29 18:51:26.683 INFO [stderr] warning: unnecessary parentheses around `if` condition Nov 29 18:51:26.683 INFO [stderr] --> src/main.rs:32:12 Nov 29 18:51:26.683 INFO [stderr] | Nov 29 18:51:26.684 INFO [stderr] 32 | if (items[i].name != "Aged Brie" && items[i].name != "Backstage passes to a TAFKAL80ETC concert") Nov 29 18:51:26.684 INFO [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Nov 29 18:51:26.684 INFO [stderr] | Nov 29 18:51:26.685 INFO [stderr] = note: #[warn(unused_parens)] on by default Nov 29 18:51:26.685 INFO [stderr] Nov 29 18:51:26.685 INFO [stderr] warning: unnecessary parentheses around `if` condition Nov 29 18:51:26.686 INFO [stderr] --> src/main.rs:34:16 Nov 29 18:51:26.686 INFO [stderr] | Nov 29 18:51:26.686 INFO [stderr] 34 | if (items[i].quality > 0) Nov 29 18:51:26.687 INFO [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Nov 29 18:51:26.687 INFO [stderr] Nov 29 18:51:26.687 INFO [stderr] warning: unnecessary parentheses around `if` condition Nov 29 18:51:26.687 INFO [stderr] --> src/main.rs:36:20 Nov 29 18:51:26.688 INFO [stderr] | Nov 29 18:51:26.688 INFO [stderr] 36 | if (items[i].name != "Sulfuras, Hand of Ragnaros") Nov 29 18:51:26.688 INFO [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Nov 29 18:51:26.688 INFO [stderr] Nov 29 18:51:26.689 INFO [stderr] warning: unnecessary parentheses around `if` condition Nov 29 18:51:26.689 INFO [stderr] --> src/main.rs:44:16 Nov 29 18:51:26.689 INFO [stderr] | Nov 29 18:51:26.690 INFO [stderr] 44 | if (items[i].quality < 50) Nov 29 18:51:26.690 INFO [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Nov 29 18:51:26.690 INFO [stderr] Nov 29 18:51:26.690 INFO [stderr] warning: unnecessary parentheses around `if` condition Nov 29 18:51:26.691 INFO [stderr] --> src/main.rs:48:20 Nov 29 18:51:26.691 INFO [stderr] | Nov 29 18:51:26.691 INFO [stderr] 48 | if (items[i].name == "Backstage passes to a TAFKAL80ETC concert") Nov 29 18:51:26.691 INFO [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Nov 29 18:51:26.691 INFO [stderr] Nov 29 18:51:26.692 INFO [stderr] warning: unnecessary parentheses around `if` condition Nov 29 18:51:26.692 INFO [stderr] --> src/main.rs:50:24 Nov 29 18:51:26.692 INFO [stderr] | Nov 29 18:51:26.693 INFO [stderr] 50 | if (items[i].sell_in < 11) Nov 29 18:51:26.693 INFO [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Nov 29 18:51:26.693 INFO [stderr] Nov 29 18:51:26.693 INFO [stderr] warning: unnecessary parentheses around `if` condition Nov 29 18:51:26.694 INFO [stderr] --> src/main.rs:52:28 Nov 29 18:51:26.694 INFO [stderr] | Nov 29 18:51:26.694 INFO [stderr] 52 | if (items[i].quality < 50) Nov 29 18:51:26.694 INFO [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Nov 29 18:51:26.695 INFO [stderr] Nov 29 18:51:26.695 INFO [stderr] warning: unnecessary parentheses around `if` condition Nov 29 18:51:26.695 INFO [stderr] --> src/main.rs:58:24 Nov 29 18:51:26.695 INFO [stderr] | Nov 29 18:51:26.696 INFO [stderr] 58 | if (items[i].sell_in < 6) Nov 29 18:51:26.696 INFO [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Nov 29 18:51:26.696 INFO [stderr] Nov 29 18:51:26.696 INFO [stderr] warning: unnecessary parentheses around `if` condition Nov 29 18:51:26.697 INFO [stderr] --> src/main.rs:60:28 Nov 29 18:51:26.697 INFO [stderr] | Nov 29 18:51:26.697 INFO [stderr] 60 | if (items[i].quality < 50) Nov 29 18:51:26.697 INFO [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Nov 29 18:51:26.697 INFO [stderr] Nov 29 18:51:26.697 INFO [stderr] warning: unnecessary parentheses around `if` condition Nov 29 18:51:26.697 INFO [stderr] --> src/main.rs:69:12 Nov 29 18:51:26.697 INFO [stderr] | Nov 29 18:51:26.697 INFO [stderr] 69 | if (items[i].name != "Sulfuras, Hand of Ragnaros") Nov 29 18:51:26.697 INFO [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Nov 29 18:51:26.697 INFO [stderr] Nov 29 18:51:26.697 INFO [stderr] warning: unnecessary parentheses around `if` condition Nov 29 18:51:26.697 INFO [stderr] --> src/main.rs:74:12 Nov 29 18:51:26.697 INFO [stderr] | Nov 29 18:51:26.697 INFO [stderr] 74 | if (items[i].sell_in < 0) Nov 29 18:51:26.697 INFO [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Nov 29 18:51:26.697 INFO [stderr] Nov 29 18:51:26.697 INFO [stderr] warning: unnecessary parentheses around `if` condition Nov 29 18:51:26.697 INFO [stderr] --> src/main.rs:76:16 Nov 29 18:51:26.697 INFO [stderr] | Nov 29 18:51:26.698 INFO [stderr] 76 | if (items[i].name != "Aged Brie") Nov 29 18:51:26.698 INFO [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Nov 29 18:51:26.698 INFO [stderr] Nov 29 18:51:26.698 INFO [stderr] warning: unnecessary parentheses around `if` condition Nov 29 18:51:26.698 INFO [stderr] --> src/main.rs:78:20 Nov 29 18:51:26.698 INFO [stderr] | Nov 29 18:51:26.698 INFO [stderr] 78 | if (items[i].name != "Backstage passes to a TAFKAL80ETC concert") Nov 29 18:51:26.698 INFO [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Nov 29 18:51:26.698 INFO [stderr] Nov 29 18:51:26.698 INFO [stderr] warning: unnecessary parentheses around `if` condition Nov 29 18:51:26.698 INFO [stderr] --> src/main.rs:80:24 Nov 29 18:51:26.698 INFO [stderr] | Nov 29 18:51:26.698 INFO [stderr] 80 | if (items[i].quality > 0) Nov 29 18:51:26.698 INFO [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Nov 29 18:51:26.698 INFO [stderr] Nov 29 18:51:26.698 INFO [stderr] warning: unnecessary parentheses around `if` condition Nov 29 18:51:26.698 INFO [stderr] --> src/main.rs:82:28 Nov 29 18:51:26.698 INFO [stderr] | Nov 29 18:51:26.698 INFO [stderr] 82 | if (items[i].name != "Sulfuras, Hand of Ragnaros") Nov 29 18:51:26.698 INFO [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Nov 29 18:51:26.698 INFO [stderr] Nov 29 18:51:26.698 INFO [stderr] warning: unnecessary parentheses around `if` condition Nov 29 18:51:26.698 INFO [stderr] --> src/main.rs:95:20 Nov 29 18:51:26.698 INFO [stderr] | Nov 29 18:51:26.698 INFO [stderr] 95 | if (items[i].quality < 50) Nov 29 18:51:26.698 INFO [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Nov 29 18:51:26.698 INFO [stderr] Nov 29 18:51:26.708 INFO [stderr] warning: unnecessary parentheses around `if` condition Nov 29 18:51:26.709 INFO [stderr] --> src/main.rs:32:12 Nov 29 18:51:26.709 INFO [stderr] | Nov 29 18:51:26.709 INFO [stderr] 32 | if (items[i].name != "Aged Brie" && items[i].name != "Backstage passes to a TAFKAL80ETC concert") Nov 29 18:51:26.710 INFO [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Nov 29 18:51:26.710 INFO [stderr] | Nov 29 18:51:26.710 INFO [stderr] = note: #[warn(unused_parens)] on by default Nov 29 18:51:26.711 INFO [stderr] Nov 29 18:51:26.711 INFO [stderr] warning: unnecessary parentheses around `if` condition Nov 29 18:51:26.711 INFO [stderr] --> src/main.rs:34:16 Nov 29 18:51:26.711 INFO [stderr] | Nov 29 18:51:26.711 INFO [stderr] 34 | if (items[i].quality > 0) Nov 29 18:51:26.711 INFO [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Nov 29 18:51:26.711 INFO [stderr] Nov 29 18:51:26.711 INFO [stderr] warning: unnecessary parentheses around `if` condition Nov 29 18:51:26.711 INFO [stderr] --> src/main.rs:36:20 Nov 29 18:51:26.711 INFO [stderr] | Nov 29 18:51:26.711 INFO [stderr] 36 | if (items[i].name != "Sulfuras, Hand of Ragnaros") Nov 29 18:51:26.711 INFO [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Nov 29 18:51:26.711 INFO [stderr] Nov 29 18:51:26.712 INFO [stderr] warning: unnecessary parentheses around `if` condition Nov 29 18:51:26.712 INFO [stderr] --> src/main.rs:44:16 Nov 29 18:51:26.712 INFO [stderr] | Nov 29 18:51:26.712 INFO [stderr] 44 | if (items[i].quality < 50) Nov 29 18:51:26.712 INFO [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Nov 29 18:51:26.712 INFO [stderr] Nov 29 18:51:26.712 INFO [stderr] warning: unnecessary parentheses around `if` condition Nov 29 18:51:26.712 INFO [stderr] --> src/main.rs:48:20 Nov 29 18:51:26.712 INFO [stderr] | Nov 29 18:51:26.712 INFO [stderr] 48 | if (items[i].name == "Backstage passes to a TAFKAL80ETC concert") Nov 29 18:51:26.712 INFO [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Nov 29 18:51:26.712 INFO [stderr] Nov 29 18:51:26.712 INFO [stderr] warning: unnecessary parentheses around `if` condition Nov 29 18:51:26.712 INFO [stderr] --> src/main.rs:50:24 Nov 29 18:51:26.712 INFO [stderr] | Nov 29 18:51:26.712 INFO [stderr] 50 | if (items[i].sell_in < 11) Nov 29 18:51:26.712 INFO [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Nov 29 18:51:26.712 INFO [stderr] Nov 29 18:51:26.713 INFO [stderr] warning: unnecessary parentheses around `if` condition Nov 29 18:51:26.713 INFO [stderr] --> src/main.rs:52:28 Nov 29 18:51:26.713 INFO [stderr] | Nov 29 18:51:26.713 INFO [stderr] 52 | if (items[i].quality < 50) Nov 29 18:51:26.713 INFO [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Nov 29 18:51:26.713 INFO [stderr] Nov 29 18:51:26.713 INFO [stderr] warning: unnecessary parentheses around `if` condition Nov 29 18:51:26.713 INFO [stderr] --> src/main.rs:58:24 Nov 29 18:51:26.713 INFO [stderr] | Nov 29 18:51:26.713 INFO [stderr] 58 | if (items[i].sell_in < 6) Nov 29 18:51:26.713 INFO [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Nov 29 18:51:26.713 INFO [stderr] Nov 29 18:51:26.713 INFO [stderr] warning: unnecessary parentheses around `if` condition Nov 29 18:51:26.713 INFO [stderr] --> src/main.rs:60:28 Nov 29 18:51:26.713 INFO [stderr] | Nov 29 18:51:26.713 INFO [stderr] 60 | if (items[i].quality < 50) Nov 29 18:51:26.713 INFO [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Nov 29 18:51:26.713 INFO [stderr] Nov 29 18:51:26.713 INFO [stderr] warning: unnecessary parentheses around `if` condition Nov 29 18:51:26.714 INFO [stderr] --> src/main.rs:69:12 Nov 29 18:51:26.714 INFO [stderr] | Nov 29 18:51:26.714 INFO [stderr] 69 | if (items[i].name != "Sulfuras, Hand of Ragnaros") Nov 29 18:51:26.714 INFO [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Nov 29 18:51:26.714 INFO [stderr] Nov 29 18:51:26.714 INFO [stderr] warning: unnecessary parentheses around `if` condition Nov 29 18:51:26.714 INFO [stderr] --> src/main.rs:74:12 Nov 29 18:51:26.714 INFO [stderr] | Nov 29 18:51:26.714 INFO [stderr] 74 | if (items[i].sell_in < 0) Nov 29 18:51:26.714 INFO [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Nov 29 18:51:26.714 INFO [stderr] Nov 29 18:51:26.714 INFO [stderr] warning: unnecessary parentheses around `if` condition Nov 29 18:51:26.714 INFO [stderr] --> src/main.rs:76:16 Nov 29 18:51:26.714 INFO [stderr] | Nov 29 18:51:26.714 INFO [stderr] 76 | if (items[i].name != "Aged Brie") Nov 29 18:51:26.714 INFO [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Nov 29 18:51:26.714 INFO [stderr] Nov 29 18:51:26.714 INFO [stderr] warning: unnecessary parentheses around `if` condition Nov 29 18:51:26.714 INFO [stderr] --> src/main.rs:78:20 Nov 29 18:51:26.714 INFO [stderr] | Nov 29 18:51:26.715 INFO [stderr] 78 | if (items[i].name != "Backstage passes to a TAFKAL80ETC concert") Nov 29 18:51:26.715 INFO [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Nov 29 18:51:26.715 INFO [stderr] Nov 29 18:51:26.715 INFO [stderr] warning: unnecessary parentheses around `if` condition Nov 29 18:51:26.715 INFO [stderr] --> src/main.rs:80:24 Nov 29 18:51:26.715 INFO [stderr] | Nov 29 18:51:26.715 INFO [stderr] 80 | if (items[i].quality > 0) Nov 29 18:51:26.715 INFO [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Nov 29 18:51:26.715 INFO [stderr] Nov 29 18:51:26.715 INFO [stderr] warning: unnecessary parentheses around `if` condition Nov 29 18:51:26.715 INFO [stderr] --> src/main.rs:82:28 Nov 29 18:51:26.715 INFO [stderr] | Nov 29 18:51:26.715 INFO [stderr] 82 | if (items[i].name != "Sulfuras, Hand of Ragnaros") Nov 29 18:51:26.715 INFO [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Nov 29 18:51:26.715 INFO [stderr] Nov 29 18:51:26.715 INFO [stderr] warning: unnecessary parentheses around `if` condition Nov 29 18:51:26.715 INFO [stderr] --> src/main.rs:95:20 Nov 29 18:51:26.715 INFO [stderr] | Nov 29 18:51:26.715 INFO [stderr] 95 | if (items[i].quality < 50) Nov 29 18:51:26.715 INFO [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Nov 29 18:51:26.715 INFO [stderr] Nov 29 18:51:26.812 INFO [stderr] warning: function `UpdateQuality` should have a snake case name such as `update_quality` Nov 29 18:51:26.812 INFO [stderr] --> src/main.rs:28:1 Nov 29 18:51:26.813 INFO [stderr] | Nov 29 18:51:26.813 INFO [stderr] 28 | / fn UpdateQuality(items: &mut [Item]) Nov 29 18:51:26.813 INFO [stderr] 29 | | { Nov 29 18:51:26.813 INFO [stderr] 30 | | for i in 0..items.len() Nov 29 18:51:26.813 INFO [stderr] 31 | | { Nov 29 18:51:26.813 INFO [stderr] ... | Nov 29 18:51:26.813 INFO [stderr] 101 | | } Nov 29 18:51:26.813 INFO [stderr] 102 | | } Nov 29 18:51:26.813 INFO [stderr] | |_^ Nov 29 18:51:26.813 INFO [stderr] | Nov 29 18:51:26.813 INFO [stderr] = note: #[warn(non_snake_case)] on by default Nov 29 18:51:26.813 INFO [stderr] Nov 29 18:51:26.817 INFO [stderr] warning: function `UpdateQuality` should have a snake case name such as `update_quality` Nov 29 18:51:26.817 INFO [stderr] --> src/main.rs:28:1 Nov 29 18:51:26.817 INFO [stderr] | Nov 29 18:51:26.817 INFO [stderr] 28 | / fn UpdateQuality(items: &mut [Item]) Nov 29 18:51:26.817 INFO [stderr] 29 | | { Nov 29 18:51:26.818 INFO [stderr] 30 | | for i in 0..items.len() Nov 29 18:51:26.818 INFO [stderr] 31 | | { Nov 29 18:51:26.818 INFO [stderr] ... | Nov 29 18:51:26.818 INFO [stderr] 101 | | } Nov 29 18:51:26.818 INFO [stderr] 102 | | } Nov 29 18:51:26.819 INFO [stderr] | |_^ Nov 29 18:51:26.819 INFO [stderr] | Nov 29 18:51:26.819 INFO [stderr] = note: #[warn(non_snake_case)] on by default Nov 29 18:51:26.819 INFO [stderr] Nov 29 18:51:26.871 INFO [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.84s Nov 29 18:51:26.873 INFO [stderr] su: No module specific data is present Nov 29 18:51:28.004 INFO running `"docker" "inspect" "ce46f80189dc29e519d260c139e9678150cd5cc2441cffd38cd72b769f4f8738"` Nov 29 18:51:28.274 INFO running `"docker" "rm" "-f" "ce46f80189dc29e519d260c139e9678150cd5cc2441cffd38cd72b769f4f8738"` Nov 29 18:51:28.532 INFO [stdout] ce46f80189dc29e519d260c139e9678150cd5cc2441cffd38cd72b769f4f8738