Nov 29 18:51:28.613 INFO checking saterus/gilded-rose-rust against master#a49316ddc99d9d595193557fc899f6c52e4d9af9 for pr-56323 Nov 29 18:51:28.613 INFO running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/pr-56323/worker-6/master#a49316ddc99d9d595193557fc899f6c52e4d9af9:/target:rw,Z" "-v" "/mnt/big/crater/work/local/test-source/worker-6/pr-56323/master#a49316ddc99d9d595193557fc899f6c52e4d9af9:/source:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/source" "-e" "USER_ID=1000" "-e" "CMD=cargo +a49316ddc99d9d595193557fc899f6c52e4d9af9-alt check --frozen --all --all-targets" "-e" "CARGO_TARGET_DIR=/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/cargo-home" "-e" "RUSTUP_HOME=/rustup-home" "-m" "1536M" "--network" "none" "crater"` Nov 29 18:51:29.000 INFO [stdout] 6c9af4805de1965da8aaa8c25b5dffc86bea87400c518faa3de00c69cbf205d4 Nov 29 18:51:29.006 INFO running `"docker" "start" "-a" "6c9af4805de1965da8aaa8c25b5dffc86bea87400c518faa3de00c69cbf205d4"` Nov 29 18:51:29.660 INFO [stderr] usermod: no changes Nov 29 18:51:29.693 INFO [stderr] Checking gilded_rose v0.1.0 (/source) Nov 29 18:51:30.056 INFO [stderr] warning: unnecessary parentheses around `if` condition Nov 29 18:51:30.056 INFO [stderr] --> src/main.rs:32:12 Nov 29 18:51:30.056 INFO [stderr] | Nov 29 18:51:30.056 INFO [stderr] 32 | if (items[i].name != "Aged Brie" && items[i].name != "Backstage passes to a TAFKAL80ETC concert") Nov 29 18:51:30.056 INFO [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Nov 29 18:51:30.056 INFO [stderr] | Nov 29 18:51:30.056 INFO [stderr] = note: #[warn(unused_parens)] on by default Nov 29 18:51:30.056 INFO [stderr] Nov 29 18:51:30.056 INFO [stderr] warning: unnecessary parentheses around `if` condition Nov 29 18:51:30.056 INFO [stderr] --> src/main.rs:34:16 Nov 29 18:51:30.056 INFO [stderr] | Nov 29 18:51:30.056 INFO [stderr] 34 | if (items[i].quality > 0) Nov 29 18:51:30.056 INFO [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Nov 29 18:51:30.056 INFO [stderr] Nov 29 18:51:30.056 INFO [stderr] warning: unnecessary parentheses around `if` condition Nov 29 18:51:30.056 INFO [stderr] --> src/main.rs:36:20 Nov 29 18:51:30.056 INFO [stderr] | Nov 29 18:51:30.056 INFO [stderr] 36 | if (items[i].name != "Sulfuras, Hand of Ragnaros") Nov 29 18:51:30.056 INFO [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Nov 29 18:51:30.056 INFO [stderr] Nov 29 18:51:30.056 INFO [stderr] warning: unnecessary parentheses around `if` condition Nov 29 18:51:30.056 INFO [stderr] --> src/main.rs:44:16 Nov 29 18:51:30.056 INFO [stderr] | Nov 29 18:51:30.056 INFO [stderr] 44 | if (items[i].quality < 50) Nov 29 18:51:30.056 INFO [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Nov 29 18:51:30.056 INFO [stderr] Nov 29 18:51:30.056 INFO [stderr] warning: unnecessary parentheses around `if` condition Nov 29 18:51:30.056 INFO [stderr] --> src/main.rs:48:20 Nov 29 18:51:30.056 INFO [stderr] | Nov 29 18:51:30.056 INFO [stderr] 48 | if (items[i].name == "Backstage passes to a TAFKAL80ETC concert") Nov 29 18:51:30.056 INFO [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Nov 29 18:51:30.056 INFO [stderr] Nov 29 18:51:30.056 INFO [stderr] warning: unnecessary parentheses around `if` condition Nov 29 18:51:30.056 INFO [stderr] --> src/main.rs:50:24 Nov 29 18:51:30.056 INFO [stderr] | Nov 29 18:51:30.056 INFO [stderr] 50 | if (items[i].sell_in < 11) Nov 29 18:51:30.056 INFO [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Nov 29 18:51:30.056 INFO [stderr] Nov 29 18:51:30.056 INFO [stderr] warning: unnecessary parentheses around `if` condition Nov 29 18:51:30.056 INFO [stderr] --> src/main.rs:52:28 Nov 29 18:51:30.056 INFO [stderr] | Nov 29 18:51:30.056 INFO [stderr] 52 | if (items[i].quality < 50) Nov 29 18:51:30.056 INFO [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Nov 29 18:51:30.056 INFO [stderr] Nov 29 18:51:30.060 INFO [stderr] warning: unnecessary parentheses around `if` condition Nov 29 18:51:30.060 INFO [stderr] --> src/main.rs:58:24 Nov 29 18:51:30.060 INFO [stderr] | Nov 29 18:51:30.060 INFO [stderr] 58 | if (items[i].sell_in < 6) Nov 29 18:51:30.060 INFO [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Nov 29 18:51:30.060 INFO [stderr] Nov 29 18:51:30.060 INFO [stderr] warning: unnecessary parentheses around `if` condition Nov 29 18:51:30.060 INFO [stderr] --> src/main.rs:60:28 Nov 29 18:51:30.060 INFO [stderr] | Nov 29 18:51:30.060 INFO [stderr] 60 | if (items[i].quality < 50) Nov 29 18:51:30.060 INFO [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Nov 29 18:51:30.060 INFO [stderr] Nov 29 18:51:30.060 INFO [stderr] warning: unnecessary parentheses around `if` condition Nov 29 18:51:30.060 INFO [stderr] --> src/main.rs:69:12 Nov 29 18:51:30.060 INFO [stderr] | Nov 29 18:51:30.060 INFO [stderr] 69 | if (items[i].name != "Sulfuras, Hand of Ragnaros") Nov 29 18:51:30.060 INFO [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Nov 29 18:51:30.060 INFO [stderr] Nov 29 18:51:30.060 INFO [stderr] warning: unnecessary parentheses around `if` condition Nov 29 18:51:30.060 INFO [stderr] --> src/main.rs:74:12 Nov 29 18:51:30.060 INFO [stderr] | Nov 29 18:51:30.060 INFO [stderr] 74 | if (items[i].sell_in < 0) Nov 29 18:51:30.060 INFO [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Nov 29 18:51:30.060 INFO [stderr] Nov 29 18:51:30.060 INFO [stderr] warning: unnecessary parentheses around `if` condition Nov 29 18:51:30.060 INFO [stderr] --> src/main.rs:76:16 Nov 29 18:51:30.060 INFO [stderr] | Nov 29 18:51:30.060 INFO [stderr] 76 | if (items[i].name != "Aged Brie") Nov 29 18:51:30.060 INFO [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Nov 29 18:51:30.060 INFO [stderr] Nov 29 18:51:30.060 INFO [stderr] warning: unnecessary parentheses around `if` condition Nov 29 18:51:30.061 INFO [stderr] --> src/main.rs:78:20 Nov 29 18:51:30.061 INFO [stderr] | Nov 29 18:51:30.061 INFO [stderr] 78 | if (items[i].name != "Backstage passes to a TAFKAL80ETC concert") Nov 29 18:51:30.061 INFO [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Nov 29 18:51:30.061 INFO [stderr] Nov 29 18:51:30.061 INFO [stderr] warning: unnecessary parentheses around `if` condition Nov 29 18:51:30.061 INFO [stderr] --> src/main.rs:80:24 Nov 29 18:51:30.061 INFO [stderr] | Nov 29 18:51:30.061 INFO [stderr] 80 | if (items[i].quality > 0) Nov 29 18:51:30.061 INFO [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Nov 29 18:51:30.061 INFO [stderr] Nov 29 18:51:30.061 INFO [stderr] warning: unnecessary parentheses around `if` condition Nov 29 18:51:30.061 INFO [stderr] --> src/main.rs:82:28 Nov 29 18:51:30.061 INFO [stderr] | Nov 29 18:51:30.061 INFO [stderr] 82 | if (items[i].name != "Sulfuras, Hand of Ragnaros") Nov 29 18:51:30.061 INFO [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Nov 29 18:51:30.061 INFO [stderr] Nov 29 18:51:30.061 INFO [stderr] warning: unnecessary parentheses around `if` condition Nov 29 18:51:30.061 INFO [stderr] --> src/main.rs:95:20 Nov 29 18:51:30.061 INFO [stderr] | Nov 29 18:51:30.061 INFO [stderr] 95 | if (items[i].quality < 50) Nov 29 18:51:30.061 INFO [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Nov 29 18:51:30.061 INFO [stderr] Nov 29 18:51:30.110 INFO [stderr] warning: function `UpdateQuality` should have a snake case name such as `update_quality` Nov 29 18:51:30.110 INFO [stderr] --> src/main.rs:28:1 Nov 29 18:51:30.110 INFO [stderr] | Nov 29 18:51:30.110 INFO [stderr] 28 | / fn UpdateQuality(items: &mut [Item]) Nov 29 18:51:30.110 INFO [stderr] 29 | | { Nov 29 18:51:30.110 INFO [stderr] 30 | | for i in 0..items.len() Nov 29 18:51:30.110 INFO [stderr] 31 | | { Nov 29 18:51:30.110 INFO [stderr] ... | Nov 29 18:51:30.110 INFO [stderr] 101 | | } Nov 29 18:51:30.110 INFO [stderr] 102 | | } Nov 29 18:51:30.110 INFO [stderr] | |_^ Nov 29 18:51:30.110 INFO [stderr] | Nov 29 18:51:30.110 INFO [stderr] = note: #[warn(non_snake_case)] on by default Nov 29 18:51:30.110 INFO [stderr] Nov 29 18:51:30.118 INFO [stderr] warning: unnecessary parentheses around `if` condition Nov 29 18:51:30.118 INFO [stderr] --> src/main.rs:32:12 Nov 29 18:51:30.118 INFO [stderr] | Nov 29 18:51:30.118 INFO [stderr] 32 | if (items[i].name != "Aged Brie" && items[i].name != "Backstage passes to a TAFKAL80ETC concert") Nov 29 18:51:30.118 INFO [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Nov 29 18:51:30.118 INFO [stderr] | Nov 29 18:51:30.118 INFO [stderr] = note: #[warn(unused_parens)] on by default Nov 29 18:51:30.118 INFO [stderr] Nov 29 18:51:30.118 INFO [stderr] warning: unnecessary parentheses around `if` condition Nov 29 18:51:30.118 INFO [stderr] --> src/main.rs:34:16 Nov 29 18:51:30.118 INFO [stderr] | Nov 29 18:51:30.118 INFO [stderr] 34 | if (items[i].quality > 0) Nov 29 18:51:30.118 INFO [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Nov 29 18:51:30.118 INFO [stderr] Nov 29 18:51:30.118 INFO [stderr] warning: unnecessary parentheses around `if` condition Nov 29 18:51:30.118 INFO [stderr] --> src/main.rs:36:20 Nov 29 18:51:30.118 INFO [stderr] | Nov 29 18:51:30.118 INFO [stderr] 36 | if (items[i].name != "Sulfuras, Hand of Ragnaros") Nov 29 18:51:30.118 INFO [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Nov 29 18:51:30.118 INFO [stderr] Nov 29 18:51:30.118 INFO [stderr] warning: unnecessary parentheses around `if` condition Nov 29 18:51:30.118 INFO [stderr] --> src/main.rs:44:16 Nov 29 18:51:30.118 INFO [stderr] | Nov 29 18:51:30.118 INFO [stderr] 44 | if (items[i].quality < 50) Nov 29 18:51:30.118 INFO [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Nov 29 18:51:30.118 INFO [stderr] Nov 29 18:51:30.118 INFO [stderr] warning: unnecessary parentheses around `if` condition Nov 29 18:51:30.118 INFO [stderr] --> src/main.rs:48:20 Nov 29 18:51:30.118 INFO [stderr] | Nov 29 18:51:30.118 INFO [stderr] 48 | if (items[i].name == "Backstage passes to a TAFKAL80ETC concert") Nov 29 18:51:30.118 INFO [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Nov 29 18:51:30.118 INFO [stderr] Nov 29 18:51:30.118 INFO [stderr] warning: unnecessary parentheses around `if` condition Nov 29 18:51:30.118 INFO [stderr] --> src/main.rs:50:24 Nov 29 18:51:30.118 INFO [stderr] | Nov 29 18:51:30.118 INFO [stderr] 50 | if (items[i].sell_in < 11) Nov 29 18:51:30.118 INFO [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Nov 29 18:51:30.118 INFO [stderr] Nov 29 18:51:30.118 INFO [stderr] warning: unnecessary parentheses around `if` condition Nov 29 18:51:30.118 INFO [stderr] --> src/main.rs:52:28 Nov 29 18:51:30.118 INFO [stderr] | Nov 29 18:51:30.118 INFO [stderr] 52 | if (items[i].quality < 50) Nov 29 18:51:30.118 INFO [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Nov 29 18:51:30.118 INFO [stderr] Nov 29 18:51:30.118 INFO [stderr] warning: unnecessary parentheses around `if` condition Nov 29 18:51:30.118 INFO [stderr] --> src/main.rs:58:24 Nov 29 18:51:30.118 INFO [stderr] | Nov 29 18:51:30.118 INFO [stderr] 58 | if (items[i].sell_in < 6) Nov 29 18:51:30.118 INFO [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Nov 29 18:51:30.118 INFO [stderr] Nov 29 18:51:30.118 INFO [stderr] warning: unnecessary parentheses around `if` condition Nov 29 18:51:30.118 INFO [stderr] --> src/main.rs:60:28 Nov 29 18:51:30.118 INFO [stderr] | Nov 29 18:51:30.118 INFO [stderr] 60 | if (items[i].quality < 50) Nov 29 18:51:30.118 INFO [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Nov 29 18:51:30.118 INFO [stderr] Nov 29 18:51:30.118 INFO [stderr] warning: unnecessary parentheses around `if` condition Nov 29 18:51:30.118 INFO [stderr] --> src/main.rs:69:12 Nov 29 18:51:30.118 INFO [stderr] | Nov 29 18:51:30.118 INFO [stderr] 69 | if (items[i].name != "Sulfuras, Hand of Ragnaros") Nov 29 18:51:30.118 INFO [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Nov 29 18:51:30.118 INFO [stderr] Nov 29 18:51:30.118 INFO [stderr] warning: unnecessary parentheses around `if` condition Nov 29 18:51:30.118 INFO [stderr] --> src/main.rs:74:12 Nov 29 18:51:30.118 INFO [stderr] | Nov 29 18:51:30.118 INFO [stderr] 74 | if (items[i].sell_in < 0) Nov 29 18:51:30.118 INFO [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Nov 29 18:51:30.118 INFO [stderr] Nov 29 18:51:30.118 INFO [stderr] warning: unnecessary parentheses around `if` condition Nov 29 18:51:30.118 INFO [stderr] --> src/main.rs:76:16 Nov 29 18:51:30.118 INFO [stderr] | Nov 29 18:51:30.118 INFO [stderr] 76 | if (items[i].name != "Aged Brie") Nov 29 18:51:30.118 INFO [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Nov 29 18:51:30.118 INFO [stderr] Nov 29 18:51:30.118 INFO [stderr] warning: unnecessary parentheses around `if` condition Nov 29 18:51:30.118 INFO [stderr] --> src/main.rs:78:20 Nov 29 18:51:30.118 INFO [stderr] | Nov 29 18:51:30.118 INFO [stderr] 78 | if (items[i].name != "Backstage passes to a TAFKAL80ETC concert") Nov 29 18:51:30.118 INFO [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Nov 29 18:51:30.118 INFO [stderr] Nov 29 18:51:30.118 INFO [stderr] warning: unnecessary parentheses around `if` condition Nov 29 18:51:30.118 INFO [stderr] --> src/main.rs:80:24 Nov 29 18:51:30.118 INFO [stderr] | Nov 29 18:51:30.118 INFO [stderr] 80 | if (items[i].quality > 0) Nov 29 18:51:30.118 INFO [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Nov 29 18:51:30.118 INFO [stderr] Nov 29 18:51:30.118 INFO [stderr] warning: unnecessary parentheses around `if` condition Nov 29 18:51:30.118 INFO [stderr] --> src/main.rs:82:28 Nov 29 18:51:30.118 INFO [stderr] | Nov 29 18:51:30.118 INFO [stderr] 82 | if (items[i].name != "Sulfuras, Hand of Ragnaros") Nov 29 18:51:30.118 INFO [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Nov 29 18:51:30.118 INFO [stderr] Nov 29 18:51:30.118 INFO [stderr] warning: unnecessary parentheses around `if` condition Nov 29 18:51:30.118 INFO [stderr] --> src/main.rs:95:20 Nov 29 18:51:30.119 INFO [stderr] | Nov 29 18:51:30.119 INFO [stderr] 95 | if (items[i].quality < 50) Nov 29 18:51:30.119 INFO [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Nov 29 18:51:30.119 INFO [stderr] Nov 29 18:51:30.171 INFO [stderr] warning: function `UpdateQuality` should have a snake case name such as `update_quality` Nov 29 18:51:30.171 INFO [stderr] --> src/main.rs:28:1 Nov 29 18:51:30.171 INFO [stderr] | Nov 29 18:51:30.171 INFO [stderr] 28 | / fn UpdateQuality(items: &mut [Item]) Nov 29 18:51:30.171 INFO [stderr] 29 | | { Nov 29 18:51:30.171 INFO [stderr] 30 | | for i in 0..items.len() Nov 29 18:51:30.171 INFO [stderr] 31 | | { Nov 29 18:51:30.171 INFO [stderr] ... | Nov 29 18:51:30.171 INFO [stderr] 101 | | } Nov 29 18:51:30.171 INFO [stderr] 102 | | } Nov 29 18:51:30.171 INFO [stderr] | |_^ Nov 29 18:51:30.171 INFO [stderr] | Nov 29 18:51:30.171 INFO [stderr] = note: #[warn(non_snake_case)] on by default Nov 29 18:51:30.171 INFO [stderr] Nov 29 18:51:30.179 INFO [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.50s Nov 29 18:51:30.181 INFO [stderr] su: No module specific data is present Nov 29 18:51:30.506 INFO running `"docker" "inspect" "6c9af4805de1965da8aaa8c25b5dffc86bea87400c518faa3de00c69cbf205d4"` Nov 29 18:51:30.594 INFO running `"docker" "rm" "-f" "6c9af4805de1965da8aaa8c25b5dffc86bea87400c518faa3de00c69cbf205d4"` Nov 29 18:51:30.816 INFO [stdout] 6c9af4805de1965da8aaa8c25b5dffc86bea87400c518faa3de00c69cbf205d4