Nov 06 14:36:36.761 INFO checking saterus/gilded-rose-rust against master#24e66c28980442a48d9458f1a4f9b76cc722dc8a for pr-55687 Nov 06 14:36:36.762 INFO running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/pr-55687/worker-0/master#24e66c28980442a48d9458f1a4f9b76cc722dc8a:/target:rw,Z" "-v" "/mnt/big/crater/work/local/test-source/worker-0/pr-55687/master#24e66c28980442a48d9458f1a4f9b76cc722dc8a:/source:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/source" "-e" "USER_ID=1000" "-e" "CMD=cargo +24e66c28980442a48d9458f1a4f9b76cc722dc8a-alt check --frozen --all --all-targets" "-e" "CARGO_TARGET_DIR=/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/cargo-home" "-e" "RUSTUP_HOME=/rustup-home" "-m" "1536M" "--network" "none" "crater"` Nov 06 14:36:37.048 INFO blam! c60edc2519a91c11fcd0f5bec2b8934396175483e208b7272f55f415695a319d Nov 06 14:36:37.064 INFO running `"docker" "start" "-a" "c60edc2519a91c11fcd0f5bec2b8934396175483e208b7272f55f415695a319d"` Nov 06 14:36:38.189 INFO kablam! usermod: no changes Nov 06 14:36:38.242 INFO kablam! Checking gilded_rose v0.1.0 (/source) Nov 06 14:36:38.754 INFO kablam! warning: unnecessary parentheses around `if` condition Nov 06 14:36:38.754 INFO kablam! --> src/main.rs:32:12 Nov 06 14:36:38.755 INFO kablam! | Nov 06 14:36:38.755 INFO kablam! 32 | if (items[i].name != "Aged Brie" && items[i].name != "Backstage passes to a TAFKAL80ETC concert") Nov 06 14:36:38.756 INFO kablam! | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Nov 06 14:36:38.756 INFO kablam! | Nov 06 14:36:38.756 INFO kablam! = note: #[warn(unused_parens)] on by default Nov 06 14:36:38.756 INFO kablam! Nov 06 14:36:38.757 INFO kablam! warning: unnecessary parentheses around `if` condition Nov 06 14:36:38.757 INFO kablam! --> src/main.rs:34:16 Nov 06 14:36:38.757 INFO kablam! | Nov 06 14:36:38.757 INFO kablam! 34 | if (items[i].quality > 0) Nov 06 14:36:38.757 INFO kablam! | ^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Nov 06 14:36:38.757 INFO kablam! Nov 06 14:36:38.757 INFO kablam! warning: unnecessary parentheses around `if` condition Nov 06 14:36:38.757 INFO kablam! --> src/main.rs:36:20 Nov 06 14:36:38.757 INFO kablam! | Nov 06 14:36:38.757 INFO kablam! 36 | if (items[i].name != "Sulfuras, Hand of Ragnaros") Nov 06 14:36:38.757 INFO kablam! | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Nov 06 14:36:38.757 INFO kablam! Nov 06 14:36:38.758 INFO kablam! warning: unnecessary parentheses around `if` condition Nov 06 14:36:38.758 INFO kablam! --> src/main.rs:44:16 Nov 06 14:36:38.758 INFO kablam! | Nov 06 14:36:38.758 INFO kablam! 44 | if (items[i].quality < 50) Nov 06 14:36:38.758 INFO kablam! | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Nov 06 14:36:38.758 INFO kablam! Nov 06 14:36:38.758 INFO kablam! warning: unnecessary parentheses around `if` condition Nov 06 14:36:38.758 INFO kablam! --> src/main.rs:48:20 Nov 06 14:36:38.758 INFO kablam! | Nov 06 14:36:38.758 INFO kablam! 48 | if (items[i].name == "Backstage passes to a TAFKAL80ETC concert") Nov 06 14:36:38.758 INFO kablam! | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Nov 06 14:36:38.758 INFO kablam! Nov 06 14:36:38.759 INFO kablam! warning: unnecessary parentheses around `if` condition Nov 06 14:36:38.759 INFO kablam! --> src/main.rs:50:24 Nov 06 14:36:38.759 INFO kablam! | Nov 06 14:36:38.759 INFO kablam! 50 | if (items[i].sell_in < 11) Nov 06 14:36:38.759 INFO kablam! | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Nov 06 14:36:38.759 INFO kablam! Nov 06 14:36:38.759 INFO kablam! warning: unnecessary parentheses around `if` condition Nov 06 14:36:38.759 INFO kablam! --> src/main.rs:52:28 Nov 06 14:36:38.759 INFO kablam! | Nov 06 14:36:38.759 INFO kablam! 52 | if (items[i].quality < 50) Nov 06 14:36:38.759 INFO kablam! | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Nov 06 14:36:38.759 INFO kablam! Nov 06 14:36:38.760 INFO kablam! warning: unnecessary parentheses around `if` condition Nov 06 14:36:38.760 INFO kablam! --> src/main.rs:58:24 Nov 06 14:36:38.760 INFO kablam! | Nov 06 14:36:38.760 INFO kablam! 58 | if (items[i].sell_in < 6) Nov 06 14:36:38.760 INFO kablam! | ^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Nov 06 14:36:38.760 INFO kablam! Nov 06 14:36:38.760 INFO kablam! warning: unnecessary parentheses around `if` condition Nov 06 14:36:38.760 INFO kablam! --> src/main.rs:60:28 Nov 06 14:36:38.760 INFO kablam! | Nov 06 14:36:38.760 INFO kablam! 60 | if (items[i].quality < 50) Nov 06 14:36:38.760 INFO kablam! | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Nov 06 14:36:38.760 INFO kablam! Nov 06 14:36:38.761 INFO kablam! warning: unnecessary parentheses around `if` condition Nov 06 14:36:38.761 INFO kablam! --> src/main.rs:69:12 Nov 06 14:36:38.761 INFO kablam! | Nov 06 14:36:38.761 INFO kablam! 69 | if (items[i].name != "Sulfuras, Hand of Ragnaros") Nov 06 14:36:38.761 INFO kablam! | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Nov 06 14:36:38.761 INFO kablam! Nov 06 14:36:38.762 INFO kablam! warning: unnecessary parentheses around `if` condition Nov 06 14:36:38.762 INFO kablam! --> src/main.rs:74:12 Nov 06 14:36:38.762 INFO kablam! | Nov 06 14:36:38.762 INFO kablam! 74 | if (items[i].sell_in < 0) Nov 06 14:36:38.762 INFO kablam! | ^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Nov 06 14:36:38.762 INFO kablam! Nov 06 14:36:38.763 INFO kablam! warning: unnecessary parentheses around `if` condition Nov 06 14:36:38.763 INFO kablam! --> src/main.rs:76:16 Nov 06 14:36:38.763 INFO kablam! | Nov 06 14:36:38.763 INFO kablam! 76 | if (items[i].name != "Aged Brie") Nov 06 14:36:38.763 INFO kablam! | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Nov 06 14:36:38.763 INFO kablam! Nov 06 14:36:38.763 INFO kablam! warning: unnecessary parentheses around `if` condition Nov 06 14:36:38.763 INFO kablam! --> src/main.rs:78:20 Nov 06 14:36:38.763 INFO kablam! | Nov 06 14:36:38.764 INFO kablam! 78 | if (items[i].name != "Backstage passes to a TAFKAL80ETC concert") Nov 06 14:36:38.764 INFO kablam! | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Nov 06 14:36:38.764 INFO kablam! Nov 06 14:36:38.764 INFO kablam! warning: unnecessary parentheses around `if` condition Nov 06 14:36:38.764 INFO kablam! --> src/main.rs:80:24 Nov 06 14:36:38.764 INFO kablam! | Nov 06 14:36:38.764 INFO kablam! 80 | if (items[i].quality > 0) Nov 06 14:36:38.764 INFO kablam! | ^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Nov 06 14:36:38.765 INFO kablam! Nov 06 14:36:38.765 INFO kablam! warning: unnecessary parentheses around `if` condition Nov 06 14:36:38.765 INFO kablam! --> src/main.rs:82:28 Nov 06 14:36:38.765 INFO kablam! | Nov 06 14:36:38.765 INFO kablam! 82 | if (items[i].name != "Sulfuras, Hand of Ragnaros") Nov 06 14:36:38.765 INFO kablam! | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Nov 06 14:36:38.765 INFO kablam! Nov 06 14:36:38.766 INFO kablam! warning: unnecessary parentheses around `if` condition Nov 06 14:36:38.766 INFO kablam! --> src/main.rs:95:20 Nov 06 14:36:38.766 INFO kablam! | Nov 06 14:36:38.766 INFO kablam! 95 | if (items[i].quality < 50) Nov 06 14:36:38.766 INFO kablam! | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Nov 06 14:36:38.766 INFO kablam! Nov 06 14:36:38.827 INFO kablam! warning: function `UpdateQuality` should have a snake case name such as `update_quality` Nov 06 14:36:38.827 INFO kablam! --> src/main.rs:28:1 Nov 06 14:36:38.827 INFO kablam! | Nov 06 14:36:38.827 INFO kablam! 28 | / fn UpdateQuality(items: &mut [Item]) Nov 06 14:36:38.827 INFO kablam! 29 | | { Nov 06 14:36:38.827 INFO kablam! 30 | | for i in 0..items.len() Nov 06 14:36:38.827 INFO kablam! 31 | | { Nov 06 14:36:38.827 INFO kablam! ... | Nov 06 14:36:38.827 INFO kablam! 101 | | } Nov 06 14:36:38.827 INFO kablam! 102 | | } Nov 06 14:36:38.828 INFO kablam! | |_^ Nov 06 14:36:38.828 INFO kablam! | Nov 06 14:36:38.828 INFO kablam! = note: #[warn(non_snake_case)] on by default Nov 06 14:36:38.828 INFO kablam! Nov 06 14:36:38.932 INFO kablam! warning: unnecessary parentheses around `if` condition Nov 06 14:36:38.932 INFO kablam! --> src/main.rs:32:12 Nov 06 14:36:38.932 INFO kablam! | Nov 06 14:36:38.932 INFO kablam! 32 | if (items[i].name != "Aged Brie" && items[i].name != "Backstage passes to a TAFKAL80ETC concert") Nov 06 14:36:38.932 INFO kablam! | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Nov 06 14:36:38.932 INFO kablam! | Nov 06 14:36:38.932 INFO kablam! = note: #[warn(unused_parens)] on by default Nov 06 14:36:38.932 INFO kablam! Nov 06 14:36:38.932 INFO kablam! warning: unnecessary parentheses around `if` condition Nov 06 14:36:38.932 INFO kablam! --> src/main.rs:34:16 Nov 06 14:36:38.933 INFO kablam! | Nov 06 14:36:38.933 INFO kablam! 34 | if (items[i].quality > 0) Nov 06 14:36:38.933 INFO kablam! | ^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Nov 06 14:36:38.933 INFO kablam! Nov 06 14:36:38.933 INFO kablam! warning: unnecessary parentheses around `if` condition Nov 06 14:36:38.933 INFO kablam! --> src/main.rs:36:20 Nov 06 14:36:38.933 INFO kablam! | Nov 06 14:36:38.933 INFO kablam! 36 | if (items[i].name != "Sulfuras, Hand of Ragnaros") Nov 06 14:36:38.933 INFO kablam! | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Nov 06 14:36:38.933 INFO kablam! Nov 06 14:36:38.933 INFO kablam! warning: unnecessary parentheses around `if` condition Nov 06 14:36:38.933 INFO kablam! --> src/main.rs:44:16 Nov 06 14:36:38.933 INFO kablam! | Nov 06 14:36:38.933 INFO kablam! 44 | if (items[i].quality < 50) Nov 06 14:36:38.933 INFO kablam! | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Nov 06 14:36:38.933 INFO kablam! Nov 06 14:36:38.933 INFO kablam! warning: unnecessary parentheses around `if` condition Nov 06 14:36:38.933 INFO kablam! --> src/main.rs:48:20 Nov 06 14:36:38.933 INFO kablam! | Nov 06 14:36:38.933 INFO kablam! 48 | if (items[i].name == "Backstage passes to a TAFKAL80ETC concert") Nov 06 14:36:38.933 INFO kablam! | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Nov 06 14:36:38.933 INFO kablam! Nov 06 14:36:38.933 INFO kablam! warning: unnecessary parentheses around `if` condition Nov 06 14:36:38.933 INFO kablam! --> src/main.rs:50:24 Nov 06 14:36:38.933 INFO kablam! | Nov 06 14:36:38.933 INFO kablam! 50 | if (items[i].sell_in < 11) Nov 06 14:36:38.933 INFO kablam! | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Nov 06 14:36:38.933 INFO kablam! Nov 06 14:36:38.933 INFO kablam! warning: unnecessary parentheses around `if` condition Nov 06 14:36:38.933 INFO kablam! --> src/main.rs:52:28 Nov 06 14:36:38.933 INFO kablam! | Nov 06 14:36:38.933 INFO kablam! 52 | if (items[i].quality < 50) Nov 06 14:36:38.933 INFO kablam! | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Nov 06 14:36:38.933 INFO kablam! Nov 06 14:36:38.933 INFO kablam! warning: unnecessary parentheses around `if` condition Nov 06 14:36:38.933 INFO kablam! --> src/main.rs:58:24 Nov 06 14:36:38.933 INFO kablam! | Nov 06 14:36:38.933 INFO kablam! 58 | if (items[i].sell_in < 6) Nov 06 14:36:38.933 INFO kablam! | ^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Nov 06 14:36:38.933 INFO kablam! Nov 06 14:36:38.933 INFO kablam! warning: unnecessary parentheses around `if` condition Nov 06 14:36:38.933 INFO kablam! --> src/main.rs:60:28 Nov 06 14:36:38.933 INFO kablam! | Nov 06 14:36:38.933 INFO kablam! 60 | if (items[i].quality < 50) Nov 06 14:36:38.933 INFO kablam! | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Nov 06 14:36:38.933 INFO kablam! Nov 06 14:36:38.934 INFO kablam! warning: unnecessary parentheses around `if` condition Nov 06 14:36:38.934 INFO kablam! --> src/main.rs:69:12 Nov 06 14:36:38.934 INFO kablam! | Nov 06 14:36:38.934 INFO kablam! 69 | if (items[i].name != "Sulfuras, Hand of Ragnaros") Nov 06 14:36:38.934 INFO kablam! | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Nov 06 14:36:38.934 INFO kablam! Nov 06 14:36:38.934 INFO kablam! warning: unnecessary parentheses around `if` condition Nov 06 14:36:38.934 INFO kablam! --> src/main.rs:74:12 Nov 06 14:36:38.934 INFO kablam! | Nov 06 14:36:38.934 INFO kablam! 74 | if (items[i].sell_in < 0) Nov 06 14:36:38.934 INFO kablam! | ^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Nov 06 14:36:38.934 INFO kablam! Nov 06 14:36:38.934 INFO kablam! warning: unnecessary parentheses around `if` condition Nov 06 14:36:38.934 INFO kablam! --> src/main.rs:76:16 Nov 06 14:36:38.934 INFO kablam! | Nov 06 14:36:38.934 INFO kablam! 76 | if (items[i].name != "Aged Brie") Nov 06 14:36:38.934 INFO kablam! | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Nov 06 14:36:38.934 INFO kablam! Nov 06 14:36:38.934 INFO kablam! warning: unnecessary parentheses around `if` condition Nov 06 14:36:38.934 INFO kablam! --> src/main.rs:78:20 Nov 06 14:36:38.934 INFO kablam! | Nov 06 14:36:38.934 INFO kablam! 78 | if (items[i].name != "Backstage passes to a TAFKAL80ETC concert") Nov 06 14:36:38.934 INFO kablam! | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Nov 06 14:36:38.934 INFO kablam! Nov 06 14:36:38.934 INFO kablam! warning: unnecessary parentheses around `if` condition Nov 06 14:36:38.934 INFO kablam! --> src/main.rs:80:24 Nov 06 14:36:38.934 INFO kablam! | Nov 06 14:36:38.935 INFO kablam! 80 | if (items[i].quality > 0) Nov 06 14:36:38.935 INFO kablam! | ^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Nov 06 14:36:38.935 INFO kablam! Nov 06 14:36:38.935 INFO kablam! warning: unnecessary parentheses around `if` condition Nov 06 14:36:38.935 INFO kablam! --> src/main.rs:82:28 Nov 06 14:36:38.935 INFO kablam! | Nov 06 14:36:38.935 INFO kablam! 82 | if (items[i].name != "Sulfuras, Hand of Ragnaros") Nov 06 14:36:38.935 INFO kablam! | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Nov 06 14:36:38.935 INFO kablam! Nov 06 14:36:38.935 INFO kablam! warning: unnecessary parentheses around `if` condition Nov 06 14:36:38.935 INFO kablam! --> src/main.rs:95:20 Nov 06 14:36:38.935 INFO kablam! | Nov 06 14:36:38.935 INFO kablam! 95 | if (items[i].quality < 50) Nov 06 14:36:38.935 INFO kablam! | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Nov 06 14:36:38.935 INFO kablam! Nov 06 14:36:39.002 INFO kablam! warning: function `UpdateQuality` should have a snake case name such as `update_quality` Nov 06 14:36:39.002 INFO kablam! --> src/main.rs:28:1 Nov 06 14:36:39.002 INFO kablam! | Nov 06 14:36:39.002 INFO kablam! 28 | / fn UpdateQuality(items: &mut [Item]) Nov 06 14:36:39.002 INFO kablam! 29 | | { Nov 06 14:36:39.002 INFO kablam! 30 | | for i in 0..items.len() Nov 06 14:36:39.003 INFO kablam! 31 | | { Nov 06 14:36:39.003 INFO kablam! ... | Nov 06 14:36:39.003 INFO kablam! 101 | | } Nov 06 14:36:39.003 INFO kablam! 102 | | } Nov 06 14:36:39.003 INFO kablam! | |_^ Nov 06 14:36:39.003 INFO kablam! | Nov 06 14:36:39.003 INFO kablam! = note: #[warn(non_snake_case)] on by default Nov 06 14:36:39.003 INFO kablam! Nov 06 14:36:39.044 INFO kablam! Finished dev [unoptimized + debuginfo] target(s) in 0.82s Nov 06 14:36:39.046 INFO kablam! su: No module specific data is present Nov 06 14:36:39.423 INFO running `"docker" "rm" "-f" "c60edc2519a91c11fcd0f5bec2b8934396175483e208b7272f55f415695a319d"` Nov 06 14:36:39.582 INFO blam! c60edc2519a91c11fcd0f5bec2b8934396175483e208b7272f55f415695a319d