Nov 03 23:41:25.304 INFO checking saterus/gilded-rose-rust against try#e740b9aa0b624fa39feb39613e76d15bdf57e594 for pr-55655 Nov 03 23:41:25.305 INFO running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/pr-55655/worker-3/try#e740b9aa0b624fa39feb39613e76d15bdf57e594:/target:rw,Z" "-v" "/mnt/big/crater/work/local/test-source/worker-3/pr-55655/try#e740b9aa0b624fa39feb39613e76d15bdf57e594:/source:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/source" "-e" "USER_ID=1000" "-e" "CMD=cargo +e740b9aa0b624fa39feb39613e76d15bdf57e594-alt check --frozen --all --all-targets" "-e" "CARGO_TARGET_DIR=/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/cargo-home" "-e" "RUSTUP_HOME=/rustup-home" "-m" "1536M" "--network" "none" "crater"` Nov 03 23:41:25.741 INFO blam! 4ae0af083fcf64a5deea28340bddbcb3af8e76b9e8483f490d6f3222956a3c16 Nov 03 23:41:25.744 INFO running `"docker" "start" "-a" "4ae0af083fcf64a5deea28340bddbcb3af8e76b9e8483f490d6f3222956a3c16"` Nov 03 23:41:27.898 INFO kablam! usermod: no changes Nov 03 23:41:27.971 INFO kablam! Checking gilded_rose v0.1.0 (/source) Nov 03 23:41:28.875 INFO kablam! warning: unnecessary parentheses around `if` condition Nov 03 23:41:28.876 INFO kablam! --> src/main.rs:32:12 Nov 03 23:41:28.876 INFO kablam! | Nov 03 23:41:28.876 INFO kablam! 32 | if (items[i].name != "Aged Brie" && items[i].name != "Backstage passes to a TAFKAL80ETC concert") Nov 03 23:41:28.877 INFO kablam! | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Nov 03 23:41:28.877 INFO kablam! | Nov 03 23:41:28.877 INFO kablam! = note: #[warn(unused_parens)] on by default Nov 03 23:41:28.878 INFO kablam! Nov 03 23:41:28.878 INFO kablam! warning: unnecessary parentheses around `if` condition Nov 03 23:41:28.878 INFO kablam! --> src/main.rs:34:16 Nov 03 23:41:28.879 INFO kablam! | Nov 03 23:41:28.879 INFO kablam! 34 | if (items[i].quality > 0) Nov 03 23:41:28.879 INFO kablam! | ^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Nov 03 23:41:28.879 INFO kablam! Nov 03 23:41:28.880 INFO kablam! warning: unnecessary parentheses around `if` condition Nov 03 23:41:28.880 INFO kablam! --> src/main.rs:36:20 Nov 03 23:41:28.880 INFO kablam! | Nov 03 23:41:28.881 INFO kablam! 36 | if (items[i].name != "Sulfuras, Hand of Ragnaros") Nov 03 23:41:28.881 INFO kablam! | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Nov 03 23:41:28.881 INFO kablam! Nov 03 23:41:28.882 INFO kablam! warning: unnecessary parentheses around `if` condition Nov 03 23:41:28.882 INFO kablam! --> src/main.rs:44:16 Nov 03 23:41:28.882 INFO kablam! | Nov 03 23:41:28.883 INFO kablam! 44 | if (items[i].quality < 50) Nov 03 23:41:28.883 INFO kablam! | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Nov 03 23:41:28.883 INFO kablam! Nov 03 23:41:28.883 INFO kablam! warning: unnecessary parentheses around `if` condition Nov 03 23:41:28.884 INFO kablam! --> src/main.rs:48:20 Nov 03 23:41:28.884 INFO kablam! | Nov 03 23:41:28.884 INFO kablam! 48 | if (items[i].name == "Backstage passes to a TAFKAL80ETC concert") Nov 03 23:41:28.885 INFO kablam! | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Nov 03 23:41:28.885 INFO kablam! Nov 03 23:41:28.885 INFO kablam! warning: unnecessary parentheses around `if` condition Nov 03 23:41:28.886 INFO kablam! --> src/main.rs:50:24 Nov 03 23:41:28.886 INFO kablam! | Nov 03 23:41:28.886 INFO kablam! 50 | if (items[i].sell_in < 11) Nov 03 23:41:28.886 INFO kablam! | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Nov 03 23:41:28.887 INFO kablam! Nov 03 23:41:28.887 INFO kablam! warning: unnecessary parentheses around `if` condition Nov 03 23:41:28.887 INFO kablam! --> src/main.rs:52:28 Nov 03 23:41:28.888 INFO kablam! | Nov 03 23:41:28.888 INFO kablam! 52 | if (items[i].quality < 50) Nov 03 23:41:28.888 INFO kablam! | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Nov 03 23:41:28.889 INFO kablam! Nov 03 23:41:28.889 INFO kablam! warning: unnecessary parentheses around `if` condition Nov 03 23:41:28.889 INFO kablam! --> src/main.rs:58:24 Nov 03 23:41:28.889 INFO kablam! | Nov 03 23:41:28.890 INFO kablam! 58 | if (items[i].sell_in < 6) Nov 03 23:41:28.890 INFO kablam! | ^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Nov 03 23:41:28.890 INFO kablam! Nov 03 23:41:28.890 INFO kablam! warning: unnecessary parentheses around `if` condition Nov 03 23:41:28.890 INFO kablam! --> src/main.rs:60:28 Nov 03 23:41:28.890 INFO kablam! | Nov 03 23:41:28.890 INFO kablam! 60 | if (items[i].quality < 50) Nov 03 23:41:28.890 INFO kablam! | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Nov 03 23:41:28.890 INFO kablam! Nov 03 23:41:28.890 INFO kablam! warning: unnecessary parentheses around `if` condition Nov 03 23:41:28.891 INFO kablam! --> src/main.rs:69:12 Nov 03 23:41:28.891 INFO kablam! | Nov 03 23:41:28.891 INFO kablam! 69 | if (items[i].name != "Sulfuras, Hand of Ragnaros") Nov 03 23:41:28.891 INFO kablam! | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Nov 03 23:41:28.891 INFO kablam! Nov 03 23:41:28.891 INFO kablam! warning: unnecessary parentheses around `if` condition Nov 03 23:41:28.891 INFO kablam! --> src/main.rs:74:12 Nov 03 23:41:28.891 INFO kablam! | Nov 03 23:41:28.891 INFO kablam! 74 | if (items[i].sell_in < 0) Nov 03 23:41:28.891 INFO kablam! | ^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Nov 03 23:41:28.891 INFO kablam! Nov 03 23:41:28.891 INFO kablam! warning: unnecessary parentheses around `if` condition Nov 03 23:41:28.891 INFO kablam! --> src/main.rs:76:16 Nov 03 23:41:28.891 INFO kablam! | Nov 03 23:41:28.891 INFO kablam! 76 | if (items[i].name != "Aged Brie") Nov 03 23:41:28.891 INFO kablam! | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Nov 03 23:41:28.891 INFO kablam! Nov 03 23:41:28.891 INFO kablam! warning: unnecessary parentheses around `if` condition Nov 03 23:41:28.891 INFO kablam! --> src/main.rs:78:20 Nov 03 23:41:28.891 INFO kablam! | Nov 03 23:41:28.891 INFO kablam! 78 | if (items[i].name != "Backstage passes to a TAFKAL80ETC concert") Nov 03 23:41:28.891 INFO kablam! | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Nov 03 23:41:28.891 INFO kablam! Nov 03 23:41:28.891 INFO kablam! warning: unnecessary parentheses around `if` condition Nov 03 23:41:28.891 INFO kablam! --> src/main.rs:80:24 Nov 03 23:41:28.891 INFO kablam! | Nov 03 23:41:28.891 INFO kablam! 80 | if (items[i].quality > 0) Nov 03 23:41:28.891 INFO kablam! | ^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Nov 03 23:41:28.891 INFO kablam! Nov 03 23:41:28.897 INFO kablam! warning: unnecessary parentheses around `if` condition Nov 03 23:41:28.897 INFO kablam! --> src/main.rs:82:28 Nov 03 23:41:28.897 INFO kablam! | Nov 03 23:41:28.897 INFO kablam! 82 | if (items[i].name != "Sulfuras, Hand of Ragnaros") Nov 03 23:41:28.897 INFO kablam! | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Nov 03 23:41:28.897 INFO kablam! Nov 03 23:41:28.897 INFO kablam! warning: unnecessary parentheses around `if` condition Nov 03 23:41:28.897 INFO kablam! --> src/main.rs:95:20 Nov 03 23:41:28.897 INFO kablam! | Nov 03 23:41:28.897 INFO kablam! 95 | if (items[i].quality < 50) Nov 03 23:41:28.897 INFO kablam! | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Nov 03 23:41:28.897 INFO kablam! Nov 03 23:41:28.975 INFO kablam! warning: unnecessary parentheses around `if` condition Nov 03 23:41:28.975 INFO kablam! --> src/main.rs:32:12 Nov 03 23:41:28.975 INFO kablam! | Nov 03 23:41:28.975 INFO kablam! 32 | if (items[i].name != "Aged Brie" && items[i].name != "Backstage passes to a TAFKAL80ETC concert") Nov 03 23:41:28.975 INFO kablam! | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Nov 03 23:41:28.975 INFO kablam! | Nov 03 23:41:28.975 INFO kablam! = note: #[warn(unused_parens)] on by default Nov 03 23:41:28.975 INFO kablam! Nov 03 23:41:28.975 INFO kablam! warning: unnecessary parentheses around `if` condition Nov 03 23:41:28.975 INFO kablam! --> src/main.rs:34:16 Nov 03 23:41:28.975 INFO kablam! | Nov 03 23:41:28.975 INFO kablam! 34 | if (items[i].quality > 0) Nov 03 23:41:28.975 INFO kablam! | ^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Nov 03 23:41:28.975 INFO kablam! Nov 03 23:41:28.975 INFO kablam! warning: unnecessary parentheses around `if` condition Nov 03 23:41:28.975 INFO kablam! --> src/main.rs:36:20 Nov 03 23:41:28.975 INFO kablam! | Nov 03 23:41:28.976 INFO kablam! 36 | if (items[i].name != "Sulfuras, Hand of Ragnaros") Nov 03 23:41:28.976 INFO kablam! | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Nov 03 23:41:28.976 INFO kablam! Nov 03 23:41:28.976 INFO kablam! warning: unnecessary parentheses around `if` condition Nov 03 23:41:28.976 INFO kablam! --> src/main.rs:44:16 Nov 03 23:41:28.976 INFO kablam! | Nov 03 23:41:28.976 INFO kablam! 44 | if (items[i].quality < 50) Nov 03 23:41:28.976 INFO kablam! | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Nov 03 23:41:28.976 INFO kablam! Nov 03 23:41:28.977 INFO kablam! warning: unnecessary parentheses around `if` condition Nov 03 23:41:28.977 INFO kablam! --> src/main.rs:48:20 Nov 03 23:41:28.977 INFO kablam! | Nov 03 23:41:28.977 INFO kablam! 48 | if (items[i].name == "Backstage passes to a TAFKAL80ETC concert") Nov 03 23:41:28.977 INFO kablam! | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Nov 03 23:41:28.977 INFO kablam! Nov 03 23:41:28.977 INFO kablam! warning: unnecessary parentheses around `if` condition Nov 03 23:41:28.977 INFO kablam! --> src/main.rs:50:24 Nov 03 23:41:28.978 INFO kablam! | Nov 03 23:41:28.978 INFO kablam! 50 | if (items[i].sell_in < 11) Nov 03 23:41:28.978 INFO kablam! | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Nov 03 23:41:28.978 INFO kablam! Nov 03 23:41:28.978 INFO kablam! warning: unnecessary parentheses around `if` condition Nov 03 23:41:28.978 INFO kablam! --> src/main.rs:52:28 Nov 03 23:41:28.978 INFO kablam! | Nov 03 23:41:28.978 INFO kablam! 52 | if (items[i].quality < 50) Nov 03 23:41:28.978 INFO kablam! | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Nov 03 23:41:28.979 INFO kablam! Nov 03 23:41:28.979 INFO kablam! warning: unnecessary parentheses around `if` condition Nov 03 23:41:28.979 INFO kablam! --> src/main.rs:58:24 Nov 03 23:41:28.979 INFO kablam! | Nov 03 23:41:28.979 INFO kablam! 58 | if (items[i].sell_in < 6) Nov 03 23:41:28.979 INFO kablam! | ^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Nov 03 23:41:28.979 INFO kablam! Nov 03 23:41:28.979 INFO kablam! warning: unnecessary parentheses around `if` condition Nov 03 23:41:28.980 INFO kablam! --> src/main.rs:60:28 Nov 03 23:41:28.980 INFO kablam! | Nov 03 23:41:28.980 INFO kablam! 60 | if (items[i].quality < 50) Nov 03 23:41:28.980 INFO kablam! | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Nov 03 23:41:28.980 INFO kablam! Nov 03 23:41:28.980 INFO kablam! warning: unnecessary parentheses around `if` condition Nov 03 23:41:28.980 INFO kablam! --> src/main.rs:69:12 Nov 03 23:41:28.980 INFO kablam! | Nov 03 23:41:28.981 INFO kablam! 69 | if (items[i].name != "Sulfuras, Hand of Ragnaros") Nov 03 23:41:28.981 INFO kablam! | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Nov 03 23:41:28.981 INFO kablam! Nov 03 23:41:28.981 INFO kablam! warning: unnecessary parentheses around `if` condition Nov 03 23:41:28.981 INFO kablam! --> src/main.rs:74:12 Nov 03 23:41:28.981 INFO kablam! | Nov 03 23:41:28.981 INFO kablam! 74 | if (items[i].sell_in < 0) Nov 03 23:41:28.982 INFO kablam! | ^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Nov 03 23:41:28.982 INFO kablam! Nov 03 23:41:28.982 INFO kablam! warning: unnecessary parentheses around `if` condition Nov 03 23:41:28.982 INFO kablam! --> src/main.rs:76:16 Nov 03 23:41:28.982 INFO kablam! | Nov 03 23:41:28.982 INFO kablam! 76 | if (items[i].name != "Aged Brie") Nov 03 23:41:28.982 INFO kablam! | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Nov 03 23:41:28.982 INFO kablam! Nov 03 23:41:28.982 INFO kablam! warning: unnecessary parentheses around `if` condition Nov 03 23:41:28.983 INFO kablam! --> src/main.rs:78:20 Nov 03 23:41:28.983 INFO kablam! | Nov 03 23:41:28.983 INFO kablam! 78 | if (items[i].name != "Backstage passes to a TAFKAL80ETC concert") Nov 03 23:41:28.983 INFO kablam! | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Nov 03 23:41:28.983 INFO kablam! Nov 03 23:41:28.983 INFO kablam! warning: unnecessary parentheses around `if` condition Nov 03 23:41:28.983 INFO kablam! --> src/main.rs:80:24 Nov 03 23:41:28.983 INFO kablam! | Nov 03 23:41:28.984 INFO kablam! 80 | if (items[i].quality > 0) Nov 03 23:41:28.984 INFO kablam! | ^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Nov 03 23:41:28.984 INFO kablam! Nov 03 23:41:28.984 INFO kablam! warning: unnecessary parentheses around `if` condition Nov 03 23:41:28.984 INFO kablam! --> src/main.rs:82:28 Nov 03 23:41:28.984 INFO kablam! | Nov 03 23:41:28.985 INFO kablam! 82 | if (items[i].name != "Sulfuras, Hand of Ragnaros") Nov 03 23:41:28.985 INFO kablam! | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Nov 03 23:41:28.985 INFO kablam! Nov 03 23:41:28.985 INFO kablam! warning: unnecessary parentheses around `if` condition Nov 03 23:41:28.985 INFO kablam! --> src/main.rs:95:20 Nov 03 23:41:28.985 INFO kablam! | Nov 03 23:41:28.985 INFO kablam! 95 | if (items[i].quality < 50) Nov 03 23:41:28.985 INFO kablam! | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Nov 03 23:41:28.985 INFO kablam! Nov 03 23:41:29.031 INFO kablam! warning: function `UpdateQuality` should have a snake case name such as `update_quality` Nov 03 23:41:29.031 INFO kablam! --> src/main.rs:28:1 Nov 03 23:41:29.031 INFO kablam! | Nov 03 23:41:29.031 INFO kablam! 28 | / fn UpdateQuality(items: &mut [Item]) Nov 03 23:41:29.031 INFO kablam! 29 | | { Nov 03 23:41:29.031 INFO kablam! 30 | | for i in 0..items.len() Nov 03 23:41:29.032 INFO kablam! 31 | | { Nov 03 23:41:29.032 INFO kablam! ... | Nov 03 23:41:29.032 INFO kablam! 101 | | } Nov 03 23:41:29.032 INFO kablam! 102 | | } Nov 03 23:41:29.032 INFO kablam! | |_^ Nov 03 23:41:29.032 INFO kablam! | Nov 03 23:41:29.033 INFO kablam! = note: #[warn(non_snake_case)] on by default Nov 03 23:41:29.033 INFO kablam! Nov 03 23:41:29.173 INFO kablam! warning: function `UpdateQuality` should have a snake case name such as `update_quality` Nov 03 23:41:29.173 INFO kablam! --> src/main.rs:28:1 Nov 03 23:41:29.173 INFO kablam! | Nov 03 23:41:29.173 INFO kablam! 28 | / fn UpdateQuality(items: &mut [Item]) Nov 03 23:41:29.173 INFO kablam! 29 | | { Nov 03 23:41:29.173 INFO kablam! 30 | | for i in 0..items.len() Nov 03 23:41:29.173 INFO kablam! 31 | | { Nov 03 23:41:29.173 INFO kablam! ... | Nov 03 23:41:29.173 INFO kablam! 101 | | } Nov 03 23:41:29.173 INFO kablam! 102 | | } Nov 03 23:41:29.173 INFO kablam! | |_^ Nov 03 23:41:29.173 INFO kablam! | Nov 03 23:41:29.173 INFO kablam! = note: #[warn(non_snake_case)] on by default Nov 03 23:41:29.173 INFO kablam! Nov 03 23:41:29.219 INFO kablam! Finished dev [unoptimized + debuginfo] target(s) in 1.28s Nov 03 23:41:29.227 INFO kablam! su: No module specific data is present Nov 03 23:41:30.680 INFO running `"docker" "rm" "-f" "4ae0af083fcf64a5deea28340bddbcb3af8e76b9e8483f490d6f3222956a3c16"` Nov 03 23:41:31.023 INFO blam! 4ae0af083fcf64a5deea28340bddbcb3af8e76b9e8483f490d6f3222956a3c16