Nov 03 23:41:31.113 INFO checking saterus/gilded-rose-rust against master#2ad8c7b3502616aff142a4640cce911c6c2c5463 for pr-55655 Nov 03 23:41:31.115 INFO running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/pr-55655/worker-3/master#2ad8c7b3502616aff142a4640cce911c6c2c5463:/target:rw,Z" "-v" "/mnt/big/crater/work/local/test-source/worker-3/pr-55655/master#2ad8c7b3502616aff142a4640cce911c6c2c5463:/source:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/source" "-e" "USER_ID=1000" "-e" "CMD=cargo +2ad8c7b3502616aff142a4640cce911c6c2c5463-alt check --frozen --all --all-targets" "-e" "CARGO_TARGET_DIR=/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/cargo-home" "-e" "RUSTUP_HOME=/rustup-home" "-m" "1536M" "--network" "none" "crater"` Nov 03 23:41:31.592 INFO blam! bca85e7eec76d6809a433db14aa87f18de4a839c9d0cc109eaa1a14e8cb8fda3 Nov 03 23:41:31.594 INFO running `"docker" "start" "-a" "bca85e7eec76d6809a433db14aa87f18de4a839c9d0cc109eaa1a14e8cb8fda3"` Nov 03 23:41:33.143 INFO kablam! usermod: no changes Nov 03 23:41:33.187 INFO kablam! Checking gilded_rose v0.1.0 (/source) Nov 03 23:41:33.700 INFO kablam! warning: unnecessary parentheses around `if` condition Nov 03 23:41:33.700 INFO kablam! --> src/main.rs:32:12 Nov 03 23:41:33.700 INFO kablam! | Nov 03 23:41:33.700 INFO kablam! 32 | if (items[i].name != "Aged Brie" && items[i].name != "Backstage passes to a TAFKAL80ETC concert") Nov 03 23:41:33.700 INFO kablam! | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Nov 03 23:41:33.700 INFO kablam! | Nov 03 23:41:33.700 INFO kablam! = note: #[warn(unused_parens)] on by default Nov 03 23:41:33.700 INFO kablam! Nov 03 23:41:33.700 INFO kablam! warning: unnecessary parentheses around `if` condition Nov 03 23:41:33.700 INFO kablam! --> src/main.rs:34:16 Nov 03 23:41:33.700 INFO kablam! | Nov 03 23:41:33.701 INFO kablam! 34 | if (items[i].quality > 0) Nov 03 23:41:33.701 INFO kablam! | ^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Nov 03 23:41:33.701 INFO kablam! Nov 03 23:41:33.701 INFO kablam! warning: unnecessary parentheses around `if` condition Nov 03 23:41:33.701 INFO kablam! --> src/main.rs:36:20 Nov 03 23:41:33.701 INFO kablam! | Nov 03 23:41:33.701 INFO kablam! 36 | if (items[i].name != "Sulfuras, Hand of Ragnaros") Nov 03 23:41:33.702 INFO kablam! | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Nov 03 23:41:33.702 INFO kablam! Nov 03 23:41:33.702 INFO kablam! warning: unnecessary parentheses around `if` condition Nov 03 23:41:33.702 INFO kablam! --> src/main.rs:44:16 Nov 03 23:41:33.702 INFO kablam! | Nov 03 23:41:33.702 INFO kablam! 44 | if (items[i].quality < 50) Nov 03 23:41:33.703 INFO kablam! | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Nov 03 23:41:33.703 INFO kablam! Nov 03 23:41:33.703 INFO kablam! warning: unnecessary parentheses around `if` condition Nov 03 23:41:33.703 INFO kablam! --> src/main.rs:48:20 Nov 03 23:41:33.703 INFO kablam! | Nov 03 23:41:33.703 INFO kablam! 48 | if (items[i].name == "Backstage passes to a TAFKAL80ETC concert") Nov 03 23:41:33.703 INFO kablam! | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Nov 03 23:41:33.703 INFO kablam! Nov 03 23:41:33.704 INFO kablam! warning: unnecessary parentheses around `if` condition Nov 03 23:41:33.704 INFO kablam! --> src/main.rs:50:24 Nov 03 23:41:33.704 INFO kablam! | Nov 03 23:41:33.704 INFO kablam! 50 | if (items[i].sell_in < 11) Nov 03 23:41:33.704 INFO kablam! | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Nov 03 23:41:33.704 INFO kablam! Nov 03 23:41:33.704 INFO kablam! warning: unnecessary parentheses around `if` condition Nov 03 23:41:33.704 INFO kablam! --> src/main.rs:52:28 Nov 03 23:41:33.704 INFO kablam! | Nov 03 23:41:33.705 INFO kablam! 52 | if (items[i].quality < 50) Nov 03 23:41:33.705 INFO kablam! | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Nov 03 23:41:33.705 INFO kablam! Nov 03 23:41:33.705 INFO kablam! warning: unnecessary parentheses around `if` condition Nov 03 23:41:33.705 INFO kablam! --> src/main.rs:58:24 Nov 03 23:41:33.705 INFO kablam! | Nov 03 23:41:33.705 INFO kablam! 58 | if (items[i].sell_in < 6) Nov 03 23:41:33.705 INFO kablam! | ^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Nov 03 23:41:33.706 INFO kablam! Nov 03 23:41:33.711 INFO kablam! warning: unnecessary parentheses around `if` condition Nov 03 23:41:33.711 INFO kablam! --> src/main.rs:60:28 Nov 03 23:41:33.711 INFO kablam! | Nov 03 23:41:33.711 INFO kablam! 60 | if (items[i].quality < 50) Nov 03 23:41:33.711 INFO kablam! | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Nov 03 23:41:33.711 INFO kablam! Nov 03 23:41:33.711 INFO kablam! warning: unnecessary parentheses around `if` condition Nov 03 23:41:33.711 INFO kablam! --> src/main.rs:69:12 Nov 03 23:41:33.711 INFO kablam! | Nov 03 23:41:33.711 INFO kablam! 69 | if (items[i].name != "Sulfuras, Hand of Ragnaros") Nov 03 23:41:33.711 INFO kablam! | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Nov 03 23:41:33.711 INFO kablam! Nov 03 23:41:33.711 INFO kablam! warning: unnecessary parentheses around `if` condition Nov 03 23:41:33.711 INFO kablam! --> src/main.rs:74:12 Nov 03 23:41:33.711 INFO kablam! | Nov 03 23:41:33.711 INFO kablam! 74 | if (items[i].sell_in < 0) Nov 03 23:41:33.711 INFO kablam! | ^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Nov 03 23:41:33.711 INFO kablam! Nov 03 23:41:33.712 INFO kablam! warning: unnecessary parentheses around `if` condition Nov 03 23:41:33.712 INFO kablam! --> src/main.rs:76:16 Nov 03 23:41:33.712 INFO kablam! | Nov 03 23:41:33.712 INFO kablam! 76 | if (items[i].name != "Aged Brie") Nov 03 23:41:33.712 INFO kablam! | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Nov 03 23:41:33.712 INFO kablam! Nov 03 23:41:33.712 INFO kablam! warning: unnecessary parentheses around `if` condition Nov 03 23:41:33.712 INFO kablam! --> src/main.rs:78:20 Nov 03 23:41:33.712 INFO kablam! | Nov 03 23:41:33.712 INFO kablam! 78 | if (items[i].name != "Backstage passes to a TAFKAL80ETC concert") Nov 03 23:41:33.712 INFO kablam! | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Nov 03 23:41:33.712 INFO kablam! Nov 03 23:41:33.712 INFO kablam! warning: unnecessary parentheses around `if` condition Nov 03 23:41:33.712 INFO kablam! --> src/main.rs:80:24 Nov 03 23:41:33.712 INFO kablam! | Nov 03 23:41:33.712 INFO kablam! 80 | if (items[i].quality > 0) Nov 03 23:41:33.712 INFO kablam! | ^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Nov 03 23:41:33.712 INFO kablam! Nov 03 23:41:33.712 INFO kablam! warning: unnecessary parentheses around `if` condition Nov 03 23:41:33.713 INFO kablam! --> src/main.rs:82:28 Nov 03 23:41:33.713 INFO kablam! | Nov 03 23:41:33.713 INFO kablam! 82 | if (items[i].name != "Sulfuras, Hand of Ragnaros") Nov 03 23:41:33.713 INFO kablam! | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Nov 03 23:41:33.713 INFO kablam! Nov 03 23:41:33.713 INFO kablam! warning: unnecessary parentheses around `if` condition Nov 03 23:41:33.713 INFO kablam! --> src/main.rs:95:20 Nov 03 23:41:33.713 INFO kablam! | Nov 03 23:41:33.713 INFO kablam! 95 | if (items[i].quality < 50) Nov 03 23:41:33.713 INFO kablam! | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Nov 03 23:41:33.713 INFO kablam! Nov 03 23:41:33.718 INFO kablam! warning: unnecessary parentheses around `if` condition Nov 03 23:41:33.719 INFO kablam! --> src/main.rs:32:12 Nov 03 23:41:33.719 INFO kablam! | Nov 03 23:41:33.719 INFO kablam! 32 | if (items[i].name != "Aged Brie" && items[i].name != "Backstage passes to a TAFKAL80ETC concert") Nov 03 23:41:33.719 INFO kablam! | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Nov 03 23:41:33.719 INFO kablam! | Nov 03 23:41:33.719 INFO kablam! = note: #[warn(unused_parens)] on by default Nov 03 23:41:33.719 INFO kablam! Nov 03 23:41:33.719 INFO kablam! warning: unnecessary parentheses around `if` condition Nov 03 23:41:33.719 INFO kablam! --> src/main.rs:34:16 Nov 03 23:41:33.719 INFO kablam! | Nov 03 23:41:33.719 INFO kablam! 34 | if (items[i].quality > 0) Nov 03 23:41:33.719 INFO kablam! | ^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Nov 03 23:41:33.719 INFO kablam! Nov 03 23:41:33.719 INFO kablam! warning: unnecessary parentheses around `if` condition Nov 03 23:41:33.719 INFO kablam! --> src/main.rs:36:20 Nov 03 23:41:33.719 INFO kablam! | Nov 03 23:41:33.719 INFO kablam! 36 | if (items[i].name != "Sulfuras, Hand of Ragnaros") Nov 03 23:41:33.719 INFO kablam! | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Nov 03 23:41:33.719 INFO kablam! Nov 03 23:41:33.719 INFO kablam! warning: unnecessary parentheses around `if` condition Nov 03 23:41:33.719 INFO kablam! --> src/main.rs:44:16 Nov 03 23:41:33.720 INFO kablam! | Nov 03 23:41:33.720 INFO kablam! 44 | if (items[i].quality < 50) Nov 03 23:41:33.720 INFO kablam! | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Nov 03 23:41:33.720 INFO kablam! Nov 03 23:41:33.720 INFO kablam! warning: unnecessary parentheses around `if` condition Nov 03 23:41:33.720 INFO kablam! --> src/main.rs:48:20 Nov 03 23:41:33.720 INFO kablam! | Nov 03 23:41:33.720 INFO kablam! 48 | if (items[i].name == "Backstage passes to a TAFKAL80ETC concert") Nov 03 23:41:33.720 INFO kablam! | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Nov 03 23:41:33.720 INFO kablam! Nov 03 23:41:33.720 INFO kablam! warning: unnecessary parentheses around `if` condition Nov 03 23:41:33.720 INFO kablam! --> src/main.rs:50:24 Nov 03 23:41:33.720 INFO kablam! | Nov 03 23:41:33.720 INFO kablam! 50 | if (items[i].sell_in < 11) Nov 03 23:41:33.720 INFO kablam! | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Nov 03 23:41:33.720 INFO kablam! Nov 03 23:41:33.720 INFO kablam! warning: unnecessary parentheses around `if` condition Nov 03 23:41:33.720 INFO kablam! --> src/main.rs:52:28 Nov 03 23:41:33.720 INFO kablam! | Nov 03 23:41:33.720 INFO kablam! 52 | if (items[i].quality < 50) Nov 03 23:41:33.720 INFO kablam! | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Nov 03 23:41:33.721 INFO kablam! Nov 03 23:41:33.721 INFO kablam! warning: unnecessary parentheses around `if` condition Nov 03 23:41:33.721 INFO kablam! --> src/main.rs:58:24 Nov 03 23:41:33.721 INFO kablam! | Nov 03 23:41:33.721 INFO kablam! 58 | if (items[i].sell_in < 6) Nov 03 23:41:33.721 INFO kablam! | ^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Nov 03 23:41:33.721 INFO kablam! Nov 03 23:41:33.721 INFO kablam! warning: unnecessary parentheses around `if` condition Nov 03 23:41:33.721 INFO kablam! --> src/main.rs:60:28 Nov 03 23:41:33.721 INFO kablam! | Nov 03 23:41:33.721 INFO kablam! 60 | if (items[i].quality < 50) Nov 03 23:41:33.721 INFO kablam! | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Nov 03 23:41:33.721 INFO kablam! Nov 03 23:41:33.721 INFO kablam! warning: unnecessary parentheses around `if` condition Nov 03 23:41:33.721 INFO kablam! --> src/main.rs:69:12 Nov 03 23:41:33.721 INFO kablam! | Nov 03 23:41:33.721 INFO kablam! 69 | if (items[i].name != "Sulfuras, Hand of Ragnaros") Nov 03 23:41:33.721 INFO kablam! | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Nov 03 23:41:33.721 INFO kablam! Nov 03 23:41:33.721 INFO kablam! warning: unnecessary parentheses around `if` condition Nov 03 23:41:33.721 INFO kablam! --> src/main.rs:74:12 Nov 03 23:41:33.721 INFO kablam! | Nov 03 23:41:33.722 INFO kablam! 74 | if (items[i].sell_in < 0) Nov 03 23:41:33.722 INFO kablam! | ^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Nov 03 23:41:33.722 INFO kablam! Nov 03 23:41:33.722 INFO kablam! warning: unnecessary parentheses around `if` condition Nov 03 23:41:33.722 INFO kablam! --> src/main.rs:76:16 Nov 03 23:41:33.722 INFO kablam! | Nov 03 23:41:33.722 INFO kablam! 76 | if (items[i].name != "Aged Brie") Nov 03 23:41:33.722 INFO kablam! | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Nov 03 23:41:33.722 INFO kablam! Nov 03 23:41:33.722 INFO kablam! warning: unnecessary parentheses around `if` condition Nov 03 23:41:33.722 INFO kablam! --> src/main.rs:78:20 Nov 03 23:41:33.722 INFO kablam! | Nov 03 23:41:33.722 INFO kablam! 78 | if (items[i].name != "Backstage passes to a TAFKAL80ETC concert") Nov 03 23:41:33.722 INFO kablam! | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Nov 03 23:41:33.722 INFO kablam! Nov 03 23:41:33.722 INFO kablam! warning: unnecessary parentheses around `if` condition Nov 03 23:41:33.722 INFO kablam! --> src/main.rs:80:24 Nov 03 23:41:33.722 INFO kablam! | Nov 03 23:41:33.722 INFO kablam! 80 | if (items[i].quality > 0) Nov 03 23:41:33.722 INFO kablam! | ^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Nov 03 23:41:33.722 INFO kablam! Nov 03 23:41:33.722 INFO kablam! warning: unnecessary parentheses around `if` condition Nov 03 23:41:33.723 INFO kablam! --> src/main.rs:82:28 Nov 03 23:41:33.723 INFO kablam! | Nov 03 23:41:33.723 INFO kablam! 82 | if (items[i].name != "Sulfuras, Hand of Ragnaros") Nov 03 23:41:33.723 INFO kablam! | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Nov 03 23:41:33.723 INFO kablam! Nov 03 23:41:33.730 INFO kablam! warning: unnecessary parentheses around `if` condition Nov 03 23:41:33.730 INFO kablam! --> src/main.rs:95:20 Nov 03 23:41:33.730 INFO kablam! | Nov 03 23:41:33.730 INFO kablam! 95 | if (items[i].quality < 50) Nov 03 23:41:33.730 INFO kablam! | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Nov 03 23:41:33.730 INFO kablam! Nov 03 23:41:33.780 INFO kablam! warning: function `UpdateQuality` should have a snake case name such as `update_quality` Nov 03 23:41:33.780 INFO kablam! --> src/main.rs:28:1 Nov 03 23:41:33.780 INFO kablam! | Nov 03 23:41:33.780 INFO kablam! 28 | / fn UpdateQuality(items: &mut [Item]) Nov 03 23:41:33.780 INFO kablam! 29 | | { Nov 03 23:41:33.780 INFO kablam! 30 | | for i in 0..items.len() Nov 03 23:41:33.780 INFO kablam! 31 | | { Nov 03 23:41:33.780 INFO kablam! ... | Nov 03 23:41:33.780 INFO kablam! 101 | | } Nov 03 23:41:33.780 INFO kablam! 102 | | } Nov 03 23:41:33.780 INFO kablam! | |_^ Nov 03 23:41:33.780 INFO kablam! | Nov 03 23:41:33.780 INFO kablam! = note: #[warn(non_snake_case)] on by default Nov 03 23:41:33.780 INFO kablam! Nov 03 23:41:33.879 INFO kablam! warning: function `UpdateQuality` should have a snake case name such as `update_quality` Nov 03 23:41:33.879 INFO kablam! --> src/main.rs:28:1 Nov 03 23:41:33.879 INFO kablam! | Nov 03 23:41:33.879 INFO kablam! 28 | / fn UpdateQuality(items: &mut [Item]) Nov 03 23:41:33.879 INFO kablam! 29 | | { Nov 03 23:41:33.879 INFO kablam! 30 | | for i in 0..items.len() Nov 03 23:41:33.879 INFO kablam! 31 | | { Nov 03 23:41:33.879 INFO kablam! ... | Nov 03 23:41:33.879 INFO kablam! 101 | | } Nov 03 23:41:33.879 INFO kablam! 102 | | } Nov 03 23:41:33.879 INFO kablam! | |_^ Nov 03 23:41:33.879 INFO kablam! | Nov 03 23:41:33.879 INFO kablam! = note: #[warn(non_snake_case)] on by default Nov 03 23:41:33.879 INFO kablam! Nov 03 23:41:33.924 INFO kablam! Finished dev [unoptimized + debuginfo] target(s) in 0.75s Nov 03 23:41:33.926 INFO kablam! su: No module specific data is present Nov 03 23:41:34.843 INFO running `"docker" "rm" "-f" "bca85e7eec76d6809a433db14aa87f18de4a839c9d0cc109eaa1a14e8cb8fda3"` Nov 03 23:41:35.151 INFO blam! bca85e7eec76d6809a433db14aa87f18de4a839c9d0cc109eaa1a14e8cb8fda3