Nov 09 05:48:50.520 INFO checking saterus/gilded-rose-rust against master#653da4fd006c97625247acd7e076d0782cdc149b for pr-55632 Nov 09 05:48:50.520 INFO running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/pr-55632/worker-2/master#653da4fd006c97625247acd7e076d0782cdc149b:/target:rw,Z" "-v" "/mnt/big/crater/work/local/test-source/worker-2/pr-55632/master#653da4fd006c97625247acd7e076d0782cdc149b:/source:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/source" "-e" "USER_ID=1000" "-e" "CMD=cargo +653da4fd006c97625247acd7e076d0782cdc149b-alt check --frozen --all --all-targets" "-e" "CARGO_TARGET_DIR=/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/cargo-home" "-e" "RUSTUP_HOME=/rustup-home" "-m" "1536M" "--network" "none" "crater"` Nov 09 05:48:50.706 INFO blam! b14ce7bc351015c9f5fbdfbf2baa1c55685d6309523d374c138d1b561b37173b Nov 09 05:48:50.708 INFO running `"docker" "start" "-a" "b14ce7bc351015c9f5fbdfbf2baa1c55685d6309523d374c138d1b561b37173b"` Nov 09 05:48:51.426 INFO kablam! usermod: no changes Nov 09 05:48:51.463 INFO kablam! Checking gilded_rose v0.1.0 (/source) Nov 09 05:48:52.299 INFO kablam! warning: unnecessary parentheses around `if` condition Nov 09 05:48:52.299 INFO kablam! --> src/main.rs:32:12 Nov 09 05:48:52.300 INFO kablam! | Nov 09 05:48:52.301 INFO kablam! 32 | if (items[i].name != "Aged Brie" && items[i].name != "Backstage passes to a TAFKAL80ETC concert") Nov 09 05:48:52.301 INFO kablam! | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Nov 09 05:48:52.302 INFO kablam! | Nov 09 05:48:52.302 INFO kablam! = note: #[warn(unused_parens)] on by default Nov 09 05:48:52.302 INFO kablam! Nov 09 05:48:52.303 INFO kablam! warning: unnecessary parentheses around `if` condition Nov 09 05:48:52.303 INFO kablam! --> src/main.rs:34:16 Nov 09 05:48:52.304 INFO kablam! | Nov 09 05:48:52.304 INFO kablam! 34 | if (items[i].quality > 0) Nov 09 05:48:52.305 INFO kablam! | ^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Nov 09 05:48:52.305 INFO kablam! Nov 09 05:48:52.306 INFO kablam! warning: unnecessary parentheses around `if` condition Nov 09 05:48:52.306 INFO kablam! --> src/main.rs:36:20 Nov 09 05:48:52.307 INFO kablam! | Nov 09 05:48:52.307 INFO kablam! 36 | if (items[i].name != "Sulfuras, Hand of Ragnaros") Nov 09 05:48:52.308 INFO kablam! | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Nov 09 05:48:52.308 INFO kablam! Nov 09 05:48:52.308 INFO kablam! warning: unnecessary parentheses around `if` condition Nov 09 05:48:52.308 INFO kablam! --> src/main.rs:44:16 Nov 09 05:48:52.309 INFO kablam! | Nov 09 05:48:52.309 INFO kablam! 44 | if (items[i].quality < 50) Nov 09 05:48:52.309 INFO kablam! | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Nov 09 05:48:52.309 INFO kablam! Nov 09 05:48:52.309 INFO kablam! warning: unnecessary parentheses around `if` condition Nov 09 05:48:52.310 INFO kablam! --> src/main.rs:48:20 Nov 09 05:48:52.310 INFO kablam! | Nov 09 05:48:52.310 INFO kablam! 48 | if (items[i].name == "Backstage passes to a TAFKAL80ETC concert") Nov 09 05:48:52.310 INFO kablam! | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Nov 09 05:48:52.310 INFO kablam! Nov 09 05:48:52.310 INFO kablam! warning: unnecessary parentheses around `if` condition Nov 09 05:48:52.310 INFO kablam! --> src/main.rs:50:24 Nov 09 05:48:52.310 INFO kablam! | Nov 09 05:48:52.310 INFO kablam! 50 | if (items[i].sell_in < 11) Nov 09 05:48:52.310 INFO kablam! | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Nov 09 05:48:52.310 INFO kablam! Nov 09 05:48:52.310 INFO kablam! warning: unnecessary parentheses around `if` condition Nov 09 05:48:52.310 INFO kablam! --> src/main.rs:52:28 Nov 09 05:48:52.310 INFO kablam! | Nov 09 05:48:52.310 INFO kablam! 52 | if (items[i].quality < 50) Nov 09 05:48:52.310 INFO kablam! | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Nov 09 05:48:52.310 INFO kablam! Nov 09 05:48:52.310 INFO kablam! warning: unnecessary parentheses around `if` condition Nov 09 05:48:52.310 INFO kablam! --> src/main.rs:58:24 Nov 09 05:48:52.310 INFO kablam! | Nov 09 05:48:52.310 INFO kablam! 58 | if (items[i].sell_in < 6) Nov 09 05:48:52.310 INFO kablam! | ^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Nov 09 05:48:52.310 INFO kablam! Nov 09 05:48:52.310 INFO kablam! warning: unnecessary parentheses around `if` condition Nov 09 05:48:52.310 INFO kablam! --> src/main.rs:60:28 Nov 09 05:48:52.310 INFO kablam! | Nov 09 05:48:52.313 INFO kablam! 60 | if (items[i].quality < 50) Nov 09 05:48:52.313 INFO kablam! | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Nov 09 05:48:52.314 INFO kablam! Nov 09 05:48:52.314 INFO kablam! warning: unnecessary parentheses around `if` condition Nov 09 05:48:52.314 INFO kablam! --> src/main.rs:69:12 Nov 09 05:48:52.314 INFO kablam! | Nov 09 05:48:52.314 INFO kablam! 69 | if (items[i].name != "Sulfuras, Hand of Ragnaros") Nov 09 05:48:52.314 INFO kablam! | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Nov 09 05:48:52.314 INFO kablam! Nov 09 05:48:52.314 INFO kablam! warning: unnecessary parentheses around `if` condition Nov 09 05:48:52.314 INFO kablam! --> src/main.rs:74:12 Nov 09 05:48:52.314 INFO kablam! | Nov 09 05:48:52.314 INFO kablam! 74 | if (items[i].sell_in < 0) Nov 09 05:48:52.314 INFO kablam! | ^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Nov 09 05:48:52.314 INFO kablam! Nov 09 05:48:52.314 INFO kablam! warning: unnecessary parentheses around `if` condition Nov 09 05:48:52.314 INFO kablam! --> src/main.rs:76:16 Nov 09 05:48:52.314 INFO kablam! | Nov 09 05:48:52.314 INFO kablam! 76 | if (items[i].name != "Aged Brie") Nov 09 05:48:52.314 INFO kablam! | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Nov 09 05:48:52.314 INFO kablam! Nov 09 05:48:52.314 INFO kablam! warning: unnecessary parentheses around `if` condition Nov 09 05:48:52.314 INFO kablam! --> src/main.rs:78:20 Nov 09 05:48:52.314 INFO kablam! | Nov 09 05:48:52.314 INFO kablam! 78 | if (items[i].name != "Backstage passes to a TAFKAL80ETC concert") Nov 09 05:48:52.314 INFO kablam! | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Nov 09 05:48:52.314 INFO kablam! Nov 09 05:48:52.314 INFO kablam! warning: unnecessary parentheses around `if` condition Nov 09 05:48:52.314 INFO kablam! --> src/main.rs:80:24 Nov 09 05:48:52.314 INFO kablam! | Nov 09 05:48:52.314 INFO kablam! 80 | if (items[i].quality > 0) Nov 09 05:48:52.314 INFO kablam! | ^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Nov 09 05:48:52.314 INFO kablam! Nov 09 05:48:52.314 INFO kablam! warning: unnecessary parentheses around `if` condition Nov 09 05:48:52.314 INFO kablam! --> src/main.rs:82:28 Nov 09 05:48:52.314 INFO kablam! | Nov 09 05:48:52.315 INFO kablam! 82 | if (items[i].name != "Sulfuras, Hand of Ragnaros") Nov 09 05:48:52.315 INFO kablam! | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Nov 09 05:48:52.315 INFO kablam! Nov 09 05:48:52.315 INFO kablam! warning: unnecessary parentheses around `if` condition Nov 09 05:48:52.315 INFO kablam! --> src/main.rs:95:20 Nov 09 05:48:52.315 INFO kablam! | Nov 09 05:48:52.315 INFO kablam! 95 | if (items[i].quality < 50) Nov 09 05:48:52.315 INFO kablam! | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Nov 09 05:48:52.315 INFO kablam! Nov 09 05:48:52.375 INFO kablam! warning: unnecessary parentheses around `if` condition Nov 09 05:48:52.375 INFO kablam! --> src/main.rs:32:12 Nov 09 05:48:52.375 INFO kablam! | Nov 09 05:48:52.375 INFO kablam! 32 | if (items[i].name != "Aged Brie" && items[i].name != "Backstage passes to a TAFKAL80ETC concert") Nov 09 05:48:52.375 INFO kablam! | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Nov 09 05:48:52.375 INFO kablam! | Nov 09 05:48:52.375 INFO kablam! = note: #[warn(unused_parens)] on by default Nov 09 05:48:52.375 INFO kablam! Nov 09 05:48:52.375 INFO kablam! warning: unnecessary parentheses around `if` condition Nov 09 05:48:52.375 INFO kablam! --> src/main.rs:34:16 Nov 09 05:48:52.375 INFO kablam! | Nov 09 05:48:52.375 INFO kablam! 34 | if (items[i].quality > 0) Nov 09 05:48:52.375 INFO kablam! | ^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Nov 09 05:48:52.375 INFO kablam! Nov 09 05:48:52.375 INFO kablam! warning: unnecessary parentheses around `if` condition Nov 09 05:48:52.375 INFO kablam! --> src/main.rs:36:20 Nov 09 05:48:52.375 INFO kablam! | Nov 09 05:48:52.375 INFO kablam! 36 | if (items[i].name != "Sulfuras, Hand of Ragnaros") Nov 09 05:48:52.375 INFO kablam! | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Nov 09 05:48:52.375 INFO kablam! Nov 09 05:48:52.375 INFO kablam! warning: unnecessary parentheses around `if` condition Nov 09 05:48:52.375 INFO kablam! --> src/main.rs:44:16 Nov 09 05:48:52.375 INFO kablam! | Nov 09 05:48:52.375 INFO kablam! 44 | if (items[i].quality < 50) Nov 09 05:48:52.383 INFO kablam! | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Nov 09 05:48:52.383 INFO kablam! Nov 09 05:48:52.383 INFO kablam! warning: unnecessary parentheses around `if` condition Nov 09 05:48:52.383 INFO kablam! --> src/main.rs:48:20 Nov 09 05:48:52.383 INFO kablam! | Nov 09 05:48:52.383 INFO kablam! 48 | if (items[i].name == "Backstage passes to a TAFKAL80ETC concert") Nov 09 05:48:52.383 INFO kablam! | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Nov 09 05:48:52.383 INFO kablam! Nov 09 05:48:52.383 INFO kablam! warning: unnecessary parentheses around `if` condition Nov 09 05:48:52.383 INFO kablam! --> src/main.rs:50:24 Nov 09 05:48:52.383 INFO kablam! | Nov 09 05:48:52.383 INFO kablam! 50 | if (items[i].sell_in < 11) Nov 09 05:48:52.384 INFO kablam! | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Nov 09 05:48:52.385 INFO kablam! Nov 09 05:48:52.385 INFO kablam! warning: unnecessary parentheses around `if` condition Nov 09 05:48:52.385 INFO kablam! --> src/main.rs:52:28 Nov 09 05:48:52.385 INFO kablam! | Nov 09 05:48:52.385 INFO kablam! 52 | if (items[i].quality < 50) Nov 09 05:48:52.385 INFO kablam! | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Nov 09 05:48:52.385 INFO kablam! Nov 09 05:48:52.385 INFO kablam! warning: unnecessary parentheses around `if` condition Nov 09 05:48:52.385 INFO kablam! --> src/main.rs:58:24 Nov 09 05:48:52.385 INFO kablam! | Nov 09 05:48:52.385 INFO kablam! 58 | if (items[i].sell_in < 6) Nov 09 05:48:52.385 INFO kablam! | ^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Nov 09 05:48:52.385 INFO kablam! Nov 09 05:48:52.385 INFO kablam! warning: unnecessary parentheses around `if` condition Nov 09 05:48:52.385 INFO kablam! --> src/main.rs:60:28 Nov 09 05:48:52.385 INFO kablam! | Nov 09 05:48:52.385 INFO kablam! 60 | if (items[i].quality < 50) Nov 09 05:48:52.385 INFO kablam! | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Nov 09 05:48:52.385 INFO kablam! Nov 09 05:48:52.385 INFO kablam! warning: unnecessary parentheses around `if` condition Nov 09 05:48:52.385 INFO kablam! --> src/main.rs:69:12 Nov 09 05:48:52.385 INFO kablam! | Nov 09 05:48:52.385 INFO kablam! 69 | if (items[i].name != "Sulfuras, Hand of Ragnaros") Nov 09 05:48:52.385 INFO kablam! | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Nov 09 05:48:52.385 INFO kablam! Nov 09 05:48:52.385 INFO kablam! warning: unnecessary parentheses around `if` condition Nov 09 05:48:52.385 INFO kablam! --> src/main.rs:74:12 Nov 09 05:48:52.385 INFO kablam! | Nov 09 05:48:52.385 INFO kablam! 74 | if (items[i].sell_in < 0) Nov 09 05:48:52.385 INFO kablam! | ^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Nov 09 05:48:52.385 INFO kablam! Nov 09 05:48:52.385 INFO kablam! warning: unnecessary parentheses around `if` condition Nov 09 05:48:52.385 INFO kablam! --> src/main.rs:76:16 Nov 09 05:48:52.385 INFO kablam! | Nov 09 05:48:52.385 INFO kablam! 76 | if (items[i].name != "Aged Brie") Nov 09 05:48:52.385 INFO kablam! | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Nov 09 05:48:52.385 INFO kablam! Nov 09 05:48:52.385 INFO kablam! warning: unnecessary parentheses around `if` condition Nov 09 05:48:52.385 INFO kablam! --> src/main.rs:78:20 Nov 09 05:48:52.385 INFO kablam! | Nov 09 05:48:52.385 INFO kablam! 78 | if (items[i].name != "Backstage passes to a TAFKAL80ETC concert") Nov 09 05:48:52.385 INFO kablam! | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Nov 09 05:48:52.385 INFO kablam! Nov 09 05:48:52.385 INFO kablam! warning: unnecessary parentheses around `if` condition Nov 09 05:48:52.385 INFO kablam! --> src/main.rs:80:24 Nov 09 05:48:52.385 INFO kablam! | Nov 09 05:48:52.385 INFO kablam! 80 | if (items[i].quality > 0) Nov 09 05:48:52.385 INFO kablam! | ^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Nov 09 05:48:52.385 INFO kablam! Nov 09 05:48:52.385 INFO kablam! warning: unnecessary parentheses around `if` condition Nov 09 05:48:52.385 INFO kablam! --> src/main.rs:82:28 Nov 09 05:48:52.385 INFO kablam! | Nov 09 05:48:52.385 INFO kablam! 82 | if (items[i].name != "Sulfuras, Hand of Ragnaros") Nov 09 05:48:52.385 INFO kablam! | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Nov 09 05:48:52.386 INFO kablam! Nov 09 05:48:52.386 INFO kablam! warning: unnecessary parentheses around `if` condition Nov 09 05:48:52.386 INFO kablam! --> src/main.rs:95:20 Nov 09 05:48:52.386 INFO kablam! | Nov 09 05:48:52.386 INFO kablam! 95 | if (items[i].quality < 50) Nov 09 05:48:52.386 INFO kablam! | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Nov 09 05:48:52.386 INFO kablam! Nov 09 05:48:52.428 INFO kablam! warning: function `UpdateQuality` should have a snake case name such as `update_quality` Nov 09 05:48:52.428 INFO kablam! --> src/main.rs:28:1 Nov 09 05:48:52.428 INFO kablam! | Nov 09 05:48:52.429 INFO kablam! 28 | / fn UpdateQuality(items: &mut [Item]) Nov 09 05:48:52.429 INFO kablam! 29 | | { Nov 09 05:48:52.429 INFO kablam! 30 | | for i in 0..items.len() Nov 09 05:48:52.429 INFO kablam! 31 | | { Nov 09 05:48:52.429 INFO kablam! ... | Nov 09 05:48:52.429 INFO kablam! 101 | | } Nov 09 05:48:52.429 INFO kablam! 102 | | } Nov 09 05:48:52.429 INFO kablam! | |_^ Nov 09 05:48:52.429 INFO kablam! | Nov 09 05:48:52.429 INFO kablam! = note: #[warn(non_snake_case)] on by default Nov 09 05:48:52.429 INFO kablam! Nov 09 05:48:52.523 INFO kablam! warning: function `UpdateQuality` should have a snake case name such as `update_quality` Nov 09 05:48:52.523 INFO kablam! --> src/main.rs:28:1 Nov 09 05:48:52.523 INFO kablam! | Nov 09 05:48:52.523 INFO kablam! 28 | / fn UpdateQuality(items: &mut [Item]) Nov 09 05:48:52.523 INFO kablam! 29 | | { Nov 09 05:48:52.523 INFO kablam! 30 | | for i in 0..items.len() Nov 09 05:48:52.523 INFO kablam! 31 | | { Nov 09 05:48:52.523 INFO kablam! ... | Nov 09 05:48:52.523 INFO kablam! 101 | | } Nov 09 05:48:52.523 INFO kablam! 102 | | } Nov 09 05:48:52.523 INFO kablam! | |_^ Nov 09 05:48:52.523 INFO kablam! | Nov 09 05:48:52.523 INFO kablam! = note: #[warn(non_snake_case)] on by default Nov 09 05:48:52.523 INFO kablam! Nov 09 05:48:52.551 INFO kablam! Finished dev [unoptimized + debuginfo] target(s) in 1.11s Nov 09 05:48:52.555 INFO kablam! su: No module specific data is present Nov 09 05:48:53.671 INFO running `"docker" "rm" "-f" "b14ce7bc351015c9f5fbdfbf2baa1c55685d6309523d374c138d1b561b37173b"` Nov 09 05:48:54.021 INFO blam! b14ce7bc351015c9f5fbdfbf2baa1c55685d6309523d374c138d1b561b37173b